From nobody Tue Jun 16 03:47:17 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFCDA33E34C for ; Wed, 15 Apr 2026 18:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776278445; cv=none; b=YcC+MEgzsVlGMrip/VZUpZ9tMJQI05btmLVsUYGw5dHn7isQDOfFI5RXzTLVVwRcgYd50Ur/9cTIn57I0v/SweJ0oIXyrVTSJ0BiND0tOMw+BzUrBgeogEFXSvWSXY3NVP9wTbKMUIqN3ibjKY3HOAQbS79shpKzsUHQwVcVmuI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776278445; c=relaxed/simple; bh=QTClQs6mmg0+2IOvek0wnn6CLbm5OoS03YkOeSOb5Yc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KGzzHrdmgIWtpScEJsX/dh13Wr/By0xLzviYklW5fltG9+GqPf2FlJZIJtevBzJAAVSM9hMiBTg+/2Xfm8P48q0elupLyNsggj+g+y9z8CoGgo54+FqShyXkWtrACLVVhrUcYEl2R0RtRZRDdEfDv+2Z3KKhU2PIoSj31/+2adM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VgfbSy/N; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VgfbSy/N" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-35d971fb6f1so5903496a91.0 for ; Wed, 15 Apr 2026 11:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776278443; x=1776883243; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QuK475K92RErA2NVtS79BUBslHILtmYa6Vn0sllo80U=; b=VgfbSy/N14OjPL7MYzhlnX/7++SZ7c3zbRvb+D1n2vysOJ9UjlPBswCNXyFmr+QzmC L1XDwQJTanqkGs0Jivjmmi7vhqDIH4m77df630eghFmZXlNqRtwCiyECHGqPLMRPb4Bx d5hRwYA30xcnGaKZ5YiS6EX6sdeVT3b6MSnaT4ZqQaseQaAjelinu/OKjxIG5ow5Y7W6 yVN84FhLbiVGQQqQxVdml7qDuEV5Tv0b8bmBz+pMRSjqcJAwVuau6CK2zlRBei6uc341 1IgwZGBR4+4/O+Kn3F5hV2kv9sYg7zE3n6S+Wpvh73Wpp6MBTXVmr/gUXiyV39LsUX+r abSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776278443; x=1776883243; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QuK475K92RErA2NVtS79BUBslHILtmYa6Vn0sllo80U=; b=f5DUSyCXz6GuBVrnsccQCe/jn2r/eQG6gPwKi140EuHovVKYC+9CzXZBUSMwNXvDfM Vtxl1ONm0LKf5vIHNHmDDCIyJYHurK1+ntye5VJ4GFZ7G1MOR+1uBaVmrh8KWSCnSBHY l9h/7eoKcmgF9BlapgnAVNnsrgKBAGHaGetwV3KFy8rUcaUcO5BGZD680HI5rsOVn/fK uP38QEfVITNxtzcDE9UbqN3Dr14nZAuRlMfot8hkIyK35XSb13Fb0lkQjhMYlGmpV+fm lhfJQGGFelWjfqGS3E9+sKOAnr09AzUraulQPT6yYQi7/r3FOrJv3nu69QCHM4WjJQXi BC4A== X-Forwarded-Encrypted: i=1; AFNElJ8TMmxpZfJ1TiZItDYcyuXlrR2gPjmw9ilOe0kM+fh1kW8wqOaiCsALyhJD6/zgoqs+k3Tm8YsVxTZwFTo=@vger.kernel.org X-Gm-Message-State: AOJu0YxAt7QIJ4pPE7LZYe99fFFcgG+a2mrMLLEljRvmjdJISZAq5w8a zsjSmwT1avbj8WckASb/pan6zvG7of4B57ZBCnWvuDC4PUjvFMLMZY+O X-Gm-Gg: AeBDietK2H7eYjmBQAILqjMRdW1RSpDZUn6wNIsiSH9G6A0LUVHwbJoe5Tj7tBikmrs L3AQh1Naqs8QWW34CRfEBIX3dvIvYmh0ywKmnaxiiRaek7f6HGzm3/zADSfefjZHNR6+ut6n/Xc h4TN1mnwvRftQM7v41r+xOUBJu0T7W0NgVfIrDDG4kAOG6jv6S3ea6ae4D3K3pSI7qTVljK+pE9 JKSnrm9q+yCcuxW2BLwquZmYFyGum0FGmfm2L7lRAsA46JymsOmsZG/E99BlaVGYFQ4GAvllU64 A7v57uCC3IwbWg5ITN0fJdeOOEF8DfTjaZ0swARemejX8y/kc/iYaKbK0TBISpvF+L2Ld4cuGvo 5KdTkVq9ErS/4RF4xhhJJbKkt3NGqtM4fWOKzSPoecu/MWuxs+QB4Pc/ieVOM0hxezQh5JmS37B HqGgRDUSFGCgHnF2vxv3rpSnWScoN3AYVHdT0= X-Received: by 2002:a17:903:985:b0:2b0:ac1e:973a with SMTP id d9443c01a7336-2b2d5a64770mr229004475ad.39.1776278443284; Wed, 15 Apr 2026 11:40:43 -0700 (PDT) Received: from lgs.. ([2409:893d:1171:10e2:93ee:194:b07d:a9b2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b4780ef736sm38289825ad.8.2026.04.15.11.40.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 11:40:42 -0700 (PDT) From: Guangshuo Li To: Greg Kroah-Hartman , Jiri Slaby , Guangshuo Li , Paul B Schroeder , Andrew Morton , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] serial: 8250_exar_st16c554: fix reference leak on failed device registration Date: Thu, 16 Apr 2026 02:40:31 +0800 Message-ID: <20260415184032.3776292-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in exar_init(), the embedded struct device in exar_device has already been initialized by device_initialize(), but the failure path returns the error without dropping the device reference for the current platform device: exar_init() -> platform_device_register(&exar_device) -> device_initialize(&exar_device.dev) -> setup_pdev_dma_masks(&exar_device) -> platform_device_add(&exar_device) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before returning the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: e0980dafa329d ("[PATCH] Exar quad port serial") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/tty/serial/8250/8250_exar_st16c554.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_exar_st16c554.c b/drivers/tty/ser= ial/8250/8250_exar_st16c554.c index 933811ebfaac..b2c37f0c52aa 100644 --- a/drivers/tty/serial/8250/8250_exar_st16c554.c +++ b/drivers/tty/serial/8250/8250_exar_st16c554.c @@ -30,7 +30,13 @@ static struct platform_device exar_device =3D { =20 static int __init exar_init(void) { - return platform_device_register(&exar_device); + int ret; + + ret =3D platform_device_register(&exar_device); + if (ret) + platform_device_put(&exar_device); + + return ret; } =20 module_init(exar_init); --=20 2.43.0