From nobody Tue Jun 16 03:47:17 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84F523803F5 for ; Wed, 15 Apr 2026 18:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776278288; cv=none; b=rEl05hAaiAGmIzmYY9nMzKBFEBmslADK9UV4GhPd12M86CaMruIF8FZ72W0Q/QcE2GtEcQW8IkxRBKXE/nzRxL6ixWy/9i0Xf9ln6tKLjW+tWY48iYZgy3yGVL59HKEPl3+yo89Z9UgQcYZwG8JAaZgjXYUocr8DQYV4P+k2p2U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776278288; c=relaxed/simple; bh=9RSII71/jNnvAOcFmcfnWZ0Y9rCchJepmkQZ7efG4JA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nMfFiiTGaC/uy54FRtQ9gKnS1kPa46zRfkEWMR6kBcTRnmh6+NJhsqDPMDoqs+nJ8a246rVaWySbxC+lKrOVeT2riN4Xa1koR1OIzPmOc3oqnKsXmBN//PLbB8KSipJKGDLfCWmVqiee6bgpH7eeOBD3kNCFX1e2Cgn9Po3eU7U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JgMkqVhp; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JgMkqVhp" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c741692db4cso2029361a12.1 for ; Wed, 15 Apr 2026 11:38:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776278287; x=1776883087; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Q4ZTI/wYqnqWn46+oi6fQh//I+QeN1uMmyxPHBv5EkQ=; b=JgMkqVhpgm3LLmArRPiCLbO6vyal9M0LC5x287tYgUigKrwzYQK3iItVFr1xHrf6nj 6BqEQ4wlxRxdg5uqj1+4x4XeCwdqdOb8Cp252usHezcwIT7ZOKFa5lP051lZ5gOkFXhN o8KT1MHCNeJS7FzGGN9329bdJfeL3HiiDkyj1WCo1ds3lAM43E/a5o9kCgxtPOrztMyS do59b2j2W6HR/igAyp9nT5uRh7KcOhAIQxuVf9D44atThGH20yHU9+wxbKuhyPlLF0BI 5N7EdCvFur+G4a8zJMawlw+0vtR+PkQsuE73UPUQA50QNbyTGOinkFOrX66vj7vYgxfL KweQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776278287; x=1776883087; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q4ZTI/wYqnqWn46+oi6fQh//I+QeN1uMmyxPHBv5EkQ=; b=iVw1xkgvt2NEmBll3Fud8JVm+q5xZieh0oz7XBIO8OZgob4Vec8SxpvqwpW1dJZwN6 8KvtlH1f3sMfQtNYLkzMo2vmMD2RSv/s6Nj26ySgnGxoBRKxeqQoaB1+UBjPVOBlrzLt XBBV8llnvvnotKO1R8+YkxxE/Lk1n4HOcZgBB6wNrK2WIjxTrdQittA3aavWRGSyY9Ku 9/U4OYtYrAjzw0clUBDzeiDURmliySuG1KVLWNbDPm6hI3LdCvAPo7xep82y6TI0YMaE +k8VdnIraJr5/IQVHDEjvg2PlV9d461+dcwCXgOF1gGyT6/aFZ91iEqeV6eq6qjzLxxi v97w== X-Forwarded-Encrypted: i=1; AFNElJ8u6DeKLCxFqMWACrDxK2QwdMU4gCQ6dDBXE+g4F1RO2sLjERwZ+IAXGsX5oAqEM0qaaxYTONTIyUnWHp4=@vger.kernel.org X-Gm-Message-State: AOJu0YxDqILe1TSNPKmmXdYDWLO7A8yURAwfBHox5lIMXCgSsRE6aVIS wGzhRg9qtZwOheXzZFXXw7xVTDiULP9BcvMUaV3CrBx0IvStT3cOE4mt X-Gm-Gg: AeBDievQrspSxkr8OI1KU8UoT/zobRayejkJ48HC4CZbrCeAHSnIZ0KghxmA6NgedCF R522zsE9DeciWBgkiLI1uKkGk2nAWNbCtOttfz7xnwS7dvewLYqxJfXQehLF2q7uN23q4Ozvpj+ I+B8V5yPRZNKSsalv5RvXsOWs9TCDpFhcMRTLB+oA5rhH5c8BDJB3f5PBIiQ8l4WnKQFv69w9m0 EAZG2hLWSY95aXsWm870G8dc2U1Klc/AFznlvXeokGRJ00CFmJDByrALp8pqtmqD/4GhnLuDUp1 Ukla6fni8YD4I+3CZ9PVLJUzSwtKgvnKP6LYh3J7Kg47s/p/jQVMUcfPea5RMBFkHzguuSJPc4/ e0Y6YLpatKBf/FiECdIdKOlKGBwZtOa9AQ43MHhhwj0YF+zQdA0ZGeibVqKMcHrwdnr6GFFo56k WtWcFY6CWpoxYRi29pOUQlHMtm3Md7QxlCdnw= X-Received: by 2002:a05:6a21:6da0:b0:39b:8e94:c4b2 with SMTP id adf61e73a8af0-3a06d17e69cmr551491637.12.1776278286823; Wed, 15 Apr 2026 11:38:06 -0700 (PDT) Received: from lgs.. ([2409:893d:1171:10e2:93ee:194:b07d:a9b2]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f6707b717sm2546151b3a.21.2026.04.15.11.38.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 11:38:06 -0700 (PDT) From: Guangshuo Li To: Greg Kroah-Hartman , Jiri Slaby , Guangshuo Li , Russell King , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] serial: 8250_boca: fix reference leak on failed device registration Date: Thu, 16 Apr 2026 02:37:55 +0800 Message-ID: <20260415183756.3770073-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in boca_init(), the embedded struct device in boca_device has already been initialized by device_initialize(), but the failure path returns the error without dropping the device reference for the current platform device: boca_init() -> platform_device_register(&boca_device) -> device_initialize(&boca_device.dev) -> setup_pdev_dma_masks(&boca_device) -> platform_device_add(&boca_device) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before returning the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: ec9f47cd6a14c ("[PATCH] Serial: Split 8250 port table") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/tty/serial/8250/8250_boca.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_boca.c b/drivers/tty/serial/8250/= 8250_boca.c index a9b97c034653..70ea8e30ae80 100644 --- a/drivers/tty/serial/8250/8250_boca.c +++ b/drivers/tty/serial/8250/8250_boca.c @@ -39,7 +39,13 @@ static struct platform_device boca_device =3D { =20 static int __init boca_init(void) { - return platform_device_register(&boca_device); + int ret; + + ret =3D platform_device_register(&boca_device); + if (ret) + platform_device_put(&boca_device); + + return ret; } =20 module_init(boca_init); --=20 2.43.0