From nobody Tue Jun 16 03:47:17 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D0613EDAA6 for ; Wed, 15 Apr 2026 18:16:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776277011; cv=none; b=muxoRtN2Xfamk8dk4CouqnL5jR+dg/VDSHuDYr5o4bJCsSSL0yzASZCXrggx1LRe1CCAgHzZM6qyfd4bE94O/cruUrNuEnq6NQeW0UN4JuWe1HDUAfn25LGBOcHxGjpMqFIhUCjgxVoTmVYPHKhIHucFbBnyfj+1H3idYWhtslo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776277011; c=relaxed/simple; bh=IxFWJtxRv8Mb1+aNXHRQ1gqmj1hf8SCvhG9tk0JJCtc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=M0HBjrCazrqKNaYbg/mh9AzcnOlRB/rCWxn2OKLVdBHeguxYhx19PftColXnyTr2NIbV46G+MUutZSl344hKtY08f31rgBf1YDjL0BAGcW6LKVu0FNOL0sRx0x+1YZwkACmdxkYxJVzIXdizAsXHVGodsdYSNECoLCGW42eTyBE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fKGqc8QD; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fKGqc8QD" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-82f5dc076ddso1230725b3a.0 for ; Wed, 15 Apr 2026 11:16:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776277009; x=1776881809; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UkSMnGatsFIe6PvZFudhYv/NcAOEkU0FsMM0HKaHQTQ=; b=fKGqc8QDrR9ctjyjYgh7a0jFE1uggRjU2JtWpGTug9VodR49QQ7Ey3m4VfIIwN8KsR RTUkhWGpXVUGqNQFJ/7B3jluuzkDz/iTfAT3SM6FuMdwmjHx2oOdB/RpqrWaDjtVgvay rKnAd1NAmNllZg7z2mcAJ4ML9LNkIkS/pA/T0qgG6AuReL7qQzKPlO0Zu5F9449PVlY5 LpRAEBa6ECpuSA6iBr5TV+cuVK7xOdOE6Ve2onx6Nwcz8MwUtrZ4LKO6Kc5+HhdxllLU M2vIiW/sSJAq3D3hqR5uPDis1AW8OKzSUA1BKiIjtdVCKyxPNRZbttSLMPfuCJiaFL2w 6S0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776277009; x=1776881809; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UkSMnGatsFIe6PvZFudhYv/NcAOEkU0FsMM0HKaHQTQ=; b=tGwedTIT12Z4uty+qwYWy+9nHv7Gs88xz/Vk/PhBcCR5EAUAO3356uYjdIJsJQ70rZ pTDeufaZgFUVaEO0fak6d/9087IFASWUuAtbDLwBZSvZXgcVhxflajTrLbRTRxlcMmx8 Cr73PGEKDfOkS9Lzg8sWOzSaXShWAdo6gqYrHfcoSCR3KV/7Rx3LqBujjWOYA1mJtIr3 yYsfwls/4HhJVPmMMh3Yja0wR17YBh1zUv57jz8vpnXVh6YQh/ZxNFZDK6+400immNlL QzMtaUtF/dSlxGScsNyQrVFeJ5tHz6W4NBDOhnjJw4fROIc038DN/BEkPlb5bBY+I54K Tbgw== X-Forwarded-Encrypted: i=1; AFNElJ8U4VzkMwS2UC63XvXpayLTQcPE1hoo9uYB92KjIMnhvhLMpaVSF/Gv6ALjxgrQA34TolzE1HWnOAy15AI=@vger.kernel.org X-Gm-Message-State: AOJu0YxueCS6vg7NXea5qr3ajthFFWilkpyc4LBE5TVHozgbXaGb4UqB 3xJNjHLJdCGBQYbM3c3lTH5VQgMyg6FLYv+a8z5gz+ui40k6nzzKV60h X-Gm-Gg: AeBDieuQBOwK/DAsOPoDg/DYITi95JN+w9iKUetxIr69f/gymnfdvumTiuDycGcZ7Lr PbXgvR09KLE3Oe2uX2T2qUteHswSZeVvbdh1CO9njcd6HYu+OsUVPtrX5zH05WSDmX9XxEXcAIz QQVhPvXez+zhV1hP5ZyGma6oUw4R49qYYjGNjIxc2/Rkmi2oGmNrPJojT40TYcxOqy0SZuh80h+ LszEyPXLl7I6QyCEVAwjV3uNVg0PR9Or+q1g+1lciTzVfZNE2gvWqyaO0w9j1ZsnSL8j5GwPqUA PECLVEfU9/OZWzJtCFGWB3KL40/SsflcfX103uvBWJb03XYXu4zOi+q8Nz8tlDCM585kdKYS5TG GBfT0gQnYfjHdJ1UnEzshVjxDVC5sdQd/anxNFW/Tjrl+54j03Y3MwqQnW5pGLlK7reYEyJiK8S zaP9jTKAZVFaDxvzGlhfCT8kpGC58E1qCWBiBb8fMtpGfbSA== X-Received: by 2002:a05:6a00:2e17:b0:82f:6e9:d1c3 with SMTP id d2e1a72fcca58-82f0c30f5d1mr23365240b3a.29.1776277008784; Wed, 15 Apr 2026 11:16:48 -0700 (PDT) Received: from lgs.. ([2409:893d:1171:10e2:3140:373:572a:dbb0]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f6f52d45asm1658333b3a.38.2026.04.15.11.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 11:16:47 -0700 (PDT) From: Guangshuo Li To: Conor Dooley , Daire McNamara , Nicolas Ferre , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] soc: microchip: mpfs-sys-controller: fix reference leak on failed device registration Date: Thu, 16 Apr 2026 02:16:35 +0800 Message-ID: <20260415181635.3699592-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in mpfs_sys_controller_probe(), the embedded struct device in subdevs[i] has already been initialized by device_initialize(), but the failure path only reports the error and does not drop the device reference for the current platform device: mpfs_sys_controller_probe() -> platform_device_register(&subdevs[i]) -> device_initialize(&subdevs[i].dev) -> setup_pdev_dma_masks(&subdevs[i]) -> platform_device_add(&subdevs[i]) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() after reporting the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: d0054a470c339 ("soc: add microchip polarfire soc system controller") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/soc/microchip/mpfs-sys-controller.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/soc/microchip/mpfs-sys-controller.c b/drivers/soc/micr= ochip/mpfs-sys-controller.c index 10b2fc39da66..404c31daf459 100644 --- a/drivers/soc/microchip/mpfs-sys-controller.c +++ b/drivers/soc/microchip/mpfs-sys-controller.c @@ -168,8 +168,10 @@ static int mpfs_sys_controller_probe(struct platform_d= evice *pdev) =20 for (i =3D 0; i < ARRAY_SIZE(subdevs); i++) { subdevs[i].dev.parent =3D dev; - if (platform_device_register(&subdevs[i])) + if (platform_device_register(&subdevs[i])) { dev_warn(dev, "Error registering sub device %s\n", subdevs[i].name); + platform_device_put(&subdevs[i]); + } } =20 dev_info(&pdev->dev, "Registered MPFS system controller\n"); --=20 2.43.0