From nobody Sat Jun 20 11:51:00 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABC431EB5E3 for ; Wed, 15 Apr 2026 18:12:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776276759; cv=none; b=CAybsEHJC/+oplz2VgZRFuTGYV+ecKps89FWerQ2BgbILOet92FZdJC5NwTCZyAd7jhWby5c0QtThtmfpKMtcLoT3ZzXuai+l0gZxzODVnsjpoVIVWYTwHcGvMTFk/NXY9kjTg8yC8KD+RgTJ2AO1mr61kXaqw5WRNPj3k9lnnU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776276759; c=relaxed/simple; bh=3hGJztvEX6cDexQ5dQY8hER05fHJ7iOxNtn3+4h9WJk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jDemwSwtlQ5z0Sy3eHwRK3xjNoyTcdudEtE3eb8osz7Nz+20Jovbx8YQeb0E1JCD39/OF12TUp258LfxjDLeNww+j4giW/RxEZyby9lUnG15h7/Jduo/+zkTnRo+TiQzMLw795MEGyF2n/6j4mTZe8ujSe0KbCtRGzMLJIywz6A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VDULXuSg; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VDULXuSg" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2aae146b604so51088815ad.3 for ; Wed, 15 Apr 2026 11:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776276758; x=1776881558; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DyeTgqiUQeF6qpYSovoboUuQhhyXduArgsMgN+IugZI=; b=VDULXuSgoDfBImc3XG1eOFxeF0cj/aoIBTHIQd5WcnNAW9qlwz0HTmfBkEej3WlzA1 9bNNPEHbsOyMS2OZLrz/F2LavlyjmbizcjX94WfSxNhgKzCGaS7wz4+lMIAbmZ8IFeIG 4AZXS3O4OY3E/91XOxYf5uJ/PIl4Nb/zE1WyilYtEEPj5HuBt1MYLrYnRo0Pj5+sM1eD EuDFbUEqKtYF0JMHTeAv6rcxlMhGCDMa3WOgOJtX3dNOTlAFVSnZ3100ahcEmqxaJEIN 6Jei4Q0BXoMMT8znP2tir708eH2hSnMJICIRSESjG6rO52OiqoqgMz7FwrD8mk3LItKm 1Dqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776276758; x=1776881558; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DyeTgqiUQeF6qpYSovoboUuQhhyXduArgsMgN+IugZI=; b=ciLIqSCwcVFc5A/p97ljMBxKoObuszvkAljfANwH3bvgxgvKUS+bxGKQdoVSR+Kv1d Ym8gGEk9F+1biC3TunyjV/8sF39hD9XrUQ5jMZFDKPo+mWCTMzX3z7w72rdVp42xHxxF ogSrRbtzdl7UHU6AWrJn8rTUYtCc5plWLWlTUmm2m1WcOrq2eOuwHKvwb+7ReqVVnj+O nYca9hROYrVxGqonp4/jQgqg2lF9baA29C1+Nrd7jE/+FqLKhL3TuK3PyAoRkTAteJuw tfQRDo0VZ2kTqTdMwrZqdXZc7ubR8GKX63kyunc8BO/maB2gX2afJkIr4IyAZt8vVo3Q GRQg== X-Forwarded-Encrypted: i=1; AFNElJ9aRlBk1dtDcVpOYw18bi5lu/b2clcoSYIxDOyl/QPUGhe+mE92XbEMeV817/V0+f8wLS1xuKEIWlKfxp4=@vger.kernel.org X-Gm-Message-State: AOJu0YyNSijqxaL86XZHnW/Intz8ywwAsr3mfJEeG1yZO2GUVROoEumO 0bzfDu+CoHUHRfIQrh8PJjTIrJIn7QlwflxyUxI+nk9q9iyj1+KTPo0X X-Gm-Gg: AeBDieura00cSbBvjf4S9usZPsFqYedL92DJaDHWedso2O3WPRJp1EmkWYAK7pIXngM csEUcI6N06VZQPBChO5limSE7KWdb0ayzYRnWJlVmYck9VgxVutS10c0Kmb73GKFCnMZNb8rgYF ZvzJGyf7B8W4Ly0y2ZGkZvp3BUXx+vp8FN4UM5lieIVsOvlX2nKeA+BWq2kWbWTCoBIwkmIKZ/0 ckdRmiMT+okESwKidyZUNbXJ4pz4PKjf1S2bIxZhJFmDZq3sxl+mTYgZyhCBTrkKFMl4R9FCx2N LUIM+112l/f49aiMOCPtEvoY6KjNBHK4j4oda/L7oNW53ywLDIcCUJAsdYsVVB1qqN7fMPUCm1e 5ogfEhb1RrQmzauAm8QrSWJxS+6a7AQreMY3FgGLl06op5YeDgK8pbZFQ5oOe8NHauBx+0x0Yiv UdZvKWgnxsRYh+pcRje/sysByiD/8ZKdSFRh1B9Pga1ai9GA== X-Received: by 2002:a17:903:3c4c:b0:2b2:489a:f46a with SMTP id d9443c01a7336-2b2d5a69ae7mr218001135ad.36.1776276758111; Wed, 15 Apr 2026 11:12:38 -0700 (PDT) Received: from lgs.. ([2409:893d:1171:10e2:3140:373:572a:dbb0]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b47826e922sm30845855ad.53.2026.04.15.11.12.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 11:12:37 -0700 (PDT) From: Guangshuo Li To: Liam Girdwood , Mark Brown , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] regulator: wm8400: fix reference leak on failed device registration Date: Thu, 16 Apr 2026 02:12:28 +0800 Message-ID: <20260415181228.3691185-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in wm8400_register_regulator(), the embedded struct device in wm8400->regulators[reg] has already been initialized by device_initialize(), but the failure path returns the error without dropping the device reference for the current platform device: wm8400_register_regulator() -> platform_device_register(&wm8400->regulators[reg]) -> device_initialize(&wm8400->regulators[reg].dev) -> setup_pdev_dma_masks(&wm8400->regulators[reg]) -> platform_device_add(&wm8400->regulators[reg]) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before returning the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: 42fad570b6662 ("regulator: Add WM8400 regulator support") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/regulator/wm8400-regulator.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/wm8400-regulator.c b/drivers/regulator/wm840= 0-regulator.c index fb3ca7956d00..5849bb051d2a 100644 --- a/drivers/regulator/wm8400-regulator.c +++ b/drivers/regulator/wm8400-regulator.c @@ -243,6 +243,7 @@ int wm8400_register_regulator(struct device *dev, int r= eg, struct regulator_init_data *initdata) { struct wm8400 *wm8400 =3D dev_get_drvdata(dev); + int ret; =20 if (wm8400->regulators[reg].name) return -EBUSY; @@ -254,7 +255,12 @@ int wm8400_register_regulator(struct device *dev, int = reg, wm8400->regulators[reg].dev.parent =3D dev; wm8400->regulators[reg].dev.platform_data =3D initdata; =20 - return platform_device_register(&wm8400->regulators[reg]); + ret =3D platform_device_register(&wm8400->regulators[reg]); + if (ret) + platform_device_put(&wm8400->regulators[reg]); + + return ret; + } EXPORT_SYMBOL_GPL(wm8400_register_regulator); =20 --=20 2.43.0