From nobody Sat Jun 20 11:52:21 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CEFF3264CE for ; Wed, 15 Apr 2026 18:00:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776276059; cv=none; b=GqFdzPT59D08W9BiF4OyMogEVTupdYhzPCWtByiu8JJvj/9tUpSvTpN85C53zx9YpantKyQgBwCeh+9KTs3rCGD2KxrsAgQtBWxHQ5Smcwx/uDmG98woxwoHzelyH7F6fxMOl0t/ixWUmG3faWTNNI+EDZUep6sMnlIYgqnfvQ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776276059; c=relaxed/simple; bh=qO55L3YjS8zCKFEzzaa6hbU1AVUHdvMDaL6ZPKdxjCc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GTglDG+vVPNOAyK/qtyX0tiQB9WMpsW1gYuDXyL4JYUVjEaKZtRGmuuNPRb8sAF0R/LALKh2qkXOChAVP7dk+2zCqj1KpixD1oA5YPZTaTj9F4TTpjqd4JpZ1LcYhIaCntnaM9OA5VwiajnmpInP/QCiynEN2osQzfARL2z7mHc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VO0yCdmb; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VO0yCdmb" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c76c067bc51so2605786a12.0 for ; Wed, 15 Apr 2026 11:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776276057; x=1776880857; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BkycsCrJmhofL1VSAGHsLVaCLza7QJmmTEvp4Vq/cIY=; b=VO0yCdmbqr7hLOzBkxBHTIDKpESCCKjJIJNkmPcOLT0X4rU/0fHG3T+M556dUw7Hzu 2XeRZyA9UMa6+7m9QX7vKm1H6jDu0M9vitA4C/FXU3Gt7jPuTLgqeISw72lGhhG9ikBp /lxYtssOHoBXTDyNOwT8/qROr1K7YN1rZQNAViim5hgP/bUQ8VEU+CgMM/OGOZdDFgc0 6Renzo5HbFFPnAtwHylexHva1Fmm4OTGm6peTg6MjgrgzRUjrWzATeKi2PGWPt5B64PX wHYEbX6PdJ7y5h5Y0o8Bkn5UFxYDi1T1OS/xzdEPgJ8slZp++Frk1DLR3zjdr4QnVpm1 4Qqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776276057; x=1776880857; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BkycsCrJmhofL1VSAGHsLVaCLza7QJmmTEvp4Vq/cIY=; b=hTkjPIp8f6Qxz6hsiidl3Sbtkg5/QaYOqJtlYWf3IsVUtKC16jMEjpQUAeyyChMuMQ gMi3YeBUAZR+fEK++YmxxZ7y8407DldHRBz8pavB8aHAbazO8HQtsdeRuLdW43pMgxSv cm+2EPFB2UPI52qmfw4kTWJTpiFowkr7jNGBxliTdfri4VwKju+SatbaO3NAD/5ASFCt srH/Snkv9yaje+40Dncuk0Ecnq2bcuGgZOBjJAJsZ2+UShEMuORkPZp1XULKxY9iuTpN wuKONFg7SysaCe4Hd712jfT+n1iPr2eFdpCl9UuiyfhMsJUDJTyu1b03FQJ5RFN7gOTF iqTg== X-Forwarded-Encrypted: i=1; AFNElJ//YpzFq4HGoY/Xyzuz7zRD2YDf74T6G/d6MNORIP1uHL2RzJzSI1UfUvtkfLgYxTnF4zeUPT3SIOhz0b4=@vger.kernel.org X-Gm-Message-State: AOJu0YwlxBeAf8vI+d+a6fhvzb006uWPQJUhc9kIwRj7C8w11y8z//eG 34nacBeLQxChLuqNKaaPaE1rQpgT0ggOHHqixpNpskBICawgVmzBX8rB X-Gm-Gg: AeBDietuCmIkHVY9aCW6ye/kocsxKvJZwXjQfP1RKMdcM7Ol2PAI+EstI0ER9QQiMqU EylPfNu9goNPj3Ln794dqhjydz4gk1KNFzKIMylAjQaTSSb2PYJuPsYMDkl/9uyk83sF72VkB24 689oxlTIK9gJYS0zC/vlPB6O8BLkQWurMbHDCUJLVNMMUwmNb765LM0zLVjf7DMx2Yr4yOJfaOJ 9TkfGGiORU7dWMlS2pMfZLF0lyf+V53dHaBih0UJ/+JYK0pDBot36t7kHLXQxZ+JwD/7rFjXzRT tSbZuMBeEBY7fy0aC6U4gX/xWVospyXrCGsBwSkizTxINfaxmEfZIYOdLu77haeIv9etC7tx68O 8D9qpgBEHDozSixi2b5SFx1EXSVW40caihRVR4c2ArWIcowosJQK0em8IcPlMmz9ez27G2Iqc6f ZJfSee6ZvLMDuBumBoLs13LMH22dmewmKKbnSN/8mJYXlIP8s= X-Received: by 2002:a05:6a20:4312:b0:39b:c9ff:e3eb with SMTP id adf61e73a8af0-39fe3c64cb1mr23482146637.4.1776276057180; Wed, 15 Apr 2026 11:00:57 -0700 (PDT) Received: from lgs.. ([2409:893d:1171:10e2:48dd:8f21:beaa:cec8]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c79581bad89sm2057644a12.25.2026.04.15.11.00.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 11:00:56 -0700 (PDT) From: Guangshuo Li To: Andy Shevchenko , Mika Westerberg , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Linus Walleij , Guenter Roeck , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] platform/x86: intel_scu_wdt: fix reference leak on failed device registration Date: Thu, 16 Apr 2026 02:00:42 +0800 Message-ID: <20260415180042.3648360-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in register_mid_wdt(), the embedded struct device in wdt_dev has already been initialized by device_initialize(), but the failure path returns the error without dropping the device reference for the current platform device: register_mid_wdt() -> platform_device_register(&wdt_dev) -> device_initialize(&wdt_dev.dev) -> setup_pdev_dma_masks(&wdt_dev) -> platform_device_add(&wdt_dev) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before returning the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: 55627c70db6ad ("platform/x86: intel_scu_wdt: Drop SCU notification") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Andy Shevchenko --- drivers/platform/x86/intel_scu_wdt.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel_scu_wdt.c b/drivers/platform/x86/in= tel_scu_wdt.c index 746d47d33406..bc120d57cadd 100644 --- a/drivers/platform/x86/intel_scu_wdt.c +++ b/drivers/platform/x86/intel_scu_wdt.c @@ -58,13 +58,18 @@ static const struct x86_cpu_id intel_mid_cpu_ids[] =3D { static int __init register_mid_wdt(void) { const struct x86_cpu_id *id; + int ret; =20 id =3D x86_match_cpu(intel_mid_cpu_ids); if (!id) return -ENODEV; =20 wdt_dev.dev.platform_data =3D (struct intel_mid_wdt_pdata *)id->driver_da= ta; - return platform_device_register(&wdt_dev); + ret =3D platform_device_register(&wdt_dev); + if (ret) + platform_device_put(&wdt_dev); + + return ret; } arch_initcall(register_mid_wdt); =20 --=20 2.43.0