From nobody Sat Jun 20 11:51:02 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29BC1314B9A for ; Wed, 15 Apr 2026 17:57:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776275843; cv=none; b=q7i5CGgQGcTOE60L0bB7/BoQbP8xMRcBudpk/45on2WkkqrLWJdyoZ12cw8sutMzmOzxEHMCbhqP8Hxr4awFgaCiJz68EE0XGWSukJ7qX8anuMMBNUhe1pQyq4vEX/HMEPrUnGoQ37QgPLuExq9tIDXdw1IFjlOTj1mtiL0j9zA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776275843; c=relaxed/simple; bh=zYEZtG3CNWlhxk5TCgfhLdH0TQVOB7keHngYJTHByUw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TLV17hMh/3X5j6mVgivPQjD8zXo/LGdNeTESuvRENES1WnmUn33iY0KNtN4QVyYe42N9IU0up1UK3vsUGCLzEggbn+zAs26edGY9eGTpXozsbvuhQUsx0mygfnN0dWvZHOjUMtgd8EspmyYAAkTv4krev2GxP4LrLS6P6crD53c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pLFiMUdq; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pLFiMUdq" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-35d965648a2so6123150a91.0 for ; Wed, 15 Apr 2026 10:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776275841; x=1776880641; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LVK8DHikQoX7A6e7OIrQHyMcwBuwukNQmr1sdoA8uRw=; b=pLFiMUdqV8fBQUB5pzAs2UxHYVrKEL/zCInz2p3JCZ38E8CrMKoSRqXqSqomSHMQm2 wkko3qf3kSHcI69KqW8iC6Yafwhc+Cu3sKrcptiF565+uyl/UUrDqwdgOgp0QmUseFpQ +HHYmQAUlken7ROoqwxZmZznd3gGatHzVKoj3HOLSkzQC2whEkVPsI3ie7XpPPs2a3kC cGf8IuQcXMVRxsePJtMhPOwJOVoC+d+GCk2zvIp9Xw8e0VRnkuyZ5vJ4zf1Iv2xhpYid ZVjAExDTu17ZmLU8oN5S6wDiS0gc0gHMVN28xfpVo0eZctd4Tfwmx8HQt5JfbUC3elXO JTtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776275841; x=1776880641; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LVK8DHikQoX7A6e7OIrQHyMcwBuwukNQmr1sdoA8uRw=; b=V6173A0T2SUvtVnHnSAiAOkE/oAMfdXTGK9M4KW8Sq+Z8IXBooNG/s0V57hmHuNYTs bZ4330L1uCTQP18eY6uPDhWCXootfKR/tLNb5KYRk7xidJ8rNuMElQ298ZZv9qfjXzEn N3EJ7FohuJo6bPBPAH/Qdxdgsj7GezYZo/EqvsioCh8b1BBozTNx3LZ3fzr9is0WR9eG KWo4ya3VaP3MhpeADI9famCudeZgfXiVhnAor1+oU1O/RqiV0oJYBZnaiZphHx8NwEOH b66DIqjVCMah1K5h7XSjW9sONEv4BdyEOcTPt6eRN61gp5F1lpO45u30GLD+MGkd01qB bQMA== X-Forwarded-Encrypted: i=1; AFNElJ+7ZsV/Tk2sNBFRildntutm5U2bpZMPQ1erMb3p9o8n8Kyx5sOdq1Qg+pahHkgDgkLEKgLf1ogYen+Kqqg=@vger.kernel.org X-Gm-Message-State: AOJu0YyDeh3/pbnFsvBkTjoI34bzwq1HE8gFCB5t8rPccgTa3tUVW53Y 3TQhiT3t4hxYkN3fzuXvgiNgfV5I0I6NatwCOEW/tfJVS1VhJTNYSo69 X-Gm-Gg: AeBDievvrA+vqsa5oq1qV0ohHQUoUQxYJ+HgpPiLYZc653+KgMglO0ydukBDYNKwNic 2nJruUMuU//WdGDdY6J4E0I07rz0WLMMOHkEKW4I63ad+pYh7DqV3hY7mzkCW8R9ojGJ8uo5pkw UrubgVtWgg/jmC7SPLUg6YCOiu0gf9mahDsOH53TSbZUFm24OnaXiJ9S5+a5FdHayfHDWUeE5UA zHmlFYlbJQUygGYW5K1E8CRxlnBtuqyJjDitGEj8Gd1Wm0k04XTy5FybB7c2c9tB7pWe76Uaaam WfBCdJc8/zW2yN35Ce+hFuZqtpUyP6p89seDxxsLXCmZu0cIY1n8iCVD/VeL57M9BPoN0/haHxK HoUMPoRU3W828MWaw1MKqT08XCixG38sPnQO2Wklc7KV8IAs0pMPqdQxJPOIIIadnJp59ow0E6A LbbZqMClvlWtLcT9KvYcJQZNHxhIaTQCJ2sr/jJHqAzOTDS9o= X-Received: by 2002:a17:90b:4b46:b0:35f:b3fe:18e9 with SMTP id 98e67ed59e1d1-35fb3fe1caamr14818307a91.16.1776275841534; Wed, 15 Apr 2026 10:57:21 -0700 (PDT) Received: from lgs.. ([2409:893d:1171:10e2:48dd:8f21:beaa:cec8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b4782cf2aesm29261815ad.83.2026.04.15.10.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 10:57:21 -0700 (PDT) From: Guangshuo Li To: Benson Leung , Tzung-Bi Shih , Guenter Roeck , Thierry Escande , Gwendal Grignou , Enric Balletbo i Serra , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] platform/chrome: cros_ec_lpc: fix reference leak on failed device registration Date: Thu, 16 Apr 2026 01:57:07 +0800 Message-ID: <20260415175707.3640225-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in cros_ec_lpc_init(), the embedded struct device in cros_ec_lpc_device has already been initialized by device_initialize(), but the failure path only reports the error and unregisters the platform driver without dropping the device reference for the current platform device: cros_ec_lpc_init() -> platform_device_register(&cros_ec_lpc_device) -> device_initialize(&cros_ec_lpc_device.dev) -> setup_pdev_dma_masks(&cros_ec_lpc_device) -> platform_device_add(&cros_ec_lpc_device) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before unregistering the platform driver. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: 5f454bdf63536 ("platform/chrome: cros_ec_lpc: Register the driver if= ACPI entry is missing.") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/platform/chrome/cros_ec_lpc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrom= e/cros_ec_lpc.c index 78cfff80cdea..cb3ff76d29e9 100644 --- a/drivers/platform/chrome/cros_ec_lpc.c +++ b/drivers/platform/chrome/cros_ec_lpc.c @@ -892,6 +892,7 @@ static int __init cros_ec_lpc_init(void) ret =3D platform_device_register(&cros_ec_lpc_device); if (ret) { pr_err(DRV_NAME ": can't register device: %d\n", ret); + platform_device_put(&cros_ec_lpc_device); platform_driver_unregister(&cros_ec_lpc_driver); } } --=20 2.43.0