From nobody Sat Jun 20 11:51:20 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95D373ECBE5 for ; Wed, 15 Apr 2026 17:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776275459; cv=none; b=laxmQPSLYIUeUDsvrViCu9FrsH/kZ3/Muph1+BxHN3GVuOipn8oDhmw0qTSVWQArjiP3IGZlxqscreeq55ObdAfB3BA5SvCWCOqUQu6hhPkbFa3+wU+u8nFuaBPgXkPJ90CcWcP0NsDRCbM/zzf4XXSmFJQ6OFxKObQMtFOI8CU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776275459; c=relaxed/simple; bh=q9TGLRe1UVqxWGYdLDq7YnNCc4SCxzhTB9OScxICR6Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=U7jX+x7ZmD6h1+kkZ9+dW16jrp35X0uFZ3DWzitbinFOTp5/PTg3usv9XZHM+l9X5vuMRkevvRPRz2bBGNlUomsAb5mYa8e7UgHP5s8vrz8mPdn7D3fpbvT98tqTiiAErBPLNOykTRmA9Sn6PCLpM/2NnjzywqTAy9cHtNpu1NI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jV3x9tcA; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jV3x9tcA" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ad21f437eeso42447425ad.0 for ; Wed, 15 Apr 2026 10:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776275456; x=1776880256; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gjx41/oJzSzCxjCOcBWOIoSBA7KLlVfstVe2P4xKOAc=; b=jV3x9tcACRpUKRbQdmJbBUqji3OcwLPq6G7gLJUxOjgQFslkRgeLvJHk6LxMI6E3nr DHBW8hf3ZtnNs7LQARdF2Nvpi2x2koOnwO/zQnZU2SQDVM17i+yu5xoC/ROtIlzNh/Rm A522ppbngH9ENS88kgAAtDXSv/MAzpwMUbFseTNJi7ks+hvCeIEK7MLvVOyXVfLOMddW kXeuNaMhJkdK8Dp3+Ujv6+r8nK/5EmjmWHSmQ/M+IAMZ6eXWdAbuby5lIZ75umDeFzKh Lp8O5m/6rs6qDfaZIVUnJ7bcKoJswqv+ePfZCl+4bCQ3MNtcRKAANcG1XoKVEePXOoAM /PBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776275456; x=1776880256; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gjx41/oJzSzCxjCOcBWOIoSBA7KLlVfstVe2P4xKOAc=; b=dLcwFZxUlwchPQvutjTJPv2qaocGxjryC7btrmotvhl28HXChEpJlnzrV9/tYMThAx P1u/QFMyHEYdLjK+qLUIC6I32NSCVqIhorvts8XTo4LiyK1zMXyBcKRAoW8z5ORNPG+p DDKNkhPRuzhNF6QiaBCb01AtS1zyCk5DZhvhLLAOBZL6eugJdTu9JBBa4V88PxOgT5wx dJReMzohYzK2QefO4irt4o1IidxomVtlrOqvwsna92peyoqSrHKo0RJ+x6aWqTd11zhl uoSf11LsitRi4vFr1eRynJ8twThNB9cJlTtwFnRdb2CmZBywbbOiCJsPCwuY2IR01eW5 enLg== X-Forwarded-Encrypted: i=1; AFNElJ9TXzSq2Fx3Nv/KYU5QImtMxTSX3epnbuK06dQzPG7S7oRN3lAGhG5jH0rsH+F29wa8G5C2mBbbd1zJ/3w=@vger.kernel.org X-Gm-Message-State: AOJu0YyNrE4SHAHVUDSco7n22i8uW+PAmLCODIuMiHsnk2lbg5KzqNjd rJRiKCzRg2Ovj8mkZWj6jmsecSHg2EaXMcd/6zNxD+8ZkmbpH0jU6zHhd6LrHhF15EZIAw== X-Gm-Gg: AeBDies/LoyfU+QQWI8xHdZlVOw8PnEk56GZ/LoEf5iBxwRzqrNfFuKZ5+SfZK3lKO8 MOJ0W0zMMH/uovpYXMz7+o/uiw6NcGpTmqJ3NanfQc4dIHInOVgNnBCu1X9DQq6vwdonLpK+6En kAwetAtnnb9JQye29XjJ9IorhHRILPWdVebXOCzlsansDjuNHyE9WYy0lDgIF2asnEfHhthIM6A VgX00MykIE9egxeshKhTiPXR2Aqqq4leRGHjxBndrQPHB1YGtf0pJym+n73mTNdDXZSGmglMbfo hzL1FczE2yZ/KxObCYGUSw5EzsUkLieg2SpoGJSQo5DCsLVVlYb9h4lQsU79i01VFdm0n9uvxfY lUvCxaKA1ZHXiTp2fghmwVa0I9gqrL9glhZBDPF4MijHaZ6KMMBRUvctgYJy2O0C5O2TTBCGoJP dRTMT6lYi0Ijxuobt6xgtrMJInKlv5dvVn4b4n X-Received: by 2002:a17:903:3c6d:b0:2b2:4bbc:14b0 with SMTP id d9443c01a7336-2b5eab05edamr3733145ad.20.1776275456476; Wed, 15 Apr 2026 10:50:56 -0700 (PDT) Received: from lgs.. ([2409:893d:1171:10e2:48dd:8f21:beaa:cec8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b47826e248sm26728185ad.47.2026.04.15.10.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 10:50:55 -0700 (PDT) From: Guangshuo Li To: Benson Leung , Tzung-Bi Shih , Olof Johansson , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] platform/chrome: fix reference leak on failed device registration Date: Thu, 16 Apr 2026 01:50:38 +0800 Message-ID: <20260415175038.3633384-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in chromeos_pstore_init(), the embedded struct device in chromeos_ramoops has already been initialized by device_initialize(), but the failure path returns the error without dropping the device reference for the current platform device: chromeos_pstore_init() -> platform_device_register(&chromeos_ramoops) -> device_initialize(&chromeos_ramoops.dev) -> setup_pdev_dma_masks(&chromeos_ramoops) -> platform_device_add(&chromeos_ramoops) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before returning the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: 9742e127cd0dd ("platform/chrome: Add pstore platform_device") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/platform/chrome/chromeos_pstore.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/c= hrome/chromeos_pstore.c index a6eed99507d4..9e6d14dbb1c2 100644 --- a/drivers/platform/chrome/chromeos_pstore.c +++ b/drivers/platform/chrome/chromeos_pstore.c @@ -127,8 +127,13 @@ static int __init chromeos_pstore_init(void) /* First check ACPI for non-hardcoded values from firmware. */ acpi_dev_found =3D chromeos_check_acpi(); =20 - if (acpi_dev_found || dmi_check_system(chromeos_pstore_dmi_table)) - return platform_device_register(&chromeos_ramoops); + if (acpi_dev_found || dmi_check_system(chromeos_pstore_dmi_table)) { + ret =3D platform_device_register(&chromeos_ramoops); + if (ret) + platform_device_put(&chromeos_ramoops); + + return ret; + } =20 return -ENODEV; } --=20 2.43.0