From nobody Sun Apr 19 15:59:41 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BB153E9F97 for ; Wed, 15 Apr 2026 16:52:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776271935; cv=none; b=BPEj6sMtuvlP4Sgsjkrolvhr5h37i0IUFSygU8zanGLucYYiXyeD4O894IcZnD22RnJWk6DbTcFLAHjdswkfKZCWpIw7QcCOyrZ6+7jmbZcM6MyiQF5/DNMrE7us34HYGJQWbgccJrHNanHfx8CurobPF/kN2l5C9wWRRmLVINE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776271935; c=relaxed/simple; bh=rj5wLlup8qGQB7iNo7ZCtRiFyr1/9/lYD2XX1FA5veg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=G0ZNodLljSI3XJQAwXu+92zh+K+KDyRHn0Y5lgvx/9zPNpBGR6p7TGOH5ohejlFzqZl1Jo4frna5fU36SokvfsEmv1Hg99Frk3YUCyUy8MBQAaZdrMShI72+RYcP/1jt0HzEj7TcppXKIkaWlFbzBwvUgESWmlwHrmCiZH4ckuc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PMCLJe/p; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PMCLJe/p" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2b0afa0210bso33450225ad.2 for ; Wed, 15 Apr 2026 09:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776271933; x=1776876733; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YoIHp8GvLTuo5zMUl11z4KLw0EIw4APmXWOBDsv2hkQ=; b=PMCLJe/ph5FFe8WCCUqobYFNDH+I6rh9KHLeaWllg+ioPHlF0jz7c1VcTCsrFIjme5 H1se78pxmCUnsCFceThYwRmjPaVYoDnyRBLw3pbMrZUvzRG990i1azzpRDqOyzWKEEP3 qejoY7MEz+S2L882V9wjD9PzUY1dqiUqVNcbi/lYhMixW99ffwByiw1peuP9i2uWrdn+ 6qZ6HVbUteb3/n5R2NMrSszuhN2NgtNpwTdA+cVWVo9/BEZSN9nrWA/DcQPtWxT4hklz pho7NLSKbUlgXT6yPtNTMaYfBCRRE2xyMXe76uH+CK8U64/8VTe6REoPIXOet0kGBp1I 4zjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776271933; x=1776876733; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YoIHp8GvLTuo5zMUl11z4KLw0EIw4APmXWOBDsv2hkQ=; b=L0eP1a8GvK2Hh2SkCTOrxiz23HD60xH48ihBmq32lndcu0yYr+0sSLSes1iImh6dk6 4KqSSooOEOdwyoszDI34O0n4SQ07TTLluDIKHx7Ft8S+20t+623qSqvqVH1gAzfNDSPs PFZ8Otl71VKSrmJlBP7sQTUkprCLjZFWmuehsDLFOvVEWjJXXDXJ2TbQSG/jHUm3VM7i F6cV48hEliRBlZUbUDm2AR7Y3gyeVKDPzapjuRkPonwIX3eM9qwQX7i0YhqbxekQJ9ev QG/80WbnKrjEdFW+UM2b/m+NjyXd//8CHGCGA/x62pn20Kq4dx0vqqvjh7jdC86yDUFm x3sg== X-Forwarded-Encrypted: i=1; AFNElJ+dmGt55pQUj5wopgY8tS4r3mzEPJzgnEb6nujtRuxa9qr22ygqJhEEveXZwXxRGwodawnZR8pdQHbcQSI=@vger.kernel.org X-Gm-Message-State: AOJu0YwjDS0OcuhhcQuXnkaHdQ8v4LBgWXK3wIE/3Nsp+E4SEs4buZQU P98Fky/NdZhY1QNnAH7b1ToGpj57IaiUMnEGpL4su8Oif/vK3jWUukfF41JazXN3qhUXXe1Q X-Gm-Gg: AeBDievJYw67nqJRFopRqB0Nz8/XkXOxazsRbEcCsGW7WL66M6ELBEAIsbJdtZnteVG xexILWkW+ghWVhedjIV01zWaAUxHfC5TWhZSNXz2qQpzA+BahMOF4jjiERbHlg6Qai3FS4WS5b/ KbsaHH874taOiDVdLgv5HwgA6/MTqPCwWu+k7SBx7fXQucQTKHpD+6h2kVzYWYAFkf/JCM7fmmH Av1j2SXhmoTxzIGt6Oeq6El8cRoJ/cy0SUgr4yog4f/v8qQ3rXcPvUqk/XRX9fWmH9tOSiBllFc xR1pb/8eTluflAMo93/iscMAX5YhB6FH0bhJ8zQDAGpeFv9gQs9svYdhD8RFKSOMJ8mA+eb00c4 OEcXKbwU+kLm8gL1yO89tds+vvCXhF2J1r3aZ16lc0Qa7z4Ny1D1M9DBibN7wXEdytVj+U/klps 3BFhrtvRJiTizlUgL9KjwrdzvaF/MehU/t0KrHr3G0ZWbYYNU= X-Received: by 2002:a17:903:acb:b0:2b2:4eec:980b with SMTP id d9443c01a7336-2b2d5940ec9mr240710515ad.7.1776271932876; Wed, 15 Apr 2026 09:52:12 -0700 (PDT) Received: from lgs.. ([2409:893d:1171:10e2:48dd:8f21:beaa:cec8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b4782abd6csm25660635ad.63.2026.04.15.09.52.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 09:52:12 -0700 (PDT) From: Guangshuo Li To: Arnd Bergmann , Greg Kroah-Hartman , Guangshuo Li , Andy Shevchenko , Linus Walleij , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] eeprom: digsy_mtc: fix reference leak on failed device registration Date: Thu, 16 Apr 2026 00:52:02 +0800 Message-ID: <20260415165203.3584869-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in digsy_mtc_eeprom_devices_init(), the embedded struct device in digsy_mtc_eeprom has already been initialized by device_initialize(), but the failure path only removes the software node and does not drop the device reference for the current platform device: digsy_mtc_eeprom_devices_init() -> platform_device_register(&digsy_mtc_eeprom) -> device_initialize(&digsy_mtc_eeprom.dev) -> setup_pdev_dma_masks(&digsy_mtc_eeprom) -> platform_device_add(&digsy_mtc_eeprom) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() after removing the software node. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: c8ed97d8c3984 ("eeprom: digsy_mtc: Convert to use GPIO descriptors") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Andy Shevchenko --- drivers/misc/eeprom/digsy_mtc_eeprom.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/eeprom/digsy_mtc_eeprom.c b/drivers/misc/eeprom/d= igsy_mtc_eeprom.c index ee58f7ce5bfa..54fcbdc0412a 100644 --- a/drivers/misc/eeprom/digsy_mtc_eeprom.c +++ b/drivers/misc/eeprom/digsy_mtc_eeprom.c @@ -89,8 +89,10 @@ static int __init digsy_mtc_eeprom_devices_init(void) return ret; =20 ret =3D platform_device_register(&digsy_mtc_eeprom); - if (ret) + if (ret) { device_remove_software_node(&digsy_mtc_eeprom.dev); + platform_device_put(&digsy_mtc_eeprom); + } =20 return ret; } --=20 2.43.0