From nobody Sat Jun 20 11:50:47 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6101F3D3490 for ; Wed, 15 Apr 2026 16:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776269417; cv=none; b=VEqWOoLEj0CyYMpJgBbIyR2MiUlj86xqd3gTY0BojcfHg0yc2ndILKsbBBs/kIQkM9m0hS/gNV23zw3M2FnBB5PdCin/5fcKWLlCGlFOZe8sAu2L9t+qXQXhpl8zF5t0N21+ucPymxrQj1fX/U66nEjMLYloV/+hyfuFPsXxND8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776269417; c=relaxed/simple; bh=2w3KOA8yk7Qww0r6vlP8QuGutHFJJRfR+W+DcVcyKkY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Y0HIzHWveYXIJz7KkGtWLgjiR75f/+hUWKdSKi2FuuQ0myCVSId3H3tKjgSD7nsL2z2tVGxh94udRUcT6fjLm7K4edrI9CEnCU2yDdeVEqfc14rwzpmMXwJBAWQ91Nr4NJGZA/66oJ8wOU+/rznZ5BY6LqHEK+hago9OVRKfQEg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l9ENnJDl; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l9ENnJDl" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-35d965648a2so6000864a91.0 for ; Wed, 15 Apr 2026 09:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776269416; x=1776874216; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uvfnqSOHR6vjb0scxZvmU791071WtEtmpn2rGjggRIE=; b=l9ENnJDlYOLhjEW9ONq6JooYpp1H+dEyNuUxtBaddg+FP469OA9Vzqlk6GlpKl37iv w3V1VIvC9dBqZCOAVGtpat2g5p5rdvQWbzCMUoOuXCguOLsWUbCXwrBaOqH8R6+5tQaO PUj4VSNWaohkuG5hu03t0z5yzlNv6RCbrgKcXg+t153cjhPt2jiu78OLs51z2GCElgXW 1mh53WLjrww0I/KWKlNpFtRBkOhHqMn75Cu+BPJAT57vhedxI4CMX3PU3tLZAbSe4p4w Meu6/fZnceN1Pr/bsp6pcxUWUOzi9ceZxQxMkBilRQ6fzEKFMXwjnrkH0bd1d+dIyDqs 1syA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776269416; x=1776874216; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uvfnqSOHR6vjb0scxZvmU791071WtEtmpn2rGjggRIE=; b=OJKmI2zRNUX0smMG+usLDc1cGr6bzxfd1fNITplSY3O4GiP3Vpl3Ca/tGhw9JbhXix gV43ocFZQnvP2moNTUjhYC/qoyUgRK6vmxbVv/FZRnO74b3YlNIe7u2NUZcrxtneHQ4Y uApPzlGFF4rF+YqninrD9GZDMxld3dR9QsadpNe5L89El0Bl3FSjBa68wipaAIRGp3KN 4ymbr7XhBDYAJiv3mOsuCw7GndAZzo6iw9JVmajkniVSOKmBpgXwel6zhqudIG4fshO3 dYaakIyhYG5zz8yu3MeUQQtOmIhG9AcP9oHblDvS40u5fsIcWCxclkldVDKJSTmGCcvt WFrQ== X-Forwarded-Encrypted: i=1; AFNElJ/8DkYmxBBNJncNKAGM2xW9KFTTb8UuVmZaFkeIgkBqKXtLLRzBNe+9ToF/u+e9MxyrgKKGPKDkYPSC68Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzwGx5ut94yAJAbeRZirZMgXyJvyEl4u2Yr/CMug6ryzLsolWm2 YiYeZSrMbassRayqGySQy63CEkC5wCh2Duv0O2PMfGvEY9P9G5IevjD0f4R4MibwaDoU6G7R X-Gm-Gg: AeBDievhy7rUlOFA0mHET0r9dKkdwOEt8IKFZ4+rdB80VbIXCX6/ukPqdhrjqKIMD9R Q8IjLr5FrBs/86g+4PYTgQLSmz5V08uY84ZVuTND16heDK4XqJNhK2I09+b2nxkV78WHdEfVP2R FTCfIN0rbhCTEAlIFMNt2i3n1oSExTB1KHvkbd8Me8EoRLR/NtatYWg50fB7yoLf+7jiblAok5J rXyxAIdgMWMXiXamJAuM9VyK3vlTOabG5j/sPubYuNoRu8nEwtMpHltzTkwad5nRFGf6pzzOUbu m6vYPkikw02ne81wVvqrMc8sdODyhEYLzmFMVmMIM5HwLMJCg35UbQZBY8sZlPmWnHQH/sokRsb 60NI7FjQsYP4r3/8WsGtv0jGOLf8hQMiC1vc+j4tmjVOkCUZhsozNVMwpK8NZWxRWlhskg9xOXZ YxBRjQHy08oLGqADTP77Uy7L6JD3Vo9wDSUzKp X-Received: by 2002:a17:90b:28cc:b0:35d:aeb2:25b2 with SMTP id 98e67ed59e1d1-35e428cda1bmr22964275a91.27.1776269415554; Wed, 15 Apr 2026 09:10:15 -0700 (PDT) Received: from lgs.. ([2409:893d:1171:10e2:3836:7c38:e5c1:4b6b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35fce8d7cd2sm1066496a91.4.2026.04.15.09.10.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 09:10:14 -0700 (PDT) From: Guangshuo Li To: Daniel Almeida , Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] media: visl: fix reference leak on failed device registration Date: Thu, 16 Apr 2026 00:10:04 +0800 Message-ID: <20260415161004.3542108-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in visl_init(), the embedded struct device in visl_pdev has already been initialized by device_initialize(), but the failure path returns the error without dropping the device reference for the current platform device: visl_init() -> platform_device_register(&visl_pdev) -> device_initialize(&visl_pdev.dev) -> setup_pdev_dma_masks(&visl_pdev) -> platform_device_add(&visl_pdev) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before returning the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: 0c078e310b6d1 ("media: visl: add virtual stateless decoder driver") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/media/test-drivers/visl/visl-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/test-drivers/visl/visl-core.c b/drivers/media/te= st-drivers/visl/visl-core.c index 127ab18bce99..15e4f05d5ec9 100644 --- a/drivers/media/test-drivers/visl/visl-core.c +++ b/drivers/media/test-drivers/visl/visl-core.c @@ -558,8 +558,11 @@ static int __init visl_init(void) int ret; =20 ret =3D platform_device_register(&visl_pdev); - if (ret) + if (ret) { + platform_device_put(&visl_pdev); return ret; + } + =20 ret =3D platform_driver_register(&visl_pdrv); if (ret) --=20 2.43.0