From nobody Sat Jun 20 11:49:34 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D2B23B5318 for ; Wed, 15 Apr 2026 16:08:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776269323; cv=none; b=YgNlYcNuJOB5NF76DtKmvNcAf0gUiIZwUZpOHq0MTWinekBlwxqbg32AbYTy9n58fxjLOy0YUM6BufcXQiq9UZWFC2dV0w4jlXMpVbeoXNaombsldRa6q70AUEGC0YTiIseMUMDT0D9XACtplaiup6hSE3z916lJsKbsvgebHn4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776269323; c=relaxed/simple; bh=jMqQvHDH2lwJH+8MK75B6OZ9tIA2KP8DnA2nTclqSbk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dpbiM8/s5Nzchn8MCLY1cFwlXd/CKjJrVBB2Upi7BCIj/5ZV3utljNclnDMqQei9o7sw5cS8Tjxog2uGrgNH22R8zVgrZUWK53nQFtuVjJuspuqt3uCMyFobmu2Ml+Xr9XkJUidaxrPC7xtZh1VnRsaPTHq27H8rMXpEos5v7Nw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HhLb7LuM; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HhLb7LuM" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso107803735e9.3 for ; Wed, 15 Apr 2026 09:08:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776269320; x=1776874120; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0nGy8cs9TuK82zOcS8+ppBLbL8+nzVMmWL3xkF4nuKs=; b=HhLb7LuMp/wRTe33M6tsZTVkRNbXO8IePy0FHMJBJ2me+iwByr+nkMY84gsV+hXhkX qTDp8Go6j73eyd0xm2VlMlQhXxdZTJDLsFfNE6zwm4uTow0KsycLFfTOiNnJhcpUA+iQ BqgWI5l5iGNUJHt0TTxQjEhCmEMY+Czhgk36oFkW9FhHsfN04FhuW4xUdG07+2lIWHr4 TBmgDExv0w2w8bH78N5hCl6jIW8XSp7DlhNI+CZ/2u4tnm01m3QoMoz44mDdCUr46dgL PtZHnKb8NEWcINGCNZncUJB5xU35rS+fV5TJtA6BJu3Xkctp/RigpAmv7a1PToDx3k9C KmTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776269320; x=1776874120; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0nGy8cs9TuK82zOcS8+ppBLbL8+nzVMmWL3xkF4nuKs=; b=lsikOUKge3jU001wLhQe8+lcUL6uNo9N0xskDK4fvANzVU5BelONkhWWDofWWlvssB cwRkNIwNMO+6h1wFqgs55ycP6BTMW1KDOeXbY2OPoNqNeCxO0IvF6F1hGxAtQp2tE7cs 8Lt8bT4xETYBCXWYeWv7vo8ENGvWh+uXN+B+zed+QJKvjEYa70SUo+w61lKa3HfGZuzm Z0qYkaACv1TCgWFO7qZEgqWcJJsuOzbrpT7TaXIQkwJc87C9POXONd6pdyywV7VuwWpT aRCY0rk0Pwi1zQsRZvG+X7fE9Mq+SmRQxbF1yNJ7ALIDHNqMrtTJA+mHGFBJHbUd6fEB 0VZg== X-Forwarded-Encrypted: i=1; AFNElJ9dYXosiDUcWDuA3AcTWLiRnVagpITUf1Z1mluEu2CS9NaqBDaY7uKbb4rWEVxgJYoLyhjAIwrgZOk3Erk=@vger.kernel.org X-Gm-Message-State: AOJu0YycWFxrWS6JqYIWOoOpwLUhMzNyccXSFsFcXkCjiZgoNU84B35Z 7GFqUr+dVE7I4K5mf9EWKZxBAdo8o7oLkGR0ZD+569l5KdaUfFXa/d/H X-Gm-Gg: AeBDiev5E6Xek4WjMhkMCYMNuWpk/3tHw8ESXQPXGkFly2xwHGUnGrIapUPUV4Z9yyC HP020APQTSgKLBvqjqr/TeXly4wCgE6Zd+l8j2dEfMY+4cCRC7dzuGOd6nJ/tKSS6tySAQhSfUY B4jg3mqMszXcuy5/ATrla68JW2QzwBNwT4U8XKXk2MZKe1yJ5HSXoadnglmcLcTK5P8/QzE4+Fd Rs/01dl5KX4O/c2WKl56E0qIO5Irika/wr2ML7yTT0MnpLtzmxIJSLqmbBMg/5jajQY4a1FW2Sn lYmH26Z5EUZ4RJAju/bIaAh2IpWWuomw3Dd2lV/vOuVpQvVr04AhJGEX+F6WodTQxxLBtTW4qRl COTl2Hr8Im82L582CK1mAqRh05iecgZKshYJkWHhXHRNWwaK/SmyCAKqgWbIhscEcmlUPBKzpdd g13+4nYZprcqJgH2y5REeVweHJnA== X-Received: by 2002:a05:600c:1f83:b0:488:a82f:bba9 with SMTP id 5b1f17b1804b1-488d6864dd2mr310638985e9.22.1776269320058; Wed, 15 Apr 2026 09:08:40 -0700 (PDT) Received: from antoniarch ([37.163.125.81]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f0ec6cc6sm23482975e9.29.2026.04.15.09.08.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 09:08:39 -0700 (PDT) From: Antoni Pokusinski To: alexandre.belloni@bootlin.com Cc: marex@denx.de, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Antoni Pokusinski Subject: [PATCH] rtc: abx80x: fix the RTC_VL_CLR clearing all status flags Date: Wed, 15 Apr 2026 18:06:11 +0200 Message-ID: <20260415160610.127155-2-apokusinski01@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The RTC_VL_CLR ioctl intends to clear only the battery low flag (BLF), however the current implementation writes 0 to the status register, clearing all status bits. Fix this by writing back the masked status value so that only BLF is cleared, preserving other status flags. Fixes: ffe1c5a2d427 ("rtc: abx80x: Implement RTC_VL_READ,CLR ioctls") Signed-off-by: Antoni Pokusinski --- drivers/rtc/rtc-abx80x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-abx80x.c b/drivers/rtc/rtc-abx80x.c index 3fee27914ba8..5c2424a00b7e 100644 --- a/drivers/rtc/rtc-abx80x.c +++ b/drivers/rtc/rtc-abx80x.c @@ -545,7 +545,8 @@ static int abx80x_ioctl(struct device *dev, unsigned in= t cmd, unsigned long arg) =20 status &=3D ~ABX8XX_STATUS_BLF; =20 - tmp =3D i2c_smbus_write_byte_data(client, ABX8XX_REG_STATUS, 0); + tmp =3D i2c_smbus_write_byte_data(client, ABX8XX_REG_STATUS, + status); if (tmp < 0) return tmp; =20 --=20 2.53.0