From nobody Tue Jun 16 02:37:02 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3141F3DA5AF for ; Wed, 15 Apr 2026 15:28:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776266922; cv=none; b=MQ+cuwmuT1ZAHFcgAJjgwd1ANVpGFDKZaGft+kGSPSsShc3yEoVJZ8v5wkq+c7KGQ3cvv0o1JGB4cwfzKVej0IZbDhX+Cac4CYtEuaVqgp8aYQBmnHKQKgrzm59+D5bfDSHjKKJ2fVlFYu1FBoJwk5uOwWvkEEJQy+B7Qq2LMCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776266922; c=relaxed/simple; bh=oJIKfpkjLTRuSN0Na5MbEEyvI1htq76RZymUd605YJ0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bC+oA+j4LKrPFQftHxFqv22mfhPjrcd+mGWqPcziveOWXV/t6XAOpCv0X0QJ4srJNdJSYJu5kwUqplEvZGRp4J6Ceyp3Q58Sw6qbTwnGOssg82pwtm7TZliQRibO7dEpv/TumDv1dMUdj8Mbc0pamC3I4TgzhGyxeV3j/CxW2c8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IkjwaP4q; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IkjwaP4q" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2b2429f98d0so43439055ad.2 for ; Wed, 15 Apr 2026 08:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776266921; x=1776871721; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wpi8dSRmXDyoL9oy3Sy4RDdQKtqc7S8AukkEChjSFcU=; b=IkjwaP4qxK1AOR4Wcskl1buhA2/hEBFNUZAgFgz0iacco2DZHQvEH1mCuYmY6hFy5Y CVixGBXglLe8VZdQZOq6stuLwCN7Ir+328Pku9uTwk1zTtorTFYBBpYUucCzmXCJP7AX RFMTPS52JwygLXGTiNuEoDm3z41mt8hkkXTNULbCVsmWyfiU+26DMvAutXO/TklTozwq wF1eqQA+HfvaTuP5zPNFfBcD6x+saP6y5n6MSFVo0XfI/k/Sl83ymJmX9riHLnGlPYlv vviTd+T/BEaMnQhrkyc2HFv9QYPGVVWOikFXPY4BzHKgYMQHyZJU7HOEYnEJ+Dnux8bH StkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776266921; x=1776871721; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wpi8dSRmXDyoL9oy3Sy4RDdQKtqc7S8AukkEChjSFcU=; b=czzlXzTk8m6J/tsEDz5qoV+ywKvGgFfjd78StnptOgovTsUJP1DrajmJjor88TDD7U b3fO9uI1foH44EoVVN/z4GCAIPXe8OHVMkeCV2XSqGvbGm/YWfIvu5r109IUYiIZOEo2 8kQ0EPL2EhbvYvIXyjVTAdVJ3doIht/xncChAnTziV+7o/THnXEsIpcYQ+38Gz6nosBc Nb3XdHmA1oQUSCfB4zH16fuYuSECzAejAV0mhYMnrYjbalEiAbsYMsyjvuuEqLxqd/8W BN8Mr6Vtp5RlPlhIS0aDAL4tc2Kue7ih0q+mZ5nlIO1PmaUqXIJ2gzpAUouWWKz40vWT ZEBQ== X-Forwarded-Encrypted: i=1; AFNElJ+T+SCNqiQkivqsgfJmBvdfT40UBI2bw/30MD606nzoiwoiQkfa24OfxjS62+dp7bLkpfYO/ItvMyGodZc=@vger.kernel.org X-Gm-Message-State: AOJu0YwGNtZCQjihu5o5R1Yx5QQw9PVSoWA9x9N8L4GcKQOJRXBhyPjI bKdWhj5+yp15nAbAaddDKg4gUpDKhJ6raBRLIxaZnNQmZvmrbPgT+mvz X-Gm-Gg: AeBDieuQnxMkYTaAu0z5CTXkARRwlUANrYWbgidRI+uph4hOx1lT8me6FkTWwihp6cW eFLlqMARQYHT7i5SRbZHnwNbf3QtYVx0YY01y7ZqWulKdTDTCow7gAdVleAdZSGoAInzgFbNwes 4XBrHrYLYOP1F0N00hG59+dcw73UrdYORFGzBxqjz9WV0KUnJLuQEd+Iisa9sxev1un8NSmoSIU gq4P4k/ooaT2HE3+tZ9XxOiXAsa/Ip1N3Ig9AiGkoboecVi/Slb91k3LWff0EkV7W9scLB2/zfy ie0SlQ6AfRaWE/EUVmjKKiTJHBznevzDtomUFCevRze1l+3OS1fN5sMELG526sMxNipCiSi/EIU J29tPtzR75b5Hzmfvh+6wRGEKr6RNS51+f23hIzBl4kQ3tdKsWHfH1oTbHdpynyrnr4c8u3Av9C mThSJnXerT4cU3g/+P0C7u2Zq4QW+zF/n3gka7IMJkkA== X-Received: by 2002:a17:903:3848:b0:2b4:678c:5f1f with SMTP id d9443c01a7336-2b4678c60a9mr90028585ad.0.1776266920513; Wed, 15 Apr 2026 08:28:40 -0700 (PDT) Received: from lgs.. ([2409:893d:1179:9a96:408e:b322:d944:7204]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b47810ae96sm34661885ad.21.2026.04.15.08.28.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 08:28:39 -0700 (PDT) From: Guangshuo Li To: "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] media: vidtv: fix reference leak on failed device registration Date: Wed, 15 Apr 2026 23:28:26 +0800 Message-ID: <20260415152826.3406217-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in vidtv_bridge_init(), the embedded struct device in vidtv_bridge_dev has already been initialized by device_initialize(), but the failure path returns the error without dropping the device reference for the current platform device: vidtv_bridge_init() -> platform_device_register(&vidtv_bridge_dev) -> device_initialize(&vidtv_bridge_dev.dev) -> setup_pdev_dma_masks(&vidtv_bridge_dev) -> platform_device_add(&vidtv_bridge_dev) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before returning the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: f90cf6079bf67 ("media: vidtv: add a bridge driver") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/media/test-drivers/vidtv/vidtv_bridge.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/test-drivers/vidtv/vidtv_bridge.c b/drivers/medi= a/test-drivers/vidtv/vidtv_bridge.c index b6203e10e37a..0b551981a5b2 100644 --- a/drivers/media/test-drivers/vidtv/vidtv_bridge.c +++ b/drivers/media/test-drivers/vidtv/vidtv_bridge.c @@ -592,8 +592,10 @@ static int __init vidtv_bridge_init(void) int ret; =20 ret =3D platform_device_register(&vidtv_bridge_dev); - if (ret) + if (ret) { + platform_device_put(&vidtv_bridge_dev); return ret; + } =20 ret =3D platform_driver_register(&vidtv_bridge_driver); if (ret) --=20 2.43.0