From nobody Tue Jun 16 02:37:02 2026 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B4EB3DA5AF for ; Wed, 15 Apr 2026 15:24:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776266641; cv=none; b=ZwAgT8lVQfJJhGk9F+HentWOae3BMWf5G+5fEFoomlbTxFWqsB/80gfk4BpDnRm1kfdHnwlyL9ay2jpykaYBvKcI34R3qMQJGX942LrrULNfLrC+zP2YnxHpRPTTnNxSOK4gMxfzHoDa7Uqn4wy0JpPBdQ+Fc8HIZ7tOO+Z3CUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776266641; c=relaxed/simple; bh=zWofefXAMoBIMWD0yGiB+cnjkunx6Q6U1CvnfYTDYNs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DUrwB8OaT3mi3KxBDukpOX10l6g0LdqFcxK3b3auaIEFmC5kaq1Oh9fz0etJ3v+4vlt2B+irdi6c/wNSF5JfCclD7HXx03WCmjJkEQSSgqbCjmjCJzoN7sBeXF5CVOgyFfG5Ue641Ok1TsKmD6M/eTShDydcMM30QNJRsT8YW8s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L3TBPJCp; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L3TBPJCp" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c648bc907ebso4822205a12.3 for ; Wed, 15 Apr 2026 08:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776266639; x=1776871439; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8ZxxH/dKWsV+bGW+MZF3EUGH4YsLgoDpr4lfqL5yS18=; b=L3TBPJCpp/Tri7IHqe7wXCwNlJ916xtl+IkLVFM3pwoHYGtIM4TU2GTE/VjRHbl3NC lu7LZPtqKEPJX2HLao3vJfGXpsFCAB1mn/8FjopnF83yXrV0/RT+XaiidawAvlKJC5bP i2WuOan9R4ZT0C2yOPB0PTyJUb2sF6ZVZloqWF1a7zFq+cw6xeBYDadCp/T6ZSHi50u/ 2iEXNmuaEs5hcbhOvQgOqHuXVjhVWqXYEOiX/Zfj5i4oAQEEIBYzAZrrSCNk+GSNDN6d 4gm0BsyaXOyV1T6flOw/f1IgPRTMN7G4uF6Xb5kKRIavC12VuUYRdc2GShE4f38Q9NxB c4Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776266639; x=1776871439; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8ZxxH/dKWsV+bGW+MZF3EUGH4YsLgoDpr4lfqL5yS18=; b=Xf6H39gC20RfYlmbGdCUjzauOk2RXUlNTFiAJSdShe+8C6bSS8kwOFgeIv10PLIFXO t9PskT3GU5QtRSxCVne5fgt1sZQYhYDCCN1rsBcM9ynQyYdq2h0GIFc3sDGDI7npk4p7 0A3ReXn0M/fc+usHfhCO9bdvqVOX3jo3PB/t//U4Q1F+V6U8VL2MFtuk7Iu5hjUW0d3t 0rOQXkrJE5wU98l0rGdC5PuDSoYJ1Rwg1C1W2bNRWxnOJb31yrl9oWH4fSO8w5a/F41Q iJxam+3ukaqfKEdEnPKcdEvpgir0qNLVGNKwsC+odEprpdH6+gApgJudb4XWg5hUeoGf sKmw== X-Forwarded-Encrypted: i=1; AFNElJ+nlsx42Yfv/CkXEHx6owgl0FnCx99y+NBLm7Impk8SpoFaK9I18N9EEGCHKTNG0XPPY6FBPYEscc89vek=@vger.kernel.org X-Gm-Message-State: AOJu0YxJyqieNta4M3aM4ILEJW+yeRI0IwlHNB5LaPaRjvYS/G/HLkOg TeOQoNZYkfyIinx27urzXJxjVv8m0FqO5dGivR2Qzl3qBOdvnTMTwkwVixVXivVZGcAFwbGm X-Gm-Gg: AeBDies2BDshWGbicpiVQNWD7kA66rD5TeInO+3fFFcsxNxrJ0yTc82X4AEUPACMjKl SNVnjpL3YCic/B/fKYZDCiV3P0raG2MBWaIMD7FLrfyMLHXLQFcjbq3cVE62GXQA1yqbN2B8DWT GAz9JtHgDfhcpwBGVfTiX2r9+Wk0RWbAg10N11z5qpTHUP3uOSjmKamT50uZcdPf6Fe4rWjTTKe +kpFgz32mq6gbsio7B/iZJ8q/YlTyJseWwxwdMAJKaZUEvVv1PAUnrUOwU/nqqPOh+7s4vk2sQJ MGr4/MVUCI0tlRwWs5HEVFalSfk19GGHNCxzvRlSmNh5THYabaP2RXH9/7HOn/sosm1c272HDzI D1GePErKdTmRZ3r5pJULIJEzRgM6AErsNlIgBwrOK9jJgFOGbyl5pVnW01Tc62FhkVg9wdVOuWz jveiTpsAvb2+ar1cSyXvAFwEk/S+AgdxmS9BtKhPsryg== X-Received: by 2002:a05:6a20:7d9b:b0:398:b16f:7045 with SMTP id adf61e73a8af0-39fe3f5d036mr23819827637.29.1776266639449; Wed, 15 Apr 2026 08:23:59 -0700 (PDT) Received: from lgs.. ([2409:893d:1179:9a96:408e:b322:d944:7204]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f6744c923sm2433719b3a.52.2026.04.15.08.23.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 08:23:58 -0700 (PDT) From: Guangshuo Li To: Hans Verkuil , Mauro Carvalho Chehab , Keiichi Watanabe , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] media: vicodec: fix reference leak on failed device registration Date: Wed, 15 Apr 2026 23:23:43 +0800 Message-ID: <20260415152343.3398025-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in vicodec_init(), the embedded struct device in vicodec_pdev has already been initialized by device_initialize(), but the failure path returns the error without dropping the device reference for the current platform device: vicodec_init() -> platform_device_register(&vicodec_pdev) -> device_initialize(&vicodec_pdev.dev) -> setup_pdev_dma_masks(&vicodec_pdev) -> platform_device_add(&vicodec_pdev) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before returning the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: 256bf813ba39f ("media: vicodec: add the virtual codec driver") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/media/test-drivers/vicodec/vicodec-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/test-drivers/vicodec/vicodec-core.c b/drivers/me= dia/test-drivers/vicodec/vicodec-core.c index 318e8330f16a..bf9a75feee93 100644 --- a/drivers/media/test-drivers/vicodec/vicodec-core.c +++ b/drivers/media/test-drivers/vicodec/vicodec-core.c @@ -2238,8 +2238,10 @@ static int __init vicodec_init(void) int ret; =20 ret =3D platform_device_register(&vicodec_pdev); - if (ret) + if (ret) { + platform_device_put(&vicodec_pdev); return ret; + } =20 ret =3D platform_driver_register(&vicodec_pdrv); if (ret) --=20 2.43.0