From nobody Thu Jun 18 08:02:35 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36FCB4369A for ; Wed, 15 Apr 2026 15:15:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776266107; cv=none; b=fuy/wZ8rtW6JOxTeOG2uOejVS/HsvFAQRVY+HTkEuNI/L4QXNIbxkWWG2l0XRibI6AZwV1n2h9RqBHIpTt/3fuzFyEwdZe6bf8OaEFs/f3vkEWutLVpCzm3J1/3ivQI3Kb34NG7DXas2Zk7G0g6d9IIRt83c9wiw8zewQsKaVwc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776266107; c=relaxed/simple; bh=bVYuDe6E8/tQa9JSwBETMmxVEyh0dqCHzU/TdSwyWIA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oh5dS2qGk7ztiz98RlK78eWOBtDJjdkl7D0ihmPSXzEabTXHB7/EQ+EkBGWhZAIu+/FI2/vGL464d4wEnotU6ylqzUpeOAF8A1T+fQXjpqHfGeli2C8THRmmtOhF6zOQ3lDBJ8QI1rZHURPQC2KtP8x2tzw2+yPUSrdbLFE8ZM4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=por+2Kl7; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="por+2Kl7" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-35fbca04006so1656279a91.1 for ; Wed, 15 Apr 2026 08:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776266105; x=1776870905; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jOR7w0F+ZPAedOetlmUBsNvlbtBWh+W8kyjE1x6Q9SU=; b=por+2Kl7llU4kio3dEoK9ylcoOw47w4SoJc/mkcF+qSuIN1HgpHLWR+pzey9BuH9sP d12oHw+KZEm3ngwzX9euD5yPN6/2v3ufQko6jKNxGfwnXSQm1XVpi9jLFTRhxmm+csD3 MyHA+FbgHghnJz6lGP3ax4LQvIScYo9d1eZlkWArhn/QemiLTcfn5jbRU4T2HU2Cn4cC 20nOMcqFHM90A4DTUrhsJWfdqIEN6OUtDQXkfIeuiTYYilKwI/Q3wdrGCtdUteXRjZ2H fKV/mLTYdyx4JU1wcrO3ntNJpHCFSAYqoTbl2Usc6tJkM3nkbxIHXG4ZdQPfuxtfcP/c 0dzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776266105; x=1776870905; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jOR7w0F+ZPAedOetlmUBsNvlbtBWh+W8kyjE1x6Q9SU=; b=bKg5naqa1Eo1rn0WxM+ZemEKDFtNFKIHZxgZDL+Vw/iqAIF5ots7ZUIH9+o9BkniR8 heiFu3UD06hLFWFwieTzxqCrP1ahlRGu2rmQnq9GLzZeEnYhFDB3mlnzMjEDhdVY20Om UA2ZgPHsfTGhBsUEI1QrjnjP0CtnKs7wf4Yez63WytqgSCufV4ve08LgyVbAP2cbx2O8 +CjO8j67vgTvx6/PTXyN2KeGDIAVcZHgg1ORkKvrJ9x/3ZjH+bjz1t24xD6YJY1yhNDC Akg1PA83QtkB3nJwvpfsRdcAyc83T7o2HoBo0ajkuXIO5HaVn+kQLrDIoKGTqtF5wkOR oXpg== X-Forwarded-Encrypted: i=1; AFNElJ/KpDYe3IywX8Mcyd1XPUhGNh7382vktKEucT3qqNlWBSsvhu9wr+KAdbk2iqf9YUP6jQT8lLlld5nc4Vo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxcto9dzcET69vFr1ZB5X76vLtl8edOl8KvHWDD2wqeUNidxKCD HfpCSER8U8uAtewyF2aDSIWDfXDUXaA0D0rCI/7B3LHJn5Y/oEabiqWq X-Gm-Gg: AeBDietW9jmZ8aMzJgblGKe+r+LG4DRWQ7Lc2FQAHdEd6l7XVA/WRzOWiTDWgthe+dc OM4gg5QnVO5ZQv4TRrBjRpsZcko7pE6CsoeTRMKyJihyP9cCztWllPqKNhxtKr19qThvth58Im3 /9cbuJmjV8Nq0ivf8CWc44YInKFTtbWxsgkjtUFfDzGCuIOZjvrBi0lEW8x42SNpagNwVlNfLuB JQhwhr1pcH/4Ar070D7RfSUm3sGFc+KSyIFOBGMs5udnJ4Wolj1iiHcBzpAP2zRcTDxSdsHxFHP WOCxX/h2d/n5eqIityI84mw5uDqyzQrX/+uKIKNpB2slHSJvMR7kNMwlZhkDCoye6k0668MAMtv bwXBUhVAp/SrEgutkXAx2MnaCW5zFiKruuvrtTrsoUBFXt0Is0+x5ZoiIKtB9DlRw+lBlaL2QqO Q4Ldn9EqRidENYvJ5kTdsy/YYWHlAY9Ie7qL2yrmQRTg== X-Received: by 2002:a17:90a:741:b0:35e:5723:85e3 with SMTP id 98e67ed59e1d1-35e5723894dmr10328629a91.9.1776266105215; Wed, 15 Apr 2026 08:15:05 -0700 (PDT) Received: from lgs.. ([2409:893d:1179:9a96:408e:b322:d944:7204]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35fd20d0c3bsm2458832a91.9.2026.04.15.08.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 08:15:04 -0700 (PDT) From: Guangshuo Li To: Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Matthew Majewski , Philipp Zabel , Sakari Ailus , Kees Cook , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] media: vim2m: fix reference leak on failed device registration Date: Wed, 15 Apr 2026 23:14:49 +0800 Message-ID: <20260415151449.3387235-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in vim2m_init(), the embedded struct device in vim2m_pdev has already been initialized by device_initialize(), but the failure path returns the error without dropping the device reference for the current platform device: vim2m_init() -> platform_device_register(&vim2m_pdev) -> device_initialize(&vim2m_pdev.dev) -> setup_pdev_dma_masks(&vim2m_pdev) -> platform_device_add(&vim2m_pdev) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before returning the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: 1f923a42033ad ("[media] mem2mem_testdev: rename to vim2m") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/media/test-drivers/vim2m.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/test-drivers/vim2m.c b/drivers/media/test-driver= s/vim2m.c index bb2dd11eef0e..80dc7edcbb5e 100644 --- a/drivers/media/test-drivers/vim2m.c +++ b/drivers/media/test-drivers/vim2m.c @@ -1601,8 +1601,10 @@ static int __init vim2m_init(void) int ret; =20 ret =3D platform_device_register(&vim2m_pdev); - if (ret) + if (ret) { + platform_device_put(&vim2m_pdev); return ret; + } =20 ret =3D platform_driver_register(&vim2m_pdrv); if (ret) --=20 2.43.0