From nobody Tue Jun 16 02:35:14 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD84E3806A6 for ; Wed, 15 Apr 2026 14:46:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776264410; cv=none; b=ZVGjU8SJnC98omEjSHSLTxrFvRlXKARsQFfJn9C8+9qkvEiKvV10Q5/yxxso5O/VIQvux6tn2VhGF5kcZzG8j0W9hU1xDTKjADF67IPOvAspV/lSjwj8BaXwJFjQXxoiYy/dWH/O1LjjYrRAr3VjOPCWudfRdG44sGkvs5hn4K0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776264410; c=relaxed/simple; bh=m5uBtB5w2V3z3lf06S5GGwOx4WottXt9NNdAXqDjePg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=InfwHQweXBI91yUR57Md5VOcpA1DmMQR4NTB8d/5sw/GruXtcGHCnUGuEY72NHfmLtRDgZcXQlRSKkr5jJnAuX3RkhJfwyaW6QzidCvAPPTvZBTDRvx9lJ52TgHzJcfMcwg4j5kzBU4d5OCFrrvo0FFduE33jMf00LBI/7Vsayo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jdRBwrLQ; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jdRBwrLQ" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-35d9923eec5so3980228a91.2 for ; Wed, 15 Apr 2026 07:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776264409; x=1776869209; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=znxX/LCQa33kO599nbk2Q/Mw7o66DJJuY9IEDvMYWxM=; b=jdRBwrLQSWBQ44CYFYi88TTo2u7PyIQMI71O7MdeBIUpmROJput4LPlL4X4ctp2TFk /1c+wIlivUILjd9XOGpZf7brnlxJhdCKx37RAIysZ+5dO1Bneb71kJcOx4rMjRSKDJ8m anuz1EhL/2wSa53OCrJEBz/E8uudmNoFdyELlPLVWDRbaqnk6lsrtSOVoFgkdqeP9H/L vAhGUohhEe4qUkMBNwuw1ZXdoO8LwCq5kW/CpGAvttUMwsUaJHSEoVb9wwCuH/kcpukH mlQMTEgjEVpGUKdv7VhVrygPM2usgiHBSkHHbtMlQGgV2QCHC23uH08VI8U7J+vDOLCm 29jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776264409; x=1776869209; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=znxX/LCQa33kO599nbk2Q/Mw7o66DJJuY9IEDvMYWxM=; b=pv6BuV5Ow23KbNYTisN2Ztrm46Hrrv+JfwtqLVQIYc9Sad6+0hhhqABprEiLHBuLk0 kR0TRvb4c0I43GKSBt6Ld9mp9A+OClIswmThg/BfbtvJaQcQEidC1nso7FiFq62mvu2F FdzQu/nXaPOy5Et9sD8iU5Veq0ryPBf+VNjM3mxOB4lRZpm13NtVdYswr9GknZApIe/h imc48fmz09QNm6PqUTttdaq3Qp6RSoy/G126RkFaLANbBWRmPb/opSFDhy5W7f1xDi38 H3AvykP3c6O81R2YdaHRFASuyA6YES1occDzqqi5QuMTyPVijGckp7p7hLCTz6ezoJUK gFfA== X-Forwarded-Encrypted: i=1; AFNElJ/P+ekIdiNU9l4NQ5ZzSyNlR4LXlLvFVxZISGFi9ZC2nK4HlJS2HJdwBGiwnyimow9owkLFN+WSbpUDJX4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7vwWYPUjhFHFaIYUkfe56IfdREML5ez5YmpvVZ6wINQRezW9x 9yvocQxCPQbryqQ4RfnMWHg+cGAxTZC8DPj6nhaYWE1qkUlrIf10HxDk X-Gm-Gg: AeBDieuP5WEaKXO+dUwrhg6AEVZM4JQtiNQ9GUNnZK4pznMOGp4OPwHtN0gPdvl+ckA dOnOHwiz4TogJbF27/PPJUnQnZgMClo3QlpsMNdTKQI3/RCT+3UrZc/9+V9odYYFXLySrQr3jtw F118eOdSZnFJzo8zQFOtlMnfeNW5MwMiAdu/Y3mxCc2mHrI3NOhhiqwW1RCi5/9lKTVvwFEP0VW zJ4DkEWnKGKL6Iyk3IwSHcYAoFTX3MDzFjbYQteWUC3IQ/UZ78nEeQWxy7IXkhAzMeZdt+vsS0c v8m7cWjrfo0rM15Zw/sErR4xpAd5BYaSqaBhh1uF/hiKEpUHCkzH4Jg9SClE1scon+kb0qhgr+q TgklRYDAuB5h6Ek6MFLMyPx5gTdaITgRAunG0ZYan+E9kzzFVdn+l2tnJbZplG3JYk0bNfoF2cD uSgRtRA1Zum0x/qq2pOjM4EtwxxWBJ3Ipg X-Received: by 2002:a17:90b:4a04:b0:35b:e550:e68a with SMTP id 98e67ed59e1d1-35e4254fb13mr21922246a91.3.1776264409084; Wed, 15 Apr 2026 07:46:49 -0700 (PDT) Received: from lgs.. ([112.224.67.108]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35fd308cf98sm2310617a91.7.2026.04.15.07.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 07:46:47 -0700 (PDT) From: Guangshuo Li To: Guangshuo Li , Paul Mackerras , Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] macintosh: windfarm_core: fix reference leak on failed device registration Date: Wed, 15 Apr 2026 22:46:35 +0800 Message-ID: <20260415144635.3318697-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in windfarm_core_init(), the embedded struct device in wf_platform_device has already been initialized by device_initialize(), but the failure path does not drop the device reference for the current platform device: windfarm_core_init() platform_device_register(&wf_platform_device) device_initialize(&wf_platform_device.dev) setup_pdev_dma_masks(&wf_platform_device) return platform_device_add(&wf_platform_device) This leads to a reference leak when platform_device_register() fails. Fix this by checking the return value and calling platform_device_put(). The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: 75722d3992f57 ("[PATCH] ppc64: Thermal control for SMU based machine= s") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/macintosh/windfarm_core.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/macintosh/windfarm_core.c b/drivers/macintosh/windfarm= _core.c index 5307b1e34261..4003e72f3a57 100644 --- a/drivers/macintosh/windfarm_core.c +++ b/drivers/macintosh/windfarm_core.c @@ -436,9 +436,14 @@ EXPORT_SYMBOL_GPL(wf_clear_overtemp); =20 static int __init windfarm_core_init(void) { + int err; + DBG("wf: core loaded\n"); =20 - platform_device_register(&wf_platform_device); + err =3D platform_device_register(&wf_platform_device); + if (err) + platform_device_put(&wf_platform_device); + return 0; } =20 --=20 2.43.0