From nobody Tue Jun 16 02:36:10 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 849CA32FA18 for ; Wed, 15 Apr 2026 14:37:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776263835; cv=none; b=CaT7T4+KbS+TqXzTmWPBNcL0vE9ptm4eXJ3CVrn4XeidJV62/kT/yOHCdRlEa7rG0RPuEtWXypIJQ8RVpiRvdcJrvUpJypJfF3+IJB+xkdJmVcwNjNuS2dK2ueJD6qscwdfwGkTMxEnOneE2D5orniist/ABqGdYjsavHvxL/fg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776263835; c=relaxed/simple; bh=NqQZvRyGr1pP+uxFovjiYK14xw8qS22yayjPmz0El3Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TJoRwxoo3gfpDQNJvScd8v04lysHlbzl1MXaIj2k64BLDY2gszsvqJVPzcL66k+Pm7a938ef1L4G52Rj6OYFUULfPs2ybuOA2kdzzj1g+TDVxoZUlLu8MpxIfZKJw2ntOFwZoWcajoVTdqAGseP/N1fKhIYTd+2Dr3EQSK9JWmg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QC/nShUd; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QC/nShUd" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ab232cc803so34728715ad.3 for ; Wed, 15 Apr 2026 07:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776263834; x=1776868634; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=98VPopI4qbGCT1pqdO2A1z/c8E+zsHJEMVeJSMI3VR8=; b=QC/nShUddKuWwOSwPyt0vldYrMNZBsKxJd0PuYIpTq/CZRDwarN0AvNqmFG3u3iuTC 1vYz69La9R7eSkGHi32VMQmJut0zW8k27/svQZx5LHuDNstoqk7C4EqtxsSaFVTPVPSm a3SVGgZsixBzzVK/ATWGU3EARTBQ6ZxXsicA1jEQY5ELjcvpzJZDIMW2lpbGTLIBAld8 ogDfABI/o1LNvcNVURD1w7Qbz1DkgV7z6QrHTe4vrUU/PThla/xehplS2mWTU8lajMLB 5bOiEEfJ+gN2p6/m0us9asNmOjo7TOa/wJMsVFalwgDt+NzFKBBPSsGPY+C5KKQ4bbBW Uhhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776263834; x=1776868634; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=98VPopI4qbGCT1pqdO2A1z/c8E+zsHJEMVeJSMI3VR8=; b=EGST4gXCLpM5wQHxDLwStwkK97GbG+YDuSP9LVYo0R65Damjb0RIz0bWCe2T1iqEKB DqpM6YVQvu6veimQqyrLrPhJK4/ILAtB5o+pxYhovtRwEx673EzeNCyYZdG2JkgE6vvZ EpbI3i7kausH2CzlzquIe4aLmYO6pACSduRJrlsu+VYMFH/j9v4olpHCdyzS8DKeqiu3 bjEJ8cMDboRamJDV4fveDSzN2Cqau4LXgRA32N36xETTjKnaIr/lDoBd4UgckyvF0d7R Q6UcUOENHv9xIwIEIMBMpbcsUf+EdXXEfb9PZSUIymMxGmrOFL200Vzxz5qNrobPlHYR wAMg== X-Forwarded-Encrypted: i=1; AFNElJ/DiU4MzkKzzGKwgm+BVV3HhN36AuSJVWj/rLxivbJ6LmoqImBgG0pZY7Ca2w84t85tqOPN3guAhLvFT10=@vger.kernel.org X-Gm-Message-State: AOJu0YwMIxEZ22qtv9z2Uz9cfdCK5NrFr/yYd/5PaMoGDU2+IknMnl3f yMQ9wEyMnhg0eEPvvs7H0GGi64an1h6PQywDIKs0K6ur5HcVGMUzbddw X-Gm-Gg: AeBDievudfBAJ/nojpGM3bqBKKDhX229ID/T43zgFevyxuAOU+qHvGrOPr58sEm5+d5 hIrPbvif9HZ32yXgmasZZrkf3BJoDb5vwEWrXbkp1uMyCeQ6DQYSnLz7MMfcHyX09BfcHWlcpYP JTTBaJjj6GNvfKzOWn3oDSpMA35sOyxkCu0e6lwj+VWiBgemT/ysL2IHtGsPLPRIY211/gLlkax RhyzTshcUfqSeGS9pFtfixwXFdvcR1DcA04ZDYUnngcbZCuHNfZzT6IEmK2jAXU5Nq2U6i7Hgfu jeliLANCf2nnm0un2vkgdawoMAmaLxFf7TVem1JgQAy03WGrzTFsVs5/BbPNWXzbi+qpNsDamYB NVgTWYwbySBGO/AnR0ndH6+SSST5Hq0EKyjQaJdQDb3Q+SwD1UloNed4AnBBJouAyfZLMPbeD/7 GdUxPYh/SoHLzs/1RxWG3ABpvTGuwsjfvT X-Received: by 2002:a17:902:9308:b0:2b2:5503:1b8c with SMTP id d9443c01a7336-2b2d59b9facmr176124965ad.11.1776263833795; Wed, 15 Apr 2026 07:37:13 -0700 (PDT) Received: from lgs.. ([112.224.67.108]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b478142565sm22902665ad.37.2026.04.15.07.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 07:37:13 -0700 (PDT) From: Guangshuo Li To: Guangshuo Li , Kees Cook , Johannes Berg , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] macintosh: adb: fix reference leak on failed platform device registration Date: Wed, 15 Apr 2026 22:37:01 +0800 Message-ID: <20260415143701.3309681-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When platform_device_register() fails in adbdev_init(), the embedded struct device in adb_pfdev has already been initialized by device_initialize(), but the failure path does not drop the device reference for the current platform device: adbdev_init() platform_device_register(&adb_pfdev) device_initialize(&adb_pfdev.dev) setup_pdev_dma_masks(&adb_pfdev) return platform_device_add(&adb_pfdev) As documented in platform_device_register(), the caller must use platform_device_put() to give up the reference initialized in this function when registration fails. This leads to a reference leak when platform_device_register() fails. Fix this by checking the return value and calling platform_device_put(). The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: c9f6d3d5c6d4f ("[POWERPC] adb: Replace sleep notifier with platform = driver suspend/resume hooks") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/macintosh/adb.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/macintosh/adb.c b/drivers/macintosh/adb.c index fe150125e099..eff06f78aa80 100644 --- a/drivers/macintosh/adb.c +++ b/drivers/macintosh/adb.c @@ -883,6 +883,8 @@ adb_dummy_probe(struct platform_device *dev) static void __init adbdev_init(void) { + int err; + if (register_chrdev(ADB_MAJOR, "adb", &adb_fops)) { pr_err("adb: unable to get major %d\n", ADB_MAJOR); return; @@ -893,6 +895,9 @@ adbdev_init(void) =20 device_create(&adb_dev_class, NULL, MKDEV(ADB_MAJOR, 0), NULL, "adb"); =20 - platform_device_register(&adb_pfdev); + err =3D platform_device_register(&adb_pfdev); + if (err) + platform_device_put(&adb_pfdev); + platform_driver_probe(&adb_pfdrv, adb_dummy_probe); } --=20 2.43.0