From nobody Tue Jun 16 02:35:41 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C97563D3332 for ; Wed, 15 Apr 2026 14:03:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776261814; cv=none; b=HJDj26BNS8qcndKOKceZCMAL3ENP2RzV7yAzxc1g8C7VUdPwxhApPPRPgm2DsZcUr1c3wUkIY2CQ0YX5U00yHarBn8NcncHgjIltbO0C5sEWDxZEJvdg+3KQAtz24d50tN6MuNUPJr2oDizT6eq8jtcOJjGlDtlO4b7Jx4C2t5c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776261814; c=relaxed/simple; bh=xZCNB5AGwD2i54N1tNoj/rxbNf8IRBctcXt31dr4tTI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Awu42OnIxVsX9LjWSd1aNZnaLir91zFg8iZBuuTv7whxwnmrR4v1p7LvA5yDvE4yF2E/fuUcwn+M/UW/lZtlA05CK/wP/KQesnz3huFIvZ/I+ShTZgTpRgqzL5J5D+ni28kbJgWDUi82nVdFM1v1YhyeixpczOhBFdfV4XaW7l0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pOonx2sX; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pOonx2sX" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-43cfce3a195so4260958f8f.2 for ; Wed, 15 Apr 2026 07:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776261811; x=1776866611; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M+9O+2yusy0azBv2IUrWWCy6DoGfMuUXE30z4MsaSig=; b=pOonx2sXmZOoOgRUa7tPERmoWq9kdFDNTZbk+feWAxRRWO1z2E96oBp62QgCfjHxUI jM9IQhIMsdCos6idTsvfi+Ofy+hVvUK6PPcJ3jg7mMdGWH8GgXIwZVXIfinlD/DYfmyO mCUVeEgyOTUTANPrjGtDe+dumdw/+m6zvmYepRc2namW68/Y00NQRnX3qtk7nTPax/45 7VKtqt2mFNIvzJiAcHz2Xf/HlXviva1/vGVO+54Pf+QE/FV7Lzh1ZJqf2SNbjU6jY5Ji RJRswbSE/f7GbwhAjHEQFF3KmzOYVlJoKIiBRgIJj40T7ryknRzRld6iSuf5h/cABJdi /fWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776261811; x=1776866611; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M+9O+2yusy0azBv2IUrWWCy6DoGfMuUXE30z4MsaSig=; b=SyTPv0xNJvnPtWJCdp5N5JoLqYnLFl1Uq/pmAZXRQgYHeOpOnlxNka/EjHuhUVHaAn yyaLA4BWE54b8Ba8puM4nmVFeruohSaR2S0ciuAoM4CK01tEKcjzIwd75gTWFE9ZdHkn wfqBcZs0MJM7oqbDE0KIzzTh84dUb6qmi8Y/TQ8u8QYJxEYDpY9vhjcgnS3ZjD6oDiiK Z64eyd9mGI12G+7WZFfuynywn4lbvqGKRbzSUf6KxYiL1vkufQm6x11NvvoBV54K11Oj o+EbowzB3B/ZTHQXpLYDO05Y1U4vwy2+A+FShOdZ1dhpvuoi6uCc8IDSZ0vQIiXlgf8D UAdw== X-Forwarded-Encrypted: i=1; AFNElJ9P8BuyK/Xc25hlU/8fQEcR0Wi/14XixfZybi1QOg2y3SMeOOQTzNqf57mgCu8gCg0e22dSvszDVrd53zk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz55pnLMqzE/pHYxHm5FTRXIlsGE0X1xVFjrO9pwZE4obcvKEHb 0SyEH4ADFDJsO62ciFNLDLNqvjWfHWz8QTWtn7iiL3OD8KaPOxJcptmb X-Gm-Gg: AeBDievlGPdwtTDRcgGWX0eOfmvJtF+iMBlt2M9ul1oi6088MQkM1gqPQJDwAqv2zvf Epac1G8mC8r5xZ/96/CpE7kAFXQ6XgQaYQobBx9pPk4ltGJ62bersfKcmzwt0ixO/eGsUrw62SV 9A+MxoUV7lVe0t+AwobZsRxfNZaRfyYLTQ5Ec2Lzb7oBypiQ/Lgvf1PzHbFudS0NLrit78fGu36 UH2BQ0ZLZ7Wb8Gyf//oNtVeMmlNp38CCYKSJK2dKib6w+tVJ4e9w9SYTe7krj2tQoQsOJuyXinV ZrSYaScxYCmLUVwwonw1pw6Op9t9Ax5wkHw5Ni3VQSUc76dB7tv73Ix3bBDdspRMpSaaOT3ekxw 8tuqh0Z3EPbj1QAuTTh61HmKVRHXcZIcS9WWhZKfshwrihJbznKV2J7Z6m9lhFXm+ceYyQvf/n5 SMkA/t4iKfzzvv+3QUjNoTDe4= X-Received: by 2002:a05:6000:24c3:b0:43d:762e:76c6 with SMTP id ffacd0b85a97d-43d762e7865mr20314195f8f.7.1776261811135; Wed, 15 Apr 2026 07:03:31 -0700 (PDT) Received: from yocto.. ([2a02:3037:600:3ec1:dc49:d3d2:7f37:6734]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43ead3d5f11sm5883236f8f.18.2026.04.15.07.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 07:03:30 -0700 (PDT) From: Abd-Alrhman Masalkhi To: song@kernel.org, yukuai@fnnas.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Abd-Alrhman Masalkhi Subject: [PATCH 1/2] md: replace wait loop with wait_event() in md_handle_request() Date: Wed, 15 Apr 2026 16:03:18 +0200 Message-ID: <20260415140319.376578-2-abd.masalkhi@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260415140319.376578-1-abd.masalkhi@gmail.com> References: <20260415140319.376578-1-abd.masalkhi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The wait loop is equivalent to wait_event() and can be simplified by usaing it for improving readability. Signed-off-by: Abd-Alrhman Masalkhi --- drivers/md/md.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index ac71640ff3a8..ba2b5fb2740e 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -397,20 +397,12 @@ bool md_handle_request(struct mddev *mddev, struct bi= o *bio) { check_suspended: if (is_suspended(mddev, bio)) { - DEFINE_WAIT(__wait); /* Bail out if REQ_NOWAIT is set for the bio */ if (bio->bi_opf & REQ_NOWAIT) { bio_wouldblock_error(bio); return true; } - for (;;) { - prepare_to_wait(&mddev->sb_wait, &__wait, - TASK_UNINTERRUPTIBLE); - if (!is_suspended(mddev, bio)) - break; - schedule(); - } - finish_wait(&mddev->sb_wait, &__wait); + wait_event(mddev->sb_wait, !is_suspended(mddev, bio)); } if (!percpu_ref_tryget_live(&mddev->active_io)) goto check_suspended; --=20 2.43.0 From nobody Tue Jun 16 02:35:41 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C94633D3491 for ; Wed, 15 Apr 2026 14:03:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776261820; cv=none; b=AfusWOFNYcjSd/S0gImOyVga2g0yQCby31OYayC3uNCDsZAC7vXoWgHNlcT0LeeAsbng4QxZ7ZGbmfp7BQyOdP6fXzFGS3l3nyKEOL3Ls0q+IDAO7bpSTIw5shoTRo2lnHidOR+V1i1oPKIvHiLUAJPy2tCrrwLtg/patXOVm2M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776261820; c=relaxed/simple; bh=nnqGXxfnnV6yNYjoTKzb6sLDEfx22RM+l60ckx5zKbI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dVMzZ7chZe1bl+fbfTYrXWTJYXbjACEpip5tlAODPvJUPTybNNuR3Gd/Apd9zV5KijWWk4iz28m2nM8zaIR234x8EMT81wRRQL7Ql2xztOsdzpiVBDRStZAQI7mYlTvlJNZyWvIoSNbNjl295yUqEwbyiKZH9pNE7CAuVirX2aI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d2Hc1EoW; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d2Hc1EoW" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-43d03db7f87so4289206f8f.3 for ; Wed, 15 Apr 2026 07:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776261816; x=1776866616; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v5OxviYtQlzPzCVpCit04f/ikT/J79HQqEij8t457Xk=; b=d2Hc1EoWWUYxczH1hO+hFHE8888qA2Y6EeugT08/cB+zINTeFyDHiGwtdXNcFeLXWa UfIIeDGM8nQaxm/HQt+5lsKCzTRcwBxfhpykyu5OB9/mKnn1x0oghXn4Fxw4LxZ1KX5r tJhg1bXTXQpLbDasqjv3BrDAMNOKgn9WHM+Qcv9UAiFu6Hls0CnSd+MM9prSgqBAuvRE FYQ3kBTZn2fqTW5emgNzkxTZcvOV4mfaJ5+6Sm9BYLMzOe8GW6hNfmrb9RAGQPL05BaZ bvqKJJellLUR/mZc1v1KrSJk4I7hiu0RUZmSdWMshveynoUaWvcORiHwYyWE1tLVvZ2r KWaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776261816; x=1776866616; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=v5OxviYtQlzPzCVpCit04f/ikT/J79HQqEij8t457Xk=; b=pfd0c/UdlHizm90KUNg5082aEPJFHaLW5h9/ausOhqjOYzzGWS0K/dCRlOcQznJofv ZU1/gD0dAdy1ZptmKA8Uv7jWdDtYH2P6xB/OQo1MPK7XyJmLkX9VaPqRR6MwMZly23YW W0+YUrWYRjpfUu+lcfz98sTLpkwRFDeb3XhczbpFSIzIprg41lpKNKKIcF5YcP5VnNWE 05+mmVrY62CCGLxMVF/sxpSmPX/s+DNub0I1k9nZmFIswo9NBvmIaVdS+BBhfini4rXZ pBAW15Xzn2LFdl6/5jMVKwnSIJW7lbbLy3qlb/hpgpLZgYhLUYj1dOrqko/fXdESrs8f OPLg== X-Forwarded-Encrypted: i=1; AFNElJ/kISaFT9g9UV9nEHcAYXo858U57IG0IElcXLF/1bw7wMREi1U6fENzpnKRgknhSCTH9orYA7qroQD3ovM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9abWNb8QsZ4EFmOsqBlu9Cj+lhp1FQY5wwSjYp1GA9vDNzj7y nSDRphnjb1+ibOOlAioTryhY9BGUQsPmKkAHS4TW5lSBfQGIaqCkbIWl X-Gm-Gg: AeBDies6gJ1Fj8G+Sxy7YSZMUE9b+tggrjIPfVcnXQ8t0XukI01kTdMafK+MN8+HJTc lbU8uXNGFxgrsM2zfN/uKFHrhNEpm/shl5soZ+zLvyFj/WeVr+gVmxXE9b20sQxI7UJPA4PEPWn rE0vUGIMElmIWRV4DuIpMXhduu89q+yVicscADJuMRJaE5acXFkv+i0uKtynk76M0fyp4aOn2l0 9+k5RY1XgYL3qMGLA6vnZuG+/sKKS7zWE6/aGf3QgPdB3uQRX0KxJzVmJTgBhxCYMOQ8Rr9XoiZ Qh0Y26lKOHd90RM+Q/EoQ5cWzGt9R/McbH/+lg0q2GyMJ2Jp6dj2HjGKmLfLzhmuZt++R3Dw1vW ZOtwhNbLrJc8F+Trr6aONvmiJRi0w25ytbuF1Brpmfm9Qeoa8hzASzBYMXcv2Vv0OOxV138S0Ce OJrwZ1g0evFs6eaLuyX+iPf3M= X-Received: by 2002:a05:6000:2288:b0:43d:7508:c9b9 with SMTP id ffacd0b85a97d-43d7508cbaemr21744288f8f.49.1776261815853; Wed, 15 Apr 2026 07:03:35 -0700 (PDT) Received: from yocto.. ([2a02:3037:600:3ec1:dc49:d3d2:7f37:6734]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43ead3d5f11sm5883236f8f.18.2026.04.15.07.03.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 07:03:35 -0700 (PDT) From: Abd-Alrhman Masalkhi To: song@kernel.org, yukuai@fnnas.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Abd-Alrhman Masalkhi Subject: [PATCH 2/2] md: use mddev_lock_nointr() in mddev_suspend_and_lock_nointr() Date: Wed, 15 Apr 2026 16:03:19 +0200 Message-ID: <20260415140319.376578-3-abd.masalkhi@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260415140319.376578-1-abd.masalkhi@gmail.com> References: <20260415140319.376578-1-abd.masalkhi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This keeps mddev locking consistent and ensures that any future changes to locking behavior are done through the wrapper. Signed-off-by: Abd-Alrhman Masalkhi --- drivers/md/md.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/md.h b/drivers/md/md.h index 3bfbee595156..09ced132a917 100644 --- a/drivers/md/md.h +++ b/drivers/md/md.h @@ -1013,7 +1013,7 @@ static inline int mddev_suspend_and_lock(struct mddev= *mddev) static inline void mddev_suspend_and_lock_nointr(struct mddev *mddev) { mddev_suspend(mddev, false); - mutex_lock(&mddev->reconfig_mutex); + mddev_lock_nointr(mddev); } =20 static inline void mddev_unlock_and_resume(struct mddev *mddev) --=20 2.43.0