From nobody Tue Jun 16 02:35:14 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C99D246781 for ; Wed, 15 Apr 2026 11:29:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776252574; cv=pass; b=etao4nMLiSKyKy0hEkqgNP10fmO5+X9TkVGzwCqoOo/OxxKMnqWRzG4QQVAxNzCr55lhPjJodgtDZCHkdH7ucEfjqoBpoZB/gPct609/Mdn3ZujhItV6DedDKu7fj0tYDMfDegy+tSytBOzNs93E7+NucaNM+P01np4VXNEOX0Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776252574; c=relaxed/simple; bh=dgDlvcttz+NexmouzwXPoXMyK+iq3oOI8rBlHCXIGKE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YfDqNv5fol+inaH/3DTcQaBlFzA5uvd4jF059gES+4vkOfPI5D4cOVsbDfk2e3kGMcDA1rcvNR8XMP6l1y2z4oCFiRpiHud/QGQE7gFAjUU4e5dsejr4O1ckADKXLLRpzVWZ6DV5ZkiXQIu99WYC+GTrby/F0BxsPIoK2Xualk0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=Hxzoug34; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="Hxzoug34" ARC-Seal: i=1; a=rsa-sha256; t=1776252557; cv=none; d=zohomail.com; s=zohoarc; b=F6E2ilsS8a+Pp2Ic27pZs0JfB7FMyc1yqkpmR6BTCerb8wO2EM21DYSoqOBV7fFJIGhMHVb11bUkz6w/8YlS1OOdYiuMxGabhJrm7INaot/id9NO8tDWM3Y6qmv8cY9X7Y6mq+66D8PW9qkC5kxsCbAUqbCybCsWZtzC2XQq1Ns= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776252557; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=rm7r+iHzGolsHKD5Oxo172Zwq8rkv6pbwUdLvRgGrMs=; b=aV4d7VFzaa3N3YbR7y7SKO6e7/0TxES85BfxqOXSu4RFa40FpLJl0D7VHYowkpLefyhughHKcF0dgxuXV3Tup1+9i0KT6o7wN0liQUmdskyFrsYMzfGMW6NzXjDtErLzhBULjEHAvCr0L0PtRcsPsR2XehzHyCgIN5RZ9LD3gZ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776252556; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=rm7r+iHzGolsHKD5Oxo172Zwq8rkv6pbwUdLvRgGrMs=; b=Hxzoug34W57Bv8nyKNBu3sO3+JYyBnvKNPa7xC0/Mu3A30FTvWGOJec1mnvJoI1A DnzU2b5VnGtMLP5qU+SJxqyVR93nnxerjtstCklH7smUf3X2oz9hNVcwyk9xmLDhC8a e2lbFddDPVKVaxoUVr06RjKchZ4q2+IadHOsRKkY= Received: by mx.zohomail.com with SMTPS id 1776252554907344.80115603567106; Wed, 15 Apr 2026 04:29:14 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Daniel Almeida , Alice Ryhl Subject: [PATCH v7 1/6] drm/panthor: Expose GPU page sizes to UM Date: Wed, 15 Apr 2026 12:28:45 +0100 Message-ID: <20260415112900.681834-2-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415112900.681834-1-adrian.larumbe@collabora.com> References: <20260415112900.681834-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable In future commits that will implement repeated mappings, only repeat values multiple of GPU page sizes will be tolerated. That means these values must be made known to UM. Do it through a queriable GPU info value. Signed-off-by: Adri=C3=A1n Larumbe Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- drivers/gpu/drm/panthor/panthor_device.h | 3 +++ drivers/gpu/drm/panthor/panthor_drv.c | 8 ++++++++ drivers/gpu/drm/panthor/panthor_mmu.c | 9 ++++++++- include/uapi/drm/panthor_drm.h | 13 +++++++++++++ 4 files changed, 32 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panthor/panthor_device.h b/drivers/gpu/drm/pan= thor/panthor_device.h index 5cba272f9b4d..d856a4fe1d61 100644 --- a/drivers/gpu/drm/panthor/panthor_device.h +++ b/drivers/gpu/drm/panthor/panthor_device.h @@ -158,6 +158,9 @@ struct panthor_device { /** @csif_info: Command stream interface information. */ struct drm_panthor_csif_info csif_info; =20 + /** @mmu_info: MMU info */ + struct drm_panthor_mmu_info mmu_info; + /** @hw: GPU-specific data. */ struct panthor_hw *hw; =20 diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/pantho= r/panthor_drv.c index 73fc983dc9b4..a8090bc4e33c 100644 --- a/drivers/gpu/drm/panthor/panthor_drv.c +++ b/drivers/gpu/drm/panthor/panthor_drv.c @@ -175,6 +175,7 @@ panthor_get_uobj_array(const struct drm_panthor_obj_arr= ay *in, u32 min_stride, _Generic(_obj_name, \ PANTHOR_UOBJ_DECL(struct drm_panthor_gpu_info, tiler_present), \ PANTHOR_UOBJ_DECL(struct drm_panthor_csif_info, pad), \ + PANTHOR_UOBJ_DECL(struct drm_panthor_mmu_info, page_size_bitmap), \ PANTHOR_UOBJ_DECL(struct drm_panthor_timestamp_info, current_timestamp)= , \ PANTHOR_UOBJ_DECL(struct drm_panthor_group_priorities_info, pad), \ PANTHOR_UOBJ_DECL(struct drm_panthor_sync_op, timeline_value), \ @@ -946,6 +947,10 @@ static int panthor_ioctl_dev_query(struct drm_device *= ddev, void *data, struct d args->size =3D sizeof(ptdev->csif_info); return 0; =20 + case DRM_PANTHOR_DEV_QUERY_MMU_INFO: + args->size =3D sizeof(ptdev->mmu_info); + return 0; + case DRM_PANTHOR_DEV_QUERY_TIMESTAMP_INFO: args->size =3D sizeof(timestamp_info); return 0; @@ -966,6 +971,9 @@ static int panthor_ioctl_dev_query(struct drm_device *d= dev, void *data, struct d case DRM_PANTHOR_DEV_QUERY_CSIF_INFO: return PANTHOR_UOBJ_SET(args->pointer, args->size, ptdev->csif_info); =20 + case DRM_PANTHOR_DEV_QUERY_MMU_INFO: + return PANTHOR_UOBJ_SET(args->pointer, args->size, ptdev->mmu_info); + case DRM_PANTHOR_DEV_QUERY_TIMESTAMP_INFO: ret =3D copy_struct_from_user(×tamp_info, sizeof(timestamp_info), diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/pantho= r/panthor_mmu.c index bd41c892beb7..01577be88933 100644 --- a/drivers/gpu/drm/panthor/panthor_mmu.c +++ b/drivers/gpu/drm/panthor/panthor_mmu.c @@ -2769,7 +2769,7 @@ panthor_vm_create(struct panthor_device *ptdev, bool = for_mcu, refcount_set(&vm->as.active_cnt, 0); =20 pgtbl_cfg =3D (struct io_pgtable_cfg) { - .pgsize_bitmap =3D SZ_4K | SZ_2M, + .pgsize_bitmap =3D ptdev->mmu_info.page_size_bitmap, .ias =3D va_bits, .oas =3D pa_bits, .coherent_walk =3D ptdev->coherent, @@ -3214,6 +3214,11 @@ static void panthor_mmu_release_wq(struct drm_device= *ddev, void *res) destroy_workqueue(res); } =20 +static void panthor_mmu_info_init(struct panthor_device *ptdev) +{ + ptdev->mmu_info.page_size_bitmap =3D SZ_4K | SZ_2M; +} + /** * panthor_mmu_init() - Initialize the MMU logic. * @ptdev: Device. @@ -3226,6 +3231,8 @@ int panthor_mmu_init(struct panthor_device *ptdev) struct panthor_mmu *mmu; int ret, irq; =20 + panthor_mmu_info_init(ptdev); + mmu =3D drmm_kzalloc(&ptdev->base, sizeof(*mmu), GFP_KERNEL); if (!mmu) return -ENOMEM; diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h index 0e455d91e77d..dc2704fc2829 100644 --- a/include/uapi/drm/panthor_drm.h +++ b/include/uapi/drm/panthor_drm.h @@ -246,6 +246,9 @@ enum drm_panthor_dev_query_type { /** @DRM_PANTHOR_DEV_QUERY_CSIF_INFO: Query command-stream interface info= rmation. */ DRM_PANTHOR_DEV_QUERY_CSIF_INFO, =20 + /** @DRM_PANTHOR_DEV_QUERY_MMU_INFO: Query MMU information. */ + DRM_PANTHOR_DEV_QUERY_MMU_INFO, + /** @DRM_PANTHOR_DEV_QUERY_TIMESTAMP_INFO: Query timestamp information. */ DRM_PANTHOR_DEV_QUERY_TIMESTAMP_INFO, =20 @@ -487,6 +490,16 @@ struct drm_panthor_timestamp_info { __u64 cpu_timestamp_nsec; }; =20 +/** + * struct drm_panthor_mmu_info - MMU information + * + * Structure grouping all queryable information relating to the MMU. + */ +struct drm_panthor_mmu_info { + /** @page_size_bitmap: Allowed page sizes */ + __u64 page_size_bitmap; +}; + /** * struct drm_panthor_group_priorities_info - Group priorities information * --=20 2.53.0 From nobody Tue Jun 16 02:35:14 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E3732E0938 for ; Wed, 15 Apr 2026 11:29:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776252574; cv=pass; b=o/hT2AdSP/PwI65lGUspGKTr7R71um1cMGGkF1jxLP3LMDRjLZizvf5hpP9VDE03L0mR0n7JEXw0AYy5BZKjiAEIoshF/qOVPZLnk9sRPCGSrh9HEZCIPIIbFB+ajw0+gqr5kLKLQkK0Codyghz3u4Dq49cYXwrH2qQQIVm/lFA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776252574; c=relaxed/simple; bh=lEELtu649mIxp/coN0ufCwjc0WNX2yYcjKc2AxtDCo8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VSyLVbl/xJ7EqgijXZgaOokquk8rPiMWZvrciA5Fy+IDAPI0MpwdMKg4mmVNnr+fGZ9cSyr9YeE+i3gVUkYuA6yMvwA4QVJcoMv1OXFn1/YchSIW3+X65DJwqG7V9AvW4Pd77S0yOk8HaOpD4JrZ7oXkIOIM3HWh1SRE6v8DH50= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=YDTcxhXT; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="YDTcxhXT" ARC-Seal: i=1; a=rsa-sha256; t=1776252559; cv=none; d=zohomail.com; s=zohoarc; b=flpcwXNf3P1ZqZVzZRGHF54K0XeRkByVcCDNrK4PgE8q35dR4ZUZvPHzUNX19NRELFrmEjrKc77IY88PddlsiKpDtZNZuToZY9JopgcgbJhhHfvek9YAVJMmjUZmsS9Y7OTFDEWIQXOzB26eyWcynJylhiT/nXSMXGOgDUozO2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776252559; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=+us61HS1yypW3YfiPHD7RIrPV7DiXzvZ+vs2nwC2ZkA=; b=ULatOeLDl8ktk+tiQ8sAFg+uL4ehKUdQAi2GnvjTIUM4AVKOjgwskB2OkKV26KBChmbniX0oy6i8Jc3i1uJi2zXNLVmqPvttraeRYPPtgOZQect3pAu6VBxMa94/HoJ0+xE5UGRSc7xD/4rBowFDp1c52b8Zw1H9aVsKUcd5ExE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776252559; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=+us61HS1yypW3YfiPHD7RIrPV7DiXzvZ+vs2nwC2ZkA=; b=YDTcxhXTzZ/C4gqb/3ADEzZ0lwAc2wVJynfMGNXFFjX9jRbbzh/ENeDlz3DJZhW/ 6Nlpe+z2EOA2TowfBTi//OyH+ko5qL2uYWULtsuFlnVti8EiXGm66p08GtGUMVZBOAW oRhxUo9n9BYJx1vJvUgZ7sdKRjLljXOHkNVEea6g= Received: by mx.zohomail.com with SMTPS id 1776252558038203.00113704931823; Wed, 15 Apr 2026 04:29:18 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH v7 2/6] drm/panthor: Pass vm_bind_op to vm_prepare_map_op_ctx Date: Wed, 15 Apr 2026 12:28:46 +0100 Message-ID: <20260415112900.681834-3-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415112900.681834-1-adrian.larumbe@collabora.com> References: <20260415112900.681834-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Instead of passing its constituent elements, pass the whole struct to simplify the function prototype. Signed-off-by: Adri=C3=A1n Larumbe Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- drivers/gpu/drm/panthor/panthor_mmu.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/pantho= r/panthor_mmu.c index 01577be88933..d9e2f8afb8fb 100644 --- a/drivers/gpu/drm/panthor/panthor_mmu.c +++ b/drivers/gpu/drm/panthor/panthor_mmu.c @@ -1275,9 +1275,7 @@ static int panthor_vm_op_ctx_prealloc_pts(struct pant= hor_vm_op_ctx *op_ctx) static int panthor_vm_prepare_map_op_ctx(struct panthor_vm_op_ctx *op_ctx, struct panthor_vm *vm, struct panthor_gem_object *bo, - u64 offset, - u64 size, u64 va, - u32 flags) + const struct drm_panthor_vm_bind_op *op) { struct drm_gpuvm_bo *preallocated_vm_bo; struct sg_table *sgt =3D NULL; @@ -1286,12 +1284,12 @@ static int panthor_vm_prepare_map_op_ctx(struct pan= thor_vm_op_ctx *op_ctx, if (!bo) return -EINVAL; =20 - if ((flags & ~PANTHOR_VM_BIND_OP_MAP_FLAGS) || - (flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) !=3D DRM_PANTHOR_VM_BIND_O= P_TYPE_MAP) + if ((op->flags & ~PANTHOR_VM_BIND_OP_MAP_FLAGS) || + (op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) !=3D DRM_PANTHOR_VM_BI= ND_OP_TYPE_MAP) return -EINVAL; =20 /* Make sure the VA and size are in-bounds. */ - if (size > bo->base.size || offset > bo->base.size - size) + if (op->size > bo->base.size || op->bo_offset > bo->base.size - op->size) return -EINVAL; =20 /* If the BO has an exclusive VM attached, it can't be mapped to other VM= s. */ @@ -1299,7 +1297,7 @@ static int panthor_vm_prepare_map_op_ctx(struct panth= or_vm_op_ctx *op_ctx, bo->exclusive_vm_root_gem !=3D panthor_vm_root_gem(vm)) return -EINVAL; =20 - panthor_vm_init_op_ctx(op_ctx, size, va, flags); + panthor_vm_init_op_ctx(op_ctx, op->size, op->va, op->flags); =20 ret =3D panthor_vm_op_ctx_prealloc_vmas(op_ctx); if (ret) @@ -1328,7 +1326,7 @@ static int panthor_vm_prepare_map_op_ctx(struct panth= or_vm_op_ctx *op_ctx, } =20 op_ctx->map.vm_bo =3D drm_gpuvm_bo_obtain_prealloc(preallocated_vm_bo); - op_ctx->map.bo_offset =3D offset; + op_ctx->map.bo_offset =3D op->bo_offset; =20 ret =3D panthor_vm_op_ctx_prealloc_pts(op_ctx); if (ret) @@ -2849,10 +2847,7 @@ panthor_vm_bind_prepare_op_ctx(struct drm_file *file, gem =3D drm_gem_object_lookup(file, op->bo_handle); ret =3D panthor_vm_prepare_map_op_ctx(op_ctx, vm, gem ? to_panthor_bo(gem) : NULL, - op->bo_offset, - op->size, - op->va, - op->flags); + op); drm_gem_object_put(gem); return ret; =20 @@ -3048,10 +3043,16 @@ int panthor_vm_bind_exec_sync_op(struct drm_file *f= ile, int panthor_vm_map_bo_range(struct panthor_vm *vm, struct panthor_gem_obje= ct *bo, u64 offset, u64 size, u64 va, u32 flags) { + struct drm_panthor_vm_bind_op op =3D { + .bo_offset =3D offset, + .size =3D size, + .va =3D va, + .flags =3D flags, + }; struct panthor_vm_op_ctx op_ctx; int ret; =20 - ret =3D panthor_vm_prepare_map_op_ctx(&op_ctx, vm, bo, offset, size, va, = flags); + ret =3D panthor_vm_prepare_map_op_ctx(&op_ctx, vm, bo, &op); if (ret) return ret; =20 --=20 2.53.0 From nobody Tue Jun 16 02:35:14 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9DC336895 for ; Wed, 15 Apr 2026 11:29:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776252580; cv=pass; b=Fxdi+MyfcDCuETV0j9ToJ+tPCjg13GZbkdSZThXncFLFENV/web00/xY8vfIZ+cXE/Li2P62Ex4yPkATY5GL4toBfR+Fm5SdCAN6HpxxkjhkUbpFGBg/ip5dsohgnIq/jex3HopNb4TNr7lpscMAg/V2niY3DH5xy/yIvwhfMmA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776252580; c=relaxed/simple; bh=CgVDSmozr9Ukd5Jv5sILlknTvbAJvRzNaIa6gHoPSWU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DCrCb5hmt/GbfBE7skvPhdg6qAyRMguSq8CCVDTfGriGhRL370xyWG/uDPQik87lfInH1n+xJzbU1HlwO07OH7h/Kfb+5MyI5T1sudPcnKwj9gXH/rmBeNti2l204R+i2H3z0bdhg67oN1mMK6UQsug2NQxKikWewatcti39L/E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=VDcvtkLO; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="VDcvtkLO" ARC-Seal: i=1; a=rsa-sha256; t=1776252562; cv=none; d=zohomail.com; s=zohoarc; b=IWb1YkZLFC/CuxuOLzWXmWiTYwaS7CW+k1N2BcuEl8hGWa2qopGaWPOz8JjuB2woj6Wnm0GgENCUjt8QvVU7rny8fUiW1E658JgzIsZOjrc5mPF8Yy673JrAAAPRS2GUZDo1ABtZiYAuLv5CnZ3gpblO0d6vvSKZwdmwgn7lenM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776252562; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=7ID9yZtY1d0yX24+AAuEMsM5Ot4KCG6NkdpFTvC+8qY=; b=SPspO73OyI+Ev97+sv0x0jBNf6oMKo7EvFMzhAfmQIHhy8fNpmBPv0iAK7FtPDdFRdIAAgx21hrYTZgDQ2o3zAV1FzUR3HgV4r3YSUS5DCRT7eM3ud/zjhgXyUCuaSTzjg29uH2Q+EfM+oQi5GKO2kuFjwvsfCf6zFCveLbUkzc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776252562; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=7ID9yZtY1d0yX24+AAuEMsM5Ot4KCG6NkdpFTvC+8qY=; b=VDcvtkLOAX2PaWRq9SDRW1KyEMjFA23P7Mg5N/804JRdK0DZpxZrPWUxGINopAT2 A16jq7mDItbKZuHokHBOMGK5h1hKwM+F8CRsTkQKPj9F5wO32nlybo4ziWmgIobmIsN awhwZu+/ZeHvqLCq09ABjnRrZjOgredw1eOYYEsw= Received: by mx.zohomail.com with SMTPS id 1776252561681375.2202727333769; Wed, 15 Apr 2026 04:29:21 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Daniel Almeida , Alice Ryhl , Liviu Dudau , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Subject: [PATCH v7 3/6] drm/panthor: Delete spurious whitespace from uAPI header Date: Wed, 15 Apr 2026 12:28:47 +0100 Message-ID: <20260415112900.681834-4-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415112900.681834-1-adrian.larumbe@collabora.com> References: <20260415112900.681834-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable There's no extra blank line after the last member of any other uAPI structures, so delete it. Signed-off-by: Adri=C3=A1n Larumbe Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- include/uapi/drm/panthor_drm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h index dc2704fc2829..42c901ebdb7a 100644 --- a/include/uapi/drm/panthor_drm.h +++ b/include/uapi/drm/panthor_drm.h @@ -677,7 +677,6 @@ struct drm_panthor_vm_bind_op { * This array shall not be empty for sync-only operations. */ struct drm_panthor_obj_array syncs; - }; =20 /** --=20 2.53.0 From nobody Tue Jun 16 02:35:14 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B571A34C989 for ; Wed, 15 Apr 2026 11:29:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776252581; cv=pass; b=Mw7xRmNL04qpPiSsYBCszjgM29D68RuHE3+9pLfjBITq3/brq9S6nz6xDrip2soJmz6KM+HoZ5fKkUVO6FnwnDxtXLVtRgPXhGvNjTMsQq/Gn0S88fdu5lmpO889pUu98bW2r8yYIqor5NjGm6ub2SqkFZG1/mcef0S6En2+qRI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776252581; c=relaxed/simple; bh=DN7dHy0UE4OEvsX+QtEU0swxqpEVxrx5wI5Pglk0wDk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cD/HlznKZJO5FIToNfMUK/Ko/hRcwZmzkBJtAGXj1f+xEzaTFKfcPWepaYgvpRwvooU/Ryw+dh/OdxRhRayQXFtNaJZcNg3kJtcS4WPobSRWB/8yvLpehDiuiRFBYR87ozctvPJJl1DIRBQRFxVzcN2GrtwKXRr4pS2hr3HT+n8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=M5xO6rAp; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="M5xO6rAp" ARC-Seal: i=1; a=rsa-sha256; t=1776252567; cv=none; d=zohomail.com; s=zohoarc; b=i8IsgFTZDanFFhW/7m9/5gfnBeKkd7YoStks7UuKf8SBbGFGZt9dxsHtgfT6p4m9Uj+IA6mdyEyozYSuHE85tEcw2Wv39g+WagepaHGwhHhORvVbROfTQZNJS9Lv3ylOuYid1RD6TK0LwgWe5QjV2TESxeWJaaNEEhHYI9mqp44= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776252567; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Wk3BeTWMJ+SCnbI5In7nJ6Bhq1v75t4HmjtHopthE0M=; b=GHuBWkuOYgEKV8oZ5kLnLEjKJ97S3XqGpr+m+2ba9+a1ekDCG6C5/F9xEBIBqsnXc+xzPw0wLVgGptFjlpNFzVwRM/D3zvC5F4WG7vExJ8B5QxpjaRjl73NQRKcb9AnMtIz7IL+ePgNK6M7iYcHu/BZz7TxiVzhss83uzU+KmdM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776252567; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Wk3BeTWMJ+SCnbI5In7nJ6Bhq1v75t4HmjtHopthE0M=; b=M5xO6rApaf0X8e7YhXfCW+lv1b/l37vp+FUGUXHr6PSAkfMPmdEkizhK5KJQ/mT4 qQY7UXAFxeuecD9H/dR2xO0dxiARybneuUFPFZCQJ6LRalepjvVtVhoWhFik+qwWPJk IzYXDwhiFg/MByNjtr1M4Fjst1nDMJshqlWUGefU= Received: by mx.zohomail.com with SMTPS id 1776252564739815.794466188156; Wed, 15 Apr 2026 04:29:24 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH v7 4/6] drm/panthor: Remove unused operation context field Date: Wed, 15 Apr 2026 12:28:48 +0100 Message-ID: <20260415112900.681834-5-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415112900.681834-1-adrian.larumbe@collabora.com> References: <20260415112900.681834-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable A Panthor BO's sgtable is now retrieved from its dmap field. Signed-off-by: Adri=C3=A1n Larumbe Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- drivers/gpu/drm/panthor/panthor_mmu.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/pantho= r/panthor_mmu.c index d9e2f8afb8fb..cea78e5f0591 100644 --- a/drivers/gpu/drm/panthor/panthor_mmu.c +++ b/drivers/gpu/drm/panthor/panthor_mmu.c @@ -195,14 +195,6 @@ struct panthor_vm_op_ctx { /** @map.bo_offset: Offset in the buffer object. */ u64 bo_offset; =20 - /** - * @map.sgt: sg-table pointing to pages backing the GEM object. - * - * This is gathered at job creation time, such that we don't have - * to allocate in ::run_job(). - */ - struct sg_table *sgt; - /** @map.bo: the BO being mapped. */ struct panthor_gem_object *bo; } map; --=20 2.53.0 From nobody Tue Jun 16 02:35:14 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08E5A37D10F for ; Wed, 15 Apr 2026 11:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776252589; cv=pass; b=WdwTA63VnGuvFMqzlrjNmspqG3dLkfNWGBb71pEu9V5efK/h621wXgby55O1xj0jXuemqIfGlTRrDxTgS8sllHwbsMYFnhxAL/fDTnwnHJZTfq6g0w7eEAdPdhKFzsJlWAg9W2CIqW4apCowhsV+BSc2t02N2kbC4CKKe93aMfA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776252589; c=relaxed/simple; bh=3llaKKGh4ynD3BhBxNojEfbwZv3J/G2Enkbh7qUG2HY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=L+nRPuLs7DYzIq5GPOhyY3DqD1dH+6zr/i2XFLWIDcENuIe2C2C1WnlhfZrSqSW5dIerhoJrDwS4NmkKxSUQWBUy5Id83Kg/323FS5Mq5vzqR7U+swpfe7F7gRK0U8WHLEMDr6z/jLICxfzWtwHVnWYSMluWdjZqa1v+AT4MmsI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=Gtk9NPKe; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="Gtk9NPKe" ARC-Seal: i=1; a=rsa-sha256; t=1776252571; cv=none; d=zohomail.com; s=zohoarc; b=HTuobjd2YRoNQ9qxRno9JMJQj/qqG6x1nRV49Cu2JoFNy+0sT/BQi6V/cd+wGNRk8wDFyfO9yfThLRO3lRVquyJwQjkCCd/1Vr7sJk28tgB/GX7X27UcF89OESjam+4LB4xg/om5JODsvX0sZNFWGRJGhc3lr0xmzf+39G8sx50= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776252571; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=xAGev2Qifxqa0aKReAbyNbQYeHnCz+Zkmy7+0LBa2mQ=; b=lvShHwuFl+iCdLpcwUn4BgEZEIzV+0iaz6vfzbTzJbJSZhUDIVWL8HuufdWrXXdjBJVihPVpZtVfEnJqmxb1lfEPiDtREXZSyekrwPSHqTLkIwbP8GyQJuFNjZJOTkFpfvA3x3VfaiPRKVD1xUKgREiIwior5Y6JLqedsCz6HEk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776252570; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=xAGev2Qifxqa0aKReAbyNbQYeHnCz+Zkmy7+0LBa2mQ=; b=Gtk9NPKeMRftaJWVS4GnlgT8Cwx7uyyt8z7Y8dLGtwQnHwiFXroBBxOCa4E8e6bg rHioXkf/mz9jdVzpYFq4OJEKc6vyWwyT96evjzbOhTIfghynWPCLZMc1Q3dhVR8Fj6S rVpIEPb1nj4P3do7JlxeQxTTsUZAqGTYEBy0pcoc= Received: by mx.zohomail.com with SMTPS id 1776252568679618.3062224182121; Wed, 15 Apr 2026 04:29:28 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Daniel Almeida , Alice Ryhl Subject: [PATCH v7 5/6] drm/panthor: Support sparse mappings Date: Wed, 15 Apr 2026 12:28:49 +0100 Message-ID: <20260415112900.681834-6-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415112900.681834-1-adrian.larumbe@collabora.com> References: <20260415112900.681834-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Allow UM to bind sparsely populated memory regions by cyclically mapping virtual ranges over a kernel-allocated dummy BO. This alternative is preferable to the old method of handling sparseness in the UMD, because it relied on the creation of a buffer object to the same end, despite the fact Vulkan sparse resources don't need to be backed by a driver BO. The choice of backing sparsely-bound regions with a Panhtor BO was made so as to profit from the existing shrinker reclaim code. That way no special treatment must be given to the dummy sparse BOs when reclaiming memory, as would be the case if we had chosen a raw kernel page implementation. A new dummy BO is allocated per open file context, because even though the Vulkan spec mandates that writes into sparsely bound regions must be discarded, our implementation is still a workaround over the fact Mali CSF GPUs cannot support this behaviour on the hardware level, so writes still make it into the backing BO. If we had a global one, then it could be a venue for information leaks between file contexts, which should never happen in DRM. Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panthor/panthor_gem.c | 35 +++++ drivers/gpu/drm/panthor/panthor_gem.h | 2 + drivers/gpu/drm/panthor/panthor_mmu.c | 192 ++++++++++++++++++++++---- include/uapi/drm/panthor_drm.h | 12 ++ 4 files changed, 215 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/pantho= r/panthor_gem.c index 13295d7a593d..e27251ef113b 100644 --- a/drivers/gpu/drm/panthor/panthor_gem.c +++ b/drivers/gpu/drm/panthor/panthor_gem.c @@ -1345,6 +1345,41 @@ panthor_kernel_bo_create(struct panthor_device *ptde= v, struct panthor_vm *vm, return ERR_PTR(ret); } =20 +/** + * panthor_dummy_bo_create() - Create a Panthor BO meant to back sparse bi= ndings. + * @ptdev: Device. + * + * Return: A valid pointer in case of success, an ERR_PTR() otherwise. + */ +struct panthor_gem_object * +panthor_dummy_bo_create(struct panthor_device *ptdev) +{ + u32 dummy_flags =3D DRM_PANTHOR_BO_NO_MMAP; + struct panthor_gem_object *bo; + struct page **pages; + + bo =3D panthor_gem_create(&ptdev->base, SZ_2M, dummy_flags, NULL, 0); + if (IS_ERR_OR_NULL(bo)) + return bo; + + pages =3D drm_gem_get_pages(&bo->base); + if (PTR_ERR(pages) =3D=3D -ENOMEM) { + drm_gem_object_put(&bo->base); + bo =3D panthor_gem_create(&ptdev->base, SZ_4K, dummy_flags, NULL, 0); + if (IS_ERR_OR_NULL(bo)) + return bo; + pages =3D drm_gem_get_pages(&bo->base); + } + + if (IS_ERR_OR_NULL(pages)) { + drm_gem_object_put(&bo->base); + return ERR_CAST(pages); + } + + bo->backing.pages =3D pages; + return bo; +} + static bool can_swap(void) { return get_nr_swap_pages() > 0; diff --git a/drivers/gpu/drm/panthor/panthor_gem.h b/drivers/gpu/drm/pantho= r/panthor_gem.h index ae0491d0b121..dcf9cdd51d93 100644 --- a/drivers/gpu/drm/panthor/panthor_gem.h +++ b/drivers/gpu/drm/panthor/panthor_gem.h @@ -264,6 +264,8 @@ void panthor_gem_kernel_bo_set_label(struct panthor_ker= nel_bo *bo, const char *l int panthor_gem_sync(struct drm_gem_object *obj, u32 type, u64 offset, u64 size); =20 +struct panthor_gem_object *panthor_dummy_bo_create(struct panthor_device *= ptdev); + struct drm_gem_object * panthor_gem_prime_import(struct drm_device *dev, struct dma_buf *dma_buf); diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/pantho= r/panthor_mmu.c index cea78e5f0591..6585fd6b5d04 100644 --- a/drivers/gpu/drm/panthor/panthor_mmu.c +++ b/drivers/gpu/drm/panthor/panthor_mmu.c @@ -112,6 +112,23 @@ struct panthor_mmu { struct panthor_vm_pool { /** @xa: Array used for VM handle tracking. */ struct xarray xa; + + /** @dummy: Dummy drm object related fields + * + * Sparse bindings map virtual address ranges onto a dummy + * BO in a modulo fashion. Even though sparse writes are meant + * to be discarded and reads undefined, writes are still reflected + * in the dummy buffer. That means we must keep a dummy object per + * file context, to avoid data leaks between them. + * + */ + struct { + /** @dummy.obj: Dummy object used for sparse mappings. */ + struct panthor_gem_object *obj; + + /** @dummy.lock: Lock protecting against races on dummy object. */ + struct mutex lock; + } dummy; }; =20 /** @@ -391,6 +408,15 @@ struct panthor_vm { */ struct list_head lru_node; } reclaim; + + /** @dummy: Dummy object used for sparse mappings. + * + * VM's must keep a reference to the file context-wide dummy BO because + * they can outlive the file context, which includes the VM pool holding + * the original dummy BO reference. + * + */ + struct panthor_gem_object *dummy; }; =20 /** @@ -1020,6 +1046,46 @@ panthor_vm_map_pages(struct panthor_vm *vm, u64 iova= , int prot, return 0; } =20 +static int +panthor_vm_map_sparse(struct panthor_vm *vm, u64 iova, int prot, + struct sg_table *sgt, u64 size) +{ + u64 first_iova =3D iova; + u64 first_size =3D size; + int ret; + + if (iova & (SZ_2M - 1)) { + u64 unaligned_size =3D min(ALIGN(iova, SZ_2M) - iova, size); + + ret =3D panthor_vm_map_pages(vm, iova, prot, sgt, + 0, unaligned_size); + if (ret) + return ret; + + size -=3D unaligned_size; + iova +=3D unaligned_size; + } + + /* TODO: we should probably optimize this at the io_pgtable level. */ + while (size > 0) { + u64 next_size =3D min(size, sg_dma_len(sgt->sgl)); + + ret =3D panthor_vm_map_pages(vm, iova, prot, + sgt, 0, next_size); + if (ret) + goto err_unmap; + + size -=3D next_size; + iova +=3D next_size; + } + + return 0; + +err_unmap: + panthor_vm_unmap_pages(vm, first_iova, first_size - size); + return ret; +} + static int flags_to_prot(u32 flags) { int prot =3D 0; @@ -1258,38 +1324,71 @@ static int panthor_vm_op_ctx_prealloc_pts(struct pa= nthor_vm_op_ctx *op_ctx) return 0; } =20 +static struct panthor_gem_object * +panthor_vm_get_dummy_obj(struct panthor_vm_pool *pool, + struct panthor_vm *vm) +{ + scoped_guard(mutex, &pool->dummy.lock) { + if (!vm->dummy) { + if (!pool->dummy.obj) { + struct panthor_gem_object *obj =3D + panthor_dummy_bo_create(vm->ptdev); + if (IS_ERR(obj)) + return obj; + + pool->dummy.obj =3D obj; + } + + drm_gem_object_get(&pool->dummy.obj->base); + vm->dummy =3D pool->dummy.obj; + } + } + + return vm->dummy; +} + #define PANTHOR_VM_BIND_OP_MAP_FLAGS \ (DRM_PANTHOR_VM_BIND_OP_MAP_READONLY | \ DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC | \ DRM_PANTHOR_VM_BIND_OP_MAP_UNCACHED | \ + DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE | \ DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) =20 static int panthor_vm_prepare_map_op_ctx(struct panthor_vm_op_ctx *op_ctx, + struct panthor_vm_pool *pool, struct panthor_vm *vm, struct panthor_gem_object *bo, const struct drm_panthor_vm_bind_op *op) { + bool is_sparse =3D op->flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE; struct drm_gpuvm_bo *preallocated_vm_bo; struct sg_table *sgt =3D NULL; int ret; =20 - if (!bo) - return -EINVAL; - if ((op->flags & ~PANTHOR_VM_BIND_OP_MAP_FLAGS) || (op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) !=3D DRM_PANTHOR_VM_BI= ND_OP_TYPE_MAP) return -EINVAL; =20 /* Make sure the VA and size are in-bounds. */ - if (op->size > bo->base.size || op->bo_offset > bo->base.size - op->size) + if (bo && (is_sparse || op->size > bo->base.size || + op->bo_offset > bo->base.size - op->size)) return -EINVAL; + else if (is_sparse && (!pool || op->bo_handle || op->bo_offset)) + return -EINVAL; + + if (is_sparse) { + bo =3D panthor_vm_get_dummy_obj(pool, vm); + if (IS_ERR_OR_NULL(bo)) + return PTR_ERR(bo); + } =20 /* If the BO has an exclusive VM attached, it can't be mapped to other VM= s. */ if (bo->exclusive_vm_root_gem && bo->exclusive_vm_root_gem !=3D panthor_vm_root_gem(vm)) return -EINVAL; =20 - panthor_vm_init_op_ctx(op_ctx, op->size, op->va, op->flags); + panthor_vm_init_op_ctx(op_ctx, op->size, op->va, op->flags + | ((is_sparse) ? DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC : 0)); =20 ret =3D panthor_vm_op_ctx_prealloc_vmas(op_ctx); if (ret) @@ -1634,6 +1733,13 @@ void panthor_vm_pool_destroy(struct panthor_file *pf= ile) xa_for_each(&pfile->vms->xa, i, vm) panthor_vm_destroy(vm); =20 + scoped_guard(mutex, &pfile->vms->dummy.lock) { + struct panthor_gem_object *bo =3D pfile->vms->dummy.obj; + + if (bo) + drm_gem_object_put(&bo->base); + } + xa_destroy(&pfile->vms->xa); kfree(pfile->vms); } @@ -1651,6 +1757,8 @@ int panthor_vm_pool_create(struct panthor_file *pfile) return -ENOMEM; =20 xa_init_flags(&pfile->vms->xa, XA_FLAGS_ALLOC1); + + mutex_init(&pfile->vms->dummy.lock); return 0; } =20 @@ -1987,6 +2095,9 @@ static void panthor_vm_free(struct drm_gpuvm *gpuvm) =20 free_io_pgtable_ops(vm->pgtbl_ops); =20 + if (vm->dummy) + drm_gem_object_put(&vm->dummy->base); + drm_mm_takedown(&vm->mm); kfree(vm); } @@ -2146,7 +2257,26 @@ static void panthor_vma_init(struct panthor_vma *vma= , u32 flags) #define PANTHOR_VM_MAP_FLAGS \ (DRM_PANTHOR_VM_BIND_OP_MAP_READONLY | \ DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC | \ - DRM_PANTHOR_VM_BIND_OP_MAP_UNCACHED) + DRM_PANTHOR_VM_BIND_OP_MAP_UNCACHED | \ + DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE) + +static int +panthor_vm_exec_map_op(struct panthor_vm *vm, u32 flags, + const struct drm_gpuva_op_map *op) +{ + struct panthor_gem_object *bo =3D to_panthor_bo(op->gem.obj); + int prot =3D flags_to_prot(flags); + + if (!op->va.range) + return 0; + + if (flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE) + return panthor_vm_map_sparse(vm, op->va.addr, prot, + bo->dmap.sgt, op->va.range); + + return panthor_vm_map_pages(vm, op->va.addr, prot, bo->dmap.sgt, + op->gem.offset, op->va.range); +} =20 static int panthor_gpuva_sm_step_map(struct drm_gpuva_op *op, void *priv) { @@ -2160,9 +2290,7 @@ static int panthor_gpuva_sm_step_map(struct drm_gpuva= _op *op, void *priv) =20 panthor_vma_init(vma, op_ctx->flags & PANTHOR_VM_MAP_FLAGS); =20 - ret =3D panthor_vm_map_pages(vm, op->map.va.addr, flags_to_prot(vma->flag= s), - op_ctx->map.bo->dmap.sgt, op->map.gem.offset, - op->map.va.range); + ret =3D panthor_vm_exec_map_op(vm, vma->flags, &op->map); if (ret) { panthor_vm_op_ctx_return_vma(op_ctx, vma); return ret; @@ -2178,13 +2306,15 @@ static int panthor_gpuva_sm_step_map(struct drm_gpu= va_op *op, void *priv) } =20 static bool -iova_mapped_as_huge_page(struct drm_gpuva_op_map *op, u64 addr) +iova_mapped_as_huge_page(struct drm_gpuva_op_map *op, u64 addr, bool is_sp= arse) { struct panthor_gem_object *bo =3D to_panthor_bo(op->gem.obj); const struct page *pg; pgoff_t bo_offset; =20 bo_offset =3D addr - op->va.addr + op->gem.offset; + if (is_sparse) + bo_offset %=3D bo->base.size; pg =3D bo->backing.pages[bo_offset >> PAGE_SHIFT]; =20 return folio_size(page_folio(pg)) >=3D SZ_2M; @@ -2194,6 +2324,8 @@ static void unmap_hugepage_align(const struct drm_gpuva_op_remap *op, u64 *unmap_start, u64 *unmap_range) { + struct panthor_vma *unmap_vma =3D container_of(op->unmap->va, struct pant= hor_vma, base); + bool is_sparse =3D unmap_vma->flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE; u64 aligned_unmap_start, aligned_unmap_end, unmap_end; =20 unmap_end =3D *unmap_start + *unmap_range; @@ -2205,7 +2337,7 @@ unmap_hugepage_align(const struct drm_gpuva_op_remap = *op, */ if (op->prev && aligned_unmap_start < *unmap_start && op->prev->va.addr <=3D aligned_unmap_start && - iova_mapped_as_huge_page(op->prev, *unmap_start)) { + (iova_mapped_as_huge_page(op->prev, *unmap_start, is_sparse))) { *unmap_range +=3D *unmap_start - aligned_unmap_start; *unmap_start =3D aligned_unmap_start; } @@ -2215,7 +2347,7 @@ unmap_hugepage_align(const struct drm_gpuva_op_remap = *op, */ if (op->next && aligned_unmap_end > unmap_end && op->next->va.addr + op->next->va.range >=3D aligned_unmap_end && - iova_mapped_as_huge_page(op->next, unmap_end - 1)) { + (iova_mapped_as_huge_page(op->next, *unmap_start, is_sparse))) { *unmap_range +=3D aligned_unmap_end - unmap_end; } } @@ -2251,14 +2383,17 @@ static int panthor_gpuva_sm_step_remap(struct drm_g= puva_op *op, } =20 if (op->remap.prev) { - struct panthor_gem_object *bo =3D to_panthor_bo(op->remap.prev->gem.obj); - u64 offset =3D op->remap.prev->gem.offset + unmap_start - op->remap.prev= ->va.addr; - u64 size =3D op->remap.prev->va.addr + op->remap.prev->va.range - unmap_= start; + const struct drm_gpuva_op_map map_op =3D { + .va.addr =3D unmap_start, + .va.range =3D + op->remap.prev->va.addr + op->remap.prev->va.range - unmap_start, + .gem.obj =3D op->remap.prev->gem.obj, + .gem.offset =3D + op->remap.prev->gem.offset + unmap_start - op->remap.prev->va.addr, + }; =20 if (!unmap_vma->evicted) { - ret =3D panthor_vm_map_pages(vm, unmap_start, - flags_to_prot(unmap_vma->flags), - bo->dmap.sgt, offset, size); + ret =3D panthor_vm_exec_map_op(vm, unmap_vma->flags, &map_op); if (ret) return ret; } @@ -2269,14 +2404,15 @@ static int panthor_gpuva_sm_step_remap(struct drm_g= puva_op *op, } =20 if (op->remap.next) { - struct panthor_gem_object *bo =3D to_panthor_bo(op->remap.next->gem.obj); - u64 addr =3D op->remap.next->va.addr; - u64 size =3D unmap_start + unmap_range - op->remap.next->va.addr; + const struct drm_gpuva_op_map map_op =3D { + .va.addr =3D op->remap.next->va.addr, + .va.range =3D unmap_start + unmap_range - op->remap.next->va.addr, + .gem.obj =3D op->remap.next->gem.obj, + .gem.offset =3D op->remap.next->gem.offset, + }; =20 if (!unmap_vma->evicted) { - ret =3D panthor_vm_map_pages(vm, addr, flags_to_prot(unmap_vma->flags), - bo->dmap.sgt, op->remap.next->gem.offset, - size); + ret =3D panthor_vm_exec_map_op(vm, unmap_vma->flags, &map_op); if (ret) return ret; } @@ -2826,6 +2962,7 @@ panthor_vm_bind_prepare_op_ctx(struct drm_file *file, const struct drm_panthor_vm_bind_op *op, struct panthor_vm_op_ctx *op_ctx) { + struct panthor_file *pfile =3D file->driver_priv; ssize_t vm_pgsz =3D panthor_vm_page_size(vm); struct drm_gem_object *gem; int ret; @@ -2837,7 +2974,7 @@ panthor_vm_bind_prepare_op_ctx(struct drm_file *file, switch (op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) { case DRM_PANTHOR_VM_BIND_OP_TYPE_MAP: gem =3D drm_gem_object_lookup(file, op->bo_handle); - ret =3D panthor_vm_prepare_map_op_ctx(op_ctx, vm, + ret =3D panthor_vm_prepare_map_op_ctx(op_ctx, pfile->vms, vm, gem ? to_panthor_bo(gem) : NULL, op); drm_gem_object_put(gem); @@ -3044,7 +3181,10 @@ int panthor_vm_map_bo_range(struct panthor_vm *vm, s= truct panthor_gem_object *bo struct panthor_vm_op_ctx op_ctx; int ret; =20 - ret =3D panthor_vm_prepare_map_op_ctx(&op_ctx, vm, bo, &op); + if (drm_WARN_ON(&vm->ptdev->base, flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPAR= SE)) + return -EINVAL; + + ret =3D panthor_vm_prepare_map_op_ctx(&op_ctx, NULL, vm, bo, &op); if (ret) return ret; =20 diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h index 42c901ebdb7a..1a9bcfc8f4cd 100644 --- a/include/uapi/drm/panthor_drm.h +++ b/include/uapi/drm/panthor_drm.h @@ -614,6 +614,18 @@ enum drm_panthor_vm_bind_op_flags { */ DRM_PANTHOR_VM_BIND_OP_MAP_UNCACHED =3D 1 << 2, =20 + /** + * @DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE: Repeat a BO range + * + * Only valid with DRM_PANTHOR_VM_BIND_OP_TYPE_MAP. + * + * When this flag is set, the whole vm_bind range is mapped over a dummy = object in a cyclic + * fashion, and all GPU reads from addresses in the range return undefine= d values. This flag + * being set means drm_panthor_vm_bind_op:offset and drm_panthor_vm_bind_= op::handle must + * both be set to 0. + */ + DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE =3D 1 << 3, + /** * @DRM_PANTHOR_VM_BIND_OP_TYPE_MASK: Mask used to determine the type of = operation. */ --=20 2.53.0 From nobody Tue Jun 16 02:35:14 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08EE537D11F for ; Wed, 15 Apr 2026 11:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776252588; cv=pass; b=vDC+B5j6RiA0tS5kLCEqltFRgch/38sQxoiB2MUwL5wGdqmLXiVo/46QsRxYGAlgLKbkNcwiktQhSlwomcCmnzcjujWWyL1bYYESPVphMSixcjEDrP6xzGASW69LURRsHu83RQEkZC13cziMRyC4MogJhpcKDX+0az8o48IeKxo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776252588; c=relaxed/simple; bh=25yjW99K3WpTDGsWxuiPnry0WqVj3vcfFgbeUZtMTOk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PGqVD/MmR03EMnBZ2EC3Sm0lWMn4zUSmJWt8JemIEwkcev0hPsZBQe83ZlLdzUG/xkm1ZqoyBkHEefmHmg2PxKgwlVmZYRQMjXWwaPe7tV9KFBnfSLGEseu3jbSO1gp97/+WEzMysk7wv8zLnroMNVvivptBgy8EpXzo+uh0/nM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=YkQdqWyy; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="YkQdqWyy" ARC-Seal: i=1; a=rsa-sha256; t=1776252572; cv=none; d=zohomail.com; s=zohoarc; b=kN+rdMA+nsF6yDQNDjX9M9/h2F4KncCn534h8uPTvFJyo9eZmbGJLysNP5HIUwincczBtTPbkQgdCvhEyB2QIdJR2+oJj7mWGJ4AGBiQSwu6bRE5W0CFDgax5Se+V1brskJrB9P0y7kIL3Dj3MiQAKkc2HxYsGbYF+SE+cFkLEE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776252572; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=wBbhOd9N1ulj8HlqwKZuLm9O6XwurhYVgjsddamL+4o=; b=RR4pEhHxBY3x4eWkz4SDwBDGZ29ornRLUiQ7E0RgW8KFwctUovRoqobJRrELeCeTHVg9JiZKkoTP8tMP6hTLwrMnbl+i9p0X5riVKNsWinbcxciI4yzHznsyxD40z3LQnoXrC1c29jv4cm3ppUYwKxUbf2NHhb4Q1dMiNhPScjk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776252572; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=wBbhOd9N1ulj8HlqwKZuLm9O6XwurhYVgjsddamL+4o=; b=YkQdqWyyA63br34NJ/gjS0feJF3YfyLiakZO5cGXM51a200k6Le5OaSW6aavzP5Y /6HJPfAREE6TZjG0LgPOcjGOLJSJ7BM2xFVRWJrgiFD4P1mbww95+L3vSKjfkBYG8B7 B2FpAZCijdqFBfgTvhbWA7aFLPjHQ3zYkVyykiuY= Received: by mx.zohomail.com with SMTPS id 1776252571658869.4891831938455; Wed, 15 Apr 2026 04:29:31 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH v7 6/6] drm/panthor: Bump the driver version to 1.9 Date: Wed, 15 Apr 2026 12:28:50 +0100 Message-ID: <20260415112900.681834-7-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415112900.681834-1-adrian.larumbe@collabora.com> References: <20260415112900.681834-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Bump the driver version to reflect the new MMU info query ioctl parameter and the VM_BIND map sparse flag. Signed-off-by: Adri=C3=A1n Larumbe Reviewed-by: Boris Brezillon --- drivers/gpu/drm/panthor/panthor_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/pantho= r/panthor_drv.c index a8090bc4e33c..c8fb63ede62c 100644 --- a/drivers/gpu/drm/panthor/panthor_drv.c +++ b/drivers/gpu/drm/panthor/panthor_drv.c @@ -1787,6 +1787,8 @@ static void panthor_debugfs_init(struct drm_minor *mi= nor) * - adds DRM_IOCTL_PANTHOR_BO_QUERY_INFO ioctl * - adds drm_panthor_gpu_info::selected_coherency * - 1.8 - extends DEV_QUERY_TIMESTAMP_INFO with flags + * - 1.9 - adds DRM_PANTHOR_DEV_QUERY_MMU_INFO query + * - adds DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE flag */ static const struct drm_driver panthor_drm_driver =3D { .driver_features =3D DRIVER_RENDER | DRIVER_GEM | DRIVER_SYNCOBJ | --=20 2.53.0