From nobody Sat Jun 20 13:06:52 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45DE627AC48 for ; Wed, 15 Apr 2026 08:51:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776243083; cv=none; b=SnA5RCC23SNvcUBEBE4UaP43KehiDy09PfLOIKj0XIWWZ2dQNBDKi0Zfm28E65nYCxDQ3vmoiGNZNqSqDqLcVFi8bhGnbp9OZY3Amqs7JJzxDQaVzBBhlk3CVLfdMjYBNW29LKP0qWOdhxXdqho/cblFI6jMHGO9Ka3eTklNUyY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776243083; c=relaxed/simple; bh=NzkOE0XXojEPsLDp5AjW4nUeVXuWbIOFyVsKkxFSCVw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tu7y9Ng+4Xeym+6Lu84fwprs3ayI9EamVFFrk6gqX/AiE/L/zWHzS3o6wrvEeVHb8QQRXFJ4HaeDHqE98+7OlUKSd1JkrN2ajsECiBkI212yw4ik8nPNnx4apCsjqItd6S8fQk3fwaHnD6J0xb5f/3MLEzanGuFPsJTPxYUeIlU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rCgpz6WG; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rCgpz6WG" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-35d9c7bf9a1so5781954a91.3 for ; Wed, 15 Apr 2026 01:51:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776243081; x=1776847881; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NuPGq2uQWBcQ6iaTKDT1PjU7pmFyo/WHC6ytQGe/UTQ=; b=rCgpz6WGTSZ3or3WaGoLlQWfVaDJBLJtSk49gj/CyfDnkICOTbj+UjOnOQRLDXRGsQ m04NO4VatYv2qhsSrQn6dIz7FwOl9UHGHKOhCsj42kTQtpYGoi7i+7NGk+RU71XV2qWw k8lOcnbrQZ9yLYkQB720vOmrRkjW54ODr3QVPXSAX7+lgXZrzIDc0rysvrdY6byezoQH 5JqnADjK8R5G/8xopRhxtJXXZY8XMqSvZnDwhXTS7G91ycpwBh7OmKFlwzcefIJjBjq/ f4fbULEZICguAXhlglHf/dKD8F7bpdD9lB9fxptaqw1C3jrSkg2WLnWseBqJfrY1zRtM JE/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776243081; x=1776847881; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NuPGq2uQWBcQ6iaTKDT1PjU7pmFyo/WHC6ytQGe/UTQ=; b=A+a+5S+crRjzKIhlkyiaFcpGakLgNkuqcafumxETWhQ+DlfWtKtmujd2Os3L7gXNkC W/hmdo9eJQIUBDfKM2HcM1SJXVylQBz1nGbrziq06S7WymXulnHX0XzHJas9w8UVS8t/ r+F1See8GjZiHXcXlnO52StbLQ6ofzIsE8hjhTASfYHzG26Suo5Uu2JfQk1k7H+USIZL X8lvRF0BiBe+omc699yy2RImv38MeXwPUuCbflplpg6UBscqw1nIA0fXJzWl2Px38Qdh by2r8EbfXOP83x/vNIlsFSGSMCRO2NAbsbfio5g3PS9AjI6g6n/4cedcwNJS/dieSKt5 CcPw== X-Forwarded-Encrypted: i=1; AFNElJ/MX55V/TiQRZ4cShJKr54aacgnctPqu6xCnKIhX8Cpcb+3J9OeTfMZ/tdTxJ/ezv+7zwkinjCAffzWCjE=@vger.kernel.org X-Gm-Message-State: AOJu0YzRsZriXSkIgT3kavhbfwPRyqx0jtLpv+42Z0x54fRY5kNTX4Q8 vZrgg1EVipzKq4Gj0nXwGxuVPGFH/ZF+Mrnk1xgctvNq31cvEyDkUrry X-Gm-Gg: AeBDieutVaQjcG1iGoHQvmOVn7lujw1ynwtW+EVRT6vgwwQQEeMpHYgyYxrmv+v8Hiv /fcvbtIIm/9jnzE/N+81QCz+0o/Fv8q+sSOcoc/kXIcdnwpFZTN5HTnbPnymOvIT1gjeRdga2m1 8bKGTSbzaQ5fTjqKurSPBnTlzCh/7MW9seJAh5mLibYsp+DFOXJvvsPUhXfFr7QXojyuXtwfs74 l1iBEd/T9a//P9nM1BVNaw0dlMQvl9TvOkuS+X6oDi1RqyGYblcAPnwDei23hELreU2OnQbYBdk RI8HVWdkC2COKbZFjJeYWqWU7uzK/YXHpDxCay0zbhZkCwfXaddrIaa+7h3wo40QcRLNWM/R/XK L5Ts11dJhzrQX+C4FQo7au+0QpLyd7zsDlndDTJNZrH7gxTUFq/xTvhS8P8ewW5Z96aRfifIcRG 4ACMj5zv01npeBzSeL9k1Lygqqxq8CU2n8 X-Received: by 2002:a17:90b:288f:b0:35b:9b77:d7c with SMTP id 98e67ed59e1d1-35e4285338cmr21700928a91.14.1776243081584; Wed, 15 Apr 2026 01:51:21 -0700 (PDT) Received: from lgs.. ([112.224.67.108]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35fd3074758sm1274513a91.1.2026.04.15.01.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 01:51:21 -0700 (PDT) From: Guangshuo Li To: Luis Chamberlain , Russ Weight , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Tianfei zhang , driver-core@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] firmware_loader: fix device reference leak in firmware_upload_register() Date: Wed, 15 Apr 2026 16:51:09 +0800 Message-ID: <20260415085109.3267323-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" firmware_upload_register() -> fw_create_instance() -> device_initialize() After fw_create_instance() succeeds, the lifetime of the embedded struct device is expected to be managed through the device core reference counting, since fw_create_instance() has already called device_initialize(). In firmware_upload_register(), if alloc_lookup_fw_priv() fails after fw_create_instance() succeeds, the code reaches free_fw_sysfs and frees fw_sysfs directly instead of releasing the device reference with put_device(). This may leave the reference count of the embedded struct device unbalanced, resulting in a refcount leak. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fix this by using put_device(fw_dev) in the failure path and letting fw_dev_release() handle the final cleanup, instead of freeing the instance directly from the error path. Fixes: 97730bbb242c ("firmware_loader: Add firmware-upload support") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/base/firmware_loader/sysfs_upload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/base/firmware_loader/sysfs_upload.c b/drivers/base/fir= mware_loader/sysfs_upload.c index f59a7856934c..6b701185dcb6 100644 --- a/drivers/base/firmware_loader/sysfs_upload.c +++ b/drivers/base/firmware_loader/sysfs_upload.c @@ -366,7 +366,8 @@ firmware_upload_register(struct module *module, struct = device *parent, return fw_upload; =20 free_fw_sysfs: - kfree(fw_sysfs); + put_device(fw_dev); + goto exit_module_put; =20 free_fw_upload_priv: kfree(fw_upload_priv); --=20 2.43.0