From nobody Mon Jun 15 22:03:19 2026 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7814E361DD2 for ; Wed, 15 Apr 2026 05:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776232696; cv=none; b=HSb9mK6V0WWbE0AH75WV/yWgK2Z/gwFAII1Gh3964LpYzu5dU5CKUbclGSfFhZvoDCZeCtd7+M/B9xRpvQzYGy5HHIxUaXJPt3xKsJwOXJW4RaT2r5houH3WM/O1yrY5Kq44sRIRYoodOt0780xNQrKLg/OG5spCQrsc02cwz1s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776232696; c=relaxed/simple; bh=YJk7HFFywOAvglX29zYP4iiLAIOHUmcE1zceWMyjEtA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=jbZWYJxDbZEZY7XhT/B45O81OpcfPUzk/rrA/o6VLxLdMJBRGJntbg3XbVbKn9kYlZd5JgVyxsd3k1bwcouhqg6F8yPlmxEwwnG86JoeDVh4VvOuQkGosRplhrONwGwBTYcWly21hcRw4uigpHJH+W5ualFuQK3+P1EGr0XGj84= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TlW0yCkL; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TlW0yCkL" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-7947cf097c1so57296437b3.2 for ; Tue, 14 Apr 2026 22:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776232693; x=1776837493; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=J7Qu+iufcZ9jYk8S+wuxRjUaOgj3R8vJUSvzid2gdM4=; b=TlW0yCkLIUBrvRuZTGswlI+GJHBMFFyVA1SRcXn5BMqV9Ujb5FhwfPEBoGmxCR3hL2 CdF3kooUryWPabs6wKdosOsBxrtCE/SHio/Ii8HtuUCZ6f2fE8c0RDM/Yo9zoNIR8nj2 6J4YDpN9TZfWhspbIOohqeDLPw4aHcwBv3uS4WZ96GhkdsqtCTQr4OR/PXvZXPpoFkbB e4NgD0w08T7n76l5FEOK53jFB4lYGJp0rLQiYW+UaFk9A1q24Xc9GWDRZwIyy0fcmaIm XEQ0b718Xvn4SYcubqmyq4A6lk703CF/FEtdUNMmHJuIIERo3wYNFpLCyM0QV6528Gvn CDOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776232693; x=1776837493; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J7Qu+iufcZ9jYk8S+wuxRjUaOgj3R8vJUSvzid2gdM4=; b=FniGmXEBDLDeZefsCcqb8xDCx2+80TKdQZF3rUYRpljdyeoOmWfJU/iiUJUMH1u7nk nQxDppP2gTPGequsiUP2+lXVJbwCwkBaYuNlZtHTHDfYw8g/ALoMzwqjP0ZjnHOY8BHu 7Q3LRteHS/MnrxFUBHeIDnG7hWBC36CMk3CX5ka7/yJrnqvtdZhU70LXpXFiNqiiXtkw sWwRiHIZL2T3jIjvyNabpHL+BRA9Zh+Si5tf6WAVUVWGDPkaSLhMmKSjICTUqcKW1Axf ybxpAKg3oq1puAWkIILLdmcAN2dto8XxORVhEEWaW45n9VIPpx/xvV+j9E4QoU9jJDt9 4jow== X-Forwarded-Encrypted: i=1; AFNElJ8JQTdQykIUHIm/bmv6OQbk986t6Ye6dDSyJt3NrwH9zpSQTKhucJiOR5WwPZUORjbgbRMh9I+iBFJwTeQ=@vger.kernel.org X-Gm-Message-State: AOJu0YylWTI9c4Fg/q0o1OChjhuFmn5Ov0+vHQnZbMn+ixNgkYW5N+e7 LI3y1yWRWV0ur0DOHgmSGLjNk7Vb+Hp8jRL0JnG8juB6X0k0c5bfCzot X-Gm-Gg: AeBDiev/+nnjOEPU8fBI0a8z88+/DYe0GZCjk7bnGq3Vb4L/STvzblidSUEzovsSSNG 4ya4ZKz3elA0sp/LzwvHXZc2n8q5hDKSLk8llcHWI8cArQai8IcAp4yeznWJnVKJw2x4N5ioZS9 C+s4CpIwEl2NUUaRcjKglXZD7Odzi+jKw0EgHEzOEqQ9Th+ne1BJQLPVn+tBVGlsOHKwXuZTI4w X7RIijRkzO1Y2n7165bnkabbbzGx2/SAxXZZ/xmzChxvm5HphUxsLmlBzUepzrc9gpwRHjdBSvV ApPJVmdBRtgNSi/KjVWa6PFxnPwUIYETdqol4rDoC0xM26nhGVo4cEOclZ/JnmfmXwHM1wLIplu J1MzUX4oS+CO6UtlC1KQNIZvJ9FeWk4zidWIaIG1ObApRrvdznJjFd3RIOE6jT46Trg24xXxYrm 1MHkEIZx0iBCl3o+B81QaAzyKpY9gbbWLVcQw3mPQr6Cc02TrBPgSANi9W8ZbmvI6jXcsx7OKBy nwfloFfxRDlnILEqJlSO1q4nJBGFWPASnYUeBo= X-Received: by 2002:a05:690c:85:b0:7a2:f14d:5a1 with SMTP id 00721157ae682-7af7252df6emr209920057b3.49.1776232693315; Tue, 14 Apr 2026 22:58:13 -0700 (PDT) Received: from TDC4045031631.e0cglfehwr0e5gttmepj3hi3hf.ux.internal.cloudapp.net ([20.63.37.123]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7b768d387eesm4440177b3.29.2026.04.14.22.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 22:58:12 -0700 (PDT) From: Ashutosh Desai To: netdev@vger.kernel.org Cc: linux-hams@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Ashutosh Desai Subject: [PATCH v3 net] rose: fix OOB reads on short CLEAR REQUEST frames Date: Wed, 15 Apr 2026 05:57:56 +0000 Message-Id: <20260415055756.3825584-1-ashutoshdesai993@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rose_process_rx_frame() calls rose_decode() which reads skb->data[2] without any prior length check. For CLEAR REQUEST frames the state machines then read skb->data[3] and skb->data[4] as the cause and diagnostic bytes. A crafted 3-byte ROSE CLEAR REQUEST frame passes the minimum length gate in rose_route_frame() and reaches rose_process_rx_frame(), where rose_decode() reads one byte past the header and the state machines read two bytes past the valid buffer. A remote peer can exploit this to leak kernel memory contents or trigger a kernel panic. Add a pskb_may_pull(skb, 3) check before rose_decode() to cover its skb->data[2] access, and a pskb_may_pull(skb, 5) check afterwards for the CLEAR REQUEST path to cover the cause and diagnostic reads. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Ashutosh Desai --- V2 -> V3: drop kfree_skb() calls to fix double-free; add end-user visible symptom to commit log; use [net] subject prefix V1 -> V2: switch skb->len check to pskb_may_pull; add pskb_may_pull(skb, 3) before rose_decode() to cover its skb->data[2] access v2: https://lore.kernel.org/netdev/177614667427.3606651.8700070406932922261= @gmail.com/ v1: https://lore.kernel.org/netdev/20260409013246.2051746-1-ashutoshdesai99= 3@gmail.com/ net/rose/rose_in.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/rose/rose_in.c b/net/rose/rose_in.c index 0276b393f0e5..8e60dc562b4a 100644 --- a/net/rose/rose_in.c +++ b/net/rose/rose_in.c @@ -269,8 +269,14 @@ int rose_process_rx_frame(struct sock *sk, struct sk_b= uff *skb) if (rose->state =3D=3D ROSE_STATE_0) return 0; =20 + if (!pskb_may_pull(skb, 3)) + return 0; + frametype =3D rose_decode(skb, &ns, &nr, &q, &d, &m); =20 + if (frametype =3D=3D ROSE_CLEAR_REQUEST && !pskb_may_pull(skb, 5)) + return 0; + switch (rose->state) { case ROSE_STATE_1: queued =3D rose_state1_machine(sk, skb, frametype); --=20 2.34.1