From nobody Tue Jun 16 02:37:47 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB21D3DDDB2 for ; Wed, 15 Apr 2026 15:58:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776268684; cv=pass; b=g5+lV0zCexIcNI5o2Fmsw8MOJaZzFQDiMEJEblVMvu/pQhqbGRCezKAP7/6YPI8ZcmNHcJi+CPie6e2Z2L/SrrWzJwChKQLkl3xbZg2RuHyNWClYAdzWnd/7cM1hpy9ojArn+QV6hRPTgyxsBKBbyP0tOAfQzKuFVv0jFpqrEPU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776268684; c=relaxed/simple; bh=WVn4toorHA24f728N5FsZaEEGcdfKTQfDfjaCw55gW0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Dvo+rgPxRxUxYE5L/iX4CKdxZBxXPBs23KupZ+KN8d2Dy+G3ImBf47r8kLlLwL7QwrgXbNwFlPSlj9ZU+G6pju+5fjzL1wmwowF5RY48cRzz7zzqDMaBUO47UhcBgtSoJpiSDztkYrmSFfTwWL2TOBYstlni01nX12qWNNI7u3Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=UROCsJF4; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="UROCsJF4" ARC-Seal: i=1; a=rsa-sha256; t=1776268640; cv=none; d=zohomail.com; s=zohoarc; b=YT8/bT1HBfff6nZ6JK13mK/JDazXdn+n8xsVsPf2W/VkuSkEqDWCZplW0Q0z3+/aHYPVxi2e4PTGlWJGOra7DlzQzpjLqgEjIa8QrrH7gbEtGAmC+yZwkjVHCO8dZayNRrhun1/N5cpZKHsQuNkaE/iJxZK3KensR0tgf7EDOqs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776268640; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Bqd9FzwWq7KiLaT/1JUu11utyc7XKPue9idZFDeOEGY=; b=gcCXG3j2nq85g7heLV2KTUNk8u7WFhGVy7b2nBv7Hi7tzEtzjr8aU8rSKuInFOAzwUnZPfFHsatRqB0D4cGqviEw6WGKB9EWFjzFAtjRcUbtxdwodHpZeuQKxaD64vRFGnU9P0KYMKEtToXj9Af+j8C/LxayNoaGPXq7VsxMrsg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776268640; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=Bqd9FzwWq7KiLaT/1JUu11utyc7XKPue9idZFDeOEGY=; b=UROCsJF48F+RuRP2FxgS8ufWA0of5NxcqPNmEIpQ01RogTblMbmzTNZskdCdWxUb XGB50koYx50yOTAqxrL2nbMUAxoGb027pO0G+BXL+TIUMuv8/E7ny4rODbeWTeGnkKJ SpCKNRN5ellvzjzpgTt6Am3MtLyaGAzjgbNMz7vs= Received: by mx.zohomail.com with SMTPS id 1776268638712152.84997227807446; Wed, 15 Apr 2026 08:57:18 -0700 (PDT) From: Nicolas Frattaroli Date: Wed, 15 Apr 2026 17:56:42 +0200 Subject: [PATCH 1/2] drm/scdc-helper: Add scdc_status debugfs entry Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260415-scdc-link-health-v1-1-8e731e88eaf0@collabora.com> References: <20260415-scdc-link-health-v1-0-8e731e88eaf0@collabora.com> In-Reply-To: <20260415-scdc-link-health-v1-0-8e731e88eaf0@collabora.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.15.2 SCDC provides status information on the current display link. At the very least, it may be useful to expose this info through debugfs. Add a debugfs entry for it under the connector, which displays a few more details parsed out of the SCDC registers. A new drm_scdc_debugfs_init function can be called by the connector implementation to initialise the debugfs file. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/display/drm_scdc_helper.c | 229 ++++++++++++++++++++++++++= ++++ include/drm/display/drm_scdc_helper.h | 56 ++++++++ 2 files changed, 285 insertions(+) diff --git a/drivers/gpu/drm/display/drm_scdc_helper.c b/drivers/gpu/drm/di= splay/drm_scdc_helper.c index df878aad4a36..d582ba38a610 100644 --- a/drivers/gpu/drm/display/drm_scdc_helper.c +++ b/drivers/gpu/drm/display/drm_scdc_helper.c @@ -24,11 +24,14 @@ #include #include #include +#include #include +#include =20 #include #include #include +#include #include =20 /** @@ -55,6 +58,11 @@ =20 #define SCDC_I2C_SLAVE_ADDRESS 0x54 =20 +struct scdc_debugfs_priv { + struct drm_connector *connector; + struct drm_scdc_state state; +}; + /** * drm_scdc_read - read a block of data from SCDC * @adapter: I2C controller @@ -276,3 +284,224 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct drm_co= nnector *connector, return true; } EXPORT_SYMBOL(drm_scdc_set_high_tmds_clock_ratio); + +/** + * drm_scdc_read_status0_flags - Read SCDC "Status Flags" Register + * @connector: pointer to &struct drm_connector to issue the scdc request = on + * @flags: pointer to the caller's &struct drm_scdc_status_flags to output= to + * + * Reads the SCDC Status Flags 0 register, and outputs its contents to the + * destination @flags. Contents of @flags.status0 is only valid if function + * returns 0. + * + * Returns: %0 on success, negative errno on error. + */ +int drm_scdc_read_status0_flags(struct drm_connector *connector, + struct drm_scdc_status_flags *flags) +{ + int ret; + + ret =3D drm_scdc_writeb(connector->ddc, SCDC_UPDATE_0, SCDC_STATUS_UPDATE= ); + if (ret) + return ret; + + return drm_scdc_readb(connector->ddc, SCDC_STATUS_FLAGS_0, &flags->status= 0.data); +} +EXPORT_SYMBOL(drm_scdc_read_status0_flags); + +/** + * drm_scdc_read_error_counters - Read and clear SCDC error counters + * @connector: pointer to &struct drm_connector to issue the scdc request = on + * @counter: Caller's u16 array with 3 elements to write the counter value= s into + * + * Read the SCDC channel error counters. If the count of channel *n* is va= lid, + * write it into counter[n]. Otherwise, set counter[n] to 0. Reads all cou= nters + * in one read chunk, then clears every counter, as is mandated. + * + * Returns: %0 on success, negative errno on error. + */ +int drm_scdc_read_error_counters(struct drm_connector *connector, u16 coun= ter[3]) +{ + u8 buf[7] =3D { 0 }; + ssize_t ret; + u8 sum =3D 0; + int i; + + ret =3D drm_scdc_writeb(connector->ddc, SCDC_UPDATE_0, SCDC_CED_UPDATE); + if (ret) + return ret; + + /* why in the fucking fuck does this return a ssize_t */ + ret =3D drm_scdc_read(connector->ddc, SCDC_ERR_DET_0_L, buf, ARRAY_SIZE(b= uf)); + if (ret) + return ret; + + /* + * Verify the "checksum", i.e. sum up everything including the checksum + * register as a wrapping unsigned 8-bit addition and verify it's 0. + */ + for (i =3D 0; i < ARRAY_SIZE(buf); i++) + sum =3D wrapping_add(u8, sum, buf[i]); + + if (sum) + return -EPROTO; + + for (i =3D 0; i < ARRAY_SIZE(buf) - 1; i +=3D 2) { + if (buf[i + 1] & SCDC_CHANNEL_VALID) + counter[i / 2] =3D buf[i] | (buf[i + 1] & ~SCDC_CHANNEL_VALID) << 8; + else + counter[i / 2] =3D 0; + + buf[i] =3D 0; + buf[i + 1] =3D 0; + } + buf[ARRAY_SIZE(buf) - 1] =3D 0; + + return drm_scdc_write(connector->ddc, SCDC_ERR_DET_0_L, buf, ARRAY_SIZE(b= uf)); +} +EXPORT_SYMBOL(drm_scdc_read_error_counters); + +/** + * drm_scdc_read_state - Update state from SCDC + * @connector: pointer to a &struct drm_connector on which to operate on + * @state: pointer to a &struct drm_scdc_state to fill + * + * Reads update flags from SCDC, and updates the parts of @state that SCDC + * claims have changed, as well as populating those where such a distincti= on + * can't be made. + * + * Returns: %0 on success, negative errno on failure. + */ +int drm_scdc_read_state(struct drm_connector *connector, struct drm_scdc_s= tate *state) +{ + u8 upd_flags[2] =3D { 0 }; + struct i2c_adapter *ddc; + struct drm_scdc *scdc; + int ret; + u8 val; + + if (!state || !connector) + return -ENODEV; + + scdc =3D &connector->display_info.hdmi.scdc; + ddc =3D connector->ddc; + + if (!scdc->supported) + return -EOPNOTSUPP; + + ret =3D drm_scdc_readb(ddc, SCDC_TMDS_CONFIG, &val); + if (ret) + return ret; + + state->scrambling_enabled =3D !!(val & SCDC_SCRAMBLING_ENABLE); + state->tmds_bclk_x40 =3D !!(val & SCDC_TMDS_BIT_CLOCK_RATIO_BY_40); + + state->scrambling_detected =3D drm_scdc_get_scrambling_status(connector); + + ret =3D drm_scdc_read(ddc, SCDC_UPDATE_0, &upd_flags, sizeof(upd_flags)); + if (ret) + return ret; + + if (upd_flags[0] & SCDC_STATUS_UPDATE) { + ret =3D drm_scdc_read_status0_flags(connector, &state->stf); + if (ret) + return ret; + } + + if (upd_flags[0] & SCDC_CED_UPDATE) { + ret =3D drm_scdc_read_error_counters(connector, state->error_count); + if (ret) + return ret; + } + + return 0; +} +EXPORT_SYMBOL(drm_scdc_read_state); + +#define scdc_print_str(_f, key, s) \ + (seq_printf((_f), "%-30s: %s\n", (key), (s))) +#define scdc_print_flag(_f, key, val) \ + (scdc_print_str((_f), (key), str_yes_no((val)))) +#define scdc_print_dec(_f, key, val) \ + (seq_printf((_f), "%-30s: %d\n", (key), (val))) + +static int scdc_status_show(struct seq_file *m, void *data) +{ + struct scdc_debugfs_priv *priv =3D m->private; + struct drm_scdc_state *st =3D &priv->state; + struct drm_connector *connector =3D priv->connector; + struct drm_scdc *scdc =3D &connector->display_info.hdmi.scdc; + int ret; + + drm_connector_get(connector); + + if (connector->status !=3D connector_status_connected) { + ret =3D -ENODEV; + goto err_conn_put; + } + + scdc_print_flag(m, "SCDC Supported", scdc->supported); + if (!scdc->supported) { + ret =3D 0; + goto err_conn_put; + } + + scdc_print_flag(m, "Sink Read Request Capable", scdc->read_request); + scdc_print_flag(m, "Scrambling Supported", scdc->scrambling.supported); + scdc_print_flag(m, "Low Rate Scrambling Supported", scdc->scrambling.low_= rates); + + ret =3D drm_scdc_read_state(connector, st); + drm_connector_put(connector); + if (ret) + return ret; + + scdc_print_flag(m, "Scrambling Enabled", st->scrambling_enabled); + scdc_print_flag(m, "Scrambling Detected", st->scrambling_detected); + + if (st->tmds_bclk_x40) + scdc_print_str(m, "TMDS Bit Clock Ratio", "1/40"); + else + scdc_print_str(m, "TMDS Bit Clock Ratio", "1/10"); + + scdc_print_flag(m, "Clock Detected", st->stf.status0.flags.clock_detected= ); + scdc_print_flag(m, "Channel 0 Locked", st->stf.status0.flags.ch0_locked); + scdc_print_flag(m, "Channel 1 Locked", st->stf.status0.flags.ch1_locked); + scdc_print_flag(m, "Channel 2 Locked", st->stf.status0.flags.ch2_locked); + + scdc_print_dec(m, "Channel 0 Errors", st->error_count[0]); + scdc_print_dec(m, "Channel 1 Errors", st->error_count[1]); + scdc_print_dec(m, "Channel 2 Errors", st->error_count[2]); + + return 0; + +err_conn_put: + drm_connector_put(connector); + + return ret; +} +DEFINE_SHOW_ATTRIBUTE(scdc_status); + +/** + * drm_scdc_debugfs_init - Initialize scdc files in connector debugfs + * @connector: pointer to &struct drm_connector to operate on + * @root: debugfs &struct dentry for the debugfs root of @connector + * + * Creates SCDC-related debugfs files for @connector. Must be called after + * @root is already created. + */ +void drm_scdc_debugfs_init(struct drm_connector *connector, struct dentry = *root) +{ + struct scdc_debugfs_priv *priv; + + if (!root || !connector) + return; + + priv =3D drmm_kzalloc(connector->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return; + + priv->connector =3D connector; + + debugfs_create_file("scdc_status", 0444, root, priv, &scdc_status_fops); +} +EXPORT_SYMBOL(drm_scdc_debugfs_init); diff --git a/include/drm/display/drm_scdc_helper.h b/include/drm/display/dr= m_scdc_helper.h index 34600476a1b9..b597e24a2976 100644 --- a/include/drm/display/drm_scdc_helper.h +++ b/include/drm/display/drm_scdc_helper.h @@ -30,6 +30,55 @@ =20 struct drm_connector; struct i2c_adapter; +struct dentry; + +struct drm_scdc_status_flags { + /* Status Register 0 */ + union { + struct { + bool clock_detected : 1; + bool ch0_locked : 1; + bool ch1_locked : 1; + bool ch2_locked : 1; + bool rsvd_4 : 1; + bool rsvd_5 : 1; + bool rsvd_6 : 1; + bool rsvd_7 : 1; + } flags __packed; + u8 data; + } status0; + + /* Status Register 1 */ + union { + struct { + bool rsvd_0 : 1; + bool rsvd_1 : 1; + bool rsvd_2 : 1; + bool rsvd_3 : 1; + bool rsvd_4 : 1; + bool rsvd_5 : 1; + bool rsvd_6 : 1; + bool rsvd_7 : 1; + } flags __packed; + u8 data; + } status1; +}; + +struct drm_scdc_state { + /** @stf: contents of the status flag registers */ + struct drm_scdc_status_flags stf; + /** @scramling_enabled: true if TMDS scrambling is on */ + bool scrambling_enabled; + /** @scrambling_detected: true if the sink actually detected scrambling */ + bool scrambling_detected; + /** + * @tmds_bclk_x40: true if TMDS bit period is 1/40th of the TMDS + * clock period, false if it's 1/10th of the clock period. + */ + bool tmds_bclk_x40; + /** @error_count: character error counts for each channel */ + u16 error_count[3]; +}; =20 ssize_t drm_scdc_read(struct i2c_adapter *adapter, u8 offset, void *buffer, size_t size); @@ -77,4 +126,11 @@ bool drm_scdc_get_scrambling_status(struct drm_connecto= r *connector); bool drm_scdc_set_scrambling(struct drm_connector *connector, bool enable); bool drm_scdc_set_high_tmds_clock_ratio(struct drm_connector *connector, b= ool set); =20 +int drm_scdc_read_status0_flags(struct drm_connector *connector, + struct drm_scdc_status_flags *flags); +int drm_scdc_read_state(struct drm_connector *connector, + struct drm_scdc_state *state); +int drm_scdc_read_error_counters(struct drm_connector *connector, u16 coun= ter[3]); +void drm_scdc_debugfs_init(struct drm_connector *connector, struct dentry = *root); + #endif --=20 2.53.0 From nobody Tue Jun 16 02:37:47 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3A7E3D9DBC for ; Wed, 15 Apr 2026 15:57:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776268669; cv=pass; b=VMcyQ3vUHkYjioCQMRjKwNYah+fJJUsN7d+5wY00cxwGSLFMxP9+qzblqQP7biFjFh/IPPvj0qgtmp7vgbTJ/WjysfimJXL10wytfPVZHQpv9T1AZMdWE32Zg6ZxGfCVOM5JdZI4B3Qig5x/4rLsfsN2J7L0v54/wTs5aHHFDGw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776268669; c=relaxed/simple; bh=1J5ZlyTWfs0NrSo+wQ+cOZPmJNE7i4sQxIMoOxyvbAk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j/cPvEcKqAd6qumexCkRakOND7fhfuaYoTQ+vh6KW0kygABvob+PCTNFIqHg3Tgb6+brylBBR9UCZISqZXYZNUbJ6JnMxFiNJTWqgsDeHgYuIUg08kBH+yAjoCRdE87iFpC0oyEAEfbCKtkFnM2K/rsUCLrHHe2Q9hTl/5frBF0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=h8hcNuL3; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="h8hcNuL3" ARC-Seal: i=1; a=rsa-sha256; t=1776268645; cv=none; d=zohomail.com; s=zohoarc; b=mwE8iNk6gtDB4AlWGBN6Htnxg3LPmm4UzkJXhYTPGHrg06S75+JuwsM22HJ3jI2kZjCDtsa9CbWlQGmkJotjr7rZdlp5Ri8n6V9FtQHteUbBqg2ehufAez7d10gS+VG/J08yFYNiU2zLL9zmVM3u/2Fi6CnNjylWk1+p3XlPU54= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776268645; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=hT6jDzcZAvBjtlDBMTEBSx7DyEPgkDHN7zKQrynwvQI=; b=ADa7fF9e174tg2p/CylKdk2NMlhydxH5Qr0tkeDFHtZC96j8FmlL6300SxrP5ATcb1NmNQouc4qMPRDnNLm3l4vMUeeEVQNEdyPC/78rJCMYJnk33ZlEoDL5StVAZICjxZ6DPJuu/ileZn0RoJgaTYMX9QKU1sklHLh5mFFXBW0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1776268644; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=hT6jDzcZAvBjtlDBMTEBSx7DyEPgkDHN7zKQrynwvQI=; b=h8hcNuL3MR9IF+XnEDjfQlfXRYEv6FHhanKQ3fv8F5Ax9TIdgNO6LYs0R/qXvf53 iPDrcXf0/CL27A3icxrJnzFhA6LutgzN0lbyHDkVWx4Y84F9uOIWlHGsbQQ2b3AjQ6z zaggho0UGLWcJ/ahquIl5YfydBg5f6kKR/tu4qUM= Received: by mx.zohomail.com with SMTPS id 1776268642340129.5645777003166; Wed, 15 Apr 2026 08:57:22 -0700 (PDT) From: Nicolas Frattaroli Date: Wed, 15 Apr 2026 17:56:43 +0200 Subject: [PATCH 2/2] drm/display: bridge_connector: init scdc debugfs for HDMI Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260415-scdc-link-health-v1-2-8e731e88eaf0@collabora.com> References: <20260415-scdc-link-health-v1-0-8e731e88eaf0@collabora.com> In-Reply-To: <20260415-scdc-link-health-v1-0-8e731e88eaf0@collabora.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.15.2 On drm_bridge_connectors that contain an HDMI bridge, initialise the SCDC debugfs entry under the connector's debugfs root. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/display/drm_bridge_connector.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c b/drivers/gpu/d= rm/display/drm_bridge_connector.c index 39cc18f78eda..3e4e6bead321 100644 --- a/drivers/gpu/drm/display/drm_bridge_connector.c +++ b/drivers/gpu/drm/display/drm_bridge_connector.c @@ -25,6 +25,7 @@ #include #include #include +#include =20 /** * DOC: overview @@ -263,6 +264,9 @@ static void drm_bridge_connector_debugfs_init(struct dr= m_connector *connector, if (bridge->funcs->debugfs_init) bridge->funcs->debugfs_init(bridge, root); } + + if (bridge_connector->bridge_hdmi) + drm_scdc_debugfs_init(connector, root); } =20 static void drm_bridge_connector_reset(struct drm_connector *connector) --=20 2.53.0