From nobody Tue Jun 16 01:27:13 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D6A0387566 for ; Tue, 14 Apr 2026 21:56:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776203817; cv=none; b=npzY0hBzYa6lYTKIenAVcukEuOJ2o8AfTY0kGiyyXLQYbyfAyF5LF3PQl2eLiFyG3xo0VU2udiDns8zxTaHFIB7CR6845Oz43NdwHvO5JD/UBHjC8nIOCwCRWxe9f3G8JB+5XddSoZ98gMIGmju22Qvg7XWRZqHxTcabK6lxawQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776203817; c=relaxed/simple; bh=VjyphYDxJuD6shD9T+iAyy1PPkHnicv+dCgF1sxz6cg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BXoQvRO2VJU2cGofSVCThs89I0GWyjOowzoDjlw+74Q5Oyp7tFZsDpyraAUYqROacxKqq6JwMHebTlCAgJAriscbcwImj8Y/ofFdRO44+hWxLdHzLeTfONJ4zvFXJ6fUDB0jTYyx9LKiRVrETRx93WkDsqqt/Vrrz+taVkCxrsM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m+qtOouy; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m+qtOouy" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-488b8bc6bc9so43793355e9.3 for ; Tue, 14 Apr 2026 14:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776203814; x=1776808614; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=nKXCo1Zg374mnpyoQ0g0S9cmj+zlNgBNIT4+pAiNf8Q=; b=m+qtOouyhESPigFqvRKcpjildvBtZuSSFbRcA/gsZP2DC0D6v83MtJLvM5mDstIg66 4IIv0clQFB99qU+ZHUbDoca999rm1N8MfJ2Ijzqkj2x/+OfkiO/Ut0tvyiLtM66ufD+G YDzM15Aj8BHbJlU3n26y8qtxtIHjt6p50jF/xqqRbqWSimccYAsGtspBsuPo7jtFmOPN i+j2syFoeYEKN2PdVGsB+5iMaErsDUYvBweB/CkdVluDhtPviC4icrJq6J2TnYr4my6i akvzLQZyZ/SkgFklya0UaFQQgp7Ou+4uewlQgYucvV0kcJuf+PORVm4soAy0lu5wcZPd 9WCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776203814; x=1776808614; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nKXCo1Zg374mnpyoQ0g0S9cmj+zlNgBNIT4+pAiNf8Q=; b=KNPUrjO57dHVFDTbDsmdouJkUc26Xf9TX1zIdxGm1uZXqsEw3/Wzisi84d0gZ+A+sQ SPzevEDPg92k5sps6ToLV0BVBooNoRbQWZHgDjz1sS9Xhit/hDWWNKKc6AE9sxDyhPLL V33mlTLOxgnulGhkA2kzPwqfsZucThI18YEvHA32j7xypbl7+yNwWjbWH2EfZBJpbig8 NP/hae/7HQnm+o/0GQrIZVsRh5RJxIWk62oVrDyv/woeuh0z7HVs3rLNxUwPBWT/17ks 0XXKHMIsxIijzJ0Ppr5P6rqhCFYXZhr+XucKAEzCS2hRG1ZE0zsAYB7FO+RISj2xc+Hw iO4Q== X-Forwarded-Encrypted: i=1; AFNElJ/2sz2HzADtzdhmznyF/BR1byTiIOlPIwUqjoGEjsLuegD1p0ptLeYn54/CiRTNevAAY9mQuEnRTQurXXQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyt5pZorT0ze409To3nvgbvaDW+n4eP764fwqUaRWcjq6igtvdc uq66/dttA+ImtCmjEQRrcOTl/byW87dP+6KYK8MYBS8L8adONkL4a08w X-Gm-Gg: AeBDievr25TBezJa6gCvVacJfV2ElJZDYwffW4Xp7M1mKA5KJOrqgHNgGh8KeuS4rIB 9KdCwaaHaKc+yRVC/0klRRwL9Mnf+ZjaN1ZH7fpA6jBp10tNXQiNFLmWnBfBfW9Vwf5w3mrMdu4 wo9MZl0YFkipg/yrsyvfuTogrgk1ZNftq3U12zo3V6fO1gIyeCUTZn2s2j/lahX6rtHIC1+z2mT /50KxjTdKJTVQlWxS6B6NTr6JjePMmoHiiTb6UIAVFQY/RRHeaZQc3y2cjbJpHMZ+lC11PoP1rf bvbXjxM6eGaoeuxBX+XuhEVBvkobigZ6icWZ4ANo2HaBGtPXjiAk1IGTGRFjGJXB+FuP/04ucqc hRvA9oaprzm9Dme7ME2tgrzHqV+bbMht+KosmHuAjMUfea4jWh1r+wR8RgArQxWHN+81kSizkR2 GS4n08XzTX3ZRyaCE5qJeNcC5dSyrixA/0HTQyxRz3GxH6i6tU9HJGb5gn5Al9ixMhB2NuVod2v UlC X-Received: by 2002:a05:600c:3150:b0:488:c80c:c236 with SMTP id 5b1f17b1804b1-488d68057f3mr274715815e9.5.1776203814378; Tue, 14 Apr 2026 14:56:54 -0700 (PDT) Received: from nixos-office (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488ede2b87asm76424365e9.10.2026.04.14.14.56.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 14:56:53 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: agordeev@linux.ibm.com, gor@linux.ibm.com, hca@linux.ibm.com, iii@linux.ibm.com Cc: meted@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, akpm@linux-foundation.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Julian Braha Subject: [RESEND PATCH] s390: fix dead defaults for S390_MODULES_SANITY_TEST and S390_UNWIND_SELFTEST Date: Tue, 14 Apr 2026 22:56:51 +0100 Message-ID: <20260414215651.151228-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" These config options currently have unconditional defaults of 'n' from the def_tristate statement, which shadow the later default of 'KUNIT_ALL_TESTS', causing it to be dead code. It looks to me like the commit 25d36a85c61b ("s390/test_unwind: convert to = KUnit") added the KUNIT_ALL_TESTS default to S390_UNWIND_SELFTEST, but mistakenly didn't remove the previous 'n' default. Then, the later commit 90c5318795ee ("s390/module: test loading modules wit= h a lot of relocations") copied the Kconfig layout from S390_UNWIND_SELFTEST when adding the S390_MODULES_SANITY_TEST config option, without noticing the existing mista= ke. This dead code was found by kconfirm, a static analysis tool for Kconfig. Fixes: 25d36a85c61b ("s390/test_unwind: convert to KUnit") Fixes: 90c5318795ee ("s390/module: test loading modules with a lot of reloc= ations") Signed-off-by: Julian Braha --- arch/s390/Kconfig | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index edc927d9e85a..1b3afe89cb00 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig @@ -999,9 +999,8 @@ config S390_MODULES_SANITY_TEST_HELPERS menu "Selftests" =20 config S390_UNWIND_SELFTEST - def_tristate n + def_tristate KUNIT_ALL_TESTS depends on KUNIT - default KUNIT_ALL_TESTS prompt "Test unwind functions" help This option enables s390 specific stack unwinder testing kernel @@ -1023,9 +1022,8 @@ config S390_KPROBES_SANITY_TEST Say N if you are unsure. =20 config S390_MODULES_SANITY_TEST - def_tristate n + def_tristate KUNIT_ALL_TESTS depends on KUNIT - default KUNIT_ALL_TESTS prompt "Enable s390 specific modules tests" select S390_MODULES_SANITY_TEST_HELPERS help --=20 2.53.0