From nobody Mon Jun 15 23:17:13 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 802143E8661 for ; Tue, 14 Apr 2026 14:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776176038; cv=none; b=qC6TJ/JoYaFwU5vd+jBUvsi2UwKZEJ9xbIiM9aoH3WCqyvuV3WZzrW/wzKJBFDtKnX6fSx9JPeZI1zd+LfVTVLqCWWz7vcA4jiH3YiaDxzNyR70TV6Dh/j/hNiD5Ix15ah+cet7asvsYTvmwCX6qYfPh3wwEekMyoq7I85ZpEyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776176038; c=relaxed/simple; bh=cOS0ChWcR5EQEJfRL3vQ0seipQYF8rfAJqzgGGktYq8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mRSSXUBT2ewqO29UhC4UO9pm0c7tPyl+6QgYOaCqME1JyPgDtuHkk4MBucDED+hry/q4nBRu4gk7cIhhGruraQ7opXaYNT/8aeCLUxT/XsxFFf/FThi0ReBqdFddzmWzhXaPfzYnbuGz4+keLwFVzCObet66se/8GyBUKX7A7Dc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WaoHTreu; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WaoHTreu" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-35da8d037a5so2680094a91.0 for ; Tue, 14 Apr 2026 07:13:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776176037; x=1776780837; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YvKLQdGF1hNgVUyBQbdy4v4/PC1QoXHGam0o2m/0ceA=; b=WaoHTreuVf2lznPURueuvdlXnCkubx0yS3tA8nO+4SJ1rRLMRGTCy3C21In64cOP1u m3lrGh6I1TNLNuE1b+CYXJHEB1Pu+AGdK/HZU0nsMnWFjQJlQ1TWT1Ufc+fKtyivHX1g k0YtfXe3oPtShaiV1kgVgkGPqFjbpYzgRbm0bOuO0BUab9faElaN7tmwfZptQYiDVOzM lX+TH6/rzI4gGAdZo8QwwLr9H9kGcpUdzzf5Bo2f8htiI+aAt7ahEoDAn14/pqv0SiD5 7PYotPtLTDt/0jV9diH1culRR0nLQOie79/Xk/DumR7fT2auud98C2RKdBRh1jn1Rx2y veRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776176037; x=1776780837; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YvKLQdGF1hNgVUyBQbdy4v4/PC1QoXHGam0o2m/0ceA=; b=hpcFXCFkpe2JEnU6Aa6OxAXnLh04mbRZgJKgeAPD9V166+6s7Pm3spL5RYYXK6LYyj O+qorE6sXpgCqX3FggY2+5ULZziDrhkrC+YlfL9gr2lxt/I8R2qihafgkmpSsLtxwI8U DTmzMy+zdqKItQwgsVaEMVTaasf/zVSio56Ci7jsxNTdGpAT7LMAO0rW8pbXX4EmkfzM Ny5jsa9wLrWjs6FGDsArApctT7D6sf386GaVwgnwgABIKv9xAmbS5/Z1QdtInKE1LP17 IQmK1U3p9xJBFtcIeoAmL3JLRLnnXRuuXe4XOpCUwH/A2g+b+8UvX2D4FZQF8PPf/+1V swiA== X-Forwarded-Encrypted: i=1; AFNElJ8a5VpPIk0Rwjn05n8NzBMX4EL+4AcgOFFhwd2qsMZxRY4iKMjt5kEamyjtRzbZCnuGogkdqIAkKrKaHNQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzdRzhOTX1LhLmtyRK4CsJctdpXbMAeyYMjkIzDNUL3idfah2y4 AYTb4x4jcRjqkLdziaWDsi4aL+kGJSEgQVBHxgcbHO/Ag8ik7JFvCfRN X-Gm-Gg: AeBDiesm90n893IIgHd7JcO1hlhargjN7+bB6/YRqa5KUaHKzG81aWiaRfBjZ5TOFD4 jFIl1dT0afTlW4QbfSm+JpbXTaNIi3tznwE947ibT/zpn0J1twEHxm39Iad1ozYu6gSH1W7lmEq oiNN09gFw9MtX1TJaDM1AdFFEzLgZzZd7EDjzrPqC0yOTqrMl+iLDb/4UNR0xTnJS3ar0z90jMW U2Y+GS2rhgxXStp+QgzZ7Nh91GsvJlkJe7TqeV/hOZj4CSbN+3GtU30lOTW7MpA5BBm7Qx2yGhv pH7qXafLLl+IBHaOx7PTsZ9RUdTsZOeQwS+HuajIceXm0C7cDlu5+2Af8/n9HrO5rwlz6Sr3/Jp ttPSwyn5cSTGjDkBx/3aW2fb8nzLj+Ld4IGvbmt6V/Hzi+3ZEsNGkG04BQc93SN9SPG0SA2NvZM WmI9pW94Ytanh1vxFEp7tIuDZpdBG+eRffe9tdat4qFHKw X-Received: by 2002:a17:90a:d610:b0:35a:24f3:2c8e with SMTP id 98e67ed59e1d1-35e4276eb1cmr16742780a91.9.1776176036806; Tue, 14 Apr 2026 07:13:56 -0700 (PDT) Received: from tech-Alienware-m15-R6.. ([122.171.18.84]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35fc6e8b09fsm2250063a91.4.2026.04.14.07.13.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 07:13:56 -0700 (PDT) From: Sunny Patel To: David Hildenbrand Cc: Andrew Morton , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sunny Patel Subject: [PATCH] mm/migrate_device: Cleanup up PMD Checks and warnings Date: Tue, 14 Apr 2026 19:43:38 +0530 Message-ID: <20260414141344.29949-1-nueralspacetech@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the odd VM_WARN_ON_FOLIO(!folio, folio) usage and replace it with a simpler VM_WARN_ON_ONCE(!folio) check. Drop the redundant VM_WARN_ON_ONCE(!pmd_none(*pmdp) && !is_huge_zero_pmd(*pmdp)). Refactor the PMD checks to use pmd_present(), making the control flow clearer and avoiding duplicate condition checks. Signed-off-by: Sunny Patel Acked-by: David Hildenbrand (Arm) Acked-by: SeongJae Park Acked-by: Zi Yan --- mm/migrate_device.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/migrate_device.c b/mm/migrate_device.c index 8079676c8f1f..fe1c1999aa2d 100644 --- a/mm/migrate_device.c +++ b/mm/migrate_device.c @@ -807,8 +807,7 @@ static int migrate_vma_insert_huge_pmd_page(struct migr= ate_vma *migrate, bool flush =3D false; unsigned long i; =20 - VM_WARN_ON_FOLIO(!folio, folio); - VM_WARN_ON_ONCE(!pmd_none(*pmdp) && !is_huge_zero_pmd(*pmdp)); + VM_WARN_ON_ONCE(!folio); =20 if (!thp_vma_suitable_order(vma, addr, HPAGE_PMD_ORDER)) return -EINVAL; @@ -865,12 +864,13 @@ static int migrate_vma_insert_huge_pmd_page(struct mi= grate_vma *migrate, if (userfaultfd_missing(vma)) goto unlock_abort; =20 - if (!pmd_none(*pmdp)) { + if (pmd_present(*pmdp)) { if (!is_huge_zero_pmd(*pmdp)) goto unlock_abort; flush =3D true; - } else if (!pmd_none(*pmdp)) + } else if (!pmd_none(*pmdp)) { goto unlock_abort; + } =20 add_mm_counter(vma->vm_mm, MM_ANONPAGES, HPAGE_PMD_NR); folio_add_new_anon_rmap(folio, vma, addr, RMAP_EXCLUSIVE); --=20 2.43.0