From nobody Mon Jun 15 23:18:17 2026 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A63EA3E5ED1 for ; Tue, 14 Apr 2026 12:10:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776168640; cv=none; b=kyhG+6LN5cNznWuP2jty6lDlfwMmasi3eyvfayw9vdWZoFmIlKaw5XGiS6RNzRCw2AzAIXCWA9fGYVtPBFWtdvIxxlg6vO0daX/7OjwRZJ3/Si/8Qos3iEuHoDHUpTBqStUqp7D2fK5cXZYf6Jo+qlvLw2NmSsM5OCHiQ0Eq57Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776168640; c=relaxed/simple; bh=tfda8ZO8a0yV41gxG73VphHs3ZacuNxiugV7H0nb0QM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jwtmeZVeXKgul/0BICDWp6ZtjJzOF1suVx+9ZbG5+UZ6Kb1lNwCcpJdc4YnaN2byY4ipR0IDC2ic7dLJYcU5x0qTwZ69QmF2TesAgvCDfp/iRl112shiUARB4L+bz3101snOtQwvq6srTxNomvqwcSuhTYSsY1S99a+OYXTTvFs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M44VrBZF; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M44VrBZF" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c742723c863so3528081a12.0 for ; Tue, 14 Apr 2026 05:10:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776168638; x=1776773438; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UWUp3g+LxoslnPkybujRtv0aSTtZxDvWQnt9LN6HDso=; b=M44VrBZFu/SZdxvw08xLkmC5Dykle09uC2XVM89jaBcBAtnEJrsvcGFMXxLlRbBRaY IIeJ8FKUnY92MKSd1u5pfQex6bn8Qb3PbP6Xyi7CZAiVU4MQuSJaCfm7kPYJJnCANZgd JygQBLGSG+HQpJ/vL9ja4Exmgx4p0Ztp+XnOSQJ3wTKkhoEbbEBwpX3Kj6CQt4mDdEMG 9w2JMT76otC+X8OTi+O/tH44IzhYSdMMioa0sv/fcy/8iXE0h2u+nFMIpbQ3RUb4bTnU 32cqDtIy05lPguapmTGcc2DtMuDoic8gbE3i+jlWijJ5DCE0Qx1ewMi0id3nbjf44i00 bKPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776168638; x=1776773438; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UWUp3g+LxoslnPkybujRtv0aSTtZxDvWQnt9LN6HDso=; b=RUodFpoU4oRF50L1l9PqVG1819IM+iM7IJ4qaKnRgfCAXOKTGefRQBH6tGzaS9H0H6 bgRmWWWE3RMqdyZElIvt2s8DKT22aqOYxkzcr6C3nNEB6Ww9eS/uLT6p46+cmnEMTiQB uRnTuJXt/2YL9jdONCSwW/QgCEWAJ1zMj5E1dES/kyit+KDqw0hi+djxp3Rw5SBnYhBD ESJPrZp0DXa35dBc7gqjgfYwnR4ktpgI1lti6up8wkQvqRhg62aJTI8W1ZBgOM4DVHFo Rcr0lHsHlsVqrP40WpjRhkEVtx9yykMskkbPMs9LXIR6bPGC3xO+DcsHWPDKYXEEtMct uBTA== X-Forwarded-Encrypted: i=1; AFNElJ83K3pmxAGNORuxV1oonP45drnFNh7gckorXXrxGmIiVLXpP9kIo7D4ik0jgwVWTQ/qrjP/CK+UlZQvLY4=@vger.kernel.org X-Gm-Message-State: AOJu0YzeeHWnYJVHImAJD9Bizaam4sOmZB+U4QxJrnTaz1Nb/c2xO3WF 9fsavSsl/u70apSP6YIzyV8/nu4uU0VzjtGMtF54yxNgfnNWo5BmY0Bw X-Gm-Gg: AeBDievPHziUIHXd6x3p3Ky7pW9jc7hZxB0nmH+NGlUVYu72AKDNDFtXwb/LGLG7npU AvpyTcRC1JXVOF3CRqjXG7itXWQR9HR7Gdacow/5pS7NCrU98eT8vQTRV07iG0g5I6po9juW4Gv RvYBZBvNAx5VlM7uu/xGdHBHUZkdCgNQo0aWe6PdlHaQBbGkxu1IJZpxABQ6A/TxQjcHHwg4EoC EyRsRU/O5wh6qHE40sbMUi5Yfhqestg1Y+1t3MjYfQJLbvDiGKFaNlDt+TB81L6ItAHrYVVFAfL 3xaEZh7xr+pI0fQGw0rA/XBorAt9bLss3aAYJmMcmcjj8n4LsWXw8JBocpJwt/8hSIipabW/Wgz XvuP2BjOeMaSTUeBVOgnC3AkmzPXPKTkwJZan0ugKnJu7NDyt4PrZLvwKJ8SyIEq611EvX3loMJ 1T5LbSqwteB82Rjw== X-Received: by 2002:a05:6a21:9983:b0:39c:4cc9:9d75 with SMTP id adf61e73a8af0-39fe409bcf7mr18846083637.56.1776168637484; Tue, 14 Apr 2026 05:10:37 -0700 (PDT) Received: from lgs.. ([101.32.189.54]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c794d8f3984sm1241349a12.12.2026.04.14.05.10.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 05:10:36 -0700 (PDT) From: Guangshuo Li To: Min Ma , Lizhi Hou , Oded Gabbay , Jeff Hugo , George Yang , Narendra Gutta , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] accel/amdxdna: fix IRQ vector leak in aie2_init() Date: Tue, 14 Apr 2026 20:10:24 +0800 Message-ID: <20260414121024.3142118-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" aie2_init() allocates MSI-X vectors with pci_alloc_irq_vectors() before creating the PSP handle, starting the hardware and initializing the resolver. When aie2m_psp_create(), aie2_hw_start() or xrsm_init() fails after IRQ vectors have been allocated successfully, the function releases the firmware and unwinds hardware state, but fails to free the allocated IRQ vectors. The issue was identified by a static analysis tool I developed and confirmed by manual review. Add a dedicated error path to free the IRQ vectors after pci_alloc_irq_vectors() succeeds. Fixes: 8c9ff1b181ba ("accel/amdxdna: Add a new driver for AMD AI Engine") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/accel/amdxdna/aie2_pci.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/accel/amdxdna/aie2_= pci.c index 4924a9da55b6..f05f49f691b5 100644 --- a/drivers/accel/amdxdna/aie2_pci.c +++ b/drivers/accel/amdxdna/aie2_pci.c @@ -591,14 +591,14 @@ static int aie2_init(struct amdxdna_dev *xdna) if (!ndev->psp_hdl) { XDNA_ERR(xdna, "failed to create psp"); ret =3D -ENOMEM; - goto release_fw; + goto free_irq_vectors; } xdna->dev_handle =3D ndev; =20 ret =3D aie2_hw_start(xdna); if (ret) { XDNA_ERR(xdna, "start npu failed, ret %d", ret); - goto release_fw; + goto free_irq_vectors; } =20 xrs_cfg.clk_list.num_levels =3D ndev->max_dpm_level + 1; @@ -623,6 +623,8 @@ static int aie2_init(struct amdxdna_dev *xdna) =20 stop_hw: aie2_hw_stop(xdna); +free_irq_vectors: + pci_free_irq_vectors(pdev); release_fw: release_firmware(fw); =20 --=20 2.43.0