From nobody Mon Jun 15 23:20:44 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010006.outbound.protection.outlook.com [52.101.201.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1D993DD517 for ; Tue, 14 Apr 2026 11:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776166771; cv=fail; b=XYiz8ov+YNCsUsMBGrSOc6yc+MhaWU7/StVHh1bu4f2w0nSqZG9zys+GrZhQ96JFtSgaZcshZfKyrlttXPnG8tsIjFGi8mqcUbpwB+tZwfyrbML6iUrF+aH04Sxf2StFuG1o9H8wz64mxDt5uG+QjPKF7Og/N0lEHzEwc0mck5Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776166771; c=relaxed/simple; bh=G1+UvPWiF+H8PZ5naaCaaY0EQxCRDx5NBc0TXp2ECg4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=rSkRb0qgmjwkVLnQbDue+S5FTn5Qjet0afk0b8iPiruhqaw9Azx1eVEszZR9P7Wj3JlyQN9FoJKtEDiRtFVdH1r5hhd0+2tTBSyapa46tipQpkT9y0IHXiYZidg7z2aCWyHWjrNHO8AXz1YKFBz2/ezxt6h5lnrpr08arSMm05o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gehealthcare.com; spf=pass smtp.mailfrom=gehealthcare.com; dkim=pass (2048-bit key) header.d=gehealthcare.com header.i=@gehealthcare.com header.b=yjEKl5yo; arc=fail smtp.client-ip=52.101.201.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gehealthcare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gehealthcare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gehealthcare.com header.i=@gehealthcare.com header.b="yjEKl5yo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NJ/wo4TDxhkO6ABuB4VYABtdr2RjmbdolDZBmZaVFzNP525WWwXO04RisOl/migBAW7MVvu9xwptUlpdM5wNOp0d9l0NkSzSq30Y/A45R5pIig6dMDh+NiM0DwpJCSthvZJW9ITfrSUKm9P50QtBR1qFhx5yYYKA4KovJtUtSHbykxQRwyFOXGZEl83GpAROAMk0J4ES728LQes9UoAbCb+8UeY21SdJCMfakgFpYgmFrmYHS58yem6sL1iGrEMjEMvB3L0tlBZ47YBNj5f9nyWc3FFUbTV41ZRXLn5TcZFELt0gNvtp+W7p5CtsoPK89b2III8yMPK1xfenaRdqYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lualVDQk+7lpcX1QnW0bNehJvoMHIbEXRCPhmw+9lew=; b=TThJI0HLbk8JASBpsE/50oBou1L6+7LGDGUxDi5/aOBKs11InTFevSdEoUIY1egU/OhEywHyUu+koDFjMwvyqq8PocMGxipv6H2FgnXFBrF0oVg9yaqXtMlE7J9iZilcOJjxXYIRxiU0ZSaXUG7WG9p42hfI3b2QCYVS4d9teQ6nSEX45snOo1Fpoc8YSaJaEr/IguiOqLUiIX6LKSF6jBXL6oyKkdeSy/9nL5t8L0FvjageGmCD2Q1EFmXhIzliVn8C2VuRBEcwAHm4KxM1PGdnxalr1i2Q+0TuAGg7vrCbEt+9rSRdQsdR8b3f8WdGfnzHqCDp+2kgYlm43CRF5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 165.85.157.49) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=gehealthcare.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=gehealthcare.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gehealthcare.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lualVDQk+7lpcX1QnW0bNehJvoMHIbEXRCPhmw+9lew=; b=yjEKl5yoqijhQmg+gmKamHSD7zIX3QcItH1DeeytHIzJr6MckAD8aqwmTRxf58vuXA6AV4G0iCgw4uh4yM+d1Oz9ol6Ojh4x4xPnzK+VoQ8SMYX1tAsoLkFbrO8SrYBGAqCGGYh6bbWjKX2nhIx7jSX3eFmkvewFVNhw3lGPLrDtfrpGW748p5XIhf0kLGDNbvcqhvK73NKAMdRHwbpGhGTCoXcWSW3eIVnFN1vfgA+JTEJRvf/Gnjjk2hmhL/eV/bi1fNtkcRG2H0H3IlxX2mXQEJuM6jM6PitO72wtEEN/EVxt983TzB6dGPF8UjudiC+PTVLnlxxAUefOAVNeKw== Received: from CH0PR03CA0072.namprd03.prod.outlook.com (2603:10b6:610:cc::17) by LV8PR22MB5407.namprd22.prod.outlook.com (2603:10b6:408:22a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Tue, 14 Apr 2026 11:39:27 +0000 Received: from CH2PEPF00000144.namprd02.prod.outlook.com (2603:10b6:610:cc:cafe::b7) by CH0PR03CA0072.outlook.office365.com (2603:10b6:610:cc::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.48 via Frontend Transport; Tue, 14 Apr 2026 11:39:27 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 165.85.157.49) smtp.mailfrom=gehealthcare.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=gehealthcare.com; Received-SPF: Fail (protection.outlook.com: domain of gehealthcare.com does not designate 165.85.157.49 as permitted sender) receiver=protection.outlook.com; client-ip=165.85.157.49; helo=atlrelay1.compute.ge-healthcare.net; Received: from atlrelay1.compute.ge-healthcare.net (165.85.157.49) by CH2PEPF00000144.mail.protection.outlook.com (10.167.244.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17 via Frontend Transport; Tue, 14 Apr 2026 11:39:27 +0000 Received: from zoo11.fihel.lab.ge-healthcare.net (zoo11.fihel.lab.ge-healthcare.net [10.168.174.93]) by builder1.fihel.lab.ge-healthcare.net (Postfix) with ESMTP id 5E3A0131E4; Tue, 14 Apr 2026 14:39:25 +0300 (EEST) From: Brian Ruley To: Russell King Cc: will@kernel.org, catalin.marinas@arm.com, Brian Ruley , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm: fix race condition on PG_dcache_clean in __sync_icache_dcache() Date: Tue, 14 Apr 2026 14:39:18 +0300 Message-ID: <20260414113919.782-1-brian.ruley@gehealthcare.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000144:EE_|LV8PR22MB5407:EE_ X-MS-Office365-Filtering-Correlation-Id: 5db35a56-7584-49e9-5fe0-08de9a1a7c4d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700016|82310400026|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: RO+71nn5jK3FV3hh3MRHAOA0ButwgdRmAhdqyQJoUQh4TAh7zDVaGvohwtsA99iL0QNme2hOUlwbbufJOfKBPZGyE6bOwFbtN0cZCois7alC3JbpsAPN/v5p8+n7Q0n8l8V5kGw+Bt6xlZbOIAtLZIzUzrJBc4WglkL56Ba0aAgZhBHXuEDL21Ge0hNLJIpnSof28Hc2QREM+moGnP7TKaNFwMuZrLp1lMzOIHaWHtsAHfxduFFzPOGb8MNyvBADi3emSx1yDBn2NCLPfVvS3E9l3ugAh/I5q3lEAm7vv4mns+KjsG5cl4C/qZB+io8/Q1seH/I+Kmtyep5T2kM66qaTtmnPUbIk5jWj/GigZhJkkbJ8Q2lBy8FdPiABqdos7mrrcIFwNI58Py8eIhbUpVNWW1G4uSiBzHEI9GSgMqu2LIKjZ7K3CpGfPH8u6weh6mJtrfiJocl4UQeBeTuMqWhgCno79n0bM+XX1Eg7NeUegWhD/IpfyUa23yZDR9k/OI1ZRYQSVBXkNVw/Yv5jMB4uGWlkDo0JkQHPpM74DLfTlF4gmQv0OvWfZJMWbkIdq2u87egS84xAmHL2MIHmamCJme6GdnBJI2W8iL/fUAbNF3OwYTrRdKoSCqFJmP0m3L0aEcJ9QdA1wH/ylD1HWnZm8aGie3M/niEwlkvCRtpCmZirOv1aXPiWBMJj+Yi56PS0BQHR7wTBhrBclu9LVGHecwcma/ORRjSCb9/pxT5tO1WHASFAVayviMrBcLeRqWWZ2gEi8WOZ8LI+0QEa3w== X-Forefront-Antispam-Report: CIP:165.85.157.49;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:atlrelay1.compute.ge-healthcare.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700016)(82310400026)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: clcFIKcBta/oVYwa77ef0wWJ3Txe+I3Z3/huBKO3rV2n5HJYfwriRvVhaX3kEku0ZVmF/JrLoLw7dT3crhdomVGdHQgUZuT5KXTpu3B84+aEWB0hy6qCs4u+SeOwllAGvImnDZgNYsdZeGsCyDDSe/qoYds3oUH1cU5w0Jz04tt+vouiFqkJiCCuXJf0tRNE0/+1vFoDjq0QfW27IGeCHVRZUdw8wh1LGsqU9jw6pxHUVib86AWBTfAzhxmYGc0OyG60JK/D5eVwXuPAaCTUh94YuJJ1+n16wNqGjVNaW4UC4GUpUAXqZAiNrUPdy9K/FaCb+SsA/jht/UYpILB4Vmn80j0XXNrZcMIHCBDbux+fD3ppaeWnQ+ODQRdpUaoazQEny1wTstKX9cIvASA/pyY5GCpM+pajnguqhnVlfdYH9Wz0G7AK1HeK4e66Zu5h X-OriginatorOrg: gehealthcare.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2026 11:39:27.7333 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5db35a56-7584-49e9-5fe0-08de9a1a7c4d X-MS-Exchange-CrossTenant-Id: 9a309606-d6ec-4188-a28a-298812b4bbbf X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=9a309606-d6ec-4188-a28a-298812b4bbbf;Ip=[165.85.157.49];Helo=[atlrelay1.compute.ge-healthcare.net] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CH2PEPF00000144.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR22MB5407 Content-Type: text/plain; charset="utf-8" This bug was already discovered and fixed for arm64 in commit 588a513d3425 ("arm64: Fix race condition on PG_dcache_clean in __sync_icache_dcache()"). Verified with added instrumentation to track dcache flushes in a ring buffer, as shown by the (distilled) output: kernel: SIGILL at b6b80ac0 cpu 1 pid 32663 linux_pte=3D8eff659f hw_pte=3D8eff6e7e young=3D1 exec=3D1 kernel: dcache flush START cpu0 pfn=3D8eff6 ts=3D48629557020154 kernel: dcache flush SKIPPED cpu1 pfn=3D8eff6 ts=3D48629557020154 kernel: dcache flush FINISH cpu0 pfn=3D8eff6 ts=3D48629557036154 audisp-syslog: comm=3D"journalctl" exe=3D"/usr/bin/journalctl" sig=3D4 [.= ..] Discussions in the mailing list mentioned that arch/arm is also affected but the fix was never applied to it [1][2]. Apply the change now, since the race condition can cause sporadic SIGILL's and SEGV's especially while under high memory pressure. Link: https://lore.kernel.org/all/adzMOdySgMIePcue@willie-the-truck [1] Link: https://lore.kernel.org/all/20210514095001.13236-1-catalin.marinas@ar= m.com [2] Signed-off-by: Brian Ruley Reviewed-by: Will Deacon --- arch/arm/mm/flush.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mm/flush.c b/arch/arm/mm/flush.c index 19470d938b23..4d7ef5cc36b6 100644 --- a/arch/arm/mm/flush.c +++ b/arch/arm/mm/flush.c @@ -304,8 +304,10 @@ void __sync_icache_dcache(pte_t pteval) else mapping =3D NULL; =20 - if (!test_and_set_bit(PG_dcache_clean, &folio->flags.f)) + if (!test_bit(PG_dcache_clean, &folio->flags.f)) { __flush_dcache_folio(mapping, folio); + set_bit(PG_dcache_clean, &folio->flags.f); + } =20 if (pte_exec(pteval)) __flush_icache_all(); --=20 2.47.3