From nobody Sat Jun 20 14:12:41 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C789E19DF6A for ; Tue, 14 Apr 2026 10:38:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776163118; cv=none; b=T49KgvVxJh4d98hf3J50bvh/JCI5Gc8DyiYHLgPdSbPcfLAk0qeemz2ak+vaEwcbQ4XmU/YQ5MPUp//rYax2ejBS0shZ5//mVfV7+KqiOA82woFhcak2YxzQcaYTmHC7CVexrybbYHi+ofjjf09HQ2mrJgDwsixW4QOin/Grb3Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776163118; c=relaxed/simple; bh=FBG469TLXvpWlGEioFdFWVwzauHrAXQ8pqMZFjLRj78=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=swxu8P4JqGRIdJUwmTpdxvwqLk6VSqZ0yAEZiwZaHjXxF1h/FGf6UkQN+M2qxPG8wQbofvGXMo0KFppCz1WW5jWtNBeWizsAPvGcq4lepJdeU0ehUSeDa2FcgKjZkaCtafXhiE0NCoobMJqbedZy9z2bqCuo86ePjZvG+3tnVCU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r4R5/tqb; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r4R5/tqb" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43d01d6b50cso5514200f8f.1 for ; Tue, 14 Apr 2026 03:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776163110; x=1776767910; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/JQelBlxLiHpG/8eD2AusHYxLA7U3BNLmOfB4Xptskg=; b=r4R5/tqbejTg3pBZ7sxcS6Yt4kblfRnVj7+gxVP+HeMjKUOIRuN+bzHfzb/L3ySGuQ a1r+vRai/EyFnFhnBoAV9VdtsiRxKbFkUTtX7CRfV+aky5qFXrHW/lln8Qezdj6OhttR E88WFd6cCefMNFkoeQ4Pa2Afyn9rPIsNSUMbFFvvVBdSfhBa9AT2nclUbheYeJZn/4Lr tfy3sJBjl5TwGnhr3ja0kvXnLki9W2oRnOaigcma/R3d2qoTpWYSRwi+85uEZNAI3fn1 t7tl6L5jwu6XHG6gwLYVg+zdSujcPFMQiC53oHTS1rBAAPY1Fnb/uJqZmJ2wQxD/gD6n D+SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776163110; x=1776767910; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/JQelBlxLiHpG/8eD2AusHYxLA7U3BNLmOfB4Xptskg=; b=KD6Ti3Fo1RVCsujMm5HKNPI9PY7A5I8XI4OuLi0rGYTr3nQ8SOG4/w6JmSrxJv8cX1 hhzpQ/m4tzA+TBNAJ3f4Oshi/44firLOf/MpNxwc3urS9GPltJvxujjN+eTlasutTrYN biTmC1aegOJA9MWroH0A/wdchNV5KBu0NUKYTI956sSfGDE0YEPB9Tycw0e6Tt9snG+m +qAcZNdHtVo1C7pkD+9N/yg3inypy7RkSZZKQK0okocO9PhG+IQT6bRD3hIKMUkLLWXZ dJob5sv0yiOmHZXPBf5Hfu0eycZ7Jm38fDuZQTO31wDZ11pCqs6gr1UCOrZbiAtbayBE Zvbw== X-Forwarded-Encrypted: i=1; AFNElJ/aJQ8WHmA/NihKTSB4MfPZTiRIvw/p9efZq4qMpAvH8ZvxxgRrKAO87NVBNIIfQAGe+sGOjLT2gi9wvMo=@vger.kernel.org X-Gm-Message-State: AOJu0YwP3csTx5Aw/A/jCJeB/ID9MUFTyJS7oRsZ/9nnHd22Rn/340x1 RKdIZMDOh5fuNzwKLvDfvRzqPXg28axNtPRhj5hBk7vLIKRm6R+Jzn4k X-Gm-Gg: AeBDievGIU6la8pyog3PWDGS7/DchY6YqXXxJVgcHaOFLeUAt2lhCgrKOmw3lfvEeVZ xuoT9qvWJwV/shzswNcPj26HovhAut+KFATyVfTAtufQYKRc+mEM/eIQ4uG2zl3AoNSDBjbA/P1 WnDHWE3znlc9T/g0EJ4t+NcuOL1tZehP4U2MiEHtMAVCiUUWKKL3C2FswUwR4QT9CVbfXCXdvAV jKXqh1WXo6e9Yhf6ZSARKv9TBM2Zs4o1Pm2G3FcO9tooGwsHel/B9R2dQeipQzDmWogvPDQIr4w /oHuLnVM5Sekr/5fR7TppPqRqodzHLB4SHKtpTaWNzyBXEO5UPvO3Qp6RQoAuJeNGmPP80WVmlH Bg3kkCEDRLIMrIZ73ocwczppQ6RTq/0PkKcHNPxfZfaIJn5t4VIPg2CPDRdNjQ5UiubTdqhm4G7 7O+XgVStkYs/QeOYPzLes0mqw= X-Received: by 2002:a05:6000:1786:b0:43d:7722:ec05 with SMTP id ffacd0b85a97d-43d7722f1bdmr12815864f8f.8.1776163110093; Tue, 14 Apr 2026 03:38:30 -0700 (PDT) Received: from yocto.. ([2a02:3037:60a:6445:7190:8290:c993:38ad]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e5c981sm41725769f8f.33.2026.04.14.03.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 03:38:29 -0700 (PDT) From: Abd-Alrhman Masalkhi To: song@kernel.org, yukuai@fnnas.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Abd-Alrhman Masalkhi Subject: [PATCH] md: factor out cloned bio cleanup into md_free_bio() Date: Tue, 14 Apr 2026 12:38:13 +0200 Message-ID: <20260414103813.307601-1-abd.masalkhi@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Refactor duplicated cloned bio completion and cleanup logic into a new helper, md_free_bio(). md_end_clone_io() and md_free_cloned_bio() previously shared nearly identical teardown code, differing only in whether the original bio=E2=80=99s endio callback was invoked. Introduce a boolean parameter orig_endio to control this behavior and consolidate the logic. Signed-off-by: Abd-Alrhman Masalkhi --- drivers/md/md.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index ac71640ff3a8..707d605fee61 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -9208,7 +9208,7 @@ static void md_bitmap_end(struct mddev *mddev, struct= md_io_clone *md_io_clone) fn(mddev, md_io_clone->offset, md_io_clone->sectors); } =20 -static void md_end_clone_io(struct bio *bio) +static void md_free_bio(struct bio *bio, bool orig_endio) { struct md_io_clone *md_io_clone =3D bio->bi_private; struct bio *orig_bio =3D md_io_clone->orig_bio; @@ -9224,10 +9224,16 @@ static void md_end_clone_io(struct bio *bio) bio_end_io_acct(orig_bio, md_io_clone->start_time); =20 bio_put(bio); - bio_endio(orig_bio); + if (orig_endio) + bio_endio(orig_bio); percpu_ref_put(&mddev->active_io); } =20 +static void md_end_clone_io(struct bio *bio) +{ + md_free_bio(bio, true); +} + static void md_clone_bio(struct mddev *mddev, struct bio **bio) { struct block_device *bdev =3D (*bio)->bi_bdev; @@ -9262,21 +9268,7 @@ EXPORT_SYMBOL_GPL(md_account_bio); =20 void md_free_cloned_bio(struct bio *bio) { - struct md_io_clone *md_io_clone =3D bio->bi_private; - struct bio *orig_bio =3D md_io_clone->orig_bio; - struct mddev *mddev =3D md_io_clone->mddev; - - if (bio_data_dir(orig_bio) =3D=3D WRITE && md_bitmap_enabled(mddev, false= )) - md_bitmap_end(mddev, md_io_clone); - - if (bio->bi_status && !orig_bio->bi_status) - orig_bio->bi_status =3D bio->bi_status; - - if (md_io_clone->start_time) - bio_end_io_acct(orig_bio, md_io_clone->start_time); - - bio_put(bio); - percpu_ref_put(&mddev->active_io); + md_free_bio(bio, false); } EXPORT_SYMBOL_GPL(md_free_cloned_bio); =20 --=20 2.43.0