From nobody Sat Jun 20 14:13:59 2026 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B0754726 for ; Tue, 14 Apr 2026 10:09:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776161376; cv=none; b=JsxSlrfpnUHC+Pf1CvJxUAdwqQ361GPNDDeVth3OxhA9xU3tajLJ+wZ14LR7FRTLjyzDgIsBQnrt+NQnIbg31L+QNdth5rICUDGM3zjqB84ZrmBMJDwYxp6/FGA3EHhvV2ZxDh1A1Ab0j8QYm8yAdhqjdZYGG/as4BDxcDYLi+4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776161376; c=relaxed/simple; bh=UVuQEQwO9ZjOxcyAo++XxY7tWYlDW2Ukg5Q5WnLhjsc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U/izHQqx0PPGw1ILq7sD6H3sRLGjI9AijnyMs8NNuD90KzliiD6Znjx9NA08y1P694HC8xwg8e3g9l7I1sRl8hUD8Uh7XaR+v8lKEjDPALCItTIyqLTKZPNDAXjLP/cIs1pRAvJysE+1cnpCq4L7fWq3iTkDQVXWXgJW9V9sTj4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KV9CgUmD; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KV9CgUmD" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b9c62fc8debso835567466b.0 for ; Tue, 14 Apr 2026 03:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776161374; x=1776766174; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YM29ecLh9a+Div79GBVrni0H0EBRd49ZucMDpXYMiyQ=; b=KV9CgUmDzK54IoncnN9j8xQ6+bHKk4PktW9r40rrV6ujAI9uDkdw9RtktaMKhk/M3T EjLmYge66cSyIpTnvIz3lEtBKbN1j4ka4OWW9gb49njVhHT6XFCMCMIrAdSCYF3ljSa6 7fvdbjOmKeEUXxo6FOIjmzFvQ8N4EVJhWDrnCo6MStKp91lmRA0mIyv4fxyfG5KfVu2X FTodOTOhMkXjk4+EGhMOZ9mOsg9Mkav1EbOhwSTOmqdEKDXP22tp+uGi6BF/aJePIqmK sbXwqthcUmCHbxL3F6ii3n/JMLNESE3KlI1NWAik7KPWY/zNJ5amPVgKW82FvVv6l/Vb k/fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776161374; x=1776766174; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YM29ecLh9a+Div79GBVrni0H0EBRd49ZucMDpXYMiyQ=; b=VgITmtShIlpC65GyKR1/n3GzfyOxbqfq3zq1S/0LgmjEUY0y/tvG1YkZ4IW4jBBI4d VJbFyFwkJK1ONja59PL1jWkZ/CfDAyOpwM3x5pD86OlGdahBic7HR0wq2qobdy7zVlIX ATGX9scchfbn/dV9nTo+/ZvPUxarRkhsxN6ATshr1zO/0yuRhEEI3txb3qjOMmmueP5o VnuEpUfvSlv+eKBbQP9IqRuhKZyAyFihb0npRCJbwuuDFzzDifX/G/Ng+a3eL2ZCmWpz E6uKbuHTHKJC0QTa/feQ3znoNNGsURgv6gIOhwbUKHi4qfrv7iGxJ1oUCzIhnLRIGYzC 4E/A== X-Forwarded-Encrypted: i=1; AFNElJ/YxcJAxfMuW7s+sOONkhnhoervZE1+rHQ8G/+NEoGEajr9w0uv+8hncrDyrP2Cz9Zek7gnaszYqD8HU7s=@vger.kernel.org X-Gm-Message-State: AOJu0YwBW1qplHglXBUfOIGd8cEfQb98bAJjqXCY0PM+8D0pjpbcik2Q PVB+BTqPRt5xykDez0lQHrx/WnyRKEI2zaqVbSxnwJxQhv3YXiyqdurJ X-Gm-Gg: AeBDieu4i1ELgK3XckV+feq9pnLINTrimPlQaxLUCnNj5669a+eZ1iBzBANikQ7eHmv Eekbuhutxvmjm93vY2e1iXtwSirt6m3ni/NKSGqk2a/OBP3fJzsQQoBJ30Qv5CBU7htmhDPPOVs O8NsAUOjMv7/ow0KIWcF4lrChNToEFd1LalTcA5S52hOZZidE6AEs7fWAhRj9ffICdoMyDHCuH/ cENbBqz5QGz/MtAlx52dx6M/Sl0/CYFo43vGzY72deMcFO2fW2XDXLVFZj9oJ+wpsnZGLEpNnTL K1JAFYWxIM898nGNhsrh+A2uDRYG/TUjmOWKliq+4TeBjuaFvD3X5KrzRl2e/z5uSEKPE4h5H+Z WOzqrOkFZjimz+HHEE7r/0EgGI2c8eG0MScbTIZ25Ktajnt043eg246hIwTsuomNubk8C7W8NkJ S3kaWDQRGuY5JKKs0Gqsm/El2R8iwDZt5pweDTnc0J10tdiTI8pE2IbhMc6V2Lm+kFrx0q1Ew33 RIjRrsskQiXW+BoVnhbOnTxl4DCjx2sbwL17RP3LKfGvKdF1btVn1szAXkaKtAyo0ep X-Received: by 2002:a17:907:1582:b0:b98:32c1:2496 with SMTP id a640c23a62f3a-b9d727a0736mr667489266b.18.1776161373534; Tue, 14 Apr 2026 03:09:33 -0700 (PDT) Received: from ahossu.byod.tudelft.net ([145.94.221.163]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e7c8a4fsm375261766b.54.2026.04.14.03.09.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 03:09:33 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, hansg@kernel.org, stable@vger.kernel.org, hossu.alexandru@gmail.com, Dan Carpenter Subject: [PATCH] staging: rtl8723bs: fix frame length underflow in OnAuthClient Date: Tue, 14 Apr 2026 12:08:04 +0200 Message-ID: <20260414100804.871764-1-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413202824.740653-1-hossu.alexandru@gmail.com> References: <20260413202824.740653-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If pkt_len is less than WLAN_HDR_A3_LEN + offset + 6, the reads of the seq and status fields go beyond the frame buffer. Additionally, when pkt_len < WLAN_HDR_A3_LEN + _AUTH_IE_OFFSET_ (30 bytes), the subtraction passed to rtw_get_ie() wraps around since pkt_len is unsigned, causing rtw_get_ie() to scan well past the end of the buffer. Add a minimum length check after computing offset to reject frames that are too short before any fixed field access. Reported-by: Dan Carpenter Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Alexandru Hossu --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 90f27665667a..6b0ac54ad3d4 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -869,6 +869,9 @@ unsigned int OnAuthClient(struct adapter *padapter, uni= on recv_frame *precv_fram =20 offset =3D (GetPrivacy(pframe)) ? 4 : 0; =20 + if (pkt_len < WLAN_HDR_A3_LEN + offset + 6) + goto authclnt_fail; + seq =3D le16_to_cpu(*(__le16 *)((SIZE_PTR)pframe + WLAN_HDR_A3_LEN + offs= et + 2)); status =3D le16_to_cpu(*(__le16 *)((SIZE_PTR)pframe + WLAN_HDR_A3_LEN + o= ffset + 4)); =20 --=20 2.53.0