From nobody Mon Jun 15 22:00:47 2026 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F298E3BAD89 for ; Tue, 14 Apr 2026 09:58:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160738; cv=none; b=UYYYbw/UcLdBR0S3/T73wGyzhotFDdqAq0ERLRvGUGtwkHjfHHj7FzJLl0IhaSlB/zywe/q3YdI1bNSKgpOyqNoo4tiIDeZO5kr3KHmTPEWkDi4PhhCvACYUAGFS8p7BZyUQm348aDvDD2wP7Lulx1T+/QaJ/k0cULEUXlgxZ9c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160738; c=relaxed/simple; bh=hcaz3A9RHlDsjenZt0zbaVKRizleVxwBHTORYZTOt9s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MGWuiIva8kgFpEjILe42inMp0uRxuuMiC32OkrVZP1Ce2ViLGeIR5Xf+eWk+RpSVjnrQQ4ULWesQpqm+7qjRjGBZ/7dCifePR/nwj+p/t0mDdIBSwJaXcp7jyi56bRZZSBtOn7lznDQzWkKmfxANZgad0B79q68VbIL5kCqPiac= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YhPINy8F; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YhPINy8F" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5a2b636b944so6077257e87.1 for ; Tue, 14 Apr 2026 02:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776160735; x=1776765535; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w5/UB9Y4Wl8LhWvikIPz2mCrzIXaU2jp7kDUouEUEmw=; b=YhPINy8F8Xt+eyiO/oFGcbX07XKdzuwyTRc8WKPOnvoluYrJcuqQMAcOLTZUiWYh/U TeE7x3wA217c7aFSKOHR1VHtk8Xd/M+nxKW/bQS0kUcAnL1rsSBHvEsmecJwtL2WDuIu mAsm8JaNFbW0AhkhLFNnfDve5S8rxzasLpsWOZ1/Bt8qQYBpsLAaGdplicwd3/p2K8pO ePVbflGdFZd5GAry+AnJIZ4IU3MlatBfveMVaY4zqC3RrSd2t+3YiyWoWiDMjIPHh7y4 8JdaRKVQRBf0yIiO/QS//d4S0L4Q8wGjwp9vle+G3R117YyzZi4h2ja+kSoj73Qwa62T /FfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776160735; x=1776765535; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=w5/UB9Y4Wl8LhWvikIPz2mCrzIXaU2jp7kDUouEUEmw=; b=Z5ZFmyBDHw+V1Cht/21yHOxDHlba/SJoCTdLRk+f0BWIdTQ2wOfEsa84BennYqL4FV AsN2BNtssqXyQjLgiEUad6DFaYEf/yP3NmJRDbET4x193d0S6a1+sHCv+Oa4D9+UGrNK aLsPq4w5xvEzzpUp6hRh4Q2rJg0NukveNhF4KfC+mfX/bQuNBomZUVY7meb/r8/5DNU8 edn3oILJIUFVAvbKJJxVBBi7eY5xIprJ1qzPxUzfqGsvXhqsJCFOotwad3YUNBgqvWnj UaKPBuSjny25kQBBxxIfsu1/JKyO6+5EefsUOn2vDJYQO0oi9Z9BaenMhuhw9dUJvXji 9ang== X-Forwarded-Encrypted: i=1; AFNElJ+q6cJ2TEdd09k1i45xTzMIQJroAzHVU9qs/OtSiW/G2bOMnR6VsVPRfPl1t/nyvdM3EP1CNTNUNjHnqR8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywsys3VeaKrp2GGQ/juOampF2JWHjyU+G1xeKKPk8Apgnkpl/LI wY++EQ8bd96iExVxLMNYgeOTWErzF7Q4uAtugy0AaVwgfTJjkMr9Fy1M X-Gm-Gg: AeBDiesvW/PYz8bTzXTkZmI5fRuNCa1NChqgSqIVYdfdgIZHohbO8GqE/JH9/GL6MPD g9aq5dc85++DpxAxZ9IdRJO0JYoeHk12YQVpvs4T9dZdt/QFHAUCvQNthwUPNaWf+wReX5Q+Raf GeurjmS6x/Ue4Kx9afJTEZIc9aca/TPzQNYlIVf9TCGrY9wHEn8ye8ES8lPjoQjXnX8vgkIii2I B/OrEhspK3oXNdCUdL4Tx++zv/ut4kKgOP6b5oCm/kEYyqeW9GPSgSsOixdc9LfLe8NSZGCLCzV BDBNXWLPYq2HdD5l7AZ1jhIUuVapflxRf1eiSvGmk5vFfVm1zY6tpTQMwYCprrkBKuEs53GQl2l UWlYor/ZJzmaIVuvRXyr0zZY5HuN3+an6h2z8tcpC2QAqJEOxP68nmhI9GcuCZ0a7im8ehtft0v S/kkdXBqNKvsCxjjHnmNrb6+b9 X-Received: by 2002:a05:6512:63c6:20b0:5a3:fe3c:65b7 with SMTP id 2adb3069b0e04-5a3fe3c670fmr1609972e87.44.1776160734970; Tue, 14 Apr 2026 02:58:54 -0700 (PDT) Received: from arbuzik ([213.79.119.79]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a3eef071cbsm3208359e87.80.2026.04.14.02.58.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:58:54 -0700 (PDT) From: Marc Finkelbaum To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , Ethan Tidmore , Andy Shevchenko , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marc Finkelbaum Subject: [PATCH 1/9] staging: rtl8723bs: remove extra blank lines Date: Tue, 14 Apr 2026 12:58:25 +0300 Message-ID: <20260414095833.76480-2-regpacy@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260414095833.76480-1-regpacy@gmail.com> References: <20260414095833.76480-1-regpacy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove double blank lines between function definitions and between a function end and the following macro definition. Also remove spurious blank lines at the start of an if/else body and trailing blank lines before a closing brace in _TwoOutPipeMapping, _ThreeOutPipeMapping, Hal_MappingOutPipe, and the HalSetBrateCfg rate loop. No functional change. Signed-off-by: Marc Finkelbaum --- drivers/staging/rtl8723bs/hal/hal_com.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 31b3e880ae6a..0c3e983a1b2c 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -30,7 +30,6 @@ void rtw_hal_data_deinit(struct adapter *padapter) } } =20 - void dump_chip_info(struct hal_version ChipVersion) { char buf[128]; @@ -71,7 +70,6 @@ void dump_chip_info(struct hal_version ChipVersion) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "RomVer(%d)\n", ChipVers= ion.ROMVer); } =20 - #define EEPROM_CHANNEL_PLAN_BY_HW_MASK 0x80 =20 /* @@ -294,7 +292,6 @@ void HalSetBrateCfg(struct adapter *Adapter, u8 *mBrate= sOS, u16 *pBrateCfg) u8 i, is_brate, brate; =20 for (i =3D 0; i < NDIS_802_11_LENGTH_RATES_EX; i++) { - is_brate =3D mBratesOS[i] & IEEE80211_BASIC_RATE_MASK; brate =3D mBratesOS[i] & 0x7f; =20 @@ -361,7 +358,6 @@ static void _TwoOutPipeMapping(struct adapter *padapter= , bool bWIFICfg) struct dvobj_priv *pdvobjpriv =3D adapter_to_dvobj(padapter); =20 if (bWIFICfg) { /* WMM */ - /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ /* 0, 1, 0, 1, 0, 0, 0, 0, 0 }; */ /* 0:ep_0 num, 1:ep_1 num */ @@ -377,8 +373,6 @@ static void _TwoOutPipeMapping(struct adapter *padapter= , bool bWIFICfg) pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0];/* TXCMD */ =20 } else { /* typical setting */ - - /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ /* 1, 1, 0, 0, 0, 0, 0, 0, 0 }; */ /* 0:ep_0 num, 1:ep_1 num */ @@ -394,7 +388,6 @@ static void _TwoOutPipeMapping(struct adapter *padapter= , bool bWIFICfg) pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0];/* TXCMD */ =20 } - } =20 static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg) @@ -402,7 +395,6 @@ static void _ThreeOutPipeMapping(struct adapter *padapt= er, bool bWIFICfg) struct dvobj_priv *pdvobjpriv =3D adapter_to_dvobj(padapter); =20 if (bWIFICfg) { /* for WMM */ - /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ /* 1, 2, 1, 0, 0, 0, 0, 0, 0 }; */ /* 0:H, 1:N, 2:L */ @@ -418,8 +410,6 @@ static void _ThreeOutPipeMapping(struct adapter *padapt= er, bool bWIFICfg) pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0];/* TXCMD */ =20 } else { /* typical setting */ - - /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ /* 2, 2, 1, 0, 0, 0, 0, 0, 0 }; */ /* 0:H, 1:N, 2:L */ @@ -434,7 +424,6 @@ static void _ThreeOutPipeMapping(struct adapter *padapt= er, bool bWIFICfg) pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0];/* HIGH */ pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0];/* TXCMD */ } - } =20 bool Hal_MappingOutPipe(struct adapter *padapter, u8 NumOutPipe) @@ -462,7 +451,6 @@ bool Hal_MappingOutPipe(struct adapter *padapter, u8 Nu= mOutPipe) } =20 return result; - } =20 void hal_init_macaddr(struct adapter *adapter) @@ -749,7 +737,6 @@ void SetHalODMVar( } } =20 - bool eqNByte(u8 *str1, u8 *str2, u32 num) { if (num =3D=3D 0) --=20 2.53.0 From nobody Mon Jun 15 22:00:47 2026 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 992343C7DF1 for ; Tue, 14 Apr 2026 09:58:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160739; cv=none; b=MloKC5bCWNh5FAhF1qC4A77gLCHq/FD+2vpXBeLVu8WdxETFzBrBA+4zKX85bt0sTi0nsW0sHiIgcMoQGQSUfVYTUutAN6q4hFQmka9S6h2mGAJWzapK0VV5aJWIhiljX5LzBmSpjcEhBbsrLw+L0F7NaMcyE5PLZgpKtWmwO3w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160739; c=relaxed/simple; bh=pxMSSpzTLO5UeiUp8CLwwrcEVNmCEQ/Ow0zOH+bQHBw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LCM+Pe2XJG1U9auBTzCORZD6idSc4ceVFW5lH/hhEQdoFfhbw4vQMLKJwMnFWMIIV5s9E2kRNi5LqUoy6e8d4FDtpU3ULFfnTKxON0DOAoUB/ibGdhmtD6CT4L18+WY5KMTdUVGAUF9WzP1yzjgpR6Sce9FKJLVxZ5EQHEmjg2Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CN6/3fJJ; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CN6/3fJJ" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5a0ff30b240so7369461e87.0 for ; Tue, 14 Apr 2026 02:58:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776160736; x=1776765536; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4j64YQz7u7NwJcOeHpnDvtT07H4d1QhdIc8T2tCMk3A=; b=CN6/3fJJvSZEd94V+n5keICO9w7wRIp+i4figb2VYknIIFLgZ215dIX8MOW17X/HnS lDe04dHKPDZqLNrGbDzjeJUW7JaZjgrypKhd0r66OpJLBR/CBOMRVnME4bWkv5FFbXXr uYnCvQfx74M3OelzYiC6+09ZX7f0Kc78HaMmeTZtufOMnlRfJQdPUXpoC+ysufevCqRc QYfDTVW2r4xP3Quqw9CsDSIX+LEhIgRn/kaKD1VM+1/Y7oSQE1Px5YvBiZCQZInJFzKv qM/lMc3iIFm0L4/6a2QFQTBxCFEOx4jDGkTFceYHgAE1hLjOOIwep3waqJj2qJidvSKH u5sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776160736; x=1776765536; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4j64YQz7u7NwJcOeHpnDvtT07H4d1QhdIc8T2tCMk3A=; b=ka0Me5BIlWwU5GHcJ+ddZFGQ4j7DBeFyHTehKd+DC48QNOX38wfHeTCbKEvMBsI4kj 000C7+sQNXHB5aULdGSQl4gUyxiXhCEwntuLbA0GdGXHX/ZBXnyeNavb5Hmu56NZn5bQ OPxmRkc0h+Eo/1Xk/nJ+EGmazj6Nu90csOeWL4GMNgGKaysVfngyw02rIJGwpnpcGWCi DLOlboW/rXE+y8oXzhUHbYy4s/0VxSLmGTH5D/jeDE3qcHaw7SwSgwgZ++XTiSGqH8Aj pRsZG2gk6jPXieX7EEaMJ2twaRHzgMRQE4OhvPbtHcctZbWcYx6bIYn7kj8xG2imjFrL 5uPQ== X-Forwarded-Encrypted: i=1; AFNElJ+2W3/dUQ1J8SgYNwHRnlKcE827d3pCvhWkqpdX40E5ceMluh60yPpXIx8poSsWt7oLW22TaOAUa+hB2G0=@vger.kernel.org X-Gm-Message-State: AOJu0YyVFa+L1jqoYGMlogZEcAg75ur8mC6mq8XAR9vpodSSiDIaNdJ9 Xf/2lQQhPwZmu0Pm1DXKbwChrDV3h6XO+z7enGiZJ5rIf5o7opE1C5ud X-Gm-Gg: AeBDiesUMLUQQWY3lxgSV6cYwbpjV4waT8nvfcxmUWT8LmZDrmNOx8SVlVZZ9Y1Flwl SyKrDkxtdxl4l85dhGqSKMTtaTXaRd1YojAc0LXhkWRvW/M3do2qnYoOGUNRjO8D6n0/C1+wdhc yR8QkRjaFLLSiYo7SsZ6aQ0BelnMLoiPtWytoBvjqOJZAo7ufXa0PUNezqqE12OTI1gpF7iXxLu 7AG1RLpXBLpObq6u80LnU9WaPvt4BB8xrfLo5gZAuOZOYDTvIdG5jkRUx7foYf39y4sU21ikSQl WrVJfdr45hrO/MGvQowhRnwSDOmSLh19ylPsIAoWgVX0IwH64yhsImLoiXfL/KaiaISEJNHfW6J MtYf5S2OBoL5BN1rY+7MxO7KDOKI7CTl1JvoqCrUjvhGnEhOPKEmbwDa1DqmGRAFX0DTCLBtNcu OLNagWq1gwe1MA7w== X-Received: by 2002:a05:6512:2243:b0:5a2:9bef:52bf with SMTP id 2adb3069b0e04-5a3ef7007ddmr4819848e87.2.1776160735710; Tue, 14 Apr 2026 02:58:55 -0700 (PDT) Received: from arbuzik ([213.79.119.79]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a3eef071cbsm3208359e87.80.2026.04.14.02.58.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:58:55 -0700 (PDT) From: Marc Finkelbaum To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , Ethan Tidmore , Andy Shevchenko , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marc Finkelbaum Subject: [PATCH 2/9] staging: rtl8723bs: fix space-before-tab whitespace Date: Tue, 14 Apr 2026 12:58:26 +0300 Message-ID: <20260414095833.76480-3-regpacy@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260414095833.76480-1-regpacy@gmail.com> References: <20260414095833.76480-1-regpacy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace tab characters with a single space in macro definitions (EEPROM_CHANNEL_PLAN_BY_HW_MASK, REG_RF_BB_GAIN_OFFSET), the dump_chip_info parameter list, the pHalData pointer declaration in SetHalODMVar, and the BK/BE/VI/VO tabular comments inside _TwoOutPipeMapping and _ThreeOutPipeMapping. No functional change. Signed-off-by: Marc Finkelbaum --- drivers/staging/rtl8723bs/hal/hal_com.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 0c3e983a1b2c..07e4da49d757 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -30,7 +30,7 @@ void rtw_hal_data_deinit(struct adapter *padapter) } } =20 -void dump_chip_info(struct hal_version ChipVersion) +void dump_chip_info(struct hal_version ChipVersion) { char buf[128]; size_t cnt =3D 0; @@ -70,7 +70,7 @@ void dump_chip_info(struct hal_version ChipVersion) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "RomVer(%d)\n", ChipVers= ion.ROMVer); } =20 -#define EEPROM_CHANNEL_PLAN_BY_HW_MASK 0x80 +#define EEPROM_CHANNEL_PLAN_BY_HW_MASK 0x80 =20 /* * Description: @@ -358,7 +358,7 @@ static void _TwoOutPipeMapping(struct adapter *padapter= , bool bWIFICfg) struct dvobj_priv *pdvobjpriv =3D adapter_to_dvobj(padapter); =20 if (bWIFICfg) { /* WMM */ - /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ + /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ /* 0, 1, 0, 1, 0, 0, 0, 0, 0 }; */ /* 0:ep_0 num, 1:ep_1 num */ =20 @@ -395,7 +395,7 @@ static void _ThreeOutPipeMapping(struct adapter *padapt= er, bool bWIFICfg) struct dvobj_priv *pdvobjpriv =3D adapter_to_dvobj(padapter); =20 if (bWIFICfg) { /* for WMM */ - /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ + /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ /* 1, 2, 1, 0, 0, 0, 0, 0, 0 }; */ /* 0:H, 1:N, 2:L */ =20 @@ -410,7 +410,7 @@ static void _ThreeOutPipeMapping(struct adapter *padapt= er, bool bWIFICfg) pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0];/* TXCMD */ =20 } else { /* typical setting */ - /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ + /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ /* 2, 2, 1, 0, 0, 0, 0, 0, 0 }; */ /* 0:H, 1:N, 2:L */ =20 @@ -708,7 +708,7 @@ void SetHalODMVar( bool bSet ) { - struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); + struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); struct dm_odm_t *podmpriv =3D &pHalData->odmpriv; /* _irqL irqL; */ switch (eVariable) { @@ -786,7 +786,7 @@ static u32 Array_kfreemap[] =3D { 0xfc, 0x0, }; =20 -#define REG_RF_BB_GAIN_OFFSET 0x7f +#define REG_RF_BB_GAIN_OFFSET 0x7f //#define RF_GAIN_OFFSET_MASK 0xfffff =20 void rtw_bb_rf_gain_offset(struct adapter *padapter) --=20 2.53.0 From nobody Mon Jun 15 22:00:47 2026 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A71023CB2F1 for ; Tue, 14 Apr 2026 09:58:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160740; cv=none; b=AWSUJRSBgu5oggPCPrW0XSpzAoMk9BCVdzIFtkCwi9IMDrRRkXPhT5EORcpgcoevaesiX4pCXVQp5xj4KCi/R2H9qfAFH4efT5Z+e00NiC1zNe3a8CJpMo2IGAvVYPdeoI9Ggot+Rkamq7t1qlP3RsshHqwgu5BVUgZEWgNYk1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160740; c=relaxed/simple; bh=gwxzik5q92+YJGCAF+mUsxbR9fcv6IwBv9/eAbKIU7k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m7Nvfm+nh6WVfVY6iozJubaXPbG+HiwZM4x6AdJcOcDYrWydzkG6vm7qUVFXT7pQdOZl4b+ofKeaFs2WNZly6SRSX5Psq6v76ceZwhBzb7JLvaaWTup1fRZDVYZU3W8yRiMe6izBYnwOsnBwrPdv7ho583F+1+JbraLVrbBZtyY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e/d1doqG; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e/d1doqG" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-59de8155501so5914298e87.3 for ; Tue, 14 Apr 2026 02:58:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776160737; x=1776765537; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=shlfFrpNOrscj1KlCl4wQyL5KbFoUXtyOhECIHR0RH0=; b=e/d1doqGQCQQCvlmMzUcLVjBu37Mo2ubYjpFJJFuG2NyzTMvXfwtBsX6BpYp6tAMgH 02ixqcY0oYvgVZ3zDxfYZLrr5u/lwuDAiX3gc6mEHzKsjjXDEkQUDahtjvcq/VpSZBvd asOz3zVm9eNjqvKaotSaD6KW9ZbXp9kp5hs+SVOh4k6bylXXfbnmCm5PW+No0N1j1OED PdotJ4/oJ82Myqbiua1CK72zG5z30O9WTKbH6UvvKyVhVtHjObUBxj9tilWIiBkJByJ+ KO/KAVZ7jkksWLCU9Onf9R+CmddYIhBnPcEDYFkOp6MYHmf/YFvSTO0WbKPmUDXGCAD+ RyBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776160737; x=1776765537; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=shlfFrpNOrscj1KlCl4wQyL5KbFoUXtyOhECIHR0RH0=; b=cclLVqIP9X8mcACNG+1EwR8KWg4qEJMB5fF3rP4VYU/ScXrWNPNq4Sn7jZupKgj7sr NNop3z+ymmSqvm16/dQ5aHLbe1wGqqY4mmMM3EEsFysMowyQAm0rr1e2WYKB/1D7Ehn0 yF/ezv9IAIuzhRXrUN1N8LDXMkrjVYtg74gcUGE9t5XtglULknk2D7nW+8jn24R2pl4u w0QCMz31cdTE/JlUAHprZ7sEloyUATUzTw+1PLYwWOplZkjwFiCJ3AD4jk3G4q1LyWjO tf9xB95kq1QGVWRRB4VFYUotOE5I+IE/TTUU3QTV5iWk2nhCNCmjXAryIMNYSQK1Yf9c YsDQ== X-Forwarded-Encrypted: i=1; AFNElJ/Tea+fMx5ifD8wKIgGQGvsLdTrdLJr57CqVvMwn1KdIY5Mi8a5J25JEKcoPSNogeP3q9fPioqsUVypQAA=@vger.kernel.org X-Gm-Message-State: AOJu0YySFTws7zz0B7pkB+gw4UDdSJ20c9HFOe2DGw2Pc/+25R8R18rz n2hAziD3XwJa7Q2F05AoyKkrcnZ8ZnexCebaZrj/nyMy1cw1CZYryA/X X-Gm-Gg: AeBDieuKg6Jj+MhY9kUHp2Jjc/vOGXisxA/M+qtKTGaKhp8w/gbZOyibqhoZTJSMADo ARXa9PR1QOV4ecBgVmhplvV3cQNj63bjEGi2iYnKA535TqNjPTtA0ve5L+f1YtM+Ca7GeH/K4YT BY/tT5CHZ+WIVvrIo5sRP1nL77VMg/f53ZvYSGOq4i7jUfnZlJIKbiDciJKwex9dUsOjLQ/77TZ UqTc8i/Q3dClDVJ/gICd+xWXc4O9EFSw+Y4zCDT3M5mYMjNwXDSNtsC6CKosEdIPS0Ccfn9yFhC RnSsICZ4Cy3i5AO+DFic8+kt5L1e1qu3J7Q5p399JIOAkRjZDunHL2boeVKLDs18wKJpsBDnXk8 6257eo61dKDwbLwFJ08u7WfHZ0i+z3uK4FkK5y39MSdMO3EHX7zesDwd6HSUZKpegS22d0RpVPp R+y1c+qaJqehmfrw== X-Received: by 2002:a05:6512:3983:b0:5a2:bac1:97bc with SMTP id 2adb3069b0e04-5a3efea2465mr5028630e87.44.1776160736712; Tue, 14 Apr 2026 02:58:56 -0700 (PDT) Received: from arbuzik ([213.79.119.79]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a3eef071cbsm3208359e87.80.2026.04.14.02.58.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:58:56 -0700 (PDT) From: Marc Finkelbaum To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , Ethan Tidmore , Andy Shevchenko , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marc Finkelbaum Subject: [PATCH 3/9] staging: rtl8723bs: fix block comment alignment Date: Tue, 14 Apr 2026 12:58:27 +0300 Message-ID: <20260414095833.76480-4-regpacy@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260414095833.76480-1-regpacy@gmail.com> References: <20260414095833.76480-1-regpacy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add the required space after the opening '/*' on continuation lines in four block comments: the two C2H event format header tables, the clear_evt inline comment, and the HW_VAR_DM_FUNC_CLR comment in SetHwReg. No functional change. Signed-off-by: Marc Finkelbaum --- drivers/staging/rtl8723bs/hal/hal_com.c | 28 ++++++++++++------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 07e4da49d757..be8b5e1dbab5 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -466,10 +466,10 @@ void rtw_init_hal_com_default_value(struct adapter *A= dapter) } =20 /* -* C2H event format: -* Field TRIGGER CONTENT CMD_SEQ CMD_LEN CMD_ID -* BITS [127:120] [119:16] [15:8] [7:4] [3:0] -*/ + * C2H event format: + * Field TRIGGER CONTENT CMD_SEQ CMD_LEN CMD_ID + * BITS [127:120] [119:16] [15:8] [7:4] [3:0] + */ =20 void c2h_evt_clear(struct adapter *adapter) { @@ -477,10 +477,10 @@ void c2h_evt_clear(struct adapter *adapter) } =20 /* -* C2H event format: -* Field TRIGGER CMD_LEN CONTENT CMD_SEQ CMD_ID -* BITS [127:120] [119:112] [111:16] [15:8] [7:0] -*/ + * C2H event format: + * Field TRIGGER CMD_LEN CONTENT CMD_SEQ CMD_ID + * BITS [127:120] [119:112] [111:16] [15:8] [7:0] + */ s32 c2h_evt_read_88xx(struct adapter *adapter, u8 *buf) { s32 ret =3D _FAIL; @@ -514,9 +514,9 @@ s32 c2h_evt_read_88xx(struct adapter *adapter, u8 *buf) =20 clear_evt: /* - * Clear event to notify FW we have read the command. - * If this field isn't clear, the FW won't update the next command message. - */ + * Clear event to notify FW we have read the command. + * If this field isn't clear, the FW won't update the next command messag= e. + */ c2h_evt_clear(adapter); exit: return ret; @@ -612,9 +612,9 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 = *val) break; case HW_VAR_DM_FUNC_CLR: /* - * input is already a mask to clear function - * don't invert it again! George, Lucas@20130513 - */ + * input is already a mask to clear function + * don't invert it again! George, Lucas@20130513 + */ odm->SupportAbility &=3D *((u32 *)val); break; case HW_VAR_AMPDU_MIN_SPACE: --=20 2.53.0 From nobody Mon Jun 15 22:00:47 2026 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7944A3CBE9A for ; Tue, 14 Apr 2026 09:58:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160741; cv=none; b=miwppuTNxKKk6ZBCS64EUrVZGsJPVCB1nYyVFNkYBhr+D4aIGTL/i/+eBXGHi3W69bIhEXjzGa1iq22EHkbc1vVxam6vyFvsss05xK0wnE1EV7mzHD2cA9GSejXq7s6d2gDbpYzNHS7nuimTwsJPoS+SZX3YXd1+5LPFpbtzoRc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160741; c=relaxed/simple; bh=GvZoxViM8A4CfX7zE+icmmi0kpT+NaMuU7KiKCvRjCc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iCuSEl3VfBsGpr55FjydctlXnazk0oPGr9dQRSsEq85zCJPHj+rEPPzf2aS1JmTEZn0iqpNYKxR/VdXjtm1+aaBzi+1/DdwgecgNr6d/WhfpV6uvNqT31Ara1cJETzG2GxEPx0LIYdv9XeHWGE7dbx5Lojzw+Rl49GzLCKMlSKo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=olzJ6pJ4; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="olzJ6pJ4" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-38e800deae4so14263451fa.0 for ; Tue, 14 Apr 2026 02:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776160738; x=1776765538; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KOHHk6lkQypsp+UDP/NRQu6rNa9m8dXlhY+trkEr9d0=; b=olzJ6pJ4i3QNKBXdkaa0QK3oSq1e5x1BkeixiJHhbxGCs8SmY/eYzWabezqab/N+CO pqZZNjJZ2XP/z8PMGGMxqzcfPqCp27nuEKKaXn36U5HMzbUkH7te98RO5bFNebqb7DUI 9uKO9ndkJw97cJlttkWFyuA6Ov31qICgoxpV8wlqVH83Ll4OpMiSwDh61bd/cAF/tuxH YYlVfR56gXCVP6eQ66FFljLfSUHsgy3LjuaVdfgVyyqKnkJ3kvMC/j7DhktqgUgwZ0dC jEVNlspbcM9LbaBoek3f2oDonrKSdfhOiSc5M5EAAxwEDg08z7+rEsGxF4UiCFz25amm LHLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776160738; x=1776765538; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KOHHk6lkQypsp+UDP/NRQu6rNa9m8dXlhY+trkEr9d0=; b=Jw5RLslXRA7o0Jg0EVbreb6plFYOy1kiy28O+FsgZKSqATtbbKYPOupHODsEj/2Y95 hPzbuH84F1kcRvvaAsFEqFZUY0zR6Cmu27kFH0J7j/Ds1zXWshMztjD/DLVOR/oyjlEm H04wd5boXodOmLFZrV83S4NWZ/LxACZjm8lUo0cX4eYd8CkcAx7ZbVMY9PNPeSHgQlHW 3BRKKyi5R+6whGtpJky9TZ1zS1A+hpZEn1SSObPb00ABt7B6j7rQI2/u3XerLk/5gGyD itsdHrA6Ls/F+IGiWas0nYnMG4K13LEl9AKq0dfJOmdhmY7rgR3OFcCosBi/fL+/YfB1 bF3w== X-Forwarded-Encrypted: i=1; AFNElJ8czy7SXvlmKJWuh/xc9gCaO1/g3UH3Yay/+bHjETJwPXXnQtMgfEs7plNE61kKB97tAj4myJ9qHX71BoE=@vger.kernel.org X-Gm-Message-State: AOJu0YxiOV9ktlBd+KI2Omr4O3PeJbk1LciXVym7J5+FiK24e28jKgUr +5DxBESFO3YBsve3x3bV1jV+JLwwCycgH610oIBKt89JQYPzKC6pZfcn X-Gm-Gg: AeBDieudq9tnRBHOSMiQzZWyV/my2JWKtFL7+/S3D7atjJgyio2TY4Oh+ISiFKBo6j7 v73BkqXFS2UHv30xMjicScZVhC5MIOolZuCKIrPcxBTlxrNAGGUGZ+KXqwUtkyxNcpRYzqPhf7u SESuZZthvFbK7L4Ct/0Vu1dlnLs6VlxtnHsGEz5I4u0E6sOxaoEW7PxJ5xJytPAiHTLe9kwdSQc jUgBJv261Fu0ce6Y2PI3KzQV+3GOvwJLuO5rhPH+PiQu1LuuvflcmCLP6AZU7K2dyndVC1DNW5T 60C2pfjMjPNpnDmHHMOgEwMTsliHafnBLWzk2fKrdULgKcmWJiYrvnWUJ0ldBzeyUusRwD2mJ4E RrLQOKJk1hWj3Pp71E2Zve98bPSuOJXCtHazUgzAE7je3WjEZ6J0LRTHNmiz2N8Rc590TLNyDOj P18DjIDcGDrc+kHA== X-Received: by 2002:a05:6512:39c4:b0:5a3:e5f3:daec with SMTP id 2adb3069b0e04-5a3efb2b6b1mr5364342e87.21.1776160737466; Tue, 14 Apr 2026 02:58:57 -0700 (PDT) Received: from arbuzik ([213.79.119.79]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a3eef071cbsm3208359e87.80.2026.04.14.02.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:58:57 -0700 (PDT) From: Marc Finkelbaum To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , Ethan Tidmore , Andy Shevchenko , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marc Finkelbaum Subject: [PATCH 4/9] staging: rtl8723bs: add spaces around binary operators Date: Tue, 14 Apr 2026 12:58:28 +0300 Message-ID: <20260414095833.76480-5-regpacy@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260414095833.76480-1-regpacy@gmail.com> References: <20260414095833.76480-1-regpacy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add missing spaces around |, &, +, /, and % operators in bitfield OR expressions (SCR_* flags, BIT* masks), array index arithmetic in HalSetBrateCfg and rtw_bb_rf_gain_offset, and the register offset arithmetic in rtw_hal_check_rxfifo_full. No functional change. Signed-off-by: Marc Finkelbaum --- drivers/staging/rtl8723bs/hal/hal_com.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index be8b5e1dbab5..2f76d04aa9d3 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -540,7 +540,7 @@ void rtw_hal_update_sta_rate_mask(struct adapter *padap= ter, struct sta_info *pst /* b/g mode ra_bitmap */ for (i =3D 0; i < sizeof(psta->bssrateset); i++) { if (psta->bssrateset[i]) - tx_ra_bitmap |=3D rtw_get_bit_value_from_ieee_value(psta->bssrateset[i]= &0x7f); + tx_ra_bitmap |=3D rtw_get_bit_value_from_ieee_value(psta->bssrateset[i]= & 0x7f); } =20 /* n mode ra_bitmap */ @@ -548,13 +548,13 @@ void rtw_hal_update_sta_rate_mask(struct adapter *pad= apter, struct sta_info *pst limit =3D 8; /* 1R */ =20 for (i =3D 0; i < limit; i++) { - if (psta->htpriv.ht_cap.mcs.rx_mask[i/8] & BIT(i%8)) - tx_ra_bitmap |=3D BIT(i+12); + if (psta->htpriv.ht_cap.mcs.rx_mask[i / 8] & BIT(i % 8)) + tx_ra_bitmap |=3D BIT(i + 12); } } =20 psta->ra_mask =3D tx_ra_bitmap; - psta->init_rate =3D get_highest_rate_idx(tx_ra_bitmap)&0x3f; + psta->init_rate =3D get_highest_rate_idx(tx_ra_bitmap) & 0x3f; } =20 void SetHwReg(struct adapter *adapter, u8 variable, u8 *val) @@ -571,7 +571,7 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 = *val) u16 reg_scr; =20 reg_scr =3D rtw_read16(adapter, REG_SECCFG); - rtw_write16(adapter, REG_SECCFG, reg_scr|SCR_CHK_KEYID|SCR_RxDecEnable|S= CR_TxEncEnable); + rtw_write16(adapter, REG_SECCFG, reg_scr | SCR_CHK_KEYID | SCR_RxDecEnab= le | SCR_TxEncEnable); } break; case HW_VAR_SEC_DK_CFG: @@ -582,9 +582,9 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 = *val) if (val) { /* Enable default key related setting */ reg_scr |=3D SCR_TXBCUSEDK; if (sec->dot11AuthAlgrthm !=3D dot11AuthAlgrthm_8021X) - reg_scr |=3D (SCR_RxUseDK|SCR_TxUseDK); + reg_scr |=3D (SCR_RxUseDK | SCR_TxUseDK); } else /* Disable default key related setting */ - reg_scr &=3D ~(SCR_RXBCUSEDK|SCR_TXBCUSEDK|SCR_RxUseDK|SCR_TxUseDK); + reg_scr &=3D ~(SCR_RXBCUSEDK | SCR_TXBCUSEDK | SCR_RxUseDK | SCR_TxUseD= K); =20 rtw_write8(adapter, REG_SECCFG, reg_scr); } @@ -770,7 +770,7 @@ bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8 = *pInt) void rtw_hal_check_rxfifo_full(struct adapter *adapter) { /* switch counter to RX fifo */ - rtw_write8(adapter, REG_RXERR_RPT+3, rtw_read8(adapter, REG_RXERR_RPT+3)|= 0xf0); + rtw_write8(adapter, REG_RXERR_RPT + 3, rtw_read8(adapter, REG_RXERR_RPT += 3) | 0xf0); } =20 static u32 Array_kfreemap[] =3D { @@ -802,13 +802,13 @@ void rtw_bb_rf_gain_offset(struct adapter *padapter) =20 for (i =3D 0; i < ARRAY_SIZE(Array_kfreemap); i +=3D 2) { v1 =3D Array[i]; - v2 =3D Array[i+1]; + v2 =3D Array[i + 1]; if (v1 =3D=3D padapter->eeprompriv.EEPROMRFGainVal) { target =3D v2; break; } } - PHY_SetRFReg(padapter, RF_PATH_A, REG_RF_BB_GAIN_OFFSET, BIT18|BIT17|BI= T16|BIT15, target); + PHY_SetRFReg(padapter, RF_PATH_A, REG_RF_BB_GAIN_OFFSET, BIT18 | BIT17 = | BIT16 | BIT15, target); =20 rtw_hal_read_rfreg(padapter, RF_PATH_A, 0x7f, 0xffffffff); } --=20 2.53.0 From nobody Mon Jun 15 22:00:47 2026 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 822DB3CCA1A for ; Tue, 14 Apr 2026 09:59:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160742; cv=none; b=HB+2pPxNrxDxpTjyKZV1BSWjsELbgz5WrtJiQJDvoiLrWxmAtHz1l43Hm2jIDgKunAtnPyhszAovNXOxtJrw+nN72NiS9CBK9yWLZ57FGe843sPs3J8E3yQjXlXxMZufc73A0e3V/gzy+wlOGVjCls1gXhFc8Jp+GrSOJ7RulF0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160742; c=relaxed/simple; bh=ys7BZ7ZjxChL1qSg9mzXiykJ5dJ4mVMXSNIy7gd7dJ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rB9utTL6c/t9sHBoysyrGQer4Ea9iIOHGmoVi5i7OnHboz8LHCTgzTJFufCUvnpw6Bn8CJF+XKLHQzz7qA7n2UP+tR3SNuHBqEU1tjEOD8rvPdyz7/0oFybW2RTe8n0syF++AfoKwmZQ22r0nLQBdDGc8FBtitqvDkt4Bs37FfQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UWj9Va+O; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UWj9Va+O" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-38ddeb0f5abso43825811fa.3 for ; Tue, 14 Apr 2026 02:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776160739; x=1776765539; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EoVWSHGfMT6ozs7Z47I59n6D/+dR84VPz1NohMFwxyw=; b=UWj9Va+OT3wMJztnwlFLqoJZ7OSpR6qJOU92VuuH0M6LdDXJDAJHblmrn8fwf+YUY/ EXijVqbFCq0DquPmu2JPRPYMxjZJwPM2L/pBfurMZBBHdQ2I7NSCsxVcvxpwlUOTjdFs u8Z4dBKqpM7yJcY08BF6iTZlM0Y4aj5UTBuNfr2dQtKR5AZGYrIa5JuAfLjZOdP/aJFS dpsvQk0+j88e4WBEggWkMjKvc16VxqKXtb9LZZ9DY9WAThElWKkxFgHQdymx9K2lrnqo REtXCzgDAThnchrdhfSmvEUXRNmR9RE2ChaSalvotqj6XOuC24Cw4qZtvdkSBCyBWcPq 6ldA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776160739; x=1776765539; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EoVWSHGfMT6ozs7Z47I59n6D/+dR84VPz1NohMFwxyw=; b=BboDZOSUDtIGewJqJNjXEdYynrhzjW3h6KhdVdJTlahq4EVf1cLJ6acq86MCObfSi5 MMzU8TB8iciXwkUlkee6sYhHfTb17c2YR7F/VrI3okcESSCJIpxGrcWPnBcJJ+NVPQ4Z JFvVPkSFSadoIr7mTtQkQe9w0b48V6EvG4jTUOH2ZUxdMhjgdCcCClkEpAR6ZiZ34X5F sJATFDCrntakZyPcH054QkPpxN9esxpWutnNYC/nJisbjUjeboNikw87Yrw/Re2ezh9K ByVRUZ4eh0hDEpL33/4UMF9vEOwK/togcbB+i6hIk4Tl+OfJaNc4xL/CnhC7aclEdedV 8Htg== X-Forwarded-Encrypted: i=1; AFNElJ+L/DT2kJD5MIpqWuNuPymLMh2b7LUYlZsH+7oYL7kTnmfFngdBZVuEWRiaG4myfyITIWWBSPIWu5pojwc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy207WCRrjQ24DJx970FEBqihqFdxAaRoCFgeePTiQxOFPWNzdS YmXRp/y4QwTZdeFvc/Uyao4jRgx1GCNFO+OVztgHiK84L29CVwJ6z1AAskKALJg/FiMexA== X-Gm-Gg: AeBDieuF20IvGnVoWQGLaFWuJu4714Hxjun/PDW2rVoTygL7RhicGQo41GOZRtl2G8U DSDNypo506AUbBC85RpTDJEUCFQdtzNw4GS1fSj98DUeS5dxI5pEXZ15gu+d/T1hbrwXG8UrnNH jws5y6l3XYoE2/L8WNVbs5e6Gtr60VpKWjBlF2zXyawksoJxzRtsMRQFilrf35ztXi47ZCZ2dxN +Bea4EtzDK7A1axwEP43CnFf6zdqLOAsNQz4gFWiDHwjWPD+jUT7DtCmzCXIrV68ZLBf+tWq4W9 8D9kUjOUyC0i2qXi68BNb7beDWXv7BLZitgVweRypOx+pnZqp4GilzWXgTMH4LoabwEPMcnhDV1 r94nbSmR7vogopf3efH1i8qaNzRp9MGyfFrzVR7aVJi21AgpeLywbaKsFrm9jNqSXFAGkFvHqW6 FACgK1tk6dnknW5w== X-Received: by 2002:a05:6512:3e28:b0:5a2:7b95:af0 with SMTP id 2adb3069b0e04-5a3efb29eb9mr5501035e87.25.1776160738504; Tue, 14 Apr 2026 02:58:58 -0700 (PDT) Received: from arbuzik ([213.79.119.79]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a3eef071cbsm3208359e87.80.2026.04.14.02.58.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:58:58 -0700 (PDT) From: Marc Finkelbaum To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , Ethan Tidmore , Andy Shevchenko , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marc Finkelbaum Subject: [PATCH 5/9] staging: rtl8723bs: add space before inline block comments Date: Tue, 14 Apr 2026 12:58:29 +0300 Message-ID: <20260414095833.76480-6-regpacy@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260414095833.76480-1-regpacy@gmail.com> References: <20260414095833.76480-1-regpacy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a space between the semicolon and the opening '/*' on all Queue2Pipe assignment lines in _OneOutPipeMapping, _TwoOutPipeMapping, and _ThreeOutPipeMapping. No functional change. Signed-off-by: Marc Finkelbaum --- drivers/staging/rtl8723bs/hal/hal_com.c | 80 ++++++++++++------------- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 2f76d04aa9d3..fcfcdfd079da 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -342,15 +342,15 @@ static void _OneOutPipeMapping(struct adapter *padapt= er) { struct dvobj_priv *pdvobjpriv =3D adapter_to_dvobj(padapter); =20 - pdvobjpriv->Queue2Pipe[0] =3D pdvobjpriv->RtOutPipe[0];/* VO */ - pdvobjpriv->Queue2Pipe[1] =3D pdvobjpriv->RtOutPipe[0];/* VI */ - pdvobjpriv->Queue2Pipe[2] =3D pdvobjpriv->RtOutPipe[0];/* BE */ - pdvobjpriv->Queue2Pipe[3] =3D pdvobjpriv->RtOutPipe[0];/* BK */ + pdvobjpriv->Queue2Pipe[0] =3D pdvobjpriv->RtOutPipe[0]; /* VO */ + pdvobjpriv->Queue2Pipe[1] =3D pdvobjpriv->RtOutPipe[0]; /* VI */ + pdvobjpriv->Queue2Pipe[2] =3D pdvobjpriv->RtOutPipe[0]; /* BE */ + pdvobjpriv->Queue2Pipe[3] =3D pdvobjpriv->RtOutPipe[0]; /* BK */ =20 - pdvobjpriv->Queue2Pipe[4] =3D pdvobjpriv->RtOutPipe[0];/* BCN */ - pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0];/* MGT */ - pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0];/* HIGH */ - pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0];/* TXCMD */ + pdvobjpriv->Queue2Pipe[4] =3D pdvobjpriv->RtOutPipe[0]; /* BCN */ + pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0]; /* MGT */ + pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0]; /* HIGH */ + pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0]; /* TXCMD */ } =20 static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg) @@ -362,30 +362,30 @@ static void _TwoOutPipeMapping(struct adapter *padapt= er, bool bWIFICfg) /* 0, 1, 0, 1, 0, 0, 0, 0, 0 }; */ /* 0:ep_0 num, 1:ep_1 num */ =20 - pdvobjpriv->Queue2Pipe[0] =3D pdvobjpriv->RtOutPipe[1];/* VO */ - pdvobjpriv->Queue2Pipe[1] =3D pdvobjpriv->RtOutPipe[0];/* VI */ - pdvobjpriv->Queue2Pipe[2] =3D pdvobjpriv->RtOutPipe[1];/* BE */ - pdvobjpriv->Queue2Pipe[3] =3D pdvobjpriv->RtOutPipe[0];/* BK */ + pdvobjpriv->Queue2Pipe[0] =3D pdvobjpriv->RtOutPipe[1]; /* VO */ + pdvobjpriv->Queue2Pipe[1] =3D pdvobjpriv->RtOutPipe[0]; /* VI */ + pdvobjpriv->Queue2Pipe[2] =3D pdvobjpriv->RtOutPipe[1]; /* BE */ + pdvobjpriv->Queue2Pipe[3] =3D pdvobjpriv->RtOutPipe[0]; /* BK */ =20 - pdvobjpriv->Queue2Pipe[4] =3D pdvobjpriv->RtOutPipe[0];/* BCN */ - pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0];/* MGT */ - pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0];/* HIGH */ - pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0];/* TXCMD */ + pdvobjpriv->Queue2Pipe[4] =3D pdvobjpriv->RtOutPipe[0]; /* BCN */ + pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0]; /* MGT */ + pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0]; /* HIGH */ + pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0]; /* TXCMD */ =20 } else { /* typical setting */ /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ /* 1, 1, 0, 0, 0, 0, 0, 0, 0 }; */ /* 0:ep_0 num, 1:ep_1 num */ =20 - pdvobjpriv->Queue2Pipe[0] =3D pdvobjpriv->RtOutPipe[0];/* VO */ - pdvobjpriv->Queue2Pipe[1] =3D pdvobjpriv->RtOutPipe[0];/* VI */ - pdvobjpriv->Queue2Pipe[2] =3D pdvobjpriv->RtOutPipe[1];/* BE */ - pdvobjpriv->Queue2Pipe[3] =3D pdvobjpriv->RtOutPipe[1];/* BK */ + pdvobjpriv->Queue2Pipe[0] =3D pdvobjpriv->RtOutPipe[0]; /* VO */ + pdvobjpriv->Queue2Pipe[1] =3D pdvobjpriv->RtOutPipe[0]; /* VI */ + pdvobjpriv->Queue2Pipe[2] =3D pdvobjpriv->RtOutPipe[1]; /* BE */ + pdvobjpriv->Queue2Pipe[3] =3D pdvobjpriv->RtOutPipe[1]; /* BK */ =20 - pdvobjpriv->Queue2Pipe[4] =3D pdvobjpriv->RtOutPipe[0];/* BCN */ - pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0];/* MGT */ - pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0];/* HIGH */ - pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0];/* TXCMD */ + pdvobjpriv->Queue2Pipe[4] =3D pdvobjpriv->RtOutPipe[0]; /* BCN */ + pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0]; /* MGT */ + pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0]; /* HIGH */ + pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0]; /* TXCMD */ =20 } } @@ -399,30 +399,30 @@ static void _ThreeOutPipeMapping(struct adapter *pada= pter, bool bWIFICfg) /* 1, 2, 1, 0, 0, 0, 0, 0, 0 }; */ /* 0:H, 1:N, 2:L */ =20 - pdvobjpriv->Queue2Pipe[0] =3D pdvobjpriv->RtOutPipe[0];/* VO */ - pdvobjpriv->Queue2Pipe[1] =3D pdvobjpriv->RtOutPipe[1];/* VI */ - pdvobjpriv->Queue2Pipe[2] =3D pdvobjpriv->RtOutPipe[2];/* BE */ - pdvobjpriv->Queue2Pipe[3] =3D pdvobjpriv->RtOutPipe[1];/* BK */ + pdvobjpriv->Queue2Pipe[0] =3D pdvobjpriv->RtOutPipe[0]; /* VO */ + pdvobjpriv->Queue2Pipe[1] =3D pdvobjpriv->RtOutPipe[1]; /* VI */ + pdvobjpriv->Queue2Pipe[2] =3D pdvobjpriv->RtOutPipe[2]; /* BE */ + pdvobjpriv->Queue2Pipe[3] =3D pdvobjpriv->RtOutPipe[1]; /* BK */ =20 - pdvobjpriv->Queue2Pipe[4] =3D pdvobjpriv->RtOutPipe[0];/* BCN */ - pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0];/* MGT */ - pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0];/* HIGH */ - pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0];/* TXCMD */ + pdvobjpriv->Queue2Pipe[4] =3D pdvobjpriv->RtOutPipe[0]; /* BCN */ + pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0]; /* MGT */ + pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0]; /* HIGH */ + pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0]; /* TXCMD */ =20 } else { /* typical setting */ /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ /* 2, 2, 1, 0, 0, 0, 0, 0, 0 }; */ /* 0:H, 1:N, 2:L */ =20 - pdvobjpriv->Queue2Pipe[0] =3D pdvobjpriv->RtOutPipe[0];/* VO */ - pdvobjpriv->Queue2Pipe[1] =3D pdvobjpriv->RtOutPipe[1];/* VI */ - pdvobjpriv->Queue2Pipe[2] =3D pdvobjpriv->RtOutPipe[2];/* BE */ - pdvobjpriv->Queue2Pipe[3] =3D pdvobjpriv->RtOutPipe[2];/* BK */ + pdvobjpriv->Queue2Pipe[0] =3D pdvobjpriv->RtOutPipe[0]; /* VO */ + pdvobjpriv->Queue2Pipe[1] =3D pdvobjpriv->RtOutPipe[1]; /* VI */ + pdvobjpriv->Queue2Pipe[2] =3D pdvobjpriv->RtOutPipe[2]; /* BE */ + pdvobjpriv->Queue2Pipe[3] =3D pdvobjpriv->RtOutPipe[2]; /* BK */ =20 - pdvobjpriv->Queue2Pipe[4] =3D pdvobjpriv->RtOutPipe[0];/* BCN */ - pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0];/* MGT */ - pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0];/* HIGH */ - pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0];/* TXCMD */ + pdvobjpriv->Queue2Pipe[4] =3D pdvobjpriv->RtOutPipe[0]; /* BCN */ + pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0]; /* MGT */ + pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0]; /* HIGH */ + pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0]; /* TXCMD */ } } =20 --=20 2.53.0 From nobody Mon Jun 15 22:00:47 2026 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 318443CCFC3 for ; Tue, 14 Apr 2026 09:59:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160742; cv=none; b=DZVEW72STr0fvIqIDQVadQ2i0IKg4IR0oaixLhm7zrmkGdyySF8yb+cU+Q2yzOdLU+ZB2pyiJSENmUTmBY1ixBdp05p/lDEkw7ib6tbtD4aHH0wlqxx0H/rS1TdgHvQQWDazO+nxJER3ZHQ4qI70FanvMIuyBJBnEMkQmN5Drxs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160742; c=relaxed/simple; bh=cigqYaiI95hZ6Uh9P/wD2DmyqcOpiQzU/+0vTicsJgc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fVWet7kVmCunMQiQoz+MwrMkqql0yUohz/k5XFzz9eLdnu4KC9h673uli5Lt4lBYMOvLPx8t9HB3Uh0qYcHoXFM+O5p0Lj3n3Ulhm785kCdcuEqkBPO9cy0fJsD1izX2B9h7LI0gF7JKWii2QA0ymP2x/fLxhMyix23EeOzqk9o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YBXATnXB; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YBXATnXB" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5a3d42263e4so4822005e87.2 for ; Tue, 14 Apr 2026 02:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776160739; x=1776765539; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/pp4dkNOqmXWeG8D0HndGuYiqy4ojGPxRtQgL9sf7G0=; b=YBXATnXBXsvJ10JtHh18cIi9lxPpgCMg9RkL15O0tRw/bJAM6sqLDEYeIgmAgEIfoD agGQ4sYh41++u7nFV6D8K2paBm8BiaySBp4HCOp1iXNEIdU67Hes3H4NRd0AwFFSeeEd wWzDrUrz/YJ6prA/t5KAbXojNZwkpuV7oZlLSr80OZijc+Ccg0xnJSR6BV82ElyjAbvh iglG2Q/vbZ0+ggwrg+XQRs0jXV6wqD3mya/IBoiiNZL52vFCbKQLR4z948j4ZWGULjEN g7+vVYi1q67TtXSZbSpnDf8zr87EgjiBfRVTcF/O9pwX7levSlpu7YmVcTyltDkNKiXM DFXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776160739; x=1776765539; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/pp4dkNOqmXWeG8D0HndGuYiqy4ojGPxRtQgL9sf7G0=; b=q0YUpa6uRhuE6Ik/YgcPVJYqq+uSq9UHv6LN8KUO+E3RgofMvTgWFz9r5O742pjisD bkVtMenxeYNk239SUzp9K3afizmJfbzx8Nvso6mTWMp+m5/KN8fztPC1zUyn6vJTjrCy E8LCY1cOAIiw4NLx1VOITJwwheeRnIIcDjT1F3aT4oGNpAOkNu4ilbj8FBebNEmoAklD yPLPj0IJUaT6HrsdSuluBKPe4heiy67QGaLW0HkaCVDF4jspMqKBRiz2frld1e5fGYra r7QC5FWbbwBn0zScZoPVUjGRgfclln2HHgXHJAsYcApdMofHaiBH3wPwj2QTsY8FMOpE E1Cg== X-Forwarded-Encrypted: i=1; AFNElJ+wkbgFmiToHCpTAD2A2uYXhhH7ol31tWHuXPWgmTR3Wn4At/gGV8+6ggsHlj1tEQciYOkclsOcBTQMY8k=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0Sa4Vx2Sr2PzNsBHHPhU9bMTjwB9fFMbW5/oUhuL54qiYlKLm /9kdCbDEyZpX415/kMbWEfryk6vAkyF7wHVHGUuECoGy1BK/zjKXGyJQ X-Gm-Gg: AeBDietdk9JZyjV6AQsMACUnBEPdHchk+6C9qD/c+kbMk+Jl06y6AR6n0KzfjAA7PX4 1eCXYpjU2QbwFGAtQghFtB2ovzCih1LDdTk7PdQ8i07aflvSlsxHkSLfbpnbKLKaw465czsjDs8 2gNQYNmfkWcmTVGYbbYX3Z68uHhzoQVjxYXFfsvD/7d158/uy5bOlILczEn67tgvEkyiz/r7LP0 6LeLD5QBPgCFpTZn563Hw69525Daa0rsUqyP1FzHjLTdVsru4JJMnAXot7e8hjepqProCe0yzL0 LwGTzAYcpW2tXpqgRxaC3tgRj7R3VUP4jVuthhQjKCQpdcLLFNtC8iw1nN+WRMTuR89Gt6urG3S UGf78+vOClS1JXS9PoDREkFY5ivM6aFFy2iP0yh5U0PdUxd6/Oz1jg2ZGhDJAX9MFzvf3mRs3Gi l5XZZbeN2LWBqpUg== X-Received: by 2002:a05:6512:3183:b0:5a4:5b5:c84c with SMTP id 2adb3069b0e04-5a405b5c98cmr552568e87.17.1776160739227; Tue, 14 Apr 2026 02:58:59 -0700 (PDT) Received: from arbuzik ([213.79.119.79]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a3eef071cbsm3208359e87.80.2026.04.14.02.58.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:58:58 -0700 (PDT) From: Marc Finkelbaum To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , Ethan Tidmore , Andy Shevchenko , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marc Finkelbaum Subject: [PATCH 6/9] staging: rtl8723bs: fix Yoda conditions and == false comparisons Date: Tue, 14 Apr 2026 12:58:30 +0300 Message-ID: <20260414095833.76480-7-regpacy@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260414095833.76480-1-regpacy@gmail.com> References: <20260414095833.76480-1-regpacy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace reversed comparisons with natural-order equivalents: - '0xFF =3D=3D hw_channel_plan' -> 'hw_channel_plan =3D=3D 0xFF' - 'false =3D=3D pHalData->bDisableSWChannelPlan' -> '!pHalData->...' - 'is_supported_24g(...) =3D=3D false' -> '!is_supported_24g(...)' The multi-line if condition around bDisableSWChannelPlan is also reformatted to standard kernel one-line style. No functional change. Signed-off-by: Marc Finkelbaum --- drivers/staging/rtl8723bs/hal/hal_com.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index fcfcdfd079da..dc5e6a58fd9d 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -105,7 +105,7 @@ u8 hal_com_config_channel_plan( pHalData->bDisableSWChannelPlan =3D false; chnlPlan =3D def_channel_plan; =20 - if (0xFF =3D=3D hw_channel_plan) + if (hw_channel_plan =3D=3D 0xFF) AutoLoadFail =3D true; =20 if (!AutoLoadFail) { @@ -120,10 +120,8 @@ u8 hal_com_config_channel_plan( } } =20 - if ( - (false =3D=3D pHalData->bDisableSWChannelPlan) && - rtw_is_channel_plan_valid(sw_channel_plan) - ) + if ((!pHalData->bDisableSWChannelPlan) && + rtw_is_channel_plan_valid(sw_channel_plan)) chnlPlan =3D sw_channel_plan; =20 return chnlPlan; @@ -134,7 +132,7 @@ bool HAL_IsLegalChannel(struct adapter *adapter, u32 Ch= annel) bool bLegalChannel =3D true; =20 if ((Channel <=3D 14) && (Channel >=3D 1)) { - if (is_supported_24g(adapter->registrypriv.wireless_mode) =3D=3D false) + if (!is_supported_24g(adapter->registrypriv.wireless_mode)) bLegalChannel =3D false; } else { bLegalChannel =3D false; --=20 2.53.0 From nobody Mon Jun 15 22:00:47 2026 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41BA13CD8A8 for ; Tue, 14 Apr 2026 09:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160743; cv=none; b=asWLfCZsrVbLIF7D/mLc7GoB8ei3dQUC1s99E4KMFfUB8eoA31G8HWACOChKZRFdfh6+MmbN5dQoe0WSPMhHKfGB9CG/9kHVQzYe9UG/qjeYWcd3zFNv2wHnA8CnQ49p164NGQQBUhntPjZM1HJD7dGJ7FOCahRAp2xuh9tNiDM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160743; c=relaxed/simple; bh=7RsPONIQnY98+2OqD6btZjmZP/j+SspqK5MMkW5lqfA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FNkrI+q6xWdzVq8iSdTst2QNM84V8M48LTH9GfRo1I1bZYfn8s9rdXF4yYVWnIB5BnMuSx4sLEAM3ZK3dqjZnQ6VWnSA0G/QymRtybFa0jbNmnhZyRCVls8j9tCcF7nmsQeCtpmKwdk/Qk8+jhPtu18IrHNABMfjg2XKaMw7zCg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dhwl+p/y; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dhwl+p/y" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5a3e66f849dso5149821e87.1 for ; Tue, 14 Apr 2026 02:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776160740; x=1776765540; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JkvWGV+eYa7ezu8hkwgEcsEbAUCRA8jsvk7paZPGHo8=; b=Dhwl+p/yYAl2D4bsFSn+YONU0BPYor013qQV20EqIpCeHdVGDhhOv5vT7VbfpS+qdJ 8bThgbAAb/7qZJLo+Ied11V93SXIgKZCZKjo3pphsSMJ/BZhaVIeZ0cKT6A4G/6GcdXN dpOSUms1UgXM9KyrKKs9t0SXgI54kt5KF2zdn6Gz2t9saM9mw5oM5hTohEQGgILHG1om RvCsCQ3MHSrdeGvYKzbSEQlLwCrjV1Zw+/PZQlWKc8iT/zYNj2ensURfus+3G5GwIKVy PQr+nbSFZU7gHGV6KcR+pELiHM2t2VhPg4tubvXu8SzH/Z+NJIJP4kuXheBUgRBJLYbE w3NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776160740; x=1776765540; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JkvWGV+eYa7ezu8hkwgEcsEbAUCRA8jsvk7paZPGHo8=; b=V+KkRTWuHJ5Sn56wuKTR5bLNqtisba3C2JxuzrXyVqHl4bCUbpl1spMQ5HNIb5Z7nQ 2eQ1eXxPF4tZ86ed0PzBX90GdeP+4Bt5klORqLP5MqHopp6Oa4SYB+M3JD0GQ5iFDza7 top4trHyQcgSSSU4wgW6cfK/oZRyHeo43/39vxdQ9UIsVK9sh0d/YnAp25G0d6xwsLRe CKKwp7ueEnQFWn2KNiMUjPI6ycDMDP2wEVSgnxN4TtvcFgeRIdrAfEbmlPP07r082/lI ilFb7GVj1MBUwxXX/Z88gmlJ6TkKfiqFUlQtFQC07nIOv9aQG4wxXBBTamE6whtEjGIi TN3A== X-Forwarded-Encrypted: i=1; AFNElJ95f7hUMtWiK495EML4bOz2zqglpq093hiCVA5z2TF+IxwNdCHQHOqqFRo+g6TJARPl+HX8VyyCu2/aWBo=@vger.kernel.org X-Gm-Message-State: AOJu0YxVdVXfFJQCIXPmq/RDWRcO8KhmapJ+oe0rciuvJSHz0doUX+cB XZy70WkG32RryUVbefjgYxmLOIPh/LunTOm7X6Dmf5FK9YHk3D/jbsE9 X-Gm-Gg: AeBDieuKaODfPLaEQjxPy71TZtWhMS66PaBezbEWCx/KBrxjlK7kFCsTX9KQ/WoBagQ TDi184lrhkOiUHvFH38GtWxio+hC4Rjb6i/NoaS+NncNIiq2nfD7vp8f4Zi+XBoteEIj6p3Otk5 akJ6viGEBkKjwdPsfPHgzraV2b3BIIKhL363hIaujYTpCkY55DlvFKQC/ldB/X2rQJgDsKf9rVZ 5L5Ox7/HP3Iqlr8B+xj5g4BtMDrzFzE03sdC+iuUPDWkHCDyJE3StGM4MPQ+2NBvHwp6N1qGa06 4IfWtoFhyTvzblGZ17suFuEhuyEHGMq3UmYzCQEGySx+wKJvtx/WQpuxYhntg0N6RVGsz/jyYDm WZaLQQHSTRXfkOlX7dXrkc9nmP86h9rly84qHTlIoJt5zuoL5WBdsYO2vlyBv3hYm1BDXW5F+xU k5bLvBKv6ukYNfWg== X-Received: by 2002:a05:6512:1591:b0:5a4:558:33ae with SMTP id 2adb3069b0e04-5a4055834b3mr609264e87.10.1776160740214; Tue, 14 Apr 2026 02:59:00 -0700 (PDT) Received: from arbuzik ([213.79.119.79]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a3eef071cbsm3208359e87.80.2026.04.14.02.58.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:58:59 -0700 (PDT) From: Marc Finkelbaum To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , Ethan Tidmore , Andy Shevchenko , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marc Finkelbaum Subject: [PATCH 7/9] staging: rtl8723bs: reformat multi-line function signatures Date: Tue, 14 Apr 2026 12:58:31 +0300 Message-ID: <20260414095833.76480-8-regpacy@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260414095833.76480-1-regpacy@gmail.com> References: <20260414095833.76480-1-regpacy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert one-parameter-per-line function signatures to standard kernel style with parameters aligned to the opening parenthesis and wrapped at 80 columns. Affected functions: hal_com_config_channel_plan, GetHalDefVar, SetHalODMVar, and rtw_hal_update_sta_rate_mask. No functional change. Signed-off-by: Marc Finkelbaum --- drivers/staging/rtl8723bs/hal/hal_com.c | 26 +++++++++---------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index dc5e6a58fd9d..44bef1400947 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -90,13 +90,9 @@ void dump_chip_info(struct hal_version ChipVersion) *Final channel plan decision * */ -u8 hal_com_config_channel_plan( - struct adapter *padapter, - u8 hw_channel_plan, - u8 sw_channel_plan, - u8 def_channel_plan, - bool AutoLoadFail -) +u8 hal_com_config_channel_plan(struct adapter *padapter, u8 hw_channel_pla= n, + u8 sw_channel_plan, u8 def_channel_plan, + bool AutoLoadFail) { struct hal_com_data *pHalData; u8 chnlPlan; @@ -525,7 +521,8 @@ u8 rtw_get_mgntframe_raid(struct adapter *adapter, unsi= gned char network_type) return (network_type & WIRELESS_11B) ? RATEID_IDX_B : RATEID_IDX_G; } =20 -void rtw_hal_update_sta_rate_mask(struct adapter *padapter, struct sta_inf= o *psta) +void rtw_hal_update_sta_rate_mask(struct adapter *padapter, + struct sta_info *psta) { u8 i, limit; u32 tx_ra_bitmap; @@ -649,9 +646,8 @@ void GetHwReg(struct adapter *adapter, u8 variable, u8 = *val) } } =20 -u8 GetHalDefVar( - struct adapter *adapter, enum hal_def_variable variable, void *value -) +u8 GetHalDefVar(struct adapter *adapter, enum hal_def_variable variable, + void *value) { struct hal_com_data *hal_data =3D GET_HAL_DATA(adapter); u8 bResult =3D _SUCCESS; @@ -699,12 +695,8 @@ u8 GetHalDefVar( return bResult; } =20 -void SetHalODMVar( - struct adapter *Adapter, - enum hal_odm_variable eVariable, - void *pValue1, - bool bSet -) +void SetHalODMVar(struct adapter *Adapter, enum hal_odm_variable eVariable, + void *pValue1, bool bSet) { struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); struct dm_odm_t *podmpriv =3D &pHalData->odmpriv; --=20 2.53.0 From nobody Mon Jun 15 22:00:47 2026 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0F153CE480 for ; Tue, 14 Apr 2026 09:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160744; cv=none; b=UuLnghWr6HuQQulbQ830ZORAtN2phDQyHHJjnOKAWqRgZkNOugERC+84f0k6OvQw2gsxNWmhyCAZY86fZKkUhIDhgN/Nb7UGbpmBtASluOqHHMzUeJXjvBFgtN/F5JuZINHD/97Fk2BXrPT0EBDmclBRPeRBudpBzZ0Jey1Nazo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160744; c=relaxed/simple; bh=rHwXM+sex2p2dGPe48QH17nnOkpddITFHnXPlwJpycA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dRlRwKZXqKBOgv1OERi8qiXQv4poOmB250szmbOQgtGrNYihEKmoOl560mZjJ/TLVtrM+qRGdTh4AvA8kaOlRq60cniZE1xNP1Mqxa+TUmHOWQkS8cDuFtqhOcZ1i9kdc1FDfuOT3blHNmktWys47q+Jh12HgvXEkep1mF+IriA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RivAiLAQ; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RivAiLAQ" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-59de8155501so5914355e87.3 for ; Tue, 14 Apr 2026 02:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776160741; x=1776765541; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z870y+WgVq6dBDNjDxbOvCEshdD3HN+G5/wMOHsX9mQ=; b=RivAiLAQbqQD1EXy98vO1JMEXDiSzyXXtqeZm2YLwonucNdEqRtHsL7qSqwn0lKn91 7Wd6ovWfxInbywdOHda6NDrfMxgDLTnustbH8tSi47O/Lm+yVSgMdqtluzCNnoTcGTbA 0CdgGgt42RNcFKuPauUz0bi5Wc52RR8sGexhkq25qA0nABkEXwPBHPREO8pg9QmSsmLD N/mZbeKuHqFxO2S477L3nXv7548ud2z07XxrmYtwcPozaLbLuyjON5Eg25qKXNtDk2da BGPZj9Oyntxu6OFG8wiZ/kvFz98x/InErcXnw0/IAKZiN2wr8bXuZfl+6PNmzjsSlYgS RqlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776160741; x=1776765541; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=z870y+WgVq6dBDNjDxbOvCEshdD3HN+G5/wMOHsX9mQ=; b=oHdK0oPessA/2u4DF4tQntITDxcP8NFGhBA4+hiZbg86S8lTsb0xf/mFNPtNDxiAov kAGXqrZednzhndXYqButczIts5q0wwvToW3H3Fs83qP2WSUbVograpPHF40/iGJUkOpO irGKnZ4n4QMgsEVLsfzblKJuZDrCG6xQbNFpEPTXnvbmeglSy2BgE2bcm9m4xRkZqgNh o/YxyLJoFckeAzQbFq7+szGtl5jfBnBnFEFYMZ8gnrJb4xtGWZe+zgBZWKegByQJRcQx ID3Sorf4cd/qeoDNmW5OdrhViJ7xFl2P0KpwRreXobUo0UvQexgItuMBurMtiQyy9HBE QNZQ== X-Forwarded-Encrypted: i=1; AFNElJ/svZX+39qvFbFzy9v7iDI8z4ADoBiMrR40wOoHEd0tIGQKwHfLiTCZo276tWBvaAxujwzyvSQNq/BDA5o=@vger.kernel.org X-Gm-Message-State: AOJu0YwZWEwswrRwf9lJBzRZIVfCmqBrof6UUctpjnuQwMu9g9IEdVbS UjTtEkbhL9jRGYt37nLrOOce6zAJVHuIYHw0WxvmfhK2U9Odx1qbkiGC X-Gm-Gg: AeBDievN1QN5zcJ2vLhy24ZMA/c1N9p4oAxUGMIg9s2bqJezHPMXU+Ip+OyE9nmJFbY HS7FmmtNuccb9bj04ePz7RQr+M9iTNXXRF+ryvKuhiSv5M7HcPIq8/d+TDweg/nD5C2e2cPMjek +z483b6eqdY5Mdl7z4kaDSNs1KBFET0IUP5yKw3kwu6yv13C67glaZOM1j1fQJ9an13hOKuuYfc TRskH9Gxm9FsNN70oFtWFEdMAdP0C9Vz6VBo+1gc9fEFh0g4DDBANO2EVH/Yg1zhwlE+BwpVsyz gACGxalwTBdIjMx8u5O8B5V4uhUyISaKgvRc4kSfMWuWRcXu20CBvmXCj/DUo4enYEKIVFwvNiZ 2fdSphB6p4XJTXUvLrCF2AzVWjnXUyHGreo2mUBCSKlIWFz0k07uBexukkNzGk0IIpv57VNK6FA JCA3hCrS2fJ/hqlg== X-Received: by 2002:a05:6512:1385:b0:5a3:ffd1:fbcf with SMTP id 2adb3069b0e04-5a3ffd1fbe5mr2699525e87.17.1776160740969; Tue, 14 Apr 2026 02:59:00 -0700 (PDT) Received: from arbuzik ([213.79.119.79]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a3eef071cbsm3208359e87.80.2026.04.14.02.59.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:59:00 -0700 (PDT) From: Marc Finkelbaum To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , Ethan Tidmore , Andy Shevchenko , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marc Finkelbaum Subject: [PATCH 8/9] staging: rtl8723bs: reformat switch-case blocks with braced bodies Date: Tue, 14 Apr 2026 12:58:32 +0300 Message-ID: <20260414095833.76480-9-regpacy@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260414095833.76480-1-regpacy@gmail.com> References: <20260414095833.76480-1-regpacy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move the opening brace from a separate line to the end of the case label (case X: {) and combine the closing brace with break (} break;) for HW_VAR_SEC_CFG, HW_VAR_SEC_DK_CFG, HAL_DEF_UNDERCORATEDSMOOTHEDPWDB, and HAL_ODM_STA_INFO. Also add braces to the unguarded else clause in HW_VAR_SEC_DK_CFG, reindent the moved declarations by one level, and fix over-indented bodies in HAL_ODM_P2P_STATE and HAL_ODM_WIFI_DISPLAY_STAT= E. No functional change. Signed-off-by: Marc Finkelbaum --- drivers/staging/rtl8723bs/hal/hal_com.c | 62 +++++++++++-------------- 1 file changed, 28 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 44bef1400947..2688355f9265 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -561,16 +561,13 @@ void SetHwReg(struct adapter *adapter, u8 variable, u= 8 *val) case HW_VAR_INIT_RTS_RATE: rtw_warn_on(1); break; - case HW_VAR_SEC_CFG: - { + case HW_VAR_SEC_CFG: { u16 reg_scr; =20 reg_scr =3D rtw_read16(adapter, REG_SECCFG); rtw_write16(adapter, REG_SECCFG, reg_scr | SCR_CHK_KEYID | SCR_RxDecEnab= le | SCR_TxEncEnable); - } - break; - case HW_VAR_SEC_DK_CFG: - { + } break; + case HW_VAR_SEC_DK_CFG: { struct security_priv *sec =3D &adapter->securitypriv; u8 reg_scr =3D rtw_read8(adapter, REG_SECCFG); =20 @@ -578,12 +575,12 @@ void SetHwReg(struct adapter *adapter, u8 variable, u= 8 *val) reg_scr |=3D SCR_TXBCUSEDK; if (sec->dot11AuthAlgrthm !=3D dot11AuthAlgrthm_8021X) reg_scr |=3D (SCR_RxUseDK | SCR_TxUseDK); - } else /* Disable default key related setting */ + } else { /* Disable default key related setting */ reg_scr &=3D ~(SCR_RXBCUSEDK | SCR_TXBCUSEDK | SCR_RxUseDK | SCR_TxUseD= K); + } =20 rtw_write8(adapter, REG_SECCFG, reg_scr); - } - break; + } break; case HW_VAR_DM_FLAG: odm->SupportAbility =3D *((u32 *)val); break; @@ -653,19 +650,17 @@ u8 GetHalDefVar(struct adapter *adapter, enum hal_def= _variable variable, u8 bResult =3D _SUCCESS; =20 switch (variable) { - case HAL_DEF_UNDERCORATEDSMOOTHEDPWDB: - { - struct mlme_priv *pmlmepriv; - struct sta_priv *pstapriv; - struct sta_info *psta; + case HAL_DEF_UNDERCORATEDSMOOTHEDPWDB: { + struct mlme_priv *pmlmepriv; + struct sta_priv *pstapriv; + struct sta_info *psta; =20 - pmlmepriv =3D &adapter->mlmepriv; - pstapriv =3D &adapter->stapriv; - psta =3D rtw_get_stainfo(pstapriv, pmlmepriv->cur_network.network.mac_a= ddress); - if (psta) - *((int *)value) =3D psta->rssi_stat.UndecoratedSmoothedPWDB; - } - break; + pmlmepriv =3D &adapter->mlmepriv; + pstapriv =3D &adapter->stapriv; + psta =3D rtw_get_stainfo(pstapriv, pmlmepriv->cur_network.network.mac_ad= dress); + if (psta) + *((int *)value) =3D psta->rssi_stat.UndecoratedSmoothedPWDB; + } break; case HAL_DEF_DBG_DM_FUNC: *((u32 *)value) =3D hal_data->odmpriv.SupportAbility; break; @@ -702,24 +697,23 @@ void SetHalODMVar(struct adapter *Adapter, enum hal_o= dm_variable eVariable, struct dm_odm_t *podmpriv =3D &pHalData->odmpriv; /* _irqL irqL; */ switch (eVariable) { - case HAL_ODM_STA_INFO: - { - struct sta_info *psta =3D pValue1; - if (bSet) { - ODM_CmnInfoPtrArrayHook(podmpriv, ODM_CMNINFO_STA_STATUS, psta->mac_id= , psta); - } else { - /* spin_lock_bh(&pHalData->odm_stainfo_lock); */ - ODM_CmnInfoPtrArrayHook(podmpriv, ODM_CMNINFO_STA_STATUS, psta->mac_id= , NULL); + case HAL_ODM_STA_INFO: { + struct sta_info *psta =3D pValue1; =20 - /* spin_unlock_bh(&pHalData->odm_stainfo_lock); */ - } + if (bSet) { + ODM_CmnInfoPtrArrayHook(podmpriv, ODM_CMNINFO_STA_STATUS, psta->mac_id,= psta); + } else { + /* spin_lock_bh(&pHalData->odm_stainfo_lock); */ + ODM_CmnInfoPtrArrayHook(podmpriv, ODM_CMNINFO_STA_STATUS, psta->mac_id,= NULL); + + /* spin_unlock_bh(&pHalData->odm_stainfo_lock); */ } - break; + } break; case HAL_ODM_P2P_STATE: - ODM_CmnInfoUpdate(podmpriv, ODM_CMNINFO_WIFI_DIRECT, bSet); + ODM_CmnInfoUpdate(podmpriv, ODM_CMNINFO_WIFI_DIRECT, bSet); break; case HAL_ODM_WIFI_DISPLAY_STATE: - ODM_CmnInfoUpdate(podmpriv, ODM_CMNINFO_WIFI_DISPLAY, bSet); + ODM_CmnInfoUpdate(podmpriv, ODM_CMNINFO_WIFI_DISPLAY, bSet); break; =20 default: --=20 2.53.0 From nobody Mon Jun 15 22:00:47 2026 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 055903C1414 for ; Tue, 14 Apr 2026 09:59:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160745; cv=none; b=sLuTS16Lxj98NIBuTGOWTboYupNOjnRhNZiyiG+jfO+SwnHNN4MfnpzramGjGgt65Jx0gaEL6CYSkyqNMsRHBZQ1yW3T6NNqrn63PSR5CBDHZQHXTQothxm0rPidMqIYM/pDFnQW13N9KyHpUUL8D6HLEj4KK0cZq82ylCuPI4A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160745; c=relaxed/simple; bh=1WCnA+MKLG228VTV2fHjgVkAptbznxnr3zeFTRFclc0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SLMa/zr/yTlNLJiUgQ4jBh6Xnf1xlgsPOvjUqsyyrvtjYWWCzOMig4V9Od6Qq+DiqwaBFGqiBwrCXHhwH70btjU+crry9gdDONW0/2W+E/OITesTznjLviOt7187ChWxvVDeK6J7B+3Tz7iiszGRMtlmyDuGFq4QPFAOWk+2OuM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LtbiJEcE; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LtbiJEcE" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5a2b636b944so6077354e87.1 for ; Tue, 14 Apr 2026 02:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776160742; x=1776765542; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3k6yHbZOWF5ogL1t2dmGLcAHzs09u52SSLr2n+2Z37I=; b=LtbiJEcE8m3y9HTG/CTI8S+PecTuAE0jidFQbt42GU/r9UVSgrHc1gLaDwaFwkLQgm fm3uZyVrz/TTju1yRFuqkK4j2i3NoosnXiXc7Nj05Q3KwHliFZzfJ00nkEPzAxxU7+vT zZ7dbfuMhKi/P2gGoldZxj0PB+aBOVzrfIP/6tLcp5LM0+hkJPmAgVjU0+jiYEfTRxZI XtY+uuea5+6QtVlOdWv7kCQhQLRRjnR+H4Q4TeRcKMl+NNTJUTG01flS9aUDgJF4hFP2 b1hKEuPQUjhZC++7sswDwi/d8vMq5bQUiFAP57koa0bjMkj1SzeCPNvmdaFfiwrXkudU Hq7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776160742; x=1776765542; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3k6yHbZOWF5ogL1t2dmGLcAHzs09u52SSLr2n+2Z37I=; b=lgJfGiLsrjOBwLHssJM17fd0CZpggr+voSOVhIMJTI+JiqCDh3yjn3NCU4j86+p5gI nD3UrVR0O5t9Nd3uBGYbXlpdAA7lu029BPAOo0ObolistefaG0mKcVFZD0qoK8jCwBsU ODGng/ifb/FVMfrLPzdHUZrEeWE294sompEWlPv+KfTOyAZJecvEPVcVgTEf3h3unsPG mkwQFvJsMHdyCswPkRa6s5egnbmNIgqGsIkdeigje5qRM7LN2lEvkNvjv4rwNWOoq+sf QzqvoUF8oSIbzraPnSB5jAT2Mbp1ZLqUH8OsO6hj3uH602A0tvq62BzUz5XxiKGGY9w/ 4dlw== X-Forwarded-Encrypted: i=1; AFNElJ//EyE5LO4Y4B6tMmlgiHmrm/11FS/D5pvdyOIy2JDn0Y4YjdRFgebkfhufx7+V3YBvaoamDK7SNNF6bi0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2bf2ulpgeT9Dkio3DYXUwOJHE95Dp86mSTMNK6retc0QkhfLj y0/Pdfe+gRs6MzqnNlQ9ftsfA5I5uXVU79gnFEAeTZjnYtkK+yYendgZ X-Gm-Gg: AeBDietGnMHBIUXcARHmhvzIQ4zRlTgbiA3fn2Hr5cj2pCP3nzOgmsXvJLt2SVpzKO2 C0yN4qHssgzHlrkBfnIlZc6IGZaz6g6jFRep6+P+mx3xBUJO1xwXI66/ZVxCJ6dDmqW1AJZCtru n8jQfeBMJ5Ed4yzL2MDKT5FhsXRBq+aqva2tpQm1PMffDvoDF7Irc/8uN+y2EtURXL4xXsJKweO yr9xDAZFaKmi6owaSuO9hqXUO42foJ7UDCC+o2Z5FLU4zyOWmfTgN5GYqRSHpWPu3G9/gcgso2t VXKkrkZCzevyFgoQRFJYN/qT1v7sBFWc0cQQScueyw7terjeA+oG1tt+g5QIAKDklTPTWcFAOgX z6tTdy2RFbiABOouUJiB/IrSc3Q76apGA79B64q9evMLiXEbt1boeqbBiu97iDElPA/P773mOQZ X55yprtiJChaH348DcnHTalpLa X-Received: by 2002:a05:6512:39d5:b0:5a4:1b8:1a9c with SMTP id 2adb3069b0e04-5a401b81ad6mr1888639e87.26.1776160742019; Tue, 14 Apr 2026 02:59:02 -0700 (PDT) Received: from arbuzik ([213.79.119.79]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a3eef071cbsm3208359e87.80.2026.04.14.02.59.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:59:01 -0700 (PDT) From: Marc Finkelbaum To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , Ethan Tidmore , Andy Shevchenko , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marc Finkelbaum Subject: [PATCH 9/9] staging: rtl8723bs: wrap long lines and fix argument alignment Date: Tue, 14 Apr 2026 12:58:33 +0300 Message-ID: <20260414095833.76480-10-regpacy@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260414095833.76480-1-regpacy@gmail.com> References: <20260414095833.76480-1-regpacy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Break lines that exceed 80 columns and align continuation arguments to the opening parenthesis. Affected sites: scnprintf calls in dump_chip_info, hw_chnlPlan assignment, Queue2Pipe[7] assignments in the pipe-mapping functions, rtw_hal_set_hwreg in hal_init_macaddr, c2h_evt payload read loop, rtw_write16/rtw_write8 in SetHwReg and rtw_hal_check_rxfifo_full, rtw_get_stainfo and the UndecoratedSmoothedPWDB assignment in GetHalDefVar, ODM_CmnInfoPtrArrayHook calls in SetHalODMVar, and rtw_hal_read_rfreg/PHY_SetRFReg in rtw_bb_rf_gain_offset. No functional change. Signed-off-by: Marc Finkelbaum --- drivers/staging/rtl8723bs/hal/hal_com.c | 71 +++++++++++++++++-------- 1 file changed, 48 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 2688355f9265..0e3b5831d974 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -35,8 +35,10 @@ void dump_chip_info(struct hal_version ChipVersion) char buf[128]; size_t cnt =3D 0; =20 - cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "Chip Version Info: CHIP= _8723B_%s_", - IS_NORMAL_CHIP(ChipVersion) ? "Normal_Chip" : "Test_Chip"); + cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, + "Chip Version Info: CHIP_8723B_%s_", + IS_NORMAL_CHIP(ChipVersion) ? "Normal_Chip" : + "Test_Chip"); =20 if (IS_CHIP_VENDOR_TSMC(ChipVersion)) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "TSMC_"); @@ -63,11 +65,12 @@ void dump_chip_info(struct hal_version ChipVersion) cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "K_CUT_"); else cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, - "UNKNOWN_CUT(%d)_", ChipVersion.CUTVersion); + "UNKNOWN_CUT(%d)_", ChipVersion.CUTVersion); =20 cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "1T1R_"); =20 - cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "RomVer(%d)\n", ChipVers= ion.ROMVer); + cnt +=3D scnprintf(buf + cnt, sizeof(buf) - cnt, "RomVer(%d)\n", + ChipVersion.ROMVer); } =20 #define EEPROM_CHANNEL_PLAN_BY_HW_MASK 0x80 @@ -107,7 +110,8 @@ u8 hal_com_config_channel_plan(struct adapter *padapter= , u8 hw_channel_plan, if (!AutoLoadFail) { u8 hw_chnlPlan; =20 - hw_chnlPlan =3D hw_channel_plan & (~EEPROM_CHANNEL_PLAN_BY_HW_MASK); + hw_chnlPlan =3D hw_channel_plan & + (~EEPROM_CHANNEL_PLAN_BY_HW_MASK); if (rtw_is_channel_plan_valid(hw_chnlPlan)) { if (hw_channel_plan & EEPROM_CHANNEL_PLAN_BY_HW_MASK) pHalData->bDisableSWChannelPlan =3D true; @@ -364,9 +368,11 @@ static void _TwoOutPipeMapping(struct adapter *padapte= r, bool bWIFICfg) pdvobjpriv->Queue2Pipe[4] =3D pdvobjpriv->RtOutPipe[0]; /* BCN */ pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0]; /* MGT */ pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0]; /* HIGH */ - pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0]; /* TXCMD */ + pdvobjpriv->Queue2Pipe[7] =3D + pdvobjpriv->RtOutPipe[0]; /* TXCMD */ =20 } else { /* typical setting */ + /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ /* 1, 1, 0, 0, 0, 0, 0, 0, 0 }; */ /* 0:ep_0 num, 1:ep_1 num */ @@ -379,8 +385,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter= , bool bWIFICfg) pdvobjpriv->Queue2Pipe[4] =3D pdvobjpriv->RtOutPipe[0]; /* BCN */ pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0]; /* MGT */ pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0]; /* HIGH */ - pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0]; /* TXCMD */ - + pdvobjpriv->Queue2Pipe[7] =3D + pdvobjpriv->RtOutPipe[0]; /* TXCMD */ } } =20 @@ -401,9 +407,11 @@ static void _ThreeOutPipeMapping(struct adapter *padap= ter, bool bWIFICfg) pdvobjpriv->Queue2Pipe[4] =3D pdvobjpriv->RtOutPipe[0]; /* BCN */ pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0]; /* MGT */ pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0]; /* HIGH */ - pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0]; /* TXCMD */ + pdvobjpriv->Queue2Pipe[7] =3D + pdvobjpriv->RtOutPipe[0]; /* TXCMD */ =20 } else { /* typical setting */ + /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */ /* 2, 2, 1, 0, 0, 0, 0, 0, 0 }; */ /* 0:H, 1:N, 2:L */ @@ -416,7 +424,8 @@ static void _ThreeOutPipeMapping(struct adapter *padapt= er, bool bWIFICfg) pdvobjpriv->Queue2Pipe[4] =3D pdvobjpriv->RtOutPipe[0]; /* BCN */ pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0]; /* MGT */ pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0]; /* HIGH */ - pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0]; /* TXCMD */ + pdvobjpriv->Queue2Pipe[7] =3D + pdvobjpriv->RtOutPipe[0]; /* TXCMD */ } } =20 @@ -449,7 +458,8 @@ bool Hal_MappingOutPipe(struct adapter *padapter, u8 Nu= mOutPipe) =20 void hal_init_macaddr(struct adapter *adapter) { - rtw_hal_set_hwreg(adapter, HW_VAR_MAC_ADDR, adapter->eeprompriv.mac_addr); + rtw_hal_set_hwreg(adapter, HW_VAR_MAC_ADDR, + adapter->eeprompriv.mac_addr); } =20 void rtw_init_hal_com_default_value(struct adapter *Adapter) @@ -502,7 +512,8 @@ s32 c2h_evt_read_88xx(struct adapter *adapter, u8 *buf) =20 /* Read the content */ for (i =3D 0; i < c2h_evt->plen; i++) - c2h_evt->payload[i] =3D rtw_read8(adapter, REG_C2HEVT_MSG_NORMAL + 2 + i= ); + c2h_evt->payload[i] =3D + rtw_read8(adapter, REG_C2HEVT_MSG_NORMAL + 2 + i); =20 ret =3D _SUCCESS; =20 @@ -565,7 +576,9 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 = *val) u16 reg_scr; =20 reg_scr =3D rtw_read16(adapter, REG_SECCFG); - rtw_write16(adapter, REG_SECCFG, reg_scr | SCR_CHK_KEYID | SCR_RxDecEnab= le | SCR_TxEncEnable); + rtw_write16(adapter, REG_SECCFG, + reg_scr | SCR_CHK_KEYID | SCR_RxDecEnable | + SCR_TxEncEnable); } break; case HW_VAR_SEC_DK_CFG: { struct security_priv *sec =3D &adapter->securitypriv; @@ -576,7 +589,8 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 = *val) if (sec->dot11AuthAlgrthm !=3D dot11AuthAlgrthm_8021X) reg_scr |=3D (SCR_RxUseDK | SCR_TxUseDK); } else { /* Disable default key related setting */ - reg_scr &=3D ~(SCR_RXBCUSEDK | SCR_TXBCUSEDK | SCR_RxUseDK | SCR_TxUseD= K); + reg_scr &=3D ~(SCR_RXBCUSEDK | SCR_TXBCUSEDK | + SCR_RxUseDK | SCR_TxUseDK); } =20 rtw_write8(adapter, REG_SECCFG, reg_scr); @@ -657,9 +671,11 @@ u8 GetHalDefVar(struct adapter *adapter, enum hal_def_= variable variable, =20 pmlmepriv =3D &adapter->mlmepriv; pstapriv =3D &adapter->stapriv; - psta =3D rtw_get_stainfo(pstapriv, pmlmepriv->cur_network.network.mac_ad= dress); + psta =3D rtw_get_stainfo(pstapriv, + pmlmepriv->cur_network.network.mac_address); if (psta) - *((int *)value) =3D psta->rssi_stat.UndecoratedSmoothedPWDB; + *((int *)value) =3D + psta->rssi_stat.UndecoratedSmoothedPWDB; } break; case HAL_DEF_DBG_DM_FUNC: *((u32 *)value) =3D hal_data->odmpriv.SupportAbility; @@ -701,10 +717,14 @@ void SetHalODMVar(struct adapter *Adapter, enum hal_o= dm_variable eVariable, struct sta_info *psta =3D pValue1; =20 if (bSet) { - ODM_CmnInfoPtrArrayHook(podmpriv, ODM_CMNINFO_STA_STATUS, psta->mac_id,= psta); + ODM_CmnInfoPtrArrayHook(podmpriv, + ODM_CMNINFO_STA_STATUS, + psta->mac_id, psta); } else { /* spin_lock_bh(&pHalData->odm_stainfo_lock); */ - ODM_CmnInfoPtrArrayHook(podmpriv, ODM_CMNINFO_STA_STATUS, psta->mac_id,= NULL); + ODM_CmnInfoPtrArrayHook(podmpriv, + ODM_CMNINFO_STA_STATUS, + psta->mac_id, NULL); =20 /* spin_unlock_bh(&pHalData->odm_stainfo_lock); */ } @@ -754,7 +774,8 @@ bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8 = *pInt) void rtw_hal_check_rxfifo_full(struct adapter *adapter) { /* switch counter to RX fifo */ - rtw_write8(adapter, REG_RXERR_RPT + 3, rtw_read8(adapter, REG_RXERR_RPT += 3) | 0xf0); + rtw_write8(adapter, REG_RXERR_RPT + 3, + rtw_read8(adapter, REG_RXERR_RPT + 3) | 0xf0); } =20 static u32 Array_kfreemap[] =3D { @@ -782,19 +803,23 @@ void rtw_bb_rf_gain_offset(struct adapter *padapter) =20 if (value & BIT4) { if (padapter->eeprompriv.EEPROMRFGainVal !=3D 0xff) { - rtw_hal_read_rfreg(padapter, RF_PATH_A, 0x7f, 0xffffffff); + rtw_hal_read_rfreg(padapter, RF_PATH_A, 0x7f, + 0xffffffff); =20 for (i =3D 0; i < ARRAY_SIZE(Array_kfreemap); i +=3D 2) { v1 =3D Array[i]; v2 =3D Array[i + 1]; - if (v1 =3D=3D padapter->eeprompriv.EEPROMRFGainVal) { + if (v1 =3D=3D + padapter->eeprompriv.EEPROMRFGainVal) { target =3D v2; break; } } - PHY_SetRFReg(padapter, RF_PATH_A, REG_RF_BB_GAIN_OFFSET, BIT18 | BIT17 = | BIT16 | BIT15, target); + PHY_SetRFReg(padapter, RF_PATH_A, REG_RF_BB_GAIN_OFFSET, + BIT18 | BIT17 | BIT16 | BIT15, target); =20 - rtw_hal_read_rfreg(padapter, RF_PATH_A, 0x7f, 0xffffffff); + rtw_hal_read_rfreg(padapter, RF_PATH_A, 0x7f, + 0xffffffff); } } } --=20 2.53.0