From nobody Mon Jun 15 22:03:51 2026 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 596A53B3898 for ; Tue, 14 Apr 2026 09:13:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776157996; cv=none; b=LyTnvplnpRuU+YD2wP6I85IzzVVt+txHMk+swsMts6EdpElHUiXrOCYkPifuIzXXr5K7mg2twJr0S67yBwxAbu2rPzP9J9/LerbRimsQBEmE2DqyJGpN/ek5GuOmO/RYQaOZ5TDP+EW6LOpw+EfFzVgM0ZsObGEPo+vDdoV2Ecs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776157996; c=relaxed/simple; bh=RzEL6YecJLWxbFnpd/tO+rbow5SRmVdpl86aYOarnDU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aEPYn8AlKW1wrHrN4TB0wjSHLqWd6B9672G1Ls0k/Oi3aMC/VSe7XczPeFuqXhcP6fZHTo4a0d101Rwdoeiv9CpKy41i4ECHOi51jfjiHTQ2IsvKcYR07sFO3jwDDBIyr9ABemjbopohBicBeUy5QLUV2Dq6QJQLTYLuejFmTcA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P+TrUDM7; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P+TrUDM7" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b9c04152730so805863566b.0 for ; Tue, 14 Apr 2026 02:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776157994; x=1776762794; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W/UqgvYl0+LgOmppPltA1iiWZIT64IsidcStLZbzccQ=; b=P+TrUDM7Sinnj5Z1fP2/GT94S1PFlng0Vb2rDnxzi5UAAca7j4aJLvc8qp6VaZ0o1E ZIRPzvY0h3voLv7Hl2YmNN/OcCSBzyfIQijiinWDVaPBdb8G7v6ah3yMLjBz7IovP77y VTGIjnZ0MLj4tYS1aLbt0tMUYjtUR66P1A9kri7zUqYKO4watjiZocH7kOq3M+dqfE9u n3NQmG2hPguQvf0NPosHt1EhQas1ALeCexLActdVdsA3cOt1Bay47bb1Y1uG+Nvkjg2K Zs2UhSGE4t6buQJI0utp+Rve68FWBeyetKwLFv9sELy850YhuUkcgV5Rx3FjJf2hHUla iooA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776157994; x=1776762794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=W/UqgvYl0+LgOmppPltA1iiWZIT64IsidcStLZbzccQ=; b=TUog8aWRWsxrcfUk47bT+7JzkD1oIUHVplO/iDaG1Eo/tu2gICXGULgiyLk0y7xgGA i7PNYqs5bRbbCsftpKTo7wWfCqGA//wu2NO92UCPz2oBekpuu1w8JcifebMS52Vb4lvB qPN5+W50P9eIw1EI0bAf62+IQrJsfz/x63XNQkduIeVJzAUDs7sZvzB+TtcQedH3uSRA uOFDOcRmEPOJ2iPcKeMXu/b+6AKfzd+cXf6c4saVhijRJhcc2UZO2bdVtAasxjatRx6l g2AY8qqF3gNyoMteqqT74vvxOEuLLqhnJeWdWIl7i5IDd3hZkC0WLFnEczcRVsNQt0+/ bTCQ== X-Forwarded-Encrypted: i=1; AFNElJ9i05ljAEagajmpqbukVk5CFN4bC0K9UY7gI1lVvRBEuZQD064+qr3WFCgyx0WN3QkxLGMaUcCUOXswzfY=@vger.kernel.org X-Gm-Message-State: AOJu0YzffswRoe6VxDMo39EmA+RM7WuDftaLDTHXUrbh7eWQNFKXxoEz oIPRCyLbs+jyxbvUCY5tRJ4iA/PbCoRj8OUnIKlbUVFJJPDamqIa8F0I X-Gm-Gg: AeBDieua0y8+9Q9ezeqAi5kv3i2nT93i37IZgJseZ63FWd9qgVFY983tdeFINEDRAd7 wi5QmjqlQ1SXYrrazAnlYkTgN3IK4FfxQKM5vEJfqgO3kVkNLcezfNzOtLW22EDR1jayf41eJtY 5H35zdzaG0kx9pD4y6ahQR9JXhLLm4Arb9W8zgBreFVqYxP9dX6AQFqrrENCbys+nb/fQ1J6koA v9Y0fuR6xi/X5ha/4m8Vj6AOjPIYNcjJsDXt6ukXuhE6VyDhLlS8TnjOG7l9FXQprAOiPCaPH8G 5cchovi2ZKGHPaGfQFfBtSm5KmNcvpFaiX4FyyVpwjQkuZ3RQqEsdp5zwGQsV5uvDfkIoiR/8qD KpdzjT/RCJr/YujPcyenxJnwiEsvk718OJ17tKJM0gw2nLuhruwq7u8SPIUPq264C4cP/mLpPDt mgK9W25jh0smlVzsX16Ynao9wui7wkM3gjUiPMK6oj8iNSwJtEXf8HQ0jze9b444FMss4oZtRq5 tyQaqLe+FccG+StT2BrGBeWtPHV1uFM73ILnP5YPsQl3Ppn+c4oK52uAp8ZFSXoChruK/uiShHD shfzmLFv2LTQeykMI9GXJkFlJHx/3EnGmns1fErdBW3NIkDVzNhnOXfGi/pkYqTMTcN6pWAwQyh nhbS97DyJkjJWeo2r1+AIskmgyTDFENjSo4jEyf9Ncq88vrdsIt8JYLZCw8Q2YhXPgI5uJ2Iix1 0r4WnW1SM= X-Received: by 2002:a17:907:94d3:b0:b9d:6483:6711 with SMTP id a640c23a62f3a-b9d7281491cmr945606466b.46.1776157993612; Tue, 14 Apr 2026 02:13:13 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-b.c.od237066db22328bb-tp.internal (63.152.141.34.bc.googleusercontent.com. [34.141.152.63]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e7c8a44sm384466866b.52.2026.04.14.02.13.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:13:13 -0700 (PDT) From: Joshua Crofts To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Joshua Crofts Subject: [PATCH 1/3] iio: frequency: ad9834: clean up includes Date: Tue, 14 Apr 2026 09:12:48 +0000 Message-ID: <20260414091250.1295-2-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260414091250.1295-1-joshua.crofts1@gmail.com> References: <20260414091250.1295-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Clean up includes by removing proxy kernel.h header, add bitops.h header and order includes for better readability. Signed-off-by: Joshua Crofts --- drivers/staging/iio/frequency/ad9834.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/f= requency/ad9834.c index d339d5e8e0..eed4e08920 100644 --- a/drivers/staging/iio/frequency/ad9834.c +++ b/drivers/staging/iio/frequency/ad9834.c @@ -5,19 +5,19 @@ * Copyright 2010-2011 Analog Devices Inc. */ =20 +#include +#include #include -#include -#include #include -#include -#include -#include -#include -#include -#include #include +#include +#include #include -#include +#include +#include +#include +#include +#include =20 #include #include --=20 2.47.3 From nobody Mon Jun 15 22:03:51 2026 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D03563BBA15 for ; Tue, 14 Apr 2026 09:13:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776157999; cv=none; b=tuvSatTqXtpyntmVHtnKECkT9TwhTMv3juLphhGKUJPkufCH5YB9n7chgaKkXI8laOY2iaz9VnJdM5GL42y/4npd8VvoZhsFJfC6c4HFl1043Xby9gOT73O2JCmFqMalGu2uY4xAcHiNHfogHGnYACtx8u6WCJOz5Vj/R4L5a9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776157999; c=relaxed/simple; bh=EvacC9LihmYC+Bhnd8QXaJhFbVwPcP1wyH9ZW1zD+RA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gHaUD6V25Io1NBzHlkwFheamHZ5iZLQr6ZZALlcXVWUqXlRUF3EwGSZqPmzwtR3OzCSbK0iv9GOLnFEbJHRJP5xAL3zXgyeQnFKQ0S4SXMm2BUcBz2ZxDX1kY96pPIIlZ5ldaQEuvnk7nP4hGOcvB9VTyKTIgUjFVhO7m9rEmfc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nwlY1oN9; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nwlY1oN9" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-b9358bc9c50so695546366b.1 for ; Tue, 14 Apr 2026 02:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776157995; x=1776762795; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jLmOOVSobQdxpdV2CxzDrMXixIXpcrGizwFUI8g1ioo=; b=nwlY1oN9Tqt+LzCPmCACkGzekJKJ844VF9D7BC44LL2lwXR9sqUf1JFNO3ItU4uAto rxdUt1geK0VcE70XL7sVvQchcSXCJdAsMICtiKGaPaImo7vcfcg553V1Q3U90JPZDngg 1R6GBvut0IT1J0KyCa8NyndxhuXq2Y5xA0JVizDkvT/TjmEgjmhr6DO6fu1sWDzh+zr+ HleBggpikQkW9KfJZwuJe993myuBfuzvfgn8EinUSZzcAJi9zmJ5Pl3fw/ZxbpUXGH40 z3Uri58MtgM38OjKkxiBAx3rRR+GHgkm/2PtuLtQIFJLHZs9eFApV9o3HVtA1wgmEZpf gbdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776157995; x=1776762795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jLmOOVSobQdxpdV2CxzDrMXixIXpcrGizwFUI8g1ioo=; b=rJrj4ED9aEBh2aI/I8puqPLm1awEyQnOvWCxCJc5NXM3x4D+xdm6U3i3K+1MEGQn4T d3rnngj5375yWxZpnaPunSozV+tMtoOBs9h583fS8Huk0eB041mw6CgLrRDB46VzJqEf yax2PwZz2y0dJhy6soFsbckX4ICa4+qV05uid4JTQyFRNdiOHfvd4I23KMDlKsfp4n+O R2ebLtrE07Gix1u46mTc8Bt/aU91UQnMr4jTS3w4FG800hCSFzV6z+THnsX6tx2Ifpzv czlwKM93JH/2oi/w3Ypd2+hLauGopQegf4FGgOnN99VlqVbXHZh1zQbqMdfB556BxgY+ eimQ== X-Forwarded-Encrypted: i=1; AFNElJ8weHbnZ6tFcUvGypEKW6wo5oPH3OVFZ7m+4WOJNEmMwUMrnvBOtzSWNV1DfbnGE09OoWsVlG4CbGglXZw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5XaZ/jSxv0wC3+8a1Wt21hSIvelDEc+693QFMqWodeqxqjoJE hztzK8TxjuB7q0DHa4Xz+s35OU9eU/vif21Y0LBQwH1ZS+KDNxe2pN1b X-Gm-Gg: AeBDiesnJsQ6lqSiojk0XxkCbKWMLt9DGtYeTPUfkpeCiAZEkc78djhF9Zl21W8Strc GcpYYKI39P4iLe88eSDOF5pknehynL2HZzESrUkIz5U2u/Z7sSlJHQzM4C7H8waiuFYaqwHYX9r OD6sstPFd9HssoekgKRa7lFuBzSYlLr212hZ3ChVuP0bSYMKZOYEBAyfEPAz7lwZW1h3RoBFBeq WONF1RPGGXTfcaQtv6GQVYBFz5H8ImKSmZRRZhy+1WNMnwV93IV5RqkKbAR9zFpUOZX8dplmKfg if+/wH/SE/ZyAS+dF5pGhXW26GLsJAIurTh/Uu98GQ5m80fd+k1X+2hQIvfy+OTXVKGUeazmz9g TzGPtFi7Ks9XAIiOLecCUC+lmWlYCoue78S+N5mNrUwR5j3GL6YEnE+1kAPLFItJ95sEvzeOSrY do0Xw8yvXH+J07vmG4hakPCJg7BDwKeTiJ69/jRviNUl/vYaSv22cOfHU3pjKTqUjaEx6Vb3Tv6 dA8NNC1lHNu28/RjEp5TO6kVdgyqFnodTNdurlff583YZDktZMvE4sOzGvDVpsO/o8JegOv6BKc zk5WSY3Th/f0/TimPqn9opsTLFvgxISKJnhEz/5uLwD/X8V9funJFh29yA3WyvU/UPP8a9wa3Qc 0zzPKSNwflVxBgBPK9yHYBFAlZb7L0GKjgraV84AJFIXRfJMnWTxzwCJENAjo7kOMcPXcT45W4K iFbuuPJHc= X-Received: by 2002:a17:906:fe05:b0:b88:6164:6421 with SMTP id a640c23a62f3a-b9d72495353mr915644666b.16.1776157994816; Tue, 14 Apr 2026 02:13:14 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-b.c.od237066db22328bb-tp.internal (63.152.141.34.bc.googleusercontent.com. [34.141.152.63]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e7c8a44sm384466866b.52.2026.04.14.02.13.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:13:14 -0700 (PDT) From: Joshua Crofts To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Joshua Crofts Subject: [PATCH 2/3] iio: frequency: ad9834: change sprintf() to sysfs_emit() Date: Tue, 14 Apr 2026 09:12:49 +0000 Message-ID: <20260414091250.1295-3-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260414091250.1295-1-joshua.crofts1@gmail.com> References: <20260414091250.1295-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change instances of sprintf() to sysfs_emit() as returning formatted values to user space should be done using this function. Signed-off-by: Joshua Crofts --- drivers/staging/iio/frequency/ad9834.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/f= requency/ad9834.c index eed4e08920..9499e05a73 100644 --- a/drivers/staging/iio/frequency/ad9834.c +++ b/drivers/staging/iio/frequency/ad9834.c @@ -290,7 +290,7 @@ ssize_t ad9834_show_out0_wavetype_available(struct devi= ce *dev, else str =3D "sine triangle"; =20 - return sprintf(buf, "%s\n", str); + return sysfs_emit(buf, "%s\n", str); } =20 static IIO_DEVICE_ATTR(out_altvoltage0_out0_wavetype_available, 0444, @@ -310,7 +310,7 @@ ssize_t ad9834_show_out1_wavetype_available(struct devi= ce *dev, else str =3D "square"; =20 - return sprintf(buf, "%s\n", str); + return sysfs_emit(buf, "%s\n", str); } =20 static IIO_DEVICE_ATTR(out_altvoltage0_out1_wavetype_available, 0444, --=20 2.47.3 From nobody Mon Jun 15 22:03:51 2026 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 028FE3BE145 for ; Tue, 14 Apr 2026 09:13:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776157999; cv=none; b=L8+W4EU4Ad0cZfiI4lxVcnSo9Ny0qj34NOqsbXGSS3r7/sbVpskQHAao1h/5sO5lNKH3If896YvH7Tnu6C3hNQdQdtPpyyxQEOoEEB97jMMUZoKMtE5jmrU/rrkUf6dqEacskOr9KjkGETuRsmQSC7PzGL1RkHDebTMGtbtcPcA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776157999; c=relaxed/simple; bh=DceN/1FY5sfDaFKgfd/7xWB7OmyeTAAniEbTxPCaqG8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rA2CEApxIzrlUJ1U6SKJfu2lH9Eupgl0huMTO8Po6on8kZ3IiRbV7oMngU+dwv4/CuGYLOWCRdnqBDHnmqpvXD46QR0j3wnyV2XcHZWV/ct+Af6e8RNyIwy31g1w4JMtQ7xO287iNcfNGwe7X7z8LVJUL23M/xrMOMg7+RA//9Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q8ZZfIe0; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q8ZZfIe0" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b9c603ec2dfso715552066b.1 for ; Tue, 14 Apr 2026 02:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776157996; x=1776762796; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UmhA9XrEY3SaezkYYH4LWBg56vYjVuHTXXG+8AA87cs=; b=Q8ZZfIe0FY/PXsvMFW7IxAIXjiKieI1x8Ok+U5UIYbF+J9us1ZeBnMxLvbP4yTTwPU bdgWS7Gy8kx/1xfpPlqVgxzzL4dqYbd43A/LgaQ4zF6l5sMcQDDlHk7bLDVlUuELs3mG 6zrOcTu30Ox1yZu6tcZCung6swzouAmpruR7W6jJbj8D32SBACsDwgw404c+BtNGYdgs pWyeglDnKjS6hh5ommNseDKWB409v0rqIxRmeDReV46Q9guMosCbe33sgWYEsQ+XEscy Kg84nTjUwPsxJbwi10jY0C1orDJ8Rlah7OajROpjXMGkDH+Prw4MO0V9hIOWQd3jhpuO 1PfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776157996; x=1776762796; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UmhA9XrEY3SaezkYYH4LWBg56vYjVuHTXXG+8AA87cs=; b=gESX7knLyztb3nirAKgsMkOeD1ikBg2obMm2+Qg5TmjDqg5vBhMS+NMQEsU2hraawf t45akpxxh5LonVKcGf+KmuleI9cvPvH4EHdXEcNoyCqH9WkGqMHY25mXn7oTd6JNA/Fz A9cYMokhU6HGUzqX+IrBho8xqysObQqTb40dokN66pX4c5wZqs58KZ69BclsmfpNPER1 N/jtoMIPEPEbqCAJ23yAPXNmFg+u4j3RSWivT7n1W0nhVXFD+GRMrWej+Xe4L80xZEUn HFJoUPxeLntTEjci3v8wwMKnwMCZ+dOHU43fe+g6BSuc/9SV0hNkEchAieSj2H2VcpVG hJrw== X-Forwarded-Encrypted: i=1; AFNElJ8+MjhnSWu5+G14/AIXs5jlLmXA1m1wfYs/7wh965jF0Sh3p165oKkUTp3O5DJy+Oapbppl+ynlUpfSUL8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywjy58iA+j1AVyV/hFL6eB8591uNhBPhosty1cLxqSTLudgzJ1/ K3aSkUi10jOqu9+sPajULOtUfVM1kg4pT4yk5Dwy3Xo6OU+4qxZV3boP X-Gm-Gg: AeBDievJlafLq0dsKxER/y3cbM9AqH1SMy4uRkwLenLFDo65fhowHleNF69G+DTQt3E dWMhGrrBQ8mz4/zcLrBbrtuy+TYzzliZhxXTQQ7P6UklsEf4uYOFC3zaTChKD/Qnbywwt/f36lw CavVZHYHex6ekvkk3zMZGjDw6Qtn/u0MiVA31yQENd9togmjjPbwQmSB8pAzpUcqVEFmfiIX77y 7BSax1N3OWLkeeg7W9QVf03BZxVRQhRviPJV1LyJ101Yrq7Gc3DSbJ99jqWbdcHfIAmzmXLLoJL lZNxEu3XMm7jQ42ZT1vyBFIeZ+jOvKB97OPXyqlHQDtePFyQuGfomp/+7AKnYhqKPrpRov0uKy8 VMpOnw5IRZkZsi5sO2tXLIfilh4T4VukZSwPXvQTvjcBt7/Yqw30NwoP8PTcB9enMvZLSKN8/Rt DqGvTVnUWeJgB6Cj24ISiL+/YC2L5A/79LSgYTkuL+DmUS2fzWcLRKhHYvgKFVthEhvURUW14O6 UgCKN/ca5DWl77zoYC9fZFJF/zSPFqmYXl3OHqlaIGl0Nt1xxegJeFSfKqCLHBkKFePP/77KRII TocX9k3JPhEzP6RuWoErIHmnBxOl0KT7zyGML+ZZwLxU9+/nmWTYUe84eJkDh4MkDOmg9by7UMr oXw/fthf4VtVCdy7RfVFVzDXskS2WxfGgev9b0iCohj/EPQGjlFla6GPWUldYODElyHBNbAQBTR h5mU8aMlI= X-Received: by 2002:a17:907:a28d:b0:b9d:424f:1d9e with SMTP id a640c23a62f3a-b9d7298fffamr993970666b.34.1776157995985; Tue, 14 Apr 2026 02:13:15 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-b.c.od237066db22328bb-tp.internal (63.152.141.34.bc.googleusercontent.com. [34.141.152.63]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e7c8a44sm384466866b.52.2026.04.14.02.13.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:13:15 -0700 (PDT) From: Joshua Crofts To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Joshua Crofts Subject: [PATCH 3/3] iio: frequency: ad9834: add mutex_lock() when reading st->control Date: Tue, 14 Apr 2026 09:12:50 +0000 Message-ID: <20260414091250.1295-4-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260414091250.1295-1-joshua.crofts1@gmail.com> References: <20260414091250.1295-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add mutex_lock() and mutex_unlock() when reading st->control to prevent data races as st->control is actively modified by sysfs _write and _store functions. Signed-off-by: Joshua Crofts --- drivers/staging/iio/frequency/ad9834.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/f= requency/ad9834.c index 9499e05a73..33570474c4 100644 --- a/drivers/staging/iio/frequency/ad9834.c +++ b/drivers/staging/iio/frequency/ad9834.c @@ -283,12 +283,14 @@ ssize_t ad9834_show_out0_wavetype_available(struct de= vice *dev, struct ad9834_state *st =3D iio_priv(indio_dev); char *str; =20 + mutex_lock(&st->lock); if (st->devid =3D=3D ID_AD9833 || st->devid =3D=3D ID_AD9837) str =3D "sine triangle square"; else if (st->control & AD9834_OPBITEN) str =3D "sine"; else str =3D "sine triangle"; + mutex_unlock(&st->lock); =20 return sysfs_emit(buf, "%s\n", str); } @@ -305,10 +307,12 @@ ssize_t ad9834_show_out1_wavetype_available(struct de= vice *dev, struct ad9834_state *st =3D iio_priv(indio_dev); char *str; =20 + mutex_lock(&st->lock); if (st->control & AD9834_MODE) str =3D ""; else str =3D "square"; + mutex_unlock(&st->lock); =20 return sysfs_emit(buf, "%s\n", str); } --=20 2.47.3