From nobody Tue Apr 14 14:10:26 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56A5B376BE0 for ; Tue, 14 Apr 2026 07:16:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776150962; cv=none; b=eIucBDUpb8u2zcucret7zzHeHts21b65M+NsXIxSpoRenvgB9YVDMEetCKXDt4xJm6No95qUC1K/V8DhZfeeixkHgrsfUM88xfW0rGi72jaU1HlUqKABSOMFWqauwUtJNi/KPOlQ4p3zmrG9ikn2i416pCaRsBPnTMxj7WfvZRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776150962; c=relaxed/simple; bh=qFwsjCRrtTYd0GU5DWUfNnt76kyBmYFPLCN06AmYJ88=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RentEQomoWT0AmOkIsn1biM/I/PsynKmtuOwovZKu9p5IO6++W9kRIhEclP4Magczvypdy/KY+qQPFygiaDxwc9bWoDiVYminhqgIKVF+zfxZxA/mEhFEx0wf+sVgHjkYYDK3LDPq/k21Qq2woyk4KS26txrzniK0J3y6taeq/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=s6WRU+h0; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s6WRU+h0" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-82cd70febc7so3529256b3a.2 for ; Tue, 14 Apr 2026 00:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776150961; x=1776755761; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SvRM8PLxKjdW4f9eCSeiOBrLICFjHgClb1f/sadWYR0=; b=s6WRU+h0LNJEvyCWcjdfdouW0l5a7xQD6vv0FsukYLnJV6tOnTS3YplGUiMptiZ9bi NOcBeMoEc6zoq767TqI+PxeDCgg6rYbDzSKcSHGWwEWr0YsYVeCIPK4OCJ2V1T/G87Mn HSge6UQ6HxhDBLISwkPMGeT0VXD25lG4wSt2igzcA3NtUDLZWO9Pmzo5XZ770/8MyJQX QDCINjdQNIGFHXDKyUyFmuW509lYzPArks9gMboDovEEfptGUi3yYesvITE2VW4mY9ZN fZOyXQkVbRvoYb0hCBiPlYEFR4tNA5nMPhG2IfPeqJ0HrDeEYN1ixuqdlnS1vxjqRRpb sDlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776150961; x=1776755761; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SvRM8PLxKjdW4f9eCSeiOBrLICFjHgClb1f/sadWYR0=; b=d+Wvhfug8QBSw4YPt/BvfoX91f/Bvcj/4HpewwP6NLmYXNBOWHsR9xVqnhx2GXRP1f MLPRJ3/+DwQSbMiccx3LXqeLUqPUkOTHsogCH0TRd1j/dKX2MzA2OCJaVPgFkHZNlwUv 0aF06tsTq3xKocs0dchQAz91IPY4JUEdz3uWvKDP+lefS+WJyvR3siDVAUNh0a1uY9AJ D9Z/JP/EPNy55iULF5zHMUFD6Af/FHVOnxB92Yc8c0dw3cL+QG7uZ71ousAlJBzc/xuj VSDMBP9lof3s5JSn4D5t0LrkjwD+3Gx0VdJ9+X5ECj4C/8CGhW8Cdr5g5zyoGcrwWR5r WFcw== X-Forwarded-Encrypted: i=1; AFNElJ8O1Srw4yf5y9035H+xlPPaA29koqPzJKxijq4baq1cRgtC+eAYZt8wQHErvNjAHFl3c2TVPL2XUwX6tIk=@vger.kernel.org X-Gm-Message-State: AOJu0YxzIUffQz497Oo8yDrUMVSJtW8CtIyI+C77W9xBD9ODVSkUThty qvF9gNvpMoxlkw1iOHWjW7MaQwcjmepXC2b6t+7WW+MZ/I59W/5hY37BOUGjQQ== X-Gm-Gg: AeBDietK5Zx2fiCtqmKgwtk/SNGQZZomfDftIxV2AH0S/qc6pJ5YbMYcjRlS8TgBNy7 cgRLi0izdjZW3WHm5JQlEWcUvqMksyAF4EofQsCAv6JaEo+L14sE+eRpwqH2SSbDzzIQhJpP7Mc J4FSvLK72LCS7CT3QxRrRq0S2fva5KciWPOw3x0GvpG0P9hiVH/G/PnrG09oghaatP1AerKM6CK HdxwW28Twv8xQ1wYcqIw/1LNQWh6DcyjDY/Sxd4VW3+o3uEItpdJrHhr1vYf1Gnohz9MsEAy5MR msuihVUKwTf16LDsaYSzbHhIL0c/7fRivLBXEaYg5JWNjr5gRwIrL37YGxJTykJlCNWgKM7UdY6 oHPf6iWkb6o2I378nMWxBKjYMHrUSAqmOpdk+I9/ph1XMXrE1B3GQi+S4FzF+gVe2otVT6TAOL3 +YDY0nx/+M29HlveBSKFlW+k6R7AHXu9KAiWnAVro0uY+0JxaLC4EwEdOIREFDoTh0rI0ySP93O Ucm39h77+qvkm5R8V8wMWk= X-Received: by 2002:a05:6a00:2d89:b0:82c:20ba:1570 with SMTP id d2e1a72fcca58-82f0c2a00abmr16683140b3a.29.1776150960723; Tue, 14 Apr 2026 00:16:00 -0700 (PDT) Received: from shyam-VMware-Virtual-Platform.localdomain ([223.181.118.203]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c50cd34sm14062030b3a.54.2026.04.14.00.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 00:16:00 -0700 (PDT) From: Shyam Sunder Reddy Padira To: gregkh@linuxfoundation.org, ethantidmore06@gmail.com, error27@gmail.com Cc: nayana.mariyappa@gmail.com, s9430939@naver.com, andriy.shevchenko@intel.com, kees@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Shyam Sunder Reddy Padira Subject: [PATCH v3] staging: rtl8723bs: os_dep: avoid NULL pointer dereference in rtw_cbuf_alloc Date: Tue, 14 Apr 2026 12:43:06 +0530 Message-ID: <20260414071308.4781-2-shyamsunderreddypadira@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260413224417.5674-2-shyamsunderreddypadira@gmail.com> References: <20260413224417.5674-2-shyamsunderreddypadira@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The return value of kzalloc_flex() is used without ensuring that the allocation succeeded, and the pointer is dereferenced unconditionally. Guard the access to the allocated structure to avoid a potential NULL pointer dereference if the allocation fails. Fixes: 980cd426a257 ("staging: rtl8723bs: replace rtw_zmalloc() with kzallo= c()") Signed-off-by: Shyam Sunder Reddy Padira Reviewed-by: Dan Carpenter --- changes in v3: -Shortened commit hash in Fixes tag to 12 characters -Removed blank line between Signed-off-by and Fixes tag changes in v2: -Fixed spelling mistakes(dereference, potential) -Added Fixes tag --- drivers/staging/rtl8723bs/os_dep/osdep_service.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/sta= ging/rtl8723bs/os_dep/osdep_service.c index 7959daeabc6f..4cfdf7c62344 100644 --- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c +++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c @@ -194,7 +194,8 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size) struct rtw_cbuf *cbuf; =20 cbuf =3D kzalloc_flex(*cbuf, bufs, size); - cbuf->size =3D size; + if (cbuf) + cbuf->size =3D size; =20 return cbuf; } --=20 2.43.0