From nobody Tue Apr 14 14:10:33 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 255C030E0FB for ; Tue, 14 Apr 2026 06:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776149542; cv=none; b=a4Zxzdl8hjIKqOima63ssFeH94HAfSWURsnHr6SMaO6Nf6K7+IBZOp/8tipuzXyu1d/ndUAgcAkd+fCTs3mFpaM0fLTRoFLtTH08S0MA9fd8Cerlv+6YT/hoa0G5wmqcOS5B7wjofdLlC4QZpRmfzu4X+aF2MjcESR/JDirI860= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776149542; c=relaxed/simple; bh=vMVlmN+3MPUtn8iSuHRsgvSPszAsXgfwV4er7Ps1Iqk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=bwZ3VX58rMtvT3IVpMzmE2LF10KVZTkzlXnfDumPTJbh8eCUaYpPDolZAJFHYnhe9B0zVAlxPCskcouMmGXb0bfmltpqZ3zQiE+RExFbuV1TsH3+u1zup0lenJSdHMQ7Srq6Ro2uKfb18X9zG2Kz6KMAfzJ2fVs5CnIEsbOz9Ug= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A0pCNWU8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jyZCbn1v; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A0pCNWU8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jyZCbn1v" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63E67IY22633547 for ; Tue, 14 Apr 2026 06:52:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=/973+ADhp7ja1pNXUALB1jgQRlOkwMbLVxA BVyNMYms=; b=A0pCNWU8PsEsJKGtzBXulmNPL2WjYWXOyLntyBOjrqNmO2z8Xe+ GmS0Z4nvXh4JK810Lsf0Eqv1VkiOTVkGLjcc0ABFf7qEtwtyFyrkGM5MqWR67zKo ICXk4xHzKVRIKMA9hoRH+T7mot5kjwBh5xIgPU3JFyojttCN1ob9HDk1ade44E6u S8G0p7y8JtfWr+38Qh1JxUc5ZdNW5Wn3OBE5lEKUzMtL+c4FMj0Ng4/f05v/eCc/ e7tXk2Mt7IG1WXu+gUPNZWeTicGg3ZigivosOczy02XjexgWNFO9XRI6EHhxv2tr Dbnw+/uPPxyMfYSa5Pm2m50/ov1n57SLuig== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh86c9esm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Apr 2026 06:52:20 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c709551ec08so6665823a12.3 for ; Mon, 13 Apr 2026 23:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776149540; x=1776754340; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/973+ADhp7ja1pNXUALB1jgQRlOkwMbLVxABVyNMYms=; b=jyZCbn1vcvIFJXJqL1DT9skAA3aG7cyIcmT/6e38+lLuJ8liGGUg2CjlRUK/9R0SML porxNn2cpwhgFyA66IHqG6EaU19pqnHyH/JDuCgbqHeQKLEDUCVAtaCLzC+DxtYtwGRd Wqd0xOvxamDQme8HTfCJTxP2sIULRkh+Z9PQsUKnJPU5vJPcGg401bnw3ZcAnTjETQkr Diav8p9rqdZFtAsKM0XDqefYEK/OaAcu6fC48hlkBI3ckI6gZMmL5lVXY8kdf6SnCxMf 4RbgiqIeIS7r1bvSmygN7viYDEnWQOUvNml5D2SHnCZn++sA5DDimPRgONSAZtIZ/bwE c/jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776149540; x=1776754340; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/973+ADhp7ja1pNXUALB1jgQRlOkwMbLVxABVyNMYms=; b=Xhb4nobnEndfuJBxIZEiZ41nNzDQKSaxGA7pKTly4/w0Y1jC0C7+oXE0zbCJHca7MM pjshfdRZxCKQlESZAs1+5lRLqc0uJ6Hnvlbpgiozv6SyCKrBt1PVDbNjo5hpNs+cFaW8 DsUqfNvInukIZhP1SlcpW6URGw/4FFMZDQaJ3D+ALAb0XKxXJS3+UWkh1wGZ29pBrOHH 9Wl1xhl8101csIthNZvRnSPu2cHhkPjXPwq/t+gqu8n/cYAookSuJkUMSV5Z/5icUpMH 6AxtWiq+wOnVALEpSiHZJjBmqEJbGruIt4fw9UHgDkZhmOAXI7hgWvggvcp+o1d3I635 pmow== X-Forwarded-Encrypted: i=1; AFNElJ8B/JOraj0ZfYJZT69Z2MXUNnJQwxeIexmYTSYuptbOCcQ+eIBbhbnQ8S63LyO7nmRG/TvosLt/AGDLwYU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxo7iXQuNjofGYe76EsjZfi6WIkJyLGIBA+dNllWoURd+ym+90l dpdwhvz+l7urfeWaDrhmHiT22+MteU15TbK34IGpXQVFN05EnM41wHZd0M0rE+RRHazjJMM++P6 HVD7PjZ/08fyGvUWQba+H9YMw3TNtAOFuLP7chgAZxufiPvma9r7P1Fc4l6cC5IztWQk= X-Gm-Gg: AeBDiet0ZRrmyDYQjTCDpC/yz6POm9Q9mVZHcJsTWcUVlEbF9Xie3omvIdb4ya/NMtq v6IoYoPPXokPihxHAb2ZjATq5EJg096B/gUj58Al0twensqTysv6JmCP74v3wU8dYLBWIJymVNK mx23GJelwyBmvi1XCiGvdPhxxHtPSaIxqzWWXvjUZcZi7+XkEKpfrVdpv/63ne4koiqFk6i3NOD eyGhtpfjeXKBYytINdDZeIcNJty+cqFsNH+emsM8RWVFjN5Atzqcg8mgV09Gh6sZHh08cGm5wAd ccyM+8BA5vk48WIo0D0Wdn5uGOu7WhnENlJ6Rjm/+6Lbla3EdddqJHSmp6tQxUukYMaw7i+rXU/ AzrLm4dF63RF2cqFumquDfVkSxTIdsDtcX5GahXPvRNZ8gSUCriFyZ2ZCzr1+BCjlt4yTqGCQ04 gtoeREtcuGnWV3rF2xaPTRmWDKBMUgpaLjbY9cVdY= X-Received: by 2002:a05:6a21:3286:b0:398:4a1f:8a54 with SMTP id adf61e73a8af0-39fe3c91219mr18171355637.2.1776149539713; Mon, 13 Apr 2026 23:52:19 -0700 (PDT) X-Received: by 2002:a05:6a21:3286:b0:398:4a1f:8a54 with SMTP id adf61e73a8af0-39fe3c91219mr18171323637.2.1776149539210; Mon, 13 Apr 2026 23:52:19 -0700 (PDT) Received: from hu-ymg-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c79219fe2d5sm12226004a12.24.2026.04.13.23.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 23:52:18 -0700 (PDT) From: Yadu M G To: jingoohan1@gmail.com, mani@kernel.org Cc: lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com, robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] PCI: dwc: Initialize pp->lock before MSI domain registration Date: Tue, 14 Apr 2026 12:22:14 +0530 Message-Id: <20260414065214.3085209-1-yadu.mg@oss.qualcomm.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: k7MFDs73YUAqEOaiLF4cxoq0hfdB02Gf X-Authority-Analysis: v=2.4 cv=RoH16imK c=1 sm=1 tr=0 ts=69dde424 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=4YNVNgpfuJSr3wIkXjAA:9 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE0MDA2MiBTYWx0ZWRfX7X5QztiGRVy6 8UFpW4/x5kdkavVPfq9l9WgbRnbQyABFqaf25Xvl89KsLpkxEkuJKM3HPgEh95EaeTfmiV7BJPc 13qe5YFFkDnSdO1k+aq2HEAz21ym/jJ7MGRd9Wxo+91POaZnhldKsVP6J5ujVDVCqB8sBSX2bbt gCRJGEIk+MEWYwLmtKVndbyrfQi884d1Sz2+w8ooUptr0S3kZD++m3i2OtZBDaa0opxXOxZ/rUB K+HN70h0QQBJPYXWt3uQSMbqxsbZmA2amiLhdoqWJ6vcFoznQc/DTU1nNTI95k9gX0UJvzzvDNe d1uQ1BKqtOv++vIZVuY8N1+3Kmun74Ql0fLxUMi6gu8lex003IBdc3YjjoYtpXn/RP+l4CQ2OaY aIE7TdBHQOorKElb0QZM5wi+CJAkT+SgFL82tiSS8w4Qo1wYYf/9eYODfZT0ipVzbLJf9IKaopX 1aTjhgF8+sqDFikQLkw== X-Proofpoint-GUID: k7MFDs73YUAqEOaiLF4cxoq0hfdB02Gf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_01,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 malwarescore=0 spamscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140062 Content-Type: text/plain; charset="utf-8" A lockdep warning is observed during boot on a Qcom firmware managed platform: INFO: trying to register non-static key. The code is fine but needs lockdep annotation, or maybe you didn't initialize this object before use? turning off the locking correctness validator. ... Call trace: register_lock_class+0x128/0x4d8 __lock_acquire+0x110/0x1db0 lock_acquire+0x278/0x3d8 _raw_spin_lock_irq+0x6c/0xc0 dw_pcie_irq_domain_alloc+0x48/0x190 irq_domain_alloc_irqs_parent+0x2c/0x48 msi_domain_alloc+0x90/0x160 ... dw_pcie_irq_domain_alloc() takes pp->lock while allocating MSI interrupts. pp->lock was initialized in dw_pcie_host_init(). However, some DWC glue drivers like those on Qcom firmware managed platforms allocate MSI domains from their .msi_init callback by calling dw_pcie_allocate_domains() directly, bypassing dw_pcie_host_init(). This leaves pp->lock without a lockdep key and triggers the warning when MSI vectors are later allocated. Initialize pp->lock in dw_pcie_allocate_domains() immediately before registering the MSI IRQ domain so the lock is always initialized for every caller path. Signed-off-by: Yadu M G --- drivers/pci/controller/dwc/pcie-designware-host.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index c9517a348836..8acd671bbc8c 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -215,6 +215,14 @@ int dw_pcie_allocate_domains(struct dw_pcie_rp *pp) .host_data =3D pp, }; =20 + /* + * Initialize the lock here rather than in dw_pcie_host_init() so that + * drivers using a custom msi_init() callback that call + * dw_pcie_allocate_domains() directly also have the lock properly + * initialized before dw_pcie_irq_domain_alloc() can be invoked. + */ + raw_spin_lock_init(&pp->lock); + pp->irq_domain =3D msi_create_parent_irq_domain(&info, &dw_pcie_msi_paren= t_ops); if (!pp->irq_domain) { dev_err(pci->dev, "Failed to create IRQ domain\n"); @@ -573,8 +581,6 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp) struct pci_host_bridge *bridge; int ret; =20 - raw_spin_lock_init(&pp->lock); - bridge =3D devm_pci_alloc_host_bridge(dev, 0); if (!bridge) return -ENOMEM; --=20 2.25.1