From nobody Tue Apr 14 13:59:22 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65B6936DA1F for ; Tue, 14 Apr 2026 06:35:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776148544; cv=none; b=hYsr3XQY5AelM5mDcfMwcJAa+Yu+AwT5f3uEDa5uXPgJTEo1kXoyUlrtz5wDG3BCiVna9gRRp1I/rv1EWJBWLnyw0Ml5IDFjiMm/B4LlXbFTgywtXn113ETLt0IRbxaW7V+Tj5AbkpeRZxt+TdY7MoofVvukVvw6RnswQdLIGxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776148544; c=relaxed/simple; bh=/boUR8ebHBD63x6CwjJTnj67E5KQQnj1e51JOVLIb/Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uGM1fAO2OZdRbmI9BmdqlFr+XhAJPVgD2OifUolRIyL9xz97huXGEoj1+oeC59kaCet3y4ptQzzSe01BXCxIEuKsGixe1g19hV8mNKqeYRZynW5Xfmimxf1swq0+7Fc3w/LG6QENCCztHkfIDvEMvoxp9Aob4I+j+jZDFrncBx8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LQ4DtH/R; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LQ4DtH/R" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2ab232cc803so25989625ad.3 for ; Mon, 13 Apr 2026 23:35:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776148543; x=1776753343; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YsxOoaVcC4V0T322Xtd1x/qfgbEvHOkE8it23Ok9xxo=; b=LQ4DtH/RojUJ2wiSEjEr2XCKSzslE+E05hSopAufSJsNQW+h7kVdpKg3BcjJU3mOY8 cFKcTjHgvvILezDTM+Za5q+rNG8oENZzatktWvOStkna760evrCL1wyr0RFGAvS51TP9 B74y6/7BRePY3pDE0aYSKMtoa/YABR8jnm9YJ6GyXcAAU347R6k7+3J48r5MMwUI2mso YImpFGSDmwH3ZcubcDb00TFi8DVGBAFFlMHjj1a9LTKdSdqE+VhW+F/SD3h1y09r8vSa r2UET8ah/8sKFB+tLYTu489PAXYqf4gR3WBBEyYe3D4auFotiRNKEqLOeKHZR6uMj9hS VBqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776148543; x=1776753343; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YsxOoaVcC4V0T322Xtd1x/qfgbEvHOkE8it23Ok9xxo=; b=BNZ/k42/+JetFY77hNrs7CoA01g7vv1PIqR8tja2ECldImxoUWvhTHoZ1PVyfWRezf cuy/ysop3NYfwJvhxF1k2RDU8BWzCw9P2VVoWbw1S1drkEMmX8l6v3/vMEmFXzZWHc5s gq/AG5DF58fGhqf67hGoaD4cuN359zJUnRWnNR+TFa3CMxpZUegA3/jzYbS3aMYHtmYh rM3Q8B1F2Pn29wnr60V6mjpf8QiLiaTiSObnATAKmk6h4ryNplhpr3NYhAJmtGLaH94s m6XODM9KIazIW4hR0678U9TlQZyCNHY103H7bFjhDJzs9KQ7lFtTflXffqZkEQTbEVHh AquQ== X-Forwarded-Encrypted: i=1; AFNElJ+GtHIJOABM0Njjw3YD7hI56OC1UzccRWoFnxLP4rwoAfUE/5B8FuqSOJQtLNk9EAICRzKmTGGK6S2fJBo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5+NocOgjwKD5xlGWaIzsZALloUViG0rSQl8xcXsMbzOgytaj5 cc/1iYH8ZpwpoTUj0Gd+PpwiYISTOuUOg3FJdzy3w3df73WVbcDYqk3u X-Gm-Gg: AeBDieuHtFEEsGR2/BA1YzHYqa/U9iZqVHqft2KZTzbTrOtEgBX6GdOTMnWMJjSbf77 /uW/KJzZgRgYfr8PRy78gAsu0vbO2y32GiNdlcAWJPv2PY5+gOYEMFBXc1MJmgB+TV42JoIv7/5 aA1zIOgWyYoE2kOeDZb3gKouPFKImcQci5W7TBL2WDkPQFv7+38xPHL/80A9OIHfUihLi7JjIBy GIES6qfKVG90YFA39VyPtNBnXDn/wPh2ESe0Qye6QALpsneSh4wbZymUObBTWhRGvjI9vx2ZulS unWdjj9ll4eCdnsVKoYGc2Y36/1dgvYlNKFI7gB83y7cXs7mUmSx6Vi09ik1wWj4Lz4aMOUcfAV CJqeq8VHzN3m8bri1sGfer2zUyP6y8fMnn4SQZQuqZKDuhETFxkPjKMe/Abaeo8BIklN6aSKc7M ZjiIHv7HoNZ+ULrQftrUW9IMx9VvIpV7y+KuKCF4KbE1Cbaw== X-Received: by 2002:a17:903:2286:b0:2b2:dca5:101b with SMTP id d9443c01a7336-2b2dca51487mr141736265ad.12.1776148542717; Mon, 13 Apr 2026 23:35:42 -0700 (PDT) Received: from aadarsh.. ([2401:4900:1cd7:701e:1072:a9fe:b7cb:a224]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2b3a73747b8sm68573935ad.47.2026.04.13.23.35.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 23:35:42 -0700 (PDT) From: Aadarsh Mandal To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, ethantidmore06@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, luka.gejak@linux.dev, straube.linux@gmail.com, Aadarsh Mandal Subject: [PATCH v10] staging: rtl8723bs: remove commented-out code Date: Tue, 14 Apr 2026 12:05:34 +0530 Message-ID: <20260414063534.16697-1-aadarshmandal9354@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260318021005.6346-1-aadarshmandal9354@gmail.com> References: <20260318021005.6346-1-aadarshmandal9354@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove code that is not used anywhere in driver. Signed-off-by: Aadarsh Mandal Reviewed-by: Dan Carpenter Reviewed-by: Luka Gejak --- v10: - Change in commit style. v9: - Change in commit style. v8: - Restore the formatting of non-commented code. v7: - Change in commit style. v6: - Change in commit style. v5: - Change in commit style. v4: - Remove extra space insertion. - Delete remaining commented-out code. v3: - Add the extra space that count as insertion. - Remove unwanted addition. v2: - Restore braces for standalone code blocks {}. - Delete reindented commented-out code and extra space. v1: - Reindented commented-out code;extra space remained. --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 29 -------------------- 1 file changed, 29 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index f2f73c65a636..1281aaf0515f 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -46,8 +46,6 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter) u16 value16; u32 value32; u8 ret; -/* u8 bMacPwrCtrlOn; */ - =20 /* all of these MUST be configured before power on */ =20 @@ -69,10 +67,6 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter) value16 |=3D EnPDN; /* Enable HW power down and RF on */ rtw_write16(padapter, REG_APS_FSMCO, value16); =20 - /* Enable CMD53 R/W Operation */ -/* bMacPwrCtrlOn =3D true; */ -/* rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); */ - rtw_write8(padapter, REG_CR, 0x00); /* Enable MAC DMA/WMAC/SCHEDULE/SEC block */ value16 =3D rtw_read16(padapter, REG_CR); @@ -359,7 +353,6 @@ static void _InitNetworkType(struct adapter *padapter) value32 =3D rtw_read32(padapter, REG_CR); =20 /* TODO: use the other function to set network type */ -/* value32 =3D (value32 & ~MASK_NETTYPE) | _NETTYPE(NT_LINK_AD_HOC); */ value32 =3D (value32 & ~MASK_NETTYPE) | _NETTYPE(NT_LINK_AP); =20 rtw_write32(padapter, REG_CR, value32); @@ -410,9 +403,6 @@ static void _InitAdaptiveCtrl(struct adapter *padapter) value32 |=3D RATE_RRSR_CCK_ONLY_1M; rtw_write32(padapter, REG_RRSR, value32); =20 - /* CF-END Threshold */ - /* m_spIoBase->rtw_write8(REG_CFEND_TH, 0x1); */ - /* SIFS (used in NAV) */ value16 =3D _SPEC_SIFS_CCK(0x10) | _SPEC_SIFS_OFDM(0x10); rtw_write16(padapter, REG_SPEC_SIFS, value16); @@ -486,9 +476,6 @@ static void _initSdioAggregationSetting(struct adapter = *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); =20 - /* Tx aggregation setting */ -/* sdio_AggSettingTxUpdate(padapter); */ - /* Rx aggregation setting */ HalRxAggr8723BSdio(padapter); =20 @@ -640,9 +627,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) return _SUCCESS; } =20 - /* Disable Interrupt first. */ -/* rtw_hal_disable_interrupt(padapter); */ - ret =3D _InitPowerOn_8723BS(padapter); if (ret =3D=3D _FAIL) return _FAIL; @@ -661,8 +645,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) =20 rtl8723b_InitializeFirmwareVars(padapter); =20 -/* SIC_Init(padapter); */ - if (pwrctrlpriv->reg_rfoff) pwrctrlpriv->rf_pwrstate =3D rf_off; =20 @@ -704,8 +686,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) pHalData->RfRegChnlVal[1] =3D PHY_QueryRFReg(padapter, (enum rf_path)1, RF_CHNLBW, bRFRegOffsetMask); =20 - - /* if (!pHalData->bMACFuncEnable) { */ _InitQueueReservedPage(padapter); _InitTxBufferBoundary(padapter); =20 @@ -745,11 +725,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel, CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET= _DONT_CARE); =20 - /* Record original value for template. This is arough data, we can only = use the data */ - /* for power adjust. The value can not be adjustde according to differen= t power!!! */ -/* pHalData->OriginalCckTxPwrIdx =3D pHalData->CurrentCckTxPwrIdx; */ -/* pHalData->OriginalOfdm24GTxPwrIdx =3D pHalData->CurrentOfdm24GTxPwrIdx= ; */ - rtl8723b_InitAntenna_Selection(padapter); =20 /* */ @@ -791,8 +766,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* ack for xmit mgmt frames. */ rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TX= Q_CTRL) | BIT(12)); =20 -/* pHalData->PreRpwmVal =3D SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HR= PWM1) & 0x80; */ - { pwrctrlpriv->rf_pwrstate =3D rf_on; =20 @@ -1080,8 +1053,6 @@ static void _ReadPROMContent(struct adapter *padapter) pEEPROM->EepromOrEfuse =3D (eeValue & BOOT_FROM_EEPROM) ? true : false; pEEPROM->bautoload_fail_flag =3D (eeValue & EEPROM_EN) ? false : true; =20 -/* pHalData->EEType =3D IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEP= ROM_BOOT_EFUSE; */ - _ReadEfuseInfo8723BS(padapter); } =20 --=20 2.43.0