From nobody Tue Apr 14 14:05:39 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02F312FE07D for ; Tue, 14 Apr 2026 03:42:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776138170; cv=none; b=Eih4QCrrjDkzuyAYyn99WbtKM/XWkZjv0Y+V4Ll9ybIEfcSlNaA4tS0kJ50Ionz6M7/Fk1PYoq96F2FRWk0IYCLjM/pxmau1P8yBD/zKPmwcdo4ygy+c5ZsYEPpvSJ12d1RIWQJuH9MgUwUx1Og2EbyNbLbr5jIB8eRH5LsBkm4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776138170; c=relaxed/simple; bh=G1zkKB5J/ZwwzO57UPK0AFrN20hSeHo66GZs4YUYlKw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rgSPSQ6/hxwYW1t8Pxqe7wPkKbWlqxJyJBWQxBf1+VUi9BY12s8FkNxgA78GXwkk08ilO0hfBdiUMDQOWsJBYL6S1aiGgc4RKY6HqBrsK6K7radA/9Xa5AbOyBdayQXXoPp/QkuQ69dBYMsgGzZjWcpjpNkDYKI9rXLCu/4Hmo4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TaeDvez/; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TaeDvez/" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ab232cc803so25386515ad.3 for ; Mon, 13 Apr 2026 20:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776138168; x=1776742968; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bxcVRDBQYoEvUjV/D/PMX40SNzPhQnuxj7fjLILYmjM=; b=TaeDvez/GmrmfSWFW3V/GjcP2XU9KuVw3/oeBDDh4qIwoY14//41gQpW65X0sD1oBh UDaIe8fCiSGJ+ElO/6ejZVSA8nQXsMy6EHU3PG8xiY+otbYDJL+/rcwx2tV0aEi/eCj3 gnwzAeOKwpO42r3mGlz+plFKwALfWRZZoKtQ8xjM8mZJ0dNiE/Ebh+Le7C7Au7dbldJb 5kVhCkB4Eun1cA22p0nBbNQKzCprkuvpveWaE0G8X8j+NxONWa6JTXXouUS9QnF9TMX5 ZCy+mlOvcbfDzMRZCu43NXxdl9VseMMk4t9otQYW2qzQiTOn73AtGb4jhqc5SS+7YyEC bcOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776138168; x=1776742968; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bxcVRDBQYoEvUjV/D/PMX40SNzPhQnuxj7fjLILYmjM=; b=q/T6tqIFKf0BHUYgaYI8ycpWbSoYlEyZUdRj9RAgNk+0MmMaxUf3XIzgnPcnaWVA38 USh4swMLkjjRZtXEHGXSqev7Wir+NwPgp3K/by9b2OjHPr1rq1ZSqAJbwXqSuJy3ORLJ gzdomXO51U28qNHCdBkO6BHoHtq5mqCx6SQHVcZq1xMRqQwAF8H9iNA3V4SWQMR+oJG0 9DrAidtfRBKw5hdlYRCV2Cxarz0198/aUhDD0qfiNIwxdcivkDV4bYpyP60GIzXnpPf4 l6uTyWPz93eVL0LKATjzdWayibbVrpJOy7xAON1rWmhovsKzu0xHflZiWLYpz8b+hqMv oJuQ== X-Forwarded-Encrypted: i=1; AFNElJ/YxBSUORIowewQ90p8Rc0sUU3YH8diobsbTqY9CnEIbEIWNo24gmHTtvipZrtS6nHG2ALeA1YkAZ9vxz0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy24PuaoQHuG3giuoEWyWtIPGW40MEKwamRfjCX+Azin0RdjW59 6OiBOnjmtcMz1qHEYSRFQtCkNc9reqlVSvVuxfph6JXvTDy0jcnvaA46 X-Gm-Gg: AeBDies8B2nIgnCn2fG0hANZfbt7/SDBAQ3XzP1u8FKr/i0O7R0TtvhD4ljc3xKWslz gZOxgrScCM4PRYk+EBub8WDv7p1SZ+ROzotEi8YLA7/Hxz4dh2dWj3dwh90ETOFgTb6MD9EydbT hcUkubiTZLL6dQDZgxBAL+sM3rYTVhIAh0BBPZqgtrBaOZTgIrX2SIVQXq4IPzlpa5wlnnGrhUQ owlPOWNP7Q4yYGKpS3NLH6UQFm9uu3zZYnY4CS/TSqxPlqMkQSyFlfI8HG1Q3W9sxPm55o+75Ga 2Ro+X/hXDEW52IErQ/ZBk8AtmZmi4A1rhFf2XSnmdjBTiw1VH7NBFpMJFVbdJbQJN6XYXuBeZbw sRgzu3ql7Tu2a7TgHq4RnE5QtC4wIDxfu558eGYNRAoi88IVQuGFpda9tpRTlx5zXHEsgkBv9QX EnYXvDz4i+6NCODRwX/6mBpKCUWq7h X-Received: by 2002:a17:903:2286:b0:2b2:dca5:101b with SMTP id d9443c01a7336-2b2dca51487mr136688535ad.12.1776138168289; Mon, 13 Apr 2026 20:42:48 -0700 (PDT) Received: from zenbook ([159.196.5.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b45e949464sm63079895ad.24.2026.04.13.20.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 20:42:48 -0700 (PDT) From: Wilfred Mallawa To: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Damien Le Moal , Alistair Francis , Carlos Maiolino , Hans Holmberg , "Darrick J . Wong" , Christoph Hellwig , Wilfred Mallawa , stable@vger.kernel.org Subject: [PATCH] xfs: fix memory leak on error in xfs_alloc_zone_info() Date: Tue, 14 Apr 2026 13:41:51 +1000 Message-ID: <20260414034149.1116281-3-wilfred.opensource@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Wilfred Mallawa Currently, the 0th index of the zi_used_bucket_bitmap array is not freed on error due to the pre-decrement then evaluate semantic of this while loop us= ed in xfs_alloc_zone_info(). Fix it by allowing for the i =3D=3D 0 case to be = covered. Signed-off-by: Wilfred Mallawa Fixes: 080d01c41d44 ("xfs: implement zoned garbage collection") Cc: stable@vger.kernel.org Reviewed-by: Carlos Maiolino Reviewed-by: Damien Le Moal --- fs/xfs/xfs_zone_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_zone_alloc.c b/fs/xfs/xfs_zone_alloc.c index a851b98143c0..c64f9ab743a6 100644 --- a/fs/xfs/xfs_zone_alloc.c +++ b/fs/xfs/xfs_zone_alloc.c @@ -1217,7 +1217,7 @@ xfs_alloc_zone_info( return zi; =20 out_free_bitmaps: - while (--i > 0) + while (--i >=3D 0) kvfree(zi->zi_used_bucket_bitmap[i]); kfree(zi); return NULL; --=20 2.53.0