From nobody Tue Apr 14 14:07:33 2026 Received: from n169-112.mail.139.com (n169-112.mail.139.com [120.232.169.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 340F72D8391; Tue, 14 Apr 2026 02:59:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=120.232.169.112 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776135553; cv=none; b=Hf2/P5Ja7ccM8hdQq3DdS+WtIBGtDUgiC+pXXvFRhkNFN1HbpxP0iYnv5frVC46d5HOHmWGBY5KrU0/yAWpw2UZz52eI4tWCmpS+Da0kq/jP0GYRcej8JaejWAiblfIjiPGnxU5QB67ooHCS9ta/9nihcmtvCHIh3uik75TCIL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776135553; c=relaxed/simple; bh=Gju3hMPOQJHrtrP/OEqqpTQEAsKDXPlJqo6PvpOF8Go=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=dl+vx6FEse2fh/Ms3HZpSUenuaXUyIQ+rn//245F8G/ENH+ZlMyk7G3DajHLsvD/U34+Tp63XTIWhqqaUbMXItFqZfPM3z8vezVCg7yCI4awWqReNmH9OXoaaENOZX2FPXZvEVsHxJ9wNOkxP1/K14dgg0JQKwo950rDdCEdClA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=139.com; spf=pass smtp.mailfrom=139.com; dkim=pass (1024-bit key) header.d=139.com header.i=@139.com header.b=UccZ6Vg3; arc=none smtp.client-ip=120.232.169.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=139.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=139.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=139.com header.i=@139.com header.b="UccZ6Vg3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=139.com; s=dkim; l=0; h=from:subject:message-id:to:cc:mime-version; bh=47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=; b=UccZ6Vg3OWFDhRDZosqAYSrfjL9/5P1a4icLpLO5bLmQqU08sqUGnBEEcy+tdzSTUyFQHfFqI6540 zHBaK6fnv2Se+O9J8xa/EGUwrZOKcu6GjoHNganYvxR3fQIM1vwyK5EBz70t/Y1RQXpFaGDXt1lbu1 c6jBr458ChuORWS0= X-RM-TagInfo: emlType=0 X-RM-SPAM: X-RM-SPAM-FLAG: 00000000 Received: from NTT-kernel-dev (unknown[60.247.85.88]) by rmsmtp-lg-appmail-23-12026 (RichMail) with SMTP id 2efa69ddad7344f-00454; Tue, 14 Apr 2026 10:59:02 +0800 (CST) X-RM-TRANSID: 2efa69ddad7344f-00454 From: Li hongliang <1468888505@139.com> To: gregkh@linuxfoundation.org, stable@vger.kernel.org, fw@strlen.de Cc: patches@lists.linux.dev, linux-kernel@vger.kernel.org, pablo@netfilter.org, kadlec@netfilter.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, kaber@trash.net, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, imv4bel@gmail.com Subject: [PATCH 6.1.y] netfilter: conntrack: add missing netlink policy validations Date: Tue, 14 Apr 2026 10:59:00 +0800 Message-Id: <20260414025900.3605300-1-1468888505@139.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Florian Westphal [ Upstream commit f900e1d77ee0ef87bfb5ab3fe60f0b3d8ad5ba05 ] Hyunwoo Kim reports out-of-bounds access in sctp and ctnetlink. These attributes are used by the kernel without any validation. Extend the netlink policies accordingly. Quoting the reporter: nlattr_to_sctp() assigns the user-supplied CTA_PROTOINFO_SCTP_STATE value directly to ct->proto.sctp.state without checking that it is within the valid range. [..] and: ... with exp->dir =3D 100, the access at ct->master->tuplehash[100] reads 5600 bytes past the start of a 320-byte nf_conn object, causing a slab-out-of-bounds read confirmed by UBSAN. Fixes: 076a0ca02644 ("netfilter: ctnetlink: add NAT support for expectation= s") Fixes: a258860e01b8 ("netfilter: ctnetlink: add full support for SCTP to ct= netlink") Reported-by: Hyunwoo Kim Signed-off-by: Florian Westphal Signed-off-by: Li hongliang <1468888505@139.com> --- net/netfilter/nf_conntrack_netlink.c | 2 +- net/netfilter/nf_conntrack_proto_sctp.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntr= ack_netlink.c index 89cec02de68b..bcbd77608365 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c @@ -3458,7 +3458,7 @@ ctnetlink_change_expect(struct nf_conntrack_expect *x, =20 #if IS_ENABLED(CONFIG_NF_NAT) static const struct nla_policy exp_nat_nla_policy[CTA_EXPECT_NAT_MAX+1] = =3D { - [CTA_EXPECT_NAT_DIR] =3D { .type =3D NLA_U32 }, + [CTA_EXPECT_NAT_DIR] =3D NLA_POLICY_MAX(NLA_BE32, IP_CT_DIR_REPLY), [CTA_EXPECT_NAT_TUPLE] =3D { .type =3D NLA_NESTED }, }; #endif diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_con= ntrack_proto_sctp.c index 7ffd698497f2..90458799324e 100644 --- a/net/netfilter/nf_conntrack_proto_sctp.c +++ b/net/netfilter/nf_conntrack_proto_sctp.c @@ -600,7 +600,8 @@ static int sctp_to_nlattr(struct sk_buff *skb, struct n= lattr *nla, } =20 static const struct nla_policy sctp_nla_policy[CTA_PROTOINFO_SCTP_MAX+1] = =3D { - [CTA_PROTOINFO_SCTP_STATE] =3D { .type =3D NLA_U8 }, + [CTA_PROTOINFO_SCTP_STATE] =3D NLA_POLICY_MAX(NLA_U8, + SCTP_CONNTRACK_HEARTBEAT_SENT), [CTA_PROTOINFO_SCTP_VTAG_ORIGINAL] =3D { .type =3D NLA_U32 }, [CTA_PROTOINFO_SCTP_VTAG_REPLY] =3D { .type =3D NLA_U32 }, }; --=20 2.34.1