From nobody Tue Apr 14 14:00:24 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAD373446AB for ; Tue, 14 Apr 2026 06:58:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776149933; cv=none; b=KiKOkw+Mdcj0BP/ezS5mHCRjTU1iL8BRwfyDlkIlOMEjsTgVbHsKxPhWc1RpQW6KiXmrQ6StunWhyPIZmhNeBTiQ3qgU7huYA+CrORK1xmfwfqywFaU2Q5OP0dDwk8iAndrrA9b+uyASv3py6GFZeiFJ8BLO7IA02ax0U6sZlvg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776149933; c=relaxed/simple; bh=OGjx/rpqLanYJw8wyMx1GZX57lDgWW7QcL/E9ij2zVU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MzfjM4kQ0qztpfDeWI/Rxv9y7buyw/FDPTiAE4ObmZ6/aqtRYN7ur2jjQnzqpaVslMEOnid2BUdIAGqfgDiq9LEF21DXN9cGgVf+nV1J1oSQe6Yls6kCOdRuLKaKTin/980y0y3Pds9nOWMr1Z6Cc5El9oN9kluoDzLjJALfDfA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=inventec.com; spf=pass smtp.mailfrom=inventec.com; dkim=pass (2048-bit key) header.d=inventec.com header.i=@inventec.com header.b=BRM5p0xM; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=inventec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inventec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=inventec.com header.i=@inventec.com header.b="BRM5p0xM" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-35d965648a2so4373398a91.0 for ; Mon, 13 Apr 2026 23:58:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventec.com; s=google; t=1776149931; x=1776754731; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Z3ThBxdaxluBFioSVhIDwm332ADtoHWnIdue1Mw0j4g=; b=BRM5p0xMDzM/LFkGjGjNodboDkvIH3iGoQPIv7WWdvNqYdATcEulH954wlZ+iE0vN+ xx6uu+ah5egpnGAeCv5wl0OlXGKZ3MQ5bSoFHLHN6jPmCmRB2ZXrBH9rGBHm6UdNxkw/ X/FWzJmUC5vW39iZcfIIZQWQtqwXTPunCXyh0BQgCSI/qb/cnR/T/8MxvuiTdnuJ2wmO saHD3UGjXCU5a1gu5K3cM71TFMa1bUsiKjbmNeU9DoG1f/XHCTpylZk4eFfSNSOwCFZK HibG+YZ0/uYpEADL1MAPI5P3F2GLfaPrCpPbCnwzSxFHkoJpnoeYCpoEs1GzGwSh/rCm TQ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776149931; x=1776754731; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Z3ThBxdaxluBFioSVhIDwm332ADtoHWnIdue1Mw0j4g=; b=paEU0prx8WZuYgt48Fa4qLEMEaYdQi0t9ct8K7nA4rQACw41uL6djiT9/+CcKGWPan JK4Jh0UtvwkAFIRHEsV0YQ1WVg6YGQJ7i5tqfaiAToGSabJoFZ+QWcgvxqLMC/xyr7gQ l3gaMdvUxEVsMT4BGGHP3QsvF8RTRjmbakF6xtxks1vbb4Tl/3x+N75NIyEH5efCV01h viNNnaDLwDUb1oIgTMNi10GLVSPMPZ+y2GHc6Z3D72K/yTrdY7QvzwhcSki0clTWqYbp RVl36BBjYq8ogsiTgUXeDV7pkqTyn2B+LNGOdO8kOClaUUfNzi/Yd5XmWBc8e1/t/aPq xxlg== X-Forwarded-Encrypted: i=1; AFNElJ/QFzsJiMC/mf1vA9Ou0W1h3ootTSrUpfBAPBfDWain5oa8ASwRj0a3coB3wptj5AoT9F3APMrSZtTh8vo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5cQYv2IS7+qhjbLKnq7zeBxW6GmNCEfmygKfDwu6fa+GRwMGo LIb7s4vRs3mxmKZoWe02484h+FAqADEi0hKXbmXMpDyayHnFDwGrM13F4zAGR3Lj2Nk= X-Gm-Gg: AeBDievhsFg9co9dLuFQ+Cu2cqzckm7lJ2wQMCQiTfwjLm0B2qdprrN81np8BtbX+iy I8nMl3uwFmruQQomS2LAYG+b8nXsB20y9eUU2RN82x5jdWLBG+23atLPp55yORupTEt5HrCCZpL Xz6mJ6jxBTD27H5WneiJ0rU+fH/eeDwbCk3ieYO8ESKQopvWK/Pa65o5h+PWwLaw7S3snHqnd0o Mz6iMcdYfZyzmZo3HqK6E1MS1vWsQlwrA8c8HQYO2FDc78Jpx2yuXP3T50uFHiD5sbDK8Q6nCM8 Sape4pyAgjy6V4DAJ8j2yebTI1+8gOwcpBT02wIx5gVYOkqcdI8jv6NN3/x/KVWtuAn68efuXaK LxYQ046MX0aZ7fHn/R/GxJBFmpde7Agxb1oY55gri+GrPT4HPAnz7dGHq3uqpvL/CGKJwlXEQgv 5cKJDHmBnYh6u0y/lJiRN/fX/v/2qyA2bM7eYy89y52qm//oEfq7p96Ghsb0kg98O9bg== X-Received: by 2002:a17:90b:5625:b0:359:f43d:4a6e with SMTP id 98e67ed59e1d1-35e424548aamr19819841a91.0.1776149930990; Mon, 13 Apr 2026 23:58:50 -0700 (PDT) Received: from [127.0.1.1] (59-120-179-172.hinet-ip.hinet.net. [59.120.179.172]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35fc6eac8ddsm1019714a91.8.2026.04.13.23.58.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 23:58:50 -0700 (PDT) From: Brian Chiang Date: Tue, 14 Apr 2026 06:58:42 +0000 Subject: [PATCH v4 1/2] dt-bindings: trivial: Add q50sn12072 and q54sn120a1 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260414-add-support-for-q50sn12072-and-q54sn120a1-v4-1-b81eaea49df1@inventec.com> References: <20260414-add-support-for-q50sn12072-and-q54sn120a1-v4-0-b81eaea49df1@inventec.com> In-Reply-To: <20260414-add-support-for-q50sn12072-and-q54sn120a1-v4-0-b81eaea49df1@inventec.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Jack Cheng , Brian Chiang , Jack Cheng X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776149925; l=1150; i=chiang.brian@inventec.com; s=20260316; h=from:subject:message-id; bh=371ndBFO++Ux/UDUOyIuv35ZzqLJAZsYGZPm32hIp6Q=; b=JlZ0OUSYbZz6ko6IaimN1a1WAlJxzt0csnzLIQ4VwoG7rUz51CCP7Od/brmCaPrficvEnsDt+ myPAdtyWf7DCEYR/1bEtrVIEz4vSCtssoiUKPaGoGaY8H/knrbkDeWj X-Developer-Key: i=chiang.brian@inventec.com; a=ed25519; pk=q+NqJYuJbGpA9KS9941D7f+8PVVW+k7DvaGgFykBiUc= From: Jack Cheng Add support for the Delta Electronics q50sn12072 and q54sn120a1 1/4 Brick DC/DC Regulated Power Modules. Signed-off-by: Jack Cheng Acked-by: Rob Herring (Arm) --- Documentation/devicetree/bindings/trivial-devices.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Docum= entation/devicetree/bindings/trivial-devices.yaml index a482aeadcd44..d4b78154df82 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -96,7 +96,11 @@ properties: # Delta Electronics DPS920AB 920W 54V Power Supply - delta,dps920ab # 1/4 Brick DC/DC Regulated Power Module + - delta,q50sn12072 + # 1/4 Brick DC/DC Regulated Power Module - delta,q54sj108a2 + # 1/4 Brick DC/DC Regulated Power Module + - delta,q54sn120a1 # Devantech SRF02 ultrasonic ranger in I2C mode - devantech,srf02 # Devantech SRF08 ultrasonic ranger --=20 2.43.0 From nobody Tue Apr 14 14:00:24 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EFCF346A08 for ; Tue, 14 Apr 2026 06:58:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776149936; cv=none; b=C4viJb5pT8JzWSdDBur32/vHViF2TvYfImrQfHNMyKJrt7kO/uBj6MGsF4+bvLF9qIqqITnydoxfb5f21pgYqnHHjjVmytmp6BembtBG+OGgMSeeoZgXVDx0UJ/aFIXlocIVQNg52dS/4AHCCs5sWXIgzBW5nleRIVUegieON0I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776149936; c=relaxed/simple; bh=2fDvceWZH0uVoiXI+idreB4J3EIIZl8vYZyKQA+B/1I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gyzPcjFdG58Vy+6q/s5fhOHGnJMNiMT+r/LcSTnj6fulA7rt6Az3eO3+WL8FsWp+Gibm7SlogWaIzYNuBeqc6Jr75QcRCANosyM0X8+cvNWL7xDNV/obbYAwuiU8sfmvre1Fd9YP3xXqHCpWcz8+w/QekXkVoLDVklQjVT8g8sk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=inventec.com; spf=pass smtp.mailfrom=inventec.com; dkim=pass (2048-bit key) header.d=inventec.com header.i=@inventec.com header.b=JYRCK/cr; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=inventec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inventec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=inventec.com header.i=@inventec.com header.b="JYRCK/cr" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-354bc7c2c46so3272114a91.0 for ; Mon, 13 Apr 2026 23:58:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventec.com; s=google; t=1776149934; x=1776754734; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qnhWm4BJIe1qz1PKqfhPExcXSRC6Iyeb59/CaItSdTg=; b=JYRCK/crSaCIwqYKRjU6rPKwKB2IKTkei8gPyjIVc8n8De612cB8sRu9NUR9GvzQHg A1Vzf9XR9NGfLgqP2O4v5ZZnJBSQ6qFFh3O1bD2JvvYjL/9n5eA4my+ZcUPAhhDnj99X 0Bw7pZpMMNACmfLtCE1RoG62n0X+J7MmG3czc0/m+1tBo0uz+O0m/GpYNipX1eDSEZBt /+uWIq5RmhP9d9LYpVlV8nmKJGhfbI10UyZGM74P/ZHQJNSWVhmvK9BKumge5DXtpLBd mbrGAADN8T/EkhsapueEtOnPPF3f0L5FupiQ3GwauNvgzcDnS5ViXXbAhnZICP2LoJjk hAbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776149934; x=1776754734; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=qnhWm4BJIe1qz1PKqfhPExcXSRC6Iyeb59/CaItSdTg=; b=exsGRFZ5/YdwldW2A+nAeAtf7er4/zQPIYc3DVgTpYkgVGBOtq16WwWRquURcEXOGp wyWS7f13+2YOBCrUPcKenUigq2e6wOX8Vb6OiGby4rYnw69Rqg1hIuMVaFSrWWH7rekk sn00VfQQopCIGiH7cN96K8jg0C5MxPSk3PNmPtBo+h54su2WVu7VdYM0EsTv3/uTTuWt svCXLFUF/7XCv7p/oiGISsMj6tupCE+4SUYpbtrkKAttvzD/0Vn/ZnSSBwC5XArWs/HC 1PtzKp3tFojSIcL24Q4/8bdR6JqBt4zu2tWYxS0y3PTjuqzPSSWN+zSZ3ri6aUTNfI/+ NzCA== X-Forwarded-Encrypted: i=1; AFNElJ+xkCCyCCa9wcLsikKkB+4s43O6tAPmcfSsGV0Ypks5dUg0N7Rq0yTKsspE7kaIEefDO+fRC41EbVfTGdw=@vger.kernel.org X-Gm-Message-State: AOJu0Yyzp/L2rhv4nNl9ZyKEHl4/Dl5Z4TxdKJQ0bcrbHPoT2bsmN0pL hi66zgF1HNjcHe9SeqqNMgeLs7YVHEww9YJ8hZZ35VHPsUXRaklld7Eu4J9vUbyJiLE= X-Gm-Gg: AeBDieuWf4bT5gBCxVaCZhxSIHvgBdMgpzufQ9Yb33zs/z7+ZnGiPPpmuZK2RruEjjY s7F4uf5jgjcS7fb9gU5eV0nEu4OC79xktym+h/P5zdsszPxfXEfrPezNP2o6iaX2fuFvSod47zr ndjfIPWSVVQEZOD9JKYlAqzRr96ZLijD9BEyJInHXWzFN2yNRcTkvfK/mUeVWHW93HMlLPeayLA qVkMBY9Tml9umE2XyP34QutvHI6AqD2mVoNTtEy3UzzDdGLodoJ0YZa/sdLe9PJkfDGhwio3E/b YEu68GQ2V49XrSHZ8LU4WBMnomlLWInJCyHijiDH+PDh+XYsqfb8l16O910MDWY4p07ytINM/S4 aGeO5QFtJAD10LGcxShDxL9RBtOmto7nnUSZ74Zz1F9hIqRV47tSisuxQsKvDDypoKRVe49Bnuf d+L513IKRD4KbM7m0R+o+w1A+Jv/tYzzNcktfjNv9WjU4WlKKGfe7w4IltUzdq+u02LltkSILei zKI X-Received: by 2002:a17:90b:5283:b0:35c:cba:3453 with SMTP id 98e67ed59e1d1-35e428452e1mr15952554a91.22.1776149934062; Mon, 13 Apr 2026 23:58:54 -0700 (PDT) Received: from [127.0.1.1] (59-120-179-172.hinet-ip.hinet.net. [59.120.179.172]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35fc6eac8ddsm1019714a91.8.2026.04.13.23.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 23:58:53 -0700 (PDT) From: Brian Chiang Date: Tue, 14 Apr 2026 06:58:43 +0000 Subject: [PATCH v4 2/2] hwmon: (pmbus/q54sj108a2) Add support for q50sn12072 and q54sn120a1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260414-add-support-for-q50sn12072-and-q54sn120a1-v4-2-b81eaea49df1@inventec.com> References: <20260414-add-support-for-q50sn12072-and-q54sn120a1-v4-0-b81eaea49df1@inventec.com> In-Reply-To: <20260414-add-support-for-q50sn12072-and-q54sn120a1-v4-0-b81eaea49df1@inventec.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Jack Cheng , Brian Chiang , Jack Cheng X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776149925; l=8330; i=chiang.brian@inventec.com; s=20260316; h=from:subject:message-id; bh=CLMn8jlvGzD+hXMNiwD6qUJpGNbcZMKkkvxVny1Uuqo=; b=wqlAd22qpqoEMowq3X4jg6ii3ooaBiQmurQNUzp2cGPctbmFIp+YasN294AO7N9FkkbrSst4l rteASS80srcBJBrfJQnUjYgrdqr2LBHbR2Zl9Rqb8J1VxXozllBgMPT X-Developer-Key: i=chiang.brian@inventec.com; a=ed25519; pk=q+NqJYuJbGpA9KS9941D7f+8PVVW+k7DvaGgFykBiUc= From: Jack Cheng The Q50SN12072 and Q54SN120A1 are high-efficiency, high-density DC-DC power module from Delta Power Modules. The Q50SN12072, quarter brick, single output 12V. This product provides up to 1200 watts of output power at 38~60V. The Q50SN12072 offers peak efficiency up to 98.3%@54Vin. The Q54SN120A1, quarter brick, single output 12V. This product provides up to 1300 watts of output power at 40~60V. The Q54SN120A1 offers peak efficiency up to 98.1%@54Vin. Add support for them to q54sj108a2 driver. Signed-off-by: Jack Cheng Co-developed-by: Brian Chiang Signed-off-by: Brian Chiang --- drivers/hwmon/pmbus/q54sj108a2.c | 105 +++++++++++++++++++++++++++--------= ---- 1 file changed, 72 insertions(+), 33 deletions(-) diff --git a/drivers/hwmon/pmbus/q54sj108a2.c b/drivers/hwmon/pmbus/q54sj10= 8a2.c index d5d60a9af8c5..0fd7dc37e328 100644 --- a/drivers/hwmon/pmbus/q54sj108a2.c +++ b/drivers/hwmon/pmbus/q54sj108a2.c @@ -22,7 +22,9 @@ #define PMBUS_FLASH_KEY_WRITE 0xEC =20 enum chips { - q54sj108a2 + q50sn12072, + q54sj108a2, + q54sn120a1 }; =20 enum { @@ -55,10 +57,24 @@ struct q54sj108a2_data { #define to_psu(x, y) container_of((x), struct q54sj108a2_data, debugfs_ent= ries[(y)]) =20 static struct pmbus_driver_info q54sj108a2_info[] =3D { - [q54sj108a2] =3D { + [q50sn12072] =3D { .pages =3D 1, + /* Source : Delta Q50SN12072 */ + .format[PSC_VOLTAGE_OUT] =3D linear, + .format[PSC_TEMPERATURE] =3D linear, + .format[PSC_VOLTAGE_IN] =3D linear, + .format[PSC_CURRENT_OUT] =3D linear, =20 + .func[0] =3D PMBUS_HAVE_VIN | PMBUS_HAVE_IIN | PMBUS_HAVE_PIN | + PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT | + PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT | + PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP | + PMBUS_HAVE_STATUS_INPUT | PMBUS_HAVE_POUT, + }, + [q54sj108a2] =3D { + .pages =3D 1, /* Source : Delta Q54SJ108A2 */ + .format[PSC_VOLTAGE_OUT] =3D linear, .format[PSC_TEMPERATURE] =3D linear, .format[PSC_VOLTAGE_IN] =3D linear, .format[PSC_CURRENT_OUT] =3D linear, @@ -69,6 +85,20 @@ static struct pmbus_driver_info q54sj108a2_info[] =3D { PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP | PMBUS_HAVE_STATUS_INPUT, }, + [q54sn120a1] =3D { + .pages =3D 1, + /* Source : Delta Q54SN120A1 */ + .format[PSC_VOLTAGE_OUT] =3D linear, + .format[PSC_TEMPERATURE] =3D linear, + .format[PSC_VOLTAGE_IN] =3D linear, + .format[PSC_CURRENT_OUT] =3D linear, + + .func[0] =3D PMBUS_HAVE_VIN | PMBUS_HAVE_IIN | PMBUS_HAVE_PIN | + PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT | + PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT | + PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP | + PMBUS_HAVE_STATUS_INPUT | PMBUS_HAVE_POUT, + }, }; =20 static ssize_t q54sj108a2_debugfs_read(struct file *file, char __user *buf, @@ -270,7 +300,9 @@ static const struct file_operations q54sj108a2_fops =3D= { }; =20 static const struct i2c_device_id q54sj108a2_id[] =3D { + { "q50sn12072", q50sn12072 }, { "q54sj108a2", q54sj108a2 }, + { "q54sn120a1", q54sn120a1 }, { }, }; =20 @@ -280,6 +312,7 @@ static int q54sj108a2_probe(struct i2c_client *client) { struct device *dev =3D &client->dev; u8 buf[I2C_SMBUS_BLOCK_MAX + 1]; + const struct i2c_device_id *mid; enum chips chip_id; int ret, i; struct dentry *debugfs; @@ -292,14 +325,9 @@ static int q54sj108a2_probe(struct i2c_client *client) I2C_FUNC_SMBUS_BLOCK_DATA)) return -ENODEV; =20 - if (client->dev.of_node) - chip_id =3D (enum chips)(unsigned long)of_device_get_match_data(dev); - else - chip_id =3D i2c_match_id(q54sj108a2_id, client)->driver_data; - ret =3D i2c_smbus_read_block_data(client, PMBUS_MFR_ID, buf); if (ret < 0) { - dev_err(&client->dev, "Failed to read Manufacturer ID\n"); + dev_err(dev, "Failed to read Manufacturer ID\n"); return ret; } if (ret !=3D 6 || strncmp(buf, "DELTA", 5)) { @@ -308,19 +336,25 @@ static int q54sj108a2_probe(struct i2c_client *client) return -ENODEV; } =20 - /* - * The chips support reading PMBUS_MFR_MODEL. - */ ret =3D i2c_smbus_read_block_data(client, PMBUS_MFR_MODEL, buf); if (ret < 0) { dev_err(dev, "Failed to read Manufacturer Model\n"); return ret; } - if (ret !=3D 14 || strncmp(buf, "Q54SJ108A2", 10)) { - buf[ret] =3D '\0'; + buf[ret] =3D '\0'; + for (mid =3D q54sj108a2_id; mid->name[0]; mid++) { + if (!strncasecmp(mid->name, buf, strlen(mid->name))) + break; + } + if (!mid->name[0]) { dev_err(dev, "Unsupported Manufacturer Model '%s'\n", buf); return -ENODEV; } + chip_id =3D mid->driver_data; + + if (strcmp(client->name, mid->name) !=3D 0) + dev_notice(dev, "Device mismatch: Configured %s, detected %s\n", + client->name, mid->name); =20 ret =3D i2c_smbus_read_block_data(client, PMBUS_MFR_REVISION, buf); if (ret < 0) { @@ -341,6 +375,7 @@ static int q54sj108a2_probe(struct i2c_client *client) if (!psu) return 0; =20 + psu->chip =3D chip_id; psu->client =3D client; =20 debugfs =3D pmbus_get_debugfs_dir(client); @@ -359,9 +394,6 @@ static int q54sj108a2_probe(struct i2c_client *client) debugfs_create_file("write_protect", 0444, q54sj108a2_dir, &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_WRITEPROTECT], &q54sj108a2_fops); - debugfs_create_file("store_default", 0200, q54sj108a2_dir, - &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_STOREDEFAULT], - &q54sj108a2_fops); debugfs_create_file("vo_ov_response", 0644, q54sj108a2_dir, &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_VOOV_RESPONSE], &q54sj108a2_fops); @@ -383,27 +415,34 @@ static int q54sj108a2_probe(struct i2c_client *client) debugfs_create_file("mfr_location", 0444, q54sj108a2_dir, &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_MFR_LOCATION], &q54sj108a2_fops); - debugfs_create_file("blackbox_erase", 0200, q54sj108a2_dir, - &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_ERASE], - &q54sj108a2_fops); - debugfs_create_file("blackbox_read_offset", 0444, q54sj108a2_dir, - &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_READ_OFFSET], - &q54sj108a2_fops); - debugfs_create_file("blackbox_set_offset", 0200, q54sj108a2_dir, - &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_SET_OFFSET], - &q54sj108a2_fops); - debugfs_create_file("blackbox_read", 0444, q54sj108a2_dir, - &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_READ], - &q54sj108a2_fops); - debugfs_create_file("flash_key", 0444, q54sj108a2_dir, - &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_FLASH_KEY], - &q54sj108a2_fops); + if (psu->chip =3D=3D q54sj108a2) { + debugfs_create_file("store_default", 0200, q54sj108a2_dir, + &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_STOREDEFAULT], + &q54sj108a2_fops); + debugfs_create_file("blackbox_erase", 0200, q54sj108a2_dir, + &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_ERASE], + &q54sj108a2_fops); + debugfs_create_file("blackbox_read_offset", 0444, q54sj108a2_dir, + &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_READ_OFFSET], + &q54sj108a2_fops); + debugfs_create_file("blackbox_read", 0444, q54sj108a2_dir, + &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_READ], + &q54sj108a2_fops); + debugfs_create_file("blackbox_set_offset", 0200, q54sj108a2_dir, + &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_SET_OFFSET], + &q54sj108a2_fops); + debugfs_create_file("flash_key", 0444, q54sj108a2_dir, + &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_FLASH_KEY], + &q54sj108a2_fops); + } =20 return 0; } =20 static const struct of_device_id q54sj108a2_of_match[] =3D { - { .compatible =3D "delta,q54sj108a2", .data =3D (void *)q54sj108a2 }, + { .compatible =3D "delta,q50sn12072" }, + { .compatible =3D "delta,q54sj108a2" }, + { .compatible =3D "delta,q54sn120a1" }, { }, }; =20 @@ -421,6 +460,6 @@ static struct i2c_driver q54sj108a2_driver =3D { module_i2c_driver(q54sj108a2_driver); =20 MODULE_AUTHOR("Xiao.Ma "); -MODULE_DESCRIPTION("PMBus driver for Delta Q54SJ108A2 series modules"); +MODULE_DESCRIPTION("PMBus driver for Delta Q54SJ108A2 and compatibles"); MODULE_LICENSE("GPL"); MODULE_IMPORT_NS("PMBUS"); --=20 2.43.0