From nobody Sat Jun 20 15:20:19 2026 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4616E394780 for ; Mon, 13 Apr 2026 22:23:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776118987; cv=none; b=TqJ25kVCFVpm3b30gHIb1e8GmK42IfcavmDp5+jfcjRHCbUWnhkqeDIPlDJKRMpkP4G77GoYSQGFqPVIfCUB//Furpda4a/Ke0snXRzYqNZnXVl6yFHH9+RHrBfTqwXxNE1GCGFRuMF5GawPYFmBYyFzaZ+ZjPj8hJblIzPx+20= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776118987; c=relaxed/simple; bh=hoAkRbklT4t3UJamP8PVTZTsu+egTx6heIK7H8dG1rM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E0bEUYbvU2WAHylYUyS0cEylj+5V2pi1FrPVN8f+7jBsNJq4Zg+5kpI1Az79uz8BiPTjvZGa9DLdkuULob51djRqr4QOITFHuzjH/ybrqodvpSfY1N5iC5hu9E8MbyLyux1/2jUirNwnJu9Ku8oYCWZseqiLUx477NtdP4XgCUI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=laFiiIZh; arc=none smtp.client-ip=209.85.160.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="laFiiIZh" Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-41c4d660b19so1313991fac.1 for ; Mon, 13 Apr 2026 15:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776118984; x=1776723784; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AfX6HN3Cvr0FuWe5GVmxZakao4YGWPTUap0ZGvN56Rc=; b=laFiiIZhmJNM8ZQKlTeV5/5nm8thompfeXbR1L1mNWsJsfWuG/S6j9g7iKraqH8/iZ s0MaiERPP8q0do5kb4uGH7zP7Wj3wfCOn2bRBL09+WHgsGvMZBX4CJ9AYzqir60Iur2r /CcHLJAaMcvdCzPHfg1M2OGz5A1gaHGDiIJHoe2FsxTCqSm44H4Mw3v6khfaDCJJDt5b Pk8kIusLJ8jlKtN4xmllfBClSIKwsXUUrBl8uqbXSt8Dd8KQRckyqsQoZOfqabaFf7yz GHQokVj5k1CKDh0vvnZxzaAia4zNLbsOaJIGJeha7nBFIGOBxnu38DrVhhPM9GQtdtTM 6NOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776118984; x=1776723784; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AfX6HN3Cvr0FuWe5GVmxZakao4YGWPTUap0ZGvN56Rc=; b=IYcwYhIKSHV5YIQ2EVkrs1OKp+BuDv/5silLGk/7wssvCy6rCn0zPnyFKq+pu8WNZ9 8BggDezSbWMv5mlCTTF5BcpIUpFh36lFjiwAUi9gVw1SEEZUgRYbyOtldSqVrnegN0IR KqHscqaXgafX/O3/kYqdQod4+mdlSPAviDq96BcLwfH1NSFsTO+kCpPDdFJnDS6bETOO GV1irgSZArVVVT+X2nr4vBBe9w9bE0lFE4HNUnm5CLh0AAfUGzST3zd4hQ84I1sApOVF JyAHJ1I0fp7tvr3wF6dkxHqCiN7D0ncZUMsFaAaeZG1Mrt17FxDSHOBpYtB1Jf/hZpdj kE8w== X-Forwarded-Encrypted: i=1; AFNElJ8rNJ20vzn9BUaqqgfkcf0AKHL7O43KH8fMjENY4RVzDxp9RMOS5QiCxs6lM4kBw+ZALwpiljx5qocdVTM=@vger.kernel.org X-Gm-Message-State: AOJu0YzNm1bfuqmpavykDHzWbsTyNg2d1RT0N5/Kmp8ltKYt7gQqtSbi SoRR1nWIOa80Gfg+UDULKLmRhd96k0jpG9XFmFIb/PSCIenjQgHu0oiZ X-Gm-Gg: AeBDietE2PxxlWJQHCgzj0lX0Y5tD3S9LvNW3gYa3ic5dwLNQJmKUrUD/Y3CD3Py8TC eRNzd72SM/y+mSrj9krAlX+w01A7kKErimly02RGLe5LvFVLvRfgtv7sTdnwyvcDDBUNphi8dN5 T+YbLT49JZzr6DzcnnLLC2IW+Ym+yOMLl9I9H3wY1FpqCrYab1CuXh2B4uCDL3kbSQfyvyfef8R 55pHwt4j3w/q9dOQlIpXuiSlYwSc/F613BX+AIVX2JZkjHXRo1r7wftLS1SnnL/B8IxJ74psddS UL+TcY0vX9NTJnjwDfGf1Ue8lAaD/2nROc3SnBy0DN43sgZ+yJNUG2ASozWkRI9zD+HsR16C7Pg hWme7e4OBzytvWu7nbsAR2BceJeCC/Ja9URLd4TJz7Rr98lSEjB9pxJZ3vQZj+5JLLY8DTsW228 +/vu/HnDMUgztFxVKRiBOVrRc+fhXUVgh5SmVo X-Received: by 2002:a05:6870:d364:b0:41c:3225:f98b with SMTP id 586e51a60fabf-423e0e89de0mr8390964fac.10.1776118984247; Mon, 13 Apr 2026 15:23:04 -0700 (PDT) Received: from Dell.cheetah-searobin.ts.net ([2600:1702:56e9:4b40::33]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-423ddb80ccesm9403198fac.13.2026.04.13.15.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 15:23:03 -0700 (PDT) From: Akash Sukhavasi To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Akash Sukhavasi Subject: [PATCH 1/2] Input: analog: Fix coding style - trailing statements on same line Date: Mon, 13 Apr 2026 17:19:27 -0500 Message-ID: <20260413221928.21748-2-akash.sukhavasi@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413221928.21748-1-akash.sukhavasi@gmail.com> References: <20260413221928.21748-1-akash.sukhavasi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The checkpatch.pl script flags several errors where trailing statements are placed on the same line as 'if', 'while', or 'for' conditionals. This violates the kernel coding style and makes the control flow harder to read. Separate these single-line bodies onto their own dedicated lines to conform with standard kernel formatting. No functional change intended. Signed-off-by: Akash Sukhavasi --- drivers/input/joystick/analog.c | 45 +++++++++++++++++++++++---------- 1 file changed, 32 insertions(+), 13 deletions(-) diff --git a/drivers/input/joystick/analog.c b/drivers/input/joystick/analo= g.c index b6f7bce1c..6e1255a82 100644 --- a/drivers/input/joystick/analog.c +++ b/drivers/input/joystick/analog.c @@ -231,11 +231,13 @@ static int analog_button_read(struct analog_port *por= t, char saitek, char chf) =20 while ((~u & 0xf0) && (i < 16) && t) { port->buttons |=3D 1 << analog_chf[(~u >> 4) & 0xf]; - if (!saitek) return 0; + if (!saitek) + return 0; udelay(ANALOG_SAITEK_DELAY); t =3D strobe; gameport_trigger(port->gameport); - while (((u =3D gameport_read(port->gameport)) & port->mask) && t) t--; + while (((u =3D gameport_read(port->gameport)) & port->mask) && t) + t--; i++; } =20 @@ -324,7 +326,8 @@ static void analog_calibrate_timer(struct analog_port *= port) local_irq_restore(flags); udelay(i); t =3D ktime_sub(t2, t1) - ktime_sub(t3, t2); - if (t < tx) tx =3D t; + if (t < tx) + tx =3D t; } =20 port->loop =3D tx / 50; @@ -405,7 +408,8 @@ static int analog_init_device(struct analog_port *port,= struct analog *analog, i x =3D y; =20 if (analog->mask & ANALOG_SAITEK) { - if (i =3D=3D 2) x =3D port->axes[i]; + if (i =3D=3D 2) + x =3D port->axes[i]; v =3D x - (x >> 2); w =3D (x >> 4); } @@ -496,13 +500,25 @@ static int analog_init_masks(struct analog_port *port) =20 if (port->cooked) { =20 - for (i =3D 0; i < 4; i++) max[i] =3D port->axes[i] << 1; + for (i =3D 0; i < 4; i++) + max[i] =3D port->axes[i] << 1; + + if ((analog[0].mask & 0x7) =3D=3D 0x7) + max[2] =3D (max[0] + max[1]) >> 1; + + if ((analog[0].mask & 0xb) =3D=3D 0xb) + max[3] =3D (max[0] + max[1]) >> 1; + + if ((analog[0].mask & ANALOG_BTN_TL) && + !(analog[0].mask & ANALOG_BTN_TL2)) + max[2] >>=3D 1; + + if ((analog[0].mask & ANALOG_BTN_TR) && + !(analog[0].mask & ANALOG_BTN_TR2)) + max[3] >>=3D 1; =20 - if ((analog[0].mask & 0x7) =3D=3D 0x7) max[2] =3D (max[0] + max[1]) >> 1; - if ((analog[0].mask & 0xb) =3D=3D 0xb) max[3] =3D (max[0] + max[1]) >> 1; - if ((analog[0].mask & ANALOG_BTN_TL) && !(analog[0].mask & ANALOG_BTN_TL= 2)) max[2] >>=3D 1; - if ((analog[0].mask & ANALOG_BTN_TR) && !(analog[0].mask & ANALOG_BTN_TR= 2)) max[3] >>=3D 1; - if ((analog[0].mask & ANALOG_HAT_FCS)) max[3] >>=3D 1; + if ((analog[0].mask & ANALOG_HAT_FCS)) + max[3] >>=3D 1; =20 gameport_calibrate(port->gameport, port->axes, max); } @@ -662,13 +678,16 @@ static void analog_parse_options(void) analog_options[i] =3D analog_types[j].value; break; } - if (analog_types[j].name) continue; + if (analog_types[j].name) + continue; =20 analog_options[i] =3D simple_strtoul(js[i], &end, 0); - if (end !=3D js[i]) continue; + if (end !=3D js[i]) + continue; =20 analog_options[i] =3D 0xff; - if (!strlen(js[i])) continue; + if (!strlen(js[i])) + continue; =20 printk(KERN_WARNING "analog.c: Bad config for port %d - \"%s\"\n", i, js= [i]); } --=20 2.53.0 From nobody Sat Jun 20 15:20:19 2026 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C19AB39B942 for ; Mon, 13 Apr 2026 22:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776118988; cv=none; b=bPBDGkAZw1dG7MYZTShpOq99Y11yiCHfKIzB3LcSH6cMUSZIBGQSeava7cF4/er1+r875RMOlxGWdgm60VBHNR+moUsNIe4+XbS3KeMh9T7Xueb463eiiGwhITJmw3iSBM2GOnWCZztzM074Uh54KUBn/8JwuEjeY2e0yU/iiRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776118988; c=relaxed/simple; bh=BkklVpMlhTd+gH7Ejnq/e0uJuCjCLduLhF9pFyVjvCg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NREa3BiB3V8XvtxT4e/1ZA9QkOGP+cRUaYezGY4tQEt6Q0068kBvMWzygSgpcK1EhJIGiwNmjLXRkzlxTyF3BE2kq/mnDE34JO5+Ju2jy3kMnsATnLrRyfPIZQY4E7HlruWyfSBnYyycmVj0AE0MFRLURvt0G7iNBb6h+2Ow/v4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oMk4xTbl; arc=none smtp.client-ip=209.85.160.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oMk4xTbl" Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-4233e152457so3634559fac.1 for ; Mon, 13 Apr 2026 15:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776118986; x=1776723786; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Tzt7ZlPIbuh9m3r4chtO7LLki6qG2/dJ0U5jd5tlIC8=; b=oMk4xTblZBhuqRb2rImcjFniKdDljrLxkoq+nOVNl5CJ/c+mgoaRzgC00dl1B2NEjy uhZHk3q1IWL4fEgTfffGX4gpRO8yscKLMSg0QxWvaQIg9VXnjiww3orNeLJmv9EY4ETN PUPNCnrbvUhyXxNJyjXEZ/g+C8nTBx4x15IYwxKlpY9ETiiwYOJO5rbjTfZtq05ZwMJf JtFwXR8GmxsXfM9RLIBPyqzDWHzx7+RpuGN8NqcnoQ8EUWqJMr3Vd9U4ezaCz7Z6v+YG T5nZWN8MMyj5dwQGwwQII7yUTOOU31uz81Drq9G7EMJd4HDlVRQ7cHBB85l0Xrkt70CV jGQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776118986; x=1776723786; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Tzt7ZlPIbuh9m3r4chtO7LLki6qG2/dJ0U5jd5tlIC8=; b=GGPiyeUapabvQHv9kwmjuHWq9F5AYpv/916g7O+QLI8vhybqVx3TDf3XGlCHwrKGSy nDPKK22dSy6ClJq+EFvsqVUxcXdooyGJWL7vZpoDCQscWWGlloHaaeFG6HGXbkQ1zh4h P9R0q/OH6RjEocISOvzsaBzKF5UmRCUPv6zL4p07MJWQqY3IewAs51cW2bsvETSXdgbR pKThqQ1fFhvpcWiQ35749ymZESKl13slp7gAIbKFXNvaMFIrn8VHN5DeQMEmH+5dy+uv rZ7ezq6vteK0FYkXfBQrfS5bbnvl6pgnzQ7W0hSdUnMO9M+6Pvjubwo8DhuBvOnmowil tIKA== X-Forwarded-Encrypted: i=1; AFNElJ/nBW1yIXYG8BGwk5TyuafnQPkJYK13QvzNNMA9Tv1kBRtjruvt7MbBUl8RNn316Q/nJ3DF1r5W3IDFbcI=@vger.kernel.org X-Gm-Message-State: AOJu0YxWPk2rD9dJfnVRF4Rr1AVz3c23oGYovwABI9x2Hkhk57Ocs2KE eI26WbdGvtHO3TiOShFJhZ5kGsDAkYvxitAgjvaiVbXBifogVKiog41X X-Gm-Gg: AeBDieuQEaGZqNLrviSe1qXC49yV0NpV+4v01yIKuWqDTmgc9VLaDpHFFVwTBDDE4I+ fB0OD7GTt4mFtMbQi6sT7ElhELwnMSw0x4vx1uvCssPNuSmEWBgBzFptbjOcUEKyozDvjjGNEDe GvbOjHtt9eTgTbaO2qjx6CDNtiVgq++0CpAoCu4/CRF3aB3A8QpxvTDTa1ciw15+lE+LCu4RAkE p2qP16GBSEtK1hzp8z9GD2R6xPKP8O8UYfxBbFkNkyIOx45xO1MCDkY0YISVIoEOtP1q+WGNVS4 mGDxeuttJQNNjougnEWCxluYht8OjeWQqQTs5ouoiV3N0iv8niXDP1vV5kGdJmahGUYiXyMnAac eAgZOZQNDCIVYcjsIn/AL8RjQ5w+EFupRqghZoLlrv1HKA7idav8aovJEH7BPueRoYA3ZulWsyT sgiV4QndJd8+Iy2qi+92cmTTi0Hpdd47UxI/lx X-Received: by 2002:a05:6870:5d91:b0:41b:ff2c:de23 with SMTP id 586e51a60fabf-423e0e2c330mr10158863fac.10.1776118985786; Mon, 13 Apr 2026 15:23:05 -0700 (PDT) Received: from Dell.cheetah-searobin.ts.net ([2600:1702:56e9:4b40::33]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-423ddb80ccesm9403198fac.13.2026.04.13.15.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 15:23:04 -0700 (PDT) From: Akash Sukhavasi To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Akash Sukhavasi Subject: [PATCH 2/2] Input: analog: Fix coding style - indentation and parenthesis spacing Date: Mon, 13 Apr 2026 17:19:28 -0500 Message-ID: <20260413221928.21748-3-akash.sukhavasi@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413221928.21748-1-akash.sukhavasi@gmail.com> References: <20260413221928.21748-1-akash.sukhavasi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The checkpatch.pl script reports minor whitespace and indentation warnings in the analog joystick driver. Specifically, there is a misaligned port->loop assignment using spaces instead of tabs, and an extraneous space before a closing parenthesis in the ANALOG_BTNS_TLR mask expression. Signed-off-by: Akash Sukhavasi --- drivers/input/joystick/analog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/joystick/analog.c b/drivers/input/joystick/analo= g.c index 6e1255a82..04fd5b119 100644 --- a/drivers/input/joystick/analog.c +++ b/drivers/input/joystick/analog.c @@ -330,7 +330,7 @@ static void analog_calibrate_timer(struct analog_port *= port) tx =3D t; } =20 - port->loop =3D tx / 50; + port->loop =3D tx / 50; } =20 /* @@ -490,7 +490,7 @@ static int analog_init_masks(struct analog_port *port) | ((~analog[0].mask & ANALOG_HAT_FCS) << 4); =20 analog[0].mask &=3D ~(ANALOG_THROTTLE | ANALOG_RUDDER) - | (((~analog[0].mask & ANALOG_BTNS_TLR ) >> 10) + | (((~analog[0].mask & ANALOG_BTNS_TLR) >> 10) & ((~analog[0].mask & ANALOG_BTNS_TLR2) >> 12)); =20 analog[1].mask =3D ((i >> 20) & 0xff) | ((i >> 12) & 0xf0000); --=20 2.53.0