From nobody Mon Jun 15 20:34:36 2026 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FC52363C77 for ; Mon, 13 Apr 2026 20:03:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776110614; cv=none; b=Qy5wGs2rKockBwAT/R/DCFibo3Sg+h7Is+LoCJt25fJoByclcZnjDgpiNqt8P1qqXUqBh99JKkf6ZIXtntwxytD6agdPVBHUK8gerfbVafBpoTKXSegC8d0Y5OXYqWeI5rDtpvs2zhZ4T8wRVj1zo7dmE0PpYTolxt4Kklx77lg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776110614; c=relaxed/simple; bh=RK80ZR7zAHH9D/WmR/NT9hIJNikhZi7aebHrs+pDa/Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qHCiUGM3/+WQXuThZpkJuUJ92/mZD8egfVZIKluRqPA5KI4+2HKedjxyoZdgY/1mrvgUnC6lL+L8CrIfML20uRl2Z5fD826u/hk2UQI0sZtzUzUKCg38PTj4VwtJEWjM9NBCD9sPtiOOWE534RlTMo4XHHIBWKif0v47Pz1LL7Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fe2bvTC6; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fe2bvTC6" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b9bfcbaa81eso740532566b.1 for ; Mon, 13 Apr 2026 13:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776110612; x=1776715412; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fNtc76u4jCO4flvAdHAjEbdUTCZm4fC6HRp33lJMzlE=; b=fe2bvTC6eqnYe4SDkbtcrQBp4Ud4pXr+uXz/XPkNkSpbclckERb/Cx0SAJ+yMyhmLa g+OqC3HncuKkRMepAl/gw8sJXfiKsW+ampZwImp0ha/l8PKF1E/pX9jk6j/veCJolQF/ SEWTddMQWMqigMxieQs2vIBHbxk6TZVPaIf/82r70Id3MGIykUsDzikutyaKrhMTLkxM jPb1OowuKx2FSfjvpe+Fv1dluQvMtJdmIY9PVrAGUcT5h4nC6hH23qnKC2Sq0rXnQfAH QUE+nB/Eq2Asgcv7MkOH+zOUlJDracIV5VEsx/biy1G0Q9Hxp0RFdmQhvDXiGjie6ggQ nYFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776110612; x=1776715412; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fNtc76u4jCO4flvAdHAjEbdUTCZm4fC6HRp33lJMzlE=; b=qtyRYvhhamofE1iF5gHcm+NwW74Bc4oSuP5ylzutJJLgoFeMcB1wp2278E7etRIpbG DokNj10h3p9wyaT7TVG6KVP6vgaiy9AUugS1BLnZd902a5e8PWnzTw+NnWrcB73vSdD4 ALUO2kAFzBjhdD+WgRJM8eU5rpGC0E8uZJ5Qa7JmwXC1U3FhJ16TpEUPs6mLfcWDPQFT 4uX8G4L4aYDrWSMsVlJwzUwRkF9Y5BIkvy6Yf0mmr9xAXLggO0KOlGGB7xRd/zLN57vq FhMgtylMeTUZL2rq3UUXt/tv1S14rrNNcXkJJEGQsax2Zps55rg8f9Bms5pE6Ic13Xy6 /s/Q== X-Forwarded-Encrypted: i=1; AFNElJ9Dxoq/x7vbTMjLzPlsq7v8ewkBvt0zHyioeoxU2F2WHEfHoYHRrhhKSzhkK+7sMTb3QhH3Sr53/wT6GkE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9iL2p27GtpYCYp1hUeA1CUZ/eo4jAjd2snVeCZJjs307hRyVy mfs32IiLucBpvOgjKK0Vxqz8i1eDenyyCDPOI3uxIpn515HzY4ubarp2 X-Gm-Gg: AeBDies3jrcjTs0hzH7Ez3dAmkzGjq+5qd4raktSGVz10IcZBQLN9/G5CfgDM3s5ksL hBGxt+ikK5yY4yd/ejoQDjjJalsTsbS6Gz9HJYrrAeLQrxK6zzgmnH8MYrUBSUtWE3JaiIwupao RmYSAa03+16GEC/abJzLZ1QISZ3getK7OUcwkz0k9sxVy8BSQ0eYr08e/J5yw5DGitq9fVEGBmg fgMXjmwlkYx20C1BYDbPNOWewzlrZ4uv0VaXhXfdFS6ey8FZnDNk3DxANjkYo/l0dZl8i+rPXj1 PI7re44f7xgyJcuPcuMLBe7B3U9x8BQPd8YwJR9sHRca7eikH46utwWh0D5FZLqIss7XelVOy9y R1Pph9xNUPzyTm1uv7Agr9Bg+4Tt2vJunVy0ekKQiNe2fPGcqsGr4KBgcI7FiO/nue/nUNPh2fB JK4PehKbA4lfbmznZ8oRM+a0T5gah+oEw0+sJCfLTHQeA2pUcqs6v9jNotUCSVngk2miKAgDIey ZfIyPWnURQGVCqA9pl/QBaPWR7tz7DawL9GvTt3eKamhXVhmR7P2Gplc0Lriu88WUUpzWIjWWAq a56Uyw== X-Received: by 2002:a17:907:c80e:b0:b96:f863:deba with SMTP id a640c23a62f3a-b9d7298089dmr856237066b.32.1776110611361; Mon, 13 Apr 2026 13:03:31 -0700 (PDT) Received: from ahossu.residents.sin.openfiber.nl ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6dfd76b8sm339842166b.20.2026.04.13.13.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 13:03:30 -0700 (PDT) From: Alexandru Hossu To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, error27@gmail.com, linux-tegra@vger.kernel.org, marvin24@gmx.de, Alexandru Hossu Subject: [PATCH v3] staging: nvec: fix unconditional pm_power_off teardown Date: Mon, 13 Apr 2026 22:02:03 +0200 Message-ID: <20260413200203.726726-1-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260413151236.612404-1-hossu.alexandru@gmail.com> References: <20260413151236.612404-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" tegra_nvec_remove() unconditionally sets pm_power_off =3D NULL, even if nvec was not the one that registered it. This breaks any other driver that may have set pm_power_off to its own handler. Replace the unconditional assignment with a guarded check so that pm_power_off is only cleared if nvec was the one that set it. Also remove the stale FIXME comment, as the guard addresses exactly what it was asking for. Signed-off-by: Alexandru Hossu --- v3: - Drop incorrect Fixes tag v2: - Drop nvec_power_handle =3D NULL; after pm_power_off is cleared, nvec_power_off() is unreachable via pm_power_off so there is no dangling-pointer risk (Dan Carpenter) drivers/staging/nvec/nvec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 2a3499dd4d63..88c416ee0381 100644 --- a/drivers/staging/nvec/nvec.c +++ b/drivers/staging/nvec/nvec.c @@ -906,8 +906,8 @@ static void tegra_nvec_remove(struct platform_device *p= dev) nvec_unregister_notifier(nvec, &nvec->nvec_status_notifier); cancel_work_sync(&nvec->rx_work); cancel_work_sync(&nvec->tx_work); - /* FIXME: needs check whether nvec is responsible for power off */ - pm_power_off =3D NULL; + if (pm_power_off =3D=3D nvec_power_off) + pm_power_off =3D NULL; } =20 #ifdef CONFIG_PM_SLEEP --=20 2.53.0