From nobody Mon Jun 15 20:35:14 2026 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 364AE3E1236 for ; Mon, 13 Apr 2026 15:47:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776095269; cv=none; b=kV88Z512l41GSl0f5/QO4WulhFjXIoF5qKDW90yFaTikAb+2ZsaDX9fYhhYtMA41ELQSCx9CFteXp3pru5+zNbDLa3SXo+lpw/wTXpNL1bxjMmUAjSxtG9pz+hSfzRZHapZqFy/q0MVrdLCI7hpr75/p1IYwHigkOJ5gWOo+xDY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776095269; c=relaxed/simple; bh=m32e0BfF2n/Y3VoUao/TEjPR9SWy1+CRfNSxFuYq/LY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Zfq69dM9liaDjEbwWjcQqWYy6KoxLaLbDTVRQE4ezRbAqeZ4/iVbENwtvITLEztg2i/Xn9umrtdW8//r83gzu5hCriKAJFklcxGglpF1W2SwCeQ8tlYEC2xAYqhKsHPoRhvbNkVVXJRdO7o6opromJiiVlpcB2A8qA635NfEIC0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BK48yKlM; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BK48yKlM" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-35d90833cacso2802101a91.2 for ; Mon, 13 Apr 2026 08:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776095265; x=1776700065; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1OPjx6EVJFqbaOhHASpBQer7/3sJPyccCGPM9+uBgBU=; b=BK48yKlM0iqpj1otkrYBi9qjUboIGTW9LAW0oNIyMLjfYB8e+6nYVVZilA2T5hFAXP Il3vSl8TyU2FPt5CXDHcoiZje7iSAJBm8zLK8O3MRjVopl9VA3S+ZTzZR+9wJnNW6WE4 +MNI5GCKve7rzZzzBx6+8z3N7d+QEmNepkFgwq5/vxFo3kn3wy1o4B+XvsffdcTO901n /UDR4jVuO1IG1O6MqL9taEiMcLt0mi2hsZLKGKMhEEXDNVqotw0eqU2sjyVdhy3ZXZW+ SSTzj40F1xk7eZHeSDZhxyct1+4DyiV4mNdayyttCwxwdZrfy/Qxd6nMieVvjdLxcX1k sKSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776095265; x=1776700065; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1OPjx6EVJFqbaOhHASpBQer7/3sJPyccCGPM9+uBgBU=; b=oCb9uPUFgFzBisdd3PlEBZFdFqt+EUBdcZN9qEmbAJO18vDIkBU18jV0iWRCjrb1yU PohUdeXQIMc9TnXoBBkTk6FL0f/E0fCBS7tx6qbEzTvTsNsG9kfLZBEFwzmIFh0Zm1H2 POM+73L2uomPnQbFt1Rfbj83JPZCUtx21msX3cL8NRc6wbFA+bWurawDyjQX21h8eVkj EYfqhwtKT1HEwOBP8xR/udijD1/VdqmLUnJjVzCqnYSK/t2TyTTf2ySAc5fLR5VQY4Bu 4X7J4TmjxvP0+in1Xl3UDCylllJ85ydQki7x0GveO3VeNrtQVeRCWHFKpYlheF/Ih5ET zrHw== X-Forwarded-Encrypted: i=1; AFNElJ/RWsDpRgONuYfDG5o7vz8GI+ot8rPf6k+3TsKGkHAtnCZxSAnZHG/kBQTK7pFz2L830V4sp1LhZfqpVf0=@vger.kernel.org X-Gm-Message-State: AOJu0YwX5S/s5dZ4kMqlKitnVlxKffTLM9FDg8HmkaVBp1w5JC4U8fgE Ie+chqJ9KSKguTlXXOPZ1TgrY8chibASbJN1oH0L+E6v6Hp/oyZk4HoU X-Gm-Gg: AeBDiev0/iK+23tyUQ7FMB0FTItWEnUyvCNM4kKPx/UWZKS0UCLcJpgl6F/FP1swqfn drde3HjpY7v/zdEnvd9/NMOZH26FPa8aJOhAXpZWgvNbLzZyWpDbTkqu4HdVPohKHpvg4yFvTTq tuWmYLdF3wQTHq5SyjveJG9mz7XFciPQlxJA+Scei8EIAWCdqV5qHqr0uTSd+cAZO74u+CoaSsa rWMQ1fMPrs2RWgkjUaE5anuYD900ObKz3bwBwKYRkX5x+eBM76tTlGgXh0DzlLyEqYtgkF+MuzA XJczlL+habgroJu9wFGVs7HrrT60y79y59CY61PdFA5Le/GoeHjCjRKhKJ0EEwA4kCvNeKP5rLO vcziLK+ODGQABBq3lJ/kKRq/SXQokkMa/Pd3gxv+N8be5VJPJtlHyRb6asMYFzBjUnUFPzHXMGO Fk7m5crNlT8Bp6I5LFTA51K4Fu/80ogcw= X-Received: by 2002:a17:90b:3c48:b0:35b:e690:c5ad with SMTP id 98e67ed59e1d1-35e42849e8cmr14289796a91.25.1776095265313; Mon, 13 Apr 2026 08:47:45 -0700 (PDT) Received: from lgs.. ([2409:893d:1188:142d:edd0:8593:d07a:ab64]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7921a20100sm10228887a12.29.2026.04.13.08.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 08:47:44 -0700 (PDT) From: Guangshuo Li To: Linus Walleij , Imre Kaloz , Daniel Lezcano , Thomas Gleixner , Guenter Roeck , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] watchdog: ixp4xx: fix reference leak on platform_device_register() failure Date: Mon, 13 Apr 2026 23:47:27 +0800 Message-ID: <20260413154727.3051321-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ixp4xx_timer_probe() directly returns the result of platform_device_register(&ixp4xx_watchdog_device). When registration fails, the embedded struct device in ixp4xx_watchdog_device has already been initialized by device_initialize(), but the failure path does not drop the device reference, leading to a reference leak. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fix this by calling platform_device_put() when platform_device_register() fails. Fixes: 21a0a29d16c67 ("watchdog: ixp4xx: Rewrite driver to use core") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Linus Walleij --- drivers/clocksource/timer-ixp4xx.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-ixp4xx.c b/drivers/clocksource/timer= -ixp4xx.c index 720ed70a2964..924dbd58c4da 100644 --- a/drivers/clocksource/timer-ixp4xx.c +++ b/drivers/clocksource/timer-ixp4xx.c @@ -239,11 +239,16 @@ static struct platform_device ixp4xx_watchdog_device = =3D { static int ixp4xx_timer_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; + int ret; =20 /* Pass the base address as platform data and nothing else */ ixp4xx_watchdog_device.dev.platform_data =3D local_ixp4xx_timer->base; ixp4xx_watchdog_device.dev.parent =3D dev; - return platform_device_register(&ixp4xx_watchdog_device); + ret =3D platform_device_register(&ixp4xx_watchdog_device); + if (ret) + platform_device_put(&ixp4xx_watchdog_device); + + return ret; } =20 static const struct of_device_id ixp4xx_timer_dt_id[] =3D { --=20 2.43.0