From nobody Mon Jun 15 19:06:01 2026 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 094D23C9EE8 for ; Mon, 13 Apr 2026 15:14:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776093255; cv=none; b=PstwaV785kBIgj2ZiN/iYDBNcSeES/tNvnZCSGwjiP80xC+Jxy1SYUOsZcuMK4ro48ccpXACOrx2oN0eJBl1OBqpyac7HLbcW0tz2u0SajmiATuqEU0XO1GZVCe6VVccNBPO5FvYZJyWp5RMnJwZn0wlLewWHi1r6f2Qhv8kEvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776093255; c=relaxed/simple; bh=wLnKz0lTNl3u6Hc5SEDvuWJmbFpREBwXZsvmW+L1huQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Yrnjrm0PROqfBvFbGwJet/7E1AsKhJ3COHGOY4w9cGxRZxJiSIPNtu/pqGAKSHLZKRq/FvU99STxmZg0r9OcvzKtI06nc2JmyVPHa3Fsn2uEglnD7N0OxWAX/0m+DT9H4eva28kvrD/uiSkMCHefiNxv57urUHQJjKhDUhFjPJo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jfh2DF49; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jfh2DF49" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-671ab90fc1fso942603a12.0 for ; Mon, 13 Apr 2026 08:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776093252; x=1776698052; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=siLykDQuPSI0K3YOTzdJt9UJ6NmzQ8lrmgay3bCveqg=; b=jfh2DF495sMJ8Sn3lOZni2srcAzTGOqLtu5IdKOVuvDouo/mORVthzQU5VwmN+5Cuc 9Rlxv1EZ/2XTHZ9NxH5eRNZLrPA9hvKdW37zxOM+CubqP+1c8MjOscDIaL2D6oCBKgdP KjmgfZrXqHtxZpsoHVG/jlFgm1I8QJVIVJBf/L5oPDh1FDdFNXSWyeJdkEnw3i3eHftl FkXQLzc6kiW3mZPfg6khe9Pf5hiOx6K+PPVD2fa3RmkCj2/rtCB91YLAzd2D9kBAteBu lk5XKXNjnkZywsOCnZBb6Jgy3KyiAvOiivsLJ3g4B/MW2mHBfzyd30YgxOZ9zWHuaxoG YRtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776093252; x=1776698052; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=siLykDQuPSI0K3YOTzdJt9UJ6NmzQ8lrmgay3bCveqg=; b=adEaUw5iDTvcy8SBM/HCK3mvgmfx3n53h82oFxE1ixNdOTd59vHku+C/pArc4kU2sP wLUE9xtFKRousTyiaWeQAHeiJJ56lmboa6i5foiA6x5Il2Pf3jVBcQYM49tvaRfJbRla XACpkGJWp/V9AwTcfcDb6FnVsZIpRvRoNhDv+hRLXVe2il4RkneyBmV5ZZh8LfCDDHP0 jXexhGtNzlAGn2FPvGBxw4MRkpG1Yagh5gBrrbEVCMGOMfvgtu/FJyXPTCy/tiv/a6fP dl4Ppged7PPUbHBSdCxP0HlFPnAELKHTeg/IqPcr0B/j3fEN0nu5tgLk94dVrmqUXYrL kNWQ== X-Forwarded-Encrypted: i=1; AFNElJ8mp3H4DTlZ+0EfQlTLWF0oTZTXv4BDNNcDgqZWfqEUazOCnkj5h3puhQnsYoOrW/2geAzOfQcxz+hKFCM=@vger.kernel.org X-Gm-Message-State: AOJu0YycM0eyiLKEJsHqt8kH5SZ+RxSCVltyehWcI0bN9XbBkzZcBFPF f/nsFdlUMz8ChmXs84GynjkrGvRkhKMU3w3La4nfeRPr0pgC9vikKu51 X-Gm-Gg: AeBDietWTsnZBcP3mJKTrttNJF5EbJLG0S+pB36oBP8sDt64hMipGfmLxFJQ1MV8+yV 3w/ibk/Q3Rykg4LYGuEPpEIBD4r+ov63C3aK+3SzvHYJ9SHsb3I9y3Nho1wmg8Z/0BODyLhbSQw VmnbUzBXuPgdLdqQv5e7zDyhUIZ4FsZw7tvrrxNWbz/LnANBPmAoXebH32EY30GwtC0rJdxqnGO +FYmrRmDQ5s88wFoiGIbUeyYk+NyauNEzThP8jR6Bi7MuaPBU+5WtsBCYae584vDDRSyRudMUva 8hpIryn3shWZSyToCvbwicWtErryrwrTtAdIwEdcqgfwJCsuvEKVL1CeOAfY9ZmOoKRD/xRZ0nQ R4JPK5jrUnhzzhoLhO0TqtWr2Run1wDJOm/01HAgI7o5PLX17A4kxmSHLAsBtCt9kTsvKS3+GUH zjS6E1oW1jLY8umeD+pQ6bsrgZN9wp4Hhvdf1SXq/MBsMz71NldTK46N43kvA2SarFaRgb7RyPo D1gW3c7PzwyipvglRlLV/oSR8i4HwiKnctfeapy3cZ/oeM24A9BLVkqwOU+YrDKaVTQ9CG2Akqg jkBLTYZtolMMaQKs X-Received: by 2002:a17:907:8e16:b0:b9d:6cef:95fc with SMTP id a640c23a62f3a-b9d7267e295mr773185066b.35.1776093252053; Mon, 13 Apr 2026 08:14:12 -0700 (PDT) Received: from ahossu.residents.sin.openfiber.nl ([88.202.160.248]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6dfd77dfsm323472966b.18.2026.04.13.08.14.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 08:14:11 -0700 (PDT) From: Alexandru Hossu To: linux-media@vger.kernel.org Cc: sakari.ailus@linux.intel.com, bingbu.cao@intel.com, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, error27@gmail.com, Alexandru Hossu Subject: [PATCH v3] staging: media: ipu7: fix double-free and use-after-free in error paths Date: Mon, 13 Apr 2026 17:12:44 +0200 Message-ID: <20260413151244.612492-1-hossu.alexandru@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In both ipu7_isys_init() and ipu7_psys_init(), pdata is allocated and then passed to ipu7_bus_initialize_device(), which stores it in adev->pdata. The ipu7_bus_release() function frees adev->pdata when the device's reference count drops to zero. Two error paths incorrectly call kfree(pdata) after the device teardown has already freed it: 1. When ipu7_mmu_init() fails: put_device() is called, which drops the reference count to zero and triggers ipu7_bus_release() -> kfree(pdata). The subsequent kfree(pdata) is a double-free. 2. When ipu7_bus_add_device() fails: it calls auxiliary_device_uninit() internally, which calls put_device() -> ipu7_bus_release() -> kfree(pdata). The subsequent kfree(pdata) is again a double-free. Note that the kfree(pdata) when ipu7_bus_initialize_device() itself fails is correct, because in that case auxiliary_device_init() failed and the release function was never set up, so pdata must be freed manually. Additionally, the error code was not saved before calling put_device(), causing ERR_CAST() to dereference the already-freed adev pointer when constructing the return value. Fix this by saving the error from dev_err_probe() before put_device() and returning ERR_PTR() instead. Remove the redundant kfree(pdata) calls and fix the use-after-free in the return values of the two affected error paths. Fixes: b7fe4c0019b1 ("media: staging/ipu7: add Intel IPU7 PCI device driver= ") Cc: stable@vger.kernel.org Reviewed-by: Dan Carpenter Signed-off-by: Alexandru Hossu --- v3: - Add Cc: stable@vger.kernel.org (Media CI) v2: - Add Fixes tag (Dan Carpenter) - Save error before put_device() to avoid use-after-free in ERR_CAST() return value; use ERR_PTR(ret) instead (Dan Carpenter) - Apply same fix to ipu7_psys_init() (Dan Carpenter) drivers/staging/media/ipu7/ipu7.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/staging/media/ipu7/ipu7.c b/drivers/staging/media/ipu7= /ipu7.c index c771e763f8c5..310e3f24e571 100644 --- a/drivers/staging/media/ipu7/ipu7.c +++ b/drivers/staging/media/ipu7/ipu7.c @@ -2169,21 +2169,18 @@ ipu7_isys_init(struct pci_dev *pdev, struct device = *parent, isys_adev->mmu =3D ipu7_mmu_init(dev, base, ISYS_MMID, &ipdata->hw_variant); if (IS_ERR(isys_adev->mmu)) { - dev_err_probe(dev, PTR_ERR(isys_adev->mmu), - "ipu7_mmu_init(isys_adev->mmu) failed\n"); + ret =3D dev_err_probe(dev, PTR_ERR(isys_adev->mmu), + "ipu7_mmu_init(isys_adev->mmu) failed\n"); put_device(&isys_adev->auxdev.dev); - kfree(pdata); - return ERR_CAST(isys_adev->mmu); + return ERR_PTR(ret); } =20 isys_adev->mmu->dev =3D &isys_adev->auxdev.dev; isys_adev->subsys =3D IPU_IS; =20 ret =3D ipu7_bus_add_device(isys_adev); - if (ret) { - kfree(pdata); + if (ret) return ERR_PTR(ret); - } =20 return isys_adev; } @@ -2216,21 +2213,18 @@ ipu7_psys_init(struct pci_dev *pdev, struct device = *parent, psys_adev->mmu =3D ipu7_mmu_init(&pdev->dev, base, PSYS_MMID, &ipdata->hw_variant); if (IS_ERR(psys_adev->mmu)) { - dev_err_probe(&pdev->dev, PTR_ERR(psys_adev->mmu), - "ipu7_mmu_init(psys_adev->mmu) failed\n"); + ret =3D dev_err_probe(&pdev->dev, PTR_ERR(psys_adev->mmu), + "ipu7_mmu_init(psys_adev->mmu) failed\n"); put_device(&psys_adev->auxdev.dev); - kfree(pdata); - return ERR_CAST(psys_adev->mmu); + return ERR_PTR(ret); } =20 psys_adev->mmu->dev =3D &psys_adev->auxdev.dev; psys_adev->subsys =3D IPU_PS; =20 ret =3D ipu7_bus_add_device(psys_adev); - if (ret) { - kfree(pdata); + if (ret) return ERR_PTR(ret); - } =20 return psys_adev; } --=20 2.53.0