From nobody Mon Jun 15 20:34:36 2026 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8012C3CCFBF for ; Mon, 13 Apr 2026 14:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776091228; cv=none; b=T47YE23n3UJ9u7f+e27200RxO1o7rlEt1Gz7WQWEuQviNbseVMjYk/JlX/nKYfe9uk4dvSLqRunrzOLXrOXwP31aweyveu+UEvCmbrzGlfbAMyg6Kd9aXVMonAR1x5ryf+GB00UixvvGA69pqHI+ekfoy7mWCvBlQOgkrLmunfM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776091228; c=relaxed/simple; bh=Jw0XkZ7XWVBzbCd5mSi84uhH+sbZPXMd+k/pKIf64fY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nW9smg+EoyizR1tbN9hHz6/BduHkUE346tXupQoOMu6cM3wBdV+TjMAI6sPhMkXZhqFF732eE5NeAZVcox5/OPiCOUuHiM6vSN4PkPKUMc5QWXnfnhTWGSr9wjRM79PHQgEVeYfAL8d+V8lV046QhwxQVhfZjYvsrimIfbF3lrY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=juwYBLn0; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="juwYBLn0" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-354a18c48b5so4119151a91.1 for ; Mon, 13 Apr 2026 07:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776091227; x=1776696027; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=n8HqkCsPnBTjXRg2oQ6IzHB28nfSYPnxw8XmrlaonnE=; b=juwYBLn0Z5aUwHRa+2FkKoBLOlJBqWnUDKG8YfoObvoJQTKb9defbYcu8XNnnuByAH 6/r6UgLLetjpaT+XsH1F5T6GR6gj8iNbBI85fD3nYVqRNCYZcTT/yosp98LvCRP7hcPG 1xpfRye+hcqwbrsPjSH7D+s85eB9Jaz952E0LCPTTSkoCatrOtjwqsQp2qOY4Q32y2eL gdx2uhALPFfcxtkGChjmV+FMSxRy5SxEz1IrsxtsqzHiSnqSfz9Dkk6QDnKumtwEjmTU Th2LshJmzAgMNq02WwjdgPVuo8yTkVrFbi4X/xtIn9OMmRZ0VlFia4jUeg/jP9A+UXSe Z2Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776091227; x=1776696027; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n8HqkCsPnBTjXRg2oQ6IzHB28nfSYPnxw8XmrlaonnE=; b=P31uahKWYpEDJGAonrJwZkwP6nWqH0t1z6Qqo5ELLvBje6CujS6UdzBoe/EStjSp0u nVfuhTYTxj94LoPhkiIkcTcW22D/tzIGSZEzgj/M5UV0tPZMEInaS55UAYOaNi0DCibH 4AhFEhrlOu9dX/HNH66ZG29EmnKIR3dLKTWiK2sXQrUCa/k1iqUs4aAJ2B6PS0a6mNXC x/iBuKD2D2HPUWgzBTBb0kQpJjWDaBXMpQL+K13CbVK2pOUy0hjoERJ2o0Tmo3wS9e0u 3M1cm4oYLljx/IO8Ygu0GowGghxvudTxKcHv/C/dyiCNDJmX5iFM6hLNiFFlkVJa1ir5 GpMw== X-Forwarded-Encrypted: i=1; AFNElJ/5ZnCqSciBUtL01bLgJyeBtqNQ94UG6+FThI++8e6WfZYw4Pziq5icvYEF4MM96wHgrDWWqbjmCCINhQU=@vger.kernel.org X-Gm-Message-State: AOJu0YxV3lLnX3h4aKbrl5XPeC2ZpKp5UUG1W0PzawZhawR2E3z9KGOy pL95B2sud2DXtGGWF2v1aTE8lzl7DgnoMjFurpkyd04Vmidqd5PtuwXo X-Gm-Gg: AeBDietbAK/0BV18YRStJHioogL2F5vr72kXnd33zhek7mc9Ix0andHFdo6uP0HYdC5 Kfj3DfF3A6quuliaUs4G8+L9XJ2I5T733ChENWStVvSwNAIC7q+YlzugR5COLisHVWRoSzSLpke CIpEZ7TIQSqCXoZ3jkV/IEiY/+zvPI9R8Ulc/vF7iVWzbBcYOMasK4yhhP0t3TXYmNfKQnnKEGd SYOcNaOLR5o+HlHw7dm1ZDXT14L77sT+4ydT/iiFJJY+jdEXlUcqlG6s0hL2EFGYUs2UrMltzSA jEh1ZwTGVa1g5A6wdlHfJ9SobSvjQMsoG+9jrfrXUPn8KZWEFADeWNgcARHgPxKt6/lfb5YeFCh LR08mUolo0HMxc/mPgezjeUYTKOgHD5ZHzBTnwlPGr85kq1hKHHFHx79+vdEjmaDou5zTwB0Ihu vzsK92CdrUMPooqzk/fAyiAyATfPkN4OI= X-Received: by 2002:a17:90a:e7cc:b0:35b:e593:b1d7 with SMTP id 98e67ed59e1d1-35e4277fe50mr14632268a91.12.1776091226802; Mon, 13 Apr 2026 07:40:26 -0700 (PDT) Received: from lgs.. ([2409:893d:1188:142d:6c67:74e8:5200:1f39]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35e412233ddsm12701563a91.5.2026.04.13.07.40.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 07:40:25 -0700 (PDT) From: Guangshuo Li To: "Vaibhaav Ram T.L" , Kumaravel Thiagarajan , Arnd Bergmann , Greg Kroah-Hartman , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v2] misc: microchip: pci1xxxx: fix IRQ vector leak in gp_aux_bus_probe() Date: Mon, 13 Apr 2026 22:40:12 +0800 Message-ID: <20260413144012.3009310-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" gp_aux_bus_probe() allocates IRQ vectors with pci_alloc_irq_vectors() before initializing and adding the second auxiliary device. When pci_irq_vector(), auxiliary_device_init() or auxiliary_device_add() for the second auxiliary device fails, the function unwinds the auxiliary devices and ida allocations, but leaves the allocated IRQ vectors behind. The issue was identified by a static analysis tool I developed and confirmed by manual review. Add a dedicated error path to call pci_free_irq_vectors() after IRQ vectors have been allocated successfully. Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus driver = for the PIO function in the multi-function endpoint of pci1xxxx device.") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v2: - note that the issue was identified by my static analysis tool - and confirmed by manual review drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c b/drivers/misc/m= chp_pci1xxxx/mchp_pci1xxxx_gp.c index 34c9be437432..5e1f99a35100 100644 --- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c +++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c @@ -93,14 +93,14 @@ static int gp_aux_bus_probe(struct pci_dev *pdev, const= struct pci_device_id *id =20 retval =3D pci_irq_vector(pdev, 0); if (retval < 0) - goto err_aux_dev_init_1; + goto err_irq_vectors; =20 pdev->irq =3D retval; aux_bus->aux_device_wrapper[1]->gp_aux_data.irq_num =3D pdev->irq; =20 retval =3D auxiliary_device_init(&aux_bus->aux_device_wrapper[1]->aux_dev= ); if (retval < 0) - goto err_aux_dev_init_1; + goto err_irq_vectors; =20 retval =3D auxiliary_device_add(&aux_bus->aux_device_wrapper[1]->aux_dev); if (retval) @@ -113,6 +113,9 @@ static int gp_aux_bus_probe(struct pci_dev *pdev, const= struct pci_device_id *id =20 err_aux_dev_add_1: auxiliary_device_uninit(&aux_bus->aux_device_wrapper[1]->aux_dev); + +err_irq_vectors: + pci_free_irq_vectors(pdev); goto err_aux_dev_add_0; =20 err_aux_dev_init_1: --=20 2.43.0