From nobody Mon Jun 15 20:34:29 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0993E3822A8 for ; Mon, 13 Apr 2026 14:36:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776091017; cv=none; b=rzuyuBskMCoGjKbAYq91zWSNDSsvuu9k2yPOxh6ibaFMbXgI/w638Kc9JBX08Mc5h3h+IIMAgGBotJp8wGRAfi5RK9CbH15fU8wnCk/IeZX8/QBke+cljNCuZedbqsiVaVh1Rf+EgjAGHEvXfEr+3x6wyXKAozAnmz/S+AE4PDs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776091017; c=relaxed/simple; bh=CQiPZwiXn4m65gWkVZkLBq+sWyMmqdp49enY7UbBcTI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=l3gB6eIiiHtistWRbV7L1PNQTnEzTY920Hpy+lSZLG4qtnZyQ5TSO08tcJfBuMmjV9TK8cGKdBFCN+q4oCP/3mJqMk+ks64Juwrv2+makY6ZEp/ofRNFp9UDEE3xn7jjcRX7KmRzvHBVqhlNz1KpXubnn33RN7Lpu8FjLo4j1os= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pkA26Dz2; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pkA26Dz2" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-35fc258aaa4so162928a91.2 for ; Mon, 13 Apr 2026 07:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776091015; x=1776695815; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HZuCdLfTzqLBe0povKqAJGPUREmpR9XWI6MvS95wZIM=; b=pkA26Dz2LkVUJUFhNcw6QvzUml0nmMYLe93yOINZbfo4ah8f8fJzZqLONoPmONP3Ql oC5mXPTUm6idBGU4Xp+moUK0RJRn39zc7Ww0ANa6Bx4DocuNejXWawV1lAJXbvlRzABN TQ8WAR5ygL6J72L1K7y+dzI11/EyOJ8VPkT1p6D/yQ4/HmSIrGEmD63O+C8KqXUrbKpu NWTK/jcjXes9alHK4c1w6j3BbW9egysCYgMjR8cRsb2EfbqxbLhjGq5y7uWkJ/+v5Evf ToUUKfEHIz1bzDw8NZELT2EZszN39p8Sp+9oOyhayeyHR9vmqOTa6Xxtsfmxy67duvzL hHXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776091015; x=1776695815; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HZuCdLfTzqLBe0povKqAJGPUREmpR9XWI6MvS95wZIM=; b=Tj0stY5hBwafuqBi2oPODIYyQo6vSSa4s2+0qvRK352KhyE3CbcyvtbV4TQhDaga43 4OCV4jhMclxq0FEE3yRHbYAAzuqW0eriFgUfls+V4V1GWLqjRM1cvETECTHX6dxK8ucw 0Z/+GUqoMM6V4tPdPyZPixGNEN/BL+xssro/PTciJwa7C+tfjN+y7iTy9aiq6oT9Ki8n HlWeLN7IJBNuN7viqotT3wMS/qGHPOKTYKwzyH4ck8jFCWULz0zx7by4izyCuFpTrqZv QJf5GtUxFFg5uuXZ8AwJhYVbC+NoO5Pr6iqWqECwIuxGTUGsbVecK6uwJE97wDJjkEwS bfkw== X-Forwarded-Encrypted: i=1; AFNElJ+Df5cQHZ0Q+zLmdnIF5uD8Y3eN5ThoxFcshOuiJOmcRupRI9mQGWwqXrXwj98VhRXLBMm0Xdac6+YuUvA=@vger.kernel.org X-Gm-Message-State: AOJu0YzO22Qnf+22yOUjxblQVeStjxFx7dbtEcdIYQpPbUj5O0GIGIpf TKUzWTFZBq5uzR8Z0Hn0BErA5ixS8ruhyupJNAewHlHHPTqt5kgmfJa5 X-Gm-Gg: AeBDieswIz9G3tq77DBc+cGYsNO2hpZcml8v/eG/HHzz6VFaCtYkWV3r3pQZ3Vk8cTZ DKHlXnTrKlqa02O9TDojyBNa27CJSNUw+p+dRqv977v/4J7VXRd1WbwZv45BW91ALcMAzpnR0NH PI7hX1m38xOOuPbNsEx7jJ4VFKGI0FB/0Ju0sGxjpKF44eytx50rYrpmXKHNrVdPKVyYbdW2aeM zCpnvfcjmTpapScbyI6TUBMikvsVPbIIiuejugDV3QElBv94zUYW2srx9DOWasJ69EIVUZFrb+o 3t5SUpHj1Qa5zenr3+FHfIwZ/uFWT6qX29nVpNt9EcP2/8nFxJL4Uk0r4MOh5O2e43twuhFl7y1 h/8+CBtrdqwiMLHYfwS4BoAkLRlYVtaQwsMu2WDAdc50gd88u64Mjmmqx8n53KxRqt51P5w/dZV I5oL2HPxamFSLhO7HQ5ZXkR9EKzVQWSoA= X-Received: by 2002:a17:90b:3c85:b0:35d:a4c0:a0ac with SMTP id 98e67ed59e1d1-35e4278b922mr13246756a91.3.1776091015423; Mon, 13 Apr 2026 07:36:55 -0700 (PDT) Received: from lgs.. ([2409:893d:1188:142d:6c67:74e8:5200:1f39]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35e3512f41bsm15826120a91.9.2026.04.13.07.36.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 07:36:54 -0700 (PDT) From: Guangshuo Li To: Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Conor Dooley , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v3] clk: starfive: jh7110: fix memory leak in jh7110_reset_controller_register() error path Date: Mon, 13 Apr 2026 22:36:43 +0800 Message-ID: <20260413143643.3002454-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" jh7110_reset_controller_register() allocates a jh71x0_reset_adev with kzalloc() and sets jh7110_reset_adev_release() as the release callback for its embedded auxiliary_device before calling auxiliary_device_init(). If auxiliary_device_init() fails, the function returns immediately without freeing the allocated rdev. The release callback is not available for this path, because it is only reached after a successful auxiliary_device_init(), for example when auxiliary_device_add() fails and auxiliary_device_uninit() is called. The issue was identified by a static analysis tool I developed and confirmed by manual review. Free rdev explicitly when auxiliary_device_init() returns an error. Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock drive= r") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v3: - clarify the changelog to describe the exact failure path - note that the issue was identified by a static analysis tool developed by me and confirmed by manual review - apologize for sending the initial public posting as v2 by mistake v2: - initial public posting; v1 was mistakenly skipped drivers/clk/starfive/clk-starfive-jh7110-sys.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/starfive/clk-starfive-jh7110-sys.c b/drivers/clk/s= tarfive/clk-starfive-jh7110-sys.c index 52833d4241c5..55cd0ccbdb84 100644 --- a/drivers/clk/starfive/clk-starfive-jh7110-sys.c +++ b/drivers/clk/starfive/clk-starfive-jh7110-sys.c @@ -360,8 +360,10 @@ int jh7110_reset_controller_register(struct jh71x0_clk= _priv *priv, adev->id =3D adev_id; =20 ret =3D auxiliary_device_init(adev); - if (ret) + if (ret) { + kfree(rdev); return ret; + } =20 ret =3D auxiliary_device_add(adev); if (ret) { --=20 2.43.0