From nobody Mon Jun 15 19:26:53 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B80483DD501 for ; Mon, 13 Apr 2026 14:21:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776090101; cv=none; b=YCVrh2MhtQ+tzENBijaDtw4pcEiq7gK0wL2f9kG0IQ7NFSfe5Wk3WF45c5iz/P9mL2vl92X79gwpb5Anhvwz1IRHe1ICjWa0u0H72Df7a1VKPbcuO5bEvwpxcrpg83/nVlNRbGASeyLL7hkIavDZ+N4j0FgM+DcHyPOmO651dqo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776090101; c=relaxed/simple; bh=wUuiTpK15zyn5hV2DVktQywHOc6nIUCjJeLdNjsqI48=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HIlbQfq+b/HUzMGoLc9UNc0XrqVj9E8iNdSvre0tX/Na9B45PoGT8PGYb/ZnKjf4naitPoyzj8bgrz3BAzf8ucZ6Rlrc8haC2B3FhpClhM7FCQt71gl92Eox8zYlYqRPMxgwttGEFg6PaJ3LH6QmBwXEultt+CaSY/bCGbgnD1Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y71jz3FF; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y71jz3FF" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-35d99031e4eso2538486a91.1 for ; Mon, 13 Apr 2026 07:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776090096; x=1776694896; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yBYOrlMuwKgniT2kucvgYI8tCUxUSyygqBtilwNBNy8=; b=Y71jz3FFdVZq84s9JwTwapFVF6LNurvblpDHLhssEaCAkN6waVLqSU1XpzaAvcl/AI dzYYosC/tpohTMPuPJC1jJ4rWlr6IZWfMCeNecVUqiMP9uJsA5fYh8y7p3B2MJKU9fQf vZ3L6sCxEDyt0wOk0RSnuJXOZAIkKI+WWx2+3EeJGpqO1AsBC9OjczMUnLOAV0lnsAaw hzM4Z+Kto0CTKaDviROutgi+bPSF78+rjR2r3VAucrN61gDhcoUGFUTT9x9YllTDzAjs qveynFkTPOBxPV/a/jvHviOoV18l+Q3yAGfwG3vv8MQwqMR68RV5QfepA+mg86Sw86kb zeDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776090096; x=1776694896; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yBYOrlMuwKgniT2kucvgYI8tCUxUSyygqBtilwNBNy8=; b=fBPXlLVyYN2OqmDEYRKqhii9viWPvAUZomNMt8oPlA0v3pLc7Fq+aqICH9ZsneiVCa mAqFhIFzbK8KINaNcqT9iK6zLsgoGWh047h/bfhKKXgyhWYc538Wc3peJCNNZsIENaQx D8FdZPQ2rOHStJQv1fbsF0AhsStBdRxaF03GLkbW8d9RQpaBzHSY29ksGeYGsrj0NKUg doC41RCA0ZjXkci4KyVCWOVaeKEShVqJgasq0yhlPNL51GYyEfqQmPLuW3kTixDukraB xD1CKroQPVhUcqbOiWat0vse/4zFsEzZOp4KWt9/Q5SISNYetZUyDo38hePI8tkEmPwf 46Mw== X-Forwarded-Encrypted: i=1; AFNElJ/maD2O1eRO2hpG0NtvHNITbwhdITIKEawT/emmzEEuvEtinmMUy25ZI9zvvoGWNS46a951iQmAnu3HMr0=@vger.kernel.org X-Gm-Message-State: AOJu0YwVE8L6PuIpes3caM9Ruit5NqD2g/+j5h/wr0XAd5Sbk1GLehNF /G0T5pIUiiN1r6bVlk5/4ANLY626i/T8qZCXTklGBcYc+40wGq6zDy41 X-Gm-Gg: AeBDieuue4gULUgXXctd7SPpuSbg+HYia/ZfNL5ugeiromI4wWBEuvyaFXLb8zhrRzM RNZ3WzQfwlx3DH2Hrs8uV02WAp34Ch7b7Le3EKKXS/k6sJlA5yfNtwHlEE1GX9rDq5hBc7AOaL4 rBqd0yS2ay2toNs+7dpxwlrQiVsi9dU4LbvMu9oFeYTDRbPqL4LuRL68JqYbztKHlOl8emrYH9S LNYeLTQjlQZsSHsyMsRxzadBCw9KNTenfHm+ekUO4RkhEoydT5xr8PRag+mz5A8Z0Mzml4/blM6 moPEk7jUILKK6PLWW6U9mpRwFL4z0+Fa+jZ5wqGs/48BvGeF92O+I67+3YbV8HaLXhotmP3WIkk DF0GNaa7HgCdMxzaRVR5FKc1ZcnZVU67im1jnbB2zFr0tQvvhpnGA4jnnigdCoTOsh8FgRWJfPn ShnqRoW6jIivWn0KJkEyqT6VhYhkWQtww= X-Received: by 2002:a17:90b:3950:b0:35c:1695:24a3 with SMTP id 98e67ed59e1d1-35e4281374emr13692490a91.23.1776090096314; Mon, 13 Apr 2026 07:21:36 -0700 (PDT) Received: from lgs.. ([2409:893d:1188:142d:6c67:74e8:5200:1f39]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35e41f17991sm4258473a91.3.2026.04.13.07.21.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 07:21:35 -0700 (PDT) From: Guangshuo Li To: Greg Kroah-Hartman , Ben Hoff , Michael Kelley , Jiri Kosina , Guangshuo Li , Marco Crivellari , William Wu , Terry Junge , Yuhao Jiang , Lee Jones , John Keeping , Andrzej Pietrasiewicz , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Johan Hovold Subject: [PATCH v3] usb: gadget: f_hid: fix device reference leak in hidg_alloc() Date: Mon, 13 Apr 2026 22:21:19 +0800 Message-ID: <20260413142119.2977716-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" hidg_alloc() initializes hidg->dev with device_initialize() before calling dev_set_name(). If dev_set_name() fails, the function currently jumps to err_unlock and returns without calling put_device(). This leaves the device reference unbalanced and prevents hidg_release() from being called. Calling put_device() here is also safe, since hidg_release() only frees resources owned by hidg. The issue was identified by a static analysis tool I developed and confirmed by manual review. Route the dev_set_name() failure path through err_put_device so the device reference is dropped properly. Fixes: 89ff3dfac604 ("usb: gadget: f_hid: fix f_hidg lifetime vs cdev") Cc: stable@vger.kernel.org Reviewed-by: Johan Hovold Signed-off-by: Guangshuo Li --- v3: - note that the issue was identified by my static analysis tool - and confirmed by manual review v2: - correct Fixes tag to 89ff3dfac604 - add Reviewed-by from Johan Hovold drivers/usb/gadget/function/f_hid.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/funct= ion/f_hid.c index 3ddfd4f66f0b..2734ebd35bda 100644 --- a/drivers/usb/gadget/function/f_hid.c +++ b/drivers/usb/gadget/function/f_hid.c @@ -1610,7 +1610,7 @@ static struct usb_function *hidg_alloc(struct usb_fun= ction_instance *fi) hidg->dev.devt =3D MKDEV(major, opts->minor); ret =3D dev_set_name(&hidg->dev, "hidg%d", opts->minor); if (ret) - goto err_unlock; + goto err_put_device; =20 hidg->bInterfaceSubClass =3D opts->subclass; hidg->bInterfaceProtocol =3D opts->protocol; @@ -1647,7 +1647,6 @@ static struct usb_function *hidg_alloc(struct usb_fun= ction_instance *fi) =20 err_put_device: put_device(&hidg->dev); -err_unlock: mutex_unlock(&opts->lock); return ERR_PTR(ret); } --=20 2.43.0