From nobody Mon Jun 15 20:34:29 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AA6478F2E for ; Mon, 13 Apr 2026 14:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776089402; cv=none; b=SjLNmt/JLshhQXSIHD3yA2c5dMUvIOcaCugwXODp+pBE0lyZQ/fBGLLvSdSPUCNnagg55iz5cGDLi/isho+dE9mdrUP8Z0Abgw0VM4lpnbcVkUuqrzQlvb9TTKFQCFld1JL1JAYNxNnmkajnFhYVBIMfPPwHd3PV506KG3RQrAc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776089402; c=relaxed/simple; bh=PnxeGXUTNu3hEkC7zuJR7JNC+DIrKyDoHOzTwao3j78=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=vFy0lqvcm2+a3glJLGi/yQHaJ2P4leP4HMo1hJBqN1Pj4TTFGwmXR40mbPuqoM8hyvlkuFHbt5Hox1X6bEL0zrYX747fX7e3Izh7TwueKyX/RhUKyE1FZZM+VrhIj1qvVMPjvCsqgxXzLpG6H4D8qlMnt4dsxZtEdFs2qrs4RWI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V62rv4XI; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V62rv4XI" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-35fbca04006so388038a91.1 for ; Mon, 13 Apr 2026 07:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776089400; x=1776694200; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=zneuZEY+XNp2GcMm7hFQDlKsd574NrSD3LhwbEaLmyQ=; b=V62rv4XIZac4ByvIsfFC+weAPDHFPvm4H7+cjnSqJKcxspwedOszp7/fCwzGs3qdZF 5hokjsP2ne7m1XPaJyWByRI+uvWPP+G80JyzGF86HHUdUwUEhMyYhYyUrt4m+6XhAnmM mtvLhNnV/sWizkMnXkOncK7Bjtwgxk6CcHo0f3dtfHDieFO3RzwvikPJWCB6ioBL+mwq 8LiMRvKpI/ZGPWKww+p20z0fE6SdjvR8s7c0cl32wC9XXNyeU91f1KdHxPvk5IFPUg9n 52qm21hFvc93vmQdbJFDX5grpO9AaCc4DqRCCDIDan2YUR0EGwjq2h5XJOfoVxNKraq7 X/Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776089400; x=1776694200; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zneuZEY+XNp2GcMm7hFQDlKsd574NrSD3LhwbEaLmyQ=; b=eOtf64KrPKTiqmnq64jrhDBfz6oaPugHFbHTpOmpYcno9wmtuBldfxvb+XSGGv2APf 2IUpbiwUlmejLmc5BMybFAsGg2UV3asuwY1DF3PlRT4PHEbcfRS/lURv0c0T7TLASLS1 YoNPeDdgudzARYOu2HwyyGDd4A83Ob7pcNqH9UIXunawdw0AvA/rRiXtMRh/oq7yxaaH bnPOD2qOzTKu9F6e1oc3ZvoUkTawOoGzVqu4RklRizaSzyX0VvkxzrofrPechWqD/z1T r3AsJPz7Rty3zrzGTPu7gEj5CqtF5ZWOhSTAXmfZ2WhG+yVZPYA8bEy5/4HQLKznIQjd 2THg== X-Forwarded-Encrypted: i=1; AFNElJ8lKSWFLJm2fJo8DaI7mGDYqZosqsz57++ZjKznQ5bJmQk+E5hngyJTbbb4Rj8oPQt8cd62jeAuBk8WNlw=@vger.kernel.org X-Gm-Message-State: AOJu0YyUQ6vGHfISBPT2+qMydUXln42uA5eIw1gpI7riwmWIpLujZr1E w7NvVwpPgdfo0MYtR1GNKUeuYaDhbMa7M3KOFZGfRokfZOgGg+YE+QMWRUPq6LubD0o= X-Gm-Gg: AeBDievUBkrF9QZEtMS9nlj5AdF9vp7qcBem0blIJug3uqMNNdlzEqUJ/PrI0+4SgRZ t+LcvqJIuNOZ8LM8BxewDH7A9pLmLvVWUCM26rZVwJcAIFNOKm8EE8/uPrfF3lD4q6cNZ8oQkar s+bOHdyQdSwzIsFItiWRMkYzs5uK2W48zMod3/iSYm188MULFC7Yig0KOwbp+c6PaGIAzMA7KDs qqYm/8lJlpeiddhrUdSZy+keSzrbM5k3X9Lgb7GebWUK2izoH21QF+ufSrASUZvfKWu/wUOsgsu 2cm9pZZ5vpt78TT1k8Sj0JIum5mUFnfKNYQccewQHZ9LfS1PTz/zG+56S79hPIb091lZo5JxG/r L697WbHSvtgE/9ne06xjmMknkK4IPHCKHspcvVWWgkI/XzmrDGYAS6FKPlADy0UbWJESCqMYZpC Cwwq7sM6daBbyX/hB4q+rq+5RAWNiZTek= X-Received: by 2002:a17:90b:2d07:b0:35d:a3b4:2f0d with SMTP id 98e67ed59e1d1-35e4274e1damr12597400a91.6.1776089400391; Mon, 13 Apr 2026 07:10:00 -0700 (PDT) Received: from lgs.. ([2409:893d:1188:142d:6c67:74e8:5200:1f39]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2d4f25d83sm121237895ad.58.2026.04.13.07.09.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 07:10:00 -0700 (PDT) From: Guangshuo Li To: Guangshuo Li , linux-kernel@vger.kernel.org Subject: [PATCH v2] edd: Fix kobject reference leak in edd_init() error path Date: Mon, 13 Apr 2026 22:09:50 +0800 Message-ID: <20260413140950.2946321-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" edd_device_register() initializes the embedded kobject for struct edd_device via: edd_device_register() -> kobject_init_and_add(&edev->kobj, &edd_ktype, ...) -> edd_ktype.release =3D edd_release() -> kfree(edev) So once edd_device_register() has called kobject_init_and_add(), edev should be released via kobject_put(), not by freeing it directly. However, in edd_init(), when edd_device_register() fails, the error path calls kfree(edev) directly. That bypasses the normal kobject lifetime handling and leaks the reference held on the embedded kobject. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fix this by using kobject_put() in the edd_device_register() failure path so the object is released through edd_release(). Signed-off-by: Guangshuo Li --- v2: - note that the issue was identified by my static analysis tool - and confirmed by manual review drivers/firmware/edd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c index 55dec4eb2c00..82b326ce83ce 100644 --- a/drivers/firmware/edd.c +++ b/drivers/firmware/edd.c @@ -748,7 +748,7 @@ edd_init(void) =20 rc =3D edd_device_register(edev, i); if (rc) { - kfree(edev); + kobject_put(&edev->kobj); goto out; } edd_devices[i] =3D edev; --=20 2.43.0