From nobody Mon Jun 15 15:09:29 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B18D3BE17B for ; Mon, 13 Apr 2026 13:44:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776087843; cv=none; b=s9NmLkewx737rWadHl6vOVBc67uIwUVpzj7ndAb+3/agxsjbkqRSxOWuIljfs8LX16aaX1jE6w9U5QZ0aFU1RPqAg+byn8QaWlgiqDq6BBTwXpq48Ot+97NyqU2daO82JbFR+h4QRldwjUYC132vagh/Xbz5OrDPP88Xn3Y3UW0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776087843; c=relaxed/simple; bh=V14ZCWON2p63vUUtG28yyk5VGhtMVwJXrepp/6rwLYU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Md2uWqhKxNUNLa94tSXouVkVWadTTV1WxVonVDOimczutCJDSuWd5qrwP+fuLf39D+sEine35o6xezKVVTUXokwzh8Tg7ETkCvtbDifUya9ggBqoZgE8rs5nIA7542VYlIYoifLdkfQAdqnwR644nr8h5ioijfhm0uEkhn+QXGw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FEV2kVg2; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FEV2kVg2" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-82f22ec4501so726930b3a.0 for ; Mon, 13 Apr 2026 06:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776087842; x=1776692642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7W9JynenGbsWsUxegkWWGHkXpA2s8st+nPT0ylLSYvw=; b=FEV2kVg20DSEaQukWY+U0KCTrl7TVyQSzVR4iCysQLs2MjS4f7VHQdVx+LgkbuYq2D 26INZRPH8MoRk0thSJ3QYJsCI3e3IxAC23pp3jxZ0vH2mqi8b8v2kPn5gRV3DT0HUhDg zyyaPVYp2fkfcMunBaZasTiRWBQ6DWMiOpP4cpXCmbPyeeKAE1nNKLwsJA2tANzN3x8V iB+8UIEbKVww5P9RIcOfU78we6gkU6DNWAcg9Xg8xNdcBByVT2wsuVyBgIhHpitKmFQ1 l+QRKaVzCFShfi1AavAc0my0Sl6byV18D+CZ4pte+ghNZmsJTid+cEbK95wozLDEC0ZV FLzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776087842; x=1776692642; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7W9JynenGbsWsUxegkWWGHkXpA2s8st+nPT0ylLSYvw=; b=tZIi1EoWIj8VdACisJzuzzGg0vYcYMG37WHbl7t+VKTC3IWGCMzQZnyo1DaTbUz2RY VuPxgdX3dLl9+zVPj+48iFj/8Qvr48gzJcCTGCPvK8JSbrecQiy4HD8cAheQPC5tBhEa 9WUNCndRNF+Q9aCxiXgZy07BBqmJEKtiqeQnfxJXYLyoQgIyAZ9eil9qpyzgRe35WRBn RPR+9MXoV16iVgXiaqO4kDpkxn5d8bxRr2IZ6g5wMA+3XR8nMdxILrd8kEwWFR9oNJ54 RRpGS7rV6WqOtXkeMkF90onCmFfbQZOMqF8grFjUUZOyP46DA/VFdPmM0B91zOVlgC03 v/zw== X-Forwarded-Encrypted: i=1; AFNElJ/3WXb3bAO1SYkQ/xLWOiS/rx4NK4pf/xKrSLcZ1QT3dmM2i60re2VzfBEuh7/VeBF2xRPAftCICUeVgnM=@vger.kernel.org X-Gm-Message-State: AOJu0YyRXp2Ju3yf7TqL1n45yPLRzRXpovt1M4Ke03rNje6higYISmMG Op9XRBB2p/kV4H2AkxzvA4C9BKKvhs8v1OTIMJVZNz86bdKM23zoQ9rc X-Gm-Gg: AeBDieuYBh6tyjPsV6IJ1PtuKWSi0hBqkqvcZPPUxzDHfoBMpcK2BkXamTAB+SiKrm5 ROUlvQiuGsggCNJ21DefylxD5Ov/gUlsZja7/DairicCqHLGZgD90pK9M8cUGLZ7kfpO26Vx4aH uH+NDRajlB9/+1PN1SMZDGLZ8UMispo4CQ/v1rnDEawOBRWdNqx9u0qBTKjjrLury4ftXpbIAFX gJ6WknAmsDkkMCDruDRCFaeHj0rrv05QttBpd+g5INECcvtuwaUYBdSdq7ughIVPUQ8kGzx30P/ kJlWSzOSFOeZawRs1sbG9hLevmzsGPGA7lAWHFpdL9x5oeO1i7XbN8YUkwdoA1zxRPSedpmn845 56UTo1yQMV27wWTR/8ESDFKvUXqZdfy2gD35cJGqej8TJQ/aLPDjJc/sehQM+I2mC539r75N6h/ Rb5rGqyP5nshRjafhD3RuscVFSPWMT624= X-Received: by 2002:a05:6a00:aa09:b0:81e:d18a:489d with SMTP id d2e1a72fcca58-82f0c324ad0mr13936407b3a.42.1776087841672; Mon, 13 Apr 2026 06:44:01 -0700 (PDT) Received: from lgs.. ([2409:893d:1188:142d:6c67:74e8:5200:1f39]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c33de57sm10951065b3a.21.2026.04.13.06.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 06:44:01 -0700 (PDT) From: Guangshuo Li To: Ioana Ciornei , Stuart Yoder , Greg Kroah-Hartman , Alexander Graf , "J. German Rivera" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v2] bus: fsl-mc: Fix refcount leak in fsl_mc_device_add() error path Date: Mon, 13 Apr 2026 21:43:44 +0800 Message-ID: <20260413134345.2855417-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After device_initialize(), the lifetime of the embedded struct device is expected to be managed through the device core reference counting. In fsl_mc_device_add(), all failures after device_initialize() jump to error_cleanup_dev, where mc_dev and its associated resources are freed directly instead of releasing the device reference with put_device(&mc_dev->dev). This bypasses the normal device lifetime rules and may leave the reference count of the embedded struct device unbalanced, resulting in a refcount leak. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fix this by using put_device(&mc_dev->dev) in the error path and let fsl_mc_device_release() handle the final cleanup. Fixes: bbf9d17d9875 ("staging: fsl-mc: Freescale Management Complex (fsl-mc= ) bus driver") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v2: - note that the issue was identified by my static analysis tool - and confirmed by manual review drivers/bus/fsl-mc/fsl-mc-bus.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bu= s.c index 25845c04e562..6d132144ce25 100644 --- a/drivers/bus/fsl-mc/fsl-mc-bus.c +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c @@ -905,11 +905,7 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc *obj_desc, return 0; =20 error_cleanup_dev: - kfree(mc_dev->regions); - if (mc_bus) - kfree(mc_bus); - else - kfree(mc_dev); + put_device(&mc_dev->dev); =20 return error; } --=20 2.43.0