From nobody Mon Jun 15 15:09:35 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 646693CD8BE for ; Mon, 13 Apr 2026 13:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776087684; cv=none; b=ZiBbXInfzEvFr/+8lCqhCPBh+Q7tnlnuc86J9J82OOLuEhqqLuVMIdWihJ18/4UwQus2j0spCslmwFqZKC32IUwzxcu4myT9wcN5Od+gvwrjnvltyIbSew/UeNrg6vW1IFZCGoexvdZeiumC32gSwmOen0nwrnF7cOSuQjtG8n4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776087684; c=relaxed/simple; bh=lKjh2VoQZiyO8SauvRfoqvhKvOTpAYyrbd+624DOWYI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sDy3AsuL1B1w5ItlHLQgNjkeBpIgARTujXQcX78gKg8dnxpwrqD0me75/Quepmv9fv5e+B4O7yZuwpAGPevH96zhAmK9DPC/W2f4yY+ESJG7CWwyD+c2jXwbx9Vbz0UqZSmgijVykZjr85uQ/MgfEUhvs/LhV4PuKpOVCHhf4P4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j21TxMxD; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j21TxMxD" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c76e702e01aso1500853a12.3 for ; Mon, 13 Apr 2026 06:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776087681; x=1776692481; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2Okx6V7j8TV1N3MeUy+n26P/+RkIW771eIesahlBsPI=; b=j21TxMxDbc0GgSit9+dqLLFqThkv3Jj7jcLerteA0yOxdmsraKygnbyQc0JslyXf8m Bx87FKW4oEfZnJEJRz7OhKlFrB7gqtQJLvrZFkVX0i6ySADK9hQen7X08NsEE4wHUCMJ gk4kDViJgUi51aOtSFk1z08osbHbwNwVCx2NUsyEhMBbqLo3+MAf43/xK7vlK5X+lmJH krj8MrnBHvHq4sQs3i1t0ROme15+raCW9lo4am9JVp5tV9NvdrCe9c9Xrls2hm+1WJ3g jT6tCvb2XbaYrZgOA3MSf6r9jcLli/WbMHa/jURlSLmHbl1SDNffBeTZrRPBHv4eofFh o9pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776087681; x=1776692481; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2Okx6V7j8TV1N3MeUy+n26P/+RkIW771eIesahlBsPI=; b=Ydj1AHMVIWOCjJ/+cXSyMy9rIXz9X/doswQhHWSFgAbGX5m3AR92D47jUvZdxAMzPV VcBDa8sFG2OZ/wA8FL9FNAVjyU1N5dWElL58kMdUErp4jhCizd8orZ399Wyhan9drdNh yps9Qq5Go9a9Wwwy19HdNWIJuWZtHm5icd8oZ+z5n8m1fKKAHiQ46ueZfwMWAYvaOQd1 rhy6CD//nnqq4UTyoCXWemNdEn1/baCVVkA193AMFN9vmoj7s4Pb4iIvthZFKoQDQwwM G/rium4Yu0DxLdu3Wlw6BXnFRZvyTdbSpW7tPYs4qhFeCjUjfT4IAyb/8DnUkLT75AW1 jIvQ== X-Forwarded-Encrypted: i=1; AFNElJ94Jgiz1KbM2nPCD99+Ho2aHYoN0y/+uEbCpuTwmZp5H6ZCujKMM87Rxv9aQmJvGYbCO4wjGvNPZFudV1g=@vger.kernel.org X-Gm-Message-State: AOJu0YxM7CT/biXFDUH9CkP0SNqifPlx2ruG8CufUjhHFKSNnSFhu0Nc T06CYgqENMmOazCflrG/jz7JUGCrLd8gRTCqFfR9AmBsvEzlx07vNiLo X-Gm-Gg: AeBDieuX4YtZd5NiceFOszCLoFePV03gO1vma43NSsxgcMh0KEXnvhCGEpP7hGa4Kh3 +dHC9CqYpfNQ1QrhSLBXkZU2DtmIs17FDDkj6E02OsXqahAmbldhdXI3EiWcKC/BtXMf+eKBK7+ mV5QxglgfuUKagnahjSkZIdfwm8KhsdhHFY0EQcVgs38bcQdvIqP1Ll1OlmWUCrc26ma7AFSUbR jCU3nHqKviJwUPJDJ+DB7Dibugg2/Wy2KD6PK81DH9LjPUIf+5vVK3/PUo6s5ePlgMO+Gg5ezBR 49jqbo0HbgVbwDOWepbxX0rgvmqALDkZKJ4wp1nCVkL4CWf+RGWBNZT6H1zDy+M1V8QkieURKdc Sxd1imAn9rlq/1oW30EHMRKXwlE8ArO1kuzYKcOV2wzmR0iH1n8zUFQ8OzWz+pj6uUCRlYIf4bi nlHvLsS/WZgALntDzT+48mApOlEz8ypRA= X-Received: by 2002:a05:6a20:3d85:b0:39f:d71d:4e84 with SMTP id adf61e73a8af0-39fe40521bfmr15421807637.51.1776087681339; Mon, 13 Apr 2026 06:41:21 -0700 (PDT) Received: from lgs.. ([2409:893d:1188:142d:6c67:74e8:5200:1f39]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7921a1ef00sm9924360a12.28.2026.04.13.06.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 06:41:21 -0700 (PDT) From: Guangshuo Li To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Jonathan Cameron , Keith Busch , linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v2] driver core: Fix refcount leak in node_init_node_access() error path Date: Mon, 13 Apr 2026 21:41:09 +0800 Message-ID: <20260413134109.2848329-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After device_register(), the lifetime of the embedded struct device is expected to be managed through the device core reference counting. In node_init_node_access(), if device_register() fails, the error path frees access_node directly instead of releasing the device reference with put_device(). This bypasses the normal device lifetime rules and may leave the reference count of the embedded struct device unbalanced, resulting in a refcount leak and potentially leading to a use-after-free. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fix this by using put_device(dev) in the device_register() failure path and let node_access_release() handle the final cleanup. Fixes: 08d9dbe72b1f ("node: Link memory nodes to their compute nodes") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v2: - note that the issue was identified by my static analysis tool - and confirmed by manual review drivers/base/node.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index 00cf4532f121..2b19959a374c 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -171,13 +171,13 @@ static struct node_access_nodes *node_init_node_acces= s(struct node *node, goto free; =20 if (device_register(dev)) - goto free_name; + goto put_device; =20 pm_runtime_no_callbacks(dev); list_add_tail(&access_node->list_node, &node->access_list); return access_node; -free_name: - kfree_const(dev->kobj.name); +put_device: + put_device(dev); free: kfree(access_node); return NULL; --=20 2.43.0