From nobody Sat Apr 18 06:56:12 2026 Received: from mail-m3284.qiye.163.com (mail-m3284.qiye.163.com [220.197.32.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A876337CD28; Mon, 13 Apr 2026 13:26:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776086771; cv=none; b=LkGFvcPR2mqSOiwkl/01TC8XohA8g6vQKiPxOIGRDivDduYrQkqtyPKjsoyTyOP/VN/4Qa9ZXBDk7V88zGaywgyMXyXjlDMZeXMRVbTM+qteFX0yJ29IHX9cQxgEDH/6AQPExQ7k9qnZ6rsHSKv6+Gm88M3S8W0bBf1NGdYUZVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776086771; c=relaxed/simple; bh=XflTSJa5nDr6uNxxcbH3/E+nCpqegmd6YF02IiTQ/ps=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GcKBX3olWISj2XWaic8RvYv8UrQ2woW/7Hqvz4luCsTJ9EqVFGIo5xmwCa0gO1RmPNY3XJGPgntrkeqfrSfWhhP7lL/AZKD8nXddajyb1r0af4I02h7+t2MDQBQQFW0T9tezt5z9rmgKk6K+ViVbG2QHuzaKtUGGlTsbCPsNKtk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=UIRzxxAD; arc=none smtp.client-ip=220.197.32.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="UIRzxxAD" Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 3a8976ad6; Mon, 13 Apr 2026 21:25:56 +0800 (GMT+08:00) From: Damon Ding To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, jingoohan1@gmail.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, alim.akhtar@samsung.com, dmitry.baryshkov@oss.qualcomm.com, luca.ceresoli@bootlin.com, nicolas.frattaroli@collabora.com, dianders@chromium.org, m.szyprowski@samsung.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Damon Ding Subject: [PATCH v14 1/8] drm/bridge: analogix_dp: Pass struct drm_atomic_state* for analogix_dp_bridge_mode_set() Date: Mon, 13 Apr 2026 21:25:44 +0800 Message-Id: <20260413132551.1049307-2-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260413132551.1049307-1-damon.ding@rock-chips.com> References: <20260413132551.1049307-1-damon.ding@rock-chips.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a9d87052bc903a3kunmf5e06f40656e3e X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGkgdGVZDTx1PTR9KS0IZQktWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpKQk 1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=UIRzxxADqaNgtHzKtTD2Sh9z+ai0hA8VQK8a7jr129zCvYhVPwnEPkt5XkjjtjspSVUhIIBq+k+aZAXWcz3cP3NKeXcuIN2BXByfYQHXOSQ1nV3F4shGj7dIfoYn/MmLWUbajarfEuWGwnT13dI0CbaM4HIAfihVgIDmuJwuFfg=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=vmaaJIH4kHentNKfFa4bglHUifZ1mjsl8j3aM8E4emg=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" To avoid using &analogix_dp_device.connector for compatibility with the bridge connector framework, get &drm_connector from &drm_atomic_state instead. Signed-off-by: Damon Ding Reviewed-by: Dmitry Baryshkov Reviewed-by: Luca Ceresoli --- Changes in v14: - Add Reviewed-by tags. --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.c index 840c1963e60e..84b994cce900 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1095,14 +1095,21 @@ static int analogix_dp_set_bridge(struct analogix_d= p_device *dp) } =20 static void analogix_dp_bridge_mode_set(struct drm_bridge *bridge, + struct drm_atomic_state *state, const struct drm_display_mode *mode) { struct analogix_dp_device *dp =3D to_dp(bridge); - struct drm_display_info *display_info =3D &dp->connector.display_info; struct video_info *video =3D &dp->video_info; struct device_node *dp_node =3D dp->dev->of_node; + struct drm_connector *connector; + struct drm_display_info *display_info; int vic; =20 + connector =3D drm_atomic_get_new_connector_for_encoder(state, bridge->enc= oder); + if (!connector) + return; + display_info =3D &connector->display_info; + /* Input video interlaces & hsync pol & vsync pol */ video->interlaced =3D !!(mode->flags & DRM_MODE_FLAG_INTERLACE); video->v_sync_polarity =3D !!(mode->flags & DRM_MODE_FLAG_NVSYNC); @@ -1186,7 +1193,7 @@ static void analogix_dp_bridge_atomic_enable(struct d= rm_bridge *bridge, new_crtc_state =3D drm_atomic_get_new_crtc_state(old_state, crtc); if (!new_crtc_state) return; - analogix_dp_bridge_mode_set(bridge, &new_crtc_state->adjusted_mode); + analogix_dp_bridge_mode_set(bridge, old_state, &new_crtc_state->adjusted_= mode); =20 old_crtc_state =3D drm_atomic_get_old_crtc_state(old_state, crtc); /* Not a full enable, just disable PSR and continue */ --=20 2.34.1 From nobody Sat Apr 18 06:56:12 2026 Received: from mail-m3270.qiye.163.com (mail-m3270.qiye.163.com [220.197.32.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1EDC3CD8C6; Mon, 13 Apr 2026 13:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776087691; cv=none; b=s1oa8D2EjQqw9zGBGat5hj9eeiScv3itKR862SmDqOyr9XjPc3VadV9Y6JtYvzMz49P05itZZtc+5iXSJswmIdSdTJd/r+Jpzgp1QLdVU9Hg3wNaK28khfwwI9QgXUU8Ux+7W8f3/f/lxYfOXCL127e3zsoBZLD78KR2H6VlIZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776087691; c=relaxed/simple; bh=0unBO2Z/ubA/JsKCiMGzR/2D+bSXV4RqIYq3E5WIiNk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ACcjeWUBtFyzv+MI9uIUSp6jtojbKCcGjTjx5Hy9D0KcuR+QIbUCN2dMonPlC6wmNltNp3CH5z9ql4cMUMezXYCNTULvJukA1vAMv18inm69zlhLtvBeCBAkLo2wTzrRn7vS77rVS4wemP5r6Eh0gV0U2CYsYXOR3uu0/wvR0ME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=d6ZXj4Ab; arc=none smtp.client-ip=220.197.32.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="d6ZXj4Ab" Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 3a8976ada; Mon, 13 Apr 2026 21:25:58 +0800 (GMT+08:00) From: Damon Ding To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, jingoohan1@gmail.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, alim.akhtar@samsung.com, dmitry.baryshkov@oss.qualcomm.com, luca.ceresoli@bootlin.com, nicolas.frattaroli@collabora.com, dianders@chromium.org, m.szyprowski@samsung.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Damon Ding Subject: [PATCH v14 2/8] drm/bridge: analogix_dp: Apply drm_bridge_connector helper Date: Mon, 13 Apr 2026 21:25:45 +0800 Message-Id: <20260413132551.1049307-3-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260413132551.1049307-1-damon.ding@rock-chips.com> References: <20260413132551.1049307-1-damon.ding@rock-chips.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a9d870533f803a3kunmf5e06f40656e4b X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGk5DTVZISRhPH0ofH0MaHk1WFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpKQk 1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=d6ZXj4AbXRDrvfY5sFU5R1HouS0LcctrDCUAb1/4kpHYIwsOOmbtM5FTc0fotHLD9WuHwg4fsZX5yagAchWmVoet6lVNsEErv5PtJRXxrW9CUdM4ppFlzhMtNuOlOtRhTdw3zrXdVSQOiPhnPQ9B3Q5VrcCyId1rI19X54CFIi0=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=moiqijNlcjpf00K+vLN5gMkkVQ37b4reiK3V0F5Md4o=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" Initialize bridge_connector for both Rockchip and Exynos encoder sides. Then, make DRM_BRIDGE_ATTACH_NO_CONNECTOR mandatory for Analogix bridge side, as the private &drm_connector is no longer created. The previous &drm_connector_funcs and &drm_connector_helper_funcs APIs are replaced by the corresponding &drm_bridge_funcs APIs: analogix_dp_atomic_check() -> analogix_dp_bridge_atomic_check() analogix_dp_detect() -> analogix_dp_bridge_detect() analogix_dp_get_modes() -> analogix_dp_bridge_get_modes() analogix_dp_bridge_edid_read() Additionally, the compatibilities of Analogix DP bridge based on whether the next bridge is a 'panel'. If it is, OP_MODES and OP_DETECT are supported; If not (the next bridge is a 'monitor' or a bridge chip), OP_EDID and OP_DETECT are supported. The devm_drm_bridge_add() is placed in analogix_dp_bind() instead of analogix_dp_probe(), because the type of next bridge (the panel, monitor or bridge chip) can only be determined after the probe process has fully completed. Signed-off-by: Damon Ding Reviewed-by: Dmitry Baryshkov Reviewed-by: Luca Ceresoli Tested-by: Marek Szyprowski Tested-by: Heiko Stuebner # rk3588 --- Changes in v2: - For &drm_bridge.ops, remove DRM_BRIDGE_OP_HPD and add DRM_BRIDGE_OP_EDID. - Add analogix_dp_bridge_edid_read(). - Move &analogix_dp_plat_data.skip_connector deletion to the previous patches. Changes in v3: - Rebase with the new devm_drm_bridge_alloc() related commit 48f05c3b4b70 ("drm/bridge: analogix_dp: Use devm_drm_bridge_alloc() API"). - Expand the commit message. - Call drm_bridge_get_modes() in analogix_dp_bridge_get_modes() if the bridge is available. - Remove unnecessary parameter struct drm_connector* for callback &analogix_dp_plat_data.attach. - In order to decouple the connector driver and the bridge driver, move the bridge connector initilization to the Rockchip and Exynos sides. Changes in v4: - Expand analogix_dp_bridge_detect() parameters to &drm_bridge and &drm_connector. - Rename the &analogix_dp_plat_data.bridge to &analogix_dp_plat_data.next_bridge. Changes in v5: - Set the flag fo drm_bridge_attach() to DRM_BRIDGE_ATTACH_NO_CONNECTOR for next bridge attachment of Exynos side. - Distinguish the &drm_bridge->ops of Analogix bridge based on whether the downstream device is a panel, a bridge or neither. - Remove the calls to &analogix_dp_plat_data.get_modes(). Changes in v6: - Select DRM_BRIDGE_CONNECTOR for both Rockchip and Exynos sides. - Remove unnecessary drm_bridge_get_modes() in analogix_dp_bridge_get_modes(). - Simplify analogix_dp_bridge_edid_read(). - If the next is a bridge, set DRM_BRIDGE_OP_DETECT and return connector_status_connected in analogix_dp_bridge_detect(). - Set flag DRM_BRIDGE_ATTACH_NO_CONNECTOR for bridge attachment while binding. Meanwhile, make DRM_BRIDGE_ATTACH_NO_CONNECTOR unsuppported in analogix_dp_bridge_attach(). - Simplify the check of bridge capabilities. Changes in v7: - Remove temporary flag &exynos_dp_device.has_of_bridge. Changes in v9 - Add Tested-by tag. Changes in v10: - Split this commit into serval smaller ones. - Simplify the commit message. Changes in v11: - Move the removal of &analogix_dp_device.connector to this commit. - In exynos_dp_bridge_attach(), set the bridge flag to 'flags | DRM_BRIDGE_ATTACH_NO_CONNECTOR' instead of fixed 'DRM_BRIDGE_ATTACH_NO_CONNECTOR' for extensibility. Changes in v12: - Restore accidentally removed DRM_BRIDGE_CONNECTOR Kconfig in v10. Changes in v13: - Rebase after commit 01962a191242 ("drm/rockchip: analogix: Convert to drm_output_color_format") - Modify '(on rk3588)' to '# rk3588' for Tested-by tag. Changes in v14: - Add Reviewed-by tags. - Apply __free() to call drm_bridge_put() in CRC ralted functions. --- .../drm/bridge/analogix/analogix_dp_core.c | 136 +++++++----------- .../drm/bridge/analogix/analogix_dp_core.h | 1 - drivers/gpu/drm/exynos/Kconfig | 1 + drivers/gpu/drm/exynos/exynos_dp.c | 25 ++-- drivers/gpu/drm/rockchip/Kconfig | 1 + .../gpu/drm/rockchip/analogix_dp-rockchip.c | 11 +- 6 files changed, 79 insertions(+), 96 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.c index 84b994cce900..3c6eed9279d2 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -6,6 +6,7 @@ * Author: Jingoo Han */ =20 +#include #include #include #include @@ -856,44 +857,32 @@ static int analogix_dp_disable_psr(struct analogix_dp= _device *dp) return analogix_dp_send_psr_spd(dp, &psr_vsc, true); } =20 -static int analogix_dp_get_modes(struct drm_connector *connector) +static int analogix_dp_bridge_get_modes(struct drm_bridge *bridge, struct = drm_connector *connector) { - struct analogix_dp_device *dp =3D to_dp(connector); - const struct drm_edid *drm_edid; + struct analogix_dp_device *dp =3D to_dp(bridge); int num_modes =3D 0; =20 - if (dp->plat_data->panel) { + if (dp->plat_data->panel) num_modes +=3D drm_panel_get_modes(dp->plat_data->panel, connector); - } else { - drm_edid =3D drm_edid_read_ddc(connector, &dp->aux.ddc); - - drm_edid_connector_update(&dp->connector, drm_edid); - - if (drm_edid) { - num_modes +=3D drm_edid_connector_add_modes(&dp->connector); - drm_edid_free(drm_edid); - } - } =20 return num_modes; } =20 -static struct drm_encoder * -analogix_dp_best_encoder(struct drm_connector *connector) +static const struct drm_edid *analogix_dp_bridge_edid_read(struct drm_brid= ge *bridge, + struct drm_connector *connector) { - struct analogix_dp_device *dp =3D to_dp(connector); + struct analogix_dp_device *dp =3D to_dp(bridge); =20 - return dp->encoder; + return drm_edid_read_ddc(connector, &dp->aux.ddc); } =20 - -static int analogix_dp_atomic_check(struct drm_connector *connector, - struct drm_atomic_state *state) +static int analogix_dp_bridge_atomic_check(struct drm_bridge *bridge, + struct drm_bridge_state *bridge_state, + struct drm_crtc_state *crtc_state, + struct drm_connector_state *conn_state) { - struct analogix_dp_device *dp =3D to_dp(connector); - struct drm_display_info *di =3D &connector->display_info; - struct drm_connector_state *conn_state; - struct drm_crtc_state *crtc_state; + struct analogix_dp_device *dp =3D to_dp(bridge); + struct drm_display_info *di =3D &conn_state->connector->display_info; u32 mask =3D BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444) | BIT(DRM_OUTPUT_COLOR= _FORMAT_YCBCR422); =20 if (is_rockchip(dp->plat_data->dev_type)) { @@ -905,38 +894,21 @@ static int analogix_dp_atomic_check(struct drm_connec= tor *connector, } } =20 - conn_state =3D drm_atomic_get_new_connector_state(state, connector); - if (WARN_ON(!conn_state)) - return -ENODEV; - conn_state->self_refresh_aware =3D true; =20 - if (!conn_state->crtc) - return 0; - - crtc_state =3D drm_atomic_get_new_crtc_state(state, conn_state->crtc); - if (!crtc_state) - return 0; - if (crtc_state->self_refresh_active && !dp->psr_supported) return -EINVAL; =20 return 0; } =20 -static const struct drm_connector_helper_funcs analogix_dp_connector_helpe= r_funcs =3D { - .get_modes =3D analogix_dp_get_modes, - .best_encoder =3D analogix_dp_best_encoder, - .atomic_check =3D analogix_dp_atomic_check, -}; - static enum drm_connector_status -analogix_dp_detect(struct drm_connector *connector, bool force) +analogix_dp_bridge_detect(struct drm_bridge *bridge, struct drm_connector = *connector) { - struct analogix_dp_device *dp =3D to_dp(connector); + struct analogix_dp_device *dp =3D to_dp(bridge); enum drm_connector_status status =3D connector_status_disconnected; =20 - if (dp->plat_data->panel) + if (dp->plat_data->panel || dp->plat_data->next_bridge) return connector_status_connected; =20 if (!analogix_dp_detect_hpd(dp)) @@ -945,51 +917,18 @@ analogix_dp_detect(struct drm_connector *connector, b= ool force) return status; } =20 -static const struct drm_connector_funcs analogix_dp_connector_funcs =3D { - .fill_modes =3D drm_helper_probe_single_connector_modes, - .detect =3D analogix_dp_detect, - .destroy =3D drm_connector_cleanup, - .reset =3D drm_atomic_helper_connector_reset, - .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, - .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, -}; - static int analogix_dp_bridge_attach(struct drm_bridge *bridge, struct drm_encoder *encoder, enum drm_bridge_attach_flags flags) { struct analogix_dp_device *dp =3D to_dp(bridge); - struct drm_connector *connector =3D NULL; int ret =3D 0; =20 - if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) { - DRM_ERROR("Fix bridge driver to make connector optional!"); + if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) { + DRM_ERROR("Unsupported connector creation\n"); return -EINVAL; } =20 - if (!dp->plat_data->next_bridge) { - connector =3D &dp->connector; - connector->polled =3D DRM_CONNECTOR_POLL_HPD; - - ret =3D drm_connector_init(dp->drm_dev, connector, - &analogix_dp_connector_funcs, - DRM_MODE_CONNECTOR_eDP); - if (ret) { - DRM_ERROR("Failed to initialize connector with drm\n"); - return ret; - } - - drm_connector_helper_add(connector, - &analogix_dp_connector_helper_funcs); - drm_connector_attach_encoder(connector, encoder); - } - - /* - * NOTE: the connector registration is implemented in analogix - * platform driver, that to say connector would be exist after - * plat_data->attch return, that's why we record the connector - * point after plat attached. - */ if (dp->plat_data->attach) { ret =3D dp->plat_data->attach(dp->plat_data, bridge); if (ret) { @@ -1309,7 +1248,11 @@ static const struct drm_bridge_funcs analogix_dp_bri= dge_funcs =3D { .atomic_enable =3D analogix_dp_bridge_atomic_enable, .atomic_disable =3D analogix_dp_bridge_atomic_disable, .atomic_post_disable =3D analogix_dp_bridge_atomic_post_disable, + .atomic_check =3D analogix_dp_bridge_atomic_check, .attach =3D analogix_dp_bridge_attach, + .get_modes =3D analogix_dp_bridge_get_modes, + .edid_read =3D analogix_dp_bridge_edid_read, + .detect =3D analogix_dp_bridge_detect, }; =20 static int analogix_dp_dt_parse_pdata(struct analogix_dp_device *dp) @@ -1539,6 +1482,7 @@ EXPORT_SYMBOL_GPL(analogix_dp_resume); =20 int analogix_dp_bind(struct analogix_dp_device *dp, struct drm_device *drm= _dev) { + struct drm_bridge *bridge =3D &dp->bridge; int ret; =20 dp->drm_dev =3D drm_dev; @@ -1552,7 +1496,18 @@ int analogix_dp_bind(struct analogix_dp_device *dp, = struct drm_device *drm_dev) return ret; } =20 - ret =3D drm_bridge_attach(dp->encoder, &dp->bridge, NULL, 0); + if (dp->plat_data->panel) + bridge->ops =3D DRM_BRIDGE_OP_MODES | DRM_BRIDGE_OP_DETECT; + else + bridge->ops =3D DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_DETECT; + + bridge->of_node =3D dp->dev->of_node; + bridge->type =3D DRM_MODE_CONNECTOR_eDP; + ret =3D devm_drm_bridge_add(dp->dev, &dp->bridge); + if (ret) + goto err_unregister_aux; + + ret =3D drm_bridge_attach(dp->encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO= _CONNECTOR); if (ret) { DRM_ERROR("failed to create bridge (%d)\n", ret); goto err_unregister_aux; @@ -1570,7 +1525,6 @@ EXPORT_SYMBOL_GPL(analogix_dp_bind); void analogix_dp_unbind(struct analogix_dp_device *dp) { analogix_dp_bridge_disable(&dp->bridge); - dp->connector.funcs->destroy(&dp->connector); =20 drm_panel_unprepare(dp->plat_data->panel); =20 @@ -1580,7 +1534,9 @@ EXPORT_SYMBOL_GPL(analogix_dp_unbind); =20 int analogix_dp_start_crc(struct drm_connector *connector) { - struct analogix_dp_device *dp =3D to_dp(connector); + struct analogix_dp_device *dp; + struct drm_bridge *bridge __free(drm_bridge_put) =3D + drm_bridge_chain_get_first_bridge(connector->encoder); =20 if (!connector->state->crtc) { DRM_ERROR("Connector %s doesn't currently have a CRTC.\n", @@ -1588,13 +1544,25 @@ int analogix_dp_start_crc(struct drm_connector *con= nector) return -EINVAL; } =20 + if (!bridge || bridge->type !=3D DRM_MODE_CONNECTOR_eDP) + return -EINVAL; + + dp =3D to_dp(bridge); + return drm_dp_start_crc(&dp->aux, connector->state->crtc); } EXPORT_SYMBOL_GPL(analogix_dp_start_crc); =20 int analogix_dp_stop_crc(struct drm_connector *connector) { - struct analogix_dp_device *dp =3D to_dp(connector); + struct analogix_dp_device *dp; + struct drm_bridge *bridge __free(drm_bridge_put) =3D + drm_bridge_chain_get_first_bridge(connector->encoder); + + if (!bridge || bridge->type !=3D DRM_MODE_CONNECTOR_eDP) + return -EINVAL; + + dp =3D to_dp(bridge); =20 return drm_dp_stop_crc(&dp->aux); } diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.h index 91b215c6a0cf..17347448c6b0 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h @@ -154,7 +154,6 @@ struct analogix_dp_device { struct drm_encoder *encoder; struct device *dev; struct drm_device *drm_dev; - struct drm_connector connector; struct drm_bridge bridge; struct drm_dp_aux aux; struct clk *clock; diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index 380d9a8ce259..38bf070866f6 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/drm/exynos/Kconfig @@ -70,6 +70,7 @@ config DRM_EXYNOS_DP bool "Exynos specific extensions for Analogix DP driver" depends on DRM_EXYNOS_FIMD || DRM_EXYNOS7_DECON select DRM_ANALOGIX_DP + select DRM_BRIDGE_CONNECTOR select DRM_DISPLAY_DP_HELPER default DRM_EXYNOS select DRM_OF_DISPLAY_MODE_BRIDGE diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/ex= ynos_dp.c index 71a00ee97782..b2597fafd73d 100644 --- a/drivers/gpu/drm/exynos/exynos_dp.c +++ b/drivers/gpu/drm/exynos/exynos_dp.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include #include @@ -41,8 +42,6 @@ struct exynos_dp_device { =20 struct analogix_dp_device *adp; struct analogix_dp_plat_data plat_data; - - bool has_of_bridge; }; =20 static int exynos_dp_crtc_clock_enable(struct analogix_dp_plat_data *plat_= data, @@ -78,10 +77,8 @@ static int exynos_dp_bridge_attach(struct analogix_dp_pl= at_data *plat_data, =20 /* Pre-empt DP connector creation if there's a bridge */ if (plat_data->next_bridge) { - if (dp->has_of_bridge) - flags =3D DRM_BRIDGE_ATTACH_NO_CONNECTOR; - - ret =3D drm_bridge_attach(&dp->encoder, plat_data->next_bridge, bridge, = flags); + ret =3D drm_bridge_attach(&dp->encoder, plat_data->next_bridge, bridge, + flags | DRM_BRIDGE_ATTACH_NO_CONNECTOR); if (ret) return ret; } @@ -111,6 +108,7 @@ static int exynos_dp_bind(struct device *dev, struct de= vice *master, void *data) struct exynos_dp_device *dp =3D dev_get_drvdata(dev); struct drm_encoder *encoder =3D &dp->encoder; struct drm_device *drm_dev =3D data; + struct drm_connector *connector; int ret; =20 dp->drm_dev =3D drm_dev; @@ -126,10 +124,19 @@ static int exynos_dp_bind(struct device *dev, struct = device *master, void *data) dp->plat_data.encoder =3D encoder; =20 ret =3D analogix_dp_bind(dp->adp, dp->drm_dev); - if (ret) + if (ret) { dp->encoder.funcs->destroy(&dp->encoder); + return ret; + } + + connector =3D drm_bridge_connector_init(dp->drm_dev, dp->plat_data.encode= r); + if (IS_ERR(connector)) { + ret =3D PTR_ERR(connector); + dev_err(dp->dev, "Failed to initialize bridge_connector\n"); + return ret; + } =20 - return ret; + return drm_connector_attach_encoder(connector, dp->plat_data.encoder); } =20 static void exynos_dp_unbind(struct device *dev, struct device *master, @@ -186,8 +193,6 @@ static int exynos_dp_probe(struct platform_device *pdev) dp->dev->of_node, DRM_MODE_CONNECTOR_eDP); ret =3D IS_ERR(dp->plat_data.next_bridge) ? PTR_ERR(dp->plat_data.next_b= ridge) : 0; - if (!ret) - dp->has_of_bridge =3D true; } if (ret) return ret; diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kc= onfig index 1479b8c4ed40..e7f49fe845ea 100644 --- a/drivers/gpu/drm/rockchip/Kconfig +++ b/drivers/gpu/drm/rockchip/Kconfig @@ -46,6 +46,7 @@ config ROCKCHIP_VOP2 config ROCKCHIP_ANALOGIX_DP bool "Rockchip specific extensions for Analogix DP driver" depends on ROCKCHIP_VOP + select DRM_BRIDGE_CONNECTOR select DRM_DISPLAY_HELPER select DRM_DISPLAY_DP_HELPER help diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/= drm/rockchip/analogix_dp-rockchip.c index 48206a7b767f..99e739f4f583 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #include #include @@ -369,6 +370,7 @@ static int rockchip_dp_bind(struct device *dev, struct = device *master, { struct rockchip_dp_device *dp =3D dev_get_drvdata(dev); struct drm_device *drm_dev =3D data; + struct drm_connector *connector; int ret; =20 dp->drm_dev =3D drm_dev; @@ -388,7 +390,14 @@ static int rockchip_dp_bind(struct device *dev, struct= device *master, if (ret) goto err_cleanup_encoder; =20 - return 0; + connector =3D drm_bridge_connector_init(dp->drm_dev, dp->plat_data.encode= r); + if (IS_ERR(connector)) { + ret =3D PTR_ERR(connector); + dev_err(dp->dev, "Failed to initialize bridge_connector\n"); + goto err_cleanup_encoder; + } + + return drm_connector_attach_encoder(connector, dp->plat_data.encoder); err_cleanup_encoder: dp->encoder.encoder.funcs->destroy(&dp->encoder.encoder); return ret; --=20 2.34.1 From nobody Sat Apr 18 06:56:12 2026 Received: from mail-m19731107.qiye.163.com (mail-m19731107.qiye.163.com [220.197.31.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 055FA3A8FE6; Mon, 13 Apr 2026 13:26:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.107 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776086774; cv=none; b=Mkps2+YhfwdtyukDDYJqZg+c+0l3zu3BsyjsKHvpP5KgcwPiqWPSKC3p8OTIi+o8/onru4b3ULV7ATMhNUeark2+R7ayc9Wol8WH1HbZoKgp6uFkiKGU2NuD20EPDASVpEmcXWj1f0UhAIeOkd9QFUgtnMfeefwItuxJHww6ia0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776086774; c=relaxed/simple; bh=31nxYz1ApxVufhdWY+nJZjyKWFHHJrO8aYsakEx7hPA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lEXikz+ODkCOT46t9lTGrz4TrV9KX/w56TG7TYnSPPmkRX9H4ydtEszx+FmdH8rXfoy33wBBtw1zPg3u4Y+xDdihh+Kijsj7jjpzcZOHDUMyUl6K/zWbsjojAsacahysJs15P6c5i82GOmXEVOAM4wUxt5MwyHKPNhXIhoYp2iA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=CdPx9iS4; arc=none smtp.client-ip=220.197.31.107 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="CdPx9iS4" Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 3a8976adf; Mon, 13 Apr 2026 21:26:00 +0800 (GMT+08:00) From: Damon Ding To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, jingoohan1@gmail.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, alim.akhtar@samsung.com, dmitry.baryshkov@oss.qualcomm.com, luca.ceresoli@bootlin.com, nicolas.frattaroli@collabora.com, dianders@chromium.org, m.szyprowski@samsung.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Damon Ding Subject: [PATCH v14 3/8] drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() Date: Mon, 13 Apr 2026 21:25:46 +0800 Message-Id: <20260413132551.1049307-4-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260413132551.1049307-1-damon.ding@rock-chips.com> References: <20260413132551.1049307-1-damon.ding@rock-chips.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a9d87053c8703a3kunmf5e06f40656e55 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGkpIHlZNTklLSB9KSBlLGB5WFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpKQk 1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=CdPx9iS4+3KaKlayKDNotavCGVlgxCG7kF1Q5Rgx0YFP2DLlzZeQr9XGKYC9Pa3e1wWIooO8f3OQjR+P12ShW/PC0H2qv4LyaFbGdHLgMI6c23sQa1mKqQtP/B7G98g/5kVOOktW4qoWn24BnSVkrVsp4yWVa7F7nVO0UR3XPmw=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=A5keYFJrkzJg3KtOz/q0z9EqomERCDhhSfauQH5w3LQ=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" Since the panel/bridge should logically be positioned behind the Analogix bridge in the display pipeline, it makes sense to handle the panel/bridge parsing on the Analogix side. Therefore, we add a new API analogix_dp_finish_probe(), which combines the panel/bridge parsing with component addition, to do it. In order to process component binding right after the probe completes, the &analogix_dp_plat_data.ops is newly added to pass &component_ops, for which the &dp_aux_ep_device_with_data.done_probing() of DP AUX bus only supports passing &drm_dp_aux. Signed-off-by: Damon Ding Reviewed-by: Dmitry Baryshkov Tested-by: Marek Szyprowski Tested-by: Heiko Stuebner # rk3588 --- Changes in v4: - Rename the &analogix_dp_plat_data.bridge to &analogix_dp_plat_data.next_bridge. - Remame API analogix_dp_find_panel_or_bridge() to analogix_dp_finish_probe(). Changes in v5: - Select DRM_DISPLAY_DP_AUX_BUS for DRM_ANALOGIX_DP. Changes in v9: - Add Tested-by tag. Changes in v10: - Fix to use dev_err_probe() in analogix_dp_finish_probe(). - Expand the commit message. Changes in v13: - Modify '(on rk3588)' to '# rk3588' for Tested-by tag. --- drivers/gpu/drm/bridge/analogix/Kconfig | 1 + .../drm/bridge/analogix/analogix_dp_core.c | 46 +++++++++++++++++++ include/drm/bridge/analogix_dp.h | 2 + 3 files changed, 49 insertions(+) diff --git a/drivers/gpu/drm/bridge/analogix/Kconfig b/drivers/gpu/drm/brid= ge/analogix/Kconfig index 03dc7ffe824a..8a6136cd675f 100644 --- a/drivers/gpu/drm/bridge/analogix/Kconfig +++ b/drivers/gpu/drm/bridge/analogix/Kconfig @@ -29,6 +29,7 @@ config DRM_ANALOGIX_ANX78XX config DRM_ANALOGIX_DP tristate depends on DRM + select DRM_DISPLAY_DP_AUX_BUS =20 config DRM_ANALOGIX_ANX7625 tristate "Analogix Anx7625 MIPI to DP interface support" diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.c index 3c6eed9279d2..50415a98acb7 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -21,12 +21,14 @@ #include =20 #include +#include #include #include #include #include #include #include +#include #include #include #include @@ -1582,6 +1584,50 @@ struct drm_dp_aux *analogix_dp_get_aux(struct analog= ix_dp_device *dp) } EXPORT_SYMBOL_GPL(analogix_dp_get_aux); =20 +static int analogix_dp_aux_done_probing(struct drm_dp_aux *aux) +{ + struct analogix_dp_device *dp =3D to_dp(aux); + struct analogix_dp_plat_data *plat_data =3D dp->plat_data; + int port =3D plat_data->dev_type =3D=3D EXYNOS_DP ? 0 : 1; + int ret; + + /* + * If drm_of_find_panel_or_bridge() returns -ENODEV, there may be no vali= d panel + * or bridge nodes. The driver should go on for the driver-free bridge or= the DP + * mode applications. + */ + ret =3D drm_of_find_panel_or_bridge(dp->dev->of_node, port, 0, + &plat_data->panel, &plat_data->next_bridge); + if (ret && ret !=3D -ENODEV) + return ret; + + return component_add(dp->dev, plat_data->ops); +} + +int analogix_dp_finish_probe(struct analogix_dp_device *dp) +{ + int ret; + + ret =3D devm_of_dp_aux_populate_bus(&dp->aux, analogix_dp_aux_done_probin= g); + if (ret) { + /* + * If devm_of_dp_aux_populate_bus() returns -ENODEV, the done_probing() = will + * not be called because there are no EP devices. Then the callback func= tion + * analogix_dp_aux_done_probing() will be called directly in order to su= pport + * the other valid DT configurations. + * + * NOTE: The devm_of_dp_aux_populate_bus() is allowed to return -EPROBE_= DEFER. + */ + if (ret !=3D -ENODEV) + return dev_err_probe(dp->dev, ret, "failed to populate aux bus\n"); + + return analogix_dp_aux_done_probing(&dp->aux); + } + + return 0; +} +EXPORT_SYMBOL_GPL(analogix_dp_finish_probe); + MODULE_AUTHOR("Jingoo Han "); MODULE_DESCRIPTION("Analogix DP Core Driver"); MODULE_LICENSE("GPL v2"); diff --git a/include/drm/bridge/analogix_dp.h b/include/drm/bridge/analogix= _dp.h index 3428ffff24c5..bae969dec63a 100644 --- a/include/drm/bridge/analogix_dp.h +++ b/include/drm/bridge/analogix_dp.h @@ -30,6 +30,7 @@ struct analogix_dp_plat_data { struct drm_bridge *next_bridge; struct drm_encoder *encoder; struct drm_connector *connector; + const struct component_ops *ops; =20 int (*power_on)(struct analogix_dp_plat_data *); int (*power_off)(struct analogix_dp_plat_data *); @@ -49,5 +50,6 @@ int analogix_dp_stop_crc(struct drm_connector *connector); =20 struct analogix_dp_plat_data *analogix_dp_aux_to_plat_data(struct drm_dp_a= ux *aux); struct drm_dp_aux *analogix_dp_get_aux(struct analogix_dp_device *dp); +int analogix_dp_finish_probe(struct analogix_dp_device *dp); =20 #endif /* _ANALOGIX_DP_H_ */ --=20 2.34.1 From nobody Sat Apr 18 06:56:12 2026 Received: from mail-m155116.qiye.163.com (mail-m155116.qiye.163.com [101.71.155.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9CA3382F1B; Mon, 13 Apr 2026 13:26:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776086776; cv=none; b=bvxsecBrry6UCnPLpEaAvUkol7LP3zdgI2+MuTMv3+I1ykZqfk6cUwo+e9vsiJh4ScvzPuhxn1NnXyPumo92PzE1qS7JVoABM7nrIvKEE4CXf6jtctu66GIEWHBd5oEBjKGLT8LTREdCrlvGtzcu7moFsW4RW8KNuNhZFRdcDik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776086776; c=relaxed/simple; bh=zW98UFilD+JBqKBR9X1qIFgOgeFPqXZfPhruw/h98Cg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=p/Ywvx5Xsy79DiWmkYhiX/JqEW7oIuuTqOncXcSYvfE1eyqwkxduJO0wuQc40vJKLuLTI5U75CHb3hG0WErLuKbxWRGgUq08F/WEVRru/WpwfGZ4M1njuL0boQH4bN9WTiEi8QHlxRg+yeNLM8tqMs+W+uCRFjPWjiCbVvYHv4Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=XUhLmjWH; arc=none smtp.client-ip=101.71.155.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="XUhLmjWH" Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 3a8976ae0; Mon, 13 Apr 2026 21:26:02 +0800 (GMT+08:00) From: Damon Ding To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, jingoohan1@gmail.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, alim.akhtar@samsung.com, dmitry.baryshkov@oss.qualcomm.com, luca.ceresoli@bootlin.com, nicolas.frattaroli@collabora.com, dianders@chromium.org, m.szyprowski@samsung.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Damon Ding Subject: [PATCH v14 4/8] drm/rockchip: analogix_dp: Apply analogix_dp_finish_probe() Date: Mon, 13 Apr 2026 21:25:47 +0800 Message-Id: <20260413132551.1049307-5-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260413132551.1049307-1-damon.ding@rock-chips.com> References: <20260413132551.1049307-1-damon.ding@rock-chips.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a9d870544af03a3kunmf5e06f40656e5e X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQhkdSVZMTRgYGUwZGkpDHk1WFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpKQk 1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=XUhLmjWHstI/fPiq9xzJI75giFFBmzsbDO81DYrt9F+TWLKax5kx2Yqw5/qTedBaXE8BQBF4uwVe0iCbcPgEBoPx4HLOJqPPrqE4Wr81VLw/j05CHnyUSRtx2Yd7sRLvf8wYkQ/ojhrhgZUs4hNwYgeerul3GAYxk7vKRmzwA58=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=m/hlXvqfFqpB287qovJx8YKrbb68wHZcPxZImx/NI18=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" Apply analogix_dp_finish_probe() in order to move the panel/bridge parsing from Rockchip side to the Analogix side. Signed-off-by: Damon Ding Reviewed-by: Dmitry Baryshkov Tested-by: Heiko Stuebner # rk3588 --- Changes in v4: - Rename analogix_dp_find_panel_or_bridge() to analogix_dp_finish_probe(). Changes in v5: - Remove DRM_DISPLAY_DP_AUX_BUS for ROCKCHIP_ANALOGIX_DP Changes in v9: - Add Tested-by tag. Changes in v13: - Modify '(on rk3588)' to '# rk3588' for Tested-by tag. --- .../gpu/drm/rockchip/analogix_dp-rockchip.c | 38 +------------------ 1 file changed, 2 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/= drm/rockchip/analogix_dp-rockchip.c index 99e739f4f583..eea230f0227a 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -21,14 +21,12 @@ #include