From nobody Sat Jun 20 16:31:05 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEB0634DCD9 for ; Mon, 13 Apr 2026 12:00:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776081603; cv=none; b=GbU4Ve/FXCYcT2V6oW2eQ+P0Fr75zmie1N3RtjNp/tWM5NKmVHB7dg1MfSau0+irWucklQ/0nx+ENmrKh7BeNE2MVwP1NEritVljh5OSigNhlnuHLoIQYGDOAC3oWujts7vMRgSTRmc/LHG6pFJ6iph1lBmXzLoYf6yDV/vAwLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776081603; c=relaxed/simple; bh=6fwLwWNLs1EfDGkdX3ygPgU9zxnBYk06z+iVq0IN+O4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RE3VFpqnEYeicND35rNJ+FZGnhj0JKjBfibkcWZXahLtdATeh5cKwaAgFEtSmkMW5ZMaXzEusoSb/B7kLYY2ilPwGNRWOvWblSFbGhRJkfdYJjukZfte5eR2m0yI/uz4TLU9TuDmfuMYVlWso6RrxL1nn4hzUfVU5szeo1351N4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NAHT55EH; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NAHT55EH" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c741692db4cso1072802a12.1 for ; Mon, 13 Apr 2026 05:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776081601; x=1776686401; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3u8EWySsHMnJmBCST1Ast9PFMWGZFxzWnCzXib4HbCo=; b=NAHT55EHxxUmHG/sJlomRZbP0jXVWEoeLLns7CAvoZO44nWxqhs5W5BX0SY3kRD2H3 O49mfKq0AWmi+Bi++aHzN43uOhduJvfmphxi9ECZ8kQ82EdVP3Oe2Of2rK+vkYeHHPxE hazlMwpVkhOUmSVJlNvFfZEpbetmvBLPKCdpN2GOgbL6sw5jmBE90L/24IGY0h3DoPXi kMTfkhbF/pNu6AaYVsFl8ck0H+92Ug1Hg7lAUbWZEEUIzqfEqXpKop9w2G1otQ5ykJii FLxP7ZuKWSUwgD/zqLBmRbH3rWYyIe8+oCO/G914GU2/fmQgKNT2X35kqZgPZ9uVD7Ub 2feQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776081601; x=1776686401; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3u8EWySsHMnJmBCST1Ast9PFMWGZFxzWnCzXib4HbCo=; b=VmLMWg79uAnGqYfMfj3al3Ymn6mLxFT3HWMMQ949yag1ZxVNxLo5c+98pfJf6KZJtE AecjYXLGaF+q8ijLOflSZKuhxUeEemfDyp/XR097P4Fc1zh4LULbI/IPphDgJQxc6RkG 228mWyQPGPqMM98UXjvPcvz5fjmVGsABwniybgVnXbqNl+esbhJ7Jk/TawsAjYV59Tjv 4VN/zTjG5s9RVGCQfqdQr/5s/P320VOiwqxMjOdI/uIdmwNmf4lSVhlM0zFSu01Whl5W zB0iYv9izNse88IWPeV1lmMGOXOFIHO4QqZFUj/IrDBphKvEEu2tPen1KrjA9R09xKUB te7g== X-Forwarded-Encrypted: i=1; AFNElJ+INEyg4vDH8cD/2vNtaD470A1ISIsypHh5uVkdK63YlsDT38z2c/oTH7osIUDRmlqBZajsTElVs5ItG0Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yzd2fTycw2kCyUwupln+HtPEND0ucUZMW/+PuTuI8pf+++Bsa7g sGM/iIj8nUz2TUfrrcRervFG7o3Y6kgU3qBAydWeh68nGMJn/KpBk7fo X-Gm-Gg: AeBDieuI7U8nJc4Zcyq+LBO2F5sAM5iua3CV7z+wEfeGLfnO0OfLKq4q4pnIRVBHO0F TQHXG/z2BpmPsq3ge0PUVBbE7UvUxDgGEKlLofreX8Ix2jmleAf8MfgOSFzR0ItcaW1JyDJei7u nu4TVOFVDPVpGwbAhYIeoT9R00RuN2C3nsIMneDbHEvyTfOwHQYjgOy7SBN/mc2xiYvX9yxzYU7 2kIekul01Uxfqv5cxFbws5rW8q73xwqagERcaJZquR2bQcRWXI1BaACCHDPRC4+l8kP81I/fwWo LPrpDvta9T2yEr34LXWT3w2EFJ5mDB9riVszqJrtbDwUR5QUz9UerGbjPnHPheES2zbt9CKOwb4 qY//DyeEiWTTOs1JPi87+XCv8+SeNdhYx2yJTq5qVjL83XS/7s4e7ebBqGBqGDopw0C+dRguo2V qiAdSJjxxYe5mThvKkS+1JVFOJZGGpAbw= X-Received: by 2002:a05:6a20:e212:b0:39f:48fe:830b with SMTP id adf61e73a8af0-39fc95aa2d7mr17020912637.30.1776081601292; Mon, 13 Apr 2026 05:00:01 -0700 (PDT) Received: from lgs.. ([2409:893d:1188:142d:db27:7a46:955d:48f7]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7944cd52d0sm764199a12.21.2026.04.13.04.59.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 05:00:00 -0700 (PDT) From: Guangshuo Li To: Yishai Hadas , Jason Gunthorpe , Leon Romanovsky , Roland Dreier , Jack Morgenstein , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v2] IB/mlx4: Fix refcount leak in add_port() error path Date: Mon, 13 Apr 2026 19:59:48 +0800 Message-ID: <20260413115949.2799399-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After kobject_init_and_add(), the lifetime of the embedded struct kobject is expected to be managed through the kobject core reference counting. In add_port(), if kobject_init_and_add() fails, the error path frees p directly instead of releasing the kobject reference with kobject_put(). This may leave the reference count of the embedded struct kobject unbalanced, resulting in a refcount leak and potentially leading to a use-after-free. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fix this by using kobject_put(&p->kobj) in the kobject_init_and_add() failure path. Fixes: c1e7e466120b ("IB/mlx4: Add iov directory in sysfs under the ib devi= ce") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v2: - note that the issue was identified by my static analysis tool - and confirmed by manual review drivers/infiniband/hw/mlx4/sysfs.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx4/sysfs.c b/drivers/infiniband/hw/mlx= 4/sysfs.c index 88f534cf690e..15b36b9e4bd6 100644 --- a/drivers/infiniband/hw/mlx4/sysfs.c +++ b/drivers/infiniband/hw/mlx4/sysfs.c @@ -642,7 +642,7 @@ static int add_port(struct mlx4_ib_dev *dev, int port_n= um, int slave) kobject_get(dev->dev_ports_parent[slave]), "%d", port_num); if (ret) - goto err_alloc; + goto err_kobj; =20 p->pkey_group.name =3D "pkey_idx"; p->pkey_group.attrs =3D @@ -689,6 +689,11 @@ static int add_port(struct mlx4_ib_dev *dev, int port_= num, int slave) kobject_put(dev->dev_ports_parent[slave]); kfree(p); return ret; + +err_kobj: + kobject_put(&p->kobj); + return ret; + } =20 static int register_one_pkey_tree(struct mlx4_ib_dev *dev, int slave) --=20 2.43.0