From nobody Sun Jun 14 03:06:27 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C50B63AEF57 for ; Mon, 13 Apr 2026 11:25:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776079510; cv=none; b=uPHgPzu9etDxX2RSjy0G5jekh2gXIcrz8QcBJMhWY1f6AlxU8R466PHX8Jo2+hdQUKk11RNsBvKMbYjBBXr9bXVHpHELoj3h6FO7XdoBnsQ/08IoG64lYUPonfw46h0n/REovTy0a/n3GMetcfgZSAP0/eK6WQCeyEN2qbGJ4WU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776079510; c=relaxed/simple; bh=NqsU/qOPao42EcOBG6Z9z8WyLUb6yYc5fT28oF/v9TM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=srWhcmKKP5mCzzMBgxQQdb9pI2FHFx9eVWmV304KqmU6kFNEFcHxQl8yT30tyfsETR1phQiNhi1kI5HwMNgGOv7LmzGAZVvlicrdKv4j97RppnTwScmDYq2X5a2Dsbwj22mavqLZAv83GB3ovfxJtSLS+hUS0mx9Zb//VacQDbE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L3QAOFnm; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L3QAOFnm" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-35dac556bb2so2429196a91.1 for ; Mon, 13 Apr 2026 04:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776079509; x=1776684309; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QFsci77/A4yDoiebbXujv7ZKG9pgAsn7mtVW3rLgh+0=; b=L3QAOFnmA9+GBSsZKXL4ZL4Pz25YhK60yfIER7hy1uFhj1drVRt5F7Jfx9IsEndQyO IpxZ1KqLonLYhsL/9l3dalp0rGPeMAw69iUCLLveBq1Bcet5bU6UnnMIYsrO7Hz8b3aH gqb9kgg6mmPPtgbVuAFWdr5ic5qFkozeEw+EkhwJxKjkEg7n3hi2EnxGARX85d8hS4Ko HoMmrSDMnS6YT1+Xu1ruESNyJwNr2whUeb9x+tPmQLBIbCizpLbpmSoogcAXGinpE9TG ZjYHGgEhl0hA78YG6J7b1vOZGveC9UTggB6G6Rsy0ekvFgAxSw+n4OtKaiyOLxQfRQwr 7MRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776079509; x=1776684309; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QFsci77/A4yDoiebbXujv7ZKG9pgAsn7mtVW3rLgh+0=; b=aY6EzM/FRUa1qF4ynsEVQXEYljJ2bJKMXb3OtJHiISnalrLQLcJtpJVuRbCc1fVUwx KoBKaz1b8ycy3q58YZnsJtHTUVpNe3q1EzS/uvDIEpPN1kfn/mLVuNvmSd4DWtqXmeBz 9u4XNXvGIm6d/3vEKgjwke6jXFZN6V1Ml4dWdS3E6AIuaHbUQzgY3jiIpBi5BpUWAV4d 7I62/imex+TV4JnYUX/DyR6SmEBdKAmVnR00TkSyYOAWCOS3hyjgHIAvPW3ig5mcy5NT v6vrguTKCM5JIyr3Tyx/SgEgVxUkuDkbbNNtOQ3WbAv6gASg9uMg6PGxjSqwaCTZEsd7 yZWg== X-Forwarded-Encrypted: i=1; AFNElJ9ZISHs/AGpx4WJQoci6HM/MMvjiiF1BrmdB0Auv4c0Y2N19+cwby2KwSOMboCfdGINaSbOkkTaDGpj4N4=@vger.kernel.org X-Gm-Message-State: AOJu0YxnftK0AfT/AciYEQdg9r5TG4W5upEr2Nb6MKlXOOTYwq1TxIC6 FOgEeyYxQexXMZCy8Dvneh0/2U5USlykpeXPZd1O5xX6tqQ5uZvRCazy X-Gm-Gg: AeBDievwmEXlCbW7WlAKFyl9Y+fuwkkpYn+uOwBAScsVnV2Ovo5ZCFSjHESKYvArSAF VPe4odUXYGxS9L0Y/EjsCjtAjDzmAcnR5Xo1mtmdwnkH/91QFQbVZBU+EqutjMeBcyfsyyL7DlC Fby9h72RtX+EzjypzJHpuP2Xuv1W781rxS2iqfqa8B5a0QC01Q6Prc5LV1fM2CVsczVK+jPwtem LVMoVQ1F2bK7VbC+EHRO6aedox/XmJtu0KEMIJeQtG+WvAPf7u03hZMHTK7wrZWgj8gQYdskYq/ 4Iffagz7RlMMPxV8gLxDQSoKjISGVe+uyZOdkHo50g+zaMz0/HCkhRcXrcP9yw+F57UpjnoPmW+ AN5pzwVWPQ25HtXc9Wu2xPA0kh+YGgc56kpeFd1IKsQkIeXWckuT9135/rdd6K6Zq5lemRjImCP pztgwsRjCutDy4P/M= X-Received: by 2002:a17:902:b490:b0:2b0:6e60:9582 with SMTP id d9443c01a7336-2b2d59661ddmr101026165ad.18.1776079509075; Mon, 13 Apr 2026 04:25:09 -0700 (PDT) Received: from lgs.. ([199.182.234.55]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2d4f2af90sm116157525ad.64.2026.04.13.04.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 04:25:08 -0700 (PDT) From: Guangshuo Li To: Vinicius Costa Gomes , Dave Jiang , Vinod Koul , Dan Carpenter , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v2] dmaengine: idxd: fix double free in idxd_setup_wqs() error path Date: Mon, 13 Apr 2026 19:24:57 +0800 Message-ID: <20260413112457.2705114-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When an error happens after device_initialize(), idxd_setup_wqs() calls put_device(conf_dev). The device release callback idxd_conf_wq_release() frees wq, wq->wqcfg, and wq->opcap_bmap, but the current error paths then free them again directly, causing a double free. The issue was identified by a static analysis tool I developed and confirmed by manual review. Keep the cleanup in idxd_conf_wq_release() after put_device() and avoid freeing those objects again in idxd_setup_wqs(). Fixes: 39aaa337449e7 ("dmaengine: idxd: Fix double free in idxd_setup_wqs()= ") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v2: - note that the issue was identified by my static analysis tool - and confirmed by manual review drivers/dma/idxd/init.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c index 2acc34b3daff..f1bd9812c90d 100644 --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -212,7 +212,6 @@ static int idxd_setup_wqs(struct idxd_device *idxd) rc =3D dev_set_name(conf_dev, "wq%d.%d", idxd->id, wq->id); if (rc < 0) { put_device(conf_dev); - kfree(wq); goto err_unwind; } =20 @@ -226,7 +225,6 @@ static int idxd_setup_wqs(struct idxd_device *idxd) wq->wqcfg =3D kzalloc_node(idxd->wqcfg_size, GFP_KERNEL, dev_to_node(dev= )); if (!wq->wqcfg) { put_device(conf_dev); - kfree(wq); rc =3D -ENOMEM; goto err_unwind; } @@ -234,9 +232,7 @@ static int idxd_setup_wqs(struct idxd_device *idxd) if (idxd->hw.wq_cap.op_config) { wq->opcap_bmap =3D bitmap_zalloc(IDXD_MAX_OPCAP_BITS, GFP_KERNEL); if (!wq->opcap_bmap) { - kfree(wq->wqcfg); put_device(conf_dev); - kfree(wq); rc =3D -ENOMEM; goto err_unwind; } @@ -252,12 +248,8 @@ static int idxd_setup_wqs(struct idxd_device *idxd) err_unwind: while (--i >=3D 0) { wq =3D idxd->wqs[i]; - if (idxd->hw.wq_cap.op_config) - bitmap_free(wq->opcap_bmap); - kfree(wq->wqcfg); conf_dev =3D wq_confdev(wq); put_device(conf_dev); - kfree(wq); } bitmap_free(idxd->wq_enable_map); =20 --=20 2.43.0