From nobody Thu Jun 11 22:58:33 2026 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ECF237F75F for ; Mon, 13 Apr 2026 10:15:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075327; cv=none; b=WgYQGToM+w6n9edCBrNpUS5EyVYKgf6Ay9taC5+FpgXWNBjYZ0SElaLjufYwFuq5RnJARO5klXrfukh+66SqjoOhSLMMLGQtlFlr7wAY4op4lca/NSSL8SpwB1uJpy27Up9f9J7zudqXUUzfYWcPQsp/j0KdusPeuEov7HwE0tI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075327; c=relaxed/simple; bh=tOj8owt6Z5wjZBVosXvW1VVS/W60e7upmE8DJq/C9Ys=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VtJ4mQxmV60gTwcSP7KjNxl7gZzKmDVGuhkmLqOE/G1lsGh+8KfiUNfxJVV7+KZttzGo7YzEDIeKy236vW0iSqKUv4GM82IDL2BPwsmF7OH426Tg+DH6sEi5KckPRmECyKDo6Yy28sjRAm7v0uILxL/g3YMTI2Wx3TgePcbCkhc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=J1AJRHkI; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="J1AJRHkI" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776075322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E6GWZOmMkk8OVmWpaA2pfFmsIAXAoTe5qof7vXLu6Lg=; b=J1AJRHkIKFaJ4QX8ZyQiV8zhh+GJccWjvMxDsoVJgZBeXbVZmS6J5h2ypNeZ/Kgrwqu+/0 nrln0cECeB02WacjReWPC9pOk17fctWjKs6ftXcQZLe38lDh0AtrkpoML5zooFs3bVNRva ON6JkpXkP5FNXctq0h+/yW3GAgtubOs= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Luka Gejak , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [PATCH 01/11] staging: rtl8723bs: core: fix spacing around operators and casts Date: Mon, 13 Apr 2026 12:14:22 +0200 Message-ID: <20260413101432.158925-2-luka.gejak@linux.dev> In-Reply-To: <20260413101432.158925-1-luka.gejak@linux.dev> References: <20260413101432.158925-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Luka Gejak Fix spaces around operators and casts in the core directory to adhere to the Linux kernel coding style. This resolves multiple spacing warnings reported by checkpatch.pl. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/core/rtw_ioctl_set.c | 6 +- drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 +- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 202 +++++++++--------- drivers/staging/rtl8723bs/core/rtw_recv.c | 6 +- 4 files changed, 109 insertions(+), 109 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ioctl_set.c index c70541f95a73..439b91862d55 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c @@ -151,7 +151,7 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct= ndis_802_11_ssid *ssid) else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) =3D=3D true) goto release_mlme_lock; =20 - if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) =3D=3D t= rue) { + if (check_fwstate(pmlmepriv, _FW_LINKED | WIFI_ADHOC_MASTER_STATE) =3D=3D= true) { if ((pmlmepriv->assoc_ssid.ssid_length =3D=3D ssid->ssid_length) && (!memcmp(&pmlmepriv->assoc_ssid.ssid, ssid->ssid, ssid->ssid_length)= )) { if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D false) { @@ -487,13 +487,13 @@ u16 rtw_get_cur_max_rate(struct adapter *adapter) psta->htpriv.ht_cap.mcs.rx_mask); } else { while ((pcur_bss->supported_rates[i] !=3D 0) && (pcur_bss->supported_rat= es[i] !=3D 0xFF)) { - rate =3D pcur_bss->supported_rates[i]&0x7F; + rate =3D pcur_bss->supported_rates[i] & 0x7F; if (rate > max_rate) max_rate =3D rate; i++; } =20 - max_rate =3D max_rate*10/2; + max_rate =3D max_rate * 10 / 2; } =20 return max_rate; diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index ddfc56f0253d..35ee65c7a458 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -1075,7 +1075,7 @@ static void rtw_joinbss_update_network(struct adapter= *padapter, struct wlan_net rtw_update_protection(padapter, (cur_network->network.ies) + sizeof(struc= t ndis_802_11_fix_ie), (cur_network->network.ie_length)); =20 - rtw_update_ht_cap(padapter, cur_network->network.ies, cur_network->networ= k.ie_length, (u8) cur_network->network.configuration.ds_config); + rtw_update_ht_cap(padapter, cur_network->network.ies, cur_network->networ= k.ie_length, (u8)cur_network->network.configuration.ds_config); } =20 static struct rt_pmkid_list backupPMKIDList[NUM_PMKID_CACHE]; @@ -2502,7 +2502,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr =20 if (issued =3D=3D 0) { psta->htpriv.candidate_tid_bitmap |=3D BIT((u8)priority); - rtw_addbareq_cmd(padapter, (u8) priority, pattrib->ra); + rtw_addbareq_cmd(padapter, (u8)priority, pattrib->ra); } } } diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 5f00fe282d1b..07e1b30239a3 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -326,7 +326,7 @@ static u8 init_channel_set(struct adapter *padapter, u8= ChannelPlan, struct rt_c u8 b2_4GBand =3D false; u8 Index2G =3D 0; =20 - memset(channel_set, 0, sizeof(struct rt_channel_info)*MAX_CHANNEL_NUM); + memset(channel_set, 0, sizeof(struct rt_channel_info) * MAX_CHANNEL_NUM); =20 if (ChannelPlan >=3D RT_CHANNEL_DOMAIN_MAX && ChannelPlan !=3D RT_CHANNEL= _DOMAIN_REALTEK_DEFINE) return chanset_size; @@ -513,7 +513,7 @@ unsigned int OnProbeReq(struct adapter *padapter, union= recv_frame *precv_frame) return _SUCCESS; =20 if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D false && - check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE|WIFI_AP_STATE) =3D=3D f= alse) { + check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE | WIFI_AP_STATE) =3D=3D= false) { return _SUCCESS; } =20 @@ -526,7 +526,7 @@ unsigned int OnProbeReq(struct adapter *padapter, union= recv_frame *precv_frame) if (is_valid_p2p_probereq) goto _issue_probersp; =20 - if ((ielen !=3D 0 && false =3D=3D !memcmp((p+2), cur->ssid.ssid, cur->ss= id.ssid_length)) + if ((ielen !=3D 0 && false =3D=3D !memcmp((p + 2), cur->ssid.ssid, cur->= ssid.ssid_length)) || (ielen =3D=3D 0 && pmlmeinfo->hidden_ssid_mode) ) return _SUCCESS; @@ -597,7 +597,7 @@ unsigned int OnBeacon(struct adapter *padapter, union r= ecv_frame *precv_frame) } =20 /* check the vendor of the assoc AP */ - pmlmeinfo->assoc_AP_vendor =3D check_assoc_AP(pframe+sizeof(struct ieee= 80211_hdr_3addr), len-sizeof(struct ieee80211_hdr_3addr)); + pmlmeinfo->assoc_AP_vendor =3D check_assoc_AP(pframe + sizeof(struct ie= ee80211_hdr_3addr), len - sizeof(struct ieee80211_hdr_3addr)); =20 /* update TSF Value */ update_TSF(pmlmeext, pframe, len); @@ -616,7 +616,7 @@ unsigned int OnBeacon(struct adapter *padapter, union r= ecv_frame *precv_frame) return _SUCCESS; } =20 - if (((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) && (pmlmeinfo= ->state & WIFI_FW_ASSOC_SUCCESS)) { + if (((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) && (pmlmein= fo->state & WIFI_FW_ASSOC_SUCCESS)) { psta =3D rtw_get_stainfo(pstapriv, GetAddr2Ptr(pframe)); if (psta) { ret =3D rtw_check_bcn_info(padapter, pframe, len); @@ -634,7 +634,7 @@ unsigned int OnBeacon(struct adapter *padapter, union r= ecv_frame *precv_frame) =20 adaptive_early_32k(pmlmeext, pframe, len); } - } else if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_ADHOC_STATE) { + } else if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) { psta =3D rtw_get_stainfo(pstapriv, GetAddr2Ptr(pframe)); if (psta) { /* update WMM, ERP in the beacon */ @@ -684,7 +684,7 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) uint len =3D precv_frame->u.hdr.len; u8 offset =3D 0; =20 - if ((pmlmeinfo->state&0x03) !=3D WIFI_FW_AP_STATE) + if ((pmlmeinfo->state & 0x03) !=3D WIFI_FW_AP_STATE) return _FAIL; =20 sa =3D GetAddr2Ptr(pframe); @@ -698,8 +698,8 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) prxattrib->hdrlen =3D WLAN_HDR_A3_LEN; prxattrib->encrypt =3D _WEP40_; =20 - iv =3D pframe+prxattrib->hdrlen; - prxattrib->key_index =3D ((iv[3]>>6)&0x3); + iv =3D pframe + prxattrib->hdrlen; + prxattrib->key_index =3D ((iv[3] >> 6) & 0x3); =20 prxattrib->iv_len =3D 4; prxattrib->icv_len =3D 4; @@ -949,7 +949,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union= recv_frame *precv_frame) u8 *pframe =3D precv_frame->u.hdr.rx_data; uint pkt_len =3D precv_frame->u.hdr.len; =20 - if ((pmlmeinfo->state&0x03) !=3D WIFI_FW_AP_STATE) + if ((pmlmeinfo->state & 0x03) !=3D WIFI_FW_AP_STATE) return _FAIL; =20 frame_type =3D GetFrameSubType(pframe); @@ -1009,7 +1009,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) goto OnAssocReqFail; } else { /* check if ssid match */ - if (memcmp(p+2, cur->ssid.ssid, cur->ssid.ssid_length)) + if (memcmp(p + 2, cur->ssid.ssid, cur->ssid.ssid_length)) status =3D WLAN_STATUS_CHALLENGE_FAIL; =20 if (ie_len !=3D cur->ssid.ssid_length) @@ -1032,7 +1032,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) if (ie_len > sizeof(supportRate)) ie_len =3D sizeof(supportRate); =20 - memcpy(supportRate, p+2, ie_len); + memcpy(supportRate, p + 2, ie_len); support_rate_num =3D ie_len; =20 p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + ie_offset, WLAN_EID_EXT_SUPP= _RATES, &ie_len, @@ -1069,12 +1069,12 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) wpa_ie =3D elems.rsn_ie; wpa_ie_len =3D elems.rsn_ie_len; =20 - if (rtw_parse_wpa2_ie(wpa_ie-2, wpa_ie_len+2, &group_cipher, &pairwise_c= ipher, NULL) =3D=3D _SUCCESS) { + if (rtw_parse_wpa2_ie(wpa_ie - 2, wpa_ie_len + 2, &group_cipher, &pairwi= se_cipher, NULL) =3D=3D _SUCCESS) { pstat->dot8021xalg =3D 1;/* psk, todo:802.1x */ pstat->wpa_psk |=3D BIT(1); =20 - pstat->wpa2_group_cipher =3D group_cipher&psecuritypriv->wpa2_group_cip= her; - pstat->wpa2_pairwise_cipher =3D pairwise_cipher&psecuritypriv->wpa2_pai= rwise_cipher; + pstat->wpa2_group_cipher =3D group_cipher & psecuritypriv->wpa2_group_c= ipher; + pstat->wpa2_pairwise_cipher =3D pairwise_cipher & psecuritypriv->wpa2_p= airwise_cipher; =20 if (!pstat->wpa2_group_cipher) status =3D WLAN_STATUS_INVALID_GROUP_CIPHER; @@ -1092,12 +1092,12 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) wpa_ie =3D elems.wpa_ie; wpa_ie_len =3D elems.wpa_ie_len; =20 - if (rtw_parse_wpa_ie(wpa_ie-2, wpa_ie_len+2, &group_cipher, &pairwise_ci= pher, NULL) =3D=3D _SUCCESS) { + if (rtw_parse_wpa_ie(wpa_ie - 2, wpa_ie_len + 2, &group_cipher, &pairwis= e_cipher, NULL) =3D=3D _SUCCESS) { pstat->dot8021xalg =3D 1;/* psk, todo:802.1x */ pstat->wpa_psk |=3D BIT(0); =20 - pstat->wpa_group_cipher =3D group_cipher&psecuritypriv->wpa_group_ciphe= r; - pstat->wpa_pairwise_cipher =3D pairwise_cipher&psecuritypriv->wpa_pairw= ise_cipher; + pstat->wpa_group_cipher =3D group_cipher & psecuritypriv->wpa_group_cip= her; + pstat->wpa_pairwise_cipher =3D pairwise_cipher & psecuritypriv->wpa_pai= rwise_cipher; =20 if (!pstat->wpa_group_cipher) status =3D WLAN_STATUS_INVALID_GROUP_CIPHER; @@ -1128,7 +1128,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) /* AP support WPA/RSN, and sta is going to do WPS, but AP is not ready = */ /* that the selected registrar of AP is _FLASE */ if ((psecuritypriv->wpa_psk > 0) - && (pstat->flags & (WLAN_STA_WPS|WLAN_STA_MAYBE_WPS))) { + && (pstat->flags & (WLAN_STA_WPS | WLAN_STA_MAYBE_WPS))) { if (pmlmepriv->wps_beacon_ie) { u8 selected_registrar =3D 0; =20 @@ -1161,7 +1161,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) =20 =20 if (copy_len > 0) - memcpy(pstat->wpa_ie, wpa_ie-2, copy_len); + memcpy(pstat->wpa_ie, wpa_ie - 2, copy_len); =20 } =20 @@ -1182,7 +1182,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) if (!p) break; =20 - if (memcmp(p+2, WMM_IE, 6)) { + if (memcmp(p + 2, WMM_IE, 6)) { p =3D p + ie_len + 2; continue; } @@ -1190,33 +1190,33 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) pstat->flags |=3D WLAN_STA_WME; =20 pstat->qos_option =3D 1; - pstat->qos_info =3D *(p+8); + pstat->qos_info =3D *(p + 8); =20 - pstat->max_sp_len =3D (pstat->qos_info>>5)&0x3; + pstat->max_sp_len =3D (pstat->qos_info >> 5) & 0x3; =20 - if ((pstat->qos_info&0xf) !=3D 0xf) + if ((pstat->qos_info & 0xf) !=3D 0xf) pstat->has_legacy_ac =3D true; else pstat->has_legacy_ac =3D false; =20 - if (pstat->qos_info&0xf) { - if (pstat->qos_info&BIT(0)) - pstat->uapsd_vo =3D BIT(0)|BIT(1); + if (pstat->qos_info & 0xf) { + if (pstat->qos_info & BIT(0)) + pstat->uapsd_vo =3D BIT(0) | BIT(1); else pstat->uapsd_vo =3D 0; =20 - if (pstat->qos_info&BIT(1)) - pstat->uapsd_vi =3D BIT(0)|BIT(1); + if (pstat->qos_info & BIT(1)) + pstat->uapsd_vi =3D BIT(0) | BIT(1); else pstat->uapsd_vi =3D 0; =20 - if (pstat->qos_info&BIT(2)) - pstat->uapsd_bk =3D BIT(0)|BIT(1); + if (pstat->qos_info & BIT(2)) + pstat->uapsd_bk =3D BIT(0) | BIT(1); else pstat->uapsd_bk =3D 0; =20 - if (pstat->qos_info&BIT(3)) - pstat->uapsd_be =3D BIT(0)|BIT(1); + if (pstat->qos_info & BIT(3)) + pstat->uapsd_be =3D BIT(0) | BIT(1); else pstat->uapsd_be =3D 0; =20 @@ -1239,15 +1239,15 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) pstat->flags &=3D ~WLAN_STA_HT; =20 =20 - if ((pmlmepriv->htpriv.ht_option =3D=3D false) && (pstat->flags&WLAN_STA_= HT)) { + if ((pmlmepriv->htpriv.ht_option =3D=3D false) && (pstat->flags & WLAN_ST= A_HT)) { status =3D WLAN_STATUS_CHALLENGE_FAIL; goto OnAssocReqFail; } =20 =20 if ((pstat->flags & WLAN_STA_HT) && - ((pstat->wpa2_pairwise_cipher&WPA_CIPHER_TKIP) || - (pstat->wpa_pairwise_cipher&WPA_CIPHER_TKIP))) { + ((pstat->wpa2_pairwise_cipher & WPA_CIPHER_TKIP) || + (pstat->wpa_pairwise_cipher & WPA_CIPHER_TKIP))) { /* status =3D WLAN_STATUS_CIPHER_SUITE_REJECTED; */ /* goto OnAssocReqFail; */ } @@ -1394,7 +1394,7 @@ unsigned int OnAssocRsp(struct adapter *padapter, uni= on recv_frame *precv_frame) pmlmeinfo->slotTime =3D (pmlmeinfo->capability & BIT(10)) ? 9 : 20; =20 /* AID */ - res =3D pmlmeinfo->aid =3D (int)(le16_to_cpu(*(__le16 *)(pframe + WLAN_HD= R_A3_LEN + 4))&0x3fff); + res =3D pmlmeinfo->aid =3D (int)(le16_to_cpu(*(__le16 *)(pframe + WLAN_HD= R_A3_LEN + 4)) & 0x3fff); =20 /* following are moved to join event callback function */ /* to handle HT, WMM, rate adaptive, update MAC reg */ @@ -1626,7 +1626,7 @@ unsigned int OnAction_back(struct adapter *padapter, = union recv_frame *precv_fra if (memcmp(myid(&(padapter->eeprompriv)), GetAddr1Ptr(pframe), ETH_ALEN))= /* for if1, sta/ap mode */ return _SUCCESS; =20 - if ((pmlmeinfo->state&0x03) !=3D WIFI_FW_AP_STATE) + if ((pmlmeinfo->state & 0x03) !=3D WIFI_FW_AP_STATE) if (!(pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS)) return _SUCCESS; =20 @@ -1706,7 +1706,7 @@ static s32 rtw_action_public_decache(union recv_frame= *recv_frame, s32 token) struct adapter *adapter =3D recv_frame->u.hdr.adapter; struct mlme_ext_priv *mlmeext =3D &(adapter->mlmeextpriv); u8 *frame =3D recv_frame->u.hdr.rx_data; - u16 seq_ctrl =3D ((recv_frame->u.hdr.attrib.seq_num&0xffff) << 4) | + u16 seq_ctrl =3D ((recv_frame->u.hdr.attrib.seq_num & 0xffff) << 4) | (recv_frame->u.hdr.attrib.frag_num & 0xf); =20 if (GetRetry(frame)) { @@ -1842,9 +1842,9 @@ unsigned int OnAction_sa_query(struct adapter *padapt= er, union recv_frame *precv struct mlme_ext_priv *pmlmeext =3D &(padapter->mlmeextpriv); unsigned short tid; =20 - switch (pframe[WLAN_HDR_A3_LEN+1]) { + switch (pframe[WLAN_HDR_A3_LEN + 1]) { case 0: /* SA Query req */ - memcpy(&tid, &pframe[WLAN_HDR_A3_LEN+2], sizeof(unsigned short)); + memcpy(&tid, &pframe[WLAN_HDR_A3_LEN + 2], sizeof(unsigned short)); issue_action_SA_Query(padapter, GetAddr2Ptr(pframe), 1, tid); break; =20 @@ -2066,10 +2066,10 @@ static int update_hidden_ssid(u8 *ies, u32 ies_len,= u8 hidden_ssid_mode) u8 *next_ie =3D ssid_ie + 2 + ssid_len_ori; u32 remain_len =3D 0; =20 - remain_len =3D ies_len - (next_ie-ies); + remain_len =3D ies_len - (next_ie - ies); =20 ssid_ie[1] =3D 0; - memcpy(ssid_ie+2, next_ie, remain_len); + memcpy(ssid_ie + 2, next_ie, remain_len); len_diff -=3D ssid_len_ori; =20 break; @@ -2130,16 +2130,16 @@ void issue_beacon(struct adapter *padapter, int tim= eout_ms) pframe +=3D sizeof(struct ieee80211_hdr_3addr); pattrib->pktlen =3D sizeof(struct ieee80211_hdr_3addr); =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) { + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) { { int len_diff; =20 memcpy(pframe, cur_network->ies, cur_network->ie_length); - len_diff =3D update_hidden_ssid(pframe+_BEACON_IE_OFFSET_, - cur_network->ie_length-_BEACON_IE_OFFSET_, + len_diff =3D update_hidden_ssid(pframe + _BEACON_IE_OFFSET_, + cur_network->ie_length - _BEACON_IE_OFFSET_, pmlmeinfo->hidden_ssid_mode); - pframe +=3D (cur_network->ie_length+len_diff); - pattrib->pktlen +=3D (cur_network->ie_length+len_diff); + pframe +=3D (cur_network->ie_length + len_diff); + pattrib->pktlen +=3D (cur_network->ie_length + len_diff); } =20 { @@ -2147,8 +2147,8 @@ void issue_beacon(struct adapter *padapter, int timeo= ut_ms) uint wps_ielen; u8 sr =3D 0; =20 - wps_ie =3D rtw_get_wps_ie(pmgntframe->buf_addr+TXDESC_OFFSET+sizeof(str= uct ieee80211_hdr_3addr)+_BEACON_IE_OFFSET_, - pattrib->pktlen-sizeof(struct ieee80211_hdr_3addr)-_BEACON_IE_OFFSET_,= NULL, &wps_ielen); + wps_ie =3D rtw_get_wps_ie(pmgntframe->buf_addr + TXDESC_OFFSET + sizeof= (struct ieee80211_hdr_3addr) + _BEACON_IE_OFFSET_, + pattrib->pktlen - sizeof(struct ieee80211_hdr_3addr) - _BEACON_IE_OFFS= ET_, NULL, &wps_ielen); if (wps_ie && wps_ielen > 0) rtw_get_wps_attr_content(wps_ie, wps_ielen, WPS_ATTR_SELECTED_REGISTR= AR, (u8 *)(&sr), NULL); if (sr !=3D 0) @@ -2285,8 +2285,8 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p if (cur_network->ie_length > MAX_IE_SZ) return; =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) { - pwps_ie =3D rtw_get_wps_ie(cur_network->ies+_FIXED_IE_LENGTH_, cur_netwo= rk->ie_length-_FIXED_IE_LENGTH_, NULL, &wps_ielen); + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) { + pwps_ie =3D rtw_get_wps_ie(cur_network->ies + _FIXED_IE_LENGTH_, cur_net= work->ie_length - _FIXED_IE_LENGTH_, NULL, &wps_ielen); =20 /* inerset & update wps_probe_resp_ie */ if (pmlmepriv->wps_probe_resp_ie && pwps_ie && wps_ielen > 0) { @@ -2304,13 +2304,13 @@ void issue_probersp(struct adapter *padapter, unsig= ned char *da, u8 is_valid_p2p pattrib->pktlen +=3D wps_offset; =20 wps_ielen =3D (uint)pmlmepriv->wps_probe_resp_ie[1];/* to get ie data l= en */ - if ((wps_offset+wps_ielen+2) <=3D MAX_IE_SZ) { - memcpy(pframe, pmlmepriv->wps_probe_resp_ie, wps_ielen+2); - pframe +=3D wps_ielen+2; - pattrib->pktlen +=3D wps_ielen+2; + if ((wps_offset + wps_ielen + 2) <=3D MAX_IE_SZ) { + memcpy(pframe, pmlmepriv->wps_probe_resp_ie, wps_ielen + 2); + pframe +=3D wps_ielen + 2; + pattrib->pktlen +=3D wps_ielen + 2; } =20 - if ((wps_offset+wps_ielen+2+remainder_ielen) <=3D MAX_IE_SZ) { + if ((wps_offset + wps_ielen + 2 + remainder_ielen) <=3D MAX_IE_SZ) { memcpy(pframe, premainder_ie, remainder_ielen); pframe +=3D remainder_ielen; pattrib->pktlen +=3D remainder_ielen; @@ -2327,14 +2327,14 @@ void issue_probersp(struct adapter *padapter, unsig= ned char *da, u8 is_valid_p2p signed int ssid_ielen; signed int ssid_ielen_diff; u8 *buf; - u8 *ies =3D pmgntframe->buf_addr+TXDESC_OFFSET+sizeof(struct ieee80211_= hdr_3addr); + u8 *ies =3D pmgntframe->buf_addr + TXDESC_OFFSET + sizeof(struct ieee80= 211_hdr_3addr); =20 buf =3D kzalloc(MAX_IE_SZ, GFP_ATOMIC); if (!buf) return; =20 - ssid_ie =3D rtw_get_ie(ies+_FIXED_IE_LENGTH_, WLAN_EID_SSID, &ssid_iele= n, - (pframe-ies)-_FIXED_IE_LENGTH_); + ssid_ie =3D rtw_get_ie(ies + _FIXED_IE_LENGTH_, WLAN_EID_SSID, &ssid_ie= len, + (pframe - ies) - _FIXED_IE_LENGTH_); =20 ssid_ielen_diff =3D cur_network->ssid.ssid_length - ssid_ielen; =20 @@ -2342,8 +2342,8 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p uint remainder_ielen; u8 *remainder_ie; =20 - remainder_ie =3D ssid_ie+2; - remainder_ielen =3D (pframe-remainder_ie); + remainder_ie =3D ssid_ie + 2; + remainder_ielen =3D (pframe - remainder_ie); =20 if (remainder_ielen > MAX_IE_SZ) { netdev_warn(padapter->pnetdev, @@ -2353,9 +2353,9 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p } =20 memcpy(buf, remainder_ie, remainder_ielen); - memcpy(remainder_ie+ssid_ielen_diff, buf, remainder_ielen); - *(ssid_ie+1) =3D cur_network->ssid.ssid_length; - memcpy(ssid_ie+2, cur_network->ssid.ssid, cur_network->ssid.ssid_lengt= h); + memcpy(remainder_ie + ssid_ielen_diff, buf, remainder_ielen); + *(ssid_ie + 1) =3D cur_network->ssid.ssid_length; + memcpy(ssid_ie + 2, cur_network->ssid.ssid, cur_network->ssid.ssid_len= gth); =20 pframe +=3D ssid_ielen_diff; pattrib->pktlen +=3D ssid_ielen_diff; @@ -2393,7 +2393,7 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p /* DS parameter set */ pframe =3D rtw_set_ie(pframe, WLAN_EID_DS_PARAMS, 1, (unsigned char *)&(= cur_network->configuration.ds_config), &pattrib->pktlen); =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_ADHOC_STATE) { + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) { u8 erpinfo =3D 0; u32 ATIMWindow; /* IBSS Parameter Set... */ @@ -2748,7 +2748,7 @@ void issue_asocrsp(struct adapter *padapter, unsigned= short status, struct sta_i pframe =3D rtw_set_ie(pframe, WLAN_EID_SUPP_RATES, pstat->bssratelen, ps= tat->bssrateset, &(pattrib->pktlen)); } else { pframe =3D rtw_set_ie(pframe, WLAN_EID_SUPP_RATES, 8, pstat->bssrateset,= &(pattrib->pktlen)); - pframe =3D rtw_set_ie(pframe, WLAN_EID_EXT_SUPP_RATES, (pstat->bssratele= n-8), pstat->bssrateset+8, &(pattrib->pktlen)); + pframe =3D rtw_set_ie(pframe, WLAN_EID_EXT_SUPP_RATES, (pstat->bssratele= n - 8), pstat->bssrateset + 8, &(pattrib->pktlen)); } =20 if ((pstat->flags & WLAN_STA_HT) && (pmlmepriv->htpriv.ht_option)) { @@ -2758,18 +2758,18 @@ void issue_asocrsp(struct adapter *padapter, unsign= ed short status, struct sta_i /* p =3D hostapd_eid_ht_capabilities_info(hapd, p); */ pbuf =3D rtw_get_ie(ie + _BEACON_IE_OFFSET_, WLAN_EID_HT_CAPABILITY, &ie= _len, (pnetwork->ie_length - _BEACON_IE_OFFSET_)); if (pbuf && ie_len > 0) { - memcpy(pframe, pbuf, ie_len+2); - pframe +=3D (ie_len+2); - pattrib->pktlen +=3D (ie_len+2); + memcpy(pframe, pbuf, ie_len + 2); + pframe +=3D (ie_len + 2); + pattrib->pktlen +=3D (ie_len + 2); } =20 /* FILL HT ADD INFO IE */ /* p =3D hostapd_eid_ht_operation(hapd, p); */ pbuf =3D rtw_get_ie(ie + _BEACON_IE_OFFSET_, WLAN_EID_HT_OPERATION, &ie_= len, (pnetwork->ie_length - _BEACON_IE_OFFSET_)); if (pbuf && ie_len > 0) { - memcpy(pframe, pbuf, ie_len+2); - pframe +=3D (ie_len+2); - pattrib->pktlen +=3D (ie_len+2); + memcpy(pframe, pbuf, ie_len + 2); + pframe +=3D (ie_len + 2); + pattrib->pktlen +=3D (ie_len + 2); } =20 } @@ -2781,10 +2781,10 @@ void issue_asocrsp(struct adapter *padapter, unsign= ed short status, struct sta_i =20 for (pbuf =3D ie + _BEACON_IE_OFFSET_; ; pbuf +=3D (ie_len + 2)) { pbuf =3D rtw_get_ie(pbuf, WLAN_EID_VENDOR_SPECIFIC, &ie_len, (pnetwork-= >ie_length - _BEACON_IE_OFFSET_ - (ie_len + 2))); - if (pbuf && !memcmp(pbuf+2, WMM_PARA_IE, 6)) { - memcpy(pframe, pbuf, ie_len+2); - pframe +=3D (ie_len+2); - pattrib->pktlen +=3D (ie_len+2); + if (pbuf && !memcmp(pbuf + 2, WMM_PARA_IE, 6)) { + memcpy(pframe, pbuf, ie_len + 2); + pframe +=3D (ie_len + 2); + pattrib->pktlen +=3D (ie_len + 2); =20 break; } @@ -3024,9 +3024,9 @@ static int _issue_nulldata(struct adapter *padapter, = unsigned char *da, fctrl =3D &(pwlanhdr->frame_control); *(fctrl) =3D 0; =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) SetFrDs(fctrl); - else if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) + else if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) SetToDs(fctrl); =20 if (power_mode) @@ -3168,9 +3168,9 @@ static int _issue_qos_nulldata(struct adapter *padapt= er, unsigned char *da, fctrl =3D &(pwlanhdr->frame_control); *(fctrl) =3D 0; =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) SetFrDs(fctrl); - else if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) + else if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) SetToDs(fctrl); =20 qc =3D (unsigned short *)(pframe + pattrib->hdrlen - 2); @@ -3706,7 +3706,7 @@ unsigned int send_delba(struct adapter *padapter, u8 = initiator, u8 *addr) struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; u16 tid; =20 - if ((pmlmeinfo->state&0x03) !=3D WIFI_FW_AP_STATE) + if ((pmlmeinfo->state & 0x03) !=3D WIFI_FW_AP_STATE) if (!(pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS)) return _SUCCESS; =20 @@ -3717,7 +3717,7 @@ unsigned int send_delba(struct adapter *padapter, u8 = initiator, u8 *addr) if (initiator =3D=3D 0) {/* recipient */ for (tid =3D 0; tid < MAXTID; tid++) { if (psta->recvreorder_ctrl[tid].enable) { - issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, (((tid << 1) | init= iator)&0x1F)); + issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, (((tid << 1) | init= iator) & 0x1F)); psta->recvreorder_ctrl[tid].enable =3D false; psta->recvreorder_ctrl[tid].indicate_seq =3D 0xffff; } @@ -3725,7 +3725,7 @@ unsigned int send_delba(struct adapter *padapter, u8 = initiator, u8 *addr) } else if (initiator =3D=3D 1) {/* originator */ for (tid =3D 0; tid < MAXTID; tid++) { if (psta->htpriv.agg_enable_bitmap & BIT(tid)) { - issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, (((tid << 1) | init= iator)&0x1F)); + issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, (((tid << 1) | init= iator) & 0x1F)); psta->htpriv.agg_enable_bitmap &=3D ~BIT(tid); psta->htpriv.candidate_tid_bitmap &=3D ~BIT(tid); =20 @@ -3752,7 +3752,7 @@ unsigned int send_beacon(struct adapter *padapter) cond_resched(); rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, (u8 *)(&bxmitok)); poll++; - } while ((poll%10) !=3D 0 && false =3D=3D bxmitok && !padapter->bSurpris= eRemoved && !padapter->bDriverStopped); + } while ((poll % 10) !=3D 0 && false =3D=3D bxmitok && !padapter->bSurpr= iseRemoved && !padapter->bDriverStopped); =20 } while (false =3D=3D bxmitok && issue < 100 && !padapter->bSurpriseRemov= ed && !padapter->bDriverStopped); =20 @@ -3965,7 +3965,7 @@ u8 collect_bss_info(struct adapter *padapter, union r= ecv_frame *precv_frame, str =20 p =3D rtw_get_ie(bssid->ies + ie_offset, WLAN_EID_EXT_SUPP_RATES, &len, b= ssid->ie_length - ie_offset); if (p) { - if (len > (NDIS_802_11_LENGTH_RATES_EX-i)) + if (len > (NDIS_802_11_LENGTH_RATES_EX - i)) return _FAIL; =20 memcpy(bssid->supported_rates + i, (p + 2), len); @@ -4058,7 +4058,7 @@ void start_create_ibss(struct adapter *padapter) /* update capability */ caps =3D rtw_get_capability((struct wlan_bssid_ex *)pnetwork); update_capinfo(padapter, caps); - if (caps&WLAN_CAPABILITY_IBSS) {/* adhoc master */ + if (caps & WLAN_CAPABILITY_IBSS) {/* adhoc master */ val8 =3D 0xcf; rtw_hal_set_hwreg(padapter, HW_VAR_SEC_CFG, (u8 *)(&val8)); =20 @@ -4110,7 +4110,7 @@ void start_clnt_join(struct adapter *padapter) /* update capability */ caps =3D rtw_get_capability((struct wlan_bssid_ex *)pnetwork); update_capinfo(padapter, caps); - if (caps&WLAN_CAPABILITY_ESS) { + if (caps & WLAN_CAPABILITY_ESS) { set_msr(padapter, WIFI_FW_STATION_STATE); =20 val8 =3D (pmlmeinfo->auth_algo =3D=3D dot11AuthAlgrthm_8021X) ? 0xcc : 0= xcf; @@ -4134,10 +4134,10 @@ void start_clnt_join(struct adapter *padapter) beacon_timeout =3D decide_wait_for_beacon_timeout(pmlmeinfo->bcn_interva= l); set_link_timer(pmlmeext, beacon_timeout); _set_timer(&padapter->mlmepriv.assoc_timer, - (REAUTH_TO * REAUTH_LIMIT) + (REASSOC_TO*REASSOC_LIMIT) + beacon_timeou= t); + (REAUTH_TO * REAUTH_LIMIT) + (REASSOC_TO * REASSOC_LIMIT) + beacon_time= out); =20 pmlmeinfo->state =3D WIFI_FW_AUTH_NULL | WIFI_FW_STATION_STATE; - } else if (caps&WLAN_CAPABILITY_IBSS) { /* adhoc client */ + } else if (caps & WLAN_CAPABILITY_IBSS) { /* adhoc client */ set_msr(padapter, WIFI_FW_ADHOC_STATE); =20 val8 =3D 0xcf; @@ -4203,7 +4203,7 @@ unsigned int receive_disconnect(struct adapter *padap= ter, unsigned char *MacAddr if (!(!memcmp(MacAddr, get_my_bssid(&pmlmeinfo->network), ETH_ALEN))) return _SUCCESS; =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) { + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) { if (pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) { pmlmeinfo->state =3D WIFI_FW_NULL_STATE; report_del_sta_event(padapter, MacAddr, reason); @@ -4265,7 +4265,7 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid if (fcn <=3D 14) channel =3D fcn + j; /* 2.4 GHz */ else - channel =3D fcn + j*4; /* 5 GHz */ + channel =3D fcn + j * 4; /* 5 GHz */ =20 chplan_ap.Channel[i++] =3D channel; } @@ -4672,7 +4672,7 @@ void update_sta_info(struct adapter *padapter, struct= sta_info *psta) =20 psta->htpriv.ampdu_enable =3D pmlmepriv->htpriv.ampdu_enable; =20 - psta->htpriv.rx_ampdu_min_spacing =3D (pmlmeinfo->HT_caps.u.HT_cap_eleme= nt.AMPDU_para&IEEE80211_HT_CAP_AMPDU_DENSITY)>>2; + psta->htpriv.rx_ampdu_min_spacing =3D (pmlmeinfo->HT_caps.u.HT_cap_eleme= nt.AMPDU_para & IEEE80211_HT_CAP_AMPDU_DENSITY) >> 2; =20 if (support_short_GI(padapter, &(pmlmeinfo->HT_caps), CHANNEL_WIDTH_20)) psta->htpriv.sgi_20m =3D true; @@ -4780,7 +4780,7 @@ void mlmeext_joinbss_event_callback(struct adapter *p= adapter, int join_res) return; } =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_ADHOC_STATE) + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) /* update bc/mc sta_info */ update_bmc_sta(padapter); =20 @@ -4830,7 +4830,7 @@ void mlmeext_joinbss_event_callback(struct adapter *p= adapter, int join_res) join_type =3D 2; rtw_hal_set_hwreg(padapter, HW_VAR_MLME_JOIN, (u8 *)(&join_type)); =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) { + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) { /* correcting TSF */ correct_TSF(padapter, pmlmeext); =20 @@ -4847,7 +4847,7 @@ void mlmeext_sta_add_event_callback(struct adapter *p= adapter, struct sta_info *p struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; u8 join_type; =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_ADHOC_STATE) { + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) { if (pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) { /* adhoc master or sta_c= ount>1 */ =20 /* nothing to do */ @@ -4911,7 +4911,7 @@ void _linked_info_dump(struct adapter *padapter) =20 if (padapter->bLinkInfoDump) { =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) rtw_hal_get_def_var(padapter, HAL_DEF_UNDERCORATEDSMOOTHEDPWDB, &UndecoratedSmoothedPWDB); @@ -5407,9 +5407,9 @@ u8 disconnect_hdl(struct adapter *padapter, unsigned = char *pbuf) u8 val8; =20 if (is_client_associated_to_ap(padapter)) - issue_deauth_ex(padapter, pnetwork->mac_address, WLAN_REASON_DEAUTH_LEAV= ING, param->deauth_timeout_ms/100, 100); + issue_deauth_ex(padapter, pnetwork->mac_address, WLAN_REASON_DEAUTH_LEAV= ING, param->deauth_timeout_ms / 100, 100); =20 - if (((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_ADHOC_STATE) || ((pmlmeinfo->= state&0x03) =3D=3D WIFI_FW_AP_STATE)) { + if (((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) || ((pmlmeinfo= ->state & 0x03) =3D=3D WIFI_FW_AP_STATE)) { /* Stop BCN */ val8 =3D 0; rtw_hal_set_hwreg(padapter, HW_VAR_BCN_FUNC, (u8 *)(&val8)); @@ -5430,7 +5430,7 @@ static int rtw_scan_ch_decision(struct adapter *padap= ter, struct rtw_ieee80211_c struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; =20 /* clear first */ - memset(out, 0, sizeof(struct rtw_ieee80211_channel)*out_num); + memset(out, 0, sizeof(struct rtw_ieee80211_channel) * out_num); =20 /* acquire channels from in */ j =3D 0; @@ -5671,7 +5671,7 @@ u8 add_ba_hdl(struct adapter *padapter, unsigned char= *pbuf) return H2C_SUCCESS; =20 if (((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && (pmlmeinfo->HT_enable)= ) || - ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE)) { + ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE)) { /* pmlmeinfo->ADDBA_retry_count =3D 0; */ /* pmlmeinfo->candidate_tid_bitmap |=3D (0x1 << pparm->tid); */ /* psta->htpriv.candidate_tid_bitmap |=3D BIT(pparm->tid); */ diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index f78194d508df..d0d6efaee2af 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -58,7 +58,7 @@ signed int _rtw_init_recv_priv(struct recv_priv *precvpri= v, struct adapter *pada /* precvpriv->precv_frame_buf =3D precvpriv->pallocated_frame_buf + RXFRA= ME_ALIGN_SZ - */ /* ((SIZE_PTR) (precvpriv->pallocated_frame_buf) &(RXFRAME_ALIGN_SZ-1)); = */ =20 - precvframe =3D (union recv_frame *) precvpriv->precv_frame_buf; + precvframe =3D (union recv_frame *)precvpriv->precv_frame_buf; =20 =20 for (i =3D 0; i < NR_RECVFRAME; i++) { @@ -1492,7 +1492,7 @@ static signed int validate_recv_frame(struct adapter = *adapter, union recv_frame struct rx_pkt_attrib *pattrib =3D &precv_frame->u.hdr.attrib; =20 u8 *ptr =3D precv_frame->u.hdr.rx_data; - u8 ver =3D (unsigned char) (*ptr) & 0x3; + u8 ver =3D (unsigned char)(*ptr) & 0x3; =20 /* add version chk */ if (ver !=3D 0) { @@ -1545,7 +1545,7 @@ static signed int validate_recv_frame(struct adapter = *adapter, union recv_frame rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(bDumpRxPkt)); /* get ether_type */ memcpy(ð_type, ptr + pattrib->hdrlen + pattrib->iv_len + LLC_HEADER_= LENGTH, 2); - eth_type =3D ntohs((unsigned short) eth_type); + eth_type =3D ntohs((unsigned short)eth_type); #endif } break; --=20 2.53.0 From nobody Thu Jun 11 22:58:33 2026 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9C73391517 for ; Mon, 13 Apr 2026 10:15:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075336; cv=none; b=G3QbJMBF1qOG3lGRqxAtd59VpPlf+wx2VuOpG/WWLDA71IgbCzFmMg+42vpm7I/lBkCXaYMut3iDJjX/df8GPgUKanKUCTWgSXuRkgNNJOC4d5103qYYhDpRTKXp5XMOvxrZ5loZgcEfUCyIcag/d84CxGPB4oSqC1kKHgVmNzo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075336; c=relaxed/simple; bh=gWVpfhKsEy/We5bWiDSg5v+Ex0/rV2JOgxXVJBi5apQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IROl1GoP/Nrvhl1Ev/qsMIPyWXdu2lsg0bMHnfsx4UCCcq7Gi6zuxr+Xu06ddosRbUECQNFZCWplR00qt59OLWcyTXBO3/pWkMj1xMPm+2JsFfXCwW2y58nRHDfmO0XXpl4fSntuKU7hYinZNn8EyQfmgeDPS+5qopdFZkC8XDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=WGJGurr1; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="WGJGurr1" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776075327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=36fDgHFPcCGx6/5KWrzkcIgi6sZTk+kiZK+MQMJLnWo=; b=WGJGurr1+u4Akb2j71aDej3Z6GdiLJQxMVcIXhb5uBAjXtBjNu6fOfN2zPGCBEtU46TzF8 Nz0povtdUlOuB8CPMcKXizoyWtD2+2DlFAhfMlRAlUNzv+KHC2V4wGfASuq07s3VHfvLIp HlssGPj5gOsIp9UNEftM5kqATTMLaz4= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Luka Gejak , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [PATCH 02/11] staging: rtl8723bs: hal: fix spacing around operators and casts Date: Mon, 13 Apr 2026 12:14:23 +0200 Message-ID: <20260413101432.158925-3-luka.gejak@linux.dev> In-Reply-To: <20260413101432.158925-1-luka.gejak@linux.dev> References: <20260413101432.158925-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Luka Gejak Fix spaces around operators and casts in the hal directory to adhere to the Linux kernel coding style. This resolves multiple spacing warnings reported by checkpatch.pl. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/HalHWImg8723B_RF.c | 24 +- drivers/staging/rtl8723bs/hal/HalPhyRf.c | 8 +- .../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 150 ++++++------- drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c | 6 +- drivers/staging/rtl8723bs/hal/hal_com.c | 20 +- .../staging/rtl8723bs/hal/hal_com_phycfg.c | 28 +-- drivers/staging/rtl8723bs/hal/hal_pwr_seq.c | 32 +-- drivers/staging/rtl8723bs/hal/hal_sdio.c | 2 +- drivers/staging/rtl8723bs/hal/odm.c | 18 +- .../staging/rtl8723bs/hal/odm_CfoTracking.c | 4 +- drivers/staging/rtl8723bs/hal/odm_DIG.c | 50 ++--- .../rtl8723bs/hal/odm_DynamicBBPowerSaving.c | 8 +- drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 44 ++-- .../rtl8723bs/hal/odm_RegConfig8723B.c | 6 +- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 84 +++---- drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 208 +++++++++--------- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 50 ++--- .../staging/rtl8723bs/hal/rtl8723bs_recv.c | 6 +- 19 files changed, 376 insertions(+), 376 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c b/drivers/sta= ging/rtl8723bs/hal/HalHWImg8723B_RF.c index 0c7d0307b822..fd9b36ac9a38 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c @@ -218,7 +218,7 @@ void ODM_ReadAndConfig_MP_8723B_RadioA(struct dm_odm_t = *pDM_Odm) =20 for (i =3D 0; i < ArrayLen; i +=3D 2) { u32 v1 =3D Array[i]; - u32 v2 =3D Array[i+1]; + u32 v2 =3D Array[i + 1]; =20 /* This (offset, data) pair doesn't care the condition. */ if (v1 < 0x40000000) { @@ -227,7 +227,7 @@ void ODM_ReadAndConfig_MP_8723B_RadioA(struct dm_odm_t = *pDM_Odm) } else { /* This line is the beginning of branch. */ bool bMatched =3D true; - u8 cCond =3D (u8)((v1 & (BIT29|BIT28)) >> 28); + u8 cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); =20 if (cCond =3D=3D COND_ELSE) { /* ELSE, ENDIF */ bMatched =3D true; @@ -247,22 +247,22 @@ void ODM_ReadAndConfig_MP_8723B_RadioA(struct dm_odm_= t *pDM_Odm) * Condition isn't matched. * Discard the following (offset, data) pairs. */ - while (v1 < 0x40000000 && i < ArrayLen-2) + while (v1 < 0x40000000 && i < ArrayLen - 2) READ_NEXT_PAIR(v1, v2, i); =20 i -=3D 2; /* prevent from for-loop +=3D 2 */ } else { /* Configure matched pairs and skip to end of if-else. */ - while (v1 < 0x40000000 && i < ArrayLen-2) { + while (v1 < 0x40000000 && i < ArrayLen - 2) { odm_ConfigRF_RadioA_8723B(pDM_Odm, v1, v2); READ_NEXT_PAIR(v1, v2, i); } =20 /* Keeps reading until ENDIF. */ - cCond =3D (u8)((v1 & (BIT29|BIT28)) >> 28); - while (cCond !=3D COND_ENDIF && i < ArrayLen-2) { + cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); + while (cCond !=3D COND_ENDIF && i < ArrayLen - 2) { READ_NEXT_PAIR(v1, v2, i); - cCond =3D (u8)((v1 & (BIT29|BIT28)) >> 28); + cCond =3D (u8)((v1 & (BIT29 | BIT28)) >> 28); } } } @@ -536,11 +536,11 @@ void ODM_ReadAndConfig_MP_8723B_TXPWR_LMT(struct dm_o= dm_t *pDM_Odm) =20 for (i =3D 0; i < ARRAY_SIZE(Array_MP_8723B_TXPWR_LMT); i +=3D 6) { u8 *regulation =3D Array[i]; - u8 *bandwidth =3D Array[i+1]; - u8 *rate =3D Array[i+2]; - u8 *rfPath =3D Array[i+3]; - u8 *chnl =3D Array[i+4]; - u8 *val =3D Array[i+5]; + u8 *bandwidth =3D Array[i + 1]; + u8 *rate =3D Array[i + 2]; + u8 *rfPath =3D Array[i + 3]; + u8 *chnl =3D Array[i + 4]; + u8 *val =3D Array[i + 5]; =20 odm_ConfigBB_TXPWR_LMT_8723B( pDM_Odm, diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf.c b/drivers/staging/rtl= 8723bs/hal/HalPhyRf.c index 7bef05a9a063..254bfef543b1 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf.c @@ -220,13 +220,13 @@ void ODM_TXPowerTrackingCallback_ThermalMeter(struct = adapter *Adapter) pDM_Odm->RFCalibrateInfo.OFDM_index[p]; =20 /* 4 7.1 Handle boundary conditions of index. */ - if (pDM_Odm->RFCalibrateInfo.OFDM_index[p] > c.SwingTableSize_OFDM-1) - pDM_Odm->RFCalibrateInfo.OFDM_index[p] =3D c.SwingTableSize_OFDM-1; + if (pDM_Odm->RFCalibrateInfo.OFDM_index[p] > c.SwingTableSize_OFDM - 1) + pDM_Odm->RFCalibrateInfo.OFDM_index[p] =3D c.SwingTableSize_OFDM - 1; else if (pDM_Odm->RFCalibrateInfo.OFDM_index[p] < OFDM_min_index) pDM_Odm->RFCalibrateInfo.OFDM_index[p] =3D OFDM_min_index; } - if (pDM_Odm->RFCalibrateInfo.CCK_index > c.SwingTableSize_CCK-1) - pDM_Odm->RFCalibrateInfo.CCK_index =3D c.SwingTableSize_CCK-1; + if (pDM_Odm->RFCalibrateInfo.CCK_index > c.SwingTableSize_CCK - 1) + pDM_Odm->RFCalibrateInfo.CCK_index =3D c.SwingTableSize_CCK - 1; /* else if (pDM_Odm->RFCalibrateInfo.CCK_index < 0) */ /* pDM_Odm->RFCalibrateInfo.CCK_index =3D 0; */ } else { diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.c index 8f6849f2277e..5a08a5e3be63 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -51,20 +51,20 @@ static void setIqkMatrix_8723B( s32 ele_A =3D 0, ele_D, ele_C =3D 0, value32; =20 if (OFDM_index >=3D OFDM_TABLE_SIZE) - OFDM_index =3D OFDM_TABLE_SIZE-1; + OFDM_index =3D OFDM_TABLE_SIZE - 1; =20 - ele_D =3D (OFDMSwingTable_New[OFDM_index] & 0xFFC00000)>>22; + ele_D =3D (OFDMSwingTable_New[OFDM_index] & 0xFFC00000) >> 22; =20 /* new element A =3D element D x X */ if (IqkResult_X !=3D 0) { if ((IqkResult_X & 0x00000200) !=3D 0) /* consider minus */ IqkResult_X =3D IqkResult_X | 0xFFFFFC00; - ele_A =3D ((IqkResult_X * ele_D)>>8)&0x000003FF; + ele_A =3D ((IqkResult_X * ele_D) >> 8) & 0x000003FF; =20 /* new element C =3D element D x Y */ if ((IqkResult_Y & 0x00000200) !=3D 0) IqkResult_Y =3D IqkResult_Y | 0xFFFFFC00; - ele_C =3D ((IqkResult_Y * ele_D)>>8)&0x000003FF; + ele_C =3D ((IqkResult_Y * ele_D) >> 8) & 0x000003FF; =20 /* if (RFPath =3D=3D RF_PATH_A) */ switch (RFPath) { @@ -72,26 +72,26 @@ static void setIqkMatrix_8723B( /* write new elements A, C, D to regC80 and regC94, * element B is always 0 */ - value32 =3D (ele_D<<22)|((ele_C&0x3F)<<16)|ele_A; + value32 =3D (ele_D << 22) | ((ele_C & 0x3F) << 16) | ele_A; PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XATxIQImbalance, bMaskDWord, valu= e32); =20 - value32 =3D (ele_C&0x000003C0)>>6; + value32 =3D (ele_C & 0x000003C0) >> 6; PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XCTxAFE, bMaskH4Bits, value32); =20 - value32 =3D ((IqkResult_X * ele_D)>>7)&0x01; + value32 =3D ((IqkResult_X * ele_D) >> 7) & 0x01; PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_ECCAThreshold, BIT24, value32); break; case RF_PATH_B: /* write new elements A, C, D to regC88 and regC9C, * element B is always 0 */ - value32 =3D (ele_D<<22)|((ele_C&0x3F)<<16)|ele_A; + value32 =3D (ele_D << 22) | ((ele_C & 0x3F) << 16) | ele_A; PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XBTxIQImbalance, bMaskDWord, valu= e32); =20 - value32 =3D (ele_C&0x000003C0)>>6; + value32 =3D (ele_C & 0x000003C0) >> 6; PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XDTxAFE, bMaskH4Bits, value32); =20 - value32 =3D ((IqkResult_X * ele_D)>>7)&0x01; + value32 =3D ((IqkResult_X * ele_D) >> 7) & 0x01; PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_ECCAThreshold, BIT28, value32); =20 break; @@ -217,7 +217,7 @@ void ODM_TxPwrTrackSetPwr_8723B( Final_OFDM_Swing_Index =3D 0; =20 if (Final_CCK_Swing_Index >=3D CCK_TABLE_SIZE) - Final_CCK_Swing_Index =3D CCK_TABLE_SIZE-1; + Final_CCK_Swing_Index =3D CCK_TABLE_SIZE - 1; else if (pDM_Odm->BbSwingIdxCck <=3D 0) Final_CCK_Swing_Index =3D 0; =20 @@ -421,16 +421,16 @@ static u8 phy_PathA_IQK_8723B( =20 =20 /* Allen 20131125 */ - tmp =3D (regE9C & 0x03FF0000)>>16; + tmp =3D (regE9C & 0x03FF0000) >> 16; if ((tmp & 0x200) > 0) tmp =3D 0x400 - tmp; =20 if ( !(regEAC & BIT28) && - (((regE94 & 0x03FF0000)>>16) !=3D 0x142) && - (((regE9C & 0x03FF0000)>>16) !=3D 0x42) && - (((regE94 & 0x03FF0000)>>16) < 0x110) && - (((regE94 & 0x03FF0000)>>16) > 0xf0) && + (((regE94 & 0x03FF0000) >> 16) !=3D 0x142) && + (((regE9C & 0x03FF0000) >> 16) !=3D 0x42) && + (((regE94 & 0x03FF0000) >> 16) < 0x110) && + (((regE94 & 0x03FF0000) >> 16) > 0xf0) && (tmp < 0xf) ) result |=3D 0x01; @@ -520,23 +520,23 @@ static u8 phy_PathA_RxIQK8723B( regE9C =3D PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_After_IQK_A, bMaskD= Word); =20 /* Allen 20131125 */ - tmp =3D (regE9C & 0x03FF0000)>>16; + tmp =3D (regE9C & 0x03FF0000) >> 16; if ((tmp & 0x200) > 0) tmp =3D 0x400 - tmp; =20 if ( !(regEAC & BIT28) && - (((regE94 & 0x03FF0000)>>16) !=3D 0x142) && - (((regE9C & 0x03FF0000)>>16) !=3D 0x42) && - (((regE94 & 0x03FF0000)>>16) < 0x110) && - (((regE94 & 0x03FF0000)>>16) > 0xf0) && + (((regE94 & 0x03FF0000) >> 16) !=3D 0x142) && + (((regE9C & 0x03FF0000) >> 16) !=3D 0x42) && + (((regE94 & 0x03FF0000) >> 16) < 0x110) && + (((regE94 & 0x03FF0000) >> 16) > 0xf0) && (tmp < 0xf) ) result |=3D 0x01; else /* if Tx not OK, ignore Rx */ return result; =20 - u4tmp =3D 0x80007C00 | (regE94&0x3FF0000) | ((regE9C&0x3FF0000) >> 16); + u4tmp =3D 0x80007C00 | (regE94 & 0x3FF0000) | ((regE9C & 0x3FF0000) >> 16= ); PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK, bMaskDWord, u4tmp); =20 /* modify RXIQK mode table */ @@ -611,16 +611,16 @@ static u8 phy_PathA_RxIQK8723B( PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xdf, bRFRegOffsetMask, 0x780); =20 /* Allen 20131125 */ - tmp =3D (regEAC & 0x03FF0000)>>16; + tmp =3D (regEAC & 0x03FF0000) >> 16; if ((tmp & 0x200) > 0) tmp =3D 0x400 - tmp; =20 if ( !(regEAC & BIT27) && /* if Tx is OK, check whether Rx is OK */ - (((regEA4 & 0x03FF0000)>>16) !=3D 0x132) && - (((regEAC & 0x03FF0000)>>16) !=3D 0x36) && - (((regEA4 & 0x03FF0000)>>16) < 0x110) && - (((regEA4 & 0x03FF0000)>>16) > 0xf0) && + (((regEA4 & 0x03FF0000) >> 16) !=3D 0x132) && + (((regEAC & 0x03FF0000) >> 16) !=3D 0x36) && + (((regEA4 & 0x03FF0000) >> 16) < 0x110) && + (((regEA4 & 0x03FF0000) >> 16) > 0xf0) && (tmp < 0xf) ) result |=3D 0x02; @@ -704,16 +704,16 @@ static u8 phy_PathB_IQK_8723B(struct adapter *padapte= r) regE9C =3D PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_After_IQK_A, bMaskD= Word); =20 /* Allen 20131125 */ - tmp =3D (regE9C & 0x03FF0000)>>16; + tmp =3D (regE9C & 0x03FF0000) >> 16; if ((tmp & 0x200) > 0) tmp =3D 0x400 - tmp; =20 if ( !(regEAC & BIT28) && - (((regE94 & 0x03FF0000)>>16) !=3D 0x142) && - (((regE9C & 0x03FF0000)>>16) !=3D 0x42) && - (((regE94 & 0x03FF0000)>>16) < 0x110) && - (((regE94 & 0x03FF0000)>>16) > 0xf0) && + (((regE94 & 0x03FF0000) >> 16) !=3D 0x142) && + (((regE9C & 0x03FF0000) >> 16) !=3D 0x42) && + (((regE94 & 0x03FF0000) >> 16) < 0x110) && + (((regE94 & 0x03FF0000) >> 16) > 0xf0) && (tmp < 0xf) ) result |=3D 0x01; @@ -799,23 +799,23 @@ static u8 phy_PathB_RxIQK8723B(struct adapter *padapt= er, bool configPathB) regE9C =3D PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_After_IQK_A, bMaskD= Word); =20 /* Allen 20131125 */ - tmp =3D (regE9C & 0x03FF0000)>>16; + tmp =3D (regE9C & 0x03FF0000) >> 16; if ((tmp & 0x200) > 0) tmp =3D 0x400 - tmp; =20 if ( !(regEAC & BIT28) && - (((regE94 & 0x03FF0000)>>16) !=3D 0x142) && - (((regE9C & 0x03FF0000)>>16) !=3D 0x42) && - (((regE94 & 0x03FF0000)>>16) < 0x110) && - (((regE94 & 0x03FF0000)>>16) > 0xf0) && + (((regE94 & 0x03FF0000) >> 16) !=3D 0x142) && + (((regE9C & 0x03FF0000) >> 16) !=3D 0x42) && + (((regE94 & 0x03FF0000) >> 16) < 0x110) && + (((regE94 & 0x03FF0000) >> 16) > 0xf0) && (tmp < 0xf) ) result |=3D 0x01; else /* if Tx not OK, ignore Rx */ return result; =20 - u4tmp =3D 0x80007C00 | (regE94&0x3FF0000) | ((regE9C&0x3FF0000) >> 16); + u4tmp =3D 0x80007C00 | (regE94 & 0x3FF0000) | ((regE9C & 0x3FF0000) >> 1= 6); PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK, bMaskDWord, u4tmp); =20 /* modify RXIQK mode table */ @@ -891,16 +891,16 @@ static u8 phy_PathB_RxIQK8723B(struct adapter *padapt= er, bool configPathB) =20 =20 /* Allen 20131125 */ - tmp =3D (regEAC & 0x03FF0000)>>16; + tmp =3D (regEAC & 0x03FF0000) >> 16; if ((tmp & 0x200) > 0) tmp =3D 0x400 - tmp; =20 if ( !(regEAC & BIT27) && /* if Tx is OK, check whether Rx is OK */ - (((regEA4 & 0x03FF0000)>>16) !=3D 0x132) && - (((regEAC & 0x03FF0000)>>16) !=3D 0x36) && - (((regEA4 & 0x03FF0000)>>16) < 0x110) && - (((regEA4 & 0x03FF0000)>>16) > 0xf0) && + (((regEA4 & 0x03FF0000) >> 16) !=3D 0x132) && + (((regEAC & 0x03FF0000) >> 16) !=3D 0x36) && + (((regEA4 & 0x03FF0000) >> 16) < 0x110) && + (((regEA4 & 0x03FF0000) >> 16) > 0xf0) && (tmp < 0xf) ) result |=3D 0x02; @@ -935,7 +935,7 @@ static void _PHY_PathAFillIQKMatrix8723B( TX0_A =3D (X * Oldval_0) >> 8; PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XATxIQImbalance, 0x3FF, TX0_A); =20 - PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_ECCAThreshold, BIT(31), ((X*Oldval= _0>>7) & 0x1)); + PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_ECCAThreshold, BIT(31), ((X * Oldv= al_0 >> 7) & 0x1)); =20 Y =3D result[final_candidate][1]; if ((Y & 0x00000200) !=3D 0) @@ -943,15 +943,15 @@ static void _PHY_PathAFillIQKMatrix8723B( =20 /* 2 Tx IQC */ TX0_C =3D (Y * Oldval_0) >> 8; - PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XCTxAFE, 0xF0000000, ((TX0_C&0x3C0= )>>6)); + PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XCTxAFE, 0xF0000000, ((TX0_C & 0x3= C0) >> 6)); pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC94][KEY] =3D rOFDM0_XCTxAF= E; pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC94][VAL] =3D PHY_QueryBBRe= g(pDM_Odm->Adapter, rOFDM0_XCTxAFE, bMaskDWord); =20 - PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XATxIQImbalance, 0x003F0000, (TX0_= C&0x3F)); + PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XATxIQImbalance, 0x003F0000, (TX0_= C & 0x3F)); pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC80][KEY] =3D rOFDM0_XATxIQ= Imbalance; pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC80][VAL] =3D PHY_QueryBBRe= g(pDM_Odm->Adapter, rOFDM0_XATxIQImbalance, bMaskDWord); =20 - PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_ECCAThreshold, BIT(29), ((Y*Oldval= _0>>7) & 0x1)); + PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_ECCAThreshold, BIT(29), ((Y * Oldv= al_0 >> 7) & 0x1)); pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC4C][KEY] =3D rOFDM0_ECCATh= reshold; pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC4C][VAL] =3D PHY_QueryBBRe= g(pDM_Odm->Adapter, rOFDM0_ECCAThreshold, bMaskDWord); =20 @@ -1010,7 +1010,7 @@ static void _PHY_PathBFillIQKMatrix8723B( =20 PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XBTxIQImbalance, 0x3FF, TX1_A); =20 - PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_ECCAThreshold, BIT(27), ((X*Oldval= _1>>7) & 0x1)); + PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_ECCAThreshold, BIT(27), ((X * Oldv= al_1 >> 7) & 0x1)); =20 Y =3D result[final_candidate][5]; if ((Y & 0x00000200) !=3D 0) @@ -1019,17 +1019,17 @@ static void _PHY_PathBFillIQKMatrix8723B( TX1_C =3D (Y * Oldval_1) >> 8; =20 /* 2 Tx IQC */ - PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XDTxAFE, 0xF0000000, ((TX1_C&0x3C0= )>>6)); + PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XDTxAFE, 0xF0000000, ((TX1_C & 0x3= C0) >> 6)); /* pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC9C][KEY] =3D rOFDM0_XDT= xAFE; */ /* pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC9C][VAL] =3D PHY_QueryB= BReg(pDM_Odm->Adapter, rOFDM0_XDTxAFE, bMaskDWord); */ pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC94][KEY] =3D rOFDM0_XCTxAF= E; pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC94][VAL] =3D PHY_QueryBBRe= g(pDM_Odm->Adapter, rOFDM0_XDTxAFE, bMaskDWord); =20 - PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XBTxIQImbalance, 0x003F0000, (TX1_= C&0x3F)); + PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XBTxIQImbalance, 0x003F0000, (TX1_= C & 0x3F)); pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC80][KEY] =3D rOFDM0_XATxIQ= Imbalance; pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC80][VAL] =3D PHY_QueryBBRe= g(pDM_Odm->Adapter, rOFDM0_XBTxIQImbalance, bMaskDWord); =20 - PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_ECCAThreshold, BIT(25), ((Y*Oldval= _1>>7) & 0x1)); + PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_ECCAThreshold, BIT(25), ((Y * Oldv= al_1 >> 7) & 0x1)); pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC4C][KEY] =3D rOFDM0_ECCATh= reshold; pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC4C][VAL] =3D PHY_QueryBBRe= g(pDM_Odm->Adapter, rOFDM0_ECCAThreshold, bMaskDWord); =20 @@ -1053,7 +1053,7 @@ static void _PHY_PathBFillIQKMatrix8723B( reg =3D (result[final_candidate][7] >> 6) & 0xF; /* PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_AGCRSSITable, 0x0000F000, reg);= */ pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xCA0][KEY] =3D rOFDM0_RxIQEx= tAnta; - pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xCA0][VAL] =3D (reg << 28)|(= PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_RxIQExtAnta, bMaskDWord)&0x0fffffff= ); + pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xCA0][VAL] =3D (reg << 28) |= (PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_RxIQExtAnta, bMaskDWord) & 0x0fff= ffff); } } =20 @@ -1195,9 +1195,9 @@ static void _PHY_MACSettingCalibration8723B( rtw_write8(pDM_Odm->Adapter, MACReg[i], 0x3F); =20 for (i =3D 1 ; i < (IQK_MAC_REG_NUM - 1); i++) { - rtw_write8(pDM_Odm->Adapter, MACReg[i], (u8)(MACBackup[i]&(~BIT3))); + rtw_write8(pDM_Odm->Adapter, MACReg[i], (u8)(MACBackup[i] & (~BIT3))); } - rtw_write8(pDM_Odm->Adapter, MACReg[i], (u8)(MACBackup[i]&(~BIT5))); + rtw_write8(pDM_Odm->Adapter, MACReg[i], (u8)(MACBackup[i] & (~BIT5))); =20 } =20 @@ -1237,21 +1237,21 @@ static bool phy_SimularityCompare_8723B( =20 if (diff > MAX_TOLERANCE) { if ((i =3D=3D 2 || i =3D=3D 6) && !SimularityBitMap) { - if (result[c1][i]+result[c1][i+1] =3D=3D 0) - final_candidate[(i/4)] =3D c2; - else if (result[c2][i]+result[c2][i+1] =3D=3D 0) - final_candidate[(i/4)] =3D c1; + if (result[c1][i] + result[c1][i + 1] =3D=3D 0) + final_candidate[(i / 4)] =3D c2; + else if (result[c2][i] + result[c2][i + 1] =3D=3D 0) + final_candidate[(i / 4)] =3D c1; else - SimularityBitMap =3D SimularityBitMap|(1<Adapter, rTx_Power_Before= _IQK_A, bMaskDWord)&0x3FF0000)>>16; */ /* result[t][1] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_After_= IQK_A, bMaskDWord)&0x3FF0000)>>16; */ - result[t][2] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQ= K_A_2, bMaskDWord)&0x3FF0000)>>16; - result[t][3] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK= _A_2, bMaskDWord)&0x3FF0000)>>16; + result[t][2] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQ= K_A_2, bMaskDWord) & 0x3FF0000) >> 16; + result[t][3] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK= _A_2, bMaskDWord) & 0x3FF0000) >> 16; break; } } @@ -1429,8 +1429,8 @@ static void phy_IQCalibrate_8723B( PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_IQK, bMaskH3Bytes, 0x000000); pDM_Odm->RFCalibrateInfo.TxLOK[RF_PATH_B] =3D PHY_QueryRFReg(pDM_Odm->= Adapter, RF_PATH_B, 0x8, bRFRegOffsetMask); =20 - result[t][4] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_Before_IQ= K_A, bMaskDWord)&0x3FF0000)>>16; - result[t][5] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_After_IQK= _A, bMaskDWord)&0x3FF0000)>>16; + result[t][4] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_Before_IQ= K_A, bMaskDWord) & 0x3FF0000) >> 16; + result[t][5] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_After_IQK= _A, bMaskDWord) & 0x3FF0000) >> 16; break; } } @@ -1441,8 +1441,8 @@ static void phy_IQCalibrate_8723B( if (PathBOK =3D=3D 0x03) { /* result[t][0] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_Before= _IQK_A, bMaskDWord)&0x3FF0000)>>16; */ /* result[t][1] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_After_= IQK_A, bMaskDWord)&0x3FF0000)>>16; */ - result[t][6] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQ= K_A_2, bMaskDWord)&0x3FF0000)>>16; - result[t][7] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK= _A_2, bMaskDWord)&0x3FF0000)>>16; + result[t][6] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQ= K_A_2, bMaskDWord) & 0x3FF0000) >> 16; + result[t][7] =3D (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK= _A_2, bMaskDWord) & 0x3FF0000) >> 16; break; } } @@ -1493,12 +1493,12 @@ static void phy_LCCalibrate_8723B(struct dm_odm_t *= pDM_Odm, bool is2T) /* Check continuous TX and Packet TX */ tmpReg =3D rtw_read8(pDM_Odm->Adapter, 0xd03); =20 - if ((tmpReg&0x70) !=3D 0) /* Deal with contisuous TX case */ - rtw_write8(pDM_Odm->Adapter, 0xd03, tmpReg&0x8F); /* disable all continu= ous TX */ + if ((tmpReg & 0x70) !=3D 0) /* Deal with contisuous TX case */ + rtw_write8(pDM_Odm->Adapter, 0xd03, tmpReg & 0x8F); /* disable all conti= nuous TX */ else /* Deal with Packet TX case */ rtw_write8(pDM_Odm->Adapter, REG_TXPAUSE, 0xFF); /* block all queues */ =20 - if ((tmpReg&0x70) !=3D 0) { + if ((tmpReg & 0x70) !=3D 0) { /* 1. Read original RF mode */ /* Path-A */ RF_Amode =3D PHY_QueryRFReg(padapter, RF_PATH_A, RF_AC, bMask12Bits); @@ -1509,11 +1509,11 @@ static void phy_LCCalibrate_8723B(struct dm_odm_t *= pDM_Odm, bool is2T) =20 /* 2. Set RF mode =3D standby mode */ /* Path-A */ - PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_AC, bMask12Bits, (RF_Amode&= 0x8FFFF)|0x10000); + PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_AC, bMask12Bits, (RF_Amode = & 0x8FFFF) | 0x10000); =20 /* Path-B */ if (is2T) - PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_B, RF_AC, bMask12Bits, (RF_Bmode= &0x8FFFF)|0x10000); + PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_B, RF_AC, bMask12Bits, (RF_Bmode= & 0x8FFFF) | 0x10000); } =20 /* 3. Read RF reg18 */ @@ -1521,7 +1521,7 @@ static void phy_LCCalibrate_8723B(struct dm_odm_t *pD= M_Odm, bool is2T) =20 /* 4. Set LC calibration begin bit15 */ PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xB0, bRFRegOffsetMask, 0xDFBE0= ); /* LDO ON */ - PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_CHNLBW, bMask12Bits, LC_Cal|= 0x08000); + PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_CHNLBW, bMask12Bits, LC_Cal = | 0x08000); =20 mdelay(100); =20 @@ -1533,7 +1533,7 @@ static void phy_LCCalibrate_8723B(struct dm_odm_t *pD= M_Odm, bool is2T) } =20 /* Restore original situation */ - if ((tmpReg&0x70) !=3D 0) { /* Deal with contisuous TX case */ + if ((tmpReg & 0x70) !=3D 0) { /* Deal with contisuous TX case */ /* Path-A */ rtw_write8(pDM_Odm->Adapter, 0xd03, tmpReg); PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_AC, bMask12Bits, RF_Amode); diff --git a/drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c b/drivers/staging= /rtl8723bs/hal/HalPwrSeqCmd.c index 86404b5e6c52..3069bbd52379 100644 --- a/drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c +++ b/drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c @@ -88,7 +88,7 @@ u8 HalPwrSeqCmdParsing( value &=3D (~(GET_PWR_CFG_MASK(PwrCfgCmd))); value |=3D ( GET_PWR_CFG_VALUE(PwrCfgCmd) - &GET_PWR_CFG_MASK(PwrCfgCmd) + & GET_PWR_CFG_MASK(PwrCfgCmd) ); =20 /* Write the value back to system register */ @@ -106,7 +106,7 @@ u8 HalPwrSeqCmdParsing( else value =3D rtw_read8(padapter, offset); =20 - value =3D value&GET_PWR_CFG_MASK(PwrCfgCmd); + value =3D value & GET_PWR_CFG_MASK(PwrCfgCmd); if ( value =3D=3D (GET_PWR_CFG_VALUE(PwrCfgCmd) & GET_PWR_CFG_MASK(PwrCfgCmd)) @@ -126,7 +126,7 @@ u8 HalPwrSeqCmdParsing( if (GET_PWR_CFG_VALUE(PwrCfgCmd) =3D=3D PWRSEQ_DELAY_US) udelay(GET_PWR_CFG_OFFSET(PwrCfgCmd)); else - udelay(GET_PWR_CFG_OFFSET(PwrCfgCmd)*1000); + udelay(GET_PWR_CFG_OFFSET(PwrCfgCmd) * 1000); break; =20 case PWR_CMD_END: diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 728a2171fbcb..0444650798f2 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -552,7 +552,7 @@ void rtw_hal_update_sta_rate_mask(struct adapter *padap= ter, struct sta_info *pst /* b/g mode ra_bitmap */ for (i =3D 0; i < sizeof(psta->bssrateset); i++) { if (psta->bssrateset[i]) - tx_ra_bitmap |=3D rtw_get_bit_value_from_ieee_value(psta->bssrateset[i]= &0x7f); + tx_ra_bitmap |=3D rtw_get_bit_value_from_ieee_value(psta->bssrateset[i]= & 0x7f); } =20 /* n mode ra_bitmap */ @@ -560,13 +560,13 @@ void rtw_hal_update_sta_rate_mask(struct adapter *pad= apter, struct sta_info *pst limit =3D 8; /* 1R */ =20 for (i =3D 0; i < limit; i++) { - if (psta->htpriv.ht_cap.mcs.rx_mask[i/8] & BIT(i%8)) - tx_ra_bitmap |=3D BIT(i+12); + if (psta->htpriv.ht_cap.mcs.rx_mask[i / 8] & BIT(i % 8)) + tx_ra_bitmap |=3D BIT(i + 12); } } =20 psta->ra_mask =3D tx_ra_bitmap; - psta->init_rate =3D get_highest_rate_idx(tx_ra_bitmap)&0x3f; + psta->init_rate =3D get_highest_rate_idx(tx_ra_bitmap) & 0x3f; } =20 void SetHwReg(struct adapter *adapter, u8 variable, u8 *val) @@ -583,7 +583,7 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 = *val) u16 reg_scr; =20 reg_scr =3D rtw_read16(adapter, REG_SECCFG); - rtw_write16(adapter, REG_SECCFG, reg_scr|SCR_CHK_KEYID|SCR_RxDecEnable|S= CR_TxEncEnable); + rtw_write16(adapter, REG_SECCFG, reg_scr | SCR_CHK_KEYID | SCR_RxDecEnab= le | SCR_TxEncEnable); } break; case HW_VAR_SEC_DK_CFG: @@ -594,9 +594,9 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 = *val) if (val) { /* Enable default key related setting */ reg_scr |=3D SCR_TXBCUSEDK; if (sec->dot11AuthAlgrthm !=3D dot11AuthAlgrthm_8021X) - reg_scr |=3D (SCR_RxUseDK|SCR_TxUseDK); + reg_scr |=3D (SCR_RxUseDK | SCR_TxUseDK); } else /* Disable default key related setting */ - reg_scr &=3D ~(SCR_RXBCUSEDK|SCR_TXBCUSEDK|SCR_RxUseDK|SCR_TxUseDK); + reg_scr &=3D ~(SCR_RXBCUSEDK | SCR_TXBCUSEDK | SCR_RxUseDK | SCR_TxUseD= K); =20 rtw_write8(adapter, REG_SECCFG, reg_scr); } @@ -773,7 +773,7 @@ bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8 = *pInt) void rtw_hal_check_rxfifo_full(struct adapter *adapter) { /* switch counter to RX fifo */ - rtw_write8(adapter, REG_RXERR_RPT+3, rtw_read8(adapter, REG_RXERR_RPT+3)|= 0xf0); + rtw_write8(adapter, REG_RXERR_RPT + 3, rtw_read8(adapter, REG_RXERR_RPT += 3) | 0xf0); } =20 static u32 Array_kfreemap[] =3D { @@ -805,13 +805,13 @@ void rtw_bb_rf_gain_offset(struct adapter *padapter) =20 for (i =3D 0; i < ARRAY_SIZE(Array_kfreemap); i +=3D 2) { v1 =3D Array[i]; - v2 =3D Array[i+1]; + v2 =3D Array[i + 1]; if (v1 =3D=3D padapter->eeprompriv.EEPROMRFGainVal) { target =3D v2; break; } } - PHY_SetRFReg(padapter, RF_PATH_A, REG_RF_BB_GAIN_OFFSET, BIT18|BIT17|BI= T16|BIT15, target); + PHY_SetRFReg(padapter, RF_PATH_A, REG_RF_BB_GAIN_OFFSET, BIT18 | BIT17 = | BIT16 | BIT15, target); =20 rtw_hal_read_rfreg(padapter, RF_PATH_A, 0x7f, 0xffffffff); } diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index bdd595a99b98..a67a49288f4a 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -152,7 +152,7 @@ PHY_GetRateValuesOfTxPowerByRate( RateIndex[2] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_12M); RateIndex[3] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_18M); for (i =3D 0; i < 4; ++i) { - PwrByRateVal[i] =3D (s8) ((((Value >> (i * 8 + 4)) & 0xF)) * 10 + + PwrByRateVal[i] =3D (s8)((((Value >> (i * 8 + 4)) & 0xF)) * 10 + ((Value >> (i * 8)) & 0xF)); } *RateNum =3D 4; @@ -165,7 +165,7 @@ PHY_GetRateValuesOfTxPowerByRate( RateIndex[2] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_48M); RateIndex[3] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_54M); for (i =3D 0; i < 4; ++i) { - PwrByRateVal[i] =3D (s8) ((((Value >> (i * 8 + 4)) & 0xF)) * 10 + + PwrByRateVal[i] =3D (s8)((((Value >> (i * 8 + 4)) & 0xF)) * 10 + ((Value >> (i * 8)) & 0xF)); } *RateNum =3D 4; @@ -173,7 +173,7 @@ PHY_GetRateValuesOfTxPowerByRate( =20 case rTxAGC_A_CCK1_Mcs32: RateIndex[0] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_1M); - PwrByRateVal[0] =3D (s8) ((((Value >> (8 + 4)) & 0xF)) * 10 + + PwrByRateVal[0] =3D (s8)((((Value >> (8 + 4)) & 0xF)) * 10 + ((Value >> 8) & 0xF)); *RateNum =3D 1; break; @@ -184,13 +184,13 @@ PHY_GetRateValuesOfTxPowerByRate( RateIndex[1] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_5_5M); RateIndex[2] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_11M); for (i =3D 1; i < 4; ++i) { - PwrByRateVal[i - 1] =3D (s8) ((((Value >> (i * 8 + 4)) & 0xF)) * 10 + + PwrByRateVal[i - 1] =3D (s8)((((Value >> (i * 8 + 4)) & 0xF)) * 10 + ((Value >> (i * 8)) & 0xF)); } *RateNum =3D 3; } else if (BitMask =3D=3D 0x000000ff) { RateIndex[0] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_11M); - PwrByRateVal[0] =3D (s8) ((((Value >> 4) & 0xF)) * 10 + (Value & 0xF)); + PwrByRateVal[0] =3D (s8)((((Value >> 4) & 0xF)) * 10 + (Value & 0xF)); *RateNum =3D 1; } break; @@ -202,7 +202,7 @@ PHY_GetRateValuesOfTxPowerByRate( RateIndex[2] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_MCS2); RateIndex[3] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_MCS3); for (i =3D 0; i < 4; ++i) { - PwrByRateVal[i] =3D (s8) ((((Value >> (i * 8 + 4)) & 0xF)) * 10 + + PwrByRateVal[i] =3D (s8)((((Value >> (i * 8 + 4)) & 0xF)) * 10 + ((Value >> (i * 8)) & 0xF)); } *RateNum =3D 4; @@ -215,7 +215,7 @@ PHY_GetRateValuesOfTxPowerByRate( RateIndex[2] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_MCS6); RateIndex[3] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_MCS7); for (i =3D 0; i < 4; ++i) { - PwrByRateVal[i] =3D (s8) ((((Value >> (i * 8 + 4)) & 0xF)) * 10 + + PwrByRateVal[i] =3D (s8)((((Value >> (i * 8 + 4)) & 0xF)) * 10 + ((Value >> (i * 8)) & 0xF)); } *RateNum =3D 4; @@ -226,7 +226,7 @@ PHY_GetRateValuesOfTxPowerByRate( RateIndex[1] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_2M); RateIndex[2] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_5_5M); for (i =3D 1; i < 4; ++i) { - PwrByRateVal[i - 1] =3D (s8) ((((Value >> (i * 8 + 4)) & 0xF)) * 10 + + PwrByRateVal[i - 1] =3D (s8)((((Value >> (i * 8 + 4)) & 0xF)) * 10 + ((Value >> (i * 8)) & 0xF)); } *RateNum =3D 3; @@ -241,7 +241,7 @@ PHY_GetRateValuesOfTxPowerByRate( RateIndex[2] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_5_5M); RateIndex[3] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_11M); for (i =3D 0; i < 4; ++i) { - PwrByRateVal[i] =3D (s8) ((((Value >> (i * 8 + 4)) & 0xF)) * 10 + + PwrByRateVal[i] =3D (s8)((((Value >> (i * 8 + 4)) & 0xF)) * 10 + ((Value >> (i * 8)) & 0xF)); } *RateNum =3D 4; @@ -256,7 +256,7 @@ PHY_GetRateValuesOfTxPowerByRate( RateIndex[2] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_12M); RateIndex[3] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_18M); for (i =3D 0; i < 4; ++i) { - PwrByRateVal[i] =3D (s8) ((((Value >> (i * 8 + 4)) & 0xF)) * 10 + + PwrByRateVal[i] =3D (s8)((((Value >> (i * 8 + 4)) & 0xF)) * 10 + ((Value >> (i * 8)) & 0xF)); } *RateNum =3D 4; @@ -271,7 +271,7 @@ PHY_GetRateValuesOfTxPowerByRate( RateIndex[2] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_48M); RateIndex[3] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_54M); for (i =3D 0; i < 4; ++i) { - PwrByRateVal[i] =3D (s8) ((((Value >> (i * 8 + 4)) & 0xF)) * 10 + + PwrByRateVal[i] =3D (s8)((((Value >> (i * 8 + 4)) & 0xF)) * 10 + ((Value >> (i * 8)) & 0xF)); } *RateNum =3D 4; @@ -286,7 +286,7 @@ PHY_GetRateValuesOfTxPowerByRate( RateIndex[2] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_MCS2); RateIndex[3] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_MCS3); for (i =3D 0; i < 4; ++i) { - PwrByRateVal[i] =3D (s8) ((((Value >> (i * 8 + 4)) & 0xF)) * 10 + + PwrByRateVal[i] =3D (s8)((((Value >> (i * 8 + 4)) & 0xF)) * 10 + ((Value >> (i * 8)) & 0xF)); } *RateNum =3D 4; @@ -301,7 +301,7 @@ PHY_GetRateValuesOfTxPowerByRate( RateIndex[2] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_MCS6); RateIndex[3] =3D PHY_GetRateIndexOfTxPowerByRate(MGN_MCS7); for (i =3D 0; i < 4; ++i) { - PwrByRateVal[i] =3D (s8) ((((Value >> (i * 8 + 4)) & 0xF)) * 10 + + PwrByRateVal[i] =3D (s8)((((Value >> (i * 8 + 4)) & 0xF)) * 10 + ((Value >> (i * 8)) & 0xF)); } *RateNum =3D 4; @@ -459,7 +459,7 @@ u8 PHY_GetTxPowerIndexBase( { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); u8 txPower =3D 0; - u8 chnlIdx =3D (Channel-1); + u8 chnlIdx =3D (Channel - 1); =20 if (HAL_IsLegalChannel(padapter, Channel) =3D=3D false) chnlIdx =3D 0; diff --git a/drivers/staging/rtl8723bs/hal/hal_pwr_seq.c b/drivers/staging/= rtl8723bs/hal/hal_pwr_seq.c index 2438931ca51b..87a8f1a65bbb 100644 --- a/drivers/staging/rtl8723bs/hal/hal_pwr_seq.c +++ b/drivers/staging/rtl8723bs/hal/hal_pwr_seq.c @@ -22,7 +22,7 @@ Major Change History: /* drivers should parse below arrays and do the corresponding actions */ /* 3 Power on Array */ struct wlan_pwr_cfg rtl8723B_power_on_flow[ - RTL8723B_TRANS_CARDEMU_TO_ACT_STEPS+ + RTL8723B_TRANS_CARDEMU_TO_ACT_STEPS + RTL8723B_TRANS_END_STEPS ] =3D { RTL8723B_TRANS_CARDEMU_TO_ACT @@ -31,7 +31,7 @@ struct wlan_pwr_cfg rtl8723B_power_on_flow[ =20 /* 3Radio off GPIO Array */ struct wlan_pwr_cfg rtl8723B_radio_off_flow[ - RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+ + RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS + RTL8723B_TRANS_END_STEPS ] =3D { RTL8723B_TRANS_ACT_TO_CARDEMU @@ -40,8 +40,8 @@ struct wlan_pwr_cfg rtl8723B_radio_off_flow[ =20 /* 3Card Disable Array */ struct wlan_pwr_cfg rtl8723B_card_disable_flow[ - RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+ - RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS+ + RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS + + RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS + RTL8723B_TRANS_END_STEPS ] =3D { RTL8723B_TRANS_ACT_TO_CARDEMU @@ -51,8 +51,8 @@ struct wlan_pwr_cfg rtl8723B_card_disable_flow[ =20 /* 3 Card Enable Array */ struct wlan_pwr_cfg rtl8723B_card_enable_flow[ - RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+ - RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS+ + RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS + + RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS + RTL8723B_TRANS_END_STEPS ] =3D { RTL8723B_TRANS_CARDDIS_TO_CARDEMU @@ -62,8 +62,8 @@ struct wlan_pwr_cfg rtl8723B_card_enable_flow[ =20 /* 3Suspend Array */ struct wlan_pwr_cfg rtl8723B_suspend_flow[ - RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+ - RTL8723B_TRANS_CARDEMU_TO_SUS_STEPS+ + RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS + + RTL8723B_TRANS_CARDEMU_TO_SUS_STEPS + RTL8723B_TRANS_END_STEPS ] =3D { RTL8723B_TRANS_ACT_TO_CARDEMU @@ -73,8 +73,8 @@ struct wlan_pwr_cfg rtl8723B_suspend_flow[ =20 /* 3 Resume Array */ struct wlan_pwr_cfg rtl8723B_resume_flow[ - RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+ - RTL8723B_TRANS_CARDEMU_TO_SUS_STEPS+ + RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS + + RTL8723B_TRANS_CARDEMU_TO_SUS_STEPS + RTL8723B_TRANS_END_STEPS ] =3D { RTL8723B_TRANS_SUS_TO_CARDEMU @@ -84,8 +84,8 @@ struct wlan_pwr_cfg rtl8723B_resume_flow[ =20 /* 3HWPDN Array */ struct wlan_pwr_cfg rtl8723B_hwpdn_flow[ - RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS+ - RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS+ + RTL8723B_TRANS_ACT_TO_CARDEMU_STEPS + + RTL8723B_TRANS_CARDEMU_TO_PDN_STEPS + RTL8723B_TRANS_END_STEPS ] =3D { RTL8723B_TRANS_ACT_TO_CARDEMU @@ -95,7 +95,7 @@ struct wlan_pwr_cfg rtl8723B_hwpdn_flow[ =20 /* 3 Enter LPS */ struct wlan_pwr_cfg rtl8723B_enter_lps_flow[ - RTL8723B_TRANS_ACT_TO_LPS_STEPS+RTL8723B_TRANS_END_STEPS + RTL8723B_TRANS_ACT_TO_LPS_STEPS + RTL8723B_TRANS_END_STEPS ] =3D { /* FW behavior */ RTL8723B_TRANS_ACT_TO_LPS @@ -104,7 +104,7 @@ struct wlan_pwr_cfg rtl8723B_enter_lps_flow[ =20 /* 3 Leave LPS */ struct wlan_pwr_cfg rtl8723B_leave_lps_flow[ - RTL8723B_TRANS_LPS_TO_ACT_STEPS+RTL8723B_TRANS_END_STEPS + RTL8723B_TRANS_LPS_TO_ACT_STEPS + RTL8723B_TRANS_END_STEPS ] =3D { /* FW behavior */ RTL8723B_TRANS_LPS_TO_ACT @@ -113,7 +113,7 @@ struct wlan_pwr_cfg rtl8723B_leave_lps_flow[ =20 /* 3 Enter SW LPS */ struct wlan_pwr_cfg rtl8723B_enter_swlps_flow[ - RTL8723B_TRANS_ACT_TO_SWLPS_STEPS+RTL8723B_TRANS_END_STEPS + RTL8723B_TRANS_ACT_TO_SWLPS_STEPS + RTL8723B_TRANS_END_STEPS ] =3D { /* SW behavior */ RTL8723B_TRANS_ACT_TO_SWLPS @@ -122,7 +122,7 @@ struct wlan_pwr_cfg rtl8723B_enter_swlps_flow[ =20 /* 3 Leave SW LPS */ struct wlan_pwr_cfg rtl8723B_leave_swlps_flow[ - RTL8723B_TRANS_SWLPS_TO_ACT_STEPS+RTL8723B_TRANS_END_STEPS + RTL8723B_TRANS_SWLPS_TO_ACT_STEPS + RTL8723B_TRANS_END_STEPS ] =3D { /* SW behavior */ RTL8723B_TRANS_SWLPS_TO_ACT diff --git a/drivers/staging/rtl8723bs/hal/hal_sdio.c b/drivers/staging/rtl= 8723bs/hal/hal_sdio.c index 665c85eccbdf..1d29245da231 100644 --- a/drivers/staging/rtl8723bs/hal/hal_sdio.c +++ b/drivers/staging/rtl8723bs/hal/hal_sdio.c @@ -24,7 +24,7 @@ u8 rtw_hal_sdio_query_tx_freepage( { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); =20 - if ((pHalData->SdioTxFIFOFreePage[PageIdx]+pHalData->SdioTxFIFOFreePage[P= UBLIC_QUEUE_IDX]) >=3D (RequiredPageNum)) + if ((pHalData->SdioTxFIFOFreePage[PageIdx] + pHalData->SdioTxFIFOFreePage= [PUBLIC_QUEUE_IDX]) >=3D (RequiredPageNum)) return true; else return false; diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723b= s/hal/odm.c index 3dffa7620768..f33cc282f3b2 100644 --- a/drivers/staging/rtl8723bs/hal/odm.c +++ b/drivers/staging/rtl8723bs/hal/odm.c @@ -131,8 +131,8 @@ u8 CCKSwingTable_Ch14_New[CCK_TABLE_SIZE][8] =3D { =20 static void odm_CommonInfoSelfInit(struct dm_odm_t *pDM_Odm) { - pDM_Odm->bCckHighPower =3D (bool) PHY_QueryBBReg(pDM_Odm->Adapter, ODM_RE= G(CCK_RPT_FORMAT), ODM_BIT(CCK_RPT_FORMAT)); - pDM_Odm->RFPathRxEnable =3D (u8) PHY_QueryBBReg(pDM_Odm->Adapter, ODM_REG= (BB_RX_PATH), ODM_BIT(BB_RX_PATH)); + pDM_Odm->bCckHighPower =3D (bool)PHY_QueryBBReg(pDM_Odm->Adapter, ODM_REG= (CCK_RPT_FORMAT), ODM_BIT(CCK_RPT_FORMAT)); + pDM_Odm->RFPathRxEnable =3D (u8)PHY_QueryBBReg(pDM_Odm->Adapter, ODM_REG(= BB_RX_PATH), ODM_BIT(BB_RX_PATH)); =20 pDM_Odm->TxRate =3D 0xFF; } @@ -145,9 +145,9 @@ static void odm_CommonInfoSelfUpdate(struct dm_odm_t *p= DM_Odm) =20 if (*(pDM_Odm->pBandWidth) =3D=3D ODM_BW40M) { if (*(pDM_Odm->pSecChOffset) =3D=3D 1) - pDM_Odm->ControlChannel =3D *(pDM_Odm->pChannel)-2; + pDM_Odm->ControlChannel =3D *(pDM_Odm->pChannel) - 2; else if (*(pDM_Odm->pSecChOffset) =3D=3D 2) - pDM_Odm->ControlChannel =3D *(pDM_Odm->pChannel)+2; + pDM_Odm->ControlChannel =3D *(pDM_Odm->pChannel) + 2; } else pDM_Odm->ControlChannel =3D *(pDM_Odm->pChannel); =20 @@ -219,7 +219,7 @@ u32 ODM_Get_Rate_Bitmap( rate_bitmap =3D 0x00000ff0; break; =20 - case (ODM_WM_B|ODM_WM_G): + case (ODM_WM_B | ODM_WM_G): if (rssi_level =3D=3D DM_RATR_STA_HIGH) rate_bitmap =3D 0x00000f00; else if (rssi_level =3D=3D DM_RATR_STA_MIDDLE) @@ -228,9 +228,9 @@ u32 ODM_Get_Rate_Bitmap( rate_bitmap =3D 0x00000ff5; break; =20 - case (ODM_WM_B|ODM_WM_G|ODM_WM_N24G): - case (ODM_WM_B|ODM_WM_N24G): - case (ODM_WM_G|ODM_WM_N24G): + case (ODM_WM_B | ODM_WM_G | ODM_WM_N24G): + case (ODM_WM_B | ODM_WM_N24G): + case (ODM_WM_G | ODM_WM_N24G): if (rssi_level =3D=3D DM_RATR_STA_HIGH) rate_bitmap =3D 0x000f0000; else if (rssi_level =3D=3D DM_RATR_STA_MIDDLE) @@ -425,7 +425,7 @@ static void odm_RSSIMonitorCheckCE(struct dm_odm_t *pDM= _Odm) tmpEntryMaxPWDB =3D psta->rssi_stat.UndecoratedSmoothedPWDB; =20 if (psta->rssi_stat.UndecoratedSmoothedPWDB !=3D (-1)) - PWDB_rssi[sta_cnt++] =3D (psta->mac_id | (psta->rssi_stat.Undecorated= SmoothedPWDB<<16)); + PWDB_rssi[sta_cnt++] =3D (psta->mac_id | (psta->rssi_stat.Undecorated= SmoothedPWDB << 16)); } } =20 diff --git a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c b/drivers/stag= ing/rtl8723bs/hal/odm_CfoTracking.c index 0eaedd8f6469..084e745d4ee0 100644 --- a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c +++ b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c @@ -122,8 +122,8 @@ void ODM_CfoTracking(void *pDM_VOID) /* 4 1.3 Avoid abnormal large CFO */ CFO_ave_diff =3D (pCfoTrack->CFO_ave_pre >=3D CFO_ave) ? - (pCfoTrack->CFO_ave_pre-CFO_ave) : - (CFO_ave-pCfoTrack->CFO_ave_pre); + (pCfoTrack->CFO_ave_pre - CFO_ave) : + (CFO_ave - pCfoTrack->CFO_ave_pre); =20 if ( CFO_ave_diff > 20 && diff --git a/drivers/staging/rtl8723bs/hal/odm_DIG.c b/drivers/staging/rtl8= 723bs/hal/odm_DIG.c index a31c8368f9d9..8b754923b7d4 100644 --- a/drivers/staging/rtl8723bs/hal/odm_DIG.c +++ b/drivers/staging/rtl8723bs/hal/odm_DIG.c @@ -12,14 +12,14 @@ void odm_NHMCounterStatisticsInit(void *pDM_VOID) struct dm_odm_t *pDM_Odm =3D (struct dm_odm_t *)pDM_VOID; =20 /* PHY parameters initialize for n series */ - rtw_write16(pDM_Odm->Adapter, ODM_REG_NHM_TIMER_11N+2, 0x2710); /* 0x894[= 31:16]=3D 0x2710 Time duration for NHM unit: 4us, 0x2710 =3D40ms */ + rtw_write16(pDM_Odm->Adapter, ODM_REG_NHM_TIMER_11N + 2, 0x2710); /* 0x89= 4[31:16]=3D 0x2710 Time duration for NHM unit: 4us, 0x2710 =3D40ms */ /* rtw_write16(pDM_Odm->Adapter, ODM_REG_NHM_TIMER_11N+2, 0x4e20); 0x894[= 31:16]=3D 0x4e20 Time duration for NHM unit: 4us, 0x4e20 =3D80ms */ - rtw_write16(pDM_Odm->Adapter, ODM_REG_NHM_TH9_TH10_11N+2, 0xffff); /* 0x8= 90[31:16]=3D 0xffff th_9, th_10 */ + rtw_write16(pDM_Odm->Adapter, ODM_REG_NHM_TH9_TH10_11N + 2, 0xffff); /* 0= x890[31:16]=3D 0xffff th_9, th_10 */ /* rtw_write32(pDM_Odm->Adapter, ODM_REG_NHM_TH3_TO_TH0_11N, 0xffffff5c);= 0x898 =3D 0xffffff5c th_3, th_2, th_1, th_0 */ rtw_write32(pDM_Odm->Adapter, ODM_REG_NHM_TH3_TO_TH0_11N, 0xffffff52); /*= 0x898 =3D 0xffffff52 th_3, th_2, th_1, th_0 */ rtw_write32(pDM_Odm->Adapter, ODM_REG_NHM_TH7_TO_TH4_11N, 0xffffffff); /*= 0x89c =3D 0xffffffff th_7, th_6, th_5, th_4 */ PHY_SetBBReg(pDM_Odm->Adapter, ODM_REG_FPGA0_IQK_11N, bMaskByte0, 0xff); = /* 0xe28[7:0]=3D 0xff th_8 */ - PHY_SetBBReg(pDM_Odm->Adapter, ODM_REG_NHM_TH9_TH10_11N, BIT10|BIT9|BIT8,= 0x7); /* 0x890[9:8]=3D3 enable CCX */ + PHY_SetBBReg(pDM_Odm->Adapter, ODM_REG_NHM_TH9_TH10_11N, BIT10 | BIT9 | B= IT8, 0x7); /* 0x890[9:8]=3D3 enable CCX */ PHY_SetBBReg(pDM_Odm->Adapter, ODM_REG_OFDM_FA_RSTC_11N, BIT7, 0x1); /* = 0xc0c[7]=3D 1 max power among all RX ants */ } =20 @@ -72,16 +72,16 @@ void odm_NHMBB(void *pDM_VOID) /* struct false_ALARM_STATISTICS *pFalseAlmCnt =3D &pDM_Odm->FalseAlmCnt;= */ =20 pDM_Odm->NHMCurTxOkcnt =3D - *(pDM_Odm->pNumTxBytesUnicast)-pDM_Odm->NHMLastTxOkcnt; + *(pDM_Odm->pNumTxBytesUnicast) - pDM_Odm->NHMLastTxOkcnt; pDM_Odm->NHMCurRxOkcnt =3D - *(pDM_Odm->pNumRxBytesUnicast)-pDM_Odm->NHMLastRxOkcnt; + *(pDM_Odm->pNumRxBytesUnicast) - pDM_Odm->NHMLastRxOkcnt; pDM_Odm->NHMLastTxOkcnt =3D *(pDM_Odm->pNumTxBytesUnicast); pDM_Odm->NHMLastRxOkcnt =3D *(pDM_Odm->pNumRxBytesUnicast); =20 =20 - if ((pDM_Odm->NHMCurTxOkcnt) + 1 > (u64)(pDM_Odm->NHMCurRxOkcnt<<2) + 1) = { /* Tx > 4*Rx possible for adaptivity test */ + if ((pDM_Odm->NHMCurTxOkcnt) + 1 > (u64)(pDM_Odm->NHMCurRxOkcnt << 2) + 1= ) { /* Tx > 4*Rx possible for adaptivity test */ if (pDM_Odm->NHM_cnt_0 >=3D 190 || pDM_Odm->adaptivity_flag =3D=3D true)= { /* Enable EDCCA since it is possible running Adaptivity testing */ /* test_status =3D 1; */ @@ -129,7 +129,7 @@ void odm_SearchPwdBLowerBound(void *pDM_VOID, u8 IGI_ta= rget) ODM_Write_DIG(pDM_Odm, IGI); =20 =20 - Diff =3D IGI_target-(s8)IGI; + Diff =3D IGI_target - (s8)IGI; TH_L2H_dmc =3D pDM_Odm->TH_L2H_ini + Diff; if (TH_L2H_dmc > 10) TH_L2H_dmc =3D 10; @@ -152,7 +152,7 @@ void odm_SearchPwdBLowerBound(void *pDM_VOID, u8 IGI_ta= rget) } =20 if (pDM_Odm->txEdcca1 > 5) { - IGI =3D IGI-1; + IGI =3D IGI - 1; TH_L2H_dmc =3D TH_L2H_dmc + 1; if (TH_L2H_dmc > 10) TH_L2H_dmc =3D 10; @@ -229,7 +229,7 @@ void odm_Adaptivity(void *pDM_VOID, u8 IGI) IGI_target =3D pDM_Odm->IGI_Base + 2; else IGI_target =3D pDM_Odm->IGI_Base; - pDM_Odm->IGI_target =3D (u8) IGI_target; + pDM_Odm->IGI_target =3D (u8)IGI_target; =20 /* Search pwdB lower bound */ if (pDM_Odm->TxHangFlg =3D=3D true) { @@ -260,7 +260,7 @@ void odm_Adaptivity(void *pDM_VOID, u8 IGI) odm_NHMBB(pDM_Odm); =20 if (EDCCA_State) { - Diff =3D IGI_target-(s8)IGI; + Diff =3D IGI_target - (s8)IGI; TH_L2H_dmc =3D pDM_Odm->TH_L2H_ini + Diff; if (TH_L2H_dmc > 10) TH_L2H_dmc =3D 10; @@ -336,7 +336,7 @@ void odm_DIGInit(void *pDM_VOID) =20 pDM_DigTable->bStopDIG =3D false; pDM_DigTable->bPSDInProgress =3D false; - pDM_DigTable->CurIGValue =3D (u8) PHY_QueryBBReg(pDM_Odm->Adapter, ODM_RE= G(IGI_A), ODM_BIT(IGI)); + pDM_DigTable->CurIGValue =3D (u8)PHY_QueryBBReg(pDM_Odm->Adapter, ODM_REG= (IGI_A), ODM_BIT(IGI)); pDM_DigTable->RssiLowThresh =3D DM_DIG_THRESH_LOW; pDM_DigTable->RssiHighThresh =3D DM_DIG_THRESH_HIGH; pDM_DigTable->FALowThresh =3D DMfalseALARM_THRESH_LOW; @@ -444,7 +444,7 @@ void odm_DIG(void *pDM_VOID) if (pDM_DigTable->AntDiv_RSSI_max > DIG_MaxOfMin) DIG_Dynamic_MIN =3D DIG_MaxOfMin; else - DIG_Dynamic_MIN =3D (u8) pDM_DigTable->AntDiv_RSSI_max; + DIG_Dynamic_MIN =3D (u8)pDM_DigTable->AntDiv_RSSI_max; } } } @@ -574,16 +574,16 @@ void odm_DIGbyRSSI_LPS(void *pDM_VOID) u8 RSSI_Lower =3D DM_DIG_MIN_NIC; /* 0x1E or 0x1C */ u8 CurrentIGI =3D pDM_Odm->RSSI_Min; =20 - CurrentIGI =3D CurrentIGI+RSSI_OFFSET_DIG; + CurrentIGI =3D CurrentIGI + RSSI_OFFSET_DIG; =20 /* Using FW PS mode to make IGI */ /* Adjust by FA in LPS MODE */ if (pFalseAlmCnt->Cnt_all > DM_DIG_FA_TH2_LPS) - CurrentIGI =3D CurrentIGI+4; + CurrentIGI =3D CurrentIGI + 4; else if (pFalseAlmCnt->Cnt_all > DM_DIG_FA_TH1_LPS) - CurrentIGI =3D CurrentIGI+2; + CurrentIGI =3D CurrentIGI + 2; else if (pFalseAlmCnt->Cnt_all < DM_DIG_FA_TH0_LPS) - CurrentIGI =3D CurrentIGI-2; + CurrentIGI =3D CurrentIGI - 2; =20 =20 /* Lower bound checking */ @@ -623,25 +623,25 @@ void odm_FalseAlarmCounterStatistics(void *pDM_VOID) ret_value =3D PHY_QueryBBReg( pDM_Odm->Adapter, ODM_REG_OFDM_FA_TYPE1_11N, bMaskDWord ); - FalseAlmCnt->Cnt_Fast_Fsync =3D (ret_value&0xffff); - FalseAlmCnt->Cnt_SB_Search_fail =3D ((ret_value&0xffff0000)>>16); + FalseAlmCnt->Cnt_Fast_Fsync =3D (ret_value & 0xffff); + FalseAlmCnt->Cnt_SB_Search_fail =3D ((ret_value & 0xffff0000) >> 16); =20 ret_value =3D PHY_QueryBBReg( pDM_Odm->Adapter, ODM_REG_OFDM_FA_TYPE2_11N, bMaskDWord ); - FalseAlmCnt->Cnt_OFDM_CCA =3D (ret_value&0xffff); - FalseAlmCnt->Cnt_Parity_Fail =3D ((ret_value&0xffff0000)>>16); + FalseAlmCnt->Cnt_OFDM_CCA =3D (ret_value & 0xffff); + FalseAlmCnt->Cnt_Parity_Fail =3D ((ret_value & 0xffff0000) >> 16); =20 ret_value =3D PHY_QueryBBReg( pDM_Odm->Adapter, ODM_REG_OFDM_FA_TYPE3_11N, bMaskDWord ); - FalseAlmCnt->Cnt_Rate_Illegal =3D (ret_value&0xffff); - FalseAlmCnt->Cnt_Crc8_fail =3D ((ret_value&0xffff0000)>>16); + FalseAlmCnt->Cnt_Rate_Illegal =3D (ret_value & 0xffff); + FalseAlmCnt->Cnt_Crc8_fail =3D ((ret_value & 0xffff0000) >> 16); =20 ret_value =3D PHY_QueryBBReg( pDM_Odm->Adapter, ODM_REG_OFDM_FA_TYPE4_11N, bMaskDWord ); - FalseAlmCnt->Cnt_Mcs_fail =3D (ret_value&0xffff); + FalseAlmCnt->Cnt_Mcs_fail =3D (ret_value & 0xffff); =20 FalseAlmCnt->Cnt_Ofdm_fail =3D FalseAlmCnt->Cnt_Parity_Fail + @@ -664,13 +664,13 @@ void odm_FalseAlarmCounterStatistics(void *pDM_VOID) ret_value =3D PHY_QueryBBReg( pDM_Odm->Adapter, ODM_REG_CCK_FA_MSB_11N, bMaskByte3 ); - FalseAlmCnt->Cnt_Cck_fail +=3D (ret_value&0xff)<<8; + FalseAlmCnt->Cnt_Cck_fail +=3D (ret_value & 0xff) << 8; =20 ret_value =3D PHY_QueryBBReg( pDM_Odm->Adapter, ODM_REG_CCK_CCA_CNT_11N, bMaskDWord ); FalseAlmCnt->Cnt_CCK_CCA =3D - ((ret_value&0xFF)<<8) | ((ret_value&0xFF00)>>8); + ((ret_value & 0xFF) << 8) | ((ret_value & 0xFF00) >> 8); } =20 FalseAlmCnt->Cnt_all =3D ( diff --git a/drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c b/dri= vers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c index 57c5736527d2..bb342d7004fd 100644 --- a/drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c +++ b/drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c @@ -34,10 +34,10 @@ void ODM_RF_Saving(void *pDM_VOID, u8 bForceInNormal) =20 if (pDM_PSTable->initialize =3D=3D 0) { =20 - pDM_PSTable->Reg874 =3D (PHY_QueryBBReg(pDM_Odm->Adapter, 0x874, bMaskDW= ord)&0x1CC000)>>14; - pDM_PSTable->RegC70 =3D (PHY_QueryBBReg(pDM_Odm->Adapter, 0xc70, bMaskDW= ord)&BIT3)>>3; - pDM_PSTable->Reg85C =3D (PHY_QueryBBReg(pDM_Odm->Adapter, 0x85c, bMaskDW= ord)&0xFF000000)>>24; - pDM_PSTable->RegA74 =3D (PHY_QueryBBReg(pDM_Odm->Adapter, 0xa74, bMaskDW= ord)&0xF000)>>12; + pDM_PSTable->Reg874 =3D (PHY_QueryBBReg(pDM_Odm->Adapter, 0x874, bMaskDW= ord) & 0x1CC000) >> 14; + pDM_PSTable->RegC70 =3D (PHY_QueryBBReg(pDM_Odm->Adapter, 0xc70, bMaskDW= ord) & BIT3) >> 3; + pDM_PSTable->Reg85C =3D (PHY_QueryBBReg(pDM_Odm->Adapter, 0x85c, bMaskDW= ord) & 0xFF000000) >> 24; + pDM_PSTable->RegA74 =3D (PHY_QueryBBReg(pDM_Odm->Adapter, 0xa74, bMaskDW= ord) & 0xF000) >> 12; /* Reg818 =3D PHY_QueryBBReg(padapter, 0x818, bMaskDWord); */ pDM_PSTable->initialize =3D 1; } diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging= /rtl8723bs/hal/odm_HWConfig.c index 994b8c578e7a..a0c163979916 100644 --- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c +++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c @@ -29,7 +29,7 @@ s32 odm_signal_scale_mapping(struct dm_odm_t *dm_odm, s32= curr_sig) if (curr_sig >=3D 51 && curr_sig <=3D 100) ret_sig =3D 100; else if (curr_sig >=3D 41 && curr_sig <=3D 50) - ret_sig =3D 80 + ((curr_sig - 40)*2); + ret_sig =3D 80 + ((curr_sig - 40) * 2); else if (curr_sig >=3D 31 && curr_sig <=3D 40) ret_sig =3D 66 + (curr_sig - 30); else if (curr_sig >=3D 21 && curr_sig <=3D 30) @@ -134,7 +134,7 @@ static void odm_rx_phy_status_parsing(struct dm_odm_t *= dm_odm, * 2011.11.28 LukeLee: 88E use different LNA & VGA gain table * The RSSI formula should be modified according to the gain table */ - lna_idx =3D ((cck_agc_rpt & 0xE0)>>5); + lna_idx =3D ((cck_agc_rpt & 0xE0) >> 5); vga_idx =3D (cck_agc_rpt & 0x1F); rx_pwr_all =3D odm_cck_rssi(lna_idx, vga_idx); pwdb_all =3D odm_query_rx_pwr_percentage(rx_pwr_all); @@ -161,7 +161,7 @@ static void odm_rx_phy_status_parsing(struct dm_odm_t *= dm_odm, else if (sq_rpt < 20) sq =3D 100; else - sq =3D ((64-sq_rpt) * 100) / 44; + sq =3D ((64 - sq_rpt) * 100) / 44; =20 } =20 @@ -194,7 +194,7 @@ static void odm_rx_phy_status_parsing(struct dm_odm_t *= dm_odm, phy_info->rx_mimo_signal_strength[i] =3D (u8)rssi; =20 /* Get Rx snr value in DB */ - phy_info->rx_snr[i] =3D dm_odm->PhyDbgInfo.RxSNRdB[i] =3D (s32)(phy_sta= _rpt->path_rxsnr[i]/2); + phy_info->rx_snr[i] =3D dm_odm->PhyDbgInfo.RxSNRdB[i] =3D (s32)(phy_sta= _rpt->path_rxsnr[i] / 2); } =20 /* @@ -309,11 +309,11 @@ static void odm_Process_RSSIForDM( RSSI_min =3D pPhyInfo->rx_mimo_signal_strength[RF_PATH_A]; } =20 - if ((RSSI_max-RSSI_min) < 3) + if ((RSSI_max - RSSI_min) < 3) RSSI_Ave =3D RSSI_max; - else if ((RSSI_max-RSSI_min) < 6) + else if ((RSSI_max - RSSI_min) < 6) RSSI_Ave =3D RSSI_max - 1; - else if ((RSSI_max-RSSI_min) < 10) + else if ((RSSI_max - RSSI_min) < 10) RSSI_Ave =3D RSSI_max - 2; else RSSI_Ave =3D RSSI_max - 3; @@ -325,21 +325,21 @@ static void odm_Process_RSSIForDM( else { if (pPhyInfo->rx_pwd_ba11 > (u32)UndecoratedSmoothedOFDM) { UndecoratedSmoothedOFDM =3D - ((UndecoratedSmoothedOFDM*(Rx_Smooth_Factor-1)) + - RSSI_Ave)/Rx_Smooth_Factor; + ((UndecoratedSmoothedOFDM * (Rx_Smooth_Factor - 1)) + + RSSI_Ave) / Rx_Smooth_Factor; UndecoratedSmoothedOFDM =3D UndecoratedSmoothedOFDM + 1; } else { UndecoratedSmoothedOFDM =3D - ((UndecoratedSmoothedOFDM*(Rx_Smooth_Factor-1)) + - RSSI_Ave)/Rx_Smooth_Factor; + ((UndecoratedSmoothedOFDM * (Rx_Smooth_Factor - 1)) + + RSSI_Ave) / Rx_Smooth_Factor; } } =20 - pEntry->rssi_stat.PacketMap =3D (pEntry->rssi_stat.PacketMap<<1) | BIT0; + pEntry->rssi_stat.PacketMap =3D (pEntry->rssi_stat.PacketMap << 1) | BI= T0; =20 } else { RSSI_Ave =3D pPhyInfo->rx_pwd_ba11; - pDM_Odm->RSSI_A =3D (u8) pPhyInfo->rx_pwd_ba11; + pDM_Odm->RSSI_A =3D (u8)pPhyInfo->rx_pwd_ba11; pDM_Odm->RSSI_B =3D 0; =20 /* 1 Process CCK RSSI */ @@ -348,16 +348,16 @@ static void odm_Process_RSSIForDM( else { if (pPhyInfo->rx_pwd_ba11 > (u32)UndecoratedSmoothedCCK) { UndecoratedSmoothedCCK =3D - ((UndecoratedSmoothedCCK*(Rx_Smooth_Factor-1)) + - pPhyInfo->rx_pwd_ba11)/Rx_Smooth_Factor; + ((UndecoratedSmoothedCCK * (Rx_Smooth_Factor - 1)) + + pPhyInfo->rx_pwd_ba11) / Rx_Smooth_Factor; UndecoratedSmoothedCCK =3D UndecoratedSmoothedCCK + 1; } else { UndecoratedSmoothedCCK =3D - ((UndecoratedSmoothedCCK*(Rx_Smooth_Factor-1)) + - pPhyInfo->rx_pwd_ba11)/Rx_Smooth_Factor; + ((UndecoratedSmoothedCCK * (Rx_Smooth_Factor - 1)) + + pPhyInfo->rx_pwd_ba11) / Rx_Smooth_Factor; } } - pEntry->rssi_stat.PacketMap =3D pEntry->rssi_stat.PacketMap<<1; + pEntry->rssi_stat.PacketMap =3D pEntry->rssi_stat.PacketMap << 1; } =20 /* if (pEntry) */ @@ -369,14 +369,14 @@ static void odm_Process_RSSIForDM( pEntry->rssi_stat.ValidBit++; =20 for (i =3D 0; i < pEntry->rssi_stat.ValidBit; i++) - OFDM_pkt +=3D (u8)(pEntry->rssi_stat.PacketMap>>i)&BIT0; + OFDM_pkt +=3D (u8)(pEntry->rssi_stat.PacketMap >> i) & BIT0; =20 if (pEntry->rssi_stat.ValidBit =3D=3D 64) { - Weighting =3D ((OFDM_pkt<<4) > 64)?64:(OFDM_pkt<<4); - UndecoratedSmoothedPWDB =3D (Weighting*UndecoratedSmoothedOFDM+(64-Wei= ghting)*UndecoratedSmoothedCCK)>>6; + Weighting =3D ((OFDM_pkt << 4) > 64) ? 64 : (OFDM_pkt << 4); + UndecoratedSmoothedPWDB =3D (Weighting * UndecoratedSmoothedOFDM + (64= - Weighting) * UndecoratedSmoothedCCK) >> 6; } else { if (pEntry->rssi_stat.ValidBit !=3D 0) - UndecoratedSmoothedPWDB =3D (OFDM_pkt*UndecoratedSmoothedOFDM+(pEntry= ->rssi_stat.ValidBit-OFDM_pkt)*UndecoratedSmoothedCCK)/pEntry->rssi_stat.Va= lidBit; + UndecoratedSmoothedPWDB =3D (OFDM_pkt * UndecoratedSmoothedOFDM + (pE= ntry->rssi_stat.ValidBit - OFDM_pkt) * UndecoratedSmoothedCCK) / pEntry->rs= si_stat.ValidBit; else UndecoratedSmoothedPWDB =3D 0; } diff --git a/drivers/staging/rtl8723bs/hal/odm_RegConfig8723B.c b/drivers/s= taging/rtl8723bs/hal/odm_RegConfig8723B.c index b0ca46aec1a5..9d073f06cf62 100644 --- a/drivers/staging/rtl8723bs/hal/odm_RegConfig8723B.c +++ b/drivers/staging/rtl8723bs/hal/odm_RegConfig8723B.c @@ -33,7 +33,7 @@ void odm_ConfigRFReg_8723B( =20 udelay(1); =20 - while ((getvalue>>8) !=3D (Data>>8)) { + while ((getvalue >> 8) !=3D (Data >> 8)) { count++; PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH, RegAddr, bRFRegOffsetMask, Dat= a); udelay(1); @@ -87,14 +87,14 @@ void odm_ConfigRFReg_8723B( void odm_ConfigRF_RadioA_8723B(struct dm_odm_t *pDM_Odm, u32 Addr, u32 Dat= a) { u32 content =3D 0x1000; /* RF_Content: radioa_txt */ - u32 maskforPhySet =3D (u32)(content&0xE000); + u32 maskforPhySet =3D (u32)(content & 0xE000); =20 odm_ConfigRFReg_8723B( pDM_Odm, Addr, Data, RF_PATH_A, - Addr|maskforPhySet + Addr | maskforPhySet ); } =20 diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging= /rtl8723bs/hal/rtl8723b_cmd.c index 12416e499ac3..79f3f723fd5b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c @@ -75,23 +75,23 @@ s32 FillH2CCmd8723B(struct adapter *padapter, u8 Elemen= tID, u32 CmdLen, u8 *pCmd goto exit; =20 if (CmdLen <=3D 3) - memcpy((u8 *)(&h2c_cmd)+1, pCmdBuffer, CmdLen); + memcpy((u8 *)(&h2c_cmd) + 1, pCmdBuffer, CmdLen); else { - memcpy((u8 *)(&h2c_cmd)+1, pCmdBuffer, 3); - memcpy((u8 *)(&h2c_cmd_ex), pCmdBuffer+3, CmdLen-3); + memcpy((u8 *)(&h2c_cmd) + 1, pCmdBuffer, 3); + memcpy((u8 *)(&h2c_cmd_ex), pCmdBuffer + 3, CmdLen - 3); /* *(u8 *)(&h2c_cmd) |=3D BIT(7); */ } =20 *(u8 *)(&h2c_cmd) |=3D ElementID; =20 if (CmdLen > 3) { - msgbox_ex_addr =3D REG_HMEBOX_EXT0_8723B + (h2c_box_num*RTL8723B_EX_MES= SAGE_BOX_SIZE); + msgbox_ex_addr =3D REG_HMEBOX_EXT0_8723B + (h2c_box_num * RTL8723B_EX_M= ESSAGE_BOX_SIZE); rtw_write32(padapter, msgbox_ex_addr, h2c_cmd_ex); } - msgbox_addr =3D REG_HMEBOX_0 + (h2c_box_num*MESSAGE_BOX_SIZE); + msgbox_addr =3D REG_HMEBOX_0 + (h2c_box_num * MESSAGE_BOX_SIZE); rtw_write32(padapter, msgbox_addr, h2c_cmd); =20 - pHalData->LastHMEBoxNum =3D (h2c_box_num+1) % MAX_H2C_BOX_NUMS; + pHalData->LastHMEBoxNum =3D (h2c_box_num + 1) % MAX_H2C_BOX_NUMS; =20 } while (0); =20 @@ -144,9 +144,9 @@ static void ConstructBeacon(struct adapter *padapter, u= 8 *pframe, u32 *pLength) pframe +=3D 2; pktlen +=3D 2; =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) { + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) { pktlen +=3D cur_network->ie_length - sizeof(struct ndis_802_11_fix_ie); - memcpy(pframe, cur_network->ies+sizeof(struct ndis_802_11_fix_ie), pktle= n); + memcpy(pframe, cur_network->ies + sizeof(struct ndis_802_11_fix_ie), pkt= len); =20 goto _ConstructBeacon; } @@ -163,7 +163,7 @@ static void ConstructBeacon(struct adapter *padapter, u= 8 *pframe, u32 *pLength) /* DS parameter set */ pframe =3D rtw_set_ie(pframe, WLAN_EID_DS_PARAMS, 1, (unsigned char *)&(c= ur_network->configuration.ds_config), &pktlen); =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_ADHOC_STATE) { + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) { u32 ATIMWindow; /* IBSS Parameter Set... */ /* ATIMWindow =3D cur->configuration.ATIMWindow; */ @@ -332,7 +332,7 @@ void rtl8723b_set_rssi_cmd(struct adapter *padapter, u8= *param) { u8 u1H2CRssiSettingParm[H2C_RSSI_SETTING_LEN] =3D {0}; u8 mac_id =3D *param; - u8 rssi =3D *(param+2); + u8 rssi =3D *(param + 2); u8 uldl_state =3D 0; =20 SET_8723B_H2CCMD_RSSI_SETTING_MACID(u1H2CRssiSettingParm, mac_id); @@ -351,7 +351,7 @@ void rtl8723b_set_FwPwrMode_cmd(struct adapter *padapte= r, u8 psmode) u8 PowerState =3D 0, awake_intvl =3D 1, byte5 =3D 0, rlbm =3D 0; =20 if (pwrpriv->dtim > 0 && pwrpriv->dtim < 16) - awake_intvl =3D pwrpriv->dtim+1;/* DTIM =3D (awake_intvl - 1) */ + awake_intvl =3D pwrpriv->dtim + 1;/* DTIM =3D (awake_intvl - 1) */ else awake_intvl =3D 3;/* DTIM =3D2 */ =20 @@ -402,7 +402,7 @@ void rtl8723b_set_FwPwrMode_cmd(struct adapter *padapte= r, u8 psmode) pmlmeext->DrvBcnTimeOut =3D 0xff; =20 for (i =3D 0; i < 9; i++) { - pmlmeext->bcn_delay_ratio[i] =3D (pmlmeext->bcn_delay_cnt[i]*100)/pmlm= eext->bcn_cnt; + pmlmeext->bcn_delay_ratio[i] =3D (pmlmeext->bcn_delay_cnt[i] * 100) / = pmlmeext->bcn_cnt; =20 ratio_20_delay +=3D pmlmeext->bcn_delay_ratio[i]; ratio_80_delay +=3D pmlmeext->bcn_delay_ratio[i]; @@ -501,7 +501,7 @@ static void rtl8723b_set_FwRsvdPagePkt( pmlmeinfo =3D &pmlmeext->mlmext_info; =20 RsvdPageNum =3D BCNQ_PAGE_NUM_8723B + WOWLAN_PAGE_NUM_8723B; - MaxRsvdPageBufSize =3D RsvdPageNum*PageSize; + MaxRsvdPageBufSize =3D RsvdPageNum * PageSize; =20 pcmdframe =3D rtw_alloc_cmdxmitframe(pxmitpriv); if (!pcmdframe) @@ -523,18 +523,18 @@ static void rtl8723b_set_FwRsvdPagePkt( =20 TotalPageNum +=3D CurtPktPageNum; =20 - BufIndex +=3D (CurtPktPageNum*PageSize); + BufIndex +=3D (CurtPktPageNum * PageSize); =20 /* 3 (2) ps-poll */ RsvdPageLoc.LocPsPoll =3D TotalPageNum; ConstructPSPoll(padapter, &ReservedPagePacket[BufIndex], &PSPollLength); - rtl8723b_fill_fake_txdesc(padapter, &ReservedPagePacket[BufIndex-TxDescLe= n], PSPollLength, true, false, false); + rtl8723b_fill_fake_txdesc(padapter, &ReservedPagePacket[BufIndex - TxDesc= Len], PSPollLength, true, false, false); =20 CurtPktPageNum =3D (u8)PageNum_128(TxDescLen + PSPollLength); =20 TotalPageNum +=3D CurtPktPageNum; =20 - BufIndex +=3D (CurtPktPageNum*PageSize); + BufIndex +=3D (CurtPktPageNum * PageSize); =20 /* 3 (3) null data */ RsvdPageLoc.LocNullData =3D TotalPageNum; @@ -545,13 +545,13 @@ static void rtl8723b_set_FwRsvdPagePkt( get_my_bssid(&pmlmeinfo->network), false, 0, 0, false ); - rtl8723b_fill_fake_txdesc(padapter, &ReservedPagePacket[BufIndex-TxDescLe= n], NullDataLength, false, false, false); + rtl8723b_fill_fake_txdesc(padapter, &ReservedPagePacket[BufIndex - TxDesc= Len], NullDataLength, false, false, false); =20 CurtPktPageNum =3D (u8)PageNum_128(TxDescLen + NullDataLength); =20 TotalPageNum +=3D CurtPktPageNum; =20 - BufIndex +=3D (CurtPktPageNum*PageSize); + BufIndex +=3D (CurtPktPageNum * PageSize); =20 /* 3 (5) Qos null data */ RsvdPageLoc.LocQosNull =3D TotalPageNum; @@ -562,13 +562,13 @@ static void rtl8723b_set_FwRsvdPagePkt( get_my_bssid(&pmlmeinfo->network), true, 0, 0, false ); - rtl8723b_fill_fake_txdesc(padapter, &ReservedPagePacket[BufIndex-TxDescLe= n], QosNullLength, false, false, false); + rtl8723b_fill_fake_txdesc(padapter, &ReservedPagePacket[BufIndex - TxDesc= Len], QosNullLength, false, false, false); =20 CurtPktPageNum =3D (u8)PageNum_128(TxDescLen + QosNullLength); =20 TotalPageNum +=3D CurtPktPageNum; =20 - BufIndex +=3D (CurtPktPageNum*PageSize); + BufIndex +=3D (CurtPktPageNum * PageSize); =20 /* 3 (6) BT Qos null data */ RsvdPageLoc.LocBTQosNull =3D TotalPageNum; @@ -579,13 +579,13 @@ static void rtl8723b_set_FwRsvdPagePkt( get_my_bssid(&pmlmeinfo->network), true, 0, 0, false ); - rtl8723b_fill_fake_txdesc(padapter, &ReservedPagePacket[BufIndex-TxDescLe= n], BTQosNullLength, false, true, false); + rtl8723b_fill_fake_txdesc(padapter, &ReservedPagePacket[BufIndex - TxDesc= Len], BTQosNullLength, false, true, false); =20 CurtPktPageNum =3D (u8)PageNum_128(TxDescLen + BTQosNullLength); =20 TotalPageNum +=3D CurtPktPageNum; =20 - BufIndex +=3D (CurtPktPageNum*PageSize); + BufIndex +=3D (CurtPktPageNum * PageSize); =20 TotalPacketLen =3D BufIndex + BTQosNullLength; =20 @@ -626,12 +626,12 @@ void rtl8723b_download_rsvd_page(struct adapter *pada= pter, u8 mstatus) =20 /* We should set AID, correct TSF, HW seq enable before set JoinBssRepo= rt to Fw in 88/92C. */ /* Suggested by filen. Added by tynli. */ - rtw_write16(padapter, REG_BCN_PSR_RPT, (0xC000|pmlmeinfo->aid)); + rtw_write16(padapter, REG_BCN_PSR_RPT, (0xC000 | pmlmeinfo->aid)); =20 /* set REG_CR bit 8 */ - v8 =3D rtw_read8(padapter, REG_CR+1); + v8 =3D rtw_read8(padapter, REG_CR + 1); v8 |=3D BIT(0); /* ENSWBCN */ - rtw_write8(padapter, REG_CR+1, v8); + rtw_write8(padapter, REG_CR + 1, v8); =20 /* Disable Hw protection for a time which revserd for Hw sending beacon= . */ /* Fix download reserved page packet fail that access collision with th= e protection time. */ @@ -646,7 +646,7 @@ void rtl8723b_download_rsvd_page(struct adapter *padapt= er, u8 mstatus) bRecover =3D true; =20 /* To tell Hw the packet is not a real beacon frame. */ - rtw_write8(padapter, REG_FWHW_TXQ_CTRL+2, pHalData->RegFwHwTxQCtrl & ~BI= T(6)); + rtw_write8(padapter, REG_FWHW_TXQ_CTRL + 2, pHalData->RegFwHwTxQCtrl & ~= BIT(6)); pHalData->RegFwHwTxQCtrl &=3D ~BIT(6); =20 /* Clear beacon valid check bit. */ @@ -665,7 +665,7 @@ void rtl8723b_download_rsvd_page(struct adapter *padapt= er, u8 mstatus) /* check rsvd page download OK. */ rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, (u8 *)(&bcn_valid)); poll++; - } while (!bcn_valid && (poll%10) !=3D 0 && !padapter->bSurpriseRemoved = && !padapter->bDriverStopped); + } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->bSurpriseRemove= d && !padapter->bDriverStopped); =20 } while (!bcn_valid && DLBcnCount <=3D 100 && !padapter->bSurpriseRemove= d && !padapter->bDriverStopped); =20 @@ -688,14 +688,14 @@ void rtl8723b_download_rsvd_page(struct adapter *pada= pter, u8 mstatus) /* the beacon cannot be sent by HW. */ /* 2010.06.23. Added by tynli. */ if (bRecover) { - rtw_write8(padapter, REG_FWHW_TXQ_CTRL+2, pHalData->RegFwHwTxQCtrl | BI= T(6)); + rtw_write8(padapter, REG_FWHW_TXQ_CTRL + 2, pHalData->RegFwHwTxQCtrl | = BIT(6)); pHalData->RegFwHwTxQCtrl |=3D BIT(6); } =20 /* Clear CR[8] or beacon packet will not be send to TxBuf anymore. */ - v8 =3D rtw_read8(padapter, REG_CR+1); + v8 =3D rtw_read8(padapter, REG_CR + 1); v8 &=3D ~BIT(0); /* ~ENSWBCN */ - rtw_write8(padapter, REG_CR+1, v8); + rtw_write8(padapter, REG_CR + 1, v8); } } =20 @@ -724,7 +724,7 @@ void rtl8723b_Add_RateATid( u8 raid =3D arg[1]; u8 shortGI =3D arg[2]; u8 bw; - u32 mask =3D bitmap&0x0FFFFFFF; + u32 mask =3D bitmap & 0x0FFFFFFF; =20 psta =3D pmlmeinfo->FW_sta_info[mac_id].psta; if (!psta) @@ -813,7 +813,7 @@ static void SetFwRsvdPagePkt_BTCoex(struct adapter *pad= apter) PageSize =3D PAGE_SIZE_TX_8723B; =20 RsvdPageNum =3D BCNQ_PAGE_NUM_8723B; - MaxRsvdPageBufSize =3D RsvdPageNum*PageSize; + MaxRsvdPageBufSize =3D RsvdPageNum * PageSize; =20 pcmdframe =3D rtw_alloc_cmdxmitframe(pxmitpriv); if (!pcmdframe) @@ -834,7 +834,7 @@ static void SetFwRsvdPagePkt_BTCoex(struct adapter *pad= apter) CurtPktPageNum +=3D 1; TotalPageNum +=3D CurtPktPageNum; =20 - BufIndex +=3D (CurtPktPageNum*PageSize); + BufIndex +=3D (CurtPktPageNum * PageSize); =20 /* Jump to lastest page */ if (BufIndex < (MaxRsvdPageBufSize - PageSize)) { @@ -851,7 +851,7 @@ static void SetFwRsvdPagePkt_BTCoex(struct adapter *pad= apter) NULL, true, 0, 0, false ); - rtl8723b_fill_fake_txdesc(padapter, &ReservedPagePacket[BufIndex-TxDescLe= n], BTQosNullLength, false, true, false); + rtl8723b_fill_fake_txdesc(padapter, &ReservedPagePacket[BufIndex - TxDesc= Len], BTQosNullLength, false, true, false); =20 CurtPktPageNum =3D (u8)PageNum_128(TxDescLen + BTQosNullLength); =20 @@ -893,12 +893,12 @@ void rtl8723b_download_BTCoex_AP_mode_rsvd_page(struc= t adapter *padapter) =20 /* We should set AID, correct TSF, HW seq enable before set JoinBssRepor= t to Fw in 88/92C. */ /* Suggested by filen. Added by tynli. */ - rtw_write16(padapter, REG_BCN_PSR_RPT, (0xC000|pmlmeinfo->aid)); + rtw_write16(padapter, REG_BCN_PSR_RPT, (0xC000 | pmlmeinfo->aid)); =20 /* set REG_CR bit 8 */ - val8 =3D rtw_read8(padapter, REG_CR+1); + val8 =3D rtw_read8(padapter, REG_CR + 1); val8 |=3D BIT(0); /* ENSWBCN */ - rtw_write8(padapter, REG_CR+1, val8); + rtw_write8(padapter, REG_CR + 1, val8); =20 /* Disable Hw protection for a time which revserd for Hw sending beacon.= */ /* Fix download reserved page packet fail that access collision with the= protection time. */ @@ -914,7 +914,7 @@ void rtl8723b_download_BTCoex_AP_mode_rsvd_page(struct = adapter *padapter) =20 /* To tell Hw the packet is not a real beacon frame. */ pHalData->RegFwHwTxQCtrl &=3D ~BIT(6); - rtw_write8(padapter, REG_FWHW_TXQ_CTRL+2, pHalData->RegFwHwTxQCtrl); + rtw_write8(padapter, REG_FWHW_TXQ_CTRL + 2, pHalData->RegFwHwTxQCtrl); =20 /* Clear beacon valid check bit. */ rtw_hal_set_hwreg(padapter, HW_VAR_BCN_VALID, NULL); @@ -931,7 +931,7 @@ void rtl8723b_download_BTCoex_AP_mode_rsvd_page(struct = adapter *padapter) /* check rsvd page download OK. */ rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, &bcn_valid); poll++; - } while (!bcn_valid && (poll%10) !=3D 0 && !padapter->bSurpriseRemoved &= & !padapter->bDriverStopped); + } while (!bcn_valid && (poll % 10) !=3D 0 && !padapter->bSurpriseRemoved= && !padapter->bDriverStopped); } while (!bcn_valid && (DLBcnCount <=3D 100) && !padapter->bSurpriseRemov= ed && !padapter->bDriverStopped); =20 if (bcn_valid) { @@ -953,11 +953,11 @@ void rtl8723b_download_BTCoex_AP_mode_rsvd_page(struc= t adapter *padapter) /* 2010.06.23. Added by tynli. */ if (bRecover) { pHalData->RegFwHwTxQCtrl |=3D BIT(6); - rtw_write8(padapter, REG_FWHW_TXQ_CTRL+2, pHalData->RegFwHwTxQCtrl); + rtw_write8(padapter, REG_FWHW_TXQ_CTRL + 2, pHalData->RegFwHwTxQCtrl); } =20 /* Clear CR[8] or beacon packet will not be send to TxBuf anymore. */ - val8 =3D rtw_read8(padapter, REG_CR+1); + val8 =3D rtw_read8(padapter, REG_CR + 1); val8 &=3D ~BIT(0); /* ~ENSWBCN */ - rtw_write8(padapter, REG_CR+1, val8); + rtw_write8(padapter, REG_CR + 1, val8); } diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/= rtl8723bs/hal/rtl8723b_dm.c index 928226679ab4..eaa4306716ff 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c @@ -45,7 +45,7 @@ static void Init_ODM_ComInfo_8723b(struct adapter *Adapte= r) /* ODM_CMNINFO_BINHCT_TEST only for MP Team */ ODM_CmnInfoInit(pDM_Odm, ODM_CMNINFO_BWIFI_TEST, Adapter->registrypriv.wi= fi_spec); =20 - pdmpriv->InitODMFlag =3D ODM_RF_CALIBRATION|ODM_RF_TX_PWR_TRACK; + pdmpriv->InitODMFlag =3D ODM_RF_CALIBRATION | ODM_RF_TX_PWR_TRACK; =20 ODM_CmnInfoUpdate(pDM_Odm, ODM_CMNINFO_ABILITY, pdmpriv->InitODMFlag); } @@ -189,7 +189,7 @@ void rtl8723b_hal_dm_in_lps(struct adapter *padapter) /* set rssi to fw */ psta =3D rtw_get_stainfo(pstapriv, get_bssid(pmlmepriv)); if (psta && (psta->rssi_stat.UndecoratedSmoothedPWDB > 0)) { - PWDB_rssi =3D (psta->mac_id | (psta->rssi_stat.UndecoratedSmoothedPWDB<<= 16)); + PWDB_rssi =3D (psta->mac_id | (psta->rssi_stat.UndecoratedSmoothedPWDB <= < 16)); =20 rtl8723b_set_rssi_cmd(padapter, (u8 *)&PWDB_rssi); } diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index e794fe3caf9d..07e212552e52 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -21,23 +21,23 @@ static void _FWDownloadEnable(struct adapter *padapter,= bool enable) rtw_write8(padapter, REG_SYS_FUNC_EN + 1, tmp | 0x04); =20 tmp =3D rtw_read8(padapter, REG_MCUFWDL); - rtw_write8(padapter, REG_MCUFWDL, tmp|0x01); + rtw_write8(padapter, REG_MCUFWDL, tmp | 0x01); =20 do { tmp =3D rtw_read8(padapter, REG_MCUFWDL); if (tmp & 0x01) break; - rtw_write8(padapter, REG_MCUFWDL, tmp|0x01); + rtw_write8(padapter, REG_MCUFWDL, tmp | 0x01); msleep(1); } while (count++ < 100); =20 /* 8051 reset */ - tmp =3D rtw_read8(padapter, REG_MCUFWDL+2); - rtw_write8(padapter, REG_MCUFWDL+2, tmp&0xf7); + tmp =3D rtw_read8(padapter, REG_MCUFWDL + 2); + rtw_write8(padapter, REG_MCUFWDL + 2, tmp & 0xf7); } else { /* MCU firmware download disable. */ tmp =3D rtw_read8(padapter, REG_MCUFWDL); - rtw_write8(padapter, REG_MCUFWDL, tmp&0xfe); + rtw_write8(padapter, REG_MCUFWDL, tmp & 0xfe); } } =20 @@ -70,8 +70,8 @@ static int _BlockWrite(struct adapter *padapter, void *bu= ffer, u32 buffSize) if (remainSize_p1) { offset =3D blockCount_p1 * blockSize_p1; =20 - blockCount_p2 =3D remainSize_p1/blockSize_p2; - remainSize_p2 =3D remainSize_p1%blockSize_p2; + blockCount_p2 =3D remainSize_p1 / blockSize_p2; + remainSize_p2 =3D remainSize_p1 % blockSize_p2; } =20 /* 3 Phase #3 */ @@ -102,10 +102,10 @@ static int _PageWrite( ) { u8 value8; - u8 u8Page =3D (u8) (page & 0x07); + u8 u8Page =3D (u8)(page & 0x07); =20 - value8 =3D (rtw_read8(padapter, REG_MCUFWDL+2) & 0xF8) | u8Page; - rtw_write8(padapter, REG_MCUFWDL+2, value8); + value8 =3D (rtw_read8(padapter, REG_MCUFWDL + 2) & 0xF8) | u8Page; + rtw_write8(padapter, REG_MCUFWDL + 2, value8); =20 return _BlockWrite(padapter, buffer, size); } @@ -124,7 +124,7 @@ static int _WriteFW(struct adapter *padapter, void *buf= fer, u32 size) =20 for (page =3D 0; page < pageNums; page++) { offset =3D page * MAX_DLFW_PAGE_SIZE; - ret =3D _PageWrite(padapter, page, bufferPtr+offset, MAX_DLFW_PAGE_SIZE); + ret =3D _PageWrite(padapter, page, bufferPtr + offset, MAX_DLFW_PAGE_SIZ= E); =20 if (ret =3D=3D _FAIL) { netdev_dbg(padapter->pnetdev, "page write failed at %s %d\n", @@ -136,7 +136,7 @@ static int _WriteFW(struct adapter *padapter, void *buf= fer, u32 size) if (remainSize) { offset =3D pageNums * MAX_DLFW_PAGE_SIZE; page =3D pageNums; - ret =3D _PageWrite(padapter, page, bufferPtr+offset, remainSize); + ret =3D _PageWrite(padapter, page, bufferPtr + offset, remainSize); =20 if (ret =3D=3D _FAIL) { netdev_dbg(padapter->pnetdev, "remaining page write failed at %s %d\n", @@ -195,7 +195,7 @@ static s32 polling_fwdl_chksum( if (value32 & FWDL_ChkSum_rpt || adapter->bSurpriseRemoved || adapter->b= DriverStopped) break; yield(); - } while (jiffies_to_msecs(jiffies-start) < timeout_ms || cnt < min_cnt); + } while (jiffies_to_msecs(jiffies - start) < timeout_ms || cnt < min_cnt); =20 if (!(value32 & FWDL_ChkSum_rpt)) { goto exit; @@ -266,7 +266,7 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padapte= r) !(IS_FW_81xxC(padapter) && ((pHalData->FirmwareVersion < 0x21) || (pHalD= ata->FirmwareVersion =3D=3D 0x21 && pHalData->FirmwareSubVersion < 0x01))) ) { /* after 88C Fw v33.1 */ /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ - rtw_write8(padapter, REG_HMETFR+3, 0x20); + rtw_write8(padapter, REG_HMETFR + 3, 0x20); =20 val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); while (val & BIT2) { @@ -394,7 +394,7 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapter,= bool bUsedWoWLANFw) (write_fw++ < 3 || jiffies_to_msecs(jiffies - fwdl_start_time) < 500) ) { /* reset FWDL chksum */ - rtw_write8(padapter, REG_MCUFWDL, rtw_read8(padapter, REG_MCUFWDL)|FWDL_= ChkSum_rpt); + rtw_write8(padapter, REG_MCUFWDL, rtw_read8(padapter, REG_MCUFWDL) | FWD= L_ChkSum_rpt); =20 rtStatus =3D _WriteFW(padapter, pFirmwareBuf, FirmwareLen); if (rtStatus !=3D _SUCCESS) @@ -507,9 +507,9 @@ void Hal_GetEfuseDefinition( u16 *pu2Tmp =3D pOut; =20 if (efuseType =3D=3D EFUSE_WIFI) - *pu2Tmp =3D (EFUSE_REAL_CONTENT_LEN_8723B-EFUSE_OOB_PROTECT_BYTES); + *pu2Tmp =3D (EFUSE_REAL_CONTENT_LEN_8723B - EFUSE_OOB_PROTECT_BYTES); else - *pu2Tmp =3D (EFUSE_BT_REAL_BANK_CONTENT_LEN-EFUSE_PROTECT_BYTES_BANK); + *pu2Tmp =3D (EFUSE_BT_REAL_BANK_CONTENT_LEN - EFUSE_PROTECT_BYTES_BANK= ); } break; =20 @@ -518,9 +518,9 @@ void Hal_GetEfuseDefinition( u16 *pu2Tmp =3D pOut; =20 if (efuseType =3D=3D EFUSE_WIFI) - *pu2Tmp =3D (EFUSE_REAL_CONTENT_LEN_8723B-EFUSE_OOB_PROTECT_BYTES); + *pu2Tmp =3D (EFUSE_REAL_CONTENT_LEN_8723B - EFUSE_OOB_PROTECT_BYTES); else - *pu2Tmp =3D (EFUSE_BT_REAL_CONTENT_LEN-(EFUSE_PROTECT_BYTES_BANK*3)); + *pu2Tmp =3D (EFUSE_BT_REAL_CONTENT_LEN - (EFUSE_PROTECT_BYTES_BANK * 3= )); } break; =20 @@ -577,17 +577,17 @@ void Hal_EfusePowerSwitch( if (PwrState) { /* To avoid cannot access efuse registers after disable/enable several = times during DTM test. */ /* Suggested by SD1 IsaacHsu. 2013.07.08, added by tynli. */ - tempval =3D rtw_read8(padapter, SDIO_LOCAL_BASE|SDIO_REG_HSUS_CTRL); + tempval =3D rtw_read8(padapter, SDIO_LOCAL_BASE | SDIO_REG_HSUS_CTRL); if (tempval & BIT(0)) { /* SDIO local register is suspend */ u8 count =3D 0; =20 =20 tempval &=3D ~BIT(0); - rtw_write8(padapter, SDIO_LOCAL_BASE|SDIO_REG_HSUS_CTRL, tempval); + rtw_write8(padapter, SDIO_LOCAL_BASE | SDIO_REG_HSUS_CTRL, tempval); =20 /* check 0x86[1:0]=3D 10'2h, wait power state to leave suspend */ do { - tempval =3D rtw_read8(padapter, SDIO_LOCAL_BASE|SDIO_REG_HSUS_CTRL); + tempval =3D rtw_read8(padapter, SDIO_LOCAL_BASE | SDIO_REG_HSUS_CTRL); tempval &=3D 0x3; if (tempval =3D=3D 0x02) break; @@ -677,28 +677,28 @@ static void hal_ReadEFuse_WiFi( addr =3D offset * PGPKT_DATA_SIZE; for (i =3D 0; i < EFUSE_MAX_WORD_UNIT; i++) { /* Check word enable condition in the section */ - if (!(wden & (0x01<>CHIP_VER_RTL_SH= IFT; /* IC version (CUT) */ + ChipVersion.CUTVersion =3D (value32 & CHIP_VER_RTL_MASK) >> CHIP_VER_RTL_= SHIFT; /* IC version (CUT) */ =20 /* For regulator mode. by tynli. 2011.01.14 */ pHalData->RegulatorMode =3D ((value32 & SPS_SEL) ? RT_LDO_REGULATOR : RT_= SWITCHING_REGULATOR); @@ -892,20 +892,20 @@ void rtl8723b_InitBeaconParameters(struct adapter *pa= dapter) =20 pHalData->RegBcnCtrlVal =3D rtw_read8(padapter, REG_BCN_CTRL); pHalData->RegTxPause =3D rtw_read8(padapter, REG_TXPAUSE); - pHalData->RegFwHwTxQCtrl =3D rtw_read8(padapter, REG_FWHW_TXQ_CTRL+2); - pHalData->RegReg542 =3D rtw_read8(padapter, REG_TBTT_PROHIBIT+2); - pHalData->RegCR_1 =3D rtw_read8(padapter, REG_CR+1); + pHalData->RegFwHwTxQCtrl =3D rtw_read8(padapter, REG_FWHW_TXQ_CTRL + 2); + pHalData->RegReg542 =3D rtw_read8(padapter, REG_TBTT_PROHIBIT + 2); + pHalData->RegCR_1 =3D rtw_read8(padapter, REG_CR + 1); } =20 void _InitBurstPktLen_8723BS(struct adapter *Adapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); =20 - rtw_write8(Adapter, 0x4c7, rtw_read8(Adapter, 0x4c7)|BIT(7)); /* enable s= ingle pkt ampdu */ + rtw_write8(Adapter, 0x4c7, rtw_read8(Adapter, 0x4c7) | BIT(7)); /* enable= single pkt ampdu */ rtw_write8(Adapter, REG_RX_PKT_LIMIT_8723B, 0x18); /* for VHT packet len= gth 11K */ rtw_write8(Adapter, REG_MAX_AGGR_NUM_8723B, 0x1F); rtw_write8(Adapter, REG_PIFS_8723B, 0x00); - rtw_write8(Adapter, REG_FWHW_TXQ_CTRL_8723B, rtw_read8(Adapter, REG_FWHW_= TXQ_CTRL)&(~BIT(7))); + rtw_write8(Adapter, REG_FWHW_TXQ_CTRL_8723B, rtw_read8(Adapter, REG_FWHW_= TXQ_CTRL) & (~BIT(7))); if (pHalData->AMPDUBurstMode) rtw_write8(Adapter, REG_AMPDU_BURST_MODE_8723B, 0x5F); rtw_write8(Adapter, REG_AMPDU_MAX_TIME_8723B, 0x70); @@ -913,13 +913,13 @@ void _InitBurstPktLen_8723BS(struct adapter *Adapter) /* ARFB table 9 for 11ac 5G 2SS */ rtw_write32(Adapter, REG_ARFR0_8723B, 0x00000010); if (IS_NORMAL_CHIP(pHalData->VersionID)) - rtw_write32(Adapter, REG_ARFR0_8723B+4, 0xfffff000); + rtw_write32(Adapter, REG_ARFR0_8723B + 4, 0xfffff000); else - rtw_write32(Adapter, REG_ARFR0_8723B+4, 0x3e0ff000); + rtw_write32(Adapter, REG_ARFR0_8723B + 4, 0x3e0ff000); =20 /* ARFB table 10 for 11ac 5G 1SS */ rtw_write32(Adapter, REG_ARFR1_8723B, 0x00000010); - rtw_write32(Adapter, REG_ARFR1_8723B+4, 0x003ff000); + rtw_write32(Adapter, REG_ARFR1_8723B + 4, 0x003ff000); } =20 static void ResumeTxBeacon(struct adapter *padapter) @@ -927,10 +927,10 @@ static void ResumeTxBeacon(struct adapter *padapter) struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); =20 pHalData->RegFwHwTxQCtrl |=3D BIT(6); - rtw_write8(padapter, REG_FWHW_TXQ_CTRL+2, pHalData->RegFwHwTxQCtrl); - rtw_write8(padapter, REG_TBTT_PROHIBIT+1, 0xff); + rtw_write8(padapter, REG_FWHW_TXQ_CTRL + 2, pHalData->RegFwHwTxQCtrl); + rtw_write8(padapter, REG_TBTT_PROHIBIT + 1, 0xff); pHalData->RegReg542 |=3D BIT(0); - rtw_write8(padapter, REG_TBTT_PROHIBIT+2, pHalData->RegReg542); + rtw_write8(padapter, REG_TBTT_PROHIBIT + 2, pHalData->RegReg542); } =20 static void StopTxBeacon(struct adapter *padapter) @@ -938,16 +938,16 @@ static void StopTxBeacon(struct adapter *padapter) struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); =20 pHalData->RegFwHwTxQCtrl &=3D ~BIT(6); - rtw_write8(padapter, REG_FWHW_TXQ_CTRL+2, pHalData->RegFwHwTxQCtrl); - rtw_write8(padapter, REG_TBTT_PROHIBIT+1, 0x64); + rtw_write8(padapter, REG_FWHW_TXQ_CTRL + 2, pHalData->RegFwHwTxQCtrl); + rtw_write8(padapter, REG_TBTT_PROHIBIT + 1, 0x64); pHalData->RegReg542 &=3D ~BIT(0); - rtw_write8(padapter, REG_TBTT_PROHIBIT+2, pHalData->RegReg542); + rtw_write8(padapter, REG_TBTT_PROHIBIT + 2, pHalData->RegReg542); } =20 static void _BeaconFunctionEnable(struct adapter *padapter, u8 Enable, u8 = Linked) { rtw_write8(padapter, REG_BCN_CTRL, DIS_TSF_UDT | EN_BCN_FUNCTION | DIS_BC= NQ_SUB); - rtw_write8(padapter, REG_RD_CTRL+1, 0x6F); + rtw_write8(padapter, REG_RD_CTRL + 1, 0x6F); } =20 void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter) @@ -998,7 +998,7 @@ void rtl8723b_SetBeaconRelatedRegisters(struct adapter = *padapter) rtw_write32(padapter, REG_TCR, value32); =20 /* NOTE: Fix test chip's bug (about contention windows's randomness) */ - if (check_fwstate(&padapter->mlmepriv, WIFI_ADHOC_STATE|WIFI_ADHOC_MASTER= _STATE|WIFI_AP_STATE) =3D=3D true) { + if (check_fwstate(&padapter->mlmepriv, WIFI_ADHOC_STATE | WIFI_ADHOC_MAST= ER_STATE | WIFI_AP_STATE) =3D=3D true) { rtw_write8(padapter, REG_RXTSF_OFFSET_CCK, 0x50); rtw_write8(padapter, REG_RXTSF_OFFSET_OFDM, 0x50); } @@ -1014,9 +1014,9 @@ void rtl8723b_SetBeaconRelatedRegisters(struct adapte= r *padapter) void hal_notch_filter_8723b(struct adapter *adapter, bool enable) { if (enable) - rtw_write8(adapter, rOFDM0_RxDSP+1, rtw_read8(adapter, rOFDM0_RxDSP+1) |= BIT1); + rtw_write8(adapter, rOFDM0_RxDSP + 1, rtw_read8(adapter, rOFDM0_RxDSP + = 1) | BIT1); else - rtw_write8(adapter, rOFDM0_RxDSP+1, rtw_read8(adapter, rOFDM0_RxDSP+1) &= ~BIT1); + rtw_write8(adapter, rOFDM0_RxDSP + 1, rtw_read8(adapter, rOFDM0_RxDSP + = 1) & ~BIT1); } =20 void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_le= vel) @@ -1107,11 +1107,11 @@ void rtl8723b_init_default_value(struct adapter *pa= dapter) memset(pHalData->EfuseHal.fakeEfuseModifiedMap, 0xFF, EFUSE_MAX_MAP_LEN); pHalData->EfuseHal.BTEfuseUsedBytes =3D 0; pHalData->EfuseHal.BTEfuseUsedPercentage =3D 0; - memset(pHalData->EfuseHal.BTEfuseContent, 0xFF, EFUSE_MAX_BT_BANK*EFUSE_M= AX_HW_SIZE); + memset(pHalData->EfuseHal.BTEfuseContent, 0xFF, EFUSE_MAX_BT_BANK * EFUSE= _MAX_HW_SIZE); memset(pHalData->EfuseHal.BTEfuseInitMap, 0xFF, EFUSE_BT_MAX_MAP_LEN); memset(pHalData->EfuseHal.BTEfuseModifiedMap, 0xFF, EFUSE_BT_MAX_MAP_LEN); pHalData->EfuseHal.fakeBTEfuseUsedBytes =3D 0; - memset(pHalData->EfuseHal.fakeBTEfuseContent, 0xFF, EFUSE_MAX_BT_BANK*EFU= SE_MAX_HW_SIZE); + memset(pHalData->EfuseHal.fakeBTEfuseContent, 0xFF, EFUSE_MAX_BT_BANK * E= FUSE_MAX_HW_SIZE); memset(pHalData->EfuseHal.fakeBTEfuseInitMap, 0xFF, EFUSE_BT_MAX_MAP_LEN); memset(pHalData->EfuseHal.fakeBTEfuseModifiedMap, 0xFF, EFUSE_BT_MAX_MAP_= LEN); #endif @@ -1221,7 +1221,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( =20 memset(pwrInfo24G, 0, sizeof(struct TxPowerInfo24G)); =20 - if (0xFF =3D=3D PROMContent[eeAddr+1]) + if (0xFF =3D=3D PROMContent[eeAddr + 1]) AutoLoadFail =3D true; =20 if (AutoLoadFail) { @@ -1258,7 +1258,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( pwrInfo24G->IndexCCK_Base[rfPath][group] =3D EEPROM_DEFAULT_24G_INDEX; } =20 - for (group =3D 0; group < MAX_CHNL_GROUP_24G-1; group++) { + for (group =3D 0; group < MAX_CHNL_GROUP_24G - 1; group++) { pwrInfo24G->IndexBW40_Base[rfPath][group] =3D PROMContent[eeAddr++]; if (pwrInfo24G->IndexBW40_Base[rfPath][group] =3D=3D 0xFF) pwrInfo24G->IndexBW40_Base[rfPath][group] =3D EEPROM_DEFAULT_24G_INDEX; @@ -1270,7 +1270,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( if (PROMContent[eeAddr] =3D=3D 0xFF) pwrInfo24G->BW20_Diff[rfPath][TxCount] =3D EEPROM_DEFAULT_24G_HT20_DI= FF; else { - pwrInfo24G->BW20_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr]&0xf0)= >>4; + pwrInfo24G->BW20_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr] & 0xf= 0) >> 4; if (pwrInfo24G->BW20_Diff[rfPath][TxCount] & BIT3) /* 4bit sign numb= er to 8 bit sign number */ pwrInfo24G->BW20_Diff[rfPath][TxCount] |=3D 0xF0; } @@ -1278,7 +1278,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( if (PROMContent[eeAddr] =3D=3D 0xFF) pwrInfo24G->OFDM_Diff[rfPath][TxCount] =3D EEPROM_DEFAULT_24G_OFDM_DI= FF; else { - pwrInfo24G->OFDM_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr]&0x0f); + pwrInfo24G->OFDM_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr] & 0x0= f); if (pwrInfo24G->OFDM_Diff[rfPath][TxCount] & BIT3) /* 4bit sign numb= er to 8 bit sign number */ pwrInfo24G->OFDM_Diff[rfPath][TxCount] |=3D 0xF0; } @@ -1288,7 +1288,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( if (PROMContent[eeAddr] =3D=3D 0xFF) pwrInfo24G->BW40_Diff[rfPath][TxCount] =3D EEPROM_DEFAULT_DIFF; else { - pwrInfo24G->BW40_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr]&0xf0)= >>4; + pwrInfo24G->BW40_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr] & 0xf= 0) >> 4; if (pwrInfo24G->BW40_Diff[rfPath][TxCount] & BIT3) /* 4bit sign numb= er to 8 bit sign number */ pwrInfo24G->BW40_Diff[rfPath][TxCount] |=3D 0xF0; } @@ -1296,7 +1296,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( if (PROMContent[eeAddr] =3D=3D 0xFF) pwrInfo24G->BW20_Diff[rfPath][TxCount] =3D EEPROM_DEFAULT_DIFF; else { - pwrInfo24G->BW20_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr]&0x0f); + pwrInfo24G->BW20_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr] & 0x0= f); if (pwrInfo24G->BW20_Diff[rfPath][TxCount] & BIT3) /* 4bit sign numb= er to 8 bit sign number */ pwrInfo24G->BW20_Diff[rfPath][TxCount] |=3D 0xF0; } @@ -1305,7 +1305,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( if (PROMContent[eeAddr] =3D=3D 0xFF) pwrInfo24G->OFDM_Diff[rfPath][TxCount] =3D EEPROM_DEFAULT_DIFF; else { - pwrInfo24G->OFDM_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr]&0xf0)= >>4; + pwrInfo24G->OFDM_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr] & 0xf= 0) >> 4; if (pwrInfo24G->OFDM_Diff[rfPath][TxCount] & BIT3) /* 4bit sign numb= er to 8 bit sign number */ pwrInfo24G->OFDM_Diff[rfPath][TxCount] |=3D 0xF0; } @@ -1313,7 +1313,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( if (PROMContent[eeAddr] =3D=3D 0xFF) pwrInfo24G->CCK_Diff[rfPath][TxCount] =3D EEPROM_DEFAULT_DIFF; else { - pwrInfo24G->CCK_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr]&0x0f); + pwrInfo24G->CCK_Diff[rfPath][TxCount] =3D (PROMContent[eeAddr] & 0x0f= ); if (pwrInfo24G->CCK_Diff[rfPath][TxCount] & BIT3) /* 4bit sign numbe= r to 8 bit sign number */ pwrInfo24G->CCK_Diff[rfPath][TxCount] |=3D 0xF0; } @@ -1339,7 +1339,7 @@ void Hal_EfuseParseTxPowerInfo_8723B( =20 hal_get_chnl_group_8723b(ch + 1, &group); =20 - if (ch =3D=3D 14-1) { + if (ch =3D=3D 14 - 1) { pHalData->Index24G_CCK_Base[rfPath][ch] =3D pwrInfo24G.IndexCCK_Base[r= fPath][5]; pHalData->Index24G_BW40_Base[rfPath][ch] =3D pwrInfo24G.IndexBW40_Base= [rfPath][group]; } else { @@ -1358,9 +1358,9 @@ void Hal_EfuseParseTxPowerInfo_8723B( =20 /* 2010/10/19 MH Add Regulator recognize for CU. */ if (!AutoLoadFail) { - pHalData->EEPROMRegulatory =3D (PROMContent[EEPROM_RF_BOARD_OPTION_8723B= ]&0x7); /* bit0~2 */ + pHalData->EEPROMRegulatory =3D (PROMContent[EEPROM_RF_BOARD_OPTION_8723B= ] & 0x7); /* bit0~2 */ if (PROMContent[EEPROM_RF_BOARD_OPTION_8723B] =3D=3D 0xFF) - pHalData->EEPROMRegulatory =3D (EEPROM_DEFAULT_BOARD_OPTION&0x7); /* bi= t0~2 */ + pHalData->EEPROMRegulatory =3D (EEPROM_DEFAULT_BOARD_OPTION & 0x7); /* = bit0~2 */ } else pHalData->EEPROMRegulatory =3D 0; } @@ -1953,16 +1953,16 @@ static void hw_var_set_opmode(struct adapter *padap= ter, u8 variable, u8 *val) } =20 /* disable atim wnd */ - rtw_write8(padapter, REG_BCN_CTRL, DIS_TSF_UDT|EN_BCN_FUNCTION|DIS_ATIM= ); + rtw_write8(padapter, REG_BCN_CTRL, DIS_TSF_UDT | EN_BCN_FUNCTION | DIS_= ATIM); /* rtw_write8(padapter, REG_BCN_CTRL, 0x18); */ } else if (mode =3D=3D _HW_STATE_ADHOC_) { ResumeTxBeacon(padapter); - rtw_write8(padapter, REG_BCN_CTRL, DIS_TSF_UDT|EN_BCN_FUNCTION|DIS_BCNQ= _SUB); + rtw_write8(padapter, REG_BCN_CTRL, DIS_TSF_UDT | EN_BCN_FUNCTION | DIS_= BCNQ_SUB); } else if (mode =3D=3D _HW_STATE_AP_) { =20 ResumeTxBeacon(padapter); =20 - rtw_write8(padapter, REG_BCN_CTRL, DIS_TSF_UDT|DIS_BCNQ_SUB); + rtw_write8(padapter, REG_BCN_CTRL, DIS_TSF_UDT | DIS_BCNQ_SUB); =20 /* Set RCR */ rtw_write32(padapter, REG_RCR, 0x7000208e);/* CBSSID_DATA must set to 0= , reject ICV_ERR packet */ @@ -1985,7 +1985,7 @@ static void hw_var_set_opmode(struct adapter *padapte= r, u8 variable, u8 *val) =20 /* enable BCN0 Function for if1 */ /* don't enable update TSF0 for if1 (due to TSF update when beacon/prob= e rsp are received) */ - rtw_write8(padapter, REG_BCN_CTRL, (DIS_TSF_UDT|EN_BCN_FUNCTION|EN_TXBC= N_RPT|DIS_BCNQ_SUB)); + rtw_write8(padapter, REG_BCN_CTRL, (DIS_TSF_UDT | EN_BCN_FUNCTION | EN_= TXBCN_RPT | DIS_BCNQ_SUB)); =20 /* SW_BCN_SEL - Port0 */ /* rtw_write8(Adapter, REG_DWBCN1_CTRL_8192E+2, rtw_read8(Adapter, REG_= DWBCN1_CTRL_8192E+2) & ~BIT4); */ @@ -1995,7 +1995,7 @@ static void hw_var_set_opmode(struct adapter *padapte= r, u8 variable, u8 *val) rtw_write8( padapter, REG_CCK_CHECK_8723B, - (rtw_read8(padapter, REG_CCK_CHECK_8723B)&~BIT_BCN_PORT_SEL) + (rtw_read8(padapter, REG_CCK_CHECK_8723B) & ~BIT_BCN_PORT_SEL) ); =20 /* dis BCN1 ATIM WND if if2 is station */ @@ -2012,7 +2012,7 @@ static void hw_var_set_macaddr(struct adapter *padapt= er, u8 variable, u8 *val) u32 reg_macid =3D REG_MACID; =20 for (idx =3D 0 ; idx < 6; idx++) - rtw_write8(GET_PRIMARY_ADAPTER(padapter), (reg_macid+idx), val[idx]); + rtw_write8(GET_PRIMARY_ADAPTER(padapter), (reg_macid + idx), val[idx]); } =20 static void hw_var_set_bssid(struct adapter *padapter, u8 variable, u8 *va= l) @@ -2021,7 +2021,7 @@ static void hw_var_set_bssid(struct adapter *padapter= , u8 variable, u8 *val) u32 reg_bssid =3D REG_BSSID; =20 for (idx =3D 0 ; idx < 6; idx++) - rtw_write8(padapter, (reg_bssid+idx), val[idx]); + rtw_write8(padapter, (reg_bssid + idx), val[idx]); } =20 static void hw_var_set_bcn_func(struct adapter *padapter, u8 variable, u8 = *val) @@ -2051,11 +2051,11 @@ static void hw_var_set_correct_tsf(struct adapter *= padapter, u8 variable, u8 *va struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 - tsf =3D pmlmeext->TSFValue-do_div(pmlmeext->TSFValue, (pmlmeinfo->bcn_int= erval*1024))-1024; /* us */ + tsf =3D pmlmeext->TSFValue - do_div(pmlmeext->TSFValue, (pmlmeinfo->bcn_i= nterval * 1024)) - 1024; /* us */ =20 if ( - ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_ADHOC_STATE) || - ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) + ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) || + ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) ) StopTxBeacon(padapter); =20 @@ -2066,7 +2066,7 @@ static void hw_var_set_correct_tsf(struct adapter *pa= dapter, u8 variable, u8 *va rtw_write8(padapter, REG_BCN_CTRL, val8); =20 rtw_write32(padapter, REG_TSFTR, tsf); - rtw_write32(padapter, REG_TSFTR+4, tsf>>32); + rtw_write32(padapter, REG_TSFTR + 4, tsf >> 32); =20 /* enable related TSF function */ val8 =3D rtw_read8(padapter, REG_BCN_CTRL); @@ -2075,8 +2075,8 @@ static void hw_var_set_correct_tsf(struct adapter *pa= dapter, u8 variable, u8 *va } =20 if ( - ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_ADHOC_STATE) || - ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) + ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) || + ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) ) ResumeTxBeacon(padapter); } @@ -2141,7 +2141,7 @@ static void hw_var_set_mlme_sitesurvey(struct adapter= *padapter, u8 variable, u8 pHalData->RegRRSR =3D rtw_read16(padapter, REG_RRSR); } else { /* sitesurvey done */ - if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE))) + if (check_fwstate(pmlmepriv, (_FW_LINKED | WIFI_AP_STATE))) /* enable to rx data frame */ rtw_write16(padapter, REG_RXFLTMAP2, 0xFFFF); =20 @@ -2182,7 +2182,7 @@ static void hw_var_set_mlme_join(struct adapter *pada= pter, u8 variable, u8 *val) if (padapter->in_cta_test) val32 &=3D ~(RCR_CBSSID_DATA | RCR_CBSSID_BCN);/* RCR_ADF */ else - val32 |=3D RCR_CBSSID_DATA|RCR_CBSSID_BCN; + val32 |=3D RCR_CBSSID_DATA | RCR_CBSSID_BCN; rtw_write32(padapter, REG_RCR, val32); =20 if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) @@ -2197,7 +2197,7 @@ static void hw_var_set_mlme_join(struct adapter *pada= pter, u8 variable, u8 *val) val8 &=3D ~DIS_TSF_UDT; rtw_write8(padapter, REG_BCN_CTRL, val8); =20 - if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE|WIFI_ADHOC_MASTER_STATE)) + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE | WIFI_ADHOC_MASTER_STATE)) RetryLimit =3D 0x7; } =20 @@ -2320,8 +2320,8 @@ void C2HPacketHandler_8723B(struct adapter *padapter,= u8 *pbuffer, u16 length) =20 C2hEvent.CmdID =3D pbuffer[0]; C2hEvent.CmdSeq =3D pbuffer[1]; - C2hEvent.CmdLen =3D length-2; - tmpBuf =3D pbuffer+2; + C2hEvent.CmdLen =3D length - 2; + tmpBuf =3D pbuffer + 2; =20 process_c2h_event(padapter, &C2hEvent, tmpBuf); /* c2h_handler_8723b(padapter,&C2hEvent); */ @@ -2362,8 +2362,8 @@ void SetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) { struct mlme_ext_info *mlmext_info =3D &padapter->mlmeextpriv.mlmext_info; u16 BrateCfg =3D 0; - u16 rrsr_2g_force_mask =3D (RRSR_11M|RRSR_5_5M|RRSR_1M); - u16 rrsr_2g_allow_mask =3D (RRSR_24M|RRSR_12M|RRSR_6M|RRSR_CCK_RATES); + u16 rrsr_2g_force_mask =3D (RRSR_11M | RRSR_5_5M | RRSR_1M); + u16 rrsr_2g_allow_mask =3D (RRSR_24M | RRSR_12M | RRSR_6M | RRSR_CCK_RAT= ES); =20 HalSetBrateCfg(padapter, val, &BrateCfg); =20 @@ -2374,7 +2374,7 @@ void SetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) /* IOT consideration */ if (mlmext_info->assoc_AP_vendor =3D=3D HT_IOT_PEER_CISCO) { /* if peer is cisco and didn't use ofdm rate, we enable 6M ack */ - if ((BrateCfg & (RRSR_24M|RRSR_12M|RRSR_6M)) =3D=3D 0) + if ((BrateCfg & (RRSR_24M | RRSR_12M | RRSR_6M)) =3D=3D 0) BrateCfg |=3D RRSR_6M; } =20 @@ -2382,7 +2382,7 @@ void SetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) =20 /* Set RRSR rate table. */ rtw_write16(padapter, REG_RRSR, BrateCfg); - rtw_write8(padapter, REG_RRSR+2, rtw_read8(padapter, REG_RRSR+2)&0xf0); + rtw_write8(padapter, REG_RRSR + 2, rtw_read8(padapter, REG_RRSR + 2) & 0= xf0); } break; =20 @@ -2404,9 +2404,9 @@ void SetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) =20 val32 =3D rtw_read32(padapter, REG_RCR); if (*val) - val32 |=3D RCR_CBSSID_DATA|RCR_CBSSID_BCN; + val32 |=3D RCR_CBSSID_DATA | RCR_CBSSID_BCN; else - val32 &=3D ~(RCR_CBSSID_DATA|RCR_CBSSID_BCN); + val32 &=3D ~(RCR_CBSSID_DATA | RCR_CBSSID_BCN); rtw_write32(padapter, REG_RCR, val32); } break; @@ -2418,7 +2418,7 @@ void SetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) case HW_VAR_MLME_SITESURVEY: hw_var_set_mlme_sitesurvey(padapter, variable, val); =20 - hal_btcoex_ScanNotify(padapter, *val?true:false); + hal_btcoex_ScanNotify(padapter, *val ? true : false); break; =20 case HW_VAR_MLME_JOIN: @@ -2464,10 +2464,10 @@ void SetHwReg8723B(struct adapter *padapter, u8 var= iable, u8 *val) /* SIFS_Timer =3D 0x0a0a0808; */ /* RESP_SIFS for CCK */ rtw_write8(padapter, REG_RESP_SIFS_CCK, val[0]); /* SIFS_T2T_CCK (0x08)= */ - rtw_write8(padapter, REG_RESP_SIFS_CCK+1, val[1]); /* SIFS_R2T_CCK(0x08)= */ + rtw_write8(padapter, REG_RESP_SIFS_CCK + 1, val[1]); /* SIFS_R2T_CCK(0x0= 8) */ /* RESP_SIFS for OFDM */ rtw_write8(padapter, REG_RESP_SIFS_OFDM, val[2]); /* SIFS_T2T_OFDM (0x0a= ) */ - rtw_write8(padapter, REG_RESP_SIFS_OFDM+1, val[3]); /* SIFS_R2T_OFDM(0x0= a) */ + rtw_write8(padapter, REG_RESP_SIFS_OFDM + 1, val[3]); /* SIFS_R2T_OFDM(0= x0a) */ break; =20 case HW_VAR_ACK_PREAMBLE: @@ -2479,7 +2479,7 @@ void SetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) /* regTmp =3D (pHalData->nCur40MhzPrimeSC)<<5; */ if (bShortPreamble) regTmp |=3D 0x80; - rtw_write8(padapter, REG_RRSR+2, regTmp); + rtw_write8(padapter, REG_RRSR + 2, regTmp); } break; =20 @@ -2494,13 +2494,13 @@ void SetHwReg8723B(struct adapter *padapter, u8 var= iable, u8 *val) for (i =3D 0; i < CAM_CONTENT_COUNT; i++) { /* filled id in CAM config 2 byte */ if (i =3D=3D 0) { - ulContent |=3D (ucIndex & 0x03) | ((u16)(ulEncAlgo)<<2); + ulContent |=3D (ucIndex & 0x03) | ((u16)(ulEncAlgo) << 2); /* ulContent |=3D CAM_VALID; */ } else ulContent =3D 0; =20 /* polling bit, and No Write enable, and address */ - ulCommand =3D CAM_CONTENT_COUNT*ucIndex+i; + ulCommand =3D CAM_CONTENT_COUNT * ucIndex + i; ulCommand =3D ulCommand | CAM_POLLINIG | CAM_WRITE; /* write content 0 is equal to mark as invalid */ rtw_write32(padapter, WCAMI, ulContent); /* mdelay(40); */ @@ -2510,7 +2510,7 @@ void SetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) break; =20 case HW_VAR_CAM_INVALID_ALL: - rtw_write32(padapter, RWCAM, BIT(31)|BIT(30)); + rtw_write32(padapter, RWCAM, BIT(31) | BIT(30)); break; =20 case HW_VAR_CAM_WRITE: @@ -2569,7 +2569,7 @@ void SetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) u32 AMPDULen =3D (*((u8 *)val)); =20 if (AMPDULen < HT_AGG_SIZE_32K) - AMPDULen =3D (0x2000 << (*((u8 *)val)))-1; + AMPDULen =3D (0x2000 << (*((u8 *)val))) - 1; else AMPDULen =3D 0x7fff; =20 @@ -2695,7 +2695,7 @@ void SetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) u16 mstatus_rpt =3D (*(u16 *)val); u8 mstatus, macId; =20 - mstatus =3D (u8) (mstatus_rpt & 0xFF); + mstatus =3D (u8)(mstatus_rpt & 0xFF); macId =3D (u8)(mstatus_rpt >> 8); rtl8723b_set_FwMediaStatusRpt_cmd(padapter, mstatus, macId); } @@ -2703,18 +2703,18 @@ void SetHwReg8723B(struct adapter *padapter, u8 var= iable, u8 *val) case HW_VAR_BCN_VALID: { /* BCN_VALID, BIT16 of REG_TDECTRL =3D BIT0 of REG_TDECTRL+2, write 1 = to clear, Clear by sw */ - val8 =3D rtw_read8(padapter, REG_TDECTRL+2); + val8 =3D rtw_read8(padapter, REG_TDECTRL + 2); val8 |=3D BIT(0); - rtw_write8(padapter, REG_TDECTRL+2, val8); + rtw_write8(padapter, REG_TDECTRL + 2, val8); } break; =20 case HW_VAR_DL_BCN_SEL: { /* SW_BCN_SEL - Port0 */ - val8 =3D rtw_read8(padapter, REG_DWBCN1_CTRL_8723B+2); + val8 =3D rtw_read8(padapter, REG_DWBCN1_CTRL_8723B + 2); val8 &=3D ~BIT(4); - rtw_write8(padapter, REG_DWBCN1_CTRL_8723B+2, val8); + rtw_write8(padapter, REG_DWBCN1_CTRL_8723B + 2, val8); } break; =20 @@ -2779,7 +2779,7 @@ void GetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) case HW_VAR_BCN_VALID: { /* BCN_VALID, BIT16 of REG_TDECTRL =3D BIT0 of REG_TDECTRL+2 */ - val8 =3D rtw_read8(padapter, REG_TDECTRL+2); + val8 =3D rtw_read8(padapter, REG_TDECTRL + 2); *val =3D (BIT(0) & val8) ? true : false; } break; @@ -2855,7 +2855,7 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum h= al_def_variable variable, v break; =20 case HAL_DEF_RX_PACKET_OFFSET: - *((u32 *)pval) =3D RXDESC_SIZE + DRVINFO_SZ*8; + *((u32 *)pval) =3D RXDESC_SIZE + DRVINFO_SZ * 8; break; =20 case HW_VAR_MAX_RX_AMPDU_FACTOR: diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/stag= ing/rtl8723bs/hal/rtl8723b_phycfg.c index 7fac1c2ba8e0..51e9f06b2c63 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -19,7 +19,7 @@ static u32 phy_CalculateBitShift(u32 BitMask) u32 i; =20 for (i =3D 0; i <=3D 31; i++) { - if (((BitMask>>i) & 0x1) =3D=3D 1) + if (((BitMask >> i) & 0x1) =3D=3D 1) break; } return i; @@ -109,18 +109,18 @@ static u32 phy_RFSerialRead_8723B( NewOffset =3D Offset; =20 if (eRFPath =3D=3D RF_PATH_A) { - tmplong2 =3D PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhy= Set, bMaskDWord); - tmplong2 =3D (tmplong2 & (~bLSSIReadAddress)) | (NewOffset<<23) | bLSSIR= eadEdge; /* T65 RF */ - PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord= , tmplong2&(~bLSSIReadEdge)); + tmplong2 =3D PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforP= hySet, bMaskDWord); + tmplong2 =3D (tmplong2 & (~bLSSIReadAddress)) | (NewOffset << 23) | bLSS= IReadEdge; /* T65 RF */ + PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWo= rd, tmplong2 & (~bLSSIReadEdge)); } else { - tmplong2 =3D PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter2|MaskforPhy= Set, bMaskDWord); - tmplong2 =3D (tmplong2 & (~bLSSIReadAddress)) | (NewOffset<<23) | bLSSIR= eadEdge; /* T65 RF */ - PHY_SetBBReg(Adapter, rFPGA0_XB_HSSIParameter2|MaskforPhySet, bMaskDWord= , tmplong2&(~bLSSIReadEdge)); + tmplong2 =3D PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter2 | MaskforP= hySet, bMaskDWord); + tmplong2 =3D (tmplong2 & (~bLSSIReadAddress)) | (NewOffset << 23) | bLSS= IReadEdge; /* T65 RF */ + PHY_SetBBReg(Adapter, rFPGA0_XB_HSSIParameter2 | MaskforPhySet, bMaskDWo= rd, tmplong2 & (~bLSSIReadEdge)); } =20 - tmplong2 =3D PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhyS= et, bMaskDWord); - PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord,= tmplong2 & (~bLSSIReadEdge)); - PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord,= tmplong2 | bLSSIReadEdge); + tmplong2 =3D PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPh= ySet, bMaskDWord); + PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWor= d, tmplong2 & (~bLSSIReadEdge)); + PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWor= d, tmplong2 | bLSSIReadEdge); =20 udelay(10); =20 @@ -129,16 +129,16 @@ static u32 phy_RFSerialRead_8723B( udelay(10); =20 if (eRFPath =3D=3D RF_PATH_A) - RfPiEnable =3D (u8)PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter1|Mask= forPhySet, BIT8); + RfPiEnable =3D (u8)PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter1 | Ma= skforPhySet, BIT8); else if (eRFPath =3D=3D RF_PATH_B) - RfPiEnable =3D (u8)PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter1|Mask= forPhySet, BIT8); + RfPiEnable =3D (u8)PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter1 | Ma= skforPhySet, BIT8); =20 if (RfPiEnable) { /* Read from BBreg8b8, 12 bits for 8190, 20bits for T65 RF */ - retValue =3D PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBackPi|MaskforPh= ySet, bLSSIReadBackData); + retValue =3D PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBackPi | Maskfor= PhySet, bLSSIReadBackData); } else { /* Read from BBreg8a0, 12 bits for 8190, 20 bits for T65 RF */ - retValue =3D PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBack|MaskforPhyS= et, bLSSIReadBackData); + retValue =3D PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBack | MaskforPh= ySet, bLSSIReadBackData); } return retValue; =20 @@ -203,7 +203,7 @@ static void phy_RFSerialWrite_8723B( /* */ /* Put write addr in [5:0] and write data in [31:16] */ /* */ - DataAndAddr =3D ((NewOffset<<20) | (Data&0x000fffff)) & 0x0fffffff; /* T= 65 RF */ + DataAndAddr =3D ((NewOffset << 20) | (Data & 0x000fffff)) & 0x0fffffff; /= * T65 RF */ /* */ /* Write Operation */ /* */ @@ -266,7 +266,7 @@ void PHY_SetRFReg_8723B( if (BitMask !=3D bRFRegOffsetMask) { Original_Value =3D phy_RFSerialRead_8723B(Adapter, eRFPath, RegAddr); BitShift =3D phy_CalculateBitShift(BitMask); - Data =3D ((Original_Value & (~BitMask)) | (Data< MAX_POWER_INDEX) txPower =3D MAX_POWER_INDEX; =20 - return (u8) txPower; + return (u8)txPower; } =20 void PHY_SetTxPowerLevel8723B(struct adapter *Adapter, u8 Channel) @@ -631,7 +631,7 @@ static void phy_PostSetBwMode8723B(struct adapter *Adap= ter) =20 PHY_SetBBReg(Adapter, rFPGA1_RFMOD, bRFMOD, 0x0); =20 - PHY_SetBBReg(Adapter, rOFDM0_TxPseudoNoiseWgt, (BIT31|BIT30), 0x0); + PHY_SetBBReg(Adapter, rOFDM0_TxPseudoNoiseWgt, (BIT31 | BIT30), 0x0); break; =20 /* 40 MHz channel*/ @@ -641,11 +641,11 @@ static void phy_PostSetBwMode8723B(struct adapter *Ad= apter) PHY_SetBBReg(Adapter, rFPGA1_RFMOD, bRFMOD, 0x1); =20 /* Set Control channel to upper or lower. These settings are required o= nly for 40MHz */ - PHY_SetBBReg(Adapter, rCCK0_System, bCCKSideBand, (pHalData->nCur40MhzPr= imeSC>>1)); + PHY_SetBBReg(Adapter, rCCK0_System, bCCKSideBand, (pHalData->nCur40MhzPr= imeSC >> 1)); =20 PHY_SetBBReg(Adapter, rOFDM1_LSTF, 0xC00, pHalData->nCur40MhzPrimeSC); =20 - PHY_SetBBReg(Adapter, 0x818, (BIT26|BIT27), (pHalData->nCur40MhzPrimeSC = =3D=3D HAL_PRIME_CHNL_OFFSET_LOWER) ? 2 : 1); + PHY_SetBBReg(Adapter, 0x818, (BIT26 | BIT27), (pHalData->nCur40MhzPrimeS= C =3D=3D HAL_PRIME_CHNL_OFFSET_LOWER) ? 2 : 1); break; default: break; diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_recv.c index cab4707091e2..0204a454c954 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c @@ -335,8 +335,8 @@ static void rtl8723bs_recv_tasklet(struct tasklet_struc= t *t) =20 C2hEvent.CmdID =3D pbuf_c2h[0]; C2hEvent.CmdSeq =3D pbuf_c2h[1]; - C2hEvent.CmdLen =3D (len_c2h-2); - pdata_c2h =3D pbuf_c2h+2; + C2hEvent.CmdLen =3D (len_c2h - 2); + pdata_c2h =3D pbuf_c2h + 2; =20 if (C2hEvent.CmdID =3D=3D C2H_CCX_TX_RPT) CCX_FwC2HTxRpt_8723b(padapter, pdata_c2h, C2hEvent.CmdLen); @@ -403,7 +403,7 @@ s32 rtl8723bs_init_recv_priv(struct adapter *padapter) precvbuf->pskb->dev =3D padapter->pnetdev; =20 tmpaddr =3D (SIZE_PTR)precvbuf->pskb->data; - alignment =3D tmpaddr & (RECVBUFF_ALIGN_SZ-1); + alignment =3D tmpaddr & (RECVBUFF_ALIGN_SZ - 1); skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment)); } } --=20 2.53.0 From nobody Thu Jun 11 22:58:33 2026 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAAC33AF66C for ; Mon, 13 Apr 2026 10:15:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075335; cv=none; b=Sw9M3ghZ7/VJYVJEPJHq69nFQBuyEu8hHJYRkCQHSPQZc/cyj8aNK3pgy7+DFdV3s77FzBYGSxQTyt6k0oLsFTSwqg0zaevRjyLc7oByTN6f+kvl+ARTAa58xy7ddQgl949a43JpbUhEeuDOINyLsqXpb5jqcXMT0P57f1LSylY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075335; c=relaxed/simple; bh=xLNyd4WSW7nzPFpMksReBLY/Hhxa5k3aSGb2bhAaukM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jpSJrtR4ccxPVBf6UY3UeY+uFIo7U/ij/B7Q4uDfNdnR9daQQNaXYPi2IVmTvgJbWmP74zhBP6+nFenveD1vUty+bDu6cNECB7gVrzj4HEWRoUbslJXrqNCPjiGgTBwvGAZs8MOQ89ZyLE2q628XGvOISTQf04EFC27WEXjBbz8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Uv16Q+Is; arc=none smtp.client-ip=91.218.175.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Uv16Q+Is" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776075331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RppUm66t3ATpe/wWI5LWZprHlIA2kT4A2uwhrHzVJm0=; b=Uv16Q+IscpgdSPP/NDjnYCPo468vIJtvjvKAhsZT6cmuC/aGifIFNU0Wg0Li9DSzCWqb7t pPpCN0MLmxT7619cv/GFQeeYkDZfQ8bdlHG0djrz3uZ+CzugLHtObhh5K/sqyHP58BQRoV IduBhDhC6ObIMeIImorf+2lDPzM6fc8= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Luka Gejak , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [PATCH 03/11] staging: rtl8723bs: os_dep: fix spacing around operators Date: Mon, 13 Apr 2026 12:14:24 +0200 Message-ID: <20260413101432.158925-4-luka.gejak@linux.dev> In-Reply-To: <20260413101432.158925-1-luka.gejak@linux.dev> References: <20260413101432.158925-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Luka Gejak Fix spaces around operators in the os_dep directory to adhere to the Linux kernel coding style. This resolves multiple spacing warnings reported by checkpatch.pl. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 +- drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index d0feb28b7043..95523c3a508b 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -77,7 +77,7 @@ static int sdio_alloc_irq(struct dvobj_priv *dvobj) =20 sdio_release_host(func); =20 - return err?_FAIL:_SUCCESS; + return err ? _FAIL : _SUCCESS; } =20 static void sdio_free_irq(struct dvobj_priv *dvobj) diff --git a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c b/drivers/staging= /rtl8723bs/os_dep/wifi_regd.c index f9c4d487badf..ce835802c442 100644 --- a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c +++ b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c @@ -93,7 +93,7 @@ static int _rtw_reg_notifier_apply(struct wiphy *wiphy, =20 static const struct ieee80211_regdomain *_rtw_regdomain_select(struct rtw_regulatory - *reg) + * reg) { return &rtw_regdom_rd; } --=20 2.53.0 From nobody Thu Jun 11 22:58:33 2026 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4D5B3B3884 for ; Mon, 13 Apr 2026 10:15:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075339; cv=none; b=kfo6vYwYtHbhWbYTdQtX2/jEF0Lx3v8OWl7WT/aX+7JkuWazSFSZqaYPXVsXvaR4R5scWjDUjq1OjHxmBfCsmaIAdYCq27hv37ogxORlXhYi2EcxbVGEV2MMkc2y06oxObUkdkCp1xegmwPJDIag7LTrDV0E2d3LHt7adNM41Uc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075339; c=relaxed/simple; bh=emc6D3jEqy6qPsOZgfdRUxtE7wbvgcte90k5c1eoxI4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lnt5fAi8li9bvNg2+78A0NPozEf0F3iJf77oMSIvM1EgG1Y/DnBaQ+zHSOz/DQV51tRIecpz7DcIzt9cPWTuwiopLurti6VG1jmHyRmnMf5YNRLESqzW40WV0t93H8xsA3eG/P4u6ohkMWF/ZkRzv6p69WSTM8VCW9wGCBqipfg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Vmpp+x/p; arc=none smtp.client-ip=91.218.175.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Vmpp+x/p" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776075335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vNzoVxqZiSskPMCrR1dOLfBNs9Eq55ztE3MK61PCZkQ=; b=Vmpp+x/prw73aC/7SCb6aZ3kzi1HnN2X/GI8NBJ8fdD7uL0/s23Zhzv2dKw0TpXqG54gfy 9ZFlnU3/4rnW/YVNInByhGjvkdOlQ4zX6tgFLadR11Uln9UenctlvT5rGr7rvoAi7YTKkf ZaR8hChCQd0MEq9ou9MBTpXPflE7Ics= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Luka Gejak , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [PATCH 04/11] staging: rtl8723bs: core: align parameters with open parenthesis Date: Mon, 13 Apr 2026 12:14:25 +0200 Message-ID: <20260413101432.158925-5-luka.gejak@linux.dev> In-Reply-To: <20260413101432.158925-1-luka.gejak@linux.dev> References: <20260413101432.158925-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Luka Gejak Align function parameters with the open parenthesis in the core directory to adhere to the Linux kernel coding style. This resolves "Alignment should match open parenthesis" warnings reported by checkpatch.pl. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/core/rtw_ieee80211.c | 8 +-- .../staging/rtl8723bs/core/rtw_ioctl_set.c | 4 +- drivers/staging/rtl8723bs/core/rtw_mlme.c | 16 +++--- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 52 +++++++++---------- drivers/staging/rtl8723bs/core/rtw_recv.c | 24 ++++----- drivers/staging/rtl8723bs/core/rtw_security.c | 4 +- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +- .../staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- drivers/staging/rtl8723bs/core/rtw_xmit.c | 20 +++---- 9 files changed, 66 insertions(+), 66 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ieee80211.c index 72b7f731dd47..13f0120ddaed 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -107,7 +107,7 @@ int rtw_check_network_type(unsigned char *rate, int cha= nnel) } =20 u8 *rtw_set_fixed_ie(unsigned char *pbuf, unsigned int len, unsigned char = *source, - unsigned int *frlen) + unsigned int *frlen) { memcpy(pbuf, source, len); *frlen =3D *frlen + len; @@ -700,7 +700,7 @@ u8 *rtw_get_wps_attr(u8 *wps_ie, uint wps_ielen, u16 ta= rget_attr_id, u8 *buf_att *len_attr =3D 0; =20 if ((wps_ie[0] !=3D WLAN_EID_VENDOR_SPECIFIC) || - (memcmp(wps_ie + 2, wps_oui, 4))) { + (memcmp(wps_ie + 2, wps_oui, 4))) { return attr_ptr; } =20 @@ -764,7 +764,7 @@ u8 *rtw_get_wps_attr_content(u8 *wps_ie, uint wps_ielen= , u16 target_attr_id, u8 } =20 static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen, - struct rtw_ieee802_11_elems *elems, + struct rtw_ieee802_11_elems *elems, int show_errors) { unsigned int oui; @@ -910,7 +910,7 @@ enum parse_result rtw_ieee802_11_parse_elems(u8 *start,= uint len, break; case WLAN_EID_VENDOR_SPECIFIC: if (rtw_ieee802_11_parse_vendor_specific(pos, elen, - elems, + elems, show_errors)) unknown++; break; diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ioctl_set.c index 439b91862d55..380ce8c89670 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c @@ -280,7 +280,7 @@ u8 rtw_set_802_11_connect(struct adapter *padapter, u8 = *bssid, struct ndis_802_1 } =20 u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter, - enum ndis_802_11_network_infrastructure networktype) + enum ndis_802_11_network_infrastructure networktype) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct wlan_network *cur_network =3D &pmlmepriv->cur_network; @@ -300,7 +300,7 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *p= adapter, rtw_disassoc_cmd(padapter, 0, true); =20 if ((check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) rtw_free_assoc_resources(padapter, 1); =20 if ((*pold_state =3D=3D Ndis802_11Infrastructure) || (*pold_state =3D=3D= Ndis802_11IBSS)) { diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 35ee65c7a458..e5748463a5ff 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -265,7 +265,7 @@ void rtw_free_network_queue(struct adapter *padapter, u= 8 isfreeall) bool rtw_if_up(struct adapter *padapter) { if (padapter->bDriverStopped || padapter->bSurpriseRemoved || - !check_fwstate(&padapter->mlmepriv, _FW_LINKED)) + !check_fwstate(&padapter->mlmepriv, _FW_LINKED)) return false; =20 return true; @@ -331,7 +331,7 @@ bool rtw_is_same_ibss(struct adapter *adapter, struct w= lan_network *pnetwork) struct security_priv *psecuritypriv =3D &adapter->securitypriv; =20 if ((psecuritypriv->dot11PrivacyAlgrthm !=3D _NO_PRIVACY_) && - (pnetwork->network.privacy =3D=3D 0)) + (pnetwork->network.privacy =3D=3D 0)) return false; else if ((psecuritypriv->dot11PrivacyAlgrthm =3D=3D _NO_PRIVACY_) && (pnetwork->network.privacy =3D=3D 1)) @@ -409,7 +409,7 @@ struct wlan_network *rtw_get_oldest_wlan_network(struct= __queue *scanned_queue) } =20 void update_network(struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src, - struct adapter *padapter, bool update_ie) + struct adapter *padapter, bool update_ie) { long rssi_ori =3D dst->rssi; =20 @@ -458,14 +458,14 @@ static void update_current_network(struct adapter *ad= apter, struct wlan_bssid_ex struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; =20 rtw_bug_check(&pmlmepriv->cur_network.network, - &pmlmepriv->cur_network.network, + &pmlmepriv->cur_network.network, &pmlmepriv->cur_network.network, &pmlmepriv->cur_network.network); =20 if (check_fwstate(pmlmepriv, _FW_LINKED) && (is_same_network(&pmlmepriv->= cur_network.network, pnetwork, 0))) { update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true); rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + si= zeof(struct ndis_802_11_fix_ie), - pmlmepriv->cur_network.network.ie_length); + pmlmepriv->cur_network.network.ie_length); } } =20 @@ -1073,7 +1073,7 @@ static void rtw_joinbss_update_network(struct adapter= *padapter, struct wlan_net } =20 rtw_update_protection(padapter, (cur_network->network.ies) + sizeof(struc= t ndis_802_11_fix_ie), - (cur_network->network.ie_length)); + (cur_network->network.ie_length)); =20 rtw_update_ht_cap(padapter, cur_network->network.ies, cur_network->networ= k.ie_length, (u8)cur_network->network.configuration.ds_config); } @@ -1441,7 +1441,7 @@ void rtw_stadel_event_callback(struct adapter *adapte= r, u8 *pbuf) } =20 if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || - check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { + check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { rtw_free_stainfo(adapter, psta); =20 if (adapter->stapriv.asoc_sta_count =3D=3D 1) {/* a sta + bc/mc_stainfo = (not Ibss_stainfo) */ @@ -1998,7 +1998,7 @@ static int SecIsInPMKIDList(struct adapter *Adapter, = u8 *bssid) =20 for (i =3D 0; i < NUM_PMKID_CACHE; i++) if ((p->PMKIDList[i].bUsed) && - (!memcmp(p->PMKIDList[i].Bssid, bssid, ETH_ALEN))) + (!memcmp(p->PMKIDList[i].Bssid, bssid, ETH_ALEN))) return i; return -1; } diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 07e1b30239a3..53af3902f716 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -256,7 +256,7 @@ static void init_mlme_ext_priv_value(struct adapter *pa= dapter) } =20 static int has_channel(struct rt_channel_info *channel_set, - u8 chanset_size, + u8 chanset_size, u8 chan) { int i; @@ -269,7 +269,7 @@ static int has_channel(struct rt_channel_info *channel_= set, } =20 static void init_channel_list(struct adapter *padapter, struct rt_channel_= info *channel_set, - u8 chanset_size, + u8 chanset_size, struct p2p_channels *channel_list) { =20 @@ -303,7 +303,7 @@ static void init_channel_list(struct adapter *padapter,= struct rt_channel_info * continue; =20 if ((0 < (padapter->registrypriv.bw_mode & 0xf0)) && - ((o->bw =3D=3D BW40MINUS) || (o->bw =3D=3D BW40PLUS))) + ((o->bw =3D=3D BW40MINUS) || (o->bw =3D=3D BW40PLUS))) continue; =20 if (!reg) { @@ -513,12 +513,12 @@ unsigned int OnProbeReq(struct adapter *padapter, uni= on recv_frame *precv_frame) return _SUCCESS; =20 if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D false && - check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE | WIFI_AP_STATE) =3D=3D= false) { + check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE | WIFI_AP_STATE) =3D= =3D false) { return _SUCCESS; } =20 p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + _PROBEREQ_IE_OFFSET_, WLAN_EI= D_SSID, (int *)&ielen, - len - WLAN_HDR_A3_LEN - _PROBEREQ_IE_OFFSET_); + len - WLAN_HDR_A3_LEN - _PROBEREQ_IE_OFFSET_); =20 =20 /* check (wildcard) SSID */ @@ -713,7 +713,7 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) seq =3D le16_to_cpu(*(__le16 *)((SIZE_PTR)pframe + WLAN_HDR_A3_LEN + offs= et + 2)); =20 if (auth_mode =3D=3D 2 && - psecuritypriv->dot11PrivacyAlgrthm !=3D _WEP40_ && + psecuritypriv->dot11PrivacyAlgrthm !=3D _WEP40_ && psecuritypriv->dot11PrivacyAlgrthm !=3D _WEP104_) auth_mode =3D 0; =20 @@ -800,7 +800,7 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) } else if (seq =3D=3D 3) { =20 p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + 4 + _AUTH_IE_OFFSET_, WLAN_= EID_CHALLENGE, (int *)&ie_len, - len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_ - 4); + len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_ - 4); =20 if (!p || ie_len <=3D 0) { status =3D WLAN_STATUS_CHALLENGE_FAIL; @@ -889,7 +889,7 @@ unsigned int OnAuthClient(struct adapter *padapter, uni= on recv_frame *precv_fram if (pmlmeinfo->auth_algo =3D=3D dot11AuthAlgrthm_Shared) { /* legendary shared system */ p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + _AUTH_IE_OFFSET_, WLAN_EID_= CHALLENGE, (int *)&len, - pkt_len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_); + pkt_len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_); =20 if (!p) goto authclnt_fail; @@ -1001,7 +1001,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) /* now we should check all the fields... */ /* checking SSID */ p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + ie_offset, WLAN_EID_SSID, &ie= _len, - pkt_len - WLAN_HDR_A3_LEN - ie_offset); + pkt_len - WLAN_HDR_A3_LEN - ie_offset); =20 if (!p || ie_len =3D=3D 0) { /* broadcast ssid, however it is not allowed in assocreq */ @@ -1036,7 +1036,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) support_rate_num =3D ie_len; =20 p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + ie_offset, WLAN_EID_EXT_SUPP= _RATES, &ie_len, - pkt_len - WLAN_HDR_A3_LEN - ie_offset); + pkt_len - WLAN_HDR_A3_LEN - ie_offset); if (p) { =20 if (support_rate_num + ie_len <=3D sizeof(supportRate)) { @@ -1246,7 +1246,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) =20 =20 if ((pstat->flags & WLAN_STA_HT) && - ((pstat->wpa2_pairwise_cipher & WPA_CIPHER_TKIP) || + ((pstat->wpa2_pairwise_cipher & WPA_CIPHER_TKIP) || (pstat->wpa_pairwise_cipher & WPA_CIPHER_TKIP))) { /* status =3D WLAN_STATUS_CIPHER_SUITE_REJECTED; */ /* goto OnAssocReqFail; */ @@ -1984,7 +1984,7 @@ void update_mgntframe_attrib_addr(struct adapter *pad= apter, struct xmit_frame *p void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntfram= e) { if (padapter->bSurpriseRemoved || - padapter->bDriverStopped) { + padapter->bDriverStopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); return; @@ -2002,7 +2002,7 @@ s32 dump_mgntframe_and_wait(struct adapter *padapter,= struct xmit_frame *pmgntfr struct submit_ctx sctx; =20 if (padapter->bSurpriseRemoved || - padapter->bDriverStopped) { + padapter->bDriverStopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); return ret; @@ -2031,7 +2031,7 @@ s32 dump_mgntframe_and_wait_ack(struct adapter *padap= ter, struct xmit_frame *pmg struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; =20 if (padapter->bSurpriseRemoved || - padapter->bDriverStopped) { + padapter->bDriverStopped) { rtw_free_xmitbuf(&padapter->xmitpriv, pmgntframe->pxmitbuf); rtw_free_xmitframe(&padapter->xmitpriv, pmgntframe); return -1; @@ -2148,7 +2148,7 @@ void issue_beacon(struct adapter *padapter, int timeo= ut_ms) u8 sr =3D 0; =20 wps_ie =3D rtw_get_wps_ie(pmgntframe->buf_addr + TXDESC_OFFSET + sizeof= (struct ieee80211_hdr_3addr) + _BEACON_IE_OFFSET_, - pattrib->pktlen - sizeof(struct ieee80211_hdr_3addr) - _BEACON_IE_OFFS= ET_, NULL, &wps_ielen); + pattrib->pktlen - sizeof(struct ieee80211_hdr_3addr) - _BEACON_IE_OF= FSET_, NULL, &wps_ielen); if (wps_ie && wps_ielen > 0) rtw_get_wps_attr_content(wps_ie, wps_ielen, WPS_ATTR_SELECTED_REGISTR= AR, (u8 *)(&sr), NULL); if (sr !=3D 0) @@ -2334,7 +2334,7 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p return; =20 ssid_ie =3D rtw_get_ie(ies + _FIXED_IE_LENGTH_, WLAN_EID_SSID, &ssid_ie= len, - (pframe - ies) - _FIXED_IE_LENGTH_); + (pframe - ies) - _FIXED_IE_LENGTH_); =20 ssid_ielen_diff =3D cur_network->ssid.ssid_length - ssid_ielen; =20 @@ -2524,7 +2524,7 @@ inline void issue_probereq(struct adapter *padapter, = struct ndis_802_11_ssid *ps } =20 int issue_probereq_ex(struct adapter *padapter, struct ndis_802_11_ssid *p= ssid, u8 *da, u8 ch, bool append_wps, - int try_cnt, int wait_ms) + int try_cnt, int wait_ms) { int ret; int i =3D 0; @@ -2930,7 +2930,7 @@ void issue_assocreq(struct adapter *padapter) switch (pIE->element_id) { case WLAN_EID_VENDOR_SPECIFIC: if ((!memcmp(pIE->data, RTW_WPA_OUI, 4)) || - (!memcmp(pIE->data, WMM_OUI, 4)) || + (!memcmp(pIE->data, WMM_OUI, 4)) || (!memcmp(pIE->data, WPS_OUI, 4))) { vs_ie_length =3D pIE->length; if ((!padapter->registrypriv.wifi_spec) && (!memcmp(pIE->data, WPS_OUI= , 4))) { @@ -3307,7 +3307,7 @@ int issue_deauth(struct adapter *padapter, unsigned c= har *da, unsigned short rea } =20 int issue_deauth_ex(struct adapter *padapter, u8 *da, unsigned short reaso= n, int try_cnt, - int wait_ms) + int wait_ms) { int ret; int i =3D 0; @@ -4134,7 +4134,7 @@ void start_clnt_join(struct adapter *padapter) beacon_timeout =3D decide_wait_for_beacon_timeout(pmlmeinfo->bcn_interva= l); set_link_timer(pmlmeext, beacon_timeout); _set_timer(&padapter->mlmepriv.assoc_timer, - (REAUTH_TO * REAUTH_LIMIT) + (REASSOC_TO * REASSOC_LIMIT) + beacon_time= out); + (REAUTH_TO * REAUTH_LIMIT) + (REASSOC_TO * REASSOC_LIMIT) + beacon_t= imeout); =20 pmlmeinfo->state =3D WIFI_FW_AUTH_NULL | WIFI_FW_STATION_STATE; } else if (caps & WLAN_CAPABILITY_IBSS) { /* adhoc client */ @@ -4231,7 +4231,7 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid =20 /* Adjust channel plan by AP Country IE */ if (pregistrypriv->enable80211d && - (!pmlmeext->update_channel_plan_by_ap_done)) { + (!pmlmeext->update_channel_plan_by_ap_done)) { u8 *ie, *p; u32 len; struct rt_channel_plan chplan_ap; @@ -4281,7 +4281,7 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid if (pregistrypriv->wireless_mode & WIRELESS_11G) { do { if ((i =3D=3D MAX_CHANNEL_NUM) || - (chplan_sta[i].ChannelNum =3D=3D 0) || + (chplan_sta[i].ChannelNum =3D=3D 0) || (chplan_sta[i].ChannelNum > 14)) break; =20 @@ -4309,7 +4309,7 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid =20 /* change AP not support channel to Passive scan */ while ((i < MAX_CHANNEL_NUM) && - (chplan_sta[i].ChannelNum !=3D 0) && + (chplan_sta[i].ChannelNum !=3D 0) && (chplan_sta[i].ChannelNum <=3D 14)) { =20 chplan_new[k].ChannelNum =3D chplan_sta[i].ChannelNum; @@ -4328,7 +4328,7 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid } else { /* keep original STA 2.4G channel plan */ while ((i < MAX_CHANNEL_NUM) && - (chplan_sta[i].ChannelNum !=3D 0) && + (chplan_sta[i].ChannelNum !=3D 0) && (chplan_sta[i].ChannelNum <=3D 14)) { chplan_new[k].ChannelNum =3D chplan_sta[i].ChannelNum; chplan_new[k].ScanType =3D chplan_sta[i].ScanType; @@ -5423,7 +5423,7 @@ u8 disconnect_hdl(struct adapter *padapter, unsigned = char *pbuf) } =20 static int rtw_scan_ch_decision(struct adapter *padapter, struct rtw_ieee8= 0211_channel *out, - u32 out_num, struct rtw_ieee80211_channel *in, u32 in_num) + u32 out_num, struct rtw_ieee80211_channel *in, u32 in_num) { int i, j; int set_idx; @@ -5671,7 +5671,7 @@ u8 add_ba_hdl(struct adapter *padapter, unsigned char= *pbuf) return H2C_SUCCESS; =20 if (((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && (pmlmeinfo->HT_enable)= ) || - ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE)) { + ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE)) { /* pmlmeinfo->ADDBA_retry_count =3D 0; */ /* pmlmeinfo->candidate_tid_bitmap |=3D (0x1 << pparm->tid); */ /* psta->htpriv.candidate_tid_bitmap |=3D BIT(pparm->tid); */ diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index d0d6efaee2af..f3c1ed9823f9 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -337,7 +337,7 @@ static void rtw_handle_tkip_mic_err(struct adapter *pad= apter, u8 bgroup) key_type |=3D NL80211_KEYTYPE_PAIRWISE; =20 cfg80211_michael_mic_failure(padapter->pnetdev, (u8 *)&pmlmepriv->assoc_b= ssid[0], key_type, -1, - NULL, GFP_ATOMIC); + NULL, GFP_ATOMIC); =20 memset(&ev, 0x00, sizeof(ev)); if (bgroup) @@ -701,7 +701,7 @@ static void count_rx_stats(struct adapter *padapter, un= ion recv_frame *prframe, } =20 static signed int sta2sta_data_frame(struct adapter *adapter, union recv_f= rame *precv_frame, - struct sta_info **psta) + struct sta_info **psta) { u8 *ptr =3D precv_frame->u.hdr.rx_data; signed int ret =3D _SUCCESS; @@ -714,7 +714,7 @@ static signed int sta2sta_data_frame(struct adapter *ad= apter, union recv_frame * signed int bmcast =3D is_multicast_ether_addr(pattrib->dst); =20 if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { =20 /* filter packets that SA is myself or multicast or broadcast */ if (!memcmp(myhwaddr, pattrib->src, ETH_ALEN)) { @@ -789,7 +789,7 @@ static signed int sta2sta_data_frame(struct adapter *ad= apter, union recv_frame * } =20 static signed int ap2sta_data_frame(struct adapter *adapter, union recv_fr= ame *precv_frame, - struct sta_info **psta) + struct sta_info **psta) { u8 *ptr =3D precv_frame->u.hdr.rx_data; struct rx_pkt_attrib *pattrib =3D &precv_frame->u.hdr.attrib; @@ -894,7 +894,7 @@ static signed int ap2sta_data_frame(struct adapter *ada= pter, union recv_frame *p } =20 static signed int sta2ap_data_frame(struct adapter *adapter, union recv_fr= ame *precv_frame, - struct sta_info **psta) + struct sta_info **psta) { u8 *ptr =3D precv_frame->u.hdr.rx_data; struct rx_pkt_attrib *pattrib =3D &precv_frame->u.hdr.attrib; @@ -1416,7 +1416,7 @@ static signed int validate_80211w_mgmt(struct adapter= *adapter, union recv_frame adapter->securitypriv.binstallBIPkey =3D=3D true) { /* unicast management frame decrypt */ if (pattrib->privacy && !(is_multicast_ether_addr(GetAddr1Ptr(ptr))) && - (subtype =3D=3D WIFI_DEAUTH || subtype =3D=3D WIFI_DISASSOC || subtype = =3D=3D WIFI_ACTION)) { + (subtype =3D=3D WIFI_DEAUTH || subtype =3D=3D WIFI_DISASSOC || subty= pe =3D=3D WIFI_ACTION)) { u8 *mgmt_DATA; u32 data_len =3D 0; =20 @@ -1457,10 +1457,10 @@ static signed int validate_80211w_mgmt(struct adapt= er *adapter, union recv_frame } else { /* 802.11w protect */ if (subtype =3D=3D WIFI_ACTION) { /* according 802.11-2012 standard, these five types are not robust typ= es */ - if (ptr[WLAN_HDR_A3_LEN] !=3D RTW_WLAN_CATEGORY_PUBLIC && - ptr[WLAN_HDR_A3_LEN] !=3D RTW_WLAN_CATEGORY_HT && + if (ptr[WLAN_HDR_A3_LEN] !=3D RTW_WLAN_CATEGORY_PUBLIC && + ptr[WLAN_HDR_A3_LEN] !=3D RTW_WLAN_CATEGORY_HT && ptr[WLAN_HDR_A3_LEN] !=3D RTW_WLAN_CATEGORY_UNPROTECTED_WNM && - ptr[WLAN_HDR_A3_LEN] !=3D RTW_WLAN_CATEGORY_SELF_PROTECTED && + ptr[WLAN_HDR_A3_LEN] !=3D RTW_WLAN_CATEGORY_SELF_PROTECTED && ptr[WLAN_HDR_A3_LEN] !=3D RTW_WLAN_CATEGORY_P2P) { goto validate_80211w_fail; } @@ -1580,7 +1580,7 @@ static signed int wlanhdr_to_ethhdr(union recv_frame = *precvframe) /* convert hdr + possible LLC headers into Ethernet header */ /* eth_type =3D (psnap_type[0] << 8) | psnap_type[1]; */ if ((!memcmp(psnap, rfc1042_header, SNAP_SIZE) && - (memcmp(psnap_type, SNAP_ETH_TYPE_IPX, 2)) && + (memcmp(psnap_type, SNAP_ETH_TYPE_IPX, 2)) && (memcmp(psnap_type, SNAP_ETH_TYPE_APPLETALK_AARP, 2))) || /* eth_type !=3D ETH_P_AARP && eth_type !=3D ETH_P_IPX) || */ !memcmp(psnap, bridge_tunnel_header, SNAP_SIZE)) { @@ -1644,7 +1644,7 @@ static struct sk_buff *rtw_alloc_msdu_pkt(union recv_= frame *prframe, u16 nSubfra eth_type =3D get_unaligned_be16(&sub_skb->data[6]); =20 if (sub_skb->len >=3D 8 && - ((!memcmp(sub_skb->data, rfc1042_header, SNAP_SIZE) && + ((!memcmp(sub_skb->data, rfc1042_header, SNAP_SIZE) && eth_type !=3D ETH_P_AARP && eth_type !=3D ETH_P_IPX) || !memcmp(sub_skb->data, bridge_tunnel_header, SNAP_SIZE))) { /* @@ -2198,7 +2198,7 @@ static int recv_func(struct adapter *padapter, union = recv_frame *rframe) =20 /* check if need to enqueue into uc_swdec_pending_queue*/ if (check_fwstate(mlmepriv, WIFI_STATION_STATE) && - !is_multicast_ether_addr(prxattrib->ra) && prxattrib->encrypt > 0 && + !is_multicast_ether_addr(prxattrib->ra) && prxattrib->encrypt > 0 && (prxattrib->bdecrypted =3D=3D 0 || psecuritypriv->sw_decrypt =3D=3D tru= e) && psecuritypriv->ndisauthtype =3D=3D Ndis802_11AuthModeWPAPSK && !psecuritypriv->busetkipkey) { diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/stagin= g/rtl8723bs/core/rtw_security.c index a00504ff2910..e95daba50fbf 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -786,7 +786,7 @@ static void construct_ctr_preload(u8 *ctr_preload, } =20 static signed int aes_cipher(u8 *key, uint hdrlen, - u8 *pframe, uint plen) + u8 *pframe, uint plen) { uint qc_exists, a4_exists, i, j, payload_remainder, num_blocks, payload_index; @@ -989,7 +989,7 @@ u32 rtw_aes_encrypt(struct adapter *padapter, u8 *pxmit= frame) } =20 static signed int aes_decipher(u8 *key, uint hdrlen, - u8 *pframe, uint plen) + u8 *pframe, uint plen) { static u8 message[MAX_MSG_SIZE]; uint qc_exists, a4_exists, i, j, payload_remainder, diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging= /rtl8723bs/core/rtw_sta_mgt.c index 07a6db1d2317..f1c7a4fac42f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c +++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c @@ -249,7 +249,7 @@ struct sta_info *rtw_alloc_stainfo(struct sta_priv *pst= apriv, u8 *hwaddr) =20 /* init recv timer */ timer_setup(&preorder_ctrl->reordering_ctrl_timer, - rtw_reordering_ctrl_timeout_handler, 0); + rtw_reordering_ctrl_timeout_handler, 0); } =20 /* init for DM */ diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 6a7c09db4cd9..4d60f0ce5f95 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -1209,7 +1209,7 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *p= frame, u32 packet_len) bssid->ssid.ssid_length =3D ssid_len; =20 if (memcmp(bssid->ssid.ssid, cur_network->network.ssid.ssid, 32) || - bssid->ssid.ssid_length !=3D cur_network->network.ssid.ssid_length) + bssid->ssid.ssid_length !=3D cur_network->network.ssid.ssid_length) if (bssid->ssid.ssid[0] !=3D '\0' && bssid->ssid.ssid_length !=3D 0) /* not hidden ssid */ goto _mismatch; diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 7bce0343d59f..136c6493b134 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -407,7 +407,7 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * u8 HTOpMode =3D pmlmeinfo->HT_protection; =20 if ((pmlmeext->cur_bwmode && (HTOpMode =3D=3D 2 || HTOpMode =3D=3D 3))= || - (!pmlmeext->cur_bwmode && HTOpMode =3D=3D 3)) { + (!pmlmeext->cur_bwmode && HTOpMode =3D=3D 3)) { pattrib->vcs_mode =3D RTS_CTS; break; } @@ -564,7 +564,7 @@ static s32 update_attrib_sec_info(struct adapter *padap= ter, struct pkt_attrib *p memcpy(pattrib->dot118021x_UncstKey.skey, psta->dot118021x_UncstKey.skey= , 16); =20 if (pattrib->encrypt && - ((padapter->securitypriv.sw_encrypt) || (!psecuritypriv->hw_decrypted))) + ((padapter->securitypriv.sw_encrypt) || (!psecuritypriv->hw_decrypted= ))) pattrib->bswenc =3D true; else pattrib->bswenc =3D false; @@ -653,7 +653,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p memcpy(pattrib->src, ðerhdr.h_source, ETH_ALEN); =20 if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { memcpy(pattrib->ra, pattrib->dst, ETH_ALEN); memcpy(pattrib->ta, pattrib->src, ETH_ALEN); } else if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { @@ -680,7 +680,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p if (pktfile.pkt_len > 282) {/* MINIMUM_DHCP_PACKET_SIZE) { */ if (pattrib->ether_type =3D=3D ETH_P_IP) {/* IP header */ if (((tmp[21] =3D=3D 68) && (tmp[23] =3D=3D 67)) || - ((tmp[21] =3D=3D 67) && (tmp[23] =3D=3D 68))) { + ((tmp[21] =3D=3D 67) && (tmp[23] =3D=3D 68))) { /* 68 : UDP BOOTP client */ /* 67 : UDP BOOTP server */ pattrib->dhcp_pkt =3D 1; @@ -1017,7 +1017,7 @@ s32 rtw_txframes_pending(struct adapter *padapter) struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; =20 return ((!list_empty(&pxmitpriv->be_pending.queue)) || - (!list_empty(&pxmitpriv->bk_pending.queue)) || + (!list_empty(&pxmitpriv->bk_pending.queue)) || (!list_empty(&pxmitpriv->vi_pending.queue)) || (!list_empty(&pxmitpriv->vo_pending.queue))); } @@ -1260,7 +1260,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s } else { /* unicast mgmt frame TX */ /* start to encrypt mgmt frame */ if (subtype =3D=3D WIFI_DEAUTH || subtype =3D=3D WIFI_DISASSOC || - subtype =3D=3D WIFI_REASSOCREQ || subtype =3D=3D WIFI_ACTION) { + subtype =3D=3D WIFI_REASSOCREQ || subtype =3D=3D WIFI_ACTION) { if (pattrib->psta) psta =3D pattrib->psta; else @@ -1274,7 +1274,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s =20 /* according 802.11-2012 standard, these five types are not robust type= s */ if (subtype =3D=3D WIFI_ACTION && - (pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_PUBLIC || + (pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_PUBLIC || pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_HT || pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_UNPROTECTED_WNM || pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_SELF_PROTECTED || @@ -1435,7 +1435,7 @@ void rtw_count_tx_stats(struct adapter *padapter, str= uct xmit_frame *pxmitframe, } =20 static struct xmit_buf *__rtw_alloc_cmd_xmitbuf(struct xmit_priv *pxmitpri= v, - enum cmdbuf_type buf_type) + enum cmdbuf_type buf_type) { struct xmit_buf *pxmitbuf =3D NULL; =20 @@ -1456,7 +1456,7 @@ static struct xmit_buf *__rtw_alloc_cmd_xmitbuf(struc= t xmit_priv *pxmitpriv, } =20 struct xmit_frame *__rtw_alloc_cmdxmitframe(struct xmit_priv *pxmitpriv, - enum cmdbuf_type buf_type) + enum cmdbuf_type buf_type) { struct xmit_frame *pcmdframe; struct xmit_buf *pxmitbuf; @@ -2486,7 +2486,7 @@ struct xmit_buf *dequeue_pending_xmitbuf_under_survey= (struct xmit_priv *pxmitpri type =3D GetFrameSubType(pxmitbuf->pbuf + TXDESC_OFFSET); =20 if ((type =3D=3D WIFI_PROBEREQ) || - (type =3D=3D WIFI_DATA_NULL) || + (type =3D=3D WIFI_DATA_NULL) || (type =3D=3D WIFI_QOS_DATA_NULL)) { list_del_init(&pxmitbuf->list); break; --=20 2.53.0 From nobody Thu Jun 11 22:58:33 2026 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26BD03AF667 for ; Mon, 13 Apr 2026 10:15:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075342; cv=none; b=dsgWlM4GdO/8Tfy/EUHR4nXY3iY1wRrToJiSLhZDSH4S2O4ycyQSE593IlZjemyKMOKWYoQl4JRLSj/wNWlLvJrphDR7wkVhvgAl7VL7yZ9T3OrTO9G6LcM7wcxaLR4yXbKnvyVrw6kNrzfwpUDtUFI6a3o07eGXat2Go2bdeGw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075342; c=relaxed/simple; bh=Lzy2UR7ragNrQgLJzLOFmbn+JRYcXrQ+80bKxfMzsWw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DH7/cW8yJbXuia5DBEBHAVnfWCfq67krPkcCmatgBC+gg0FQT2vUTwcX4rfX4DV25aC5L4RVt4nWb6TItqPebiW9Ee6pYAbPehSfJXqYTvx05ZqpIt6SivRITaEZBT63m4I1AJj88YywF78M0GT5LjLhWiAMtc6WiC+0LKGS3WU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=m8f9mjYa; arc=none smtp.client-ip=91.218.175.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="m8f9mjYa" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776075339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jWFnbz3PXC8UikRqW7mpw27Jr+/URZ48PwSZbTVVfLY=; b=m8f9mjYaBS0FXE5JCd9jH/oGZABAgeEpFrgSdajSVrFCRI2Rn7elcv05DN8QHmZdCxDRhW 1XFu+0GcrXKIWb+IckXMeeEDQ6PBvR+UkO6muP2GOvNx3hH1IqCzaPYHTI1NdmPJEFTqSr I5wXQLOssJOM3CiHaCWNG/8iXi9g758= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Luka Gejak , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [PATCH 05/11] staging: rtl8723bs: hal: align parameters with open parenthesis Date: Mon, 13 Apr 2026 12:14:26 +0200 Message-ID: <20260413101432.158925-6-luka.gejak@linux.dev> In-Reply-To: <20260413101432.158925-1-luka.gejak@linux.dev> References: <20260413101432.158925-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Luka Gejak Align function parameters with the open parenthesis in the hal directory to adhere to the Linux kernel coding style. This resolves "Alignment should match open parenthesis" warnings reported by checkpatch.pl. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 2 +- drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 2 +- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 8 ++++---- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 2 +- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 2 +- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/stag= ing/rtl8723bs/hal/HalBtc8723b1Ant.c index b3e34f97cfc6..87b07187efaf 100644 --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c @@ -1870,7 +1870,7 @@ static void halbtc8723b1ant_ActionWifiConnected(struc= t btc_coexist *pBtCoexist) (pCoexDm->btStatus =3D=3D BT_8723B_1ANT_BT_STATUS_ACL_SCO_BUSY) ) { halbtc8723b1ant_ActionBtScoHidOnlyBusy(pBtCoexist, - BT_8723B_1ANT_WIFI_STATUS_CONNECTED_IDLE); + BT_8723B_1ANT_WIFI_STATUS_CONNECTED_IDLE); } else { halbtc8723b1ant_PsTdma(pBtCoexist, NORMAL_EXEC, false, 8); =20 diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c b/drivers/stag= ing/rtl8723bs/hal/HalBtc8723b2Ant.c index d32dbf94858f..9d82ccf6e138 100644 --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c @@ -566,7 +566,7 @@ static void halbtc8723b2ant_DacSwing( =20 if (!bForceExec) { if ((pCoexDm->bPreDacSwingOn =3D=3D pCoexDm->bCurDacSwingOn) && - (pCoexDm->preDacSwingLvl =3D=3D pCoexDm->curDacSwingLvl)) + (pCoexDm->preDacSwingLvl =3D=3D pCoexDm->curDacSwingLvl)) return; } mdelay(30); diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.c index 5a08a5e3be63..16006c74a4c3 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -222,7 +222,7 @@ void ODM_TxPwrTrackSetPwr_8723B( Final_CCK_Swing_Index =3D 0; =20 setIqkMatrix_8723B(pDM_Odm, Final_OFDM_Swing_Index, RFPath, - pDM_Odm->RFCalibrateInfo.iqk_matrix_regs_setting_value[ChannelMappedInd= ex][0], + pDM_Odm->RFCalibrateInfo.iqk_matrix_regs_setting_value[ChannelMappe= dIndex][0], pDM_Odm->RFCalibrateInfo.iqk_matrix_regs_setting_value[ChannelMappedInd= ex][1]); =20 setCCKFilterCoefficient(pDM_Odm, Final_CCK_Swing_Index); @@ -235,7 +235,7 @@ void ODM_TxPwrTrackSetPwr_8723B( pDM_Odm->Remnant_OFDMSwingIdx[RFPath] =3D Final_OFDM_Swing_Index - PwrT= rackingLimit_OFDM; =20 setIqkMatrix_8723B(pDM_Odm, PwrTrackingLimit_OFDM, RFPath, - pDM_Odm->RFCalibrateInfo.iqk_matrix_regs_setting_value[ChannelMappedIn= dex][0], + pDM_Odm->RFCalibrateInfo.iqk_matrix_regs_setting_value[ChannelMapp= edIndex][0], pDM_Odm->RFCalibrateInfo.iqk_matrix_regs_setting_value[ChannelMappedIn= dex][1]); =20 pDM_Odm->Modify_TxAGC_Flag_PathA =3D true; @@ -245,7 +245,7 @@ void ODM_TxPwrTrackSetPwr_8723B( pDM_Odm->Remnant_OFDMSwingIdx[RFPath] =3D Final_OFDM_Swing_Index; =20 setIqkMatrix_8723B(pDM_Odm, 0, RFPath, - pDM_Odm->RFCalibrateInfo.iqk_matrix_regs_setting_value[ChannelMappedIn= dex][0], + pDM_Odm->RFCalibrateInfo.iqk_matrix_regs_setting_value[ChannelMapp= edIndex][0], pDM_Odm->RFCalibrateInfo.iqk_matrix_regs_setting_value[ChannelMappedIn= dex][1]); =20 pDM_Odm->Modify_TxAGC_Flag_PathA =3D true; @@ -253,7 +253,7 @@ void ODM_TxPwrTrackSetPwr_8723B( PHY_SetTxPowerIndexByRateSection(Adapter, RFPath, pHalData->CurrentChan= nel, HT_MCS0_MCS7); } else { setIqkMatrix_8723B(pDM_Odm, Final_OFDM_Swing_Index, RFPath, - pDM_Odm->RFCalibrateInfo.iqk_matrix_regs_setting_value[ChannelMappedIn= dex][0], + pDM_Odm->RFCalibrateInfo.iqk_matrix_regs_setting_value[ChannelMapp= edIndex][0], pDM_Odm->RFCalibrateInfo.iqk_matrix_regs_setting_value[ChannelMappedIn= dex][1]); =20 if (pDM_Odm->Modify_TxAGC_Flag_PathA) { /* If TxAGC has changed, reset = TxAGC again */ diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index a67a49288f4a..dd91ce3a8e37 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -426,7 +426,7 @@ void PHY_SetTxPowerIndexByRateSection( u8 cckRates[] =3D {MGN_1M, MGN_2M, MGN_5_5M, MGN_11M}; =20 PHY_SetTxPowerIndexByRateArray(padapter, RFPath, - pHalData->CurrentChannelBW, + pHalData->CurrentChannelBW, Channel, cckRates, ARRAY_SIZE(cckRates)); =20 diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_recv.c index 0204a454c954..da87d2af8500 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c @@ -128,7 +128,7 @@ static void update_recvframe_phyinfo(union recv_frame *= precvframe, /* rtl8723b_query_rx_phy_status(precvframe, pphy_status); */ /* spin_lock_bh(&p_hal_data->odm_stainfo_lock); */ odm_phy_status_query(&p_hal_data->odmpriv, p_phy_info, - (u8 *)pphy_status, &(pkt_info)); + (u8 *)pphy_status, &(pkt_info)); if (psta) psta->rssi =3D pattrib->phy_info.RecvSignalPower; /* spin_unlock_bh(&p_hal_data->odm_stainfo_lock); */ diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index f50726d2ed0c..fc075a4e146f 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -232,7 +232,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, st= ruct xmit_priv *pxmitpriv /* check xmit_buf size enough or not */ txlen =3D txdesc_size + rtw_wlan_pkt_size(pxmitframe); if (!pxmitbuf || - ((_RND(pxmitbuf->len, 8) + txlen) > max_xmit_len) || + ((_RND(pxmitbuf->len, 8) + txlen) > max_xmit_len) || (k >=3D (rtw_hal_sdio_max_txoqt_free_space(padapter) - 1)) ) { if (pxmitbuf) { diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index f2f73c65a636..3b4d036d2caa 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -743,7 +743,7 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) invalidate_cam_all(padapter); =20 rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel, - CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET= _DONT_CARE); + CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_O= FFSET_DONT_CARE); =20 /* Record original value for template. This is arough data, we can only = use the data */ /* for power adjust. The value can not be adjustde according to differen= t power!!! */ --=20 2.53.0 From nobody Thu Jun 11 22:58:33 2026 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57B983B892D for ; Mon, 13 Apr 2026 10:15:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075347; cv=none; b=Ku112wPMxUKlBjNRA1qUJRyQ0jB6gJ/iMOXLZL7IGcl1xOslVox0u1cjYoDcQAGT3xY+jsYrlQnYsJiyHIsGb4x3zOeHrDznE2EYmV6012vzNTBOh3XXuwbnSb47DIohft0OnxDnY/24Wz1dN90YeGXLOJQyBMzcexYtSw1F0tk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075347; c=relaxed/simple; bh=yPkQpdRJz4UUEAIB1UHDnAtzLhdEjq30MfMTXx+1RkQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lOx0zqMCTwASeiDrSD5QJUfE3kOk2rDNIHR47+hsF5Vh5Zis1+urjYoL+Paa3Jt5NSqYJtezLfo4+zFI76h6RlwN77E3BM5Hqb5jX9eDWGN64XKE/g3BT74XR7oYie2ShPeoUctGQZ6rohfIsYYNCo20Xa6mmJyZqhiCgjqcGYQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Mz5UfPXW; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Mz5UfPXW" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776075344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1cb61+C5CwkI3uiNoG1Pp1t2PFr18a9etaR9+AfhkPM=; b=Mz5UfPXW8xGqq/jC5C08wqxNH+xvkcy4feLl2TQZI9Xyxx6xs+JxCVgjGYOFRzPBscY33A jCM87NKHsK5KRiP8wbwuI5WcoK2WogPhojD6iY8fxrpxB2R1+YEimYuVhQBKmPxQTVbC/O 0lrsV2x7RH8+29kyDkNiOw0dkFQOnNg= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Luka Gejak , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [PATCH 06/11] staging: rtl8723bs: os_dep: align parameters with open parenthesis Date: Mon, 13 Apr 2026 12:14:27 +0200 Message-ID: <20260413101432.158925-7-luka.gejak@linux.dev> In-Reply-To: <20260413101432.158925-1-luka.gejak@linux.dev> References: <20260413101432.158925-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Luka Gejak Align function parameters with the open parenthesis in the os_dep directory to adhere to the Linux kernel coding style. This resolves "Alignment should match open parenthesis" warnings reported by checkpatch.pl. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 098456e97c96..eb407d245ebc 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -2305,7 +2305,7 @@ static int cfg80211_rtw_start_ap(struct wiphy *wiphy,= struct net_device *ndev, } =20 static int cfg80211_rtw_change_beacon(struct wiphy *wiphy, struct net_devi= ce *ndev, - struct cfg80211_ap_update *info) + struct cfg80211_ap_update *info) { struct adapter *adapter =3D rtw_netdev_priv(ndev); =20 --=20 2.53.0 From nobody Thu Jun 11 22:58:33 2026 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 027573B2FFF for ; Mon, 13 Apr 2026 10:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075352; cv=none; b=Yxo7fXnFiuhurGQUPHdRg/YzYg6OZOwPezNlu6zXt8KwElsfamb/riAXHuJV2rS72e0HK6cL6gOxyi5VS04NSE+7mEn1S3wz1Rh4bxS36hSww7uvi1i4VBDCCiLqXEdiV/Mr3owKj37t2bT1hYeRYL3YOksQr6CWIzzHoZnz9IA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075352; c=relaxed/simple; bh=s26qjEBdRBuekJ1OQklu/aJ2s6i3w1YLlammy4HnsgQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GKvmrL/u/ez3FX5nMSJWnYgGu7WjvgzjniyIgx+R8Ihtd+tOhgX4xZbCvDqihYyTREPstJmBRTTNY00i6F7U6bhdsxJZX4je33UHm76iaLWWFEp7Xjwh3+4iaXwL8HFmn7Obn2bMtyUbhjGTanRww2dN4b9jZ1kPGAa10eQH/Ds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Pw+u0PHe; arc=none smtp.client-ip=91.218.175.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Pw+u0PHe" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776075348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NpxRsac8NiHAmsoyXEN6ICiA4iIU5Im8l/rci7jzfN0=; b=Pw+u0PHe91XFRIyht4UgDJKhjF8bLcjG3WVg0q3npKhx/snOHCYqD8o6zDe50HWUKzb/mB gesP7Pgc2kQvWYrOfyEzTzTnTIfnReSrkV5QVmH7zCq5y2aNt7Di2S1C87YOKts9vIVlEe yhn7oxcx1kWY+rByG+zqvWNSZfAQgYk= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Luka Gejak , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [PATCH 07/11] staging: rtl8723bs: core: remove blank lines before closing brace Date: Mon, 13 Apr 2026 12:14:28 +0200 Message-ID: <20260413101432.158925-8-luka.gejak@linux.dev> In-Reply-To: <20260413101432.158925-1-luka.gejak@linux.dev> References: <20260413101432.158925-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Luka Gejak Remove empty lines immediately preceding a closing brace in the core directory to adhere to the Linux kernel coding style. This resolves "Blank lines aren't necessary before a close brace" warnings reported by checkpatch.pl. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/core/rtw_ieee80211.c | 1 - .../staging/rtl8723bs/core/rtw_ioctl_set.c | 3 - drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 60 ------------------- drivers/staging/rtl8723bs/core/rtw_recv.c | 38 ------------ drivers/staging/rtl8723bs/core/rtw_security.c | 3 - 5 files changed, 105 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ieee80211.c index 13f0120ddaed..305982c43613 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -593,7 +593,6 @@ int rtw_get_wapi_ie(u8 *in_ie, uint in_len, u8 *wapi_ie= , u16 *wapi_len) =20 if (wapi_len) *wapi_len =3D in_ie[cnt + 1] + 2; - } =20 cnt +=3D in_ie[cnt + 1] + 2; /* get next */ diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ioctl_set.c index 380ce8c89670..5eaf47c6ccb3 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c @@ -120,9 +120,7 @@ u8 rtw_do_join(struct adapter *padapter) pmlmepriv->to_join =3D false; } } - } - } =20 exit: @@ -417,7 +415,6 @@ u8 rtw_set_802_11_authentication_mode(struct adapter *p= adapter, enum ndis_802_11 =20 u8 rtw_set_802_11_add_wep(struct adapter *padapter, struct ndis_802_11_wep= *wep) { - signed int keyid, res; struct security_priv *psecuritypriv =3D &(padapter->securitypriv); u8 ret =3D _SUCCESS; diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 53af3902f716..00beb68c3439 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -272,7 +272,6 @@ static void init_channel_list(struct adapter *padapter,= struct rt_channel_info * u8 chanset_size, struct p2p_channels *channel_list) { - static const struct p2p_oper_class_map op_class[] =3D { { IEEE80211G, 81, 1, 13, 1, BW20 }, { IEEE80211G, 82, 14, 14, 1, BW20 }, @@ -317,7 +316,6 @@ static void init_channel_list(struct adapter *padapter,= struct rt_channel_info * } } channel_list->reg_classes =3D cla; - } =20 static u8 init_channel_set(struct adapter *padapter, u8 ChannelPlan, struc= t rt_channel_info *channel_set) @@ -539,7 +537,6 @@ unsigned int OnProbeReq(struct adapter *padapter, union= recv_frame *precv_frame) } =20 return _SUCCESS; - } =20 unsigned int OnProbeRsp(struct adapter *padapter, union recv_frame *precv_= frame) @@ -552,7 +549,6 @@ unsigned int OnProbeRsp(struct adapter *padapter, union= recv_frame *precv_frame) } =20 return _SUCCESS; - } =20 unsigned int OnBeacon(struct adapter *padapter, union recv_frame *precv_fr= ame) @@ -665,7 +661,6 @@ unsigned int OnBeacon(struct adapter *padapter, union r= ecv_frame *precv_frame) _END_ONBEACON_: =20 return _SUCCESS; - } =20 unsigned int OnAuth(struct adapter *padapter, union recv_frame *precv_fram= e) @@ -732,7 +727,6 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) =20 pstat =3D rtw_get_stainfo(pstapriv, sa); if (!pstat) { - /* allocate a new one */ pstat =3D rtw_alloc_stainfo(pstapriv, sa); if (!pstat) { @@ -746,7 +740,6 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) /* pstat->flags =3D 0; */ /* pstat->capability =3D 0; */ } else { - spin_lock_bh(&pstapriv->asoc_list_lock); if (list_empty(&pstat->asoc_list) =3D=3D false) { list_del_init(&pstat->asoc_list); @@ -764,7 +757,6 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) =20 spin_lock_bh(&pstapriv->auth_list_lock); if (list_empty(&pstat->auth_list)) { - list_add_tail(&pstat->auth_list, &pstapriv->auth_list); pstapriv->auth_list_cnt++; } @@ -798,7 +790,6 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) pstat->state |=3D WIFI_FW_AUTH_STATE; pstat->authalg =3D algorithm; } else if (seq =3D=3D 3) { - p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + 4 + _AUTH_IE_OFFSET_, WLAN_= EID_CHALLENGE, (int *)&ie_len, len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_ - 4); =20 @@ -847,7 +838,6 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) issue_auth(padapter, pstat, (unsigned short)status); =20 return _FAIL; - } =20 unsigned int OnAuthClient(struct adapter *padapter, union recv_frame *prec= v_frame) @@ -924,7 +914,6 @@ unsigned int OnAuthClient(struct adapter *padapter, uni= on recv_frame *precv_fram /* pmlmeinfo->state &=3D ~(WIFI_FW_AUTH_STATE); */ =20 return _FAIL; - } =20 unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_= frame) @@ -1038,7 +1027,6 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + ie_offset, WLAN_EID_EXT_SUPP= _RATES, &ie_len, pkt_len - WLAN_HDR_A3_LEN - ie_offset); if (p) { - if (support_rate_num + ie_len <=3D sizeof(supportRate)) { memcpy(supportRate + support_rate_num, p + 2, ie_len); support_rate_num +=3D ie_len; @@ -1063,7 +1051,6 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) pstat->wpa2_pairwise_cipher =3D 0; memset(pstat->wpa_ie, 0, sizeof(pstat->wpa_ie)); if ((psecuritypriv->wpa_psk & BIT(1)) && elems.rsn_ie) { - int group_cipher =3D 0, pairwise_cipher =3D 0; =20 wpa_ie =3D elems.rsn_ie; @@ -1086,7 +1073,6 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) } =20 } else if ((psecuritypriv->wpa_psk & BIT(0)) && elems.wpa_ie) { - int group_cipher =3D 0, pairwise_cipher =3D 0; =20 wpa_ie =3D elems.wpa_ie; @@ -1149,7 +1135,6 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) status =3D WLAN_STATUS_INVALID_IE; =20 goto OnAssocReqFail; - } =20 if (elems.wps_ie) { @@ -1162,7 +1147,6 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) =20 if (copy_len > 0) memcpy(pstat->wpa_ie, wpa_ie - 2, copy_len); - } =20 =20 @@ -1219,7 +1203,6 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) pstat->uapsd_be =3D BIT(0) | BIT(1); else pstat->uapsd_be =3D 0; - } =20 break; @@ -1278,7 +1261,6 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) =20 /* if (pstat->aid > NUM_STA) { */ if (pstat->aid > pstapriv->max_num_sta) { - pstat->aid =3D 0; =20 status =3D WLAN_STATUS_AP_UNABLE_TO_HANDLE_NEW_STA; @@ -1478,7 +1460,6 @@ unsigned int OnDeAuth(struct adapter *padapter, union= recv_frame *precv_frame) list_del_init(&psta->asoc_list); pstapriv->asoc_list_cnt--; updated =3D ap_free_sta(padapter, psta, false, reason); - } spin_unlock_bh(&pstapriv->asoc_list_lock); =20 @@ -1550,7 +1531,6 @@ unsigned int OnDisassoc(struct adapter *padapter, uni= on recv_frame *precv_frame) list_del_init(&psta->asoc_list); pstapriv->asoc_list_cnt--; updated =3D ap_free_sta(padapter, psta, false, reason); - } spin_unlock_bh(&pstapriv->asoc_list_lock); =20 @@ -1567,7 +1547,6 @@ unsigned int OnDisassoc(struct adapter *padapter, uni= on recv_frame *precv_frame) =20 pmlmepriv->link_detect_info.busy_traffic =3D false; return _SUCCESS; - } =20 unsigned int OnAtim(struct adapter *padapter, union recv_frame *precv_fram= e) @@ -1875,11 +1854,9 @@ unsigned int OnAction(struct adapter *padapter, unio= n recv_frame *precv_frame) =20 if (category =3D=3D ptable->num) ptable->func(padapter, precv_frame); - } =20 return _SUCCESS; - } =20 unsigned int DoReserved(struct adapter *padapter, union recv_frame *precv_= frame) @@ -1914,7 +1891,6 @@ static struct xmit_frame *_alloc_mgtxmitframe(struct = xmit_priv *pxmitpriv, bool =20 exit: return pmgntframe; - } =20 inline struct xmit_frame *alloc_mgtxmitframe(struct xmit_priv *pxmitpriv) @@ -1967,7 +1943,6 @@ void update_mgntframe_attrib(struct adapter *padapter= , struct pkt_attrib *pattri pattrib->retry_ctrl =3D true; =20 pattrib->mbssid =3D 0; - } =20 void update_mgntframe_attrib_addr(struct adapter *padapter, struct xmit_fr= ame *pmgntframe) @@ -2158,7 +2133,6 @@ void issue_beacon(struct adapter *padapter, int timeo= ut_ms) } =20 goto _issue_bcn; - } =20 /* below for ad-hoc mode */ @@ -2227,7 +2201,6 @@ void issue_beacon(struct adapter *padapter, int timeo= ut_ms) dump_mgntframe_and_wait(padapter, pmgntframe, timeout_ms); else dump_mgntframe(padapter, pmgntframe); - } =20 void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_val= id_p2p_probereq) @@ -2412,7 +2385,6 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p =20 =20 /* todo:HT for adhoc */ - } =20 pattrib->last_txcmdsz =3D pattrib->pktlen; @@ -2421,7 +2393,6 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p dump_mgntframe(padapter, pmgntframe); =20 return; - } =20 static int _issue_probereq(struct adapter *padapter, @@ -2672,9 +2643,7 @@ void issue_auth(struct adapter *padapter, struct sta_= info *psta, unsigned short pattrib->icv_len =3D 4; =20 pattrib->pktlen +=3D pattrib->icv_len; - } - } =20 pattrib->last_txcmdsz =3D pattrib->pktlen; @@ -2771,7 +2740,6 @@ void issue_asocrsp(struct adapter *padapter, unsigned= short status, struct sta_i pframe +=3D (ie_len + 2); pattrib->pktlen +=3D (ie_len + 2); } - } =20 /* FILL WMM IE */ @@ -2792,7 +2760,6 @@ void issue_asocrsp(struct adapter *padapter, unsigned= short status, struct sta_i if (!pbuf || ie_len =3D=3D 0) break; } - } =20 if (pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_REALTEK) @@ -3619,7 +3586,6 @@ static void issue_action_BSSCoexistPacket(struct adap= ter *padapter) iedata |=3D BIT(2);/* 20 MHz BSS Width Request */ =20 pframe =3D rtw_set_ie(pframe, WLAN_EID_BSS_COEX_2040, 1, &iedata, &(pat= trib->pktlen)); - } =20 =20 @@ -3658,7 +3624,6 @@ static void issue_action_BSSCoexistPacket(struct adap= ter *padapter) if (ICS[0][0] =3D=3D 0) ICS[0][0] =3D 1; } - } =20 spin_unlock_bh(&(pmlmepriv->scanned_queue.lock)); @@ -3686,9 +3651,7 @@ static void issue_action_BSSCoexistPacket(struct adap= ter *padapter) } =20 pframe =3D rtw_set_ie(pframe, WLAN_EID_BSS_INTOLERANT_CHL_REPORT, k, In= foContent, &(pattrib->pktlen)); - } - } =20 =20 @@ -3728,13 +3691,11 @@ unsigned int send_delba(struct adapter *padapter, u= 8 initiator, u8 *addr) issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, (((tid << 1) | init= iator) & 0x1F)); psta->htpriv.agg_enable_bitmap &=3D ~BIT(tid); psta->htpriv.candidate_tid_bitmap &=3D ~BIT(tid); - } } } =20 return _SUCCESS; - } =20 unsigned int send_beacon(struct adapter *padapter) @@ -3839,7 +3800,6 @@ void site_survey(struct adapter *padapter) =20 set_survey_timer(pmlmeext, channel_scan_time_ms); } else { - /* channel number is 0 or this channel is not valid. */ =20 { @@ -3881,7 +3841,6 @@ void site_survey(struct adapter *padapter) } =20 return; - } =20 /* collect bss info from Beacon and Probe request/response frames. */ @@ -4092,7 +4051,6 @@ void start_create_ibss(struct adapter *padapter) } /* update bc/mc sta_info */ update_bmc_sta(padapter); - } =20 void start_clnt_join(struct adapter *padapter) @@ -4151,7 +4109,6 @@ void start_clnt_join(struct adapter *padapter) } else { return; } - } =20 void start_clnt_auth(struct adapter *padapter) @@ -4175,7 +4132,6 @@ void start_clnt_auth(struct adapter *padapter) issue_auth(padapter, NULL, 0); =20 set_link_timer(pmlmeext, REAUTH_TO); - } =20 =20 @@ -4311,7 +4267,6 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid while ((i < MAX_CHANNEL_NUM) && (chplan_sta[i].ChannelNum !=3D 0) && (chplan_sta[i].ChannelNum <=3D 14)) { - chplan_new[k].ChannelNum =3D chplan_sta[i].ChannelNum; chplan_new[k].ScanType =3D SCAN_PASSIVE; i++; @@ -4418,7 +4373,6 @@ void report_survey_event(struct adapter *padapter, un= ion recv_frame *precv_frame pmlmeext->sitesurvey_res.bss_cnt++; =20 return; - } =20 void report_surveydone_event(struct adapter *padapter) @@ -4462,7 +4416,6 @@ void report_surveydone_event(struct adapter *padapter) rtw_enqueue_cmd(pcmdpriv, pcmd_obj); =20 return; - } =20 void report_join_res(struct adapter *padapter, int res) @@ -4512,7 +4465,6 @@ void report_join_res(struct adapter *padapter, int re= s) rtw_enqueue_cmd(pcmdpriv, pcmd_obj); =20 return; - } =20 void report_wmm_edca_update(struct adapter *padapter) @@ -4556,7 +4508,6 @@ void report_wmm_edca_update(struct adapter *padapter) rtw_enqueue_cmd(pcmdpriv, pcmd_obj); =20 return; - } =20 void report_del_sta_event(struct adapter *padapter, unsigned char *MacAddr= , unsigned short reason) @@ -4695,7 +4646,6 @@ void update_sta_info(struct adapter *padapter, struct= sta_info *psta) psta->htpriv.sgi_20m =3D false; psta->htpriv.sgi_40m =3D false; psta->qos_option =3D false; - } =20 psta->htpriv.ch_offset =3D pmlmeext->cur_ch_offset; @@ -4714,7 +4664,6 @@ void update_sta_info(struct adapter *padapter, struct= sta_info *psta) spin_lock_bh(&psta->lock); psta->state =3D _FW_LINKED; spin_unlock_bh(&psta->lock); - } =20 static void rtw_mlmeext_disconnect(struct adapter *padapter) @@ -4760,7 +4709,6 @@ static void rtw_mlmeext_disconnect(struct adapter *pa= dapter) =20 pmlmepriv->link_detect_info.traffic_transition_count =3D 0; pmlmepriv->link_detect_info.low_power_transition_count =3D 0; - } =20 void mlmeext_joinbss_event_callback(struct adapter *padapter, int join_res) @@ -4868,7 +4816,6 @@ void mlmeext_sta_add_event_callback(struct adapter *p= adapter, struct sta_info *p } =20 pmlmeinfo->state |=3D WIFI_FW_ASSOC_SUCCESS; - } =20 join_type =3D 2; @@ -4910,7 +4857,6 @@ void _linked_info_dump(struct adapter *padapter) struct dvobj_priv *pdvobj =3D adapter_to_dvobj(padapter); =20 if (padapter->bLinkInfoDump) { - if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) rtw_hal_get_def_var(padapter, HAL_DEF_UNDERCORATEDSMOOTHEDPWDB, @@ -5138,7 +5084,6 @@ void addba_timer_hdl(struct timer_list *t) if (phtpriv->ht_option && phtpriv->ampdu_enable) { if (phtpriv->candidate_tid_bitmap) phtpriv->candidate_tid_bitmap =3D 0x0; - } } =20 @@ -5247,11 +5192,9 @@ u8 createbss_hdl(struct adapter *padapter, u8 *pbuf) memcpy(pnetwork->ies, ((struct wlan_bssid_ex *)pbuf)->ies, pnetwork->ie_= length); =20 start_create_ibss(padapter); - } =20 return H2C_SUCCESS; - } =20 u8 join_cmd_hdl(struct adapter *padapter, u8 *pbuf) @@ -5395,7 +5338,6 @@ u8 join_cmd_hdl(struct adapter *padapter, u8 *pbuf) start_clnt_join(padapter); =20 return H2C_SUCCESS; - } =20 u8 disconnect_hdl(struct adapter *padapter, unsigned char *pbuf) @@ -5435,7 +5377,6 @@ static int rtw_scan_ch_decision(struct adapter *padap= ter, struct rtw_ieee80211_c /* acquire channels from in */ j =3D 0; for (i =3D 0; i < in_num; i++) { - set_idx =3D rtw_ch_set_search_ch(pmlmeext->channel_set, in[i].hw_value); if (in[i].hw_value && !(in[i].flags & RTW_IEEE80211_CHAN_DISABLED) && set_idx >=3D 0 @@ -5461,7 +5402,6 @@ static int rtw_scan_ch_decision(struct adapter *padap= ter, struct rtw_ieee80211_c /* if out is empty, use channel_set as default */ if (j =3D=3D 0) { for (i =3D 0; i < pmlmeext->max_chan_nums; i++) { - if (j >=3D out_num) { netdev_dbg(padapter->pnetdev, FUNC_ADPT_FMT " out_num:%u not enough\n", diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index f3c1ed9823f9..6d38fffa98dc 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -73,7 +73,6 @@ signed int _rtw_init_recv_priv(struct recv_priv *precvpri= v, struct adapter *pada =20 precvframe->u.hdr.adapter =3D padapter; precvframe++; - } =20 res =3D rtw_hal_init_recv_priv(padapter); @@ -115,7 +114,6 @@ void _rtw_free_recv_priv(struct recv_priv *precvpriv) =20 union recv_frame *_rtw_alloc_recvframe(struct __queue *pfree_recv_queue) { - union recv_frame *precvframe; struct list_head *plist, *phead; struct adapter *padapter; @@ -185,7 +183,6 @@ int rtw_free_recvframe(union recv_frame *precvframe, st= ruct __queue *pfree_recv_ =20 signed int _rtw_enqueue_recvframe(union recv_frame *precvframe, struct __q= ueue *queue) { - struct adapter *padapter =3D precvframe->u.hdr.adapter; struct recv_priv *precvpriv =3D &padapter->recvpriv; =20 @@ -279,7 +276,6 @@ signed int rtw_enqueue_recvbuf(struct recv_buf *precvbu= f, struct __queue *queue) list_add_tail(&precvbuf->list, get_list_head(queue)); spin_unlock_bh(&queue->lock); return _SUCCESS; - } =20 struct recv_buf *rtw_dequeue_recvbuf(struct __queue *queue) @@ -299,13 +295,11 @@ struct recv_buf *rtw_dequeue_recvbuf(struct __queue *= queue) precvbuf =3D container_of(plist, struct recv_buf, list); =20 list_del_init(&precvbuf->list); - } =20 spin_unlock_bh(&queue->lock); =20 return precvbuf; - } =20 static void rtw_handle_tkip_mic_err(struct adapter *padapter, u8 bgroup) @@ -354,7 +348,6 @@ static void rtw_handle_tkip_mic_err(struct adapter *pad= apter, u8 bgroup) =20 static signed int recvframe_chkmic(struct adapter *adapter, union recv_fr= ame *precvframe) { - signed int i, res =3D _SUCCESS; u32 datalen; u8 miccode[8]; @@ -426,18 +419,15 @@ static signed int recvframe_chkmic(struct adapter *ad= apter, union recv_frame *p } =20 recvframe_pull_tail(precvframe, 8); - } =20 exit: return res; - } =20 /* decrypt and set the ivlen, icvlen of the recv_frame */ static union recv_frame *decryptor(struct adapter *padapter, union recv_fr= ame *precv_frame) { - struct rx_pkt_attrib *prxattrib =3D &precv_frame->u.hdr.attrib; struct security_priv *psecuritypriv =3D &padapter->securitypriv; union recv_frame *return_packet =3D precv_frame; @@ -582,7 +572,6 @@ static signed int recv_decache(union recv_frame *precv_= frame, u8 bretry, struct prxcache->tid_rxseq[tid] =3D seq_ctrl; =20 return _SUCCESS; - } =20 static void process_pwrbit_data(struct adapter *padapter, union recv_frame= *precv_frame) @@ -604,7 +593,6 @@ static void process_pwrbit_data(struct adapter *padapte= r, union recv_frame *prec /* pstapriv->sta_dz_bitmap |=3D BIT(psta->aid); */ =20 stop_sta_xmit(padapter, psta); - } } else { if (psta->state & WIFI_SLEEP_STATE) { @@ -614,7 +602,6 @@ static void process_pwrbit_data(struct adapter *padapte= r, union recv_frame *prec wakeup_sta_to_xmit(padapter, psta); } } - } } =20 @@ -715,7 +702,6 @@ static signed int sta2sta_data_frame(struct adapter *ad= apter, union recv_frame * =20 if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { - /* filter packets that SA is myself or multicast or broadcast */ if (!memcmp(myhwaddr, pattrib->src, ETH_ALEN)) { ret =3D _FAIL; @@ -804,7 +790,6 @@ static signed int ap2sta_data_frame(struct adapter *ada= pter, union recv_frame *p (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true || check_fwstate(pmlmepriv, _FW_UNDER_LINKING) =3D=3D true) ) { - /* filter packets that SA is myself or multicast or broadcast */ if (!memcmp(myhwaddr, pattrib->src, ETH_ALEN)) { ret =3D _FAIL; @@ -822,7 +807,6 @@ static signed int ap2sta_data_frame(struct adapter *ada= pter, union recv_frame *p if (is_zero_ether_addr(pattrib->bssid) || is_zero_ether_addr(mybssid) || (memcmp(pattrib->bssid, mybssid, ETH_ALEN))) { - if (!bmcast) issue_deauth(adapter, pattrib->bssid, WLAN_REASON_CLASS3_FRAME_FROM_NO= NASSOC_STA); =20 @@ -874,7 +858,6 @@ static signed int ap2sta_data_frame(struct adapter *ada= pter, union recv_frame *p if (!memcmp(myhwaddr, pattrib->dst, ETH_ALEN) && (!bmcast)) { *psta =3D rtw_get_stainfo(pstapriv, pattrib->bssid); /* get sta_info */ if (!*psta) { - /* for AP multicast issue , modify by yiwei */ static unsigned long send_issue_deauth_time; =20 @@ -1067,7 +1050,6 @@ static signed int validate_recv_ctrl_frame(struct ada= pter *padapter, union recv_ } =20 return _FAIL; - } =20 /* perform defrag */ @@ -1139,7 +1121,6 @@ static union recv_frame *recvframe_defrag(struct adap= ter *adapter, =20 pfhdr->attrib.icv_len =3D pnfhdr->attrib.icv_len; plist =3D get_next(plist); - } =20 /* free the defrag_q queue and return the prframe */ @@ -1212,7 +1193,6 @@ static union recv_frame *recvframe_chk_defrag(struct = adapter *padapter, union re rtw_free_recvframe(precv_frame, pfree_recv_queue); prtnframe =3D NULL; } - } =20 if ((ismfrag =3D=3D 0) && (fragnum !=3D 0)) { @@ -1233,7 +1213,6 @@ static union recv_frame *recvframe_chk_defrag(struct = adapter *padapter, union re rtw_free_recvframe(precv_frame, pfree_recv_queue); prtnframe =3D NULL; } - } =20 =20 @@ -1287,7 +1266,6 @@ static signed int validate_recv_mgnt_frame(struct ada= pter *padapter, union recv_ mgt_dispatcher(padapter, precv_frame); =20 return _SUCCESS; - } =20 static signed int validate_recv_data_frame(struct adapter *adapter, union = recv_frame *precv_frame) @@ -1343,7 +1321,6 @@ static signed int validate_recv_data_frame(struct ada= pter *adapter, union recv_f default: ret =3D _FAIL; break; - } =20 if (ret =3D=3D _FAIL || ret =3D=3D RTW_RX_HANDLED) @@ -1475,7 +1452,6 @@ static signed int validate_80211w_mgmt(struct adapter= *adapter, union recv_frame =20 validate_80211w_fail: return _FAIL; - } =20 static signed int validate_recv_frame(struct adapter *adapter, union recv_= frame *precv_frame) @@ -1735,7 +1711,6 @@ static int amsdu_to_msdu(struct adapter *padapter, un= ion recv_frame *prframe) pdata =3D prframe->u.hdr.rx_data; =20 while (a_len > ETH_HLEN) { - /* Offset 12 denote 2 mac address */ nSubframe_Length =3D get_unaligned_be16(pdata + 12); =20 @@ -1843,7 +1818,6 @@ static int enqueue_reorder_recvframe(struct recv_reor= der_ctrl *preorder_ctrl, un return false; else break; - } =20 =20 @@ -1858,7 +1832,6 @@ static int enqueue_reorder_recvframe(struct recv_reor= der_ctrl *preorder_ctrl, un /* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */ =20 return true; - } =20 static int rtw_recv_indicatepkt(struct adapter *padapter, union recv_frame= *precv_frame) @@ -1926,13 +1899,11 @@ static int recv_indicatepkts_in_order(struct adapte= r *padapter, struct recv_reor pattrib =3D &prframe->u.hdr.attrib; =20 preorder_ctrl->indicate_seq =3D pattrib->seq_num; - } =20 /* Prepare indication list and indication. */ /* Check if there is any packet need indicate. */ while (!list_empty(phead)) { - prframe =3D (union recv_frame *)plist; pattrib =3D &prframe->u.hdr.attrib; =20 @@ -1970,7 +1941,6 @@ static int recv_indicatepkts_in_order(struct adapter = *padapter, struct recv_reor bPktInBuf =3D true; break; } - } =20 /* spin_unlock(&ppending_recvframe_queue->lock); */ @@ -1995,11 +1965,9 @@ static int recv_indicatepkt_reorder(struct adapter *= padapter, union recv_frame * (padapter->bSurpriseRemoved =3D=3D false)) { rtw_recv_indicatepkt(padapter, prframe); return _SUCCESS; - } =20 return _FAIL; - } =20 if (preorder_ctrl->enable =3D=3D false) { @@ -2083,7 +2051,6 @@ void rtw_reordering_ctrl_timeout_handler(struct timer= _list *t) _set_timer(&preorder_ctrl->reordering_ctrl_timer, REORDER_WAIT_TIME); =20 spin_unlock_bh(&ppending_recvframe_queue->lock); - } =20 static int process_recv_indicatepkts(struct adapter *padapter, union recv_= frame *prframe) @@ -2117,11 +2084,9 @@ static int process_recv_indicatepkts(struct adapter = *padapter, union recv_frame retval =3D _FAIL; return retval; } - } =20 return retval; - } =20 static int recv_func_prehandle(struct adapter *padapter, union recv_frame = *rframe) @@ -2195,7 +2160,6 @@ static int recv_func(struct adapter *padapter, union = recv_frame *rframe) ret =3D recv_func_prehandle(padapter, rframe); =20 if (ret =3D=3D _SUCCESS) { - /* check if need to enqueue into uc_swdec_pending_queue*/ if (check_fwstate(mlmepriv, WIFI_STATION_STATE) && !is_multicast_ether_addr(prxattrib->ra) && prxattrib->encrypt > 0 && @@ -2263,7 +2227,6 @@ static void rtw_signal_stat_timer_hdl(struct timer_li= st *t) adapter->recvpriv.signal_strength =3D adapter->recvpriv.signal_strength_= dbg; adapter->recvpriv.rssi =3D (s8)translate_percentage_to_dbm((u8)adapter->= recvpriv.signal_strength_dbg); } else { - if (recvpriv->signal_strength_data.update_req =3D=3D 0) {/* update_req = is clear, means we got rx */ avg_signal_strength =3D recvpriv->signal_strength_data.avg_val; num_signal_strength =3D recvpriv->signal_strength_data.total_num; @@ -2316,5 +2279,4 @@ static void rtw_signal_stat_timer_hdl(struct timer_li= st *t) =20 set_timer: rtw_set_signal_stat_timer(recvpriv); - } diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/stagin= g/rtl8723bs/core/rtw_security.c index e95daba50fbf..8358499b6f89 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -123,7 +123,6 @@ void rtw_wep_decrypt(struct adapter *padapter, u8 *pre= cvframe) =20 /* calculate icv and compare the icv */ *((u32 *)crc) =3D ~crc32_le(~0, payload, length - 4); - } } =20 @@ -198,7 +197,6 @@ void rtw_secgetmic(struct mic_data *pmicdata, u8 *dst) =20 void rtw_seccalctkipmic(u8 *key, u8 *header, u8 *data, u32 data_len, u8 *m= ic_code, u8 pri) { - struct mic_data micdata; u8 priority[4] =3D {0x0, 0x0, 0x0, 0x0}; =20 @@ -450,7 +448,6 @@ u32 rtw_tkip_encrypt(struct adapter *padapter, u8 *pxmi= tframe) =20 /* 4 start to encrypt each fragment */ if (pattrib->encrypt =3D=3D _TKIP_) { - { if (is_multicast_ether_addr(pattrib->ra)) prwskey =3D psecuritypriv->dot118021XGrpKey[psecuritypriv->dot118021XG= rpKeyid].skey; --=20 2.53.0 From nobody Thu Jun 11 22:58:33 2026 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 626753B52F0 for ; Mon, 13 Apr 2026 10:15:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075356; cv=none; b=hFMfoYI4T/wO4ZYgOxm2Q2/q9A/BAYIWaxjcuq/L0jAP8XKDZEnGKIYkU3aS79WVRTbYLH8Jf9TTP+XqeBfSZvWVL2kB5WhpScmvVYYHwaqxe6UdUmsB2NLiM9hhph9G/3ELQWGftt0XDdjfPaq/owWb850shwdaPNtzUdWZNKc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075356; c=relaxed/simple; bh=65NOn+3vNlKLCSyIQSUoNOvGWMQmzKIL8F1Yk4lx8nc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ByWr73R0LYZ2jMPaXaGepGMNuEs6qixObR+d7XIMtusOVh7NEzEAYc+cCXb4oNPCFOqN+RKoqB01+0O05ejFkJsMF1ywdd+vJxDmem8rU9kMKLkOzZEA/wV3JW/bV5ZNMnIjFf6zgGyPKk5xWOMNnco2djGo/0Hwvbo8Wy5YCKE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=XWVXQs/N; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="XWVXQs/N" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776075351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/sN7i0E//4kLCw75+iZDCkT4FpOU5bSfmTRKqMkIa+A=; b=XWVXQs/N47Hd+lbvVqOAcA1czyRHQjxFIEn3BKKRKtB068WMVw2zbBe9T01uDRnznRERnF 27LhUZS9p0bgF7RWYdwzE1WIEk0g1g3OMR/76X+nxurmdCTh8KXGVd1OVXBZMh31bJOVJO t30rhDYvdB5WUNOUbAwSl/oTqP3twOo= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Luka Gejak , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [PATCH 08/11] staging: rtl8723bs: hal: remove blank lines before closing brace Date: Mon, 13 Apr 2026 12:14:29 +0200 Message-ID: <20260413101432.158925-9-luka.gejak@linux.dev> In-Reply-To: <20260413101432.158925-1-luka.gejak@linux.dev> References: <20260413101432.158925-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Luka Gejak Remove empty lines immediately preceding a closing brace in the hal directory to adhere to the Linux kernel coding style. This resolves "Blank lines aren't necessary before a close brace" warnings reported by checkpatch.pl. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 -------- drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 2 -- drivers/staging/rtl8723bs/hal/HalPhyRf.c | 1 - drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 12 ------------ drivers/staging/rtl8723bs/hal/hal_com.c | 5 ----- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 2 -- drivers/staging/rtl8723bs/hal/odm.c | 10 ---------- drivers/staging/rtl8723bs/hal/odm_DIG.c | 5 ----- .../staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c | 1 - drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 7 ------- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 6 ------ drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 3 --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 --- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 4 ---- drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 3 --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 1 - drivers/staging/rtl8723bs/hal/sdio_halinit.c | 5 ----- drivers/staging/rtl8723bs/hal/sdio_ops.c | 1 - 18 files changed, 79 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/stag= ing/rtl8723bs/hal/HalBtc8723b1Ant.c index 87b07187efaf..0024c6cbe515 100644 --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c @@ -236,7 +236,6 @@ static void halbtc8723b1ant_LimitedRx( /* real update aggregation setting */ pBtCoexist->fBtcSet(pBtCoexist, BTC_SET_ACT_AGGREGATE_CTRL, NULL); =20 - } =20 static void halbtc8723b1ant_QueryBtInfo(struct btc_coexist *pBtCoexist) @@ -368,7 +367,6 @@ static void halbtc8723b1ant_MonitorWiFiCtr(struct btc_c= oexist *pBtCoexist) } =20 if (!pCoexSta->bPreCCKLock) { - if (nCCKLockCounter >=3D 5) pCoexSta->bCCKLock =3D true; else @@ -382,7 +380,6 @@ static void halbtc8723b1ant_MonitorWiFiCtr(struct btc_c= oexist *pBtCoexist) =20 pCoexSta->bPreCCKLock =3D pCoexSta->bCCKLock; =20 - } =20 static bool halbtc8723b1ant_IsWifiStatusChanged(struct btc_coexist *pBtCoe= xist) @@ -585,7 +582,6 @@ static u8 halbtc8723b1ant_ActionAlgorithm(struct btc_co= exist *pBtCoexist) ) { if (!bBtHsOn) algorithm =3D BT_8723B_1ANT_COEX_ALGO_PANEDR_HID; - } } } @@ -914,13 +910,11 @@ static void halbtc8723b1ant_SetAntPath( pBtCoexist->fBtcWrite1ByteBitMask(pBtCoexist, 0x64, 0x1, 0x0); =20 if (pBoardInfo->btdmAntPos =3D=3D BTC_ANTENNA_AT_MAIN_PORT) { - /* tell firmware "no antenna inverse" */ H2C_Parameter[0] =3D 0; H2C_Parameter[1] =3D 0; /* internal switch type */ pBtCoexist->fBtcFillH2c(pBtCoexist, 0x65, 2, H2C_Parameter); } else { - /* tell firmware "antenna inverse" */ H2C_Parameter[0] =3D 1; H2C_Parameter[1] =3D 0; /* internal switch type */ @@ -1234,7 +1228,6 @@ static void halbtc8723b1ant_PsTdma( break; } } else { - /* disable PS tdma */ switch (type) { case 8: /* PTA Control */ @@ -1912,7 +1905,6 @@ static void halbtc8723b1ant_RunSwCoexistMechanism(str= uct btc_coexist *pBtCoexist pCoexDm->curAlgorithm =3D algorithm; =20 if (halbtc8723b1ant_IsCommonAction(pBtCoexist)) { - } else { switch (pCoexDm->curAlgorithm) { case BT_8723B_1ANT_COEX_ALGO_SCO: diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c b/drivers/stag= ing/rtl8723bs/hal/HalBtc8723b2Ant.c index 9d82ccf6e138..132d91be5c82 100644 --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c @@ -1579,7 +1579,6 @@ static void halbtc8723b2ant_TdmaDurationAdjust( =20 if (!bScan && !bLink && !bRoam) halbtc8723b2ant_PsTdma(pBtCoexist, NORMAL_EXEC, true, pCoexDm->psTdmaDu= AdjType); - } } =20 @@ -2483,7 +2482,6 @@ void EXhalbtc8723b2ant_BtInfoNotify( pCoexSta->btInfoC2h[rspSource][i] =3D tmpBuf[i]; if (i =3D=3D 1) btInfo =3D tmpBuf[i]; - } =20 if (pBtCoexist->bManualControl) { diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf.c b/drivers/staging/rtl= 8723bs/hal/HalPhyRf.c index 254bfef543b1..4a4052ce3ee0 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf.c @@ -57,7 +57,6 @@ void ODM_ClearTxPowerTrackingState(struct dm_odm_t *pDM_O= dm) =20 void ODM_TXPowerTrackingCallback_ThermalMeter(struct adapter *Adapter) { - struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); struct dm_odm_t *pDM_Odm =3D &pHalData->odmpriv; =20 diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.c index 16006c74a4c3..56d6e3061d9b 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -172,7 +172,6 @@ void ODM_TxPwrTrackSetPwr_8723B( TxRate =3D HwRateToMRate(pDM_Odm->TxRate); } else /* force rate */ TxRate =3D (u8)rate; - } =20 if (TxRate !=3D 0xFF) { @@ -978,7 +977,6 @@ static void _PHY_PathAFillIQKMatrix8723B( PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_RxIQExtAnta, 0xF0000000, reg); pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xCA0][KEY] =3D rOFDM0_RxIQEx= tAnta; pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xCA0][VAL] =3D PHY_QueryBBRe= g(pDM_Odm->Adapter, rOFDM0_RxIQExtAnta, bMaskDWord); - } } =20 @@ -1064,7 +1062,6 @@ static void _PHY_PathBFillIQKMatrix8723B( =20 void ODM_SetIQCbyRFpath(struct dm_odm_t *pDM_Odm, u32 RFpath) { - struct odm_rf_cal_t *pRFCalibrateInfo =3D &pDM_Odm->RFCalibrateInfo; u8 path; =20 @@ -1126,7 +1123,6 @@ static void _PHY_SaveMACRegisters8723B( MACBackup[i] =3D rtw_read8(pDM_Odm->Adapter, MACReg[i]); } MACBackup[i] =3D rtw_read32(pDM_Odm->Adapter, MACReg[i]); - } =20 =20 @@ -1181,7 +1177,6 @@ static void _PHY_PathADDAOn8723B( for (i =3D 1 ; i < IQK_ADDA_REG_NUM ; i++) { PHY_SetBBReg(pDM_Odm->Adapter, ADDAReg[i], bMaskDWord, pathOn); } - } =20 static void _PHY_MACSettingCalibration8723B( @@ -1198,7 +1193,6 @@ static void _PHY_MACSettingCalibration8723B( rtw_write8(pDM_Odm->Adapter, MACReg[i], (u8)(MACBackup[i] & (~BIT3))); } rtw_write8(pDM_Odm->Adapter, MACReg[i], (u8)(MACBackup[i] & (~BIT5))); - } =20 static bool phy_SimularityCompare_8723B( @@ -1217,7 +1211,6 @@ static bool phy_SimularityCompare_8723B( SimularityBitMap =3D 0; =20 for (i =3D 0; i < bound; i++) { - if ((i =3D=3D 1) || (i =3D=3D 3) || (i =3D=3D 5) || (i =3D=3D 7)) { if ((result[c1][i] & 0x00000200) !=3D 0) tmp1 =3D result[c1][i] | 0xFFFFFC00; @@ -1258,7 +1251,6 @@ static bool phy_SimularityCompare_8723B( } return bResult; } else { - if (!(SimularityBitMap & 0x03)) { /* path A TX OK */ for (i =3D 0; i < 2; i++) result[3][i] =3D result[c1][i]; @@ -1344,7 +1336,6 @@ static void phy_IQCalibrate_8723B( /* u32 bbvalue; */ =20 if (t =3D=3D 0) { - /* Save ADDA parameters, turn Path A ADDA on */ _PHY_SaveADDARegisters8723B(padapter, ADDA_REG, pDM_Odm->RFCalibrateInfo= .ADDA_backup, IQK_ADDA_REG_NUM); _PHY_SaveMACRegisters8723B(padapter, IQK_MAC_REG, pDM_Odm->RFCalibrateIn= fo.IQK_MAC_backup); @@ -1420,7 +1411,6 @@ static void phy_IQCalibrate_8723B( =20 /* path B IQK */ if (is2T) { - /* path B TX IQK */ for (i =3D 0 ; i < retryCount ; i++) { PathBOK =3D phy_PathB_IQK_8723B(padapter); @@ -1478,9 +1468,7 @@ static void phy_IQCalibrate_8723B( /* load 0xe30 IQC default value */ PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_Tone_A, bMaskDWord, 0x01008c00); PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_Tone_A, bMaskDWord, 0x01008c00); - } - } =20 =20 diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 0444650798f2..33b3a1b942c1 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -294,7 +294,6 @@ void HalSetBrateCfg(struct adapter *Adapter, u8 *mBrate= sOS, u16 *pBrateCfg) u8 i, is_brate, brate; =20 for (i =3D 0; i < NDIS_802_11_LENGTH_RATES_EX; i++) { - is_brate =3D mBratesOS[i] & IEEE80211_BASIC_RATE_MASK; brate =3D mBratesOS[i] & 0x7f; =20 @@ -392,9 +391,7 @@ static void _TwoOutPipeMapping(struct adapter *padapter= , bool bWIFICfg) pdvobjpriv->Queue2Pipe[5] =3D pdvobjpriv->RtOutPipe[0];/* MGT */ pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0];/* HIGH */ pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0];/* TXCMD */ - } - } =20 static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg) @@ -434,7 +431,6 @@ static void _ThreeOutPipeMapping(struct adapter *padapt= er, bool bWIFICfg) pdvobjpriv->Queue2Pipe[6] =3D pdvobjpriv->RtOutPipe[0];/* HIGH */ pdvobjpriv->Queue2Pipe[7] =3D pdvobjpriv->RtOutPipe[0];/* TXCMD */ } - } =20 bool Hal_MappingOutPipe(struct adapter *padapter, u8 NumOutPipe) @@ -462,7 +458,6 @@ bool Hal_MappingOutPipe(struct adapter *padapter, u8 Nu= mOutPipe) } =20 return result; - } =20 void hal_init_macaddr(struct adapter *adapter) diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index dd91ce3a8e37..0d94760a011a 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -445,7 +445,6 @@ void PHY_SetTxPowerIndexByRateSection( pHalData->CurrentChannelBW, Channel, htRates1T, ARRAY_SIZE(htRates1T)); - } } =20 @@ -590,7 +589,6 @@ s8 PHY_GetTxPowerByRate(struct adapter *padapter, u8 RF= Path, u8 Rate) return value; =20 return pHalData->TxPwrByRateOffset[RFPath][rateIndex]; - } =20 void PHY_SetTxPowerByRate( diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723b= s/hal/odm.c index f33cc282f3b2..c594ca250113 100644 --- a/drivers/staging/rtl8723bs/hal/odm.c +++ b/drivers/staging/rtl8723bs/hal/odm.c @@ -249,7 +249,6 @@ u32 ODM_Get_Rate_Bitmap( } =20 return ra_mask & rate_bitmap; - } =20 static void odm_RefreshRateAdaptiveMaskCE(struct dm_odm_t *pDM_Odm) @@ -273,7 +272,6 @@ static void odm_RefreshRateAdaptiveMaskCE(struct dm_odm= _t *pDM_Odm) if (true =3D=3D ODM_RAStateCheck(pDM_Odm, pstat->rssi_stat.UndecoratedS= moothedPWDB, false, &pstat->rssi_level)) { rtw_hal_update_ra_mask(pstat, pstat->rssi_level); } - } } } @@ -297,7 +295,6 @@ static void odm_RefreshRateAdaptiveMaskCE(struct dm_odm= _t *pDM_Odm) */ static void odm_RefreshRateAdaptiveMask(struct dm_odm_t *pDM_Odm) { - if (!(pDM_Odm->SupportAbility & ODM_BB_RA_MASK)) return; =20 @@ -369,7 +366,6 @@ static void odm_RSSIMonitorInit(struct dm_odm_t *pDM_Od= m) struct ra_t *pRA_Table =3D &pDM_Odm->DM_RA_Table; =20 pRA_Table->firstconnect =3D false; - } =20 static void FindMinimumRSSI(struct adapter *padapter) @@ -543,7 +539,6 @@ void odm_TXPowerTrackingInit(struct dm_odm_t *pDM_Odm) pDM_Odm->RFCalibrateInfo.DeltaPowerIndexLast[p] =3D 0; pDM_Odm->RFCalibrateInfo.PowerIndexOffset[p] =3D 0; } - } =20 void ODM_TXPowerTrackingCheck(struct dm_odm_t *pDM_Odm) @@ -573,7 +568,6 @@ void ODM_TXPowerTrackingCheck(struct dm_odm_t *pDM_Odm) /* */ void ODM_DMInit(struct dm_odm_t *pDM_Odm) { - odm_CommonInfoSelfInit(pDM_Odm); odm_DIGInit(pDM_Odm); odm_NHMCounterStatisticsInit(pDM_Odm); @@ -732,7 +726,6 @@ void ODM_CmnInfoInit(struct dm_odm_t *pDM_Odm, enum odm= _cmninfo_e CmnInfo, u32 V /* do nothing */ break; } - } =20 =20 @@ -856,7 +849,6 @@ void ODM_CmnInfoHook(struct dm_odm_t *pDM_Odm, enum odm= _cmninfo_e CmnInfo, void /* do nothing */ break; } - } =20 =20 @@ -882,7 +874,6 @@ void ODM_CmnInfoPtrArrayHook( /* do nothing */ break; } - } =20 =20 @@ -985,7 +976,6 @@ void ODM_CmnInfoUpdate(struct dm_odm_t *pDM_Odm, u32 Cm= nInfo, u64 Value) break; } =20 - } =20 /* 3 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ diff --git a/drivers/staging/rtl8723bs/hal/odm_DIG.c b/drivers/staging/rtl8= 723bs/hal/odm_DIG.c index 8b754923b7d4..7e8a47606835 100644 --- a/drivers/staging/rtl8723bs/hal/odm_DIG.c +++ b/drivers/staging/rtl8723bs/hal/odm_DIG.c @@ -293,7 +293,6 @@ void ODM_Write_DIG(void *pDM_VOID, u8 CurrentIGI) if (!pDM_DigTable->bPSDInProgress) { if (CurrentIGI > pDM_DigTable->rx_gain_range_max) CurrentIGI =3D pDM_DigTable->rx_gain_range_max; - } =20 /* 1 Set IGI value */ @@ -303,7 +302,6 @@ void ODM_Write_DIG(void *pDM_VOID, u8 CurrentIGI) =20 pDM_DigTable->CurIGValue =3D CurrentIGI; } - } =20 bool odm_DigAbort(void *pDM_VOID) @@ -477,7 +475,6 @@ void odm_DIG(void *pDM_VOID) =20 /* 1 Adjust initial gain by false alarm */ if (pDM_Odm->bLinked && bPerformance) { - if (bFirstTpTarget || FirstConnect) { pDM_DigTable->LargeFAHit =3D 0; =20 @@ -506,7 +503,6 @@ void odm_DIG(void *pDM_VOID) } } } else { - if (FirstDisConnect || bFirstCoverage) { CurrentIGI =3D dm_dig_min; } else { @@ -754,7 +750,6 @@ u8 odm_ForbiddenIGICheck(void *pDM_VOID, u8 DIG_Dynamic= _MIN, u8 CurrentIGI) } =20 return rx_gain_range_min; - } =20 /* 3 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ diff --git a/drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c b/dri= vers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c index bb342d7004fd..9a1076dc0009 100644 --- a/drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c +++ b/drivers/staging/rtl8723bs/hal/odm_DynamicBBPowerSaving.c @@ -33,7 +33,6 @@ void ODM_RF_Saving(void *pDM_VOID, u8 bForceInNormal) } =20 if (pDM_PSTable->initialize =3D=3D 0) { - pDM_PSTable->Reg874 =3D (PHY_QueryBBReg(pDM_Odm->Adapter, 0x874, bMaskDW= ord) & 0x1CC000) >> 14; pDM_PSTable->RegC70 =3D (PHY_QueryBBReg(pDM_Odm->Adapter, 0xc70, bMaskDW= ord) & BIT3) >> 3; pDM_PSTable->Reg85C =3D (PHY_QueryBBReg(pDM_Odm->Adapter, 0x85c, bMaskDW= ord) & 0xFF000000) >> 24; diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging= /rtl8723bs/hal/odm_HWConfig.c index a0c163979916..c575c42d1757 100644 --- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c +++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c @@ -18,7 +18,6 @@ static u8 odm_query_rx_pwr_percentage(s8 ant_power) return 100; else return 100 + ant_power; - } =20 s32 odm_signal_scale_mapping(struct dm_odm_t *dm_odm, s32 curr_sig) @@ -162,7 +161,6 @@ static void odm_rx_phy_status_parsing(struct dm_odm_t *= dm_odm, sq =3D 100; else sq =3D ((64 - sq_rpt) * 100) / 44; - } =20 phy_info->signal_quality =3D sq; @@ -250,7 +248,6 @@ static void odm_Process_RSSIForDM( struct dm_odm_t *pDM_Odm, struct odm_phy_info *pPhyInfo, struct odm_packe= t_info *pPktinfo ) { - s32 UndecoratedSmoothedPWDB, UndecoratedSmoothedCCK, UndecoratedSmoothedO= FDM, RSSI_Ave; u8 isCCKrate =3D 0; u8 RSSI_max, RSSI_min, i; @@ -278,7 +275,6 @@ static void odm_Process_RSSIForDM( =20 /* Statistic for antenna/path diversity------------------ */ if (pDM_Odm->SupportAbility & ODM_BB_ANT_DIV) { - } =20 /* Smart Antenna Debug Message------------------ */ @@ -288,7 +284,6 @@ static void odm_Process_RSSIForDM( UndecoratedSmoothedPWDB =3D pEntry->rssi_stat.UndecoratedSmoothedPWDB; =20 if (pPktinfo->to_self || pPktinfo->is_beacon) { - if (!isCCKrate) { /* ofdm rate */ if (pPhyInfo->rx_mimo_signal_strength[RF_PATH_B] =3D=3D 0) { RSSI_Ave =3D pPhyInfo->rx_mimo_signal_strength[RF_PATH_A]; @@ -385,7 +380,6 @@ static void odm_Process_RSSIForDM( pEntry->rssi_stat.UndecoratedSmoothedOFDM =3D UndecoratedSmoothedOFDM; pEntry->rssi_stat.UndecoratedSmoothedPWDB =3D UndecoratedSmoothedPWDB; } - } } =20 @@ -396,7 +390,6 @@ static void odm_Process_RSSIForDM( void odm_phy_status_query(struct dm_odm_t *dm_odm, struct odm_phy_info *ph= y_info, u8 *phy_status, struct odm_packet_info *pkt_info) { - odm_rx_phy_status_parsing(dm_odm, phy_info, phy_status, pkt_info); =20 if (!dm_odm->RSSI_test) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging= /rtl8723bs/hal/rtl8723b_cmd.c index 79f3f723fd5b..1b576bcd0c5f 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c @@ -31,7 +31,6 @@ static u8 _is_fw_read_cmd_down(struct adapter *padapter, = u8 msgbox_num) } while ((!read_down) && (retry_cnts--)); =20 return read_down; - } =20 =20 @@ -188,7 +187,6 @@ static void ConstructBeacon(struct adapter *padapter, u= 8 *pframe, u32 *pLength) return; =20 *pLength =3D pktlen; - } =20 static void ConstructPSPoll(struct adapter *padapter, u8 *pframe, u32 *pLe= ngth) @@ -416,12 +414,10 @@ void rtl8723b_set_FwPwrMode_cmd(struct adapter *padap= ter, u8 psmode) /* reset adaptive_early_32k cnt */ pmlmeext->bcn_delay_cnt[i] =3D 0; pmlmeext->bcn_delay_ratio[i] =3D 0; - } =20 pmlmeext->bcn_cnt =3D 0; pmlmeext->adaptive_tsf_done =3D true; - } =20 /* offload to FW if fw version > v15.10 @@ -431,7 +427,6 @@ void rtl8723b_set_FwPwrMode_cmd(struct adapter *padapte= r, u8 psmode) if ((pmlmeext->DrvBcnEarly!=3D 0Xff) && (pmlmeext->DrvBcnTimeOut!=3D 0xf= f)) u1H2CPwrModeParm[H2C_PWRMODE_LEN-1] =3D BIT(0) | ((pmlmeext->DrvBcnEarl= y<<1)&0x0E) |((pmlmeext->DrvBcnTimeOut<<4)&0xf0) ; */ - } =20 hal_btcoex_RecordPwrMode(padapter, u1H2CPwrModeParm, H2C_PWRMODE_LEN); @@ -458,7 +453,6 @@ void rtl8723b_set_FwPsTuneParam_cmd(struct adapter *pad= apter) =20 void rtl8723b_set_FwPwrModeInIPS_cmd(struct adapter *padapter, u8 cmd_para= m) { - FillH2CCmd8723B(padapter, H2C_8723B_FWLPS_IN_IPS_, 1, &cmd_param); } =20 diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/= rtl8723bs/hal/rtl8723b_dm.c index eaa4306716ff..423be22073d2 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c @@ -17,7 +17,6 @@ /* */ static void Init_ODM_ComInfo_8723b(struct adapter *Adapter) { - struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); struct dm_odm_t *pDM_Odm =3D &pHalData->odmpriv; struct dm_priv *pdmpriv =3D &pHalData->dmpriv; @@ -193,7 +192,6 @@ void rtl8723b_hal_dm_in_lps(struct adapter *padapter) =20 rtl8723b_set_rssi_cmd(padapter, (u8 *)&PWDB_rssi); } - } =20 void rtl8723b_HalDmWatchDog_in_LPS(struct adapter *Adapter) @@ -251,7 +249,6 @@ void rtl8723b_HalDmWatchDog_in_LPS(struct adapter *Adap= ter) skip_lps_dm: =20 return; - } =20 void rtl8723b_init_dm_priv(struct adapter *Adapter) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 07e212552e52..2be52a2d22b3 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -785,7 +785,6 @@ static void hal_ReadEFuse_BT( =20 if ((eFuse_Addr - 1) < total) break; - } =20 /* switch bank back to bank 0 for later BT and wifi use. */ @@ -1959,7 +1958,6 @@ static void hw_var_set_opmode(struct adapter *padapte= r, u8 variable, u8 *val) ResumeTxBeacon(padapter); rtw_write8(padapter, REG_BCN_CTRL, DIS_TSF_UDT | EN_BCN_FUNCTION | DIS_= BCNQ_SUB); } else if (mode =3D=3D _HW_STATE_AP_) { - ResumeTxBeacon(padapter); =20 rtw_write8(padapter, REG_BCN_CTRL, DIS_TSF_UDT | DIS_BCNQ_SUB); @@ -2207,7 +2205,6 @@ static void hw_var_set_mlme_join(struct adapter *pada= pter, u8 variable, u8 *val) =20 void CCX_FwC2HTxRpt_8723b(struct adapter *padapter, u8 *pdata, u8 len) { - #define GET_8723B_C2H_TX_RPT_LIFE_TIME_OVER(_Header) LE_BITS_TO_1BYTE((_He= ader + 0), 6, 1) #define GET_8723B_C2H_TX_RPT_RETRY_OVER(_Header) LE_BITS_TO_1BYTE((_Header= + 0), 7, 1) =20 diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/stag= ing/rtl8723bs/hal/rtl8723b_phycfg.c index 51e9f06b2c63..4ffd849ca941 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -46,7 +46,6 @@ u32 PHY_QueryBBReg_8723B(struct adapter *Adapter, u32 Reg= Addr, u32 BitMask) BitShift =3D phy_CalculateBitShift(BitMask); =20 return (OriginalValue & BitMask) >> BitShift; - } =20 =20 @@ -80,7 +79,6 @@ void PHY_SetBBReg_8723B( } =20 rtw_write32(Adapter, RegAddr, Data); - } =20 =20 @@ -141,7 +139,6 @@ static u32 phy_RFSerialRead_8723B( retValue =3D PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBack | MaskforPh= ySet, bLSSIReadBackData); } return retValue; - } =20 /** @@ -329,7 +326,6 @@ static void phy_InitBBRFRegisterDefinition(struct adapt= er *Adapter) pHalData->PHYRegDef[RF_PATH_B].rfLSSIReadBack =3D rFPGA0_XB_LSSIReadBack; pHalData->PHYRegDef[RF_PATH_A].rfLSSIReadBackPi =3D TransceiverA_HSPI_Rea= dback; pHalData->PHYRegDef[RF_PATH_B].rfLSSIReadBackPi =3D TransceiverB_HSPI_Rea= dback; - } =20 static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c b/drivers/stag= ing/rtl8723bs/hal/rtl8723b_rf6052.c index ffb35e1ace62..2d76ab34bb3e 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c @@ -76,7 +76,6 @@ void PHY_RF6052SetBandwidth8723B( default: break; } - } =20 static int phy_RF6052_Config_ParaFile(struct adapter *Adapter) @@ -91,7 +90,6 @@ static int phy_RF6052_Config_ParaFile(struct adapter *Ada= pter) /* 3----------------------------------------------------------------- */ /* for (eRFPath =3D RF_PATH_A; eRFPath NumTotalRFPath; eRFPath= ++) */ for (eRFPath =3D 0; eRFPath < pHalData->NumTotalRFPath; eRFPath++) { - pPhyReg =3D &pHalData->PHYRegDef[eRFPath]; =20 /*----Store original RFENV control type----*/ @@ -162,7 +160,6 @@ int PHY_RF6052_Config8723B(struct adapter *Adapter) /* Config BB and RF */ /* */ return phy_RF6052_Config_ParaFile(Adapter); - } =20 /* End of HalRf6052.c */ diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index fc075a4e146f..a3012679a3b5 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -520,7 +520,6 @@ s32 rtl8723bs_hal_xmitframe_enqueue( } =20 return err; - } =20 /* diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 3b4d036d2caa..c476ebd0e600 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -232,7 +232,6 @@ static void _InitNormalChipOneOutEpPriority(struct adap= ter *Adapter) _InitNormalChipRegPriority( Adapter, value, value, value, value, value, value ); - } =20 static void _InitNormalChipTwoOutEpPriority(struct adapter *Adapter) @@ -280,7 +279,6 @@ static void _InitNormalChipTwoOutEpPriority(struct adap= ter *Adapter) } =20 _InitNormalChipRegPriority(Adapter, beQ, bkQ, viQ, voQ, mgtQ, hiQ); - } =20 static void _InitNormalChipThreeOutEpPriority(struct adapter *padapter) @@ -326,7 +324,6 @@ static void _InitQueuePriority(struct adapter *Adapter) break; } =20 - } =20 static void _InitPageBoundary(struct adapter *padapter) @@ -530,7 +527,6 @@ static void _InitOperationMode(struct adapter *padapter) } =20 rtw_write8(padapter, REG_BWOPMODE, regBwOpMode); - } =20 static void _InitInterrupt(struct adapter *padapter) @@ -619,7 +615,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* do polling cpwm */ start_time =3D jiffies; do { - mdelay(1); =20 rtw_hal_get_hwreg(padapter, HW_VAR_CPWM, &cpwm_now); diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl= 8723bs/hal/sdio_ops.c index 8cece69dbf79..6929a18202af 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c @@ -614,7 +614,6 @@ static u16 sdio_local_cmd52_read2byte(struct adapter *a= dapter, u32 addr) =20 static u32 sdio_local_cmd53_read4byte(struct adapter *adapter, u32 addr) { - u8 mac_pwr_ctrl_on; u32 val =3D 0; struct intf_hdl *intfhdl =3D &adapter->iopriv.intf; --=20 2.53.0 From nobody Thu Jun 11 22:58:33 2026 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E42A33ACA6F for ; Mon, 13 Apr 2026 10:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075359; cv=none; b=nX+chnsh5/PWPjzJuJ9p2xzAWHuRsnh6HOI6gLxr4eOgmWayMeqQ1AQVNJtWbRPZP8YzMdNN/T/lEPjTKZ40pmUaI0gs7Y3Z0riTRBni3jW/qZ/9KEYQ22PbxhbVLs/MoexqPnUYwubmjwS43csyMDo5a3YMZWjzntyi2A8Lr1g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075359; c=relaxed/simple; bh=otXB5VcUaTZ6Grd+/pSMjdOw4IBGTtx4RqrduBbEOsY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zftx7p2vAOnBrsJQOj+UCJ+Ax05LNXwoPjv5ZglkiH8fkXJefJUaV0dinE1YiOQXKfTvwptOQE8158twexdTtws3Ip9QNgGefmAxKwpogjPWyyG6bewHzGPXco48/cj3uwQS+X28SK/cjNQiksBK4RnsGpRfLG9+j8Z1RdN/pxI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=YNuc3J1z; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="YNuc3J1z" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776075356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bBAFvJKdbJQBv8ulDEnQpow37aZfHxjdPr7A83AbeIc=; b=YNuc3J1znbLqFYDQzICuzLF5a1icrWwkBeRQlsBVV88yB+6gQ20rN2B8L/ffYMr572lwf5 XDeS1kjF+8M+RlV/3ri/lLrUtoAosWrnliWwwrym+SIWreB/F578lyDznSwogHzgEWkOj2 BuZ/UPsnr4gvbUR9jLlKF9bMpHIigG4= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Luka Gejak , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [PATCH 09/11] staging: rtl8723bs: os_dep: remove unnecessary braces Date: Mon, 13 Apr 2026 12:14:30 +0200 Message-ID: <20260413101432.158925-10-luka.gejak@linux.dev> In-Reply-To: <20260413101432.158925-1-luka.gejak@linux.dev> References: <20260413101432.158925-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Luka Gejak Remove unnecessary braces around single-statement blocks in the os_dep directory to adhere to the Linux kernel coding style. This resolves unnecessary braces warnings reported by checkpatch.pl. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 3 +-- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index eb407d245ebc..53b305443c29 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -1402,9 +1402,8 @@ static int rtw_cfg80211_set_key_mgt(struct security_p= riv *psecuritypriv, u32 key if (key_mgt =3D=3D WLAN_AKM_SUITE_8021X) /* auth_type =3D UMAC_AUTH_TYPE_8021X; */ psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; - else if (key_mgt =3D=3D WLAN_AKM_SUITE_PSK) { + else if (key_mgt =3D=3D WLAN_AKM_SUITE_PSK) psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; - } =20 return 0; } diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index 95523c3a508b..5c546ce04747 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -144,9 +144,8 @@ static void sdio_deinit(struct dvobj_priv *dvobj) sdio_claim_host(func); sdio_disable_func(func); =20 - if (dvobj->irq_alloc) { + if (dvobj->irq_alloc) sdio_release_irq(func); - } =20 sdio_release_host(func); } --=20 2.53.0 From nobody Thu Jun 11 22:58:33 2026 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D1A63BD64A for ; Mon, 13 Apr 2026 10:16:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075364; cv=none; b=hZh/h1k7fI0pOCVkQJ/seSA9MQmkiPUX2KqHkXtxvPlmfNZzgEWYB+MH9fOW7amC3rwgyitOSK7fVM7mX9WKIOgoSvUkxf602AYJ5fM58w8Y5rhwK8MWgBvHHnW8dsdzBnSQHplMvtjOANM9Y83RbUFkuT1ievqrseALkNd+d+M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075364; c=relaxed/simple; bh=Hk1LEJ06Ybb8Melf5c2Ksth/5iklXN3N3Cv9u8QA0rA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nTUt2aEKP1anjFu2kKlnHjGC1ZQJYmcQ95PXGkvrrvZYr2tjkGTwy2BacgF+yAN19te9bsIrSj6ezAz8yfOIw22xR75S0iYzq+BN/Wk9pAk3HgYJZrs5L9Siz8CmWIgoqWoQjSfZ3D+eyJw/+FtLUZitBsKjheG1waslsPP957E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=MA3zhxcN; arc=none smtp.client-ip=91.218.175.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="MA3zhxcN" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776075360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hGyJpPVklh6FqHgzngavFWRRnEwhwlHdxbmqXEQ7qlI=; b=MA3zhxcNRVfFa3ZZ/4o+KcTv+G2zfCz3qF51NNt+7eoJXFGdNXWJOj0JU8qcsJv4BhXerF 2lyXR6RT1ZWV0QAn5RrWsKdEepchLyyqjwM9G/HqaFOcx6y2Gg14eXvB7yLCO8F8oZ8/+r cvI8Cuh0GH8D69/2UYEGRghnAODqMOI= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Luka Gejak , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [PATCH 10/11] staging: rtl8723bs: os_dep: remove blank lines before closing braces Date: Mon, 13 Apr 2026 12:14:31 +0200 Message-ID: <20260413101432.158925-11-luka.gejak@linux.dev> In-Reply-To: <20260413101432.158925-1-luka.gejak@linux.dev> References: <20260413101432.158925-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Luka Gejak Remove empty lines immediately preceding a closing brace in the os_dep directory to adhere to the Linux kernel coding style. This resolves "Blank lines aren't necessary before a close brace" warnings reported by checkpatch.pl. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 53b305443c29..b7d6bc96559d 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -578,7 +578,6 @@ static int rtw_cfg80211_ap_set_encryption(struct net_de= vice *dev, struct ieee_pa psecuritypriv->dot118021XGrpPrivacy =3D _WEP40_; if (param->u.crypt.key_len =3D=3D 13) psecuritypriv->dot118021XGrpPrivacy =3D _WEP104_; - } else if (strcmp(param->u.crypt.alg, "TKIP") =3D=3D 0) { psecuritypriv->dot118021XGrpPrivacy =3D _TKIP_; =20 @@ -589,7 +588,6 @@ static int rtw_cfg80211_ap_set_encryption(struct net_de= vice *dev, struct ieee_pa memcpy(rxkey, &(param->u.crypt.key[24]), 8); =20 psecuritypriv->busetkipkey =3D true; - } else if (strcmp(param->u.crypt.alg, "CCMP") =3D=3D 0) { psecuritypriv->dot118021XGrpPrivacy =3D _AES_; =20 @@ -633,7 +631,6 @@ static int rtw_cfg80211_ap_set_encryption(struct net_de= vice *dev, struct ieee_pa memcpy(psta->dot11tkiprxmickey.skey, &(param->u.crypt.key[24]), 8); =20 psecuritypriv->busetkipkey =3D true; - } else if (strcmp(param->u.crypt.alg, "CCMP") =3D=3D 0) { psta->dot118021XPrivacy =3D _AES_; } else { @@ -645,7 +642,6 @@ static int rtw_cfg80211_ap_set_encryption(struct net_de= vice *dev, struct ieee_pa psta->ieee8021x_blocked =3D false; =20 psta->bpairwise_key_installed =3D true; - } else { /* group key??? */ if (strcmp(param->u.crypt.alg, "WEP") =3D=3D 0) { memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 = : param->u.crypt.key_len)); @@ -663,7 +659,6 @@ static int rtw_cfg80211_ap_set_encryption(struct net_de= vice *dev, struct ieee_pa memcpy(rxkey, &(param->u.crypt.key[24]), 8); =20 psecuritypriv->busetkipkey =3D true; - } else if (strcmp(param->u.crypt.alg, "CCMP") =3D=3D 0) { psecuritypriv->dot118021XGrpPrivacy =3D _AES_; =20 @@ -2048,7 +2043,6 @@ static netdev_tx_t rtw_cfg80211_monitor_if_xmit_entry= (struct sk_buff *skb, struc /* Use the real net device to transmit the packet */ _rtw_xmit_entry(skb, padapter->pnetdev); return NETDEV_TX_OK; - } else if ((frame_control & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE)= ) =3D=3D (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION)) { /* only for action frames */ @@ -2503,7 +2497,6 @@ static int _cfg80211_rtw_mgmt_tx(struct adapter *pada= pter, u8 tx_ch, const u8 *b if (dump_mgntframe_and_wait_ack(padapter, pmgntframe) !=3D _SUCCESS) { ack =3D false; ret =3D _FAIL; - } else { msleep(50); =20 --=20 2.53.0 From nobody Thu Jun 11 22:58:33 2026 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C0153B38B7 for ; Mon, 13 Apr 2026 10:16:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075371; cv=none; b=UdOgkkDGa18dwT4bCvSdBNjVed9Ge9XffLmybsMxN076vZOS7zr+j5R6VPQy2rNnafot2H+L9Lijnsd0tYWAgVfU16qKchvaKokjTcfyDRlaA0m8K2lPUZgk2/gu0xa+nWfKm4hYXH0YdRXtdpd0AetTsAHJ4TJ5GlVBCer7Gyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776075371; c=relaxed/simple; bh=gmEqV2O+Ve1xvrxNOvvQHfWLmbeVSO6T8tQyrZXKcl0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BVrfDqFCfcuTBXR4UKrWqZLoKy2e75Lwu445QnUXBIgNUfyt+PofIIRXCFtY5qCj+UoOJKdss5nsHbVMsVS0pWiA/4dpSRgvulnrWW0LiH5dcEJdDiGqAkDxWCTNUYcHneficKFNPqGeMMgDEk71bbD2S+yRCjeP5Q2iA3VoZ7U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=jIoLh25D; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="jIoLh25D" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776075366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=81+DiUFEiGggG16Ab21a06Yec7wf/M+ssHtc+8CUwkA=; b=jIoLh25DEI7FaSwGBjAO6PSCK0q1zj1viQ6WyDZ+mIMaIK9nEzluXwYEx337szZEVN8MrF 8mqyg5ZyxidZ7ZvNSQ4biyaaZHNdiXuyJi7M0CFhMOYnwjOPYXt0wAl9c9fxtyXXoHpKCH GTLUYG4Sis4uxANAtZWWi796WoAAl9U= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Luka Gejak , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [PATCH 11/11] staging: rtl8723bs: hal: remove unnecessary braces Date: Mon, 13 Apr 2026 12:14:32 +0200 Message-ID: <20260413101432.158925-12-luka.gejak@linux.dev> In-Reply-To: <20260413101432.158925-1-luka.gejak@linux.dev> References: <20260413101432.158925-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Luka Gejak Remove unnecessary braces around single-statement blocks in the hal directory to adhere to the Linux kernel coding style. This resolves unnecessary braces warnings reported by checkpatch.pl. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 137 +++++++----------- drivers/staging/rtl8723bs/hal/HalPhyRf.c | 6 +- .../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 24 +-- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 9 +- .../staging/rtl8723bs/hal/hal_com_phycfg.c | 6 +- drivers/staging/rtl8723bs/hal/hal_intf.c | 6 +- drivers/staging/rtl8723bs/hal/odm.c | 4 +- drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 6 +- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 3 +- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 49 +++---- .../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 12 +- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 1 - 12 files changed, 101 insertions(+), 162 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c b/drivers/stag= ing/rtl8723bs/hal/HalBtc8723b2Ant.c index 132d91be5c82..9d0bd2bc7401 100644 --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c @@ -35,49 +35,43 @@ static u8 halbtc8723b2ant_BtRssiState( (pCoexSta->preBtRssiState =3D=3D BTC_RSSI_STATE_LOW) || (pCoexSta->preBtRssiState =3D=3D BTC_RSSI_STATE_STAY_LOW) ) { - if (btRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) { + if (btRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) btRssiState =3D BTC_RSSI_STATE_HIGH; - } else { + else btRssiState =3D BTC_RSSI_STATE_STAY_LOW; - } } else { - if (btRssi < rssiThresh) { + if (btRssi < rssiThresh) btRssiState =3D BTC_RSSI_STATE_LOW; - } else { + else btRssiState =3D BTC_RSSI_STATE_STAY_HIGH; - } } } else if (levelNum =3D=3D 3) { - if (rssiThresh > rssiThresh1) { + if (rssiThresh > rssiThresh1) return pCoexSta->preBtRssiState; - } =20 if ( (pCoexSta->preBtRssiState =3D=3D BTC_RSSI_STATE_LOW) || (pCoexSta->preBtRssiState =3D=3D BTC_RSSI_STATE_STAY_LOW) ) { - if (btRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) { + if (btRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) btRssiState =3D BTC_RSSI_STATE_MEDIUM; - } else { + else btRssiState =3D BTC_RSSI_STATE_STAY_LOW; - } } else if ( (pCoexSta->preBtRssiState =3D=3D BTC_RSSI_STATE_MEDIUM) || (pCoexSta->preBtRssiState =3D=3D BTC_RSSI_STATE_STAY_MEDIUM) ) { - if (btRssi >=3D (rssiThresh1 + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) { + if (btRssi >=3D (rssiThresh1 + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) btRssiState =3D BTC_RSSI_STATE_HIGH; - } else if (btRssi < rssiThresh) { + else if (btRssi < rssiThresh) btRssiState =3D BTC_RSSI_STATE_LOW; - } else { + else btRssiState =3D BTC_RSSI_STATE_STAY_MEDIUM; - } } else { - if (btRssi < rssiThresh1) { + if (btRssi < rssiThresh1) btRssiState =3D BTC_RSSI_STATE_MEDIUM; - } else { + else btRssiState =3D BTC_RSSI_STATE_STAY_HIGH; - } } } =20 @@ -104,49 +98,43 @@ static u8 halbtc8723b2ant_WifiRssiState( (pCoexSta->preWifiRssiState[index] =3D=3D BTC_RSSI_STATE_LOW) || (pCoexSta->preWifiRssiState[index] =3D=3D BTC_RSSI_STATE_STAY_LOW) ) { - if (wifiRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) { + if (wifiRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) wifiRssiState =3D BTC_RSSI_STATE_HIGH; - } else { + else wifiRssiState =3D BTC_RSSI_STATE_STAY_LOW; - } } else { - if (wifiRssi < rssiThresh) { + if (wifiRssi < rssiThresh) wifiRssiState =3D BTC_RSSI_STATE_LOW; - } else { + else wifiRssiState =3D BTC_RSSI_STATE_STAY_HIGH; - } } } else if (levelNum =3D=3D 3) { - if (rssiThresh > rssiThresh1) { + if (rssiThresh > rssiThresh1) return pCoexSta->preWifiRssiState[index]; - } =20 if ( (pCoexSta->preWifiRssiState[index] =3D=3D BTC_RSSI_STATE_LOW) || (pCoexSta->preWifiRssiState[index] =3D=3D BTC_RSSI_STATE_STAY_LOW) ) { - if (wifiRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) { + if (wifiRssi >=3D (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) wifiRssiState =3D BTC_RSSI_STATE_MEDIUM; - } else { + else wifiRssiState =3D BTC_RSSI_STATE_STAY_LOW; - } } else if ( (pCoexSta->preWifiRssiState[index] =3D=3D BTC_RSSI_STATE_MEDIUM) || (pCoexSta->preWifiRssiState[index] =3D=3D BTC_RSSI_STATE_STAY_MEDIUM) ) { - if (wifiRssi >=3D (rssiThresh1 + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) { + if (wifiRssi >=3D (rssiThresh1 + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT)) wifiRssiState =3D BTC_RSSI_STATE_HIGH; - } else if (wifiRssi < rssiThresh) { + else if (wifiRssi < rssiThresh) wifiRssiState =3D BTC_RSSI_STATE_LOW; - } else { + else wifiRssiState =3D BTC_RSSI_STATE_STAY_MEDIUM; - } } else { - if (wifiRssi < rssiThresh1) { + if (wifiRssi < rssiThresh1) wifiRssiState =3D BTC_RSSI_STATE_MEDIUM; - } else { + else wifiRssiState =3D BTC_RSSI_STATE_STAY_HIGH; - } } } =20 @@ -294,9 +282,8 @@ static u8 halbtc8723b2ant_ActionAlgorithm(struct btc_co= exist *pBtCoexist) =20 pBtCoexist->fBtcGet(pBtCoexist, BTC_GET_BL_HS_OPERATION, &bBtHsOn); =20 - if (!pBtLinkInfo->bBtLinkExist) { + if (!pBtLinkInfo->bBtLinkExist) return algorithm; - } =20 if (pBtLinkInfo->bScoExist) numOfDiffProfile++; @@ -311,58 +298,54 @@ static u8 halbtc8723b2ant_ActionAlgorithm(struct btc_= coexist *pBtCoexist) numOfDiffProfile++; =20 if (numOfDiffProfile =3D=3D 1) { - if (pBtLinkInfo->bScoExist) { + if (pBtLinkInfo->bScoExist) algorithm =3D BT_8723B_2ANT_COEX_ALGO_SCO; - } else { - if (pBtLinkInfo->bHidExist) { + else + if (pBtLinkInfo->bHidExist) algorithm =3D BT_8723B_2ANT_COEX_ALGO_HID; - } else if (pBtLinkInfo->bA2dpExist) { + else if (pBtLinkInfo->bA2dpExist) algorithm =3D BT_8723B_2ANT_COEX_ALGO_A2DP; - } else if (pBtLinkInfo->bPanExist) { - if (bBtHsOn) { + else if (pBtLinkInfo->bPanExist) { + if (bBtHsOn) algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANHS; - } else { + else algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANEDR; - } } } } else if (numOfDiffProfile =3D=3D 2) { if (pBtLinkInfo->bScoExist) { - if (pBtLinkInfo->bHidExist) { + if (pBtLinkInfo->bHidExist) algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANEDR_HID; - } else if (pBtLinkInfo->bA2dpExist) { + else if (pBtLinkInfo->bA2dpExist) algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANEDR_HID; } else if (pBtLinkInfo->bPanExist) { - if (bBtHsOn) { + if (bBtHsOn) algorithm =3D BT_8723B_2ANT_COEX_ALGO_SCO; - } else { + else algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANEDR_HID; - } } } else { if ( pBtLinkInfo->bHidExist && pBtLinkInfo->bA2dpExist - ) { + ) algorithm =3D BT_8723B_2ANT_COEX_ALGO_HID_A2DP; - } else if ( + else if ( pBtLinkInfo->bHidExist && pBtLinkInfo->bPanExist ) { - if (bBtHsOn) { + if (bBtHsOn) algorithm =3D BT_8723B_2ANT_COEX_ALGO_HID; - } else { + else algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANEDR_HID; - } } else if ( pBtLinkInfo->bPanExist && pBtLinkInfo->bA2dpExist ) { - if (bBtHsOn) { + if (bBtHsOn) algorithm =3D BT_8723B_2ANT_COEX_ALGO_A2DP_PANHS; - } else { + else algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANEDR_A2DP; - } } } } else if (numOfDiffProfile =3D=3D 3) { @@ -370,30 +353,28 @@ static u8 halbtc8723b2ant_ActionAlgorithm(struct btc_= coexist *pBtCoexist) if ( pBtLinkInfo->bHidExist && pBtLinkInfo->bA2dpExist - ) { + ) algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANEDR_HID; - } else if ( + else if ( pBtLinkInfo->bHidExist && pBtLinkInfo->bPanExist - ) { + ) algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANEDR_HID; - } else if ( + else if ( pBtLinkInfo->bPanExist && pBtLinkInfo->bA2dpExist - ) { + ) algorithm =3D BT_8723B_2ANT_COEX_ALGO_PANEDR_HID; - } } else { if ( pBtLinkInfo->bHidExist && pBtLinkInfo->bPanExist && pBtLinkInfo->bA2dpExist ) { - if (bBtHsOn) { + if (bBtHsOn) algorithm =3D BT_8723B_2ANT_COEX_ALGO_HID_A2DP; - } else { + else algorithm =3D BT_8723B_2ANT_COEX_ALGO_HID_A2DP_PANEDR; - } } } } else if (numOfDiffProfile >=3D 3) { @@ -480,9 +461,8 @@ static void halbtc8723b2ant_SetSwRfRxLpfCorner( } else { /* Resume RF Rx LPF corner */ /* After initialized, we can use pCoexDm->btRf0x1eBackup */ - if (pBtCoexist->bInitilized) { + if (pBtCoexist->bInitilized) pBtCoexist->fBtcSetRfReg(pBtCoexist, BTC_RF_A, 0x1e, 0xfffff, pCoexDm->= btRf0x1eBackup); - } } } =20 @@ -2201,13 +2181,11 @@ static void halbtc8723b2ant_RunCoexistMechanism(str= uct btc_coexist *pBtCoexist) { u8 algorithm =3D 0; =20 - if (pBtCoexist->bManualControl) { + if (pBtCoexist->bManualControl) return; - } =20 - if (pCoexSta->bUnderIps) { + if (pCoexSta->bUnderIps) return; - } =20 algorithm =3D halbtc8723b2ant_ActionAlgorithm(pBtCoexist); if (pCoexSta->bC2hBtInquiryPage && (BT_8723B_2ANT_COEX_ALGO_PANHS !=3D al= gorithm)) { @@ -2225,9 +2203,8 @@ static void halbtc8723b2ant_RunCoexistMechanism(struc= t btc_coexist *pBtCoexist) if (halbtc8723b2ant_IsCommonAction(pBtCoexist)) { pCoexDm->bAutoTdmaAdjust =3D false; } else { - if (pCoexDm->curAlgorithm !=3D pCoexDm->preAlgorithm) { + if (pCoexDm->curAlgorithm !=3D pCoexDm->preAlgorithm) pCoexDm->bAutoTdmaAdjust =3D false; - } =20 =20 switch (pCoexDm->curAlgorithm) { @@ -2405,11 +2382,10 @@ void EXhalbtc8723b2ant_IpsNotify(struct btc_coexist= *pBtCoexist, u8 type) =20 void EXhalbtc8723b2ant_LpsNotify(struct btc_coexist *pBtCoexist, u8 type) { - if (type =3D=3D BTC_LPS_ENABLE) { + if (type =3D=3D BTC_LPS_ENABLE) pCoexSta->bUnderLps =3D true; - } else if (type =3D=3D BTC_LPS_DISABLE) { + else if (type =3D=3D BTC_LPS_DISABLE) pCoexSta->bUnderLps =3D false; - } } =20 void EXhalbtc8723b2ant_ScanNotify(struct btc_coexist *pBtCoexist, u8 type) @@ -2484,9 +2460,8 @@ void EXhalbtc8723b2ant_BtInfoNotify( btInfo =3D tmpBuf[i]; } =20 - if (pBtCoexist->bManualControl) { + if (pBtCoexist->bManualControl) return; - } =20 if (BT_INFO_SRC_8723B_2ANT_WIFI_FW !=3D rspSource) { pCoexSta->btRetryCnt =3D pCoexSta->btInfoC2h[rspSource][2] & 0xf; /* [3:= 0] */ diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf.c b/drivers/staging/rtl= 8723bs/hal/HalPhyRf.c index 4a4052ce3ee0..69e7cfe533c1 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf.c @@ -117,9 +117,8 @@ void ODM_TXPowerTrackingCallback_ThermalMeter(struct ad= apter *Adapter) } =20 /* Calculate Average ThermalValue after average enough times */ - if (ThermalValue_AVG_count) { + if (ThermalValue_AVG_count) ThermalValue =3D (u8)(ThermalValue_AVG / ThermalValue_AVG_count); - } =20 /* 4 5. Calculate delta, delta_LCK */ /* delta" here is used to determine whether thermal value changes or not.= */ @@ -234,8 +233,7 @@ void ODM_TXPowerTrackingCallback_ThermalMeter(struct ad= apter *Adapter) } =20 /* Print Swing base & current */ - for (p =3D RF_PATH_A; p < c.RfPathCount; p++) { - } + for (p =3D RF_PATH_A; p < c.RfPathCount; p++) =20 if ( (pDM_Odm->RFCalibrateInfo.PowerIndexOffset[RF_PATH_A] !=3D 0 || diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.c index 56d6e3061d9b..d90c011b164b 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -1105,9 +1105,8 @@ static void _PHY_SaveADDARegisters8723B( if (!ODM_CheckPowerStatus(padapter)) return; =20 - for (i =3D 0 ; i < RegisterNum ; i++) { + for (i =3D 0 ; i < RegisterNum ; i++) ADDABackup[i] =3D PHY_QueryBBReg(pDM_Odm->Adapter, ADDAReg[i], bMaskDWor= d); - } } =20 =20 @@ -1119,9 +1118,8 @@ static void _PHY_SaveMACRegisters8723B( struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); struct dm_odm_t *pDM_Odm =3D &pHalData->odmpriv; =20 - for (i =3D 0 ; i < (IQK_MAC_REG_NUM - 1); i++) { + for (i =3D 0 ; i < (IQK_MAC_REG_NUM - 1); i++) MACBackup[i] =3D rtw_read8(pDM_Odm->Adapter, MACReg[i]); - } MACBackup[i] =3D rtw_read32(pDM_Odm->Adapter, MACReg[i]); } =20 @@ -1137,9 +1135,8 @@ static void _PHY_ReloadADDARegisters8723B( struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); struct dm_odm_t *pDM_Odm =3D &pHalData->odmpriv; =20 - for (i =3D 0 ; i < RegiesterNum; i++) { + for (i =3D 0 ; i < RegiesterNum; i++) PHY_SetBBReg(pDM_Odm->Adapter, ADDAReg[i], bMaskDWord, ADDABackup[i]); - } } =20 static void _PHY_ReloadMACRegisters8723B( @@ -1148,9 +1145,8 @@ static void _PHY_ReloadMACRegisters8723B( { u32 i; =20 - for (i =3D 0 ; i < (IQK_MAC_REG_NUM - 1); i++) { + for (i =3D 0 ; i < (IQK_MAC_REG_NUM - 1); i++) rtw_write8(padapter, MACReg[i], (u8)MACBackup[i]); - } rtw_write32(padapter, MACReg[i], MACBackup[i]); } =20 @@ -1170,13 +1166,11 @@ static void _PHY_PathADDAOn8723B( if (!is2T) { pathOn =3D 0x01c00014; PHY_SetBBReg(pDM_Odm->Adapter, ADDAReg[0], bMaskDWord, 0x01c00014); - } else { + } else PHY_SetBBReg(pDM_Odm->Adapter, ADDAReg[0], bMaskDWord, pathOn); - } =20 - for (i =3D 1 ; i < IQK_ADDA_REG_NUM ; i++) { + for (i =3D 1 ; i < IQK_ADDA_REG_NUM ; i++) PHY_SetBBReg(pDM_Odm->Adapter, ADDAReg[i], bMaskDWord, pathOn); - } } =20 static void _PHY_MACSettingCalibration8723B( @@ -1189,9 +1183,8 @@ static void _PHY_MACSettingCalibration8723B( =20 rtw_write8(pDM_Odm->Adapter, MACReg[i], 0x3F); =20 - for (i =3D 1 ; i < (IQK_MAC_REG_NUM - 1); i++) { + for (i =3D 1 ; i < (IQK_MAC_REG_NUM - 1); i++) rtw_write8(pDM_Odm->Adapter, MACReg[i], (u8)(MACBackup[i] & (~BIT3))); - } rtw_write8(pDM_Odm->Adapter, MACReg[i], (u8)(MACBackup[i] & (~BIT5))); } =20 @@ -1516,9 +1509,8 @@ static void phy_LCCalibrate_8723B(struct dm_odm_t *pD= M_Odm, bool is2T) PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xB0, bRFRegOffsetMask, 0xDFFE0= ); /* LDO OFF */ =20 /* Channel 10 LC calibration issue for 8723bs with 26M xtal */ - if (pDM_Odm->SupportInterface =3D=3D ODM_ITRF_SDIO && pDM_Odm->PackageTyp= e >=3D 0x2) { + if (pDM_Odm->SupportInterface =3D=3D ODM_ITRF_SDIO && pDM_Odm->PackageTyp= e >=3D 0x2) PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_CHNLBW, bMask12Bits, LC_Cal= ); - } =20 /* Restore original situation */ if ((tmpReg & 0x70) !=3D 0) { /* Deal with contisuous TX case */ diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/r= tl8723bs/hal/hal_btcoex.c index 2a2dd60be8bb..062156bdc2ba 100644 --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c @@ -1027,15 +1027,14 @@ void EXhalbtcoutsrc_SpecialPacketNotify(struct btc_= coexist *pBtCoexist, u8 pktTy if (pBtCoexist->bManualControl) return; =20 - if (pktType =3D=3D PACKET_DHCP) { + if (pktType =3D=3D PACKET_DHCP) packetType =3D BTC_PACKET_DHCP; - } else if (pktType =3D=3D PACKET_EAPOL) { + else if (pktType =3D=3D PACKET_EAPOL) packetType =3D BTC_PACKET_EAPOL; - } else if (pktType =3D=3D PACKET_ARP) { + else if (pktType =3D=3D PACKET_ARP) packetType =3D BTC_PACKET_ARP; - } else { + else return; - } =20 /* All notify is called in cmd thread, don't need to leave low power aga= in */ /* halbtcoutsrc_LeaveLowPower(pBtCoexist); */ diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index 0d94760a011a..7487bf75ebda 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -324,9 +324,8 @@ static void PHY_StoreTxPowerByRateNew(struct adapter *p= adapter, u32 RfPath, if (RfPath >=3D RF_PATH_MAX) return; =20 - for (i =3D 0; i < rateNum; ++i) { + for (i =3D 0; i < rateNum; ++i) pHalData->TxPwrByRateOffset[RfPath][rateIndex[i]] =3D PwrByRateVal[i]; - } } =20 static void PHY_StoreTxPowerByRateOld( @@ -362,9 +361,8 @@ void PHY_StoreTxPowerByRate( =20 if (pDM_Odm->PhyRegPgVersion > 0) PHY_StoreTxPowerByRateNew(padapter, RfPath, RegAddr, BitMask, Data); - else if (pDM_Odm->PhyRegPgVersion =3D=3D 0) { + else if (pDM_Odm->PhyRegPgVersion =3D=3D 0) PHY_StoreTxPowerByRateOld(padapter, RegAddr, BitMask, Data); - } } =20 static void diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index 27c0c0198714..45634b5e5082 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -208,9 +208,8 @@ void rtw_hal_update_ra_mask(struct sta_info *psta, u8 r= ssi_level) =20 if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) add_ratid(padapter, psta, rssi_level); - else { + else UpdateHalRAMask8723B(padapter, psta->mac_id, rssi_level); - } } =20 void rtw_hal_add_ra_tid(struct adapter *padapter, u32 bitmap, u8 *arg, u8 = rssi_level) @@ -254,9 +253,8 @@ void rtw_hal_dm_watchdog(struct adapter *padapter) =20 void rtw_hal_dm_watchdog_in_lps(struct adapter *padapter) { - if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode) { + if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode) rtl8723b_HalDmWatchDog_in_LPS(padapter); /* this function caller is in i= nterrupt context */ - } } =20 void beacon_timing_control(struct adapter *padapter) diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723b= s/hal/odm.c index c594ca250113..9a6f8c2cfa29 100644 --- a/drivers/staging/rtl8723bs/hal/odm.c +++ b/drivers/staging/rtl8723bs/hal/odm.c @@ -269,9 +269,8 @@ static void odm_RefreshRateAdaptiveMaskCE(struct dm_odm= _t *pDM_Odm) if (is_multicast_ether_addr(pstat->hwaddr)) /* if (psta->mac_id =3D=3D= 1) */ continue; =20 - if (true =3D=3D ODM_RAStateCheck(pDM_Odm, pstat->rssi_stat.UndecoratedS= moothedPWDB, false, &pstat->rssi_level)) { + if (true =3D=3D ODM_RAStateCheck(pDM_Odm, pstat->rssi_stat.UndecoratedS= moothedPWDB, false, &pstat->rssi_level)) rtw_hal_update_ra_mask(pstat, pstat->rssi_level); - } } } } @@ -975,7 +974,6 @@ void ODM_CmnInfoUpdate(struct dm_odm_t *pDM_Odm, u32 Cm= nInfo, u64 Value) /* do nothing */ break; } - } =20 /* 3 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging= /rtl8723bs/hal/odm_HWConfig.c index c575c42d1757..71e177f533ce 100644 --- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c +++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c @@ -238,9 +238,8 @@ static void odm_rx_phy_status_parsing(struct dm_odm_t *= dm_odm, if (is_cck_rate) { phy_info->signal_strength =3D (u8)(odm_signal_scale_mapping(dm_odm, pwdb= _all)); } else { - if (rf_rx_num !=3D 0) { + if (rf_rx_num !=3D 0) phy_info->signal_strength =3D (u8)(odm_signal_scale_mapping(dm_odm, tot= al_rssi /=3D rf_rx_num)); - } } } =20 @@ -274,8 +273,7 @@ static void odm_Process_RSSIForDM( pDM_Odm->RxRate =3D pPktinfo->data_rate; =20 /* Statistic for antenna/path diversity------------------ */ - if (pDM_Odm->SupportAbility & ODM_BB_ANT_DIV) { - } + if (pDM_Odm->SupportAbility & ODM_BB_ANT_DIV) =20 /* Smart Antenna Debug Message------------------ */ =20 diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging= /rtl8723bs/hal/rtl8723b_cmd.c index 1b576bcd0c5f..d25ebab4571d 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c @@ -25,9 +25,8 @@ static u8 _is_fw_read_cmd_down(struct adapter *padapter, = u8 msgbox_num) =20 do { valid =3D rtw_read8(padapter, REG_HMETFR) & BIT(msgbox_num); - if (0 =3D=3D valid) { + if (0 =3D=3D valid) read_down =3D true; - } } while ((!read_down) && (retry_cnts--)); =20 return read_down; diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 2be52a2d22b3..4dba941ebe3c 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -197,9 +197,8 @@ static s32 polling_fwdl_chksum( yield(); } while (jiffies_to_msecs(jiffies - start) < timeout_ms || cnt < min_cnt); =20 - if (!(value32 & FWDL_ChkSum_rpt)) { + if (!(value32 & FWDL_ChkSum_rpt)) goto exit; - } =20 if (g_fwdl_chksum_fail) { g_fwdl_chksum_fail--; @@ -238,9 +237,8 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min= _cnt, u32 timeout_ms) yield(); } while (jiffies_to_msecs(jiffies - start) < timeout_ms || cnt < min_cnt); =20 - if (!(value32 & WINTINI_RDY)) { + if (!(value32 & WINTINI_RDY)) goto exit; - } =20 if (g_fwdl_wintint_rdy_fail) { g_fwdl_wintint_rdy_fail--; @@ -1047,9 +1045,8 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u= 32 mac_id, u8 rssi_level) rate_bitmap =3D hal_btcoex_GetRaMask(padapter); mask &=3D ~rate_bitmap; =20 - if (pHalData->fw_ractrl) { + if (pHalData->fw_ractrl) rtl8723b_set_FwMacIdConfig_cmd(padapter, mac_id, psta->raid, psta->bw_mo= de, short_gi_rate, mask); - } =20 /* set correct initial date rate for each mac_id */ pdmpriv->INIDATA_RATE[mac_id] =3D psta->init_rate; @@ -1202,9 +1199,9 @@ void Hal_EfuseParseIDCode(struct adapter *padapter, u= 8 *hwinfo) =20 /* Check 0x8129 again for making sure autoload status!! */ EEPROMId =3D le16_to_cpu(*((__le16 *)hwinfo)); - if (EEPROMId !=3D RTL_EEPROM_ID) { + if (EEPROMId !=3D RTL_EEPROM_ID) pEEPROM->bautoload_fail_flag =3D true; - } else + else pEEPROM->bautoload_fail_flag =3D false; } =20 @@ -1586,20 +1583,18 @@ u8 SCMapping_8723B(struct adapter *Adapter, struct = pkt_attrib *pattrib) struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); =20 if (pHalData->CurrentChannelBW =3D=3D CHANNEL_WIDTH_40) { - if (pattrib->bwmode =3D=3D CHANNEL_WIDTH_40) { + if (pattrib->bwmode =3D=3D CHANNEL_WIDTH_40) SCSettingOfDesc =3D HT_DATA_SC_DONOT_CARE; - } else if (pattrib->bwmode =3D=3D CHANNEL_WIDTH_20) { - if (pHalData->nCur40MhzPrimeSC =3D=3D HAL_PRIME_CHNL_OFFSET_UPPER) { + else if (pattrib->bwmode =3D=3D CHANNEL_WIDTH_20) { + if (pHalData->nCur40MhzPrimeSC =3D=3D HAL_PRIME_CHNL_OFFSET_UPPER) SCSettingOfDesc =3D HT_DATA_SC_20_UPPER_OF_40MHZ; - } else if (pHalData->nCur40MhzPrimeSC =3D=3D HAL_PRIME_CHNL_OFFSET_LOWE= R) { + else if (pHalData->nCur40MhzPrimeSC =3D=3D HAL_PRIME_CHNL_OFFSET_LOWER) SCSettingOfDesc =3D HT_DATA_SC_20_LOWER_OF_40MHZ; - } else { + else SCSettingOfDesc =3D HT_DATA_SC_DONOT_CARE; - } } - } else { + } else SCSettingOfDesc =3D HT_DATA_SC_DONOT_CARE; - } =20 return SCSettingOfDesc; } @@ -1620,9 +1615,8 @@ static void rtl8723b_cal_txdesc_chksum(struct tx_desc= *ptxdesc) /* Thomas, Lucas@SD4, 20130515 */ count =3D 16; =20 - for (index =3D 0; index < count; index++) { + for (index =3D 0; index < count; index++) checksum |=3D le16_to_cpu(*(__le16 *)(usPtr + index)); - } =20 ptxdesc->txdw7 |=3D cpu_to_le32(checksum & 0x0000ffff); } @@ -1796,11 +1790,10 @@ static void rtl8723b_fill_default_txdesc( ptxdesc->mbssid =3D pattrib->mbssid & 0xF; =20 ptxdesc->rty_lmt_en =3D 1; /* retry limit enable */ - if (pattrib->retry_ctrl) { + if (pattrib->retry_ctrl) ptxdesc->data_rt_lmt =3D 6; - } else { + else ptxdesc->data_rt_lmt =3D 12; - } =20 ptxdesc->datarate =3D MRateToHwRate(pmlmeext->tx_rate); =20 @@ -1891,9 +1884,8 @@ void rtl8723b_fill_fake_txdesc( SET_TX_DESC_HWSEQ_SEL_8723B(pDesc, 0); } =20 - if (IsBTQosNull) { + if (IsBTQosNull) SET_TX_DESC_BT_INT_8723B(pDesc, 1); - } =20 SET_TX_DESC_USE_RATE_8723B(pDesc, 1); /* use data rate which is set by S= w */ SET_TX_DESC_OWN_8723B((u8 *)pDesc, 1); @@ -2208,9 +2200,8 @@ void CCX_FwC2HTxRpt_8723b(struct adapter *padapter, u= 8 *pdata, u8 len) #define GET_8723B_C2H_TX_RPT_LIFE_TIME_OVER(_Header) LE_BITS_TO_1BYTE((_He= ader + 0), 6, 1) #define GET_8723B_C2H_TX_RPT_RETRY_OVER(_Header) LE_BITS_TO_1BYTE((_Header= + 0), 7, 1) =20 - if (GET_8723B_C2H_TX_RPT_RETRY_OVER(pdata) | GET_8723B_C2H_TX_RPT_LIFE_TI= ME_OVER(pdata)) { + if (GET_8723B_C2H_TX_RPT_RETRY_OVER(pdata) | GET_8723B_C2H_TX_RPT_LIFE_TI= ME_OVER(pdata)) rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_CCX_PKT_FAIL); - } /* else if (seq_no !=3D padapter->xmitpriv.seq_no) { rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_CCX_PKT_FAIL); @@ -2580,9 +2571,8 @@ void SetHwReg8723B(struct adapter *padapter, u8 varia= ble, u8 *val) =20 /* Forece leave RF low power mode for 1T1R to prevent conficting setti= ng in Fw power */ /* saving sequence. 2010.06.07. Added by tynli. Suggested by SD3 yscha= ng. */ - if (psmode !=3D PS_MODE_ACTIVE) { + if (psmode !=3D PS_MODE_ACTIVE) ODM_RF_Saving(&pHalData->odmpriv, true); - } =20 /* if (psmode !=3D PS_MODE_ACTIVE) { */ /* rtl8723b_set_lowpwr_lps_cmd(padapter, true); */ @@ -2896,11 +2886,10 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum= hal_def_variable variable, v break; =20 case HAL_DEF_TX_PAGE_BOUNDARY: - if (!padapter->registrypriv.wifi_spec) { + if (!padapter->registrypriv.wifi_spec) *(u8 *)pval =3D TX_PAGE_BOUNDARY_8723B; - } else { + else *(u8 *)pval =3D WMM_NORMAL_TX_PAGE_BOUNDARY_8723B; - } break; =20 case HAL_DEF_MACID_SLEEP: diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index a3012679a3b5..58d5ffabda01 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -140,9 +140,8 @@ s32 rtl8723bs_xmit_buf_handler(struct adapter *padapter) return _SUCCESS; =20 ret =3D rtw_register_tx_alive(padapter); - if (ret !=3D _SUCCESS) { + if (ret !=3D _SUCCESS) return _SUCCESS; - } =20 do { queue_empty =3D rtl8723_dequeue_writeport(padapter); @@ -375,9 +374,8 @@ static s32 rtl8723bs_xmit_handler(struct adapter *padap= ter) spin_lock_bh(&pxmitpriv->lock); ret =3D rtw_txframes_pending(padapter); spin_unlock_bh(&pxmitpriv->lock); - if (ret =3D=3D 0) { + if (ret =3D=3D 0) return _SUCCESS; - } =20 /* dequeue frame and write to hardware */ =20 @@ -395,9 +393,8 @@ static s32 rtl8723bs_xmit_handler(struct adapter *padap= ter) spin_lock_bh(&pxmitpriv->lock); ret =3D rtw_txframes_pending(padapter); spin_unlock_bh(&pxmitpriv->lock); - if (ret =3D=3D 1) { + if (ret =3D=3D 1) goto next; - } =20 return _SUCCESS; } @@ -412,9 +409,8 @@ int rtl8723bs_xmit_thread(void *context) =20 do { ret =3D rtl8723bs_xmit_handler(padapter); - if (signal_pending(current)) { + if (signal_pending(current)) flush_signals(current); - } } while (_SUCCESS =3D=3D ret); =20 complete(&pxmitpriv->SdioXmitTerminate); diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index c476ebd0e600..ee6dba5a8bcd 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -323,7 +323,6 @@ static void _InitQueuePriority(struct adapter *Adapter) default: break; } - } =20 static void _InitPageBoundary(struct adapter *padapter) --=20 2.53.0