From nobody Sat Jun 13 02:14:40 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A10BD344D95; Mon, 13 Apr 2026 05:08:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776056932; cv=none; b=b6+61jbydL8r80nHlr2m5zcuDLtQ4uW6TKIyruWZyIB27kKRMlP0dgQlFPb539h2PiI8LRXsQv9ROiwCuA6InsMC/z9RR2t0MFyz/zty7pWRiKcSTD/C8D/yTomq5xjTxgoyqq/tZhf+oKsRzCcbg70JmHmfbwZ270Og/PycEz4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776056932; c=relaxed/simple; bh=tp8KOjmdQ4MjJ1498n7/CnNxfNveyZ6rinU8BbhvPK0=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RQKNhbT8qHCi4WZlCZNgSWxVpQK5hpAf8IhWSd4ZsPYZI6X9bJ26Q1pjKQlhiirgfsKRZaGECjknIOdb7rc60n9fBag/eFpJ//Zk13Isjp2Vl5a/YZX3f8nGkE1fMLJEWB83ySUh+OdrAV8BtuaAtUaS45l6QFfGyjeBqU2ig4I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=CJvP7zxf; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="CJvP7zxf" Received: by linux.microsoft.com (Postfix, from userid 1173) id 7144E20B712D; Sun, 12 Apr 2026 22:08:45 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7144E20B712D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1776056925; bh=UpKbiM/WzXu5/Bqg2FujmXCbJGJIFbSiryBEH0k7wug=; h=From:To:Subject:Date:In-Reply-To:References:From; b=CJvP7zxf0Rd1SjSFzgs3b+YUDnjwjie5mWsLUt2md5FNetlIWRrB7j9dHcu+E4RUK 40EOWajej6IOzUspW1TUNnNjC1Y/iJJ2uzJSngCyWI8gsgem8KneHgfTmslfO25ALL HVC9N4FL6lN8WEeb6zWeYnAJLlDPPhgmFi/kX7pc= From: Erni Sri Satya Vennela To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ernis@linux.microsoft.com, ssengar@linux.microsoft.com, dipayanroy@linux.microsoft.com, gargaditya@linux.microsoft.com, shirazsaleem@microsoft.com, kees@kernel.org, kotaranov@microsoft.com, leon@kernel.org, shacharr@microsoft.com, stephen@networkplumber.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 1/4] net: mana: Init link_change_work before potential error paths in probe Date: Sun, 12 Apr 2026 22:08:37 -0700 Message-ID: <20260413050843.605789-2-ernis@linux.microsoft.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260413050843.605789-1-ernis@linux.microsoft.com> References: <20260413050843.605789-1-ernis@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move INIT_WORK(link_change_work) to right after the mana_context allocation, before any error path that could reach mana_remove(). Previously, if mana_create_eq() or mana_query_device_cfg() failed, mana_probe() would jump to the error path which calls mana_remove(). mana_remove() unconditionally calls disable_work_sync(link_change_work), but the work struct had not been initialized yet. This can trigger CONFIG_DEBUG_OBJECTS_WORK enabled. Fixes: 54133f9b4b53 ("net: mana: Support HW link state events") Signed-off-by: Erni Sri Satya Vennela Reviewed-by: Simon Horman --- Changes in v2: * Apply the patch in net instead of net-next. --- drivers/net/ethernet/microsoft/mana/mana_en.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/et= hernet/microsoft/mana/mana_en.c index 07630322545f..57f146ea6f66 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -3631,6 +3631,8 @@ int mana_probe(struct gdma_dev *gd, bool resuming) =20 ac->gdma_dev =3D gd; gd->driver_data =3D ac; + + INIT_WORK(&ac->link_change_work, mana_link_state_handle); } =20 err =3D mana_create_eq(ac); @@ -3648,8 +3650,6 @@ int mana_probe(struct gdma_dev *gd, bool resuming) =20 if (!resuming) { ac->num_ports =3D num_ports; - - INIT_WORK(&ac->link_change_work, mana_link_state_handle); } else { if (ac->num_ports !=3D num_ports) { dev_err(dev, "The number of vPorts changed: %d->%d\n", --=20 2.34.1 From nobody Sat Jun 13 02:14:40 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0A1A7381AE3; Mon, 13 Apr 2026 05:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776056933; cv=none; b=seIl5bFRU5RVMOL/hRjsXmghdBnOfHynUPY+vqjH/KsYBh/CtAyDA1ZFWgSY5n2a5s3ejFtbZUtvdrESgPD6KmWfqH0xTN441iqkaMB+2Ba0tfpIceedlpSEyJOL1a78GGOnFFIVakxpj2IyDMYsNWnyvUr9IQ1Ua15KCtfEb54= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776056933; c=relaxed/simple; bh=2/Sgiuf0i4Z6yaO92crvH0qtHa25YLDB6KSbbFFkCnA=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YAMPnoVTKSJLAq1u/7dSaMmNvA4csh6UQEMfupOR1ZYHC0KhuiobjnYLB+8sYTUUe2AqtJ4+hGVyD3kTRchNSVqq860sewKv3gEzUwCiWTmN48k7I3hfXHlP/cs3Ir7p/1D8j9E2WLL6li7YWYnxpUcUbzcjjcoYK0SjHbZEy+c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=f9uNMtf8; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="f9uNMtf8" Received: by linux.microsoft.com (Postfix, from userid 1173) id 1931B20B7129; Sun, 12 Apr 2026 22:08:46 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1931B20B7129 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1776056926; bh=sb3m66RzCJPfglqdY/359rz5n0K9rwFOKlus0zCVaOk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=f9uNMtf8U3KeTSHwVdn4+WPHCIn/cqN0IBGAqyOJqxMVbju10236Y1f3BpwlGVNas FQK/aLD2wRpE9/aYe/6MCsxWawlp/34y3QqIVWqlLPSKwTE7kGC3RgU+YCvgr2z+AG 3cA5VHLtK1EXCQ8+MP1T6FCVttAMp0YHe1jtA3/E= From: Erni Sri Satya Vennela To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ernis@linux.microsoft.com, ssengar@linux.microsoft.com, dipayanroy@linux.microsoft.com, gargaditya@linux.microsoft.com, shirazsaleem@microsoft.com, kees@kernel.org, kotaranov@microsoft.com, leon@kernel.org, shacharr@microsoft.com, stephen@networkplumber.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 2/4] net: mana: Init gf_stats_work before potential error paths in probe Date: Sun, 12 Apr 2026 22:08:38 -0700 Message-ID: <20260413050843.605789-3-ernis@linux.microsoft.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260413050843.605789-1-ernis@linux.microsoft.com> References: <20260413050843.605789-1-ernis@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move INIT_DELAYED_WORK(gf_stats_work) to before mana_create_eq(), while keeping schedule_delayed_work() at its original location. Previously, if any function between mana_create_eq() and the INIT_DELAYED_WORK call failed, mana_probe() would call mana_remove() which unconditionally calls cancel_delayed_work_sync(gf_stats_work) in __flush_work() or debug object warnings with CONFIG_DEBUG_OBJECTS_WORK enabled. Fixes: be4f1d67ec56 ("net: mana: Add standard counter rx_missed_errors") Signed-off-by: Erni Sri Satya Vennela Reviewed-by: Simon Horman --- Changes in v2: * Apply the patch in net instead of net-next. --- drivers/net/ethernet/microsoft/mana/mana_en.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/et= hernet/microsoft/mana/mana_en.c index 57f146ea6f66..f6ad46736418 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -3635,6 +3635,8 @@ int mana_probe(struct gdma_dev *gd, bool resuming) INIT_WORK(&ac->link_change_work, mana_link_state_handle); } =20 + INIT_DELAYED_WORK(&ac->gf_stats_work, mana_gf_stats_work_handler); + err =3D mana_create_eq(ac); if (err) { dev_err(dev, "Failed to create EQs: %d\n", err); @@ -3709,7 +3711,6 @@ int mana_probe(struct gdma_dev *gd, bool resuming) =20 err =3D add_adev(gd, "eth"); =20 - INIT_DELAYED_WORK(&ac->gf_stats_work, mana_gf_stats_work_handler); schedule_delayed_work(&ac->gf_stats_work, MANA_GF_STATS_PERIOD); =20 out: --=20 2.34.1 From nobody Sat Jun 13 02:14:40 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0A233381B1C; Mon, 13 Apr 2026 05:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776056933; cv=none; b=TRFbu/+Zbb/uT2D/M6rhyQEo3mHYGGuBoXCPpnEB6HIYnlhfcj/fJy2HTBXScShVKfWJbOPCxEdkdo6t75fNwpO/Y/STXXXFxJY4MPmEarQxYbBSPucN9C36XPphD3m28GD6SB7MtKLM5DxMtSC6O9rOkA6cXSg5z3fNjiEsUys= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776056933; c=relaxed/simple; bh=Omt7l2ZGmdQq9uYj4lHwHIPJUy2Ae/QbidRwwQnoo0w=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CChEoTBoASm1GeM/nGkypJXIucaeBT8c7BSwXlPwX6qGaOGFGGs0wgF8z2ng0QGj/yqgWbX3MdL3O4RoyHL4KRCjjpgfX/s98V6eJeHsK6EEIzbRiqjaLPEfxXbZYbvPIxCK5VDhlR05Q5ydYJFkJbhOGVOUXl1imZYNNPYAI5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=o42ksuLL; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="o42ksuLL" Received: by linux.microsoft.com (Postfix, from userid 1173) id B312B20B713B; Sun, 12 Apr 2026 22:08:46 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B312B20B713B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1776056926; bh=zMwewV+dOIBPAAf8NeLiYmX6NUc8wSZ3jkHLbt2qTSc=; h=From:To:Subject:Date:In-Reply-To:References:From; b=o42ksuLL7qdzrhNGwe9oaUSBXlZQr8ZB74T14KOfGK3fbW/FV2g1gIgKwM9C3Jti/ oiiUSUPv2vv1NKGV+9PoAU5rFipeMW85wilCWjFqXgi4efSUywRv8BpsCucpCosv0n zqpkXcleWmJqkPZ9YqREM/+ing2xkVhoSHbnbQEs= From: Erni Sri Satya Vennela To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ernis@linux.microsoft.com, ssengar@linux.microsoft.com, dipayanroy@linux.microsoft.com, gargaditya@linux.microsoft.com, shirazsaleem@microsoft.com, kees@kernel.org, kotaranov@microsoft.com, leon@kernel.org, shacharr@microsoft.com, stephen@networkplumber.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 3/4] net: mana: Don't overwrite port probe error with add_adev result Date: Sun, 12 Apr 2026 22:08:39 -0700 Message-ID: <20260413050843.605789-4-ernis@linux.microsoft.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260413050843.605789-1-ernis@linux.microsoft.com> References: <20260413050843.605789-1-ernis@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In mana_probe(), if mana_probe_port() fails for any port, the error is stored in 'err' and the loop breaks. However, the subsequent unconditional 'err =3D add_adev(gd, "eth")' overwrites this error. If add_adev() succeeds, mana_probe() returns success despite ports being left in a partially initialized state (ac->ports[i] =3D=3D NULL). Only call add_adev() when there is no prior error, so the probe correctly fails and triggers mana_remove() cleanup. Fixes: ced82fce77e9 ("net: mana: Probe rdma device in mana driver") Signed-off-by: Erni Sri Satya Vennela --- Changes in v2: * Apply the patch in net instead of net-next. --- drivers/net/ethernet/microsoft/mana/mana_en.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/et= hernet/microsoft/mana/mana_en.c index f6ad46736418..1a141c46ac27 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -3680,10 +3680,9 @@ int mana_probe(struct gdma_dev *gd, bool resuming) if (!resuming) { for (i =3D 0; i < ac->num_ports; i++) { err =3D mana_probe_port(ac, i, &ac->ports[i]); - /* we log the port for which the probe failed and stop - * probes for subsequent ports. - * Note that we keep running ports, for which the probes - * were successful, unless add_adev fails too + /* Log the port for which the probe failed, stop probing + * subsequent ports, and skip add_adev. + * Already-probed ports remain functional. */ if (err) { dev_err(dev, "Probe Failed for port %d\n", i); @@ -3697,10 +3696,9 @@ int mana_probe(struct gdma_dev *gd, bool resuming) enable_work(&apc->queue_reset_work); err =3D mana_attach(ac->ports[i]); rtnl_unlock(); - /* we log the port for which the attach failed and stop - * attach for subsequent ports - * Note that we keep running ports, for which the attach - * were successful, unless add_adev fails too + /* Log the port for which the attach failed, stop + * attaching subsequent ports, and skip add_adev. + * Already-attached ports remain functional. */ if (err) { dev_err(dev, "Attach Failed for port %d\n", i); @@ -3709,7 +3707,8 @@ int mana_probe(struct gdma_dev *gd, bool resuming) } } =20 - err =3D add_adev(gd, "eth"); + if (!err) + err =3D add_adev(gd, "eth"); =20 schedule_delayed_work(&ac->gf_stats_work, MANA_GF_STATS_PERIOD); =20 --=20 2.34.1 From nobody Sat Jun 13 02:14:40 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EF45D1D435F; Mon, 13 Apr 2026 05:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776057010; cv=none; b=Tc/jy+QfGNsP09gsrvPhFIWtC/mICTU6ypYv8/ACjX8ncp0dSZR+arCNHzPfLGI1sKd376Yeikqd37SEMZVtMqXUHg6tqda2Glu5b25d/5cTuZ1j2JA7ZGHdpASO+K6fJ5b6oTA0oZKD3HDKo1lidZNS6MJpmVmlWiznDGnn13Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776057010; c=relaxed/simple; bh=S1RPgc3ieNbPHCWODeWvLFxJmmZA72lpp1jJb4Hx9Lc=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sEpcM5+J9hwViQtbZ9zxnN8BOH66IMZaJzJKQSYPmcuGEfmd26lChxf9LBxOCyO4JEUqGV0L2yRobnz4FPqpIGyJuR6xCxX8NdcIL529UkCwQcDJ9ZONWp0a/cF6oajfwpR35ATC8pXdV+DsHlPTk2gaIxsjKF7ILlYYVsxadvA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=eEZRuUCN; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="eEZRuUCN" Received: by linux.microsoft.com (Postfix, from userid 1173) id E109C20B6F01; Sun, 12 Apr 2026 22:10:08 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E109C20B6F01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1776057008; bh=r8/mdOBpoRRMgRcF8KxeNZyoEUm662XAFr49YQ9Uozw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=eEZRuUCNCelhvESpqgBV4iB3bvNepOdMhoFgnbZf6/nZ1sJtrJ2ljqyfz5USu+E85 0ouzPlmIdIgc4k8Aie+lF/FtLU4R4VVIoiOIqU2avQg45zMARFhRtM7U26TSiB+ZIW sHJXd9gecyRjIbhvrNDkd8W2U87WchE/eyH3v1Mk= From: Erni Sri Satya Vennela To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ernis@linux.microsoft.com, ssengar@linux.microsoft.com, dipayanroy@linux.microsoft.com, gargaditya@linux.microsoft.com, shirazsaleem@microsoft.com, kees@kernel.org, kotaranov@microsoft.com, leon@kernel.org, shacharr@microsoft.com, stephen@networkplumber.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2 4/4] net: mana: Fix EQ leak in mana_remove on NULL port Date: Sun, 12 Apr 2026 22:08:40 -0700 Message-ID: <20260413050843.605789-5-ernis@linux.microsoft.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260413050843.605789-1-ernis@linux.microsoft.com> References: <20260413050843.605789-1-ernis@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In mana_remove(), when a NULL port is encountered in the port iteration loop, 'goto out' skips the mana_destroy_eq(ac) call, leaking the event queues allocated earlier by mana_create_eq(). This can happen when mana_probe_port() fails for port 0, leaving ac->ports[0] as NULL. On driver unload or error cleanup, mana_remove() hits the NULL entry and jumps past mana_destroy_eq(). Change 'goto out' to 'break' so the for-loop exits normally and mana_destroy_eq() is always reached. Remove the now-unreferenced out: label. Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network A= dapter (MANA)") Signed-off-by: Erni Sri Satya Vennela --- Changes in v2: * Apply the patch in net instead of net-next. --- drivers/net/ethernet/microsoft/mana/mana_en.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/et= hernet/microsoft/mana/mana_en.c index 1a141c46ac27..97237d137cbf 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -3747,7 +3747,7 @@ void mana_remove(struct gdma_dev *gd, bool suspending) if (!ndev) { if (i =3D=3D 0) dev_err(dev, "No net device to remove\n"); - goto out; + break; } =20 apc =3D netdev_priv(ndev); @@ -3778,7 +3778,7 @@ void mana_remove(struct gdma_dev *gd, bool suspending) } =20 mana_destroy_eq(ac); -out: + if (ac->per_port_queue_reset_wq) { destroy_workqueue(ac->per_port_queue_reset_wq); ac->per_port_queue_reset_wq =3D NULL; --=20 2.34.1