From nobody Mon Jun 15 18:03:12 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D914C1AE877 for ; Mon, 13 Apr 2026 03:50:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776052232; cv=none; b=Dwz2madwSH0zz30bgkjBMVblEYnApjgAHG9BdtMXOD+fcTVXdF0bxNAXY/TsROx3u0na878IZBoumDHZ5KtnsupHW9N/hFzWw+ycWH6p5olmwTjkkoxcd310U8qTZuWilrFV0G1iiFD+kOB76i/uCyX5FIRk4OvXJHRYK18VuY8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776052232; c=relaxed/simple; bh=G+z3juLYTTGNnge1Q7+l118XoMP53BlwRMWS2rp4EwI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=N0s2RrBftsliL26ojtfRI+bQNo+5BD0tt8gSlvSD8d8egPdDyHBjqS3e8p56FNWnnVbKMzXcCBCE1ttbP1D3FhCAcuUe0TOX0msN5U4JN6+d24oXFTrcGXZTOlX5yFfI459ty/Jj2dujBr93AyKtHyNlem3KE22PDGzANaKc+kQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lW3XHypW; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lW3XHypW" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-35fb7f51171so407453a91.1 for ; Sun, 12 Apr 2026 20:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776052229; x=1776657029; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SLYrZW1/bb0BohbqxF1IHAXhdfS6eaDzFERz8UW0w5s=; b=lW3XHypWwk5qpf0yKb3Gq68AQDZ80/kx9uMnJZfPlwnrGiAyzD6FUTk8riQ51UEVL0 8AxZW+fd0/eiM0t+TeqWX9F4o78R3yHikqr0lv2AZae7/DeZD6yHBNgoZFrMZIONRoS1 z6uaWCj1B+CINvxF97eukhHHFGnln6SjuXtR04Z9Ik25yqTTyLIrhFwf4fH4Co5+z5+n DSoPgAgs1m1tDZGxcJFiOU93ufZ0mCpSyVfMTSPkb+/qmdG4N1gKscRrra5N7DxByVb6 iGeqzejFN7Ru8cjCUqn75qhCk4GL1cVQ1N+fqZaV5Fi7quAOm9+Ccq2+r8uPDA8YHZFb tbOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776052229; x=1776657029; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SLYrZW1/bb0BohbqxF1IHAXhdfS6eaDzFERz8UW0w5s=; b=SOZAfgi12psfFV/b8UMhmRb55KIVAQBIsZvRqfGfOQPgOluW+kD4GqLzLXSFv1HhWP tRA5Wpanh3+Gnjeiv1fJ1bHiWQoutnafS6XPDTZa0t5vaKqJNwBk5neY2H4STDvybUJi dOU4yUvsky7yuPk0ctbHhfrB8fnY+kvXg9JrVdkylDhiH4OVKhogcespVISgjRAbGfJy tpq/4aY6t7ndar1ZArhXR1VCmOHjsukOGRXfu04tfCjIOPbD/H0wYqA5Lyb3hGUbefRC kcyPahDHeo+t1JVIRKVhElAxi16PvVFDjD06CYvywOEAK7E/0kzT1n4gZxvritYQg3Ue eMQw== X-Forwarded-Encrypted: i=1; AFNElJ9razU2+Rz5CF67My7UKsIf06zjIIjVU/HGtkKUZ6ai+qh82UXYk47+NHPYrGx6P4iRKli5vvYaIKu4CV0=@vger.kernel.org X-Gm-Message-State: AOJu0YwDgsuiBlWCg+lU4dqJlPjqffLG7lSkm2UGtyuGoktQc0uTtwEx zsyHONKk33GPYywO5qAXWHLLv/75YqJU0tF9tcUm3ksNH0whY64xbw1w6CNjD56l X-Gm-Gg: AeBDiesLsdbTJPTQBVxRj5gD4uxnIvbd1kZJKhkELIRGB+nm+xAtERoEMY6pEdCTAYH HvTnk3lRYwWKfTg2Zt6w89UBvu7JtCxjR1ZrtoojkKjBCiGWarXVJxdaeMZ92fBhZhkqmKik21F BF4GnFpN9jHjDpBpUgjFm3cCUOEfHz9CF4rNd+o+ySTI7tyi0iwlJgSY6J2EN+ajyffITfhxPjg nimEmsZBf+PAXJvoqSSFM20yi2IEYjbXTHV1rIvxOWM1iCBEuXnRYGNDf8CaktOj4J7gC6i1beu uU09sJHBo5MQLvB1RVpZo0it8tw3vmMyzj10QJE3gt+t6Sm2vDnTZtVEMZnqTmdY2U8GCqZMHC1 EB6hZK98ueFL0Wyn7VkKJYdfSMbK8Rg3sPf/nVovtn0in/epW04z9pG1DlsQnZ2QjIQV+SPyDaU Vul4rYKUzAN5jses0sittkP0qw81a+HQvy4gh6ienzXRTlH8xYSgD46LaT5jww7NwgkO+fi2NCV g== X-Received: by 2002:a17:90b:4e85:b0:35b:a8cf:7960 with SMTP id 98e67ed59e1d1-35e42769f93mr11744410a91.3.1776052229174; Sun, 12 Apr 2026 20:50:29 -0700 (PDT) Received: from localhost.localdomain ([2405:6580:9cc0:8700:96ae:8c3d:9c98:97d9]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35e4e2dbf47sm7030644a91.0.2026.04.12.20.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 20:50:28 -0700 (PDT) From: Berk Cem Goksel To: zonque@gmail.com, tiwai@suse.com, perex@perex.cz Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, andreyknvl@gmail.com, stable@vger.kernel.org, Berk Cem Goksel Subject: [PATCH v2 1/2] ALSA: caiaq: fix use-after-free and double-free in setup_card() Date: Mon, 13 Apr 2026 06:49:40 +0300 Message-Id: <20260413034941.1131465-2-berkcgoksel@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260413034941.1131465-1-berkcgoksel@gmail.com> References: <20260413034941.1131465-1-berkcgoksel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When snd_card_register() fails in setup_card(), snd_card_free() is called on the card, but there is no return statement afterwards. Execution falls through to snd_usb_caiaq_control_init(cdev), which dereferences members of the just-freed card, resulting in a use-after-free. setup_card() is void and init_card() still returns 0 on this path, so snd_probe() leaves the freed card pointer in the USB interface's private data via usb_set_intfdata(). When the device is later disconnected, snd_usb_caiaq_disconnect() calls snd_card_free_when_closed() on that same pointer, producing a double-free and slab corruption. Add the missing return so a failed snd_card_register() cleanly aborts setup without touching freed memory. The issue is reachable by any caiaq-compatible USB device whose descriptors cause snd_card_register() to fail. It was reproduced with raw-gadget + dummy_hcd on 7.0.0-rc5 (arm64, KASAN). Fixes: 8e3cd08ed8e5 ("[ALSA] caiaq - add control API and more input feature= s") Cc: stable@vger.kernel.org Cc: Andrey Konovalov Signed-off-by: Berk Cem Goksel --- v2: - Correct "Fixes:" tag sound/usb/caiaq/device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/caiaq/device.c b/sound/usb/caiaq/device.c index 3a71bab8a477..d52f3b9a2bac 100644 --- a/sound/usb/caiaq/device.c +++ b/sound/usb/caiaq/device.c @@ -369,6 +369,7 @@ static void setup_card(struct snd_usb_caiaqdev *cdev) if (ret < 0) { dev_err(dev, "snd_card_register() returned %d\n", ret); snd_card_free(cdev->chip.card); + return; } =20 ret =3D snd_usb_caiaq_control_init(cdev); --=20 2.34.1 From nobody Mon Jun 15 18:03:12 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6395B2D592C for ; Mon, 13 Apr 2026 03:50:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776052238; cv=none; b=VDMZreRmnbuykcyY6TI6CX7d9OvzaaprNGL/5rKHwGI7SV08PpN2vO5nn6lpHDqMepdUPOnifVGah6MJyPppHwOrarOchSlqVBtBzhuxqzocljiND9+NjOWsLwDYcq/HlPdfcRQdTYG7ooqN0tOy9um2eFPmKTgy0iugRLEzs7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776052238; c=relaxed/simple; bh=Wrj+gdpP6ITRJA8dSWGbh5zoUNshnIIubPM7stoPbPA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PiEkpPuQgG8rDISmZIMeAUumdiv4PTMtC4g8oL6N4W20asB+37Kh6wmN5GTdn3M6LolxcYlHvj/P9r4nIFTh3Y0rDc8YojoFZYIFlx2/Was92PJH8XqTSTOgaa8WxhBPCPTqz6uYX6PVvt82Q6g4QygtUYTANXNHr+ritBFxfCM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X5LjrD+j; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X5LjrD+j" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-35d94f4ee36so2223408a91.3 for ; Sun, 12 Apr 2026 20:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776052237; x=1776657037; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T5SGpOXoxl9RjzaYVEFaZVgctA66UXg9R08vi8wYY78=; b=X5LjrD+joWY6G4BF5W2RDofpPng1J0woMsnwEf9gMgwc+3vJJaBfYumhv6yaWlBmYF E//PCVfm75W1mis95sxzVK6dqLPZ+XsBlHNC6Pqls9IterP0m0HtHpH4rz3QgR8TPI8Q 9XbTxmunvAg5nfCIpcGiW228Ry4FSrHzgdGjbkTaX8V9Jta/Js7iTiLwq/d/cldAsbrm Owe+stzvrBud4svOGH0WAm/E0T+td99F7gn/ljryW7u+Ctr/u5QR0mTh4cnksUo8ogaO 7Y9XZ+9zisNxX8yCp8Gm3BqcKi5tUc5Wqjudxf7fozWV3NqVhLNTWyRIDb9DQ0aM18aO LhoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776052237; x=1776657037; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T5SGpOXoxl9RjzaYVEFaZVgctA66UXg9R08vi8wYY78=; b=ZgSc78hrasOex2RjvbkN21b2zI3X26Eea3GBwgMAK575TAQmu7exXt0JXqO9ihhQ1R iQYaIwYmkEEzzZSWqhpB8Wos+4lDau0Di8PlzreotCB2sPQV0u11ST0YaIP7sI4F7/YV wT/bEBy5FVjp+kfzv9DJ/L8JKNgvgC03Thv6EwJTPkftgZr/rK/gAJvqX/ASNd75RMpN IpWgDJoe25cGBvevJV0q2Xn5D7VVJDRgKLeqoSLBzEUh2bhAKRX1ShdPHP8j2PhmvFpc sT7Bi50IIL5j/AMcXzc0DDhFCO8FBB0dd/+EHBDolsD+Bd0zRGTOxC5MO1UfNbJ6Xijx Hn2g== X-Forwarded-Encrypted: i=1; AFNElJ8IHnzWza2qb3oZ36NwIhRFQyW+9epLUIFlw54sM+Y8ZwDrUJzEmfI8/Bzros7UByWiWiYktMz4/M9XmuQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yytufqq2QslQ8xOJevcEl3KBnDwg0L+pcogtSsdmydUgR0Cm0ku CTOZDMNe9Jw67Q5Yhw7sJeofU7mgvvv2q44yV3/HoAfVERwn1Fxs3WEH X-Gm-Gg: AeBDievGVSamvHlhTekm8z/tj7J5QAvNhyVlTRJN6iRz8cGw5H9AhDLlPMyurkAhSYC w2eamGW79nMsjO9iuJs/jF5mAmzpoRk3hC19kjIfZ+Rav8Uf2ycEXu4K9TBq+FcdUOLmQGKG8xL svSD9jEhzaPsB1kA1bJbs2GcglurRxqomOkN1q8A1pUFBRr+Wss9CRQxqYVuuFcmOP/SHo/7UTi tSxjKkuhQmDVDxb2ZwTqa0fwKUcM33qQCPl+1qOFscmmTKF0GUVbfVRIo8hCBOyKlRyihhzUmrT 5zvKI+4L0/n5+0bNhitp7DVo73yj7vshSy/nX0+Ng2bBEuc8XdMNQwoFIzkP3Wy6HePBBqlDKg6 FFDXYDfVcbYqnKJVQJDC0P+VfQZTvSa0Y6Btu6gtbHlZ1/mi4/tuC0jLJHuatmJP4KHho+R1/lw LcI3xz+kCtaSEU1kKBTwG1RlIT1El533tVCB/mcX7cjNzF29RCNn8M8Y+gr+hN+PZdZLzo/Ecjx Q== X-Received: by 2002:a17:90b:5185:b0:35a:18b1:c245 with SMTP id 98e67ed59e1d1-35e4250f241mr11933562a91.3.1776052236668; Sun, 12 Apr 2026 20:50:36 -0700 (PDT) Received: from localhost.localdomain ([2405:6580:9cc0:8700:96ae:8c3d:9c98:97d9]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35e4e2dbf47sm7030644a91.0.2026.04.12.20.50.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 20:50:36 -0700 (PDT) From: Berk Cem Goksel To: zonque@gmail.com, tiwai@suse.com, perex@perex.cz Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, andreyknvl@gmail.com, stable@vger.kernel.org, Berk Cem Goksel Subject: [PATCH v2 2/2] ALSA: caiaq: take a reference on the USB device in create_card() Date: Mon, 13 Apr 2026 06:49:41 +0300 Message-Id: <20260413034941.1131465-3-berkcgoksel@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260413034941.1131465-1-berkcgoksel@gmail.com> References: <20260413034941.1131465-1-berkcgoksel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The caiaq driver stores a pointer to the parent USB device in cdev->chip.dev but never takes a reference on it. The card's private_free callback, snd_usb_caiaq_card_free(), can run asynchronously via snd_card_free_when_closed() after the USB device has already been disconnected and freed, so any access to cdev->chip.dev in that path dereferences a freed usb_device. On top of the refcounting issue, the current card_free implementation calls usb_reset_device(cdev->chip.dev). A reset in a free callback is inappropriate: the device is going away, the call takes the device lock in a teardown context, and the reset races with the disconnect path that the callback is already cleaning up after. Take a reference on the USB device in create_card() with usb_get_dev(), drop it with usb_put_dev() in the free callback, and remove the usb_reset_device() call. Fixes: b04dcbb7f7b1 ("ALSA: caiaq: Use snd_card_free_when_closed() at disco= nnection") Cc: stable@vger.kernel.org Cc: Andrey Konovalov Signed-off-by: Berk Cem Goksel --- v2: - Correct "Fixes:" tag - Remove null check before the usb_put_dev() call in card_free() sound/usb/caiaq/device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/usb/caiaq/device.c b/sound/usb/caiaq/device.c index d52f3b9a2bac..fa734fa61052 100644 --- a/sound/usb/caiaq/device.c +++ b/sound/usb/caiaq/device.c @@ -385,7 +385,7 @@ static void card_free(struct snd_card *card) snd_usb_caiaq_input_free(cdev); #endif snd_usb_caiaq_audio_free(cdev); - usb_reset_device(cdev->chip.dev); + usb_put_dev(cdev->chip.dev); } =20 static int create_card(struct usb_device *usb_dev, @@ -411,7 +411,7 @@ static int create_card(struct usb_device *usb_dev, return err; =20 cdev =3D caiaqdev(card); - cdev->chip.dev =3D usb_dev; + cdev->chip.dev =3D usb_get_dev(usb_dev); cdev->chip.card =3D card; cdev->chip.usb_id =3D USB_ID(le16_to_cpu(usb_dev->descriptor.idVendor), le16_to_cpu(usb_dev->descriptor.idProduct)); --=20 2.34.1